date:20180509

[GitHub] yjx1045072812 opened a new issue #1769: 我自己实现了一个Container，如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?

2018-05-09 Thread GitBox

yjx1045072812 opened a new issue #1769: 
我自己实现了一个Container，如何在使用com.alibaba.dubbo.container.Main启动应用的时候传递参数进来?
URL: https://github.com/apache/incubator-dubbo/issues/1769
 
 
   我自己实现了一个Container，在里面引导启动了我的程序。现在我想借助在java -jar 
启动时传递额外参数到MyContainer以覆盖内部参数的效果


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] ningyu1 opened a new issue #1768: When the RPC protocol is HTTP, use GenericService.$invoke call error.

2018-05-09 Thread GitBox

ningyu1 opened a new issue #1768: When the RPC protocol is HTTP, use 
GenericService.$invoke call error.
URL: https://github.com/apache/incubator-dubbo/issues/1768
 
 
   ## dubbo version
   
   dubbo-2.6.1
   
   ## provider service
   
   ```
   public interface MyClassService {
   
   public String sayHello();
   
   public String sayHello(MyClassVo vo, @Min(1) long id);
   
   }
   ```
   
   ## provider config
   
   ```
   
   
   
   
   
   ```
   
   ## consumer use registry
   
   ```
   ApplicationConfig application = new ApplicationConfig();
   application.setName("DubboSample");
   ReferenceConfig reference = new ReferenceConfig();
   reference.setApplication(application);
   RegistryConfig registry = registry = new RegistryConfig();
   registry.setProtocol("zookeeper");
   registry.setAddress("192.168.0.58:2181");
   reference.setRegistry(registry);
   reference.setGeneric(true);
   GenericService genericService = (GenericService) reference.get();
   Object result = genericService.$invoke(getMethod(), new String[]{}, new 
Object[]{});
   ```
   
   ## consumer use dircet connection
   
   ```
   ApplicationConfig application = new ApplicationConfig();
   application.setName("DubboSample");
   ReferenceConfig reference = new ReferenceConfig();
   reference.setApplication(application);
   
reference.setUrl("http://192.168.6.47:8090/com.jiuyescm.dubbo.test.api.MyClassService;)
   reference.setGeneric(true);
   GenericService genericService = (GenericService) reference.get();
   Object result = genericService.$invoke(getMethod(), new String[]{}, new 
Object[]{});
   ```
   
   ## Error
   
   ```
   2018/05/10 12:20:39 ERROR - 
cn.tsoft.framework.testing.jmeter.plugin.dubbo.sample.DubboSample: 接口返回异常： 
com.alibaba.dubbo.rpc.RpcException: Failed to invoke remote service: interface 
com.alibaba.dubbo.rpc.service.GenericService, method: $invoke, cause: 
Invocation of method [public abstract java.lang.Object 
com.alibaba.dubbo.rpc.service.GenericService.$invoke(java.lang.String,java.lang.String[],java.lang.Object[])
 throws com.alibaba.dubbo.rpc.service.GenericException] failed in HTTP invoker 
remote service at 
[http://192.168.6.47:8090/com.jiuyescm.dubbo.test.api.MyClassService]; nested 
exception is java.lang.NoSuchMethodException: 
com.sun.proxy.$Proxy18.$invoke(java.lang.String, [Ljava.lang.String;, 
[Ljava.lang.Object;)
at 
com.alibaba.dubbo.rpc.protocol.AbstractProxyProtocol.getRpcException(AbstractProxyProtocol.java:119)
at 
com.alibaba.dubbo.rpc.protocol.AbstractProxyProtocol$2.doInvoke(AbstractProxyProtocol.java:99)
at 
com.alibaba.dubbo.rpc.protocol.AbstractInvoker.invoke(AbstractInvoker.java:142)
at 
com.alibaba.dubbo.rpc.filter.GenericImplFilter.invoke(GenericImplFilter.java:172)
at 
com.alibaba.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:68)
at 
com.alibaba.dubbo.rpc.protocol.dubbo.filter.FutureFilter.invoke(FutureFilter.java:53)
at 
com.alibaba.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:68)
at 
com.alibaba.dubbo.monitor.support.MonitorFilter.invoke(MonitorFilter.java:74)
at 
com.alibaba.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:68)
at 
com.alibaba.dubbo.rpc.filter.ConsumerContextFilter.invoke(ConsumerContextFilter.java:47)
at 
com.alibaba.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:68)
at 
com.alibaba.dubbo.rpc.listener.ListenerInvokerWrapper.invoke(ListenerInvokerWrapper.java:73)
at 
com.alibaba.dubbo.rpc.proxy.InvokerInvocationHandler.invoke(InvokerInvocationHandler.java:51)
at com.alibaba.dubbo.common.bytecode.proxy0.$invoke(proxy0.java)
at 
cn.tsoft.framework.testing.jmeter.plugin.dubbo.sample.DubboSample.callDubbo(DubboSample.java:463)
at 
cn.tsoft.framework.testing.jmeter.plugin.dubbo.sample.DubboSample.sample(DubboSample.java:321)
at 
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:465)
at 
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:410)
at org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:241)
at java.lang.Thread.run(Thread.java:744)
   Caused by: org.springframework.remoting.RemoteInvocationFailureException: 
Invocation of method [public abstract java.lang.Object 
com.alibaba.dubbo.rpc.service.GenericService.$invoke(java.lang.String,java.lang.String[],java.lang.Object[])
 throws com.alibaba.dubbo.rpc.service.GenericException] failed in HTTP invoker 
remote service at 
[http://192.168.6.47:8090/com.jiuyescm.dubbo.test.api.MyClassService]; nested 
exception is java.lang.NoSuchMethodException: 
com.sun.proxy.$Proxy18.$invoke(java.lang.String, [Ljava.lang.String;, 
[Ljava.lang.Object;)
at 
org.springframework.remoting.httpinvoker.HttpInvokerClientInterceptor.invoke(HttpInvokerClientInterceptor.java:158)

[GitHub] jimwarewj commented on issue #1767: 启动 dubbo-admin时报错

2018-05-09 Thread GitBox

jimwarewj commented on issue #1767: 启动 dubbo-admin时报错
URL: 
https://github.com/apache/incubator-dubbo/issues/1767#issuecomment-387946139
 
 
   解决


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] jimwarewj closed issue #1767: 启动 dubbo-admin时报错

2018-05-09 Thread GitBox

jimwarewj closed issue #1767: 启动 dubbo-admin时报错
URL: https://github.com/apache/incubator-dubbo/issues/1767
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] jimwarewj opened a new issue #1767: 启动 dubbo-admin时报错

2018-05-09 Thread GitBox

jimwarewj opened a new issue #1767: 启动 dubbo-admin时报错
URL: https://github.com/apache/incubator-dubbo/issues/1767
 
 
   什么原因呢？
   ERROR dubbo.DubboRegistry -  [DUBBO] Failed to subscribe 
consumer://127.0.0.1/com.alibaba.dubbo.registry.RegistryService?application=dubbo-admin=1=false=1=2.5.8=false=com.alibaba.dubbo.registry.RegistryService=true=lookup,unsubscribe,subscribe,unregister,register=13296=false=true=true=1=1525917740262=false,
 waiting for retry, cause: Failed to invoke the method subscribe in the service 
com.alibaba.dubbo.registry.RegistryService. Tried 3 times of the providers 
[127.0.0.1:2181] (1/1) from the registry 127.0.0.1:2181 on the consumer 
127.0.0.1 using the dubbo version 2.5.8. Last error is: Invoke remote method 
timeout. method: subscribe, provider: 
dubbo://127.0.0.1:2181/com.alibaba.dubbo.registry.RegistryService?application=dubbo-admin=1=false=1=2.5.8=false=com.alibaba.dubbo.registry.RegistryService=true=lookup,unsubscribe,subscribe,unregister,register=13296=false=1525917740262=true=true=1=1525917740262=false,
 cause: Waiting server-side response timeout by scan timer. start time: 
2018-05-10 10:02:42.834, end time: 2018-05-10 10:02:52.839, client elapsed: 80 
ms, server elapsed: 9922 ms, timeout: 1 ms, request: Request [id=4, 
version=2.0.0, twoway=true, event=false, broken=false, data=RpcInvocation 
[methodName=subscribe, parameterTypes=[class com.alibaba.dubbo.common.URL, 
interface com.alibaba.dubbo.registry.NotifyListener], 
arguments=[consumer://127.0.0.1/com.alibaba.dubbo.registry.RegistryService?application=dubbo-admin=1=false=1=2.5.8=false=com.alibaba.dubbo.registry.RegistryService=true=lookup,unsubscribe,subscribe,unregister,register=13296=false=true=true=1=1525917740262=false,
 com.alibaba.dubbo.registry.integration.RegistryDirectory@6552c628], 
attachments={path=com.alibaba.dubbo.registry.RegistryService, 
sys_callback_arg-1=1699923496, 
interface=com.alibaba.dubbo.registry.RegistryService, version=0.0.0, 
timeout=1}]], channel: 127.0.0.1:0 -> 127.0.0.1/10.6.217.103:2181, dubbo 
version: 2.5.8, current host: 127.0.0.1
   com.alibaba.dubbo.rpc.RpcException: Failed to invoke the method subscribe in 
the service com.alibaba.dubbo.registry.RegistryService. Tried 3 times of the 
providers [127.0.0.1:2181] (1/1) from the registry 127.0.0.1:2181 on the 
consumer 127.0.0.1 using the dubbo version 2.5.8. Last error is: Invoke remote 
method timeout. method: subscribe, provider: 
dubbo://127.0.0.1:2181/com.alibaba.dubbo.registry.RegistryService?application=dubbo-admin=1=false=1=2.5.8=false=com.alibaba.dubbo.registry.RegistryService=true=lookup,unsubscribe,subscribe,unregister,register=13296=false=1525917740262=true=true=1=1525917740262=false,
 cause: Waiting server-side response timeout by scan timer. start time: 
2018-05-10 10:02:42.834, end time: 2018-05-10 10:02:52.839, client elapsed: 80 
ms, server elapsed: 9922 ms, timeout: 1 ms, request: Request [id=4, 
version=2.0.0, twoway=true, event=false, broken=false, data=RpcInvocation 
[methodName=subscribe, parameterTypes=[class com.alibaba.dubbo.common.URL, 
interface com.alibaba.dubbo.registry.NotifyListener], 
arguments=[consumer://127.0.0.1/com.alibaba.dubbo.registry.RegistryService?application=dubbo-admin=1=false=1=2.5.8=false=com.alibaba.dubbo.registry.RegistryService=true=lookup,unsubscribe,subscribe,unregister,register=13296=false=true=true=1=1525917740262=false,
 com.alibaba.dubbo.registry.integration.RegistryDirectory@6552c628], 
attachments={path=com.alibaba.dubbo.registry.RegistryService, 
sys_callback_arg-1=1699923496, 
interface=com.alibaba.dubbo.registry.RegistryService, version=0.0.0, 
timeout=1}]], channel: 127.0.0.1:0 -> 127.0.0.1/127.0.0.1:2181
at 
com.alibaba.dubbo.rpc.cluster.support.FailoverClusterInvoker.doInvoke(FailoverClusterInvoker.java:108)
at 
com.alibaba.dubbo.rpc.cluster.support.AbstractClusterInvoker.invoke(AbstractClusterInvoker.java:229)
at 
com.alibaba.dubbo.rpc.cluster.support.wrapper.MockClusterInvoker.invoke(MockClusterInvoker.java:72)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] piglingcn opened a new issue #130: 用了springboot+dubbo之后，事务怎么处理，官方没一个例子吗

2018-05-09 Thread GitBox

piglingcn opened a new issue #130: 用了springboot+dubbo之后，事务怎么处理，官方没一个例子吗
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/130
 
 
   用了springboot+dubbo之后，事务怎么处理，官方没一个例子吗


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] jimwarewj commented on issue #1765: 使用@Reference注解，如果对应服务没有实例，报错之后这个对象一直为空

2018-05-09 Thread GitBox

jimwarewj commented on issue #1765: 使用@Reference注解，如果对应服务没有实例，报错之后这个对象一直为空
URL: 
https://github.com/apache/incubator-dubbo/issues/1765#issuecomment-387944108
 
 
   我猜应该是没有配置


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] mascothaojun opened a new issue #1766: 请问有2.6.1配置kryo+curator的例子吗？

2018-05-09 Thread GitBox

mascothaojun opened a new issue #1766: 请问有2.6.1配置kryo+curator的例子吗？
URL: https://github.com/apache/incubator-dubbo/issues/1766
 
 
   
升级到2.6.1后，使用kryo+curator的组合，原来的项目就不能正常使用了，如果用2.5.10+hessian是没问题的，但是hessian不支持文件上传的，对于文件流之间的传输就出现了问题


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true

2018-05-09 Thread GitBox

ma-xiao-guang-64 commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-387940785
 
 
   @ralf0131Thank, if a thread does not respond to the interrupt signal, 
newThreadToCloseExecutor will work to wait thread finished.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] ralf0131 commented on issue #27: Enable rest and serialization documentation

2018-05-09 Thread GitBox

ralf0131 commented on issue #27: Enable rest and serialization documentation
URL: 
https://github.com/apache/incubator-dubbo-docs/issues/27#issuecomment-387936918
 
 
   Ok, I will follow that process.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] willlau0524 commented on issue #1765: 使用@Reference注解，如果对应服务没有实例，报错之后这个对象一直为空

2018-05-09 Thread GitBox

willlau0524 commented on issue #1765: 使用@Reference注解，如果对应服务没有实例，报错之后这个对象一直为空
URL: 
https://github.com/apache/incubator-dubbo/issues/1765#issuecomment-38792
 
 
   异常栈：
   java.lang.reflect.InvocationTargetException: null
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_131]
   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_131]
   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_131]
   at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131]
   at 
com.alibaba.dubbo.config.AbstractConfig.toString(AbstractConfig.java:473) 
[dubbo-2.5.8.jar:2.5.8]
   at java.lang.String.valueOf(String.java:2994) [?:1.8.0_131]
   at java.lang.StringBuilder.append(StringBuilder.java:131) 
[?:1.8.0_131]
   at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.AbstractAnnotationConfigBeanBuilder.build(AbstractAnnotationConfigBeanBuilder.java:61)
 [dubbo-2.5.8.jar:2.5.8]
   at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.buildReferenceBean(ReferenceAnnotationBeanPostProcessor.java:318)
 [dubbo-2.5.8.jar:2.5.8]
   at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.access$100(ReferenceAnnotationBeanPostProcessor.java:45)
 [dubbo-2.5.8.jar:2.5.8]
   at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor$ReferenceFieldElement.inject(ReferenceAnnotationBeanPostProcessor.java:296)
 [dubbo-2.5.8.jar:2.5.8]
   at 
org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:88)
 [spring-beans-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.postProcessPropertyValues(ReferenceAnnotationBeanPostProcessor.java:72)
 [dubbo-2.5.8.jar:2.5.8]
   at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1264)
 [spring-beans-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:553)
 [spring-beans-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:483)
 [spring-beans-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306)
 [spring-beans-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
 [spring-beans-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
 [spring-beans-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
 [spring-beans-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:761)
 [spring-beans-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:867)
 [spring-context-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:543)
 [spring-context-4.3.12.RELEASE.jar:4.3.12.RELEASE]
   at 
org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:122)
 [spring-boot-1.5.8.RELEASE.jar:1.5.8.RELEASE]
   at 
org.springframework.boot.SpringApplication.refresh(SpringApplication.java:693) 
[spring-boot-1.5.8.RELEASE.jar:1.5.8.RELEASE]
   at 
org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:360)
 [spring-boot-1.5.8.RELEASE.jar:1.5.8.RELEASE]
   at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:303) 
[spring-boot-1.5.8.RELEASE.jar:1.5.8.RELEASE]
   at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1118) 
[spring-boot-1.5.8.RELEASE.jar:1.5.8.RELEASE]
   at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1107) 
[spring-boot-1.5.8.RELEASE.jar:1.5.8.RELEASE]


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific

[GitHub] willlau0524 opened a new issue #1765: 使用@Reference注解，如果对应服务没有实例，报错之后这个对象一直为空

2018-05-09 Thread GitBox

willlau0524 opened a new issue #1765: 使用@Reference注解，如果对应服务没有实例，报错之后这个对象一直为空
URL: https://github.com/apache/incubator-dubbo/issues/1765
 
 
   最近服务上线的时候发现，使用@Reference 注解去引用某个服务，如果这个服务没有实例在zk，那么会抛出一个 
IllegalStateException， 信息是 No provider available for the service  。 
此时使用这个注解修饰的对象会置为空，那么后续就算有实例上线注册到zk了，运行到使用这个对象的代码的时候会报空指针。
   只有在引用服务有实例的时候重启，这样这个引用对象才会正确构建，不知道是故意这么设计的还是一个bug?  经过测试，使用API构建 
ReferenceConfig 没有这个问题


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] tumao2 opened a new issue #129: @Reference注解中url可以配置到application.properties中么

2018-05-09 Thread GitBox

tumao2 opened a new issue #129: @Reference注解中url可以配置到application.properties中么
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/129
 
 
   @Reference(version = "1.0.0", application = "${dubbo.application.id}", url = 
"dubbo://localhost:20880")
   可以写成这样么
   @Reference(version = "1.0.0", application = "${dubbo.application.id}", url = 
"${dubbo.rpc.test.url}")
   在配置文件application.properties中配置
   dubbo.rpc.test.url=dubbo://localhost:20880
   我像这样写，好像不行，有解决方法么


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] JoeCao opened a new issue #16: The repository url in README has changed

2018-05-09 Thread GitBox

JoeCao opened a new issue #16: The repository url in README has changed 
URL: https://github.com/apache/incubator-dubbo-rpc-jsonrpc/issues/16
 
 
   dubbo-client-py and dubbo nodejs repository has been moved in dubbo 
organization.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] beiwei30 closed pull request #1746: [Dubbo-1744] Enable tcp no delay for netty 3 server implementation

2018-05-09 Thread GitBox

beiwei30 closed pull request #1746: [Dubbo-1744] Enable tcp no delay for netty 
3 server implementation
URL: https://github.com/apache/incubator-dubbo/pull/1746
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java
 
b/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java
index d08ff257f2..0d1103b426 100644
--- 
a/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java
+++ 
b/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java
@@ -74,6 +74,7 @@ protected void doOpen() throws Throwable {
 // https://issues.jboss.org/browse/NETTY-365
 // https://issues.jboss.org/browse/NETTY-379
 // final Timer timer = new HashedWheelTimer(new 
NamedThreadFactory("NettyIdleTimer", true));
+bootstrap.setOption("child.tcpNoDelay", true);
 bootstrap.setPipelineFactory(new ChannelPipelineFactory() {
 public ChannelPipeline getPipeline() {
 NettyCodecAdapter adapter = new NettyCodecAdapter(getCodec(), 
getUrl(), NettyServer.this);
@@ -153,4 +154,4 @@ public boolean isBound() {
 return channel.isBound();
 }
 
-}
\ No newline at end of file
+}


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] justinmclean commented on issue #27: Enable rest and serialization documentation

2018-05-09 Thread GitBox

justinmclean commented on issue #27: Enable rest and serialization documentation
URL: 
https://github.com/apache/incubator-dubbo-docs/issues/27#issuecomment-387696290
 
 
   Hi,
   > Yes. A software grant has been filed.
   > 
   Great! Just not obvious from the name and perhaps the process has not been 
correct followed as I don’t see it listed here:
   http://incubator.apache.org/ip-clearance/
   
   It may just need to be updated and/or lazy consensus of IP clearance asked 
on the incubator list. [1]
   
   Thanks,
   Justin
   
   1. http://apache.org/foundation/how-it-works/legal.html#incoming-code


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] codecov-io commented on issue #1764: Remove unnecessary null check.

2018-05-09 Thread GitBox

codecov-io commented on issue #1764: Remove unnecessary null check.
URL: https://github.com/apache/incubator-dubbo/pull/1764#issuecomment-387691253
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=h1) 
Report
   > Merging 
[#1764](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/6ec0225cfa9b45c8349d19019f965d5c52d40a09?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/graphs/tree.svg?height=150=VnEIkiFQT0=650=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#1764  +/-   ##
   
   - Coverage 37.93%   37.93%   -0.01% 
   + Complexity 4023 4022   -1 
   
 Files   618  618  
 Lines 2972729728   +1 
 Branches   5241 5241  
   
   - Hits  1127811277   -1 
   - Misses1660816611   +3 
   + Partials   1841 1840   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==)
 | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=footer).
 Last update 
[6ec0225...3d4edd1](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] beiwei30 closed pull request #1758: Config api unit test

2018-05-09 Thread GitBox

beiwei30 closed pull request #1758: Config api unit test
URL: https://github.com/apache/incubator-dubbo/pull/1758
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ArgumentConfig.java
 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ArgumentConfig.java
index 61fff8defc..e752726a0c 100644
--- 
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ArgumentConfig.java
+++ 
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ArgumentConfig.java
@@ -27,7 +27,7 @@
 
 private static final long serialVersionUID = -2165482463925213595L;
 
-//arugment index -1 represents not set
+//argument: index -1 represents not set
 private Integer index = -1;
 
 //argument type
diff --git 
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ApplicationConfigTest.java
 
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ApplicationConfigTest.java
new file mode 100644
index 00..f60bb85698
--- /dev/null
+++ 
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ApplicationConfigTest.java
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.config;
+
+import com.alibaba.dubbo.common.Constants;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.hamcrest.Matchers.contains;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.hasEntry;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.sameInstance;
+import static org.hamcrest.collection.IsCollectionWithSize.hasSize;
+import static org.junit.Assert.assertThat;
+
+public class ApplicationConfigTest {
+@Test
+public void testName() throws Exception {
+ApplicationConfig application = new ApplicationConfig();
+application.setName("app");
+assertThat(application.getName(), equalTo("app"));
+application = new ApplicationConfig("app2");
+assertThat(application.getName(), equalTo("app2"));
+Map parameters = new HashMap();
+ApplicationConfig.appendParameters(parameters, application);
+assertThat(parameters, hasEntry(Constants.APPLICATION_KEY, "app2"));
+}
+
+@Test
+public void testVersion() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setVersion("1.0.0");
+assertThat(application.getVersion(), equalTo("1.0.0"));
+Map parameters = new HashMap();
+ApplicationConfig.appendParameters(parameters, application);
+assertThat(parameters, hasEntry("application.version", "1.0.0"));
+}
+
+@Test
+public void testOwner() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setOwner("owner");
+assertThat(application.getOwner(), equalTo("owner"));
+}
+
+@Test
+public void testOrganization() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setOrganization("org");
+assertThat(application.getOrganization(), equalTo("org"));
+}
+
+@Test
+public void testArchitecture() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setArchitecture("arch");
+assertThat(application.getArchitecture(), equalTo("arch"));
+}
+
+@Test
+public void testEnvironment1() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setEnvironment("develop");
+assertThat(application.getEnvironment(), equalTo("develop"));
+application.setEnvironment("test");
+assertThat(application.getEnvironment(),

[GitHub] codecov-io commented on issue #1762: Remove unnecessary null check.

2018-05-09 Thread GitBox

codecov-io commented on issue #1762:  Remove unnecessary null check.
URL: https://github.com/apache/incubator-dubbo/pull/1762#issuecomment-387686777
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=h1) 
Report
   > Merging 
[#1762](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/6ec0225cfa9b45c8349d19019f965d5c52d40a09?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/graphs/tree.svg?width=650=pr=VnEIkiFQT0=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#1762  +/-   ##
   
   - Coverage 37.93%   37.92%   -0.02% 
 Complexity 4023 4023  
   
 Files   618  618  
 Lines 2972729738  +11 
 Branches   5241 5241  
   
 Hits  1127811278  
   - Misses1660816619  +11 
 Partials   1841 1841
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
   | 
[...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==)
 | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | |
   | 
[...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==)
 | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `76.63% <0%> (+1.86%)` | `7% <0%> (ø)` | :arrow_down: |
   | 
[...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==)
 | `70.9% <0%> (+3.63%)` | `9% <0%> (+1%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=footer).
 Last update 
[6ec0225...a42fa2d](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] codecov-io commented on issue #1758: Config api unit test

2018-05-09 Thread GitBox

codecov-io commented on issue #1758: Config api unit test
URL: https://github.com/apache/incubator-dubbo/pull/1758#issuecomment-387686585
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1758?src=pr=h1) 
Report
   > Merging 
[#1758](https://codecov.io/gh/apache/incubator-dubbo/pull/1758?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/0592e84a3c07b4451e81d2eecc0c51af384858d2?src=pr=desc)
 will **increase** coverage by `0.81%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/graphs/tree.svg?width=650=150=pr=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1758?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#1758  +/-   ##
   
   + Coverage 37.94%   38.75%   +0.81% 
   - Complexity 4028 4140 +112 
   
 Files   618  618  
 Lines 2973029727   -3 
 Branches   5244 5241   -3 
   
   + Hits  1128011522 +242 
   + Misses1660916362 -247 
   - Partials   1841 1843   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1758?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../java/com/alibaba/dubbo/config/ArgumentConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQXJndW1lbnRDb25maWcuamF2YQ==)
 | `100% <ø> (+100%)` | `7 <0> (+7)` | :arrow_up: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
   | 
[...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==)
 | `37.5% <0%> (-4.17%)` | `3% <0%> (ø)` | |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `81.08% <0%> (-0.09%)` | `80% <0%> (ø)` | |
   | 
[...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh)
 | `39.81% <0%> (+0.46%)` | `43% <0%> (+1%)` | :arrow_up: |
   | 
[.../java/com/alibaba/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==)
 | `71.83% <0%> (+0.7%)` | `115% <0%> (+1%)` | :arrow_up: |
   | 
[...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=)
 | `48.7% <0%> (+0.73%)` | `37% <0%> (+1%)` | :arrow_up: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `76.63% <0%> (+1.86%)` | `7% <0%> (ø)` | :arrow_down: |
   | 
[...bo/rpc/cluster/support/AbstractClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3N1cHBvcnQvQWJzdHJhY3RDbHVzdGVySW52b2tlci5qYXZh)
 | `70.58% <0%> (+3.28%)` | `41% <0%> (-1%)` | :arrow_down: |
   | ... and [8 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1758/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1758?src=pr=continue).
   > **Legend** -

[GitHub] liaozan opened a new pull request #1764: Remove unnecessary null check.

2018-05-09 Thread GitBox

liaozan opened a new pull request #1764: Remove unnecessary null check.
URL: https://github.com/apache/incubator-dubbo/pull/1764
 
 
   Remove unnecessary null check.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] liaozan closed pull request #1762: Remove unnecessary null check.

2018-05-09 Thread GitBox

liaozan closed pull request #1762:  Remove unnecessary null check.
URL: https://github.com/apache/incubator-dubbo/pull/1762
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/AnnotationBean.java
 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/AnnotationBean.java
index bbb75d9efd..6c59ffc2d4 100644
--- 
a/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/AnnotationBean.java
+++ 
b/dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/AnnotationBean.java
@@ -89,28 +89,28 @@ public void 
postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory)
 if (annotationPackage == null || annotationPackage.length() == 0) {
 return;
 }
-if (beanFactory instanceof BeanDefinitionRegistry) {
-try {
-// init scanner
-Class scannerClass = 
ReflectUtils.forName("org.springframework.context.annotation.ClassPathBeanDefinitionScanner");
-Object scanner = scannerClass.getConstructor(new 
Class[]{BeanDefinitionRegistry.class, boolean.class}).newInstance(new 
Object[]{(BeanDefinitionRegistry) beanFactory, true});
-// add filter
-Class filterClass = 
ReflectUtils.forName("org.springframework.core.type.filter.AnnotationTypeFilter");
-Object filter = 
filterClass.getConstructor(Class.class).newInstance(Service.class);
-Method addIncludeFilter = 
scannerClass.getMethod("addIncludeFilter", 
ReflectUtils.forName("org.springframework.core.type.filter.TypeFilter"));
-addIncludeFilter.invoke(scanner, filter);
-// scan packages
-String[] packages = 
Constants.COMMA_SPLIT_PATTERN.split(annotationPackage);
-Method scan = scannerClass.getMethod("scan", new 
Class[]{String[].class});
-scan.invoke(scanner, new Object[]{packages});
-} catch (Throwable e) {
-// spring 2.0
-}
+   if (beanFactory instanceof BeanDefinitionRegistry) {
+   try {
+   // init scanner
+   Class scannerClass = 
ReflectUtils.forName("org.springframework.context.annotation.ClassPathBeanDefinitionScanner");
+   Object scanner = scannerClass.getConstructor(new 
Class[]{BeanDefinitionRegistry.class, boolean.class}).newInstance(new 
Object[]{(BeanDefinitionRegistry) beanFactory, true});
+   // add filter
+   Class filterClass = 
ReflectUtils.forName("org.springframework.core.type.filter.AnnotationTypeFilter");
+   Object filter = 
filterClass.getConstructor(Class.class).newInstance(Service.class);
+   Method addIncludeFilter = 
scannerClass.getMethod("addIncludeFilter", 
ReflectUtils.forName("org.springframework.core.type.filter.TypeFilter"));
+   addIncludeFilter.invoke(scanner, filter);
+   // scan packages
+   String[] packages = 
Constants.COMMA_SPLIT_PATTERN.split(annotationPackage);
+   Method scan = scannerClass.getMethod("scan", new 
Class[]{String[].class});
+   scan.invoke(scanner, new Object[]{packages});
+   } catch (Throwable e) {
+   // spring 2.0
+   }
 }
 }
 
 @Override
-public void destroy() throws Exception {
+public void destroy() {
 
 //  This will only be called for singleton scope bean, and expected to 
be called by spring shutdown hook when BeanFactory/ApplicationContext destroys.
 //  We will guarantee dubbo related resources being released with 
dubbo shutdown hook.
@@ -152,37 +152,42 @@ public Object postProcessAfterInitialization(Object bean, 
String beanName)
 }
 if (applicationContext != null) {
 serviceConfig.setApplicationContext(applicationContext);
-if (service.registry() != null && service.registry().length > 
0) {
+   service.registry();
+   if (service.registry().length > 0) {
 List registryConfigs = new 
ArrayList();
 for (String registryId : service.registry()) {
 if (registryId != null && registryId.length() > 0) {
-registryConfigs.add((RegistryConfig) 
applicationContext.getBean(registryId, RegistryConfig.class));
+

[GitHub] ralf0131 commented on issue #27: Enable rest and serialization documentation

2018-05-09 Thread GitBox

ralf0131 commented on issue #27: Enable rest and serialization documentation
URL: 
https://github.com/apache/incubator-dubbo-docs/issues/27#issuecomment-387670128
 
 
   Yes. A software grant has been filed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] justinmclean commented on issue #27: Enable rest and serialization documentation

2018-05-09 Thread GitBox

justinmclean commented on issue #27: Enable rest and serialization documentation
URL: 
https://github.com/apache/incubator-dubbo-docs/issues/27#issuecomment-387665233
 
 
   Hi,
   > Dangdang has donated 
 their documentation 
about rest and serialization.
   > 
   > Need to cleanup some of the contents and enable them on dubbo.apache.org
   > 
   
   Has this come in to Apache via a software grant?
   
   Thanks,
   Justin


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] ChoingHyun opened a new issue #29: 启动报错：Exception in thread "main" java.lang.NoClassDefFoundError: javax/servlet/FilterChain

2018-05-09 Thread GitBox

ChoingHyun opened a new issue #29: 启动报错：Exception in thread "main" 
java.lang.NoClassDefFoundError: javax/servlet/FilterChain
URL: https://github.com/apache/incubator-dubbo-ops/issues/29
 
 
   `Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=128m; 
support was removed in 8.0
   Java HotSpot(TM) 64-Bit Server VM warning: UseCMSCompactAtFullCollection is 
deprecated and will likely be removed in a future release.
INFO logger.LoggerFactory - using logger: 
com.alibaba.dubbo.common.logger.log4j.Log4jLoggerAdapter
INFO container.Main -  [DUBBO] Use container type([log4j, spring, registry, 
jetty]) to run dubbo serivce., dubbo version: 2.6.0, current host: 127.0.0.1
   Exception in thread "main" java.lang.NoClassDefFoundError: 
javax/servlet/FilterChain
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at 
com.alibaba.dubbo.container.jetty.JettyContainer.start(JettyContainer.java:56)
at com.alibaba.dubbo.container.Main.main(Main.java:85)
   Caused by: java.lang.ClassNotFoundException: javax.servlet.FilterChain
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 14 more
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] ChoingHyun commented on issue #26: 启东时没有按照配置的zookeeper找注册中心

2018-05-09 Thread GitBox

ChoingHyun commented on issue #26: 启东时没有按照配置的zookeeper找注册中心
URL: 
https://github.com/apache/incubator-dubbo-ops/issues/26#issuecomment-387656491
 
 
   遇到同样问题


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] codecov-io commented on issue #1760: add Locale serialize support

2018-05-09 Thread GitBox

codecov-io commented on issue #1760: add Locale serialize support
URL: https://github.com/apache/incubator-dubbo/pull/1760#issuecomment-387651639
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1760?src=pr=h1) 
Report
   > Merging 
[#1760](https://codecov.io/gh/apache/incubator-dubbo/pull/1760?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/63a2569a4c7e7545c5e6863047dfa31b932001c2?src=pr=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1760/graphs/tree.svg?width=650=pr=VnEIkiFQT0=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1760?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#1760  +/-   ##
   
   - Coverage 37.95%   37.93%   -0.03% 
   + Complexity 4026 4022   -4 
   
 Files   618  618  
 Lines 2972829728  
 Branches   5242 5242  
   
   - Hits  1128311277   -6 
   - Misses1660716609   +2 
   - Partials   1838 1842   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1760?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1760/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
   | 
[...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1760/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==)
 | `67.27% <0%> (-3.64%)` | `8% <0%> (-1%)` | |
   | 
[...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1760/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==)
 | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1760?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1760?src=pr=footer).
 Last update 
[63a2569...e27d8d7](https://codecov.io/gh/apache/incubator-dubbo/pull/1760?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] ralf0131 opened a new issue #27: Enable rest and serialization documentation

2018-05-09 Thread GitBox

ralf0131 opened a new issue #27: Enable rest and serialization documentation
URL: https://github.com/apache/incubator-dubbo-docs/issues/27
 
 
   Dangdang has 
[donated](https://github.com/apache/incubator-dubbo-docs/pull/14) their 
documentation about rest and serialization. 
   
   Need to cleanup some of the contents and enable them on dubbo.apache.org


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] nzomkxia opened a new pull request #1760: add Locale serialize support

2018-05-09 Thread GitBox

nzomkxia opened a new pull request #1760: add Locale serialize 
support
URL: https://github.com/apache/incubator-dubbo/pull/1760
 
 
   ## What is the purpose of the change
   
   fix #906 and add deserialize support
   ## Brief changelog
   
   X
   
   ## Verifying this change
   
   X
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a 
[GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the 
change (usually before you start working on it). Trivial changes like typos do 
not require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException 
when host config not exist #XXX`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile 
failsafe:integration-test` to make sure unit-test and integration-test pass.
   - [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] diecui1202 commented on issue #1759: fix #934 #1756 use loadBalance policy to choose invoke when providers less 2

2018-05-09 Thread GitBox

diecui1202 commented on issue #1759: fix #934 #1756 use loadBalance policy to 
choose invoke when providers less 2
URL: https://github.com/apache/incubator-dubbo/pull/1759#issuecomment-387640024
 
 
   That's cool. Thanks a lot.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] diecui1202 commented on a change in pull request #1144: [Dubbo-#1123] Fix several problems in ConsistentHashLoadBalance

2018-05-09 Thread GitBox

diecui1202 commented on a change in pull request #1144: [Dubbo-#1123] Fix 
several problems in ConsistentHashLoadBalance
URL: https://github.com/apache/incubator-dubbo/pull/1144#discussion_r186946594
 
 

 ##
 File path: 
dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/loadbalance/LoadBalanceTest.java
 ##
 @@ -200,5 +200,33 @@ public void testLoadBalanceWarmup() {
 Assert.assertEquals(100, AbstractLoadBalance
 .calculateWarmupWeight(20 * 60 * 1000, Constants.DEFAULT_WARMUP, 
Constants.DEFAULT_WEIGHT));
 }
+
+public Invocation createInvocation(int i) {
+   Invocation invocation = EasyMock.createMock(Invocation.class);
+   
EasyMock.expect(invocation.getMethodName()).andReturn("method").anyTimes();
 
 Review comment:
   Could you post a new PR while our test framework has changed to Mockito from 
EasyMock ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] ralf0131 commented on issue #1759: fix #934 #1756 use loadBalance policy to choose invoke when providers less 2

2018-05-09 Thread GitBox

ralf0131 commented on issue #1759: fix #934 #1756 use loadBalance policy to 
choose invoke when providers less 2
URL: https://github.com/apache/incubator-dubbo/pull/1759#issuecomment-387638346
 
 
   Sorry for mistakenly closing the pull request, it has been merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] ralf0131 closed pull request #1759: fix #934 #1756 use loadBalance policy to choose invoke when providers less 2

2018-05-09 Thread GitBox

ralf0131 closed pull request #1759: fix #934 #1756 use loadBalance policy to 
choose invoke when providers less 2
URL: https://github.com/apache/incubator-dubbo/pull/1759
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvoker.java
 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvoker.java
index 68ed406f9c..0a3e0a5120 100644
--- 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvoker.java
+++ 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvoker.java
@@ -136,10 +136,6 @@ public void destroy() {
 return null;
 if (invokers.size() == 1)
 return invokers.get(0);
-// If we only have two invokers, use round-robin instead.
-if (invokers.size() == 2 && selected != null && !selected.isEmpty()) {
-return selected.get(0) == invokers.get(0) ? invokers.get(1) : 
invokers.get(0);
-}
 if (loadbalance == null) {
 loadbalance = 
ExtensionLoader.getExtensionLoader(LoadBalance.class).getExtension(Constants.DEFAULT_LOADBALANCE);
 }
@@ -157,7 +153,7 @@ public void destroy() {
 int index = invokers.indexOf(invoker);
 try {
 //Avoid collision
-invoker = index < invokers.size() - 1 ? 
invokers.get(index + 1) : invoker;
+invoker = index < invokers.size() - 1 ? 
invokers.get(index + 1) : invokers.get(0);
 } catch (Exception e) {
 logger.warn(e.getMessage() + " may because invokers 
list dynamic change, ignore.", e);
 }
diff --git 
a/dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
 
b/dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
index cdfcdcf883..611683ce00 100644
--- 
a/dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
+++ 
b/dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
@@ -37,6 +37,7 @@
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
+import org.mockito.Mockito;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -156,19 +157,19 @@ public void testSelect_Invokersize1() throws Exception {
 @Test
 public void testSelect_Invokersize2AndselectNotNull() throws Exception {
 invokers.clear();
-invokers.add(invoker1);
 invokers.add(invoker2);
+invokers.add(invoker4);
 {
 selectedInvokers.clear();
-selectedInvokers.add(invoker1);
-Invoker invoker = cluster.select(null, null, invokers, 
selectedInvokers);
+selectedInvokers.add(invoker4);
+Invoker invoker = cluster.select(null, invocation, invokers, 
selectedInvokers);
 Assert.assertEquals(invoker2, invoker);
 }
 {
 selectedInvokers.clear();
 selectedInvokers.add(invoker2);
-Invoker invoker = cluster.select(null, null, invokers, 
selectedInvokers);
-Assert.assertEquals(invoker1, invoker);
+Invoker invoker = cluster.select(null, invocation, invokers, 
selectedInvokers);
+Assert.assertEquals(invoker4, invoker);
 }
 }
 
@@ -322,18 +323,24 @@ public void testSelect_multiInvokers(String lbname) 
throws Exception {
 for (int i = 0; i < runs; i++) {
 Invoker sinvoker = cluster.select(lb, invocation, invokers, 
selectedInvokers);
 Assert.assertEquals(true, sinvoker.isAvailable());
+
+Mockito.clearInvocations(invoker1, invoker2, invoker3, invoker4, 
invoker5);
 }
 for (int i = 0; i < runs; i++) {
 selectedInvokers.clear();
 selectedInvokers.add(invoker1);
 Invoker sinvoker = cluster.select(lb, invocation, invokers, 
selectedInvokers);
 Assert.assertEquals(true, sinvoker.isAvailable());
+
+Mockito.clearInvocations(invoker1, invoker2, invoker3, invoker4, 
invoker5);
 }
 for (int i = 0; i < runs; i++) {
 selectedInvokers.clear();
 selectedInvokers.add(invoker2);
 Invoker sinvoker = cluster.select(lb, invocation, invokers, 
selectedInvokers);
 Assert.assertEquals(true, sinvoker.isAvailable());
+
+Mockito.clearInvocations(invoker1, invoker2, invoker3, invoker4, 
invoker5);
 }
 for (int i = 0; i < runs; i++) {

[GitHub] ralf0131 closed issue #1756: AbstractClusterInvokerTest throws OutOfMemoryError

2018-05-09 Thread GitBox

ralf0131 closed issue #1756: AbstractClusterInvokerTest throws OutOfMemoryError
URL: https://github.com/apache/incubator-dubbo/issues/1756
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] diecui1202 opened a new pull request #1759: fix #934 #1756 use loadBalance policy to choose invoke when providers less 2

2018-05-09 Thread GitBox

diecui1202 opened a new pull request #1759: fix #934 #1756 use loadBalance 
policy to choose invoke when providers less 2
URL: https://github.com/apache/incubator-dubbo/pull/1759
 
 
   ## What is the purpose of the change
   
   1. Use loadBalance policy when providers less 2
   2. Fix AbstractClusterInvokerTest OutOfMemoryError
   
   ## Brief changelog
   
   1. Remove the following code fragment in AbstractClusterInvoker.java :
   ```java
   -// If we only have two invokers, use round-robin instead.
   -if (invokers.size() == 2 && selected != null && 
!selected.isEmpty()) {
   -return selected.get(0) == invokers.get(0) ? invokers.get(1) : 
invokers.get(0);
   -}
   ```
   2. Add clear invocation operation after invoking in 
AbstractClusterInvokerTest.java : 
   ```
   Mockito.clearInvocations(invoker1, invoker2, invoker3, invoker4, invoker5);
   ```
   
   ## Verifying this change
   
   All test cases are pass.
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a 
[GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the 
change (usually before you start working on it). Trivial changes like typos do 
not require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException 
when host config not exist #XXX`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile 
failsafe:integration-test` to make sure unit-test and integration-test pass.
   - [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] ralf0131 closed pull request #1759: fix #934 #1756 use loadBalance policy to choose invoke when providers less 2

2018-05-09 Thread GitBox

ralf0131 closed pull request #1759: fix #934 #1756 use loadBalance policy to 
choose invoke when providers less 2
URL: https://github.com/apache/incubator-dubbo/pull/1759
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvoker.java
 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvoker.java
index 68ed406f9c..0a3e0a5120 100644
--- 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvoker.java
+++ 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvoker.java
@@ -136,10 +136,6 @@ public void destroy() {
 return null;
 if (invokers.size() == 1)
 return invokers.get(0);
-// If we only have two invokers, use round-robin instead.
-if (invokers.size() == 2 && selected != null && !selected.isEmpty()) {
-return selected.get(0) == invokers.get(0) ? invokers.get(1) : 
invokers.get(0);
-}
 if (loadbalance == null) {
 loadbalance = 
ExtensionLoader.getExtensionLoader(LoadBalance.class).getExtension(Constants.DEFAULT_LOADBALANCE);
 }
@@ -157,7 +153,7 @@ public void destroy() {
 int index = invokers.indexOf(invoker);
 try {
 //Avoid collision
-invoker = index < invokers.size() - 1 ? 
invokers.get(index + 1) : invoker;
+invoker = index < invokers.size() - 1 ? 
invokers.get(index + 1) : invokers.get(0);
 } catch (Exception e) {
 logger.warn(e.getMessage() + " may because invokers 
list dynamic change, ignore.", e);
 }
diff --git 
a/dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
 
b/dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
index cdfcdcf883..611683ce00 100644
--- 
a/dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
+++ 
b/dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
@@ -37,6 +37,7 @@
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
+import org.mockito.Mockito;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -156,19 +157,19 @@ public void testSelect_Invokersize1() throws Exception {
 @Test
 public void testSelect_Invokersize2AndselectNotNull() throws Exception {
 invokers.clear();
-invokers.add(invoker1);
 invokers.add(invoker2);
+invokers.add(invoker4);
 {
 selectedInvokers.clear();
-selectedInvokers.add(invoker1);
-Invoker invoker = cluster.select(null, null, invokers, 
selectedInvokers);
+selectedInvokers.add(invoker4);
+Invoker invoker = cluster.select(null, invocation, invokers, 
selectedInvokers);
 Assert.assertEquals(invoker2, invoker);
 }
 {
 selectedInvokers.clear();
 selectedInvokers.add(invoker2);
-Invoker invoker = cluster.select(null, null, invokers, 
selectedInvokers);
-Assert.assertEquals(invoker1, invoker);
+Invoker invoker = cluster.select(null, invocation, invokers, 
selectedInvokers);
+Assert.assertEquals(invoker4, invoker);
 }
 }
 
@@ -322,18 +323,24 @@ public void testSelect_multiInvokers(String lbname) 
throws Exception {
 for (int i = 0; i < runs; i++) {
 Invoker sinvoker = cluster.select(lb, invocation, invokers, 
selectedInvokers);
 Assert.assertEquals(true, sinvoker.isAvailable());
+
+Mockito.clearInvocations(invoker1, invoker2, invoker3, invoker4, 
invoker5);
 }
 for (int i = 0; i < runs; i++) {
 selectedInvokers.clear();
 selectedInvokers.add(invoker1);
 Invoker sinvoker = cluster.select(lb, invocation, invokers, 
selectedInvokers);
 Assert.assertEquals(true, sinvoker.isAvailable());
+
+Mockito.clearInvocations(invoker1, invoker2, invoker3, invoker4, 
invoker5);
 }
 for (int i = 0; i < runs; i++) {
 selectedInvokers.clear();
 selectedInvokers.add(invoker2);
 Invoker sinvoker = cluster.select(lb, invocation, invokers, 
selectedInvokers);
 Assert.assertEquals(true, sinvoker.isAvailable());
+
+Mockito.clearInvocations(invoker1, invoker2, invoker3, invoker4, 
invoker5);
 }
 for (int i = 0; i < runs; i++) {

[GitHub] diecui1202 commented on a change in pull request #1267: [dubbo-1267]add consistentHashLoadBalance test

2018-05-09 Thread GitBox

diecui1202 commented on a change in pull request #1267: [dubbo-1267]add 
consistentHashLoadBalance test 
URL: https://github.com/apache/incubator-dubbo/pull/1267#discussion_r186943993
 
 

 ##
 File path: 
dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/loadbalance/LoadBalanceTest.java
 ##
 @@ -71,6 +73,14 @@ public void setUp() throws Exception {
 invoker3 = EasyMock.createMock(Invoker.class);
 invoker4 = EasyMock.createMock(Invoker.class);
 invoker5 = EasyMock.createMock(Invoker.class);
+invocationList = new ArrayList();
+for(int i=0; i<1000; i++){
 
 Review comment:
   Could you format the code ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] diecui1202 commented on a change in pull request #1267: [dubbo-1267]add consistentHashLoadBalance test

2018-05-09 Thread GitBox

diecui1202 commented on a change in pull request #1267: [dubbo-1267]add 
consistentHashLoadBalance test 
URL: https://github.com/apache/incubator-dubbo/pull/1267#discussion_r186944119
 
 

 ##
 File path: 
dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/loadbalance/LoadBalanceTest.java
 ##
 @@ -71,6 +73,14 @@ public void setUp() throws Exception {
 invoker3 = EasyMock.createMock(Invoker.class);
 invoker4 = EasyMock.createMock(Invoker.class);
 invoker5 = EasyMock.createMock(Invoker.class);
+invocationList = new ArrayList();
+for(int i=0; i<1000; i++){
+Invocation  invocation1 = EasyMock.createMock(Invocation.class);
 
 Review comment:
   `invocation` is a better variable name here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] diecui1202 commented on a change in pull request #1267: [dubbo-1267]add consistentHashLoadBalance test

2018-05-09 Thread GitBox

diecui1202 commented on a change in pull request #1267: [dubbo-1267]add 
consistentHashLoadBalance test 
URL: https://github.com/apache/incubator-dubbo/pull/1267#discussion_r186939176
 
 

 ##
 File path: 
dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/loadbalance/ConsistentHashLoadBalance.java
 ##
 @@ -36,6 +36,8 @@
  */
 public class ConsistentHashLoadBalance extends AbstractLoadBalance {
 
+public static final String NAME = "consistenthash";
 
 Review comment:
   IMO, this is ok.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

39 matches

Mail list logo