date:20190910

[GitHub] [dubbo] wanghongenpin commented on issue #2635: 不看pojo类或代码，能否通过telnet等命令查看pojo类的属性信息?

2019-09-10 Thread GitHub

watch

[ Full content available at: https://github.com/apache/dubbo/issues/2635 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] goodjava opened pull request #5050: supports giving higher priority to intra-domain invocation

2019-09-10 Thread GitHub

## What is the purpose of the change

supports giving higher priority to intra-domain invocation

## Brief changelog

X

## Verifying this change

X

Follow this checklist to help us incorporate your contribution quickly and 
easily:

- [x] Make sure there is a 
[GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when 
host config not exist #XXX`. Each commit in the pull request should have a 
meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add sample in [dubbo 
samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile 
failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/dubbo/pull/5050 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] qixiaobo commented on issue #5048: 服务端从2.6.0升级到2.7.1后，Version.getIntVersion报错，响应失败

2019-09-10 Thread GitHub

maybe you can provide the error v parameter?  

[ Full content available at: https://github.com/apache/dubbo/issues/5048 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] qixiaobo commented on issue #5048: 服务端从2.6.0升级到2.7.1后，Version.getIntVersion报错，响应失败

2019-09-10 Thread GitHub

```java
 /**
 * get prefix digits from given version string
 */
private static String getPrefixDigits(String v) {
Matcher matcher = PREFIX_DIGITS_PATTERN.matcher(v);
if (matcher.find()) {
return matcher.group(1);
}
return "";
}
```
so it may return ""

[ Full content available at: https://github.com/apache/dubbo/issues/5048 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4296: add support for field name convert. e.g. order_id <-> orderId

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4296)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4296) before we 
can accept your contribution.**2** out of **3** committers have signed the 
CLA.:white_check_mark: beiwei30:white_check_mark: 
rolandhe:x: hexiufeng**hexiufeng** seems not to be a GitHub 
user. You need a GitHub account to be able to sign the CLA. If you have already 
a GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullReques
 t=4296) it.

[ Full content available at: https://github.com/apache/dubbo/pull/4296 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) before we 
can accept your contribution.**1** out of **2** committers have signed the 
CLA.:white_check_mark: mzorro:x: 君时**君时** seems not to 
be a GitHub user. You need a GitHub account to be able to sign the CLA. If you 
have already a GitHub account, please [add the email address used for this 
commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4811) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4811 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] haiyang1985 opened issue #5049: support specify protocol for Service annotation

2019-09-10 Thread GitHub

- [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of 
this repository and believe that this is not a duplicate.
- [ ] I have checked the 
[FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository 
and believe that this is not a duplicate.

### Environment

* Dubbo version: 2.7.3
* Operating System version: macOs sierra
* Java version: 1.8

### Steps to reproduce this issue

1. define two dubbo protocols with different port, like below.
```
@Configuration
public class DubboConfiguration {

  @Bean
  public ProtocolConfig config1() {
ProtocolConfig config = new ProtocolConfig();
config.setId("dubbo1");
config.setName("dubbo");
config.setPort(20880);
return config;
  }

  @Bean
  public ProtocolConfig config2() {
ProtocolConfig config = new ProtocolConfig();
config.setId("dubbo2");
config.setName("dubbo");
config.setPort(20770);
return config;
  }
}
```
2. specify dubbo bean id "dubbo1" as Service annotation protocol, but not 
spring bean name "config1".
```
@Service(protocol = "dubbo1")
```
3. startup the provider and see output log, and see application failed to start 
without dubbo1 protocol.

```
***
APPLICATION FAILED TO START
***

Description:

A component required a bean named 'dubbo1' that could not be found.
```

If we are specify config1 as the protocol, the application can start up 
succeed. When ServiceBean initialize, it will get reference bean from spring, 
cannot recognize dubbo properties.
@Service(protocol = "config1")

Pls. provide [GitHub address] to reproduce this issue.

### Expected Result

The application start up succeed.

### Actual Result

The application start up failed without dubbo1 protocol.

[ Full content available at: https://github.com/apache/dubbo/issues/5049 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #3897: add socks5 proxy support to 2.6.x netty4 client

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3897)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=3897) before we 
can accept your contribution.**骄龙** seems not to be a GitHub user. 
You need a GitHub account to be able to sign the CLA. If you have already a 
GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=3897) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/3897 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4235: AMS realize dubbo Proxy

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4235)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4235) before we 
can accept your contribution.**0** out of **2** committers have signed the 
CLA.:x: githublaohu:x: 
2372554...@qq.com**2372554...@qq.com** seems not to be a GitHub user. 
You need a GitHub account to be able to sign the CLA. If you have already a 
GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4235) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4235 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] htynkn commented on issue #5044: fix some typos

2019-09-10 Thread GitHub

Thanks for your contribution.

[ Full content available at: https://github.com/apache/dubbo/pull/5044 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #194: Add: new feature to support dynamic config center which compatible with dubbo 2.6.x & 2.7.x

2019-09-10 Thread GitHub

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/194?src=pr=h1) Report
> Merging [#194](https://codecov.io/gh/apache/dubbo-go/pull/194?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/bb1216a7e352794ae1103f42e086dc8ae5feb5d0?src=pr=desc)
>  will **decrease** coverage by `2.01%`.
> The diff coverage is `49.15%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/194/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/194?src=pr=tree)

```diff
@@ Coverage Diff @@
##   develop #194  +/-   ##
===
- Coverage67.49%   65.47%   -2.02% 
===
  Files   94   94  
  Lines 5864 6303 +439 
===
+ Hits  3958 4127 +169 
- Misses1496 1748 +252 
- Partials   410  428  +18
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/194?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[config/protocol\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-Y29uZmlnL3Byb3RvY29sX2NvbmZpZy5nbw==)
 | `100% <ø> (ø)` | :arrow_up: |
| 
[config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv)
 | `66.23% <ø> (+0.41%)` | :arrow_up: |
| 
[config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==)
 | `61.7% <ø> (ø)` | :arrow_up: |
| 
[config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==)
 | `100% <ø> (ø)` | :arrow_up: |
| 
[config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==)
 | `0% <0%> (ø)` | |
| 
[config\_center/zookeeper/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvZmFjdG9yeS5nbw==)
 | `9.09% <0%> (ø)` | :arrow_up: |
| 
[cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=)
 | `60% <0%> (-9.24%)` | :arrow_down: |
| 
[common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==)
 | `72.5% <0%> (-8.06%)` | :arrow_down: |
| 
[registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv)
 | `58.13% <100%> (ø)` | :arrow_up: |
| 
[config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=)
 | `82.75% <100%> (ø)` | :arrow_up: |
| ... and [26 
more](https://codecov.io/gh/apache/dubbo-go/pull/194/diff?src=pr=tree-more) 
| |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/194?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/194?src=pr=footer). 
> Last update 
> [bb1216a...23f5b40](https://codecov.io/gh/apache/dubbo-go/pull/194?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/194 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] chozee opened issue #5048: 服务端从2.6.0升级到2.7.1后，Version.getIntVersion报错，响应失败

2019-09-10 Thread GitHub

- [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of 
this repository and believe that this is not a duplicate.
- [ ] I have checked the 
[FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository 
and believe that this is not a duplicate.

### Environment

* Dubbo version: 2.6.0
* Operating System version: centos 6
* Java version: jdk 1.8

### Steps to reproduce this issue

1. 服务端dubbo 2.7 客户端使用2.6.0 由于集群原因升级到2.7之后zk的curator客户端会造成任务卡住，所以无法升级
2. ause: java.lang.NumberFormatException: For input string: ""
java.lang.NumberFormatException: For input string: ""
at 
java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:592)
at java.lang.Integer.parseInt(Integer.java:615)
at org.apache.dubbo.common.Version.parseInt(Version.java:128)
at org.apache.dubbo.common.Version.getIntVersion(Version.java:113)
at 
org.apache.dubbo.common.Version.isSupportResponseAttachment(Version.java:102)


[ Full content available at: https://github.com/apache/dubbo/issues/5048 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #198: Add:retries mergeUrl

2019-09-10 Thread GitHub

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr=h1) Report
> Merging [#198](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/359bdab8e26f71b54158d21a18ad8313790785c0?src=pr=desc)
>  will **increase** coverage by `0.14%`.
> The diff coverage is `90.9%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/198/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr=tree)

```diff
@@ Coverage Diff @@
##   develop #198  +/-   ##
===
+ Coverage66.71%   66.85%   +0.14% 
===
  Files   94   94  
  Lines 5870 5817  -53 
===
- Hits  3916 3889  -27 
+ Misses1545 1531  -14 
+ Partials   409  397  -12
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree#diff-Y29tbW9uL3VybC5nbw==)
 | `74.89% <90.9%> (+4.55%)` | :arrow_up: |
| 
[common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==)
 | `18.33% <0%> (-81.67%)` | :arrow_down: |
| 
[protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=)
 | `50% <0%> (-4.17%)` | :arrow_down: |
| 
[protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==)
 | `69.23% <0%> (-2.57%)` | :arrow_down: |
| 
[registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=)
 | `75% <0%> (-1.54%)` | :arrow_down: |
| 
[protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=)
 | `95.55% <0%> (ø)` | :arrow_up: |
| 
[protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==)
 | `82.92% <0%> (+0.87%)` | :arrow_up: |
| 
[filter/impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree#diff-ZmlsdGVyL2ltcGwvZWNob19maWx0ZXIuZ28=)
 | `85.71% <0%> (+1.09%)` | :arrow_up: |
| 
[protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv)
 | `70.94% <0%> (+2.56%)` | :arrow_up: |
| ... and [2 
more](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr=tree-more) 
| |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr=footer). 
> Last update 
> [359bdab...8f9295b](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/198 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] konglz commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

有几个点我觉得有风险：

* 性能表现，我看到代码里有直接走反射的，没有细看，不确定这个反射是否只执行1次；

* 资源回收，我看 
[motan的GRPC实现](https://github.com/weibocom/motan/blob/master/motan-extension/protocol-extension/motan-protocol-grpc/src/main/java/com/weibo/api/motan/protocol/grpc/GrpcProtocol.java)
 有很多资源回收的处置；

* 插件维护，protobuf编译插件是直接在C代码上改的，javaer维护代价比较高。

建议：

* 跑通冒烟测试，至少验证rpc的基本功能，如：超时、重试、集群容错、异步调用、RpcContext

* 跑出一些性能基准，如：dubbo grpc vs 原生dubbo

* 可以参照motan的实现，做一些原理对比

* pb编译插件用java包裹原生插件来实现，以避免javaer再去学习C代码（用户二开时）

[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] konglz commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

有几个点我觉得有风险：

* 性能表现，我看到代码里有直接走反射的，没有细看，不确定这个反射是否只执行1次；

* 资源回收，我看 
[motan的GRPC实现](https://github.com/weibocom/motan/blob/master/motan-extension/protocol-extension/motan-protocol-grpc/src/main/java/com/weibo/api/motan/protocol/grpc/GrpcProtocol.java)
 有很多资源回收的处置；

* 插件维护，protobuf编译插件是直接在C代码上改的，javaer维护代价比较高。

建议：

* 跑通冒烟测试，至少验证rpc的基本功能，如：超时、重试、集群容错、异步调用、RpcContext

* 跑出一些性能基准

* 可以参照motan的实现，做一些原理对比

* pb编译插件用java包裹原生插件来实现

[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] konglz commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

有几个点我觉得有风险：

* 性能表现，我看到代码里有直接走反射的，没有细看，不确定这个反射是否只执行1次；

* 资源回收，我看 
[motan的GRPC实现](https://github.com/weibocom/motan/blob/master/motan-extension/protocol-extension/motan-protocol-grpc/src/main/java/com/weibo/api/motan/protocol/grpc/GrpcProtocol.java)
 有很多资源回收的处置；

* 插件维护，protobuf编译插件是直接在C代码上改的，javaer维护代价比较高。

建议：

* 跑通冒烟测试，至少验证rpc的基本功能，如：超时、重试、集群容错、异步调用、attach传递

* 跑出一些性能基准

* 可以参照motan的实现，做一些原理对比

* pb编译插件用java包裹原生插件来实现

[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] konglz commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

有几个点我觉得有风险：

* 性能表现，我看到代码里有直接走反射的，没有细看，不确定这个反射是否只执行1次；

* 资源回收，我看 
[motan的GRPC实现](https://github.com/weibocom/motan/blob/master/motan-extension/protocol-extension/motan-protocol-grpc/src/main/java/com/weibo/api/motan/protocol/grpc/GrpcProtocol.java)
 有很多资源回收的处置；

* 插件维护，protobuf编译插件是直接在C代码上改的，javaer维护代价比较高

建议：

* 跑通冒烟测试，至少验证rpc的基本功能，如：超时、重试、集群容错、异步调用、attach传递

* 跑出一些性能基准

* 可以参照motan的实现，做一些原理对比

* pb编译插件用java包裹原生插件来实现

[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] konglz commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

有几个点我觉得有风险：

* 性能表现，我看到代码里有直接走反射的，没有细看，不确定这个反射是否只执行1次；

* 资源回收，我看 
[motan的GRPC实现](https://github.com/weibocom/motan/blob/master/motan-extension/protocol-extension/motan-protocol-grpc/src/main/java/com/weibo/api/motan/protocol/grpc/GrpcProtocol.java)
 有很多资源回收的处置；

* 插件维护，protobuf编译插件是直接在C代码上改的，javaer维护代价比较高


[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] konglz commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

有几个点我觉得有风险：

* 性能表现，我看到代码里有直接走反射的，没有细看，不确定这个反射是否只执行1次；

* 资源回收，我看 
[motan的GRPC实现](https://github.com/weibocom/motan/blob/master/motan-extension/protocol-extension/motan-protocol-grpc/src/main/java/com/weibo/api/motan/protocol/grpc/GrpcProtocol.java)
 有很多资源回收的处置；

* 插件维护，protobuf编译插件是直接在C代码上改的，javaer维护代价比较高，有没有可能用java代码实现。


[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-website] maslke commented on issue #470: http://dubbo.apache.org/zh-cn/docs/user/versions/version-270.html 文档中存在文字翻译错误问题

2019-09-10 Thread GitHub

http://dubbo.apache.org/zh-cn/docs/user/references/xml/dubbo-service.html
![1](https://user-images.githubusercontent.com/6869592/64662570-804b5f80-d47b-11e9-98ba-6f7de1eaa790.png)
上图中，中文描述应该是 缺省

[ Full content available at: https://github.com/apache/dubbo-website/issues/470 
]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] konglz commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

另外，测过性能没有？我看核心链路上直接走反射，比如：
```java
/**
 * 这里返回的impl必须要有所有的方法, Stub BlockingStube FutureStub
 */
@Override
protected  T doRefer(Class type, URL url) throws RpcException {
//通过 
type(IGreeter)，反射获得外部类（GreeterGrpc），调用静态方法（getDubboStub()），获得并返回（T）stub
Class enclosingClass = type.getEnclosingClass();
if (enclosingClass == null) {
throw new IllegalArgumentException(
type.getName() + " must be declared inside protobuf 
generated classes, " +
"should be something like 
ServiceNameGrpc.IServiceName.");
}

final Method dubboStubMethod;
try {
dubboStubMethod = enclosingClass.getDeclaredMethod("getDubboStub", 
Channel.class, long.class);
} catch (NoSuchMethodException e) {
throw new IllegalArgumentException("Does not find getDubboStub in " 
+ enclosingClass.getName()
+ ", please use the customized protoc-gen-grpc-dubbo-java 
to update the generated classes.");
}

Channel channel = channelMap.computeIfAbsent(url.getServiceKey(),
k -> ManagedChannelBuilder.forAddress(url.getHost(), 
url.getPort()).usePlaintext().build()
);

try {
int timeout = url.getParameter(TIMEOUT_KEY, DEFAULT_TIMEOUT);
@SuppressWarnings("unchecked") final T stub = (T) 
dubboStubMethod.invoke(null, channel, timeout);
return stub;
} catch (IllegalAccessException | InvocationTargetException e) {
throw new IllegalStateException("Could not create stub through 
reflection.", e);
}
}
```
我没有细看，不确定这个反射逻辑前面有没有cache，如果没有cache，这个设计值得商榷。
可以参考 
[motan的GRPC实现](https://github.com/weibocom/motan/blob/master/motan-extension/protocol-extension/motan-protocol-grpc/src/main/java/com/weibo/api/motan/protocol/grpc/GrpcProtocol.java)
 ，motan的grpc已经提交3年了，应该比较成熟了。


[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] konglz commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

另外，测过性能没有？我看核心链路上直接走反射，比如：
```java
/**
 * 这里返回的impl必须要有所有的方法, Stub BlockingStube FutureStub
 */
@Override
protected  T doRefer(Class type, URL url) throws RpcException {
//通过 
type(IGreeter)，反射获得外部类（GreeterGrpc），调用静态方法（getDubboStub()），获得并返回（T）stub
Class enclosingClass = type.getEnclosingClass();
if (enclosingClass == null) {
throw new IllegalArgumentException(
type.getName() + " must be declared inside protobuf 
generated classes, " +
"should be something like 
ServiceNameGrpc.IServiceName.");
}

final Method dubboStubMethod;
try {
dubboStubMethod = enclosingClass.getDeclaredMethod("getDubboStub", 
Channel.class, long.class);
} catch (NoSuchMethodException e) {
throw new IllegalArgumentException("Does not find getDubboStub in " 
+ enclosingClass.getName()
+ ", please use the customized protoc-gen-grpc-dubbo-java 
to update the generated classes.");
}

Channel channel = channelMap.computeIfAbsent(url.getServiceKey(),
k -> ManagedChannelBuilder.forAddress(url.getHost(), 
url.getPort()).usePlaintext().build()
);

try {
int timeout = url.getParameter(TIMEOUT_KEY, DEFAULT_TIMEOUT);
@SuppressWarnings("unchecked") final T stub = (T) 
dubboStubMethod.invoke(null, channel, timeout);
return stub;
} catch (IllegalAccessException | InvocationTargetException e) {
throw new IllegalStateException("Could not create stub through 
reflection.", e);
}
}
```

可以参考 
[motan的GRPC实现](https://github.com/weibocom/motan/blob/master/motan-extension/protocol-extension/motan-protocol-grpc/src/main/java/com/weibo/api/motan/protocol/grpc/GrpcProtocol.java)


[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-website] maslke opened issue #470: http://dubbo.apache.org/zh-cn/docs/user/versions/version-270.html 文档中存在文字翻译错误问题

2019-09-10 Thread GitHub

![TIM截图20190911094416](https://user-images.githubusercontent.com/6869592/64661904-17fb7e80-d479-11e9-8c86-94af2d528a53.png)

如上图所示，ConsumerConfig和ProducerConfig的中文意思反了。

[ Full content available at: https://github.com/apache/dubbo-website/issues/470 
]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] falcondsc commented on issue #1968: 服务调用的超时问题 Some issues with service timeout

2019-09-10 Thread GitHub

> 好的. 我會在本周三(9/11) 以前, 在 2.6.x 分支上 進行驗證.

我獲取了 2.6.x 分支 在 HeaderExchangeChannel.close()  調用 
DefaultFuture.closeChannel(channel);  方法. 但測試後發現調用到 
HeaderExchangeChannel.close()  的堆棧 和 我先前用 2.6.6 去修改時有些不同, 2.6.x 分支代碼上慢了很多(關閉 
dubbo provider 之後, 要等 30 秒以上)才會進到 consumer 端的HeaderExchangeChannel.close() .. 
我先再繼續做些測試, 查看下是不是我兩個測試環境有不同而引起的問題.

[ Full content available at: https://github.com/apache/dubbo/issues/1968 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed pull request #193: Add: invoker & attachments & merge master

2019-09-10 Thread GitHub

[ pull request closed by AlexStocks ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/193 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] arjenzhou commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

感谢反馈，会继续修改

konglz  于 2019年9月10日周二 下午9:53写道：

> 代码bug比较多：
>
>-
>   1. 超时时间完全不生效，不管在哪一端设置；
>-
>   1. 服务端抛异常，客户端接不到。
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 
> .
>


[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo]

2019-09-10 Thread GitHub



[ Full content available at: https://github.com/apache/dubbo/issues/5041 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] konglz commented on issue #3999: [SoC2019]Supporting gRPC Protocol.

2019-09-10 Thread GitHub

代码bug比较多：

* 1. 超时时间完全不生效，不管在哪一端设置；
* 2. 服务端抛异常，客户端接不到。

[ Full content available at: https://github.com/apache/dubbo/issues/3999 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] codecov-io commented on issue #5044: fix some typos

2019-09-10 Thread GitHub

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5044?src=pr=h1) Report
> Merging [#5044](https://codecov.io/gh/apache/dubbo/pull/5044?src=pr=desc) 
> into 
> [master](https://codecov.io/gh/apache/dubbo/commit/9275b9d5154b75c3a52f7fbb14f9290ef24bde2f?src=pr=desc)
>  will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo/pull/5044/graphs/tree.svg?width=650=VnEIkiFQT0=150=pr)](https://codecov.io/gh/apache/dubbo/pull/5044?src=pr=tree)

```diff
@@ Coverage Diff  @@
## master#5044  +/-   ##

- Coverage 63.94%   63.93%   -0.02% 
- Complexity  451  453   +2 

  Files   769  769  
  Lines 3319433194  
  Branches   5236 5236  

- Hits  2122621222   -4 
- Misses 9543 9548   +5 
+ Partials   2425 2424   -1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5044?src=pr=tree) 
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
| 
[...pc/cluster/loadbalance/LeastActiveLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvTGVhc3RBY3RpdmVMb2FkQmFsYW5jZS5qYXZh)
 | `88.88% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==)
 | `80% <0%> (-3.34%)` | `0% <0%> (ø)` | |
| 
[...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==)
 | `78.54% <0%> (-3.07%)` | `0% <0%> (ø)` | |
| 
[.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=)
 | `58.69% <0%> (-2.18%)` | `0% <0%> (ø)` | |
| 
[...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==)
 | `67.87% <0%> (-1.36%)` | `0% <0%> (ø)` | |
| 
[...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==)
 | `47.91% <0%> (-1.05%)` | `0% <0%> (ø)` | |
| 
[...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh)
 | `62.41% <0%> (-0.35%)` | `0% <0%> (ø)` | |
| 
[...he/dubbo/registry/zookeeper/ZookeeperRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS96b29rZWVwZXIvWm9va2VlcGVyUmVnaXN0cnkuamF2YQ==)
 | `67.37% <0%> (+0.7%)` | `0% <0%> (ø)` | :arrow_down: |
| 
[...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=)
 | `90.65% <0%> (+0.93%)` | `17% <0%> (+1%)` | :arrow_up: |
| 
[.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh)
 | `64.77% <0%> (+1.13%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [3 
more](https://codecov.io/gh/apache/dubbo/pull/5044/diff?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo/pull/5044?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo/pull/5044?src=pr=footer). 
> Last update 
> [9275b9d...a9aec64](https://codecov.io/gh/apache/dubbo/pull/5044?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[

[GitHub] [dubbo] Hearen opened issue #5045: How to understand least active road balance well?

2019-09-10 Thread GitHub

I've sought all sites I could reach and read all docs related to this topic but 
still I am not getting it. 

Sorry to post a question like this in issue part. But I have nowhere to go for 
the help. 

I know from the official doc:

> The active number refers to the difference between the counts before and 
> after the call. Select the machine with the minimum number of active calls or 
> choose a random one among machines with the same active number, so that the 
> slower machine can receives less requests.

It's not a problem to understand the last half part but as for the **active 
number definition**, I am really into confusion. And also there is an case to 
explain it officially as

> When A machine starts processing the request, the counter is incremented by 
> 1. At this time, A is still processing. If the processing is completed, the 
> counter is decremented by 1. B machine processes very quickly after receiving 
> the request. Then the active numbers of A and B are 1,0 respectively.

To my understanding, A processes one (`before`) and still have one (`after`) 
while B one (`before`) and have zero (`after`) then the difference should be A: 
0 and B: -1. 

Weird result but it's based on the difinition. 

What's the misunderstanding here? Really confusing here. Any help will be 
appreciated ;)

[ Full content available at: https://github.com/apache/dubbo/issues/5045 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] Hearen opened pull request #5044: fix some typos

2019-09-10 Thread GitHub

## What is the purpose of the change

X

## Brief changelog

X

## Verifying this change

X

Follow this checklist to help us incorporate your contribution quickly and 
easily:

- [x] Make sure there is a 
[GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when 
host config not exist #XXX`. Each commit in the pull request should have a 
meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add sample in [dubbo 
samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile 
failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/dubbo/pull/5044 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt opened pull request #198: Add:retries mergeUrl

2019-09-10 Thread GitHub



**What this PR does**:
Add:retries mergeUrl

**Which issue(s) this PR fixes**:

Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:

```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/198 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] pantianying commented on issue #197: fix MergeUrl

2019-09-10 Thread GitHub

> We can not do this because referenceURL is different from serviceUrl in 
> addtion to params , I don't know how many bug will appear after modifying in 
> this way.

ok get it

[ Full content available at: https://github.com/apache/dubbo-go/pull/197 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] pantianying opened pull request #197: fix MergeUrl

2019-09-10 Thread GitHub



**What this PR does**:

**Which issue(s) this PR fixes**:

Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:

```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/197 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] bq-xiao commented on issue #5041: No matter how I set it, the version is always 0.0.0

2019-09-10 Thread GitHub

**the same issue:**

Env:
```
maven:

org.apache.dubbo
dubbo-spring-boot-starter
2.7.3


OS: windows10
JDK:1.8
```

1.Provider source code:
```
@Service(version = "demo", interfaceClass = HelloWorldService.class)
public class HelloWorldServiceImpl implements HelloWorldService {

@Value("${dubbo.application.name}")
private String serviceName;

@Override
public String sayHello(String name) {
return String.format("[%s] : Hello, %s", serviceName, name);
}
}
```

2.Consumer source code:
```
@RestController
@RequestMapping("/sample")
public class HelloWorldController {
@Reference(version = "demo", url = "dubbo://127.0.0.1:12345")
private HelloWorldService helloWorldService;

@GetMapping(value = "/hello/{name}")
@ResponseBody
public String say(@PathVariable("name") String name) {
return helloWorldService.sayHello(name);
}
}
```
3.But get below error log
```
org.apache.dubbo.remoting.RemotingException: 
org.apache.dubbo.remoting.RemotingException: Not found exported service: 
com.example.dubbo.springboot.api.service.HelloWorldService:12345 in 
[com.example.dubbo.springboot.api.service.HelloWorldService:demo:12345], may be 
version or group mismatch , channel: consumer: /192.168.0.190:9410 --> 
provider: /192.168.0.190:12345, message:RpcInvocation [methodName=sayHello, 
parameterTypes=[class java.lang.String], arguments=[aa], 
attachments={path=com.example.dubbo.springboot.api.service.HelloWorldService, 
input=270, dubbo=2.0.2, 
interface=com.example.dubbo.springboot.api.service.HelloWorldService, 
version=0.0.0}]
org.apache.dubbo.remoting.RemotingException: Not found exported service: 
com.example.dubbo.springboot.api.service.HelloWorldService:12345 in 
[com.example.dubbo.springboot.api.service.HelloWorldService:demo:12345], may be 
version or group mismatch , channel: consumer: /192.168.0.190:9410 --> 
provider: /192.168.0.190:12345, message:RpcInvocation [methodName=sayHello, 
parameterTypes=[class java.lang.String], arguments=[aa], 
attachments={path=com.example.dubbo.springboot.api.service.HelloWorldService, 
input=270, dubbo=2.0.2, 
interface=com.example.dubbo.springboot.api.service.HelloWorldService, 
version=0.0.0}]
```


[ Full content available at: https://github.com/apache/dubbo/issues/5041 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #3649: [Dubbo-3629] Fix ServiceConfig duplicate export produces misleading exception

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3649)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=3649) before we 
can accept your contribution.**0** out of **2** committers have signed the 
CLA.:x: JerryChin:x: meijieqinYou have signed the CLA 
already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=3649) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/3649 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4296: add support for field name convert. e.g. order_id <-> orderId

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4296)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4296) before we 
can accept your contribution.**2** out of **3** committers have signed the 
CLA.:white_check_mark: rolandhe:white_check_mark: 
beiwei30:x: hexiufeng**hexiufeng** seems not to be a GitHub 
user. You need a GitHub account to be able to sign the CLA. If you have already 
a GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullReques
 t=4296) it.

[ Full content available at: https://github.com/apache/dubbo/pull/4296 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #5042: fix doc typo

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5042)
 All committers have signed the CLA.

[ Full content available at: https://github.com/apache/dubbo/pull/5042 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4463: Add back compatible classes: ResponseFuture and FutureAdapter

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4463)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4463) before we 
can accept your contribution.**5** out of **9** committers have signed the 
CLA.:white_check_mark: mercyblitz:white_check_mark: 
chickenlj:white_check_mark: ralf0131:white_check_mark: 
htynkn:white_check_mark: shoukai:x: zishinan:x: vio-lin:x: 
cvictory:x: haiyang1985You have signed the CLA already but the 
status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4463) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4463 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4235: AMS realize dubbo Proxy

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4235)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4235) before we 
can accept your contribution.**0** out of **2** committers have signed the 
CLA.:x: 2372554...@qq.com:x: 
githublaohu**2372554...@qq.com** seems not to be a GitHub user. You 
need a GitHub account to be able to sign the CLA. If you have already a GitHub 
account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4235) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4235 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4463: Add back compatible classes: ResponseFuture and FutureAdapter

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4463)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4463) before we 
can accept your contribution.**5** out of **9** committers have signed the 
CLA.:white_check_mark: chickenlj:white_check_mark: 
htynkn:white_check_mark: mercyblitz:white_check_mark: 
ralf0131:white_check_mark: shoukai:x: cvictory:x: 
zishinan:x: haiyang1985:x: vio-linYou have signed the CLA 
already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4463) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4463 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4296: add support for field name convert. e.g. order_id <-> orderId

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4296)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4296) before we 
can accept your contribution.**2** out of **3** committers have signed the 
CLA.:white_check_mark: beiwei30:white_check_mark: 
rolandhe:x: hexiufeng**hexiufeng** seems not to be a GitHub 
user. You need a GitHub account to be able to sign the CLA. If you have already 
a GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullReques
 t=4296) it.

[ Full content available at: https://github.com/apache/dubbo/pull/4296 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4463: Add back compatible classes: ResponseFuture and FutureAdapter

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4463)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4463) before we 
can accept your contribution.**5** out of **9** committers have signed the 
CLA.:white_check_mark: htynkn:white_check_mark: 
mercyblitz:white_check_mark: ralf0131:white_check_mark: 
chickenlj:white_check_mark: shoukai:x: cvictory:x: 
zishinan:x: vio-lin:x: haiyang1985You have signed the CLA 
already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4463) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4463 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #5043: concurrent cache bug fix

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5043)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5043) before we 
can accept your contribution.**baiyundou** seems not to be a GitHub 
user. You need a GitHub account to be able to sign the CLA. If you have already 
a GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5043) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/5043 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) before we 
can accept your contribution.**1** out of **2** committers have signed the 
CLA.:white_check_mark: mzorro:x: 君时**君时** seems not to 
be a GitHub user. You need a GitHub account to be able to sign the CLA. If you 
have already a GitHub account, please [add the email address used for this 
commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4811) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4811 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4604: Optimize code in RoundRobinLoadBalance

2019-09-10 Thread GitHub

[![CLA assistant 
check](https://cla-assistant.io/pull/badge/signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4604)
 All committers have signed the CLA.

[ Full content available at: https://github.com/apache/dubbo/pull/4604 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-admin] dashuaigege opened issue #508: dubbo admin 动态配置

2019-09-10 Thread GitHub

配置如下，超时时间并没有生效
configVersion: v2.7
enabled: true
configs:
  - side: consumer
addresses:
  - 0.0.0.0
parameters:
  timeout: 6000

[ Full content available at: https://github.com/apache/dubbo-admin/issues/508 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] brucelwl closed pull request #4785: Remove fixed settings

2019-09-10 Thread GitHub

[ pull request closed by brucelwl ]

[ Full content available at: https://github.com/apache/dubbo/pull/4785 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] yinjunonly opened issue #5041: No matter how I set it, the version is always 0.0.0

2019-09-10 Thread GitHub

### Environment
* Dubbo version: 2.7.3
* Operating System version: windows10
* Java version: 8

### Steps to reproduce this issue
1.Declare  service：
```xml

```
2.Generalizing calls using API
```java
ReferenceConfig reference = new 
ReferenceConfig();
reference.setApplication(this.applicationConfig);
reference.setRegistry(this.registryConfig);
reference.setInterface("com.xxx.RemoteDefaultService");
reference.setGeneric(true);
reference.setConsumer(consumerConfig);
reference.setGroup("commonComponent");
reference.setVersion("0.0.1");
ReferenceConfigCache cache = ReferenceConfigCache.getCache();
GenericService genericService = cache.get(reference);
int len = params.size();
String[] invokeParamTyeps = new String[len];
Object[] invokeParams = new Object[len];
for (int i = 0; i < len; i++) {
GenericParamsEntity current = params.get(i);
invokeParamTyeps[i] = current.getTypeName();
invokeParams[i] = current.getValue();
}
try {
Object result = genericService.$invoke(method, invokeParamTyeps, 
invokeParams);
return result;
} catch (GenericException e) {
genericExceptionAnalytical(e);
throw e;
}
```
3.Throw an exception
```java
Not found exported service: 

·
interface=com.shxhome.hopps.common.core.microservice.defaultservice.RemoteDefaultService,
 version=0.0.0, generic=true}]
```
**No matter how I set it, the version is always 0.0.0**


[ Full content available at: https://github.com/apache/dubbo/issues/5041 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-website] xianSir commented on issue #469: 文档貌似有问题

2019-09-10 Thread GitHub

或者换个描述, 感觉容易误导

[ Full content available at: https://github.com/apache/dubbo-website/issues/469 
]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

50 matches

Mail list logo