[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972580688
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -483,30 +485,73 @@ public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
}
/**
- * Test that each region individually honors it's enforce local max memory
flag.
+ * Test that a region with enforceLocalMaxMemory disabled colocated with
+ * a region that memory full with enforceLocalMaxMemory enabled will prevent
a bucket move.
*/
@Test
- public void testColocationIgnoreEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationOneEnforceLocalMaxMemoryFull() throws
UnknownHostException {
Review Comment:
This seconde test case is newly added, I will explain why the third test
case was changed.
Most reasons is like above, special reason for this test case is to improve
the test condition.
First region lmm was set 500 before, this will make the memory judege for
all regions totally(the one I removed in this PR) pass and make the test case
pass.
So I decrease the lmm of the first region, so make the total lmm not enough
to hold all the data, this test case will pass with this PR applied, but will
fail with the old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972580688
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -483,30 +485,73 @@ public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
}
/**
- * Test that each region individually honors it's enforce local max memory
flag.
+ * Test that a region with enforceLocalMaxMemory disabled colocated with
+ * a region that memory full with enforceLocalMaxMemory enabled will prevent
a bucket move.
*/
@Test
- public void testColocationIgnoreEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationOneEnforceLocalMaxMemoryFull() throws
UnknownHostException {
Review Comment:
This seconde test case is newly added, I will explain why the third test
case was changed.
Most reasons is like above, special reason for this test case is to improve
the test condition.
First region lmm was set 500 before, this will make the outloop memory
judege(the one I removed in this PR) pass and make the test case pass.
So I decrease the lmm of the first region, so make the total lmm not enough
to hold all the data, this test case will pass with this PR applied, but will
fail with the old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972577636
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
The test case was changed for several reasons.
- Test cases are renamed to make them a group together with the newly added
test case(see below description about the test group).
- Add MB to data size so the log will print the model with correct data size.
- Some comments are chanegd, most to help understand the test case better,
and the last comment was wrong.
Description about the test group
The first case test that both of the 2 regions are eviction disabled(this
was tested before),
the second and third test cases test one region is eviction enabled,
the second test case tests the none eviction region memory full(this was
not tested before),
the third test case tests the eviction region memory full(this was
tested before but it should be failed if the test condition was set properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972577636
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
The test case was changed for several reasons.
Test cases are renamed to make them a group together with the newly added
test case(see below description about the test group).
Add MB to data size so the log will print the model with correct data size.
Some comments are chanegd, most to help understand the test case better, and
the last comment was wrong.
Description about the test group
The first case test that both of the 2 regions are eviction disabled(this
was tested before),
the second and third test cases test one region is eviction enabled,
the second test case tests the none eviction region memory full(this was
not tested before),
the third test case tests the eviction region memory full(this was tested
before but it should be failed if the test condition was set properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972577636
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
The test case was changed for several reasons.
Test cases are renamed to make them a group(see below description about the
test group).
Add MB to data size so the log will print the model with correct data size.
Some comments are chanegd, most to help understand the test case better, and
the last comment was wrong.
Description about the test group
The first case test that both of the 2 regions are eviction disabled(this
was tested before),
the second and third test cases test one region is eviction enabled,
the second test case tests the none eviction region memory full(this was
not tested before),
the third test case tests the eviction region memory full(this was tested
before but it should be failed if the test condition was set properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
mivanac commented on code in PR #7856:
URL: https://github.com/apache/geode/pull/7856#discussion_r972559431
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
+
+ GatewaySenderMXBean bean;
+ boolean commmandRejected = false;
+
+ ResultModel rejectResultModel =
+ ResultModel.createError(CliStrings.START_GATEWAYSENDER_REJECTED);
+ TabularResultModel rejectResultData =
+
rejectResultModel.addTable(CliStrings.REJECT_START_GATEWAYSENDER_REASON);
+
+ for (DistributedMember member : dsMembers) {
+if
(cache.getDistributedSystem().getDistributedMember().getId().equals(member.getId()))
{
+ bean = service.getLocalGatewaySenderMXBean(senderId);
+} else {
+ ObjectName objectName = service.getGatewaySenderMBeanName(member,
senderId);
+ bean = service.getMBeanProxy(objectName, GatewaySenderMXBean.class);
+}
+if (bean != null) {
+ if (bean.isRunning()) {
+commmandRejected = true;
+rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+CliStrings.format(
+
CliStrings.GATEWAY_SENDER_0_IS_ALREADY_STARTED_ON_MEMBER_1, id,
+member.getId()));
+ }
+} else {
+ commmandRejected = true;
+ rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+ CliStrings.format(
+ CliStrings.GATEWAY_SENDER_0_IS_NOT_AVAILABLE_ON_MEMBER_1,
id, member.getId()));
+}
+ }
Review Comment:
This check needs to be executed prior to execution of callables, since they
are executed in parallel on all desired members.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
mivanac commented on code in PR #7856:
URL: https://github.com/apache/geode/pull/7856#discussion_r972334785
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
+
+ GatewaySenderMXBean bean;
+ boolean commmandRejected = false;
+
+ ResultModel rejectResultModel =
+ ResultModel.createError(CliStrings.START_GATEWAYSENDER_REJECTED);
+ TabularResultModel rejectResultData =
+
rejectResultModel.addTable(CliStrings.REJECT_START_GATEWAYSENDER_REASON);
+
+ for (DistributedMember member : dsMembers) {
+if
(cache.getDistributedSystem().getDistributedMember().getId().equals(member.getId()))
{
+ bean = service.getLocalGatewaySenderMXBean(senderId);
+} else {
+ ObjectName objectName = service.getGatewaySenderMBeanName(member,
senderId);
+ bean = service.getMBeanProxy(objectName, GatewaySenderMXBean.class);
+}
+if (bean != null) {
+ if (bean.isRunning()) {
+commmandRejected = true;
+rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+CliStrings.format(
+
CliStrings.GATEWAY_SENDER_0_IS_ALREADY_STARTED_ON_MEMBER_1, id,
+member.getId()));
+ }
+} else {
+ commmandRejected = true;
+ rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+ CliStrings.format(
+ CliStrings.GATEWAY_SENDER_0_IS_NOT_AVAILABLE_ON_MEMBER_1,
id, member.getId()));
+}
+ }
Review Comment:
This check needs to be executed prior to execution of callables, since they
are executed in parallel on all desired members.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jvarenina opened a new pull request, #7860: To test if sync writes
jvarenina opened a new pull request, #7860: URL: https://github.com/apache/geode/pull/7860 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jvarenina closed pull request #7835: Configurable IF file compaction writes mode
jvarenina closed pull request #7835: Configurable IF file compaction writes mode URL: https://github.com/apache/geode/pull/7835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] moleske commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
moleske commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r972202959
##
docker/ubuntu-22.04/Dockerfile:
##
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+apt -yq full-upgrade && \
+apt-get -y install \
+apt-transport-https \
+ca-certificates \
+curl \
+gnupg2 \
+software-properties-common && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+RUN . /etc/os-release && \
+curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add -
&& \
+apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+build-essential \
+libc++-dev \
+libc++abi-dev \
+zlib1g-dev \
+libssl-dev \
+bellsoft-java11 \
+git \
+doxygen \
+graphviz \
+clang-format-12 && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+# Get latest release of CMake ignoring pre-releases
+RUN installer=$(mktemp) \
+&& curl -o ${installer} -L $(curl -s
https://api.github.com/repos/Kitware/CMake/releases \
+| grep -P -i
'browser_download_url.*cmake-\d+\.\d+\.\d+-linux-x86_64\.sh' \
+| head -n 1 \
+| cut -d : -f 2,3 \
+| tr -d '"') \
+&& bash ${installer} --skip-license --prefix=/usr/local \
+&& rm ${installer}
+
+ARG GEODE_VERSION=1.14.4
Review Comment:
ah joys of forgetting about prs for months on end, can bump it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode-native] moleske merged pull request #966: GEODE-10291: Compile on ubuntu jammy (gcc/g++ 11.2.0)
moleske merged PR #966: URL: https://github.com/apache/geode-native/pull/966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
albertogpz commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972056347
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -483,30 +485,73 @@ public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
}
/**
- * Test that each region individually honors it's enforce local max memory
flag.
+ * Test that a region with enforceLocalMaxMemory disabled colocated with
+ * a region that memory full with enforceLocalMaxMemory enabled will prevent
a bucket move.
*/
@Test
- public void testColocationIgnoreEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationOneEnforceLocalMaxMemoryFull() throws
UnknownHostException {
Review Comment:
This test case is still passing without the fix in MemberRollup.java. Why
was it changed?
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
This test case is still passing without the fix in MemberRollup.java. Why
was it changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
mivanac commented on code in PR #7856:
URL: https://github.com/apache/geode/pull/7856#discussion_r972039027
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
Review Comment:
Thanks for comment. It seems if partitioned region is created on just a
group of servers, this check is not valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jvarenina commented on a diff in pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
jvarenina commented on code in PR #7856:
URL: https://github.com/apache/geode/pull/7856#discussion_r971989985
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
Review Comment:
This code will reject a start clean queue command when you execute it for a
particular group of servers when there are multiple groups of servers. Could it
be possible to check that only servers in the provided group have configured
senders and continue?
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
+
+ GatewaySenderMXBean bean;
+ boolean commmandRejected = false;
+
+ ResultModel rejectResultModel =
+ ResultModel.createError(CliStrings.START_GATEWAYSENDER_REJECTED);
+ TabularResultModel rejectResultData =
+
rejectResultModel.addTable(CliStrings.REJECT_START_GATEWAYSENDER_REASON);
+
+ for (DistributedMember member : dsMembers) {
+if
(cache.getDistributedSystem().getDistributedMember().getId().equals(member.getId()))
{
+ bean = service.getLocalGatewaySenderMXBean(senderId);
+} else {
+ ObjectName objectName = service.getGatewaySenderMBeanName(member,
senderId);
+ bean = service.getMBeanProxy(objectName, GatewaySenderMXBean.class);
+}
+if (bean != null) {
+ if (bean.isRunning()) {
+commmandRejected = true;
+rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+CliStrings.format(
+
CliStrings.GATEWAY_SENDER_0_IS_ALREADY_STARTED_ON_MEMBER_1, id,
+member.getId()));
+ }
+} else {
+ commmandRejected = true;
+ rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+ CliStrings.format(
+ CliStrings.GATEWAY_SENDER_0_IS_NOT_AVAILABLE_ON_MEMBER_1,
id, member.getId()));
+}
+ }
Review Comment:
The same checks are performed just a few lines below in callable objects
which execute the command on a member. Do we need still need those checks? Or,
If they are required, is it possible to create a function that encapsulates
them to avoid duplicated code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett closed pull request #899: GEODE-9896: Upgrades dependencies.
pivotal-jbarrett closed pull request #899: GEODE-9896: Upgrades dependencies. URL: https://github.com/apache/geode-native/pull/899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on pull request #899: GEODE-9896: Upgrades dependencies.
gaussianrecurrence commented on PR #899: URL: https://github.com/apache/geode-native/pull/899#issuecomment-1248021514 Considering geode-native is not using ACE anymore and SQLite was already updated, and also there is another PR to update Boost, maybe this can be closed @pivotal-jbarrett ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
gaussianrecurrence commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r971864236
##
docker/ubuntu-22.04/Dockerfile:
##
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+apt -yq full-upgrade && \
+apt-get -y install \
+apt-transport-https \
+ca-certificates \
+curl \
+gnupg2 \
+software-properties-common && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+RUN . /etc/os-release && \
+curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add -
&& \
+apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+build-essential \
+libc++-dev \
+libc++abi-dev \
+zlib1g-dev \
+libssl-dev \
+bellsoft-java11 \
+git \
+doxygen \
+graphviz \
+clang-format-12 && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+# Get latest release of CMake ignoring pre-releases
+RUN installer=$(mktemp) \
+&& curl -o ${installer} -L $(curl -s
https://api.github.com/repos/Kitware/CMake/releases \
+| grep -P -i
'browser_download_url.*cmake-\d+\.\d+\.\d+-linux-x86_64\.sh' \
+| head -n 1 \
+| cut -d : -f 2,3 \
+| tr -d '"') \
+&& bash ${installer} --skip-license --prefix=/usr/local \
+&& rm ${installer}
+
+ARG GEODE_VERSION=1.14.4
Review Comment:
Considering latest version is 1.15.0, maybe this needs to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jvarenina opened a new pull request, #7859: GEODE-8856: Persist gateway-sender startup-action
jvarenina opened a new pull request, #7859: URL: https://github.com/apache/geode/pull/7859 New startup-action parameter with values "stop", "pause" and "start" is now persisted during the runtime when following commands are issued: - pause gateway-sender --> startup-action="pause" - stop gateway-sender --> startup-action="stop" - start gateway-sender --> startup-action="start" - resume gateway-sender --> startup-action="start" The startup-action parameter is persisted within cluster configuration when above gfsh commands are executed successfully on at least one of the servers. Parameter is not updated and persisted when commands are executed per member as cluster configuration is not persisted in that case. New startup-action parameter will now inter-work with manual-start in a following way: - If manual-start="true" and startup-action parameter is missing, then gateway sender will require manual start (same as before). - If manual-start is not set (or "false") and startup-action parameter is missing, then gateway sender will be started automatically (same as before). - If parameter startup-action is available in cluster configuration at startup, then gateway-sender will try to reach that state regardless of manual-start parameter value. The manual-start is also improved in order to fully comply to above requirement to start gateway sender in stopped state. Current problem with manual-start parameter: Currently, when manual-start is configured to be "true", then colocated persistent parallel gateway sender queue region and buckets are not recovered after server is restarted. Because of that the main persistent region that is colocated with gateway sender queue region cannot reach online status. Solution to manual-start problem implemented in this commit: When manual-start parameter is "true" or gateway sender startup-action is "stop", then persistent parallel gateway-sender queues will now be recovered (if needed) from persistent storage during startup of the server. Queues will be recovered by using the existing mechanism that is used when gateway sender is automatically recovered (manual-start==false) after server is restarted. In this case parallel gateway sender queue persistent region and buckets are recovered (if needed) right after the main persistent region and buckets are recovered. Additionally in above case, parallel gateway sender will now reach the same state that it has when first started and then stopped by using gfsh command. In that state parallel gateway sender queue buckets remain on the servers, but dispatcher threads are stopped and non of the events are stored in queues. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
