Re: [PR] When using C++20, optionally add in comma for varargs [logging-log4cxx]
rm5248 merged PR #345: URL: https://github.com/apache/logging-log4cxx/pull/345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] When using C++20, optionally add in comma for varargs [logging-log4cxx]
rm5248 commented on PR #345: URL: https://github.com/apache/logging-log4cxx/pull/345#issuecomment-1927159573 Unfortunately since this is a C++20 only fix, that build would fail with earlier versions. The optional GCC fix as well (`##__VA_ARGS__`) only works if GNU extensions are enabled. So it works if you compile with `-std=gnu++11` but fails with `-std=c++11`. There doesn't seem to be a way to test if this is enabled or not at compile time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] When using C++20, optionally add in comma for varargs [logging-log4cxx]
swebb2066 commented on PR #345: URL: https://github.com/apache/logging-log4cxx/pull/345#issuecomment-1926165572 You can now also undo the [changes in throughput](https://github.com/apache/logging-log4cxx/commit/21f0f12a9bd378cb1b62c0b6218190dcf52ae938#diff-1cf073c63cc93390ba8ee8bc2163a5b77aec896f5187964137de44a57c1c6a47) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] When using C++20, optionally add in comma for varargs [logging-log4cxx]
rm5248 opened a new pull request, #345: URL: https://github.com/apache/logging-log4cxx/pull/345 See: #344 The FMT macros now work with only one argument when using C++20 or greater. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
