[GitHub] [netbeans] jlahoda opened a new pull request #1876: Fixing the VS Code extension build by using new TypeScript to build it.
jlahoda opened a new pull request #1876: Fixing the VS Code extension build by using new TypeScript to build it. URL: https://github.com/apache/netbeans/pull/1876 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi merged pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367212250 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: OK, they seem to be really close in the existing defaults as well. Maybe they're supposed to look the same... (nevermind this comment, I was looking at the BlueTheme) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367213204 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: Sure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367213008 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: Honestly I do not know. I'd leave it for the "community test-pad" If someone find an incurred and the coloring disturbed, let's change it until then, it is Ok. Unless I find an incurred line first... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574962625 (Oh, I assumed the BlueTheme was the existing one, so I didn't review the colors for that one.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574962376 Can't figure out how to change my review to "Approve" (github might get confused by force pushes), but feel free to merge... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367212250 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: OK, they seem to be really close in the existing defaults as well. Maybe they're supposed to look the same... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367211513 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + Review comment:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367210829 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + Review comment:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367210889 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + Review comment: Not bad after all. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367210829 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + Review comment:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367209353 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: Well, that's a good question. Tried to look it up on jacoco, found nothing. Maybe did not try hard enough. I have not seen any sample where it is came up. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574957856 You are right the original defaults are reddish. I kept them for the original theme. The not to be that red is just my own opinion on the topic. For me red means bad. For me if something is not covered it is not bad, just not covered. Though I completely understand the other viewpoint as you turned on the code coverage for a reason... That's it. If you propose to stick with some reds, then please suggest some colors for the blue and darklaf theme, I'm going to include those. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark
eirikbakke commented on a change in pull request #1873: [NETBEANS-3428] Remove
experimental from FlatLafDark
URL: https://github.com/apache/netbeans/pull/1873#discussion_r367208178
##
File path:
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/Installer.java
##
@@ -26,16 +26,14 @@
@NbBundle.Messages({
"LBL_FLATLAF_LIGHT=FlatLaf Light (experimental)",
Review comment:
Sure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207379 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: What does "inferred" mean? This green color is almost identical to that of nbcoverage-covered. It should be some distinct color. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207379 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: What does "inferred" mean? This green color is almost identical to that of nbcoverage-covered. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207918 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + Review comment: This one is a neutral grey, but it should be some variant of red. Perhaps try 813438 instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207053 ## File path: ide/defaults/src/org/netbeans/modules/defaults/BlueTheme-editor.xml ## @@ -62,4 +62,9 @@ + + + + Review comment: Let it be. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574955137 Hold on, let me test the colors in photoshop... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574954562 Actually, one possible objection to the colors... shouldn't the "uncovered" color be red-ish, like in the light theme? Right now it's neutral grey, which does not communicate the same concept. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367205572 ## File path: ide/defaults/src/org/netbeans/modules/defaults/BlueTheme-editor.xml ## @@ -62,4 +62,9 @@ + + + + Review comment: Why "nbcoverage"? Perhaps just "coverage"? (Everything in NetBeans is NetBeans...) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on issue #1845: Adding LICENSE/NOTICE for the VisualStudio Code extension for Java
junichi11 commented on issue #1845: Adding LICENSE/NOTICE for the VisualStudio Code extension for Java URL: https://github.com/apache/netbeans/pull/1845#issuecomment-574950390 @jlahoda It seems that Travis CI failed with the master branch after this was merged. Could you please take a look at it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi opened a new pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi opened a new pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875 The Options Panel:  The default colors:  Norway Today:  FlatLaf Dark:  Well these are the colors I could came up with, I guess they could be improved by someone more artistic than me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] laryn opened a new pull request #1874: Spelling fix: intented -> intended
laryn opened a new pull request #1874: Spelling fix: intented -> intended URL: https://github.com/apache/netbeans/pull/1874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark
lkishalmi merged pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark URL: https://github.com/apache/netbeans/pull/1873 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-website] vieiro opened a new pull request #434: [NETBEANS-1870] Reviewing the Asciidoc of PHP tutorials
vieiro opened a new pull request #434: [NETBEANS-1870] Reviewing the Asciidoc of PHP tutorials URL: https://github.com/apache/netbeans-website/pull/434 Cleaning up the Asciidoc of some PHP tutorials... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #1872: [NETBEANS-3695] - not proper to use a static variable through a refer…
BradWalker commented on a change in pull request #1872: [NETBEANS-3695] - not
proper to use a static variable through a refer…
URL: https://github.com/apache/netbeans/pull/1872#discussion_r367040956
##
File path:
ide/team.commons/src/org/netbeans/modules/bugtracking/commons/LinkButton.java
##
@@ -119,10 +119,10 @@ public LinkButton() {
}
public void setColors(Color linkColor, Color linkInFocusColor, Color
mouseOverLinkColor, Color visitedLinkColor) {
-this.linkInFocusColor = linkInFocusColor;
-this.linkColor = linkColor;
-this.mouseOverLinkColor = mouseOverLinkColor;
-this.visitedLinkColor = visitedLinkColor;
+linkInFocusColor = linkInFocusColor;
+linkColor = linkColor;
+mouseOverLinkColor = mouseOverLinkColor;
+visitedLinkColor = visitedLinkColor;
Review comment:
No problem. It's now changed.. Thanks for the feedback..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mklaehn commented on a change in pull request #1872: [NETBEANS-3695] - not proper to use a static variable through a refer…
mklaehn commented on a change in pull request #1872: [NETBEANS-3695] - not
proper to use a static variable through a refer…
URL: https://github.com/apache/netbeans/pull/1872#discussion_r367028572
##
File path:
ide/team.commons/src/org/netbeans/modules/bugtracking/commons/LinkButton.java
##
@@ -119,10 +119,10 @@ public LinkButton() {
}
public void setColors(Color linkColor, Color linkInFocusColor, Color
mouseOverLinkColor, Color visitedLinkColor) {
-this.linkInFocusColor = linkInFocusColor;
-this.linkColor = linkColor;
-this.mouseOverLinkColor = mouseOverLinkColor;
-this.visitedLinkColor = visitedLinkColor;
+linkInFocusColor = linkInFocusColor;
+linkColor = linkColor;
+mouseOverLinkColor = mouseOverLinkColor;
+visitedLinkColor = visitedLinkColor;
Review comment:
Short answer something like `LinkButton.linkInFocusColor = linkInFocusColor`
for these four.
Long answer: If you simply remove the `this.` you essentially assign the
method parameter to itself. Highlighting in NetBeans Editor will show that as
well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #1872: [NETBEANS-3695] - not proper to use a static variable through a refer…
BradWalker commented on a change in pull request #1872: [NETBEANS-3695] - not
proper to use a static variable through a refer…
URL: https://github.com/apache/netbeans/pull/1872#discussion_r367025507
##
File path:
ide/team.commons/src/org/netbeans/modules/bugtracking/commons/LinkButton.java
##
@@ -119,10 +119,10 @@ public LinkButton() {
}
public void setColors(Color linkColor, Color linkInFocusColor, Color
mouseOverLinkColor, Color visitedLinkColor) {
-this.linkInFocusColor = linkInFocusColor;
-this.linkColor = linkColor;
-this.mouseOverLinkColor = mouseOverLinkColor;
-this.visitedLinkColor = visitedLinkColor;
+linkInFocusColor = linkInFocusColor;
+linkColor = linkColor;
+mouseOverLinkColor = mouseOverLinkColor;
+visitedLinkColor = visitedLinkColor;
Review comment:
In it's original form, here is the warning emitted..
```
[repeat]
/home/bwalker/src/netbeans/ide/team.commons/src/org/netbeans/modules/bugtracking/commons/LinkButton.java:122:
warning: [static] static variable should be qualified by type name,
LinkButton, instead of by an expression
[repeat] this.linkInFocusColor = linkInFocusColor;
[repeat] ^
[repeat]
/home/bwalker/src/netbeans/ide/team.commons/src/org/netbeans/modules/bugtracking/commons/LinkButton.java:123:
warning: [static] static variable should be qualified by type name,
LinkButton, instead of by an expression
[repeat] this.linkColor = linkColor;
[repeat] ^
[repeat]
/home/bwalker/src/netbeans/ide/team.commons/src/org/netbeans/modules/bugtracking/commons/LinkButton.java:124:
warning: [static] static variable should be qualified by type name,
LinkButton, instead of by an expression
[repeat] this.mouseOverLinkColor = mouseOverLinkColor;
[repeat] ^
[repeat]
/home/bwalker/src/netbeans/ide/team.commons/src/org/netbeans/modules/bugtracking/commons/LinkButton.java:125:
warning: [static] static variable should be qualified by type name,
LinkButton, instead of by an expression
[repeat] this.visitedLinkColor = visitedLinkColor;
[repeat] ^
```
Which seems correct as these variables are declared static in the class. So
by accessing them via the self reference is not correct and the compiler is
warning us. Nor is providing a fully qualified class name the correct way to
fix this. These variables are declared as static in the class so they have
"global" reference.
What would you like for me to change it to?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark
lkishalmi commented on a change in pull request #1873: [NETBEANS-3428] Remove
experimental from FlatLafDark
URL: https://github.com/apache/netbeans/pull/1873#discussion_r366923297
##
File path:
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/Installer.java
##
@@ -26,16 +26,14 @@
@NbBundle.Messages({
"LBL_FLATLAF_LIGHT=FlatLaf Light (experimental)",
Review comment:
Well, I think it was tested less than the dark one and probably needs a
fitting FlatLaf Light color theme, however thinking it over it is not worse
than the Dark Nimbus or Dark Metal, so let's remove the experimental from there
as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1873: [NETBEANS-3428] Remove experimental from FlatLafDark
eirikbakke commented on a change in pull request #1873: [NETBEANS-3428] Remove
experimental from FlatLafDark
URL: https://github.com/apache/netbeans/pull/1873#discussion_r366878368
##
File path:
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/Installer.java
##
@@ -26,16 +26,14 @@
@NbBundle.Messages({
"LBL_FLATLAF_LIGHT=FlatLaf Light (experimental)",
Review comment:
Is the light version still experimental?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on issue #1746: [NETBEANS-3552] - Upgrade GraalVM from 19.0.0 to 19.3.0
JaroslavTulach commented on issue #1746: [NETBEANS-3552] - Upgrade GraalVM from 19.0.0 to 19.3.0 URL: https://github.com/apache/netbeans/pull/1746#issuecomment-574639033 GraalVM 19.3.x is the LTS version of GraalVM. Now, when the release has been shifted, it might make sense to update to it once the Travis jobs are stable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
