[jira] [Commented] (OFBIZ-6958) Adding event definitions for inbound and outbound shipments

2018-11-23 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697681#comment-16697681
 ] 

Jacques Le Roux commented on OFBIZ-6958:


Thanks Suraj

> Adding event definitions for inbound and outbound shipments
> ---
>
> Key: OFBIZ-6958
> URL: https://issues.apache.org/jira/browse/OFBIZ-6958
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product, workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: purpose, shipment, workeffort
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6958-ShipmentServices.xml.patch, 
> OFBIZ-6958-WorkEffortTypeData.xml.patch
>
>
> When inbound and outbound shipments are registered also WorkEffort records 
> are persisted. 
> * This action doesn't set the workEffortPurposeTypeId for the created work 
> efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10663) Amount field is editable at Product Detail Page

2018-11-23 Thread Dikpal Kanungo (JIRA)
Dikpal Kanungo created OFBIZ-10663:
--

 Summary: Amount field is editable at Product Detail Page
 Key: OFBIZ-10663
 URL: https://issues.apache.org/jira/browse/OFBIZ-10663
 Project: OFBiz
  Issue Type: Bug
  Components: ecommerce
Reporter: Dikpal Kanungo
 Attachments: Editable amount.png, Missing Heading.png

The customer is able to enter the price of a product from the product detail 
page which should not happen.

Steps to regenerate-

Open - ofbiz demo trunk for ecomm.
Click on the product - Tiny Gizmo  
Try editing the Amount field.

--

Click on product - .NIT Gizmo

Quantity text is missing and No value is coming in reference to Amount heading.

Please have a look at the attached screenshots.

Cheers,
Dikpal !Missing Heading.png!

 

 

 

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10662) Create customer page validations not working correctly

2018-11-23 Thread Sanjay Yadav (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanjay Yadav updated OFBIZ-10662:
-
Attachment: FieldValidationNotWorking.png

> Create customer page validations not working correctly
> --
>
> Key: OFBIZ-10662
> URL: https://issues.apache.org/jira/browse/OFBIZ-10662
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Reporter: Sanjay Yadav
>Priority: Major
> Attachments: FieldValidationNotWorking.png
>
>
> Steps to Regenerate issue:
>  # Login to demo-trunk or demo-stable instance with details:
> URL - https://demo-trunk.ofbiz.apache.org/partymgr/control/createCustomer
> admin/ ofbiz  OR
>  # Go to Party > Create Customer
>  # Enter the value in the First name and Last name field.
>  # Click on the Save button.
> Actual - System generates same single validation message..irrespective of 
> blank fields. Please refer to attachment.
> Expected - Validation message should be generated correctly and field wise. 
> Also, the order of the message should be same as filed order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-9913) Payment capturing twice on single action

2018-11-23 Thread Amit Gadaley (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley resolved OFBIZ-9913.
-
   Resolution: Cannot Reproduce
Fix Version/s: Trunk

> Payment capturing twice on single action
> 
>
> Key: OFBIZ-9913
> URL: https://issues.apache.org/jira/browse/OFBIZ-9913
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Padmavati Rawat
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Trunk
>
>
> Steps:
> 1. Navigate order component.
> 2. Set customer and select product for the order.
> 3. Set payment method ( Credit Card and EFT Account )  and shipping method 
> for the corresponding order.
> 4. Create an order.
> 5. Captured amount in associated payment method.
> Actual:
> Payment capturing twice on single action on view order screen.
> Expected:
> Payment should captured single time on single action.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10662) Create customer page validations not working correctly

2018-11-23 Thread Sanjay Yadav (JIRA)
Sanjay Yadav created OFBIZ-10662:


 Summary: Create customer page validations not working correctly
 Key: OFBIZ-10662
 URL: https://issues.apache.org/jira/browse/OFBIZ-10662
 Project: OFBiz
  Issue Type: Bug
  Components: party
Reporter: Sanjay Yadav
 Attachments: FieldValidationNotWorking.png

Steps to Regenerate issue:
 # Login to demo-trunk or demo-stable instance with details:

URL - https://demo-trunk.ofbiz.apache.org/partymgr/control/createCustomer

admin/ ofbiz  OR
 # Go to Party > Create Customer
 # Enter the value in the First name and Last name field.
 # Click on the Save button.

Actual - System generates same single validation message..irrespective of blank 
fields. Please refer to attachment.

Expected - Validation message should be generated correctly and field wise. 
Also, the order of the message should be same as filed order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-6932) In the case of MARKETING_PKG_PICK the invoice gets created of product components, Ideally the invoice should be created of package.

2018-11-23 Thread Amit Gadaley (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley resolved OFBIZ-6932.
-
   Resolution: Pending Closed
Fix Version/s: Trunk

Waiting for others to close this ticket.

> In the case of MARKETING_PKG_PICK the invoice gets created of product 
> components, Ideally the invoice should be created of package.
> ---
>
> Key: OFBIZ-6932
> URL: https://issues.apache.org/jira/browse/OFBIZ-6932
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Yashwant Dhakad
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Trunk
>
>
> Steps to reproduce:
> 1. Create sales order with MARKETING_PKG_PICK.
> 2. Completed the order with its shipment.
> 3. Invoice should be created.
> Actual: Invoice created with its components.
> Expected: Invoice should be created for its package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6932) In the case of MARKETING_PKG_PICK the invoice gets created of product components, Ideally the invoice should be created of package.

2018-11-23 Thread Amit Gadaley (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697666#comment-16697666
 ] 

Amit Gadaley commented on OFBIZ-6932:
-

Reviewed the order fulfillment and invoice creation processes for pick type of 
kit products. It is working as expected. Invoice is created for pick type of 
kit products, not for its components.

> In the case of MARKETING_PKG_PICK the invoice gets created of product 
> components, Ideally the invoice should be created of package.
> ---
>
> Key: OFBIZ-6932
> URL: https://issues.apache.org/jira/browse/OFBIZ-6932
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Yashwant Dhakad
>Assignee: Amit Gadaley
>Priority: Major
>
> Steps to reproduce:
> 1. Create sales order with MARKETING_PKG_PICK.
> 2. Completed the order with its shipment.
> 3. Invoice should be created.
> Actual: Invoice created with its components.
> Expected: Invoice should be created for its package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10659) Issue while updating product qty on order entry page

2018-11-23 Thread Pradeep Choudhary (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary reassigned OFBIZ-10659:
-

Assignee: Pradeep Choudhary

> Issue while updating product qty on order entry page
> 
>
> Key: OFBIZ-10659
> URL: https://issues.apache.org/jira/browse/OFBIZ-10659
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Padmavati Rawat
>Assignee: Pradeep Choudhary
>Priority: Major
>
> Steps:
> 1. Navigate to the Order entry page.
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
> 2. Add Item in the cart.
> 3. After adding Item in cart refresh the page and check the order item qty.
> 4. Change the Item qty and click outside of qty field to save the changes.
> Actual;
> 1. Quantity not getting updated on clicking outside the field. 
> 2. Product qty automatically increased by one on every page refresh action.
> Expected:
> 1. Product qty should be updated on clicking outside the qty field.
> 2. Product qty should not be changed on page refresh.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10661) Significant gaps reflecting in between Input values in the dropdown

2018-11-23 Thread Archana Asthana (JIRA)
Archana Asthana created OFBIZ-10661:
---

 Summary: Significant gaps reflecting in between Input values in 
the dropdown
 Key: OFBIZ-10661
 URL: https://issues.apache.org/jira/browse/OFBIZ-10661
 Project: OFBiz
  Issue Type: Bug
 Environment: 
https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond
Reporter: Archana Asthana
 Attachments: ValueDropdown.png

Steps to Regenerate
1. Open 
https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond
2. Add the name for a new Price Rule
3. While adding Condition, choose input as Party
4. Scroll down the end for Values reflecting in the dropdown

*Actual: *
Seems, Some of the parties are not listed in the dropdown.
Significant gap is reflecting in between the values.
The Image is attached for reference




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10661) Significant gaps reflecting in between Input values in the dropdown

2018-11-23 Thread Archana Asthana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana Asthana updated OFBIZ-10661:

Attachment: ValueDropdown.png

> Significant gaps reflecting in between Input values in the dropdown
> ---
>
> Key: OFBIZ-10661
> URL: https://issues.apache.org/jira/browse/OFBIZ-10661
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond
>Reporter: Archana Asthana
>Priority: Major
> Attachments: ValueDropdown.png
>
>
> Steps to Regenerate
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond
> 2. Add the name for a new Price Rule
> 3. While adding Condition, choose input as Party
> 4. Scroll down the end for Values reflecting in the dropdown
> *Actual: *
> Seems, Some of the parties are not listed in the dropdown.
> Significant gap is reflecting in between the values.
> The Image is attached for reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10580) Classification group filter not working on find party screen

2018-11-23 Thread Saurabh Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697664#comment-16697664
 ] 

Saurabh Dixit commented on OFBIZ-10580:
---

Attached the patch for the issue.

> Classification group filter not working on find party screen
> 
>
> Key: OFBIZ-10580
> URL: https://issues.apache.org/jira/browse/OFBIZ-10580
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk, 16.11.04
>Reporter: Anushi Gupta
>Assignee: Saurabh Dixit
>Priority: Major
> Attachments: OFBIZ-10580.patch
>
>
> Steps to regenerate:
>  # Login to 
> partymgr([[https://demo-trunk.ofbiz.apache.org/partymgr/control/findparty])]
>  # Select classification group (if present, otherwise create new group) and 
> find party
> Actual :
> All parties are listed on searching
> Expected :
> Parties which are under the selected classification group should only be 
> listed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10580) Classification group filter not working on find party screen

2018-11-23 Thread Saurabh Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Saurabh Dixit updated OFBIZ-10580:
--
Attachment: OFBIZ-10580.patch

> Classification group filter not working on find party screen
> 
>
> Key: OFBIZ-10580
> URL: https://issues.apache.org/jira/browse/OFBIZ-10580
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk, 16.11.04
>Reporter: Anushi Gupta
>Assignee: Saurabh Dixit
>Priority: Major
> Attachments: OFBIZ-10580.patch
>
>
> Steps to regenerate:
>  # Login to 
> partymgr([[https://demo-trunk.ofbiz.apache.org/partymgr/control/findparty])]
>  # Select classification group (if present, otherwise create new group) and 
> find party
> Actual :
> All parties are listed on searching
> Expected :
> Parties which are under the selected classification group should only be 
> listed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-6958) Adding event definitions for inbound and outbound shipments

2018-11-23 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-6958.
--
Resolution: Fixed

There was a minor typo. It should be INCOMING_SHIPMENT instead of 
INGOING_SHIPMENT.

This has been fixed at

ofbiz framework trunk at r#1847338
ofbiz framework R17.12 at r#1847339
ofbiz 16.11 at r#1847340

> Adding event definitions for inbound and outbound shipments
> ---
>
> Key: OFBIZ-6958
> URL: https://issues.apache.org/jira/browse/OFBIZ-6958
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product, workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: purpose, shipment, workeffort
> Attachments: OFBIZ-6958-ShipmentServices.xml.patch, 
> OFBIZ-6958-WorkEffortTypeData.xml.patch
>
>
> When inbound and outbound shipments are registered also WorkEffort records 
> are persisted. 
> * This action doesn't set the workEffortPurposeTypeId for the created work 
> efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-6958) Adding event definitions for inbound and outbound shipments

2018-11-23 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-6958.


> Adding event definitions for inbound and outbound shipments
> ---
>
> Key: OFBIZ-6958
> URL: https://issues.apache.org/jira/browse/OFBIZ-6958
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product, workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: purpose, shipment, workeffort
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6958-ShipmentServices.xml.patch, 
> OFBIZ-6958-WorkEffortTypeData.xml.patch
>
>
> When inbound and outbound shipments are registered also WorkEffort records 
> are persisted. 
> * This action doesn't set the workEffortPurposeTypeId for the created work 
> efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10403) Multiple services for checking party permissions

2018-11-23 Thread Humera Khan (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan updated OFBIZ-10403:

Affects Version/s: Trunk

> Multiple services for checking party permissions
> 
>
> Key: OFBIZ-10403
> URL: https://issues.apache.org/jira/browse/OFBIZ-10403
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Humera Khan
>Priority: Major
>
> Found two different services for check party permission:
> *ServiceUtil.java* has _getPartyIdCheckSecurity_
> *PartyPermissionServices.xml* has _partyIdPermissionCheck_
> _getPartyIdCheckSecurity_ can be deleted as it is not in proper place and 
> some enhancements (check admin permission) could be done in 
> _partyIdPermissionCheck_ so that single permission service could be used for 
> partyId permission checking.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10623) Error message is displayed on ecommerce when user tries to use Split shipment functionality

2018-11-23 Thread Praveen Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697662#comment-16697662
 ] 

Praveen Sharma commented on OFBIZ-10623:


Attaching patch for the same OFBIZ-10623

> Error message is displayed on ecommerce when user tries to use Split shipment 
> functionality
> ---
>
> Key: OFBIZ-10623
> URL: https://issues.apache.org/jira/browse/OFBIZ-10623
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
> Environment: https://demo-trunk.ofbiz.apache.org/ecommerce
>Reporter: Arpit Mor
>Assignee: Praveen Sharma
>Priority: Major
> Attachments: 1-Checkout.png, 2-SplitShipment.png, 3-ErrorMessage.png, 
> OFBIZ-10623.patch
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  # Add multiple items to cart
>  # Click on Check Out on cart summary (Please refer attachment: 1-Checkout)
>  # Click on split shipment (Please refer attachment: 2-SplitShipment)
> Actual: Error message is displayed when user clicks on split shipment (Please 
> refer attachment: 3-ErrorMessage)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10623) Error message is displayed on ecommerce when user tries to use Split shipment functionality

2018-11-23 Thread Praveen Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma updated OFBIZ-10623:
---
Attachment: OFBIZ-10623.patch

> Error message is displayed on ecommerce when user tries to use Split shipment 
> functionality
> ---
>
> Key: OFBIZ-10623
> URL: https://issues.apache.org/jira/browse/OFBIZ-10623
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
> Environment: https://demo-trunk.ofbiz.apache.org/ecommerce
>Reporter: Arpit Mor
>Assignee: Praveen Sharma
>Priority: Major
> Attachments: 1-Checkout.png, 2-SplitShipment.png, 3-ErrorMessage.png, 
> OFBIZ-10623.patch
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  # Add multiple items to cart
>  # Click on Check Out on cart summary (Please refer attachment: 1-Checkout)
>  # Click on split shipment (Please refer attachment: 2-SplitShipment)
> Actual: Error message is displayed when user clicks on split shipment (Please 
> refer attachment: 3-ErrorMessage)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7670) OFBIZ-7517:SpecialPurpose/ecommerce: Correct all the checkboxes and radio buttons in all the ecommerce FTLs.

2018-11-23 Thread Chandrashekhar Dhakad (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandrashekhar Dhakad updated OFBIZ-7670:
-
Attachment: RadioButtonsAndCheckboxesUI.png

> OFBIZ-7517:SpecialPurpose/ecommerce: Correct all the checkboxes and radio 
> buttons in all the ecommerce FTLs.
> 
>
> Key: OFBIZ-7670
> URL: https://issues.apache.org/jira/browse/OFBIZ-7670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: 16.11.01
>Reporter: Mohammad Kathawala
>Assignee: Chandrashekhar Dhakad
>Priority: Minor
> Attachments: OFBIZ-7670.patch, RadioButtonsAndCheckboxesUI.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10500) Tax calculation incorrect when creating orders

2018-11-23 Thread Ankush Upadhyay (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay reassigned OFBIZ-10500:
---

Assignee: Ankush Upadhyay

> Tax calculation incorrect when creating orders
> --
>
> Key: OFBIZ-10500
> URL: https://issues.apache.org/jira/browse/OFBIZ-10500
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
> Environment: OpenJDK 1.8.0_151 64bit on Ubuntu 16.04
>Reporter: Frank Herrman
>Assignee: Ankush Upadhyay
>Priority: Major
> Attachments: Schermafbeelding 2018-07-30 om 10.15.51.png, 
> Schermafbeelding 2018-07-30 om 10.16.16.png
>
>
> After a 
> [discussion|https://lists.apache.org/thread.html/adf568edad92255340697f78ea4f34a07e328cc1689b8fb73e16fa53@%3Cuser.ofbiz.apache.org%3E]
>  on the user mailinglist we concluded there seems to be an issue with the tax 
> calculations.
> *Steps to reproduce*
>  * Create a tax authority for a specific country (e.g. The Netherlands in my 
> case)
>  * Set sales tax rate of 21% for your store with this Tax Authority
>  * Create a product and enter a price either including or excluding taxes and 
> set the corresponding flag for tax included y/n.
>  * Go to the order manager and order entry. Fill in the details, select the 
> product and go to the review page. It now shows the incorrect sales tax and 
> price.
> Let's say we have a product of 20 euro incl. taxes. With 21% that comes down 
> to 3.47 euro of taxes and a price of 16.53 euro. Instead Ofbiz shows a price 
> of 20 euro excl. taxes and adds 4.20 euros in taxes.
> *What I tried*
> Changing the price to price excl. VAT and set the flag to 'N' and visa versa. 
> Both gave the same error. 
> *Possible solution*
> I digged into the code and ended up in the file:
> {{ applications/order/groovyScripts/entry/OrderReadHelper.java}}
> The function in line 2401
> {code:java}
> public static BigDecimal getOrderItemSubTotal(GenericValue orderItem, 
> List adjustments, boolean forTax, boolean forShipping){code}
> returns the price of one item there. It uses this piece of code:
> {code:java}
> orderItem.getBigDecimal("unitPrice");{code}
> The line item is always the price including taxes. When I adjust this price 
> (by dividing it by 1.21) I do get the correct price in the review page. I do 
> not, however, get the right tax amount. This is calculated elsewhere and 
> still using the 20 euro price I guess. Anyway, it does show I was in the 
> right spot.
> I'm not familiar enough with Ofbiz to create a full patch, but I think the 
> easiest way to go is to add another column to order items where the value 
> excl. taxes is stored which can be used in places where needed. This does not 
> affect the whole system. On the other hand I'm not sure where the order items 
> are stored, since when you are on the review page it is not stored in 
> database yet. Probably just in the session? Should make things even easier.
> The attachments show an example. I have stored a product of 20 euro 
> (screenshot directly taken from the database tool) and I have set-up a tax 
> exempt in this case for a customer which shows 4.20 euro sales tax. If I turn 
> off the tax exempt the grand total becomes 24.20 euros, so it is not related 
> to the exempt.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10660) Similar values reflecting twice on Add Action Type dropdown in Pricerule

2018-11-23 Thread Archana Asthana (JIRA)
Archana Asthana created OFBIZ-10660:
---

 Summary: Similar values reflecting twice on Add Action Type 
dropdown in Pricerule
 Key: OFBIZ-10660
 URL: https://issues.apache.org/jira/browse/OFBIZ-10660
 Project: OFBiz
  Issue Type: Bug
 Environment: 
https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond
Reporter: Archana Asthana
 Attachments: ActionTypeDropdown.png

Steps to Regenerate
1. Open 
https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond
2. Add the name for a new Price Rule
3. Add Condition and go to Add Action panel
4. Check the dropdown values under Action Type

*Actual: *
Same value reflecting twice in the dropdown ( Flat Amount Modify)
The Image is attached for reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10118) Update multifex theme as per new markup

2018-11-23 Thread Parakh Maheshwari (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Parakh Maheshwari reassigned OFBIZ-10118:
-

Assignee: Parakh Maheshwari  (was: Nitish Mishra)

> Update multifex theme as per new markup
> ---
>
> Key: OFBIZ-10118
> URL: https://issues.apache.org/jira/browse/OFBIZ-10118
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Reporter: Deepak Dixit
>Assignee: Parakh Maheshwari
>Priority: Major
>
> As we are updating UX of ecommerce site, this breaks the multifex them of 
> ecommerce.
> Need to update css rule of multiflex theme as per new markup. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-23 Thread Rohit Koushal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal reassigned OFBIZ-5048:


Assignee: Rohit Koushal  (was: Jacques Le Roux)

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: GroovyEventMultipartParametes.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10659) Issue while updating product qty on order entry page

2018-11-23 Thread Padmavati Rawat (JIRA)
Padmavati Rawat created OFBIZ-10659:
---

 Summary: Issue while updating product qty on order entry page
 Key: OFBIZ-10659
 URL: https://issues.apache.org/jira/browse/OFBIZ-10659
 Project: OFBiz
  Issue Type: Bug
  Components: order
Reporter: Padmavati Rawat


Steps:
1. Navigate to the Order entry page.
[https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
2. Add Item in the cart.
3. After adding Item in cart refresh the page and check the order item qty.
4. Change the Item qty and click outside of qty field to save the changes.

Actual;
1. Quantity not getting updated on clicking outside the field. 
2. Product qty automatically increased by one on every page refresh action.

Expected:
1. Product qty should be updated on clicking outside the qty field.
2. Product qty should not be changed on page refresh.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10403) Multiple services for checking party permissions

2018-11-23 Thread Humera Khan (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan reassigned OFBIZ-10403:
---

Assignee: Humera Khan

> Multiple services for checking party permissions
> 
>
> Key: OFBIZ-10403
> URL: https://issues.apache.org/jira/browse/OFBIZ-10403
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Suraj Khurana
>Assignee: Humera Khan
>Priority: Major
>
> Found two different services for check party permission:
> *ServiceUtil.java* has _getPartyIdCheckSecurity_
> *PartyPermissionServices.xml* has _partyIdPermissionCheck_
> _getPartyIdCheckSecurity_ can be deleted as it is not in proper place and 
> some enhancements (check admin permission) could be done in 
> _partyIdPermissionCheck_ so that single permission service could be used for 
> partyId permission checking.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-6932) In the case of MARKETING_PKG_PICK the invoice gets created of product components, Ideally the invoice should be created of package.

2018-11-23 Thread Amit Gadaley (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley reassigned OFBIZ-6932:
---

Assignee: Amit Gadaley

> In the case of MARKETING_PKG_PICK the invoice gets created of product 
> components, Ideally the invoice should be created of package.
> ---
>
> Key: OFBIZ-6932
> URL: https://issues.apache.org/jira/browse/OFBIZ-6932
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Yashwant Dhakad
>Assignee: Amit Gadaley
>Priority: Major
>
> Steps to reproduce:
> 1. Create sales order with MARKETING_PKG_PICK.
> 2. Completed the order with its shipment.
> 3. Invoice should be created.
> Actual: Invoice created with its components.
> Expected: Invoice should be created for its package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10118) Update multifex theme as per new markup

2018-11-23 Thread Nitish Mishra (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitish Mishra reassigned OFBIZ-10118:
-

Assignee: Nitish Mishra

> Update multifex theme as per new markup
> ---
>
> Key: OFBIZ-10118
> URL: https://issues.apache.org/jira/browse/OFBIZ-10118
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Reporter: Deepak Dixit
>Assignee: Nitish Mishra
>Priority: Major
>
> As we are updating UX of ecommerce site, this breaks the multifex them of 
> ecommerce.
> Need to update css rule of multiflex theme as per new markup. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10636) Convert updatePicklist service from simple to entity-auto

2018-11-23 Thread Anushi Gupta (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anushi Gupta reassigned OFBIZ-10636:


Assignee: Anushi Gupta

> Convert updatePicklist service from simple to entity-auto
> -
>
> Key: OFBIZ-10636
> URL: https://issues.apache.org/jira/browse/OFBIZ-10636
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pallavi Goyal
>Assignee: Anushi Gupta
>Priority: Major
>
> The simple service updates the picklist and creates a record for 
> 'PicklistStatusHistory'.
> It can be improved by converting the "updatePicklist' as entity-auto and 
> adding a seca for creating the picklist status history record.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10623) Error message is displayed on ecommerce when user tries to use Split shipment functionality

2018-11-23 Thread Praveen Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma reassigned OFBIZ-10623:
--

Assignee: Praveen Sharma  (was: Ankush Upadhyay)

> Error message is displayed on ecommerce when user tries to use Split shipment 
> functionality
> ---
>
> Key: OFBIZ-10623
> URL: https://issues.apache.org/jira/browse/OFBIZ-10623
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
> Environment: https://demo-trunk.ofbiz.apache.org/ecommerce
>Reporter: Arpit Mor
>Assignee: Praveen Sharma
>Priority: Major
> Attachments: 1-Checkout.png, 2-SplitShipment.png, 3-ErrorMessage.png
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  # Add multiple items to cart
>  # Click on Check Out on cart summary (Please refer attachment: 1-Checkout)
>  # Click on split shipment (Please refer attachment: 2-SplitShipment)
> Actual: Error message is displayed when user clicks on split shipment (Please 
> refer attachment: 3-ErrorMessage)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10623) Error message is displayed on ecommerce when user tries to use Split shipment functionality

2018-11-23 Thread Ankush Upadhyay (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay reassigned OFBIZ-10623:
---

Assignee: Ankush Upadhyay

> Error message is displayed on ecommerce when user tries to use Split shipment 
> functionality
> ---
>
> Key: OFBIZ-10623
> URL: https://issues.apache.org/jira/browse/OFBIZ-10623
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
> Environment: https://demo-trunk.ofbiz.apache.org/ecommerce
>Reporter: Arpit Mor
>Assignee: Ankush Upadhyay
>Priority: Major
> Attachments: 1-Checkout.png, 2-SplitShipment.png, 3-ErrorMessage.png
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  # Add multiple items to cart
>  # Click on Check Out on cart summary (Please refer attachment: 1-Checkout)
>  # Click on split shipment (Please refer attachment: 2-SplitShipment)
> Actual: Error message is displayed when user clicks on split shipment (Please 
> refer attachment: 3-ErrorMessage)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10624) Dropdown/facet at Reports under 'Sale Orders By Channel' is not working fine.

2018-11-23 Thread Ritesh Kumar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ritesh Kumar reassigned OFBIZ-10624:


Assignee: Ritesh Kumar

> Dropdown/facet at Reports under 'Sale Orders By Channel' is not working fine.
> -
>
> Key: OFBIZ-10624
> URL: https://issues.apache.org/jira/browse/OFBIZ-10624
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Dikpal Kanungo
>Assignee: Ritesh Kumar
>Priority: Trivial
> Attachments: Facet.png
>
>
> The facet should always display 'Select' or default option value (web 
> channel) in the list, right now it is blank. When a user clicks directly on 
> 'Run' without selecting any value from facet it generated the report 
> associated with the first element (web channel) in the list, though nothing 
> is selected from the list in the facet. !Facet.png!
> Please have a look at the attached screenshot for quick reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10378) Unable to redirect to "Documents" and "Competitors and Partners" page in SFA component

2018-11-23 Thread Yogesh Naroliya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yogesh Naroliya reassigned OFBIZ-10378:
---

Assignee: Yogesh Naroliya

> Unable to redirect to "Documents" and "Competitors and Partners" page in SFA 
> component
> --
>
> Key: OFBIZ-10378
> URL: https://issues.apache.org/jira/browse/OFBIZ-10378
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Rubia Elza Joshep
>Assignee: Yogesh Naroliya
>Priority: Major
>
> Steps to generate:
>  # Open URL 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/ManagePortalPages?parentPortalPageId=SFA_MAIN#|http://example.com/]
>  # In the SFA component, click on the "Documents" and "Competitors and 
> Partners" menu.
> Actual: On click, it is not redirected to its corresponding pages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-9873:

  Assignee: Jacques Le Roux  (was: Taher Alkhateeb)

I have found an hopefully real solution for this bug rather than using the 
current workaround which prevents to check results in Windows because the PDF 
were not generated there.

I found this solution at 
https://github.com/asciidoctor/asciidoctorj-pdf/issues/8. After reading 
https://github.com/asciidoctor/asciidoctor-pdf/issues/850 I checked it also 
works on Linux.

I have attached the  [^OFBIZ-9873-final.patch] which uses the last version of 
jruby-complete. 

Please try and confirm it's OK with you too. I guess the gradle-versions-plugin 
should be able to warn us when an upgrade of jruby-complete is available like 
it does for junitReport.

> Create a PoC for a documentation system for OFBiz based on Asciidoc
> ---
>
> Key: OFBIZ-9873
> URL: https://issues.apache.org/jira/browse/OFBIZ-9873
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9873-final.patch, OFBIZ-9873-rouge-coderay.patch, 
> OFBIZ-9873.patch, OFBIZ-9873.patch, OFBIZ-9873.patch
>
>
> In reference to the [discussion 
> thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E]
>  this is an attempt to create a PoC for OFBiz documentation system based on 
> Asciidoc. The main assumptions for the design of this system are:
> - The documentation language to use is Asciidoc
> - The documentation tool is Asciidoctor
> - Publishing happens through Gradle using the asciidoctor gradle plugin (not 
> the OFBiz framework or anything else).
> - The only place where we write documentation is inside the code base
> - Every component contains its own documentation
> - General documentation goes to either a standalone directory or a generic 
> component like common or base
> - As much as possible, documentation files are small and focused on one 
> topic. And then other longer documents are constructed from these snippets of 
> documentation.
> - We publish to all formats including PDF for users, or HTML for embedded 
> help and wiki pages. So OFBiz does not parse docbook for its help system, 
> instead it just renders generated HTML.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9873:
---
Attachment: OFBIZ-9873-final.patch

> Create a PoC for a documentation system for OFBiz based on Asciidoc
> ---
>
> Key: OFBIZ-9873
> URL: https://issues.apache.org/jira/browse/OFBIZ-9873
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9873-final.patch, OFBIZ-9873-rouge-coderay.patch, 
> OFBIZ-9873.patch, OFBIZ-9873.patch, OFBIZ-9873.patch
>
>
> In reference to the [discussion 
> thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E]
>  this is an attempt to create a PoC for OFBiz documentation system based on 
> Asciidoc. The main assumptions for the design of this system are:
> - The documentation language to use is Asciidoc
> - The documentation tool is Asciidoctor
> - Publishing happens through Gradle using the asciidoctor gradle plugin (not 
> the OFBiz framework or anything else).
> - The only place where we write documentation is inside the code base
> - Every component contains its own documentation
> - General documentation goes to either a standalone directory or a generic 
> component like common or base
> - As much as possible, documentation files are small and focused on one 
> topic. And then other longer documents are constructed from these snippets of 
> documentation.
> - We publish to all formats including PDF for users, or HTML for embedded 
> help and wiki pages. So OFBiz does not parse docbook for its help system, 
> instead it just renders generated HTML.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10658) Plugins Asciidoc documentation must be standalone

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10658.
---
   Resolution: Fixed
Fix Version/s: 17.12.01

fixed in
trunk r1847272  
R17 r1847274

Note that using ":toclevels: 3" does not work when generating with Gradle 
because of the OOTB definition "'toclevels': '5'" in build.gradle

It does when used apart in Asciidoc editors. I believe OOTB a 3 levels is enough
 and the numbers are superfluous if not unpleasant. I'll address this point in 
a new thread soon.

> Plugins Asciidoc documentation must be standalone
> -
>
> Key: OFBIZ-10658
> URL: https://issues.apache.org/jira/browse/OFBIZ-10658
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10658) Plugins Asciidoc documentation must be standalone

2018-11-23 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-10658:
---

 Summary: Plugins Asciidoc documentation must be standalone
 Key: OFBIZ-10658
 URL: https://issues.apache.org/jira/browse/OFBIZ-10658
 Project: OFBiz
  Issue Type: Bug
  Components: birt
Affects Versions: Trunk, 17.12.01
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10647) Convert Birt component doc from Markdown to AsciiDoc

2018-11-23 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697074#comment-16697074
 ] 

Jacques Le Roux commented on OFBIZ-10647:
-

Blog and wiki updated

> Convert Birt component doc from Markdown to AsciiDoc 
> -
>
> Key: OFBIZ-10647
> URL: https://issues.apache.org/jira/browse/OFBIZ-10647
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], 
> convert Birt component doc from Markdown to AsciiDoc.
> While doing so move images from 
> [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports]
>  to source and update the 
> [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a].
> And finally remove the "Birt Flexible Reports" wiki page (and entries in 
> updateWiki.bat) when we will automatically generate the documentation from 
> Buildbot.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10647) Convert Birt component doc from Markdown to AsciiDoc

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10647.
---
Resolution: Implemented

> Convert Birt component doc from Markdown to AsciiDoc 
> -
>
> Key: OFBIZ-10647
> URL: https://issues.apache.org/jira/browse/OFBIZ-10647
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], 
> convert Birt component doc from Markdown to AsciiDoc.
> While doing so move images from 
> [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports]
>  to source and update the 
> [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a].
> And finally remove the "Birt Flexible Reports" wiki page (and entries in 
> updateWiki.bat) when we will automatically generate the documentation from 
> Buildbot.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10647) Convert Birt component doc from Markdown to AsciiDoc

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10647.
---
   Resolution: Fixed
Fix Version/s: (was: Upcoming Branch)
   17.12.01

Done with revision: 1847253  


> Convert Birt component doc from Markdown to AsciiDoc 
> -
>
> Key: OFBIZ-10647
> URL: https://issues.apache.org/jira/browse/OFBIZ-10647
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], 
> convert Birt component doc from Markdown to AsciiDoc.
> While doing so move images from 
> [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports]
>  to source and update the 
> [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a].
> And finally remove the "Birt Flexible Reports" wiki page (and entries in 
> updateWiki.bat) when we will automatically generate the documentation from 
> Buildbot.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10657) Backport the Asciidoc documentation and means to generate it to R17 branch

2018-11-23 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697037#comment-16697037
 ] 

Jacques Le Roux edited comment on OFBIZ-10657 at 11/23/18 12:17 PM:


Done for source code at revision: 1847248+1847253  



was (Author: jacques.le.roux):
Done for source code at revision: 1847248  


> Backport the Asciidoc documentation and means to generate it to R17 branch
> --
>
> Key: OFBIZ-10657
> URL: https://issues.apache.org/jira/browse/OFBIZ-10657
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL APPLICATIONS, framework
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
> backport the Asciidoc documentation, and means to generate it, to R17 branch
> This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
> impacted: code in framework and plugins and Buildbot script. It's only a copy 
> from the trunk to the R17 branch, including *.adoc files, related images and 
> the build.gradle script.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10647) Convert Birt component doc from Markdown to AsciiDoc

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-10647:
-

> Convert Birt component doc from Markdown to AsciiDoc 
> -
>
> Key: OFBIZ-10647
> URL: https://issues.apache.org/jira/browse/OFBIZ-10647
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], 
> convert Birt component doc from Markdown to AsciiDoc.
> While doing so move images from 
> [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports]
>  to source and update the 
> [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a].
> And finally remove the "Birt Flexible Reports" wiki page (and entries in 
> updateWiki.bat) when we will automatically generate the documentation from 
> Buildbot.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10657) Backport the Asciidoc documentation and means to generate it to R17 branch

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10657:

Description: 
As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
backport the Asciidoc documentation, and means to generate it, to R17 branch

This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
impacted: code in framework and plugins and Buildbot script. It's only a copy 
from the trunk to the R17 branch, including *.adoc files, related images and 
the build.gradle script.

  was:
As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
backport the Asciidoc documentation, and means to generate it, to R17 branch

This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
impacted: code in framework and plusing and Buildbot script. It's only a copy 
from the trunk to the R17 branch, including *.adoc files, related images and 
the build.gradle script.


> Backport the Asciidoc documentation and means to generate it to R17 branch
> --
>
> Key: OFBIZ-10657
> URL: https://issues.apache.org/jira/browse/OFBIZ-10657
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL APPLICATIONS, framework
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
> backport the Asciidoc documentation, and means to generate it, to R17 branch
> This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
> impacted: code in framework and plugins and Buildbot script. It's only a copy 
> from the trunk to the R17 branch, including *.adoc files, related images and 
> the build.gradle script.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10651) Create a Gradle task to generate the documentation for all plugins

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10651.
---
   Resolution: Fixed
Fix Version/s: 17.12.01

The backport was done with r1847248

> Create a Gradle task to generate the documentation for all plugins
> --
>
> Key: OFBIZ-10651
> URL: https://issues.apache.org/jira/browse/OFBIZ-10651
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> With INFRA-17258 Infra has created the directories needed to access the 
> generated documentation from the site. A new generateAllPluginsDocumentation 
> Gradle task will be created to generate the plugins documentation under the 
> build/asciidoc/plugins directory. It will be used in the Buildbot script to 
> copy the plugins documentation in 
> ci.apache.org/projects/ofbiz/site/pluginsdoc/ with the OFBiz documentation 
> generated in build/asciidoc/ofbiz copied to 
> ci.apache.org/projects/ofbiz/site/ofbizdoc/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10651) Create a Gradle task to generate the documentation for all plugins

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10651.
---
Resolution: Done

> Create a Gradle task to generate the documentation for all plugins
> --
>
> Key: OFBIZ-10651
> URL: https://issues.apache.org/jira/browse/OFBIZ-10651
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> With INFRA-17258 Infra has created the directories needed to access the 
> generated documentation from the site. A new generateAllPluginsDocumentation 
> Gradle task will be created to generate the plugins documentation under the 
> build/asciidoc/plugins directory. It will be used in the Buildbot script to 
> copy the plugins documentation in 
> ci.apache.org/projects/ofbiz/site/pluginsdoc/ with the OFBiz documentation 
> generated in build/asciidoc/ofbiz copied to 
> ci.apache.org/projects/ofbiz/site/ofbizdoc/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10657) Backport the Asciidoc documentation and means to generate it to R17 branch

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10657.
---
Resolution: Done

> Backport the Asciidoc documentation and means to generate it to R17 branch
> --
>
> Key: OFBIZ-10657
> URL: https://issues.apache.org/jira/browse/OFBIZ-10657
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL APPLICATIONS, framework
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
> backport the Asciidoc documentation, and means to generate it, to R17 branch
> This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
> impacted: code in framework and plusing and Buildbot script. It's only a copy 
> from the trunk to the R17 branch, including *.adoc files, related images and 
> the build.gradle script.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10651) Create a Gradle task to generate the documentation for all plugins

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-10651:
-

> Create a Gradle task to generate the documentation for all plugins
> --
>
> Key: OFBIZ-10651
> URL: https://issues.apache.org/jira/browse/OFBIZ-10651
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> With INFRA-17258 Infra has created the directories needed to access the 
> generated documentation from the site. A new generateAllPluginsDocumentation 
> Gradle task will be created to generate the plugins documentation under the 
> build/asciidoc/plugins directory. It will be used in the Buildbot script to 
> copy the plugins documentation in 
> ci.apache.org/projects/ofbiz/site/pluginsdoc/ with the OFBiz documentation 
> generated in build/asciidoc/ofbiz copied to 
> ci.apache.org/projects/ofbiz/site/ofbizdoc/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10657) Backport the Asciidoc documentation and means to generate it to R17 branch

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10657.
---
Resolution: Fixed

Done for source code at revision: 1847248  


> Backport the Asciidoc documentation and means to generate it to R17 branch
> --
>
> Key: OFBIZ-10657
> URL: https://issues.apache.org/jira/browse/OFBIZ-10657
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL APPLICATIONS, framework
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
> backport the Asciidoc documentation, and means to generate it, to R17 branch
> This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
> impacted: code in framework and plusing and Buildbot script. It's only a copy 
> from the trunk to the R17 branch, including *.adoc files, related images and 
> the build.gradle script.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10657) Backport the Asciidoc documentation and means to generate it to R17 branch

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-10657:
-

> Backport the Asciidoc documentation and means to generate it to R17 branch
> --
>
> Key: OFBIZ-10657
> URL: https://issues.apache.org/jira/browse/OFBIZ-10657
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL APPLICATIONS, framework
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
> backport the Asciidoc documentation, and means to generate it, to R17 branch
> This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
> impacted: code in framework and plusing and Buildbot script. It's only a copy 
> from the trunk to the R17 branch, including *.adoc files, related images and 
> the build.gradle script.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10652) Modify the Buildbot script to generate and copy the documentation to the site

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10652.
---
   Resolution: Implemented
Fix Version/s: 17.12.01

As discussed in https://markmail.org/message/x7sv2mpvtytr4vl4 we decided to 
backport the Asciidoc documentation, and means to generate it, to R17 branch

At revision: 1037235  the generation of the Asciidoc documentation is now done 
with R17 branch. We no longer use the trunk for the Asciidoc documentation 

> Modify the Buildbot script to generate and copy the documentation to the site
> -
>
> Key: OFBIZ-10652
> URL: https://issues.apache.org/jira/browse/OFBIZ-10652
> Project: OFBiz
>  Issue Type: Task
>  Components: BuildBot
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> Now that we can generate the plugins documentation with OFBIZ-10651 and can 
> copy them to the site with INFRA-17258 we need to modify the Buildbot script 
> to generate and copy the documentation to the site



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10657) Backport the Asciidoc documentation and means to generate it to R17 branch

2018-11-23 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10657:

Description: 
As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
backport the Asciidoc documentation, and means to generate it, to R17 branch

This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
impacted: code in framework and plusing and Buildbot script. It's only a copy 
from the trunk to the R17 branch, including *.adoc files, related images and 
the build.gradle script.

  was:
As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
backport the Asciidoc documentation, and means to generate it, to R17 branch

This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
impacted: code in framework and plusing and Buildbot script. It's only a copy 
from the trunk to the R17 branch.


> Backport the Asciidoc documentation and means to generate it to R17 branch
> --
>
> Key: OFBIZ-10657
> URL: https://issues.apache.org/jira/browse/OFBIZ-10657
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL APPLICATIONS, framework
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
> backport the Asciidoc documentation, and means to generate it, to R17 branch
> This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
> impacted: code in framework and plusing and Buildbot script. It's only a copy 
> from the trunk to the R17 branch, including *.adoc files, related images and 
> the build.gradle script.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10657) Backport the Asciidoc documentation and means to generate it to R17 branch

2018-11-23 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-10657:
---

 Summary: Backport the Asciidoc documentation and means to generate 
it to R17 branch
 Key: OFBIZ-10657
 URL: https://issues.apache.org/jira/browse/OFBIZ-10657
 Project: OFBiz
  Issue Type: Task
  Components: ALL APPLICATIONS, framework
Affects Versions: 17.12.01
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
 Fix For: 17.12.01


As discussed in [https://markmail.org/message/x7sv2mpvtytr4vl4] we decided to 
backport the Asciidoc documentation, and means to generate it, to R17 branch

This is related with OFBIZ-10651 and OFBIZ-10652 tasks. So 2 parts are 
impacted: code in framework and plusing and Buildbot script. It's only a copy 
from the trunk to the R17 branch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10574) 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere

2018-11-23 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696620#comment-16696620
 ] 

Jacques Le Roux commented on OFBIZ-10574:
-

Hi Deepak,

Why adding  ASSETMAINT_VIEW in AccountingSecurityPermissionSeedData when it's 
already defined as seed in AssetMaintSecurityPermissionSeedData ?

> 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere
> -
>
> Key: OFBIZ-10574
> URL: https://issues.apache.org/jira/browse/OFBIZ-10574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBiz-10574.patch, OFBiz-10574.patch
>
>
> We have following references for the permissionId 'ORDERMGR_CRQ_ADMIN' in the 
> OrderDemoData.xml and OrderSecurityPermissionSeedData.xml.
>  permissionId="ORDERMGR_CRQ_ADMIN"/>
>  permissionId="ORDERMGR_CRQ_ADMIN"/>
> But the 'SecurityPermission' data for this particular permission is not 
> defined anywhere.
> As the relation type between the entities 'SecurityGroupPermission' and 
> 'SecurityPermissoin' is 'one-nofk', we are not getting data load error.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package

2018-11-23 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai reassigned OFBIZ-10655:
---

Assignee: Shi Jinghai

> OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
> -
>
> Key: OFBIZ-10655
> URL: https://issues.apache.org/jira/browse/OFBIZ-10655
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Major
>
> Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10586) Change the relation type with 'SecurityPermission' in SecurityGroupPermission entity to 'one' from 'one-nofk'

2018-11-23 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam closed OFBIZ-10586.

Resolution: Not A Problem

> Change the relation type with 'SecurityPermission' in SecurityGroupPermission 
> entity to 'one' from 'one-nofk'
> -
>
> Key: OFBIZ-10586
> URL: https://issues.apache.org/jira/browse/OFBIZ-10586
> Project: OFBiz
>  Issue Type: Improvement
>  Components: securityext
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBiz-10586.patch
>
>
> In the definition of 'SecurityGroupPermission' entity, the relation type with 
> 'SecurityPermission' entity is 'one-nofk'. Hence the system is allowing to 
> use the permissions not defined anywhere. (ex. 
> ORDERMGR_CRQ_ADMIN/ORDERMGR_CRQ_UPDATE, ASSETMAINT_VIEW).
>  
> Change the relation type to 'one' to maintain the referential integrity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10586) Change the relation type with 'SecurityPermission' in SecurityGroupPermission entity to 'one' from 'one-nofk'

2018-11-23 Thread Deepak Nigam (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696560#comment-16696560
 ] 

Deepak Nigam commented on OFBIZ-10586:
--

As discussed, there is nothing to do further in this ticket so closing it.

> Change the relation type with 'SecurityPermission' in SecurityGroupPermission 
> entity to 'one' from 'one-nofk'
> -
>
> Key: OFBIZ-10586
> URL: https://issues.apache.org/jira/browse/OFBIZ-10586
> Project: OFBiz
>  Issue Type: Improvement
>  Components: securityext
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBiz-10586.patch
>
>
> In the definition of 'SecurityGroupPermission' entity, the relation type with 
> 'SecurityPermission' entity is 'one-nofk'. Hence the system is allowing to 
> use the permissions not defined anywhere. (ex. 
> ORDERMGR_CRQ_ADMIN/ORDERMGR_CRQ_UPDATE, ASSETMAINT_VIEW).
>  
> Change the relation type to 'one' to maintain the referential integrity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10586) Change the relation type with 'SecurityPermission' in SecurityGroupPermission entity to 'one' from 'one-nofk'

2018-11-23 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696556#comment-16696556
 ] 

Jacques Le Roux commented on OFBIZ-10586:
-

I think this should be closed as "Won't Do" following the discussion, notably 
[~deepak.dixit]'s advice:
{quote}It looks good to have one FK relationship while reviewing entity def 
found following description. This is by design before proceeding we need to 
check this.

"Defines a permission available to a security group; there is no FK to 
SecurityPermission because we want to leave open the possibility of ad-hoc 
permissions, especially for the Entity Data Maintenance pages which have TONS 
of permissions"

Thanks & Regards
-- Deepak Dixit
{quote}

> Change the relation type with 'SecurityPermission' in SecurityGroupPermission 
> entity to 'one' from 'one-nofk'
> -
>
> Key: OFBIZ-10586
> URL: https://issues.apache.org/jira/browse/OFBIZ-10586
> Project: OFBiz
>  Issue Type: Improvement
>  Components: securityext
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBiz-10586.patch
>
>
> In the definition of 'SecurityGroupPermission' entity, the relation type with 
> 'SecurityPermission' entity is 'one-nofk'. Hence the system is allowing to 
> use the permissions not defined anywhere. (ex. 
> ORDERMGR_CRQ_ADMIN/ORDERMGR_CRQ_UPDATE, ASSETMAINT_VIEW).
>  
> Change the relation type to 'one' to maintain the referential integrity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10586) Change the relation type with 'SecurityPermission' in SecurityGroupPermission entity to 'one' from 'one-nofk'

2018-11-23 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10586:
-

Assignee: Suraj Khurana  (was: Deepak Nigam)

> Change the relation type with 'SecurityPermission' in SecurityGroupPermission 
> entity to 'one' from 'one-nofk'
> -
>
> Key: OFBIZ-10586
> URL: https://issues.apache.org/jira/browse/OFBIZ-10586
> Project: OFBiz
>  Issue Type: Improvement
>  Components: securityext
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBiz-10586.patch
>
>
> In the definition of 'SecurityGroupPermission' entity, the relation type with 
> 'SecurityPermission' entity is 'one-nofk'. Hence the system is allowing to 
> use the permissions not defined anywhere. (ex. 
> ORDERMGR_CRQ_ADMIN/ORDERMGR_CRQ_UPDATE, ASSETMAINT_VIEW).
>  
> Change the relation type to 'one' to maintain the referential integrity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10574) 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere

2018-11-23 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10574:
-

Assignee: Suraj Khurana  (was: Deepak Nigam)

> 'ORDERMGR_CRQ_ADMIN' permissionId is not defined anywhere
> -
>
> Key: OFBIZ-10574
> URL: https://issues.apache.org/jira/browse/OFBIZ-10574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBiz-10574.patch, OFBiz-10574.patch
>
>
> We have following references for the permissionId 'ORDERMGR_CRQ_ADMIN' in the 
> OrderDemoData.xml and OrderSecurityPermissionSeedData.xml.
>  permissionId="ORDERMGR_CRQ_ADMIN"/>
>  permissionId="ORDERMGR_CRQ_ADMIN"/>
> But the 'SecurityPermission' data for this particular permission is not 
> defined anywhere.
> As the relation type between the entities 'SecurityGroupPermission' and 
> 'SecurityPermissoin' is 'one-nofk', we are not getting data load error.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)