[jira] [Commented] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.
[
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844171#comment-16844171
]
Jacques Le Roux commented on OFBIZ-10895:
-
After lurking in demos logs, I finally decided to do a whole change, it's in
trunk r1859576
R18 r1859577
R17 r1859578
R16 r1859579
I don't if it's enough (and even right) so I will continue to monitor the demos
logs...
> Unknown request [images]; this request does not exist or cannot be called
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, themes
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]-
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [images]; this request does not exist or cannot be called directly.
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
>
[jira] [Closed] (OFBIZ-11028) field emplFromDate is forgot in PayHistory entity
[ https://issues.apache.org/jira/browse/OFBIZ-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11028. --- Resolution: Fixed Fix Version/s: (was: Trunk) 18.12.01 16.11.06 17.12.01 Thanks Olivier, Your patch is in trunk ar1859571 R18 r1859572 R17 r1859573 R17 r1859574 (conflict in HumanResServices.xml handled by hand) > field emplFromDate is forgot in PayHistory entity > - > > Key: OFBIZ-11028 > URL: https://issues.apache.org/jira/browse/OFBIZ-11028 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Trunk, 17.12.01, 18.12.01 >Reporter: Olivier Heintz >Assignee: Jacques Le Roux >Priority: Major > Labels: humanres > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: OFBIZ-11028.patch, OFBIZ-11028.patch > > > A Employment can have multiple PayHistory and should have multiple > because PayHistory should show history of Pay for a employment ! > Currently, in PayHistory the field fromDate from Employment is confused with > fromDate about the current record, it's necessary to have a field > emplFromDate (to have the complete employment primaryKey). > Currently user interface for PayHistory is not working, when modifying a > PayRecord the current should be expire and a new one should be created. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10969) Unable to create Employments
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10969. --- Resolution: Fixed Fix Version/s: 18.12.01 16.11.06 17.12.01 > Unable to create Employments > > > Key: OFBIZ-10969 > URL: https://issues.apache.org/jira/browse/OFBIZ-10969 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: Image1.png > > > Steps to regenerate: > # Login to the URL: > [https://demo-trunk.ofbiz.apache.org/humanres/control/main] > # Click on Employments > # Click on New Employments > # Click on Create > Actual: Error message is displayed. Please refer attachment: Image1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10969) Unable to create Employments
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844135#comment-16844135 ] Jacques Le Roux commented on OFBIZ-10969: - Thanks Olivier, >From what I understand it suffices to commit the patch at OFBIZ-11028 and then >both tickets can be closed. This implies, as you wrote above, that: bq. In the HR test scenario, I start by create an employee and after an employment, so all works ! In the recruitment test scenario I will create a Party (without role EMPLOYEE) and after selection process I will test createEmployment to check if it do the EMPLOYEE role creation. For now, I have added in the createEmployment service the call to ensurePartyRoleTo service, so now it works, even if before, partyTo is'nt associated to roleType EMPLOYEE. In other words, currently if an employment is created for a non employee this non employee will got an Employee role and so will be an employee. I tested this scenario, it works (a pay history is also created and editable) and it seems sound to me. In other words you don't need to create an employe from an existing person before creating an employment for this person. I commited the fix from OFBIZ-11028 in trunk at revision: 1859571 By default we always try to backport bugs fixes, so I did so here (actually in OFBIZ-11028) R18 r1859572 R17 r1859573 R17 r1859574 (conflict in HumanResServices.xml handled by hand) > Unable to create Employments > > > Key: OFBIZ-10969 > URL: https://issues.apache.org/jira/browse/OFBIZ-10969 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Attachments: Image1.png > > > Steps to regenerate: > # Login to the URL: > [https://demo-trunk.ofbiz.apache.org/humanres/control/main] > # Click on Employments > # Click on New Employments > # Click on Create > Actual: Error message is displayed. Please refer attachment: Image1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10303: --- Attachment: ofbiz-glossary.adoc > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: humanres.adoc.patch, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844008#comment-16844008 ] Olivier Heintz commented on OFBIZ-10303: Add some lines about DemoData > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: humanres.adoc.patch, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10303: --- Attachment: documentation_guidelines.adoc > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: humanres.adoc.patch, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10303: --- Attachment: (was: documentation_guidelines.adoc) > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: humanres.adoc.patch, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10271) Add Document Content: hr-global-settings.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844002#comment-16844002 ] Olivier Heintz commented on OFBIZ-10271: with salary Grade and Step Position Type and details : Rate, Grade-Step, Valid Resposibilities > Add Document Content: hr-global-settings.adoc > - > > Key: OFBIZ-10271 > URL: https://issues.apache.org/jira/browse/OFBIZ-10271 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Attachments: hr-global-settings.adoc, hr-global-settings.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-global-ettings.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-global-settings.adoc by updating the template then re-attach the > updated document to this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10271) Add Document Content: hr-global-settings.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10271: --- Attachment: hr-global-settings.adoc > Add Document Content: hr-global-settings.adoc > - > > Key: OFBIZ-10271 > URL: https://issues.apache.org/jira/browse/OFBIZ-10271 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Attachments: hr-global-settings.adoc, hr-global-settings.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-global-ettings.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-global-settings.adoc by updating the template then re-attach the > updated document to this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11046) add a HR Data model chapter
[ https://issues.apache.org/jira/browse/OFBIZ-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11046: --- Attachment: OFBIZ_11046_humanres.adoc.patch > add a HR Data model chapter > --- > > Key: OFBIZ-11046 > URL: https://issues.apache.org/jira/browse/OFBIZ-11046 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: humanres > Fix For: Trunk > > Attachments: EmplPosition.png, EmplPositionDetail.png, > Employment.png, EmploymentApp.png, OFBIZ_11046_humanres.adoc.patch, > PartyHumanRes.png, PerfReview.png, ability.png, hr-data-model.adoc > > > Add some UML diagram about main HR entities. > Each diagram contain not all associated entities but only one important to > have a first understanding about the main entity of the diagram. > In the doc, each diagram is associated with some link to others diagram to > easily naviguate. > This chapter could be included in hr-documentation just before hr-glossary -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11046) add a HR Data model chapter
[ https://issues.apache.org/jira/browse/OFBIZ-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843995#comment-16843995 ] Olivier Heintz commented on OFBIZ-11046: all the png files should be place in a subdirectory on doc/asciidoc/images root directory, named hr-data-model > add a HR Data model chapter > --- > > Key: OFBIZ-11046 > URL: https://issues.apache.org/jira/browse/OFBIZ-11046 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: humanres > Fix For: Trunk > > Attachments: EmplPosition.png, EmplPositionDetail.png, > Employment.png, EmploymentApp.png, PartyHumanRes.png, PerfReview.png, > ability.png, hr-data-model.adoc > > > Add some UML diagram about main HR entities. > Each diagram contain not all associated entities but only one important to > have a first understanding about the main entity of the diagram. > In the doc, each diagram is associated with some link to others diagram to > easily naviguate. > This chapter could be included in hr-documentation just before hr-glossary -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11046) add a HR Data model chapter
[ https://issues.apache.org/jira/browse/OFBIZ-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11046: --- Attachment: EmplPosition.png EmplPositionDetail.png Employment.png EmploymentApp.png PartyHumanRes.png PerfReview.png ability.png > add a HR Data model chapter > --- > > Key: OFBIZ-11046 > URL: https://issues.apache.org/jira/browse/OFBIZ-11046 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: humanres > Fix For: Trunk > > Attachments: EmplPosition.png, EmplPositionDetail.png, > Employment.png, EmploymentApp.png, PartyHumanRes.png, PerfReview.png, > ability.png, hr-data-model.adoc > > > Add some UML diagram about main HR entities. > Each diagram contain not all associated entities but only one important to > have a first understanding about the main entity of the diagram. > In the doc, each diagram is associated with some link to others diagram to > easily naviguate. > This chapter could be included in hr-documentation just before hr-glossary -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11046) add a HR Data model chapter
Olivier Heintz created OFBIZ-11046: -- Summary: add a HR Data model chapter Key: OFBIZ-11046 URL: https://issues.apache.org/jira/browse/OFBIZ-11046 Project: OFBiz Issue Type: Sub-task Components: humanres Affects Versions: Trunk Reporter: Olivier Heintz Fix For: Trunk Attachments: hr-data-model.adoc Add some UML diagram about main HR entities. Each diagram contain not all associated entities but only one important to have a first understanding about the main entity of the diagram. In the doc, each diagram is associated with some link to others diagram to easily naviguate. This chapter could be included in hr-documentation just before hr-glossary -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10256) Add Document Content: hr-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843985#comment-16843985 ] Olivier Heintz commented on OFBIZ-10256: In this hr-intro, the different process are ordered in a more logical order. HR-about is not more included see OFBIZ-11039 > Add Document Content: hr-intro.adoc > --- > > Key: OFBIZ-10256 > URL: https://issues.apache.org/jira/browse/OFBIZ-10256 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Olivier Heintz >Priority: Minor > Attachments: OFBizMainScreen.png, hr-intro.adoc, hr-intro.adoc, > hr-intro.patch > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-intro.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-intro.adoc by updating the template then re-attach the updated > document to this issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10256) Add Document Content: hr-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10256: --- Attachment: hr-intro.adoc > Add Document Content: hr-intro.adoc > --- > > Key: OFBIZ-10256 > URL: https://issues.apache.org/jira/browse/OFBIZ-10256 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Olivier Heintz >Priority: Minor > Attachments: OFBizMainScreen.png, hr-intro.adoc, hr-intro.adoc, > hr-intro.patch > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-intro.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-intro.adoc by updating the template then re-attach the updated > document to this issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10571) [FB] Package org.apache.ofbiz.minilang
[ https://issues.apache.org/jira/browse/OFBIZ-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843950#comment-16843950 ] Suraj Khurana commented on OFBIZ-10571: --- +1. Patch looks good to me. > [FB] Package org.apache.ofbiz.minilang > -- > > Key: OFBIZ-10571 > URL: https://issues.apache.org/jira/browse/OFBIZ-10571 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Girish Vasmatkar >Assignee: Girish Vasmatkar >Priority: Minor > Attachments: OFBIZ-10571.patch > > > * [Should be a static inner > class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC] > This class is an inner class, but does not use its embedded reference to the > object which created it. This reference makes the instances of the class > larger, and may keep the reference to the creator object alive longer than > necessary. If possible, the class should be made static. > *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC* > *org.apache.ofbiz.minilang.method.callops.CallService*** > > * [Could be refactored into a named static inner > class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON] > This class is an inner class, but does not use its embedded reference to the > object which created it. This reference makes the instances of the class > larger, and may keep the reference to the creator object alive longer than > necessary. If possible, the class should be made into a _static_ inner > class. Since anonymous inner classes cannot be marked as static, doing this > will require refactoring the inner class so that it is a named inner class. > *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON* > *org.apache.ofbiz.minilang.method.conditional.CombinedConditional* > > * [Boxing/unboxing to parse a > primitive|http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING] > A boxed primitive is created from a String, just to extract the unboxed > primitive value. It is more efficient to just call the static parseXXX method. > ** > *Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING* > *org.apache.ofbiz.minilang.method.otherops.Calculate* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10571) [FB] Package org.apache.ofbiz.minilang
[ https://issues.apache.org/jira/browse/OFBIZ-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-10571: - Assignee: Suraj Khurana (was: Girish Vasmatkar) > [FB] Package org.apache.ofbiz.minilang > -- > > Key: OFBIZ-10571 > URL: https://issues.apache.org/jira/browse/OFBIZ-10571 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Girish Vasmatkar >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-10571.patch > > > * [Should be a static inner > class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC] > This class is an inner class, but does not use its embedded reference to the > object which created it. This reference makes the instances of the class > larger, and may keep the reference to the creator object alive longer than > necessary. If possible, the class should be made static. > *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC* > *org.apache.ofbiz.minilang.method.callops.CallService*** > > * [Could be refactored into a named static inner > class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON] > This class is an inner class, but does not use its embedded reference to the > object which created it. This reference makes the instances of the class > larger, and may keep the reference to the creator object alive longer than > necessary. If possible, the class should be made into a _static_ inner > class. Since anonymous inner classes cannot be marked as static, doing this > will require refactoring the inner class so that it is a named inner class. > *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON* > *org.apache.ofbiz.minilang.method.conditional.CombinedConditional* > > * [Boxing/unboxing to parse a > primitive|http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING] > A boxed primitive is created from a String, just to extract the unboxed > primitive value. It is more efficient to just call the static parseXXX method. > ** > *Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING* > *org.apache.ofbiz.minilang.method.otherops.Calculate* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"
[
https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843938#comment-16843938
]
Jacques Le Roux edited comment on OFBIZ-5254 at 5/20/19 1:00 PM:
-
The issue is due to {{messageId=<565117307.0.1558356270863@LDLC>}} in
commEventMap passed to updateCommunicationEvent service:
{userLogin=[GenericEntity:UserLogin][createdStamp,2019-05-15
09:07:58.304(java.sql.Timestamp)][createdTxStamp,2019-05-15
09:07:57.934(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2019-05-15
09:08:02.259(java.sql.Timestamp)][lastUpdatedTxStamp,2019-05-15
09:08:02.077(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
statusId=COM_COMPLETE, entryDate=2019-05-20 14:44:30.0,
subject=PD#DEMO-PRODUCT-1 - Demo Product 1, datetimeEnded=2019-05-20
14:44:30.873, communicationEventId=DEMO-COM-PRODUCT-1,
messageId=<565117307.0.1558356270863@LDLC>,
toString=ofbizscrumproductow...@example.com, fromString=ofbizt...@example.com,
content= }
LDLC is the name of my machine. The problem is the "<" ">" symboles around the
messageId. I'll check why they are needed if they are...
was (Author: jacques.le.roux):
The issue is due to {{messageId=<565117307.0.1558356270863@LDLC>}} in
commEventMap passed to updateCommunicationEvent service:
{noformat}
{userLogin=[GenericEntity:UserLogin][createdStamp,2019-05-15
09:07:58.304(java.sql.Timestamp)][createdTxStamp,2019-05-15
09:07:57.934(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2019-05-15
09:08:02.259(java.sql.Timestamp)][lastUpdatedTxStamp,2019-05-15
09:08:02.077(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
statusId=COM_COMPLETE, entryDate=2019-05-20 14:44:30.0,
subject=PD#DEMO-PRODUCT-1 - Demo Product 1, datetimeEnded=2019-05-20
14:44:30.873, communicationEventId=DEMO-COM-PRODUCT-1,
messageId=<565117307.0.1558356270863@LDLC>,
toString=ofbizscrumproductow...@example.com, fromString=ofbizt...@example.com,
content= }
{noformat}
LDLC is the name of my machine. The problem is the "<" ">" symboles around the
messageId. I'll check why they are needed if they are...
> Services allow arbitrary HTML for parameters with allow-html set to "safe"
> --
>
> Key: OFBIZ-5254
> URL: https://issues.apache.org/jira/browse/OFBIZ-5254
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Christoph Neuroth
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: security
> Attachments: OFBIZ-5254.patch, OFBIZ-5254.patch, OFBIZ-5254.patch,
> OFBIZ-5254.patch, UtilCodec.java
>
>
> For any given service with allow-html=safe parameters, the parameter data is
> not properly validated. See Model.Service.java:588:
> {code}
>
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> {code}
> Looking at that method:
> {code}
> public static String checkStringForHtmlSafeOnly(String valueName, String
> value, List errorMessageList) {
> ValidationErrorList vel = new ValidationErrorList();
> value = defaultWebValidator.getValidSafeHTML(valueName, value,
> Integer.MAX_VALUE, true, vel);
> errorMessageList.addAll(UtilGenerics.checkList(vel.errors(),
> String.class));
> return value;
> }
> {code}
> you can see that it expects the defaultWebValidator.getValidSafeHTML would
> add all validation errors to the given ValidationErrorList, but if you look
> at the implementation of ESAPI that is not the case. First, consider the
> overloaded getValidSafeHTML that takes the ValidationErrorList:
> {code}public String getValidSafeHTML(String context, String input,
> int maxLength, boolean allowNull, ValidationErrorList errors) throws
> IntrusionException {
> try {
> return getValidSafeHTML(context, input, maxLength,
> allowNull);
> } catch (ValidationException e) {
> errors.addError(context, e);
> }
> return
[jira] [Commented] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"
[
https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843938#comment-16843938
]
Jacques Le Roux commented on OFBIZ-5254:
The issue is due to {{messageId=<565117307.0.1558356270863@LDLC>}} in
commEventMap passed to updateCommunicationEvent service:
{noformat}
{userLogin=[GenericEntity:UserLogin][createdStamp,2019-05-15
09:07:58.304(java.sql.Timestamp)][createdTxStamp,2019-05-15
09:07:57.934(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2019-05-15
09:08:02.259(java.sql.Timestamp)][lastUpdatedTxStamp,2019-05-15
09:08:02.077(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
statusId=COM_COMPLETE, entryDate=2019-05-20 14:44:30.0,
subject=PD#DEMO-PRODUCT-1 - Demo Product 1, datetimeEnded=2019-05-20
14:44:30.873, communicationEventId=DEMO-COM-PRODUCT-1,
messageId=<565117307.0.1558356270863@LDLC>,
toString=ofbizscrumproductow...@example.com, fromString=ofbizt...@example.com,
content= }
{noformat}
LDLC is the name of my machine. The problem is the "<" ">" symboles around the
messageId. I'll check why they are needed if they are...
> Services allow arbitrary HTML for parameters with allow-html set to "safe"
> --
>
> Key: OFBIZ-5254
> URL: https://issues.apache.org/jira/browse/OFBIZ-5254
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Christoph Neuroth
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: security
> Attachments: OFBIZ-5254.patch, OFBIZ-5254.patch, OFBIZ-5254.patch,
> OFBIZ-5254.patch, UtilCodec.java
>
>
> For any given service with allow-html=safe parameters, the parameter data is
> not properly validated. See Model.Service.java:588:
> {code}
>
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> {code}
> Looking at that method:
> {code}
> public static String checkStringForHtmlSafeOnly(String valueName, String
> value, List errorMessageList) {
> ValidationErrorList vel = new ValidationErrorList();
> value = defaultWebValidator.getValidSafeHTML(valueName, value,
> Integer.MAX_VALUE, true, vel);
> errorMessageList.addAll(UtilGenerics.checkList(vel.errors(),
> String.class));
> return value;
> }
> {code}
> you can see that it expects the defaultWebValidator.getValidSafeHTML would
> add all validation errors to the given ValidationErrorList, but if you look
> at the implementation of ESAPI that is not the case. First, consider the
> overloaded getValidSafeHTML that takes the ValidationErrorList:
> {code}public String getValidSafeHTML(String context, String input,
> int maxLength, boolean allowNull, ValidationErrorList errors) throws
> IntrusionException {
> try {
> return getValidSafeHTML(context, input, maxLength,
> allowNull);
> } catch (ValidationException e) {
> errors.addError(context, e);
> }
> return input;
> }
> {code}
> Then, step into that method to see that ValidationExceptions are only thrown
> for things like exceeding the maximum length - not for policy violations that
> can be "cleaned", such as tags that are not allowed by the policy:
> {code}
> AntiSamy as = new AntiSamy();
> CleanResults test = as.scan(input, antiSamyPolicy);
> List errors = test.getErrorMessages();
> if ( errors.size() > 0 ) {
> // just create new exception to get it logged
> and intrusion detected
> new ValidationException( "Invalid HTML input:
> context=" + context, "Invalid HTML input: context=" + context + ", errors=" +
> errors, context );
> }
> {code}
> I guess that is an expected, although maybe not clearly documented behavior
> of ESAPI: Non-cleanable violations throw the exception and therefore will
> fail the ofbiz service, while non-allowed tags are cleaned. However, if you
> consider ModelService:588 and following lines again:
> {code}
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> //(...)
> if (errorMessageList.size() > 0) {
> throw new
[jira] [Updated] (OFBIZ-11045) Activate / Finish EmplPositionType ValidResponsibilities
[ https://issues.apache.org/jira/browse/OFBIZ-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11045: --- Attachment: OFBIZ_11045.patch > Activate / Finish EmplPositionType ValidResponsibilities > > > Key: OFBIZ-11045 > URL: https://issues.apache.org/jira/browse/OFBIZ-11045 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: humanres > Fix For: Trunk > > Attachments: OFBIZ_11045.patch > > > Most of code / form / screen exist to manage EmpPositionType, but > * one menu item is missing > * screen menu field are forgot > * entity name is wrong in the entityCondition in Form > Included Patch contain corrections for that points -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11045) Activate / Finish EmplPositionType ValidResponsibilities
Olivier Heintz created OFBIZ-11045: -- Summary: Activate / Finish EmplPositionType ValidResponsibilities Key: OFBIZ-11045 URL: https://issues.apache.org/jira/browse/OFBIZ-11045 Project: OFBiz Issue Type: Improvement Components: humanres Affects Versions: Trunk Reporter: Olivier Heintz Fix For: Trunk Attachments: OFBIZ_11045.patch Most of code / form / screen exist to manage EmpPositionType, but * one menu item is missing * screen menu field are forgot * entity name is wrong in the entityCondition in Form Included Patch contain corrections for that points -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11042) Allow to choose salaryStepSeqId when create a SalaryStep
[
https://issues.apache.org/jira/browse/OFBIZ-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Heintz updated OFBIZ-11042:
---
Attachment: OFBIZ-11044.patch
> Allow to choose salaryStepSeqId when create a SalaryStep
>
>
> Key: OFBIZ-11042
> URL: https://issues.apache.org/jira/browse/OFBIZ-11042
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
> Labels: humanres
> Fix For: Trunk
>
> Attachments: OFBIZ-11042.patch
>
>
> Comming from "The Data model Resource Book"
> {{«}} Salary Grade-Step are used in entreprise that have a predefined, highly
> structure pay system (such as the federal government). This is done by
> reference to a structure pay schedule.{{»}}
> Currently in OFBiz in HR in Global HR Settings, it's possible to choose
> gradeId but not stepSeqId and so it's not readable when you want select a
> Grade-Step for a EmployeePositionType or a Employment / PayHistory because
> it's not same as legal "Structure Pay Schedule" (like "Convention collective,
> salaire minimum par position" in France).
> In patch propose, add a field in form and in create service use it if not
> empty
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11042) Allow to choose salaryStepSeqId when create a SalaryStep
[
https://issues.apache.org/jira/browse/OFBIZ-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Heintz updated OFBIZ-11042:
---
Attachment: (was: OFBIZ-11044.patch)
> Allow to choose salaryStepSeqId when create a SalaryStep
>
>
> Key: OFBIZ-11042
> URL: https://issues.apache.org/jira/browse/OFBIZ-11042
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
> Labels: humanres
> Fix For: Trunk
>
> Attachments: OFBIZ-11042.patch
>
>
> Comming from "The Data model Resource Book"
> {{«}} Salary Grade-Step are used in entreprise that have a predefined, highly
> structure pay system (such as the federal government). This is done by
> reference to a structure pay schedule.{{»}}
> Currently in OFBiz in HR in Global HR Settings, it's possible to choose
> gradeId but not stepSeqId and so it's not readable when you want select a
> Grade-Step for a EmployeePositionType or a Employment / PayHistory because
> it's not same as legal "Structure Pay Schedule" (like "Convention collective,
> salaire minimum par position" in France).
> In patch propose, add a field in form and in create service use it if not
> empty
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11044) EmplPositionType Rate and Grade better User interface
[ https://issues.apache.org/jira/browse/OFBIZ-11044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11044: --- Attachment: OFBIZ-11044.patch > EmplPositionType Rate and Grade better User interface > - > > Key: OFBIZ-11044 > URL: https://issues.apache.org/jira/browse/OFBIZ-11044 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: humanres > Fix For: Trunk > > Attachments: OFBIZ-11044.patch > > > EmplPositionType can be associated with a Rate or a Grade-Step, look to > [Position Type - User > Manual|[https://ofbizextra.org/ofbizextra_adocs/docs/asciidoc/user-manual.html#_position_types].] > Currently Rate and Grade-Step are on the same Form, I propose to split in two > form, one for Rate and one for Grade-Step. > Sub enhancement, Grade and Step lookup don't work, corrections for this are > included -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11044) EmplPositionType Rate and Grade better User interface
Olivier Heintz created OFBIZ-11044: -- Summary: EmplPositionType Rate and Grade better User interface Key: OFBIZ-11044 URL: https://issues.apache.org/jira/browse/OFBIZ-11044 Project: OFBiz Issue Type: Improvement Components: humanres Affects Versions: Trunk Reporter: Olivier Heintz Fix For: Trunk EmplPositionType can be associated with a Rate or a Grade-Step, look to [Position Type - User Manual|[https://ofbizextra.org/ofbizextra_adocs/docs/asciidoc/user-manual.html#_position_types].] Currently Rate and Grade-Step are on the same Form, I propose to split in two form, one for Rate and one for Grade-Step. Sub enhancement, Grade and Step lookup don't work, corrections for this are included -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843847#comment-16843847 ] Suraj Khurana commented on OFBIZ-7610: -- Hello [~ankush.upadhyay], Your patch looks good to me. IMO, better place to add this check could be inside the service 'getSuppliersForProduct' as other filter condition are already available inside the service. Please share your thoughts on the same. > Product Price set based on 'Purchase Price Agreement' isn't honored while > same is used during ordering > -- > > Key: OFBIZ-7610 > URL: https://issues.apache.org/jira/browse/OFBIZ-7610 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Swapnil Shah >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7610.patch, SA_1.png, SA_2.png, SA_3.png, > SA_4.png, SA_5.png > > > Once any Purchase Agreement is created with supplier for certain products at > pre-determined price, its get successfully transformed into SupplierProduct. > But at the time of Purchase order creation is same agreement is enforced then > agreement prices for products are ignored while setting the price on cart and > eventually on order itself. > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[ https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843836#comment-16843836 ] Pawan Verma commented on OFBIZ-11018: - Thanks [~jacques.le.roux]! > Redirection of pathAlias to aliasTo does not work properly > -- > > Key: OFBIZ-11018 > URL: https://issues.apache.org/jira/browse/OFBIZ-11018 > Project: OFBiz > Issue Type: Bug > Components: cmssite, content >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: Image 001.png, OFBIZ-11018.patch, OFBIZ-11018.patch > > > Link of discussion: [https://markmail.org/message/s37whdteejqdzkha] > In CMS, we can redirect the user to different path alias using 'aliasTo' > field of *WebSitePathAlias* entity. > Example - > fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" /> > Based on the above data, if the user hit the > [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render > the content for 'newDemoHome' pathAlias. > As per my observation, the content for "newDemoHome" is renderd properly (as > expected) but the URL of the page (in browser) doesn't change. > We should also update the URL also, i.e. change browser URL from > [https://localhost:8443/cmssite/cms/demoHome] to > [https://localhost:8443/cmssite/cms/newDemoHome] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[ https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11018. --- Resolution: Fixed Fix Version/s: 18.12.01 16.11.06 17.12.01 Pawan, Your patch is in trunk r1859543 R18 r1859544 R17 r1859545 R16 rr1859546 > Redirection of pathAlias to aliasTo does not work properly > -- > > Key: OFBIZ-11018 > URL: https://issues.apache.org/jira/browse/OFBIZ-11018 > Project: OFBiz > Issue Type: Bug > Components: cmssite, content >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: Image 001.png, OFBIZ-11018.patch, OFBIZ-11018.patch > > > Link of discussion: [https://markmail.org/message/s37whdteejqdzkha] > In CMS, we can redirect the user to different path alias using 'aliasTo' > field of *WebSitePathAlias* entity. > Example - > fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" /> > Based on the above data, if the user hit the > [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render > the content for 'newDemoHome' pathAlias. > As per my observation, the content for "newDemoHome" is renderd properly (as > expected) but the URL of the page (in browser) doesn't change. > We should also update the URL also, i.e. change browser URL from > [https://localhost:8443/cmssite/cms/demoHome] to > [https://localhost:8443/cmssite/cms/newDemoHome] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7696) Add UI labels for success / eror messages in XML files
[ https://issues.apache.org/jira/browse/OFBIZ-7696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-7696: Assignee: Suraj Khurana (was: Sourabh Punyani) > Add UI labels for success / eror messages in XML files > -- > > Key: OFBIZ-7696 > URL: https://issues.apache.org/jira/browse/OFBIZ-7696 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7696_Humanres.patch, OFBIZ-7696_Marketing.patch, > OFBIZ-7696_Order.patch, OFBIZ-7696_Scrum.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[ https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11018: --- Assignee: Jacques Le Roux (was: Pawan Verma) > Redirection of pathAlias to aliasTo does not work properly > -- > > Key: OFBIZ-11018 > URL: https://issues.apache.org/jira/browse/OFBIZ-11018 > Project: OFBiz > Issue Type: Bug > Components: cmssite, content >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Jacques Le Roux >Priority: Major > Attachments: Image 001.png, OFBIZ-11018.patch, OFBIZ-11018.patch > > > Link of discussion: [https://markmail.org/message/s37whdteejqdzkha] > In CMS, we can redirect the user to different path alias using 'aliasTo' > field of *WebSitePathAlias* entity. > Example - > fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" /> > Based on the above data, if the user hit the > [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render > the content for 'newDemoHome' pathAlias. > As per my observation, the content for "newDemoHome" is renderd properly (as > expected) but the URL of the page (in browser) doesn't change. > We should also update the URL also, i.e. change browser URL from > [https://localhost:8443/cmssite/cms/demoHome] to > [https://localhost:8443/cmssite/cms/newDemoHome] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[ https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843827#comment-16843827 ] Jacques Le Roux commented on OFBIZ-11018: - Thanks Pawan, It works indeed, I can see the transition now, also in the data. I must say the content data have always been a pain for me, a real example is always a saver :) > Redirection of pathAlias to aliasTo does not work properly > -- > > Key: OFBIZ-11018 > URL: https://issues.apache.org/jira/browse/OFBIZ-11018 > Project: OFBiz > Issue Type: Bug > Components: cmssite, content >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: Image 001.png, OFBIZ-11018.patch, OFBIZ-11018.patch > > > Link of discussion: [https://markmail.org/message/s37whdteejqdzkha] > In CMS, we can redirect the user to different path alias using 'aliasTo' > field of *WebSitePathAlias* entity. > Example - > fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" /> > Based on the above data, if the user hit the > [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render > the content for 'newDemoHome' pathAlias. > As per my observation, the content for "newDemoHome" is renderd properly (as > expected) but the URL of the page (in browser) doesn't change. > We should also update the URL also, i.e. change browser URL from > [https://localhost:8443/cmssite/cms/demoHome] to > [https://localhost:8443/cmssite/cms/newDemoHome] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-7610: Assignee: Suraj Khurana (was: Ankush Upadhyay) > Product Price set based on 'Purchase Price Agreement' isn't honored while > same is used during ordering > -- > > Key: OFBIZ-7610 > URL: https://issues.apache.org/jira/browse/OFBIZ-7610 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Swapnil Shah >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7610.patch, SA_1.png, SA_2.png, SA_3.png, > SA_4.png, SA_5.png > > > Once any Purchase Agreement is created with supplier for certain products at > pre-determined price, its get successfully transformed into SupplierProduct. > But at the time of Purchase order creation is same agreement is enforced then > agreement prices for products are ignored while setting the price on cart and > eventually on order itself. > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-7610: - Affects Version/s: Release Branch 18.12 Release Branch 17.12 Release Branch 16.11 > Product Price set based on 'Purchase Price Agreement' isn't honored while > same is used during ordering > -- > > Key: OFBIZ-7610 > URL: https://issues.apache.org/jira/browse/OFBIZ-7610 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Swapnil Shah >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7610.patch, SA_1.png, SA_2.png, SA_3.png, > SA_4.png, SA_5.png > > > Once any Purchase Agreement is created with supplier for certain products at > pre-determined price, its get successfully transformed into SupplierProduct. > But at the time of Purchase order creation is same agreement is enforced then > agreement prices for products are ignored while setting the price on cart and > eventually on order itself. > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10880) Product image not scaling properly on ecommerce at different screen resolution
[ https://issues.apache.org/jira/browse/OFBIZ-10880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-10880: - Assignee: Suraj Khurana (was: Praveen Sharma) > Product image not scaling properly on ecommerce at different screen resolution > -- > > Key: OFBIZ-10880 > URL: https://issues.apache.org/jira/browse/OFBIZ-10880 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Suraj Khurana >Priority: Minor > Attachments: Image1.png, Image2.png, OFBIZ-10880.patch > > > Steps to regenerate: > # Navigate to [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Change resolution of the screen or zoom in/out of the page > Actual: Image for some products are not scaled properly and it goes out of > the boundary. Please refer attachment: Image1 > Please note that this issue occurs only at some resolution and for other > resolutions the image is scaled properly. Please refer attachment: Image2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10975) Improve the buttons on edit credit card page
[ https://issues.apache.org/jira/browse/OFBIZ-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843826#comment-16843826 ] Suraj Khurana commented on OFBIZ-10975: --- Hello [~sourabh.punyani], Please check and update Affect version. Also, please mark tickets to Patch Available so that reviewers/committers can review the patch. Thanks for your work !! > Improve the buttons on edit credit card page > > > Key: OFBIZ-10975 > URL: https://issues.apache.org/jira/browse/OFBIZ-10975 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Sourabh Punyani >Priority: Major > Attachments: Buttonissue.png, OFBIZ-10975.patch > > > Steps: > 1. Visit the demo-trunk.ofbiz.apache.org/ecommerce. > 2. Login to the system. > 3. Add Credit card details for the customer on the customer profile page. > 4. Check the Go Back and Save button after adding the credit card details. > Actual: > Go Back and Save button display twice on the header of the page, after adding > the credit card for the customer. > Expected: > The buttons should not be displayed twice after adding the credit card > details. > Please refer screenshot; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[
https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843794#comment-16843794
]
Pawan Verma edited comment on OFBIZ-11018 at 5/20/19 9:09 AM:
--
Hello [~jacques.le.roux],
Original pathAlias should not have any content associated with it(existing
condition) and associate content with the aliasTo. And aliasTo should be
associated with content which should be rendered on the screen.
I have attached some example data for the same.
{code:java}
{code}
Hitting URL [https://localhost:8443/cmssite/cms/demoHome2] should redirect to
[https://localhost:8443/cmssite/cms/demoPage2]
Please let me know in case of any concern. Thanks!
was (Author: pawan.verma):
Hello [~jacques.le.roux],
Original pathAlias should not have any content associated with it(existing
condition) and associate content with the aliasTo. And aliasTo should be
associated with content which should be rendered on the screen.
I have attached some example data for the same.
{code:java}
{code}
{code:java}
{code}
Please let me know in case of any concern. Thanks!
> Redirection of pathAlias to aliasTo does not work properly
> --
>
> Key: OFBIZ-11018
> URL: https://issues.apache.org/jira/browse/OFBIZ-11018
> Project: OFBiz
> Issue Type: Bug
> Components: cmssite, content
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Attachments: Image 001.png, OFBIZ-11018.patch, OFBIZ-11018.patch
>
>
> Link of discussion: [https://markmail.org/message/s37whdteejqdzkha]
> In CMS, we can redirect the user to different path alias using 'aliasTo'
> field of *WebSitePathAlias* entity.
> Example -
> fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" />
> Based on the above data, if the user hit the
> [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render
> the content for 'newDemoHome' pathAlias.
> As per my observation, the content for "newDemoHome" is renderd properly (as
> expected) but the URL of the page (in browser) doesn't change.
> We should also update the URL also, i.e. change browser URL from
> [https://localhost:8443/cmssite/cms/demoHome] to
> [https://localhost:8443/cmssite/cms/newDemoHome]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[
https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843794#comment-16843794
]
Pawan Verma commented on OFBIZ-11018:
-
Hello [~jacques.le.roux],
Original pathAlias should not have any content associated with it(existing
condition) and associate content with the aliasTo. And aliasTo should be
associated with content which should be rendered on the screen.
I have attached some example data for the same.
{code:java}
{code}
{code:java}
{code}
Please let me know in case of any concern. Thanks!
> Redirection of pathAlias to aliasTo does not work properly
> --
>
> Key: OFBIZ-11018
> URL: https://issues.apache.org/jira/browse/OFBIZ-11018
> Project: OFBiz
> Issue Type: Bug
> Components: cmssite, content
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Attachments: Image 001.png, OFBIZ-11018.patch, OFBIZ-11018.patch
>
>
> Link of discussion: [https://markmail.org/message/s37whdteejqdzkha]
> In CMS, we can redirect the user to different path alias using 'aliasTo'
> field of *WebSitePathAlias* entity.
> Example -
> fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" />
> Based on the above data, if the user hit the
> [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render
> the content for 'newDemoHome' pathAlias.
> As per my observation, the content for "newDemoHome" is renderd properly (as
> expected) but the URL of the page (in browser) doesn't change.
> We should also update the URL also, i.e. change browser URL from
> [https://localhost:8443/cmssite/cms/demoHome] to
> [https://localhost:8443/cmssite/cms/newDemoHome]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10899) Have an Auditor party with associated AUDITOR SecurityGroup permissions in all DEMO instances
[ https://issues.apache.org/jira/browse/OFBIZ-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843768#comment-16843768 ] Pierre Smits commented on OFBIZ-10899: -- Thanks, Jacques, for your assistance to get this into the repo. > Have an Auditor party with associated AUDITOR SecurityGroup permissions in > all DEMO instances > - > > Key: OFBIZ-10899 > URL: https://issues.apache.org/jira/browse/OFBIZ-10899 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10899-AuditorData.patch > > > While doing an implementation for a rental company (with involvement of an > external accountant/auditor), I came across the aspect that there is no > default security group regarding auditors. These parties, in general, have > only view permissions on the UI elements (screens/menu-items/forms and > templates). > In order to help the (potential) adopters to choose OFBiz, it would be smart > to have such a party, with the proposed SecurityGroup (and the appropriate > permissions) in play in any of our demo instances. > Not only for the aspect mentioned above, but also for seeing whether other > improvements can occur (e.g. create buttons visible to 'VIEW' only permission > holders). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10899) Have an Auditor party with associated AUDITOR SecurityGroup permissions in all DEMO instances
[ https://issues.apache.org/jira/browse/OFBIZ-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-10899: Assignee: Pierre Smits (was: Jacques Le Roux) > Have an Auditor party with associated AUDITOR SecurityGroup permissions in > all DEMO instances > - > > Key: OFBIZ-10899 > URL: https://issues.apache.org/jira/browse/OFBIZ-10899 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10899-AuditorData.patch > > > While doing an implementation for a rental company (with involvement of an > external accountant/auditor), I came across the aspect that there is no > default security group regarding auditors. These parties, in general, have > only view permissions on the UI elements (screens/menu-items/forms and > templates). > In order to help the (potential) adopters to choose OFBiz, it would be smart > to have such a party, with the proposed SecurityGroup (and the appropriate > permissions) in play in any of our demo instances. > Not only for the aspect mentioned above, but also for seeing whether other > improvements can occur (e.g. create buttons visible to 'VIEW' only permission > holders). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"
[
https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843766#comment-16843766
]
Jacques Le Roux commented on OFBIZ-5254:
I need to check that:
{noformat}
2019-05-20 10:09:35,544 |OFBiz-JobQueue-0 |ServiceDispatcher
|E| Incoming context (in runSync : updateCommunicationEvent) does not match
expected requirements
org.apache.ofbiz.service.ServiceValidationException: In field [messageId] by
our input policy, your input has not been accepted for security reason. Please
check and modify accordingly, thanks.
at
org.apache.ofbiz.service.ModelService.validate(ModelService.java:625)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:395)
[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[ofbiz.jar:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
[ofbiz.jar:?]
at
org.apache.ofbiz.party.communication.CommunicationEventServices.updateCommEventAfterEmail(CommunicationEventServices.java:846)
[ofbiz.jar:?]
{noformat}
> Services allow arbitrary HTML for parameters with allow-html set to "safe"
> --
>
> Key: OFBIZ-5254
> URL: https://issues.apache.org/jira/browse/OFBIZ-5254
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Christoph Neuroth
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: security
> Attachments: OFBIZ-5254.patch, OFBIZ-5254.patch, OFBIZ-5254.patch,
> OFBIZ-5254.patch, UtilCodec.java
>
>
> For any given service with allow-html=safe parameters, the parameter data is
> not properly validated. See Model.Service.java:588:
> {code}
>
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> {code}
> Looking at that method:
> {code}
> public static String checkStringForHtmlSafeOnly(String valueName, String
> value, List errorMessageList) {
> ValidationErrorList vel = new ValidationErrorList();
> value = defaultWebValidator.getValidSafeHTML(valueName, value,
> Integer.MAX_VALUE, true, vel);
> errorMessageList.addAll(UtilGenerics.checkList(vel.errors(),
> String.class));
> return value;
> }
> {code}
> you can see that it expects the defaultWebValidator.getValidSafeHTML would
> add all validation errors to the given ValidationErrorList, but if you look
> at the implementation of ESAPI that is not the case. First, consider the
> overloaded getValidSafeHTML that takes the ValidationErrorList:
> {code}public String getValidSafeHTML(String context, String input,
> int maxLength, boolean allowNull, ValidationErrorList errors) throws
> IntrusionException {
> try {
> return getValidSafeHTML(context, input, maxLength,
> allowNull);
> } catch (ValidationException e) {
> errors.addError(context, e);
> }
> return input;
> }
> {code}
> Then, step into that method to see that ValidationExceptions are only thrown
> for things like exceeding the maximum length - not for policy violations that
> can be "cleaned", such as tags that are not allowed by the policy:
> {code}
> AntiSamy as = new AntiSamy();
> CleanResults test = as.scan(input, antiSamyPolicy);
> List errors = test.getErrorMessages();
> if ( errors.size() > 0 ) {
> // just create new exception to get it logged
> and intrusion detected
> new ValidationException( "Invalid HTML input:
> context=" + context, "Invalid HTML input: context=" + context + ", errors=" +
> errors, context );
> }
> {code}
> I guess that is an expected, although maybe not clearly documented behavior
> of ESAPI: Non-cleanable violations throw the exception and therefore will
> fail the ofbiz service, while non-allowed tags are cleaned. However, if you
> consider ModelService:588 and following lines again:
> {code}
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> //(...)
> if (errorMessageList.size() > 0) {
> throw new ServiceValidationException(errorMessageList, this,
> mode);
> }
> {code}
> the cleaned return value is ignored. Therefore, you will see an
> "IntrusionDetection" in the logs, giving you a false sense of security but
> the unfiltered HTML will still go into the service. So, if you want the
> service to fail
[jira] [Closed] (OFBIZ-10899) Have an Auditor party with associated AUDITOR SecurityGroup permissions in all DEMO instances
[ https://issues.apache.org/jira/browse/OFBIZ-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10899. --- Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Pierre, Your patch is in trunk at revision: 1859535 > Have an Auditor party with associated AUDITOR SecurityGroup permissions in > all DEMO instances > - > > Key: OFBIZ-10899 > URL: https://issues.apache.org/jira/browse/OFBIZ-10899 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10899-AuditorData.patch > > > While doing an implementation for a rental company (with involvement of an > external accountant/auditor), I came across the aspect that there is no > default security group regarding auditors. These parties, in general, have > only view permissions on the UI elements (screens/menu-items/forms and > templates). > In order to help the (potential) adopters to choose OFBiz, it would be smart > to have such a party, with the proposed SecurityGroup (and the appropriate > permissions) in play in any of our demo instances. > Not only for the aspect mentioned above, but also for seeing whether other > improvements can occur (e.g. create buttons visible to 'VIEW' only permission > holders). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11043) DemoLeadOwner and DemoLeadOwner1 have too much rigths
Jacques Le Roux created OFBIZ-11043:
---
Summary: DemoLeadOwner and DemoLeadOwner1 have too much rigths
Key: OFBIZ-11043
URL: https://issues.apache.org/jira/browse/OFBIZ-11043
Project: OFBiz
Issue Type: Improvement
Components: marketing
Affects Versions: Trunk
Reporter: Jacques Le Roux
Since pre Apache era we have those 2 FIXMEs:
{code:xml}
{code}
I even wonder what the goal of these users is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10899) Have an Auditor party with associated AUDITOR SecurityGroup permissions in all DEMO instances
[ https://issues.apache.org/jira/browse/OFBIZ-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10899: --- Assignee: Jacques Le Roux (was: Pierre Smits) > Have an Auditor party with associated AUDITOR SecurityGroup permissions in > all DEMO instances > - > > Key: OFBIZ-10899 > URL: https://issues.apache.org/jira/browse/OFBIZ-10899 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10899-AuditorData.patch > > > While doing an implementation for a rental company (with involvement of an > external accountant/auditor), I came across the aspect that there is no > default security group regarding auditors. These parties, in general, have > only view permissions on the UI elements (screens/menu-items/forms and > templates). > In order to help the (potential) adopters to choose OFBiz, it would be smart > to have such a party, with the proposed SecurityGroup (and the appropriate > permissions) in play in any of our demo instances. > Not only for the aspect mentioned above, but also for seeing whether other > improvements can occur (e.g. create buttons visible to 'VIEW' only permission > holders). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
