[jira] [Resolved] (OFBIZ-7816) Profile of contact person not shown on quick add of contact in SFA
[ https://issues.apache.org/jira/browse/OFBIZ-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana resolved OFBIZ-7816. -- Resolution: Fixed Fix Version/s: 18.12.01 16.11.06 17.12.01 This has been committed to Trunk at rev#1860797 Release18.12 at rev#1860798 Release17.12 at rev#1860799 Release16.11 at rev#1860800 > Profile of contact person not shown on quick add of contact in SFA > -- > > Key: OFBIZ-7816 > URL: https://issues.apache.org/jira/browse/OFBIZ-7816 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, > Release Branch 16.11, Release Branch 17.12, Release Branch 18.12 >Reporter: Aditi Patidar >Assignee: Suraj Khurana >Priority: Major > Labels: sfa > Fix For: 17.12.01, 16.11.06, 18.12.01, 16.11.01 > > Attachments: OFBIZ-7816-2.patch, OFBIZ-7816.patch, > OFBiz-7816-3.patch, quick add contact.png, quick-add-contact-after-fix.png > > > Steps to regenerate issue: > 1. Navigate to SFA. > 2. Enter 'First Name', 'Last Name' in 'Quick Add Contact' section and press > 'Submit' button. > Refer the attached screenshot to view the issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7816) Profile of contact person not shown on quick add of contact in SFA
[ https://issues.apache.org/jira/browse/OFBIZ-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-7816. Thanks Rohit Hukkeri for providing the updated patch and everyone else for their contribution in the ticket. > Profile of contact person not shown on quick add of contact in SFA > -- > > Key: OFBIZ-7816 > URL: https://issues.apache.org/jira/browse/OFBIZ-7816 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, > Release Branch 16.11, Release Branch 17.12, Release Branch 18.12 >Reporter: Aditi Patidar >Assignee: Suraj Khurana >Priority: Major > Labels: sfa > Fix For: 16.11.01, 17.12.01, 16.11.06, 18.12.01 > > Attachments: OFBIZ-7816-2.patch, OFBIZ-7816.patch, > OFBiz-7816-3.patch, quick add contact.png, quick-add-contact-after-fix.png > > > Steps to regenerate issue: > 1. Navigate to SFA. > 2. Enter 'First Name', 'Last Name' in 'Quick Add Contact' section and press > 'Submit' button. > Refer the attached screenshot to view the issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page
[ https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra reassigned OFBIZ-11095: - Assignee: Deepak Dixit (was: Nitish Mishra) > Ecommerce image distorted in trunk demo main page > - > > Key: OFBIZ-11095 > URL: https://issues.apache.org/jira/browse/OFBIZ-11095 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-11095.patch > > > Due to recent bootstrap changes, ecommerce image is distorted in trunk demo > main page -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page
[ https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra updated OFBIZ-11095: -- Attachment: OFBIZ-11095.patch > Ecommerce image distorted in trunk demo main page > - > > Key: OFBIZ-11095 > URL: https://issues.apache.org/jira/browse/OFBIZ-11095 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Nitish Mishra >Priority: Major > Attachments: OFBIZ-11095.patch > > > Due to recent bootstrap changes, ecommerce image is distorted in trunk demo > main page -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page
Nitish Mishra created OFBIZ-11095: - Summary: Ecommerce image distorted in trunk demo main page Key: OFBIZ-11095 URL: https://issues.apache.org/jira/browse/OFBIZ-11095 Project: OFBiz Issue Type: Sub-task Components: ecommerce Affects Versions: Trunk Reporter: Nitish Mishra Assignee: Nitish Mishra Due to recent bootstrap changes, ecommerce image is distorted in trunk demo main page -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858650#comment-16858650
]
Jacques Le Roux edited comment on OFBIZ-10145 at 6/7/19 1:37 PM:
-
Thanks Swapnil,
Yes this is what I thought about, your script looks good to me. Previouysly I
wrote:
bq. I even thought about hacking the gradlew scripts, then we would not need
init-gradle-wrapper at all. But those are generated with Gradle installation
and better keep them as delivered by Gradle.
I thought about it a bit more. We have those 2 scripts in our repo. When we
will update Gradle (using something like {{gradlew wrapper --gradle-version
5.4.1}}) Gradle may change those scripts. So if we put a call to our
init-gradle-wrapper scripts in them they will be removed. But it's then very
easy to put them again notably because we have a copy of the preceding version
in our repo.
So I finally suggest that we call our init-gradle-wrapper scripts from both
gradlew and gradlew.bat script if the Wrapper is not present. Then no need to
ask our users to run the init-gradle-wrapper by hand. Using the starting script
(gradlew or gradlew.bat) would be enough.
I even suggest that we keep the message from init-gradle-wrapper.sh
bq. "Gradle is not found in your system, downloading it to instantiate the
wrapper."
to reassure the users about what's going on. The download can be long before
you can really use OFBiz, I'd even add a message explaining that.
was (Author: jacques.le.roux):
Thanks Swapnil,
Yes this is what I thought about, your script looks good to me. Previouysly I
wrote:
bq. I even thought about hacking the gradlew scripts, then we would not need
init-gradle-wrapper at all. But those are generated with Gradle installation
and better keep them as delivered by Gradle.
I thought about it a bit more. We have those 2 scripts in our repo. When we
will update Gradle (using something like {{gradlew wrapper --gradle-version
5.4.1}}) Gradle may change those scripts. So if we put a call to our
init-gradle-wrapper scripts in them they will be removed. But it's then very
easy to put them again notably because we will have a copy of the preceding
version in our repo.
So I finally suggest that we call our init-gradle-wrapper scripts from both
gradlew and gradlew.bat script if the Wrapper is not present. Then no need to
ask our users to run the init-gradle-wrapper by hand using the starting script
(gradlew or gradlew.bat) would be enough.
I even suggest that we keep the message from init-gradle-wrapper.sh
bq. "Gradle is not found in your system, downloading it to instantiate the
wrapper."
to reassure the users about what's going on. The download can be long before
you can really use OFBiz, I'd even add a message explaining that.
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858650#comment-16858650
]
Jacques Le Roux commented on OFBIZ-10145:
-
Thanks Swapnil,
Yes this is what I thought about, your script looks good to me. Previouysly I
wrote:
bq. I even thought about hacking the gradlew scripts, then we would not need
init-gradle-wrapper at all. But those are generated with Gradle installation
and better keep them as delivered by Gradle.
I thought about it a bit more. We have those 2 scripts in our repo. When we
will update Gradle (using something like {{gradlew wrapper --gradle-version
5.4.1}}) Gradle may change those scripts. So if we put a call to our
init-gradle-wrapper scripts in them they will be removed. But it's then very
easy to put them again notably because we will have a copy of the preceding
version in our repo.
So I finally suggest that we call our init-gradle-wrapper scripts from both
gradlew and gradlew.bat script if the Wrapper is not present. Then no need to
ask our users to run the init-gradle-wrapper by hand using the starting script
(gradlew or gradlew.bat) would be enough.
I even suggest that we keep the message from init-gradle-wrapper.sh
bq. "Gradle is not found in your system, downloading it to instantiate the
wrapper."
to reassure the users about what's going on. The download can be long before
you can really use OFBiz, I'd even add a message explaining that.
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858591#comment-16858591
]
Swapnil M Mane commented on OFBIZ-10145:
Hi [~jacques.le.roux] ,
Thank you for your efforts. :)
I see no harm in copying gradle-wrapper.jar and gradle-wrapper.properties from
our repository. (let's see what others say)
Based on your input, our updated script will look someting like this.
{code:java}
OFBIZ_HOME="$(pwd)"
GRADLE_WRAPPER_OFBIZ_PATH="$OFBIZ_HOME/gradle/"
WRAPPER_URL="http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.jar;
WRAPPER_PROPERTIES_URL="http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.properties;
whereIsBinary() {
whereis $1 | grep /
}
if [ ! -d "$GRADLE_WRAPPER_OFBIZ_PATH" ]; then
echo "Location seems to be incorrect, please run the 'sh
gradle/init-gradle-wrapper.sh' script from Apache OFBiz root.";
exit -1;
fi
if [ -n "$(whereIsBinary curl)" ]; then
GET_CMD="curl -o";
elif [ -n "$(whereIsBinary wget)" ]; then
GET_CMD="wget -O";
else
echo "No command curl or wget found, please install yourself.";
exit -1
fi
$GET_CMD "gradle/wrapper/gradle-wrapper.jar" $WRAPPER_URL
$GET_CMD "gradle/wrapper/gradle-wrapper.properties" $WRAPPER_PROPERTIES_URL
{code}
[~jacques.le.roux], [~soledad] and team,
Please feel free to share your thoughts on this updated script.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11091) Have an AssetDimension
[ https://issues.apache.org/jira/browse/OFBIZ-11091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11091: - Attachment: OFBIZ-11091-AssetDimension.diff > Have an AssetDimension > -- > > Key: OFBIZ-11091 > URL: https://issues.apache.org/jira/browse/OFBIZ-11091 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: AssetDimension, asset, birt, dimension, dwh > Attachments: OFBIZ-11091-AssetDimension.diff > > > The component would benefit from a brand dimension for future fact tables and > star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11094) Buildbot RAT for releases branches
Jacques Le Roux created OFBIZ-11094: --- Summary: Buildbot RAT for releases branches Key: OFBIZ-11094 URL: https://issues.apache.org/jira/browse/OFBIZ-11094 Project: OFBiz Issue Type: New Feature Components: BuildBot Affects Versions: Release Branch 16.11, Release Branch 17.12, Release Branch 18.12 Reporter: Jacques Le Roux Assignee: Jacques Le Roux For the moment, only the trunk is verified by RAT (Apache Creadur). The initial idea was that once valided in trunk there should not be issue in releases branches, but better be safe than sorry! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
