[jira] [Commented] (OFBIZ-11799) Move page-specific script links to html template

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182591#comment-17182591
 ] 

ASF subversion and git services commented on OFBIZ-11799:
-

Commit 135c7f5158d4c0b0eb548821d78bfbbd1aef625d in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=135c7f5 ]

Improved: Move page-specific script links to html template (OFBIZ-11799)

Use importLibrary js function to load jstree js at CategoryTree.ftl
Tested at
https://localhost:8443/catalog/control/main


> Move page-specific script links to html template
> 
>
> Key: OFBIZ-11799
> URL: https://issues.apache.org/jira/browse/OFBIZ-11799
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> As external script can be defined in html template, suggest to move some of 
> the page-specific script links from layoutSettings.javaScripts to the html 
> templates.
> 6 Aug 2020
> Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
> VT_STYLESHEET.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-22 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182585#comment-17182585
 ] 

Suraj Khurana commented on OFBIZ-11928:
---

+1 Ankush,

It looks good to me. Please verify all the order level data and provide a patch 
for this solution.

> Explode items not handling tax and adjustments properly
> ---
>
> Key: OFBIZ-11928
> URL: https://issues.apache.org/jira/browse/OFBIZ-11928
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Suraj Khurana
>Assignee: Pradeep Choudhary
>Priority: Major
> Attachments: image-2020-08-22-14-54-06-042.png
>
>
> Steps to re-generate:
> 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 
>  2) Now change explode item to Y
>  3) Again create same order with same products and same quantity
>  4) Notice difference in item subtotal and grand total
> I see two issues here:
>  - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is 
> correct when explode is set to N (default order)
>  Code reference: It should be handled inside ShoppingCartItem.java#explodeItem
>  - Total sales tax is different in both orders:
>  10.72 and -0.03 which can be checked if this is any configuration issue, or 
> taxes are not being handled while exploding items.
> Demo orders on trunk (will not last for long):
>  explode: N
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001
> ]explode: Y
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11799) Move page-specific script links to html template

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182582#comment-17182582
 ] 

ASF subversion and git services commented on OFBIZ-11799:
-

Commit 9960b1cdb8db423435ddf4be411d32507948caac in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9960b1c ]

Improved: Move page-specific script links to html template (OFBIZ-11799)

Use importLibrary js function to load jstree in DisplayContentNav.ftl.
Tested page at
/exampleext/control/showHelp?helpTopic=EXAMPLEEXT_main==help=undefined=undefined


> Move page-specific script links to html template
> 
>
> Key: OFBIZ-11799
> URL: https://issues.apache.org/jira/browse/OFBIZ-11799
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> As external script can be defined in html template, suggest to move some of 
> the page-specific script links from layoutSettings.javaScripts to the html 
> templates.
> 6 Aug 2020
> Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
> VT_STYLESHEET.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11976) svg files not removed on clean

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182532#comment-17182532
 ] 

Alex Bodnaru commented on OFBIZ-11976:
--

they are being brought there somehow, by some building process.
so it's complementary process, e.g. clean should clean this file too.

> svg files not removed on clean
> --
>
> Key: OFBIZ-11976
> URL: https://issues.apache.org/jira/browse/OFBIZ-11976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>
> files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg,
> in many plugins, don't get removed on clean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182530#comment-17182530
 ] 

Alex Bodnaru commented on OFBIZ-11975:
--

no [~jleroux] , the bugs are not related.
the products may be created and / or duplicated manually.
as i mentioned, by keyword searching for wg-, you get both products, and we 
may continue the experiment there.

> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.
> the attached file is my example, it loads without error messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11979) enclose productsummary list in div.row to better use the screen/plugins

2020-08-22 Thread Alex Bodnaru (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Bodnaru updated OFBIZ-11979:
-
Attachment: p-missing-div-row.patch

> enclose productsummary list in div.row to better use the screen/plugins
> ---
>
> Key: OFBIZ-11979
> URL: https://issues.apache.org/jira/browse/OFBIZ-11979
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: p-missing-div-row.patch
>
>
> it's not about div.row only,
> in productdetail, the reason field was outside the summary box.
> i've moved the reason inside the summary box, as a generic parameter, 
> highlightLabel.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11979) enclose productsummary list in div.row to better use the screen/plugins

2020-08-22 Thread Alex Bodnaru (Jira)
Alex Bodnaru created OFBIZ-11979:


 Summary: enclose productsummary list in div.row to better use the 
screen/plugins
 Key: OFBIZ-11979
 URL: https://issues.apache.org/jira/browse/OFBIZ-11979
 Project: OFBiz
  Issue Type: Bug
  Components: ALL PLUGINS
Affects Versions: Trunk, Release Branch 17.12
Reporter: Alex Bodnaru


it's not about div.row only,

in productdetail, the reason field was outside the summary box.

i've moved the reason inside the summary box, as a generic parameter, 
highlightLabel.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11978) "cart" should be "card"

2020-08-22 Thread Alex Bodnaru (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Bodnaru updated OFBIZ-11978:
-
Summary: "cart" should be "card"  (was: cart should be card)

> "cart" should be "card"
> ---
>
> Key: OFBIZ-11978
> URL: https://issues.apache.org/jira/browse/OFBIZ-11978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Trivial
> Attachments: p-card-typo.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11902) Nested attributes for Collection Types

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182481#comment-17182481
 ] 

ASF subversion and git services commented on OFBIZ-11902:
-

Commit fdb67aee728a86d4d196ff915fb433029e6d6e22 in ofbiz-framework's branch 
refs/heads/trunk from girishvasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fdb67ae ]

WIP: Implemented: Added support for defining nested attributes.(OFBIZ-11902) 
(#231)

* Added nested attr definition and code to handle nested attributes

* Checkstyle error fix

* Fixed indentation and tabs issues

> Nested attributes for Collection Types
> --
>
> Key: OFBIZ-11902
> URL: https://issues.apache.org/jira/browse/OFBIZ-11902
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> While working on OpenApi integration as well as GraphQL implementation, I 
> faced issues on how to automatically document request/response JSON structure 
> for service attributes that were of Collection types (Map, List etc).
>   
>  For simple types, it is just plain easy but when it comes to Map/Lists, you 
> have to know what exactly is inside them to be able to convey properly in the 
> OpenApi schema.
>   
>  I was thinking to may be try to introduce nested attributes in service 
> definition such that if the attribute type is Map/List, you can actually 
> specify what goes inside that attribute -
>   
> {code:java}
>        
>        name="xyz" type="String"  default-value="test"/>  
> {code}
>   
>  With this change, it becomes possible to generate the schema for the service 
> attribute, Where as if we don't have this option, we can't possibly indicate 
> what the structure of the "header" key is going to be if it was represented 
> in JSON format.
>   
>  Of course, this change will only help documentation and GraphQL 
> implementation and that there is very little case for it to benefit a general 
> OFBiz service call.
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] girishvasmatkar merged pull request #231: WIP: Implemented: Added support for defining nested attributes.(OFBIZ-11902)

2020-08-22 Thread GitBox


girishvasmatkar merged pull request #231:
URL: https://github.com/apache/ofbiz-framework/pull/231


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #231: WIP: Implemented: Added support for defining nested attributes.(OFBIZ-11902)

2020-08-22 Thread GitBox


sonarcloud[bot] commented on pull request #231:
URL: https://github.com/apache/ofbiz-framework/pull/231#issuecomment-678673587


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_ofbiz-framework=231=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=231)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=231=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=231=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #231: WIP: Implemented: Added support for defining nested attributes.(OFBIZ-11902)

2020-08-22 Thread GitBox


sonarcloud[bot] removed a comment on pull request #231:
URL: https://github.com/apache/ofbiz-framework/pull/231#issuecomment-678649798


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_ofbiz-framework=231=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=231)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=231=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=231=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-11978) cart should be card

2020-08-22 Thread Alex Bodnaru (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Bodnaru updated OFBIZ-11978:
-
Priority: Trivial  (was: Major)

> cart should be card
> ---
>
> Key: OFBIZ-11978
> URL: https://issues.apache.org/jira/browse/OFBIZ-11978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Trivial
> Attachments: p-card-typo.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-9090) Unit test case for service - createProductConfigOption

2020-08-22 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9090.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks, [~PradhanYashSharma]!

> Unit test case for service - createProductConfigOption
> --
>
> Key: OFBIZ-9090
> URL: https://issues.apache.org/jira/browse/OFBIZ-9090
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9090.patch, OFBIZ-9090.patch
>
>
> Unit test case for service - createProductConfigOption



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9090) Unit test case for service - createProductConfigOption

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182466#comment-17182466
 ] 

ASF subversion and git services commented on OFBIZ-9090:


Commit 121634f8f3cb36e307606846d797d01720613674 in ofbiz-framework's branch 
refs/heads/trunk from Akash Jain
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=121634f ]

Improved: Unit test case for service - createProductConfigOption (OFBIZ-9090)

Thanks, Pradhan Yash Sharma for your contribution


> Unit test case for service - createProductConfigOption
> --
>
> Key: OFBIZ-9090
> URL: https://issues.apache.org/jira/browse/OFBIZ-9090
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9090.patch, OFBIZ-9090.patch
>
>
> Unit test case for service - createProductConfigOption



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11978) cart should be card

2020-08-22 Thread Alex Bodnaru (Jira)
Alex Bodnaru created OFBIZ-11978:


 Summary: cart should be card
 Key: OFBIZ-11978
 URL: https://issues.apache.org/jira/browse/OFBIZ-11978
 Project: OFBiz
  Issue Type: Bug
  Components: ecommerce
Affects Versions: Trunk
Reporter: Alex Bodnaru
 Attachments: p-card-typo.patch





--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11977) multiflex css is linking to wrong location

2020-08-22 Thread Alex Bodnaru (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Bodnaru updated OFBIZ-11977:
-
Summary: multiflex css is linking to wrong location  (was: multiflex css is 
links to wrong location)

> multiflex css is linking to wrong location
> --
>
> Key: OFBIZ-11977
> URL: https://issues.apache.org/jira/browse/OFBIZ-11977
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: p-bootstrap-css.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9090) Unit test case for service - createProductConfigOption

2020-08-22 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182463#comment-17182463
 ] 

Akash Jain commented on OFBIZ-9090:
---

Attached updated patch as identified major changes into attached patch.

> Unit test case for service - createProductConfigOption
> --
>
> Key: OFBIZ-9090
> URL: https://issues.apache.org/jira/browse/OFBIZ-9090
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9090.patch, OFBIZ-9090.patch
>
>
> Unit test case for service - createProductConfigOption



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-22 Thread Rohit Koushal (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182462#comment-17182462
 ] 

Rohit Koushal edited comment on OFBIZ-11928 at 8/22/20, 5:45 PM:
-

[~ankush.upadhyay] - Your #1 solution sounds good to me. I was also thinking, 
does same is also happening for the promotion adjustment. I mean if that code 
block is clear cart's ship info, so promotion adjustment also mostly like to be 
removed with tax adjustments. isn't it ?


was (Author: rohit.koushal):
[~ankush.upadhyay] - Your #1 solution sounds good to me. I was also thinking, 
does same is also happening for the promotion adjustment. I mean if that code 
block is clear cart's ship info, so promotion adjustment also mostly like to be 
removed with tax adjustments. 

> Explode items not handling tax and adjustments properly
> ---
>
> Key: OFBIZ-11928
> URL: https://issues.apache.org/jira/browse/OFBIZ-11928
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Suraj Khurana
>Assignee: Pradeep Choudhary
>Priority: Major
> Attachments: image-2020-08-22-14-54-06-042.png
>
>
> Steps to re-generate:
> 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 
>  2) Now change explode item to Y
>  3) Again create same order with same products and same quantity
>  4) Notice difference in item subtotal and grand total
> I see two issues here:
>  - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is 
> correct when explode is set to N (default order)
>  Code reference: It should be handled inside ShoppingCartItem.java#explodeItem
>  - Total sales tax is different in both orders:
>  10.72 and -0.03 which can be checked if this is any configuration issue, or 
> taxes are not being handled while exploding items.
> Demo orders on trunk (will not last for long):
>  explode: N
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001
> ]explode: Y
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-22 Thread Rohit Koushal (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182462#comment-17182462
 ] 

Rohit Koushal commented on OFBIZ-11928:
---

[~ankush.upadhyay] - Your #1 solution sounds good to me. I was also thinking, 
does same is also happening for the promotion adjustment. I mean if that code 
block is clear cart's ship info, so promotion adjustment also mostly like to be 
removed with tax adjustments. 

> Explode items not handling tax and adjustments properly
> ---
>
> Key: OFBIZ-11928
> URL: https://issues.apache.org/jira/browse/OFBIZ-11928
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Suraj Khurana
>Assignee: Pradeep Choudhary
>Priority: Major
> Attachments: image-2020-08-22-14-54-06-042.png
>
>
> Steps to re-generate:
> 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 
>  2) Now change explode item to Y
>  3) Again create same order with same products and same quantity
>  4) Notice difference in item subtotal and grand total
> I see two issues here:
>  - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is 
> correct when explode is set to N (default order)
>  Code reference: It should be handled inside ShoppingCartItem.java#explodeItem
>  - Total sales tax is different in both orders:
>  10.72 and -0.03 which can be checked if this is any configuration issue, or 
> taxes are not being handled while exploding items.
> Demo orders on trunk (will not last for long):
>  explode: N
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001
> ]explode: Y
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11977) multiflex css is links to wrong location

2020-08-22 Thread Alex Bodnaru (Jira)
Alex Bodnaru created OFBIZ-11977:


 Summary: multiflex css is links to wrong location
 Key: OFBIZ-11977
 URL: https://issues.apache.org/jira/browse/OFBIZ-11977
 Project: OFBiz
  Issue Type: Bug
  Components: ALL PLUGINS
Affects Versions: Trunk, Release Branch 17.12
Reporter: Alex Bodnaru
 Attachments: p-bootstrap-css.patch





--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9090) Unit test case for service - createProductConfigOption

2020-08-22 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-9090:
--
Attachment: OFBIZ-9090.patch

> Unit test case for service - createProductConfigOption
> --
>
> Key: OFBIZ-9090
> URL: https://issues.apache.org/jira/browse/OFBIZ-9090
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9090.patch, OFBIZ-9090.patch
>
>
> Unit test case for service - createProductConfigOption



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11969) bootstrap-bundle*.js contains bootstrap*.js

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182461#comment-17182461
 ] 

Alex Bodnaru commented on OFBIZ-11969:
--

we were talking about possible bootstrap loading by angular.js.

it's not something i know about.

> bootstrap-bundle*.js contains bootstrap*.js
> ---
>
> Key: OFBIZ-11969
> URL: https://issues.apache.org/jira/browse/OFBIZ-11969
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: p-bootstrap-bundle-css.patch, 
> p-bootstrap-bundle-only.patch
>
>
> non-bundle is redundant, with performance hit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-8376) IncomeStatementListPdf.pdf fails

2020-08-22 Thread Rohit Koushal (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182460#comment-17182460
 ] 

Rohit Koushal commented on OFBIZ-8376:
--

Thanks [~lalit.dashora],

Can you please check and confirm that the reported problem does not exist prior 
to [r1753886|http://svn.apache.org/viewvc?view=revision=r1753886]  and 
If report rendering properly means that it is also suffering due to birt jar 
upgradation.

> IncomeStatementListPdf.pdf fails
> 
>
> Key: OFBIZ-8376
> URL: https://issues.apache.org/jira/browse/OFBIZ-8376
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> For 
> https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company
>  the PDF report at 
> https://localhost:8443/accounting/control/IncomeStatementListPdf.pdf fails 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails

2020-08-22 Thread Rohit Koushal (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182459#comment-17182459
 ] 

Rohit Koushal commented on OFBIZ-6638:
--

[~jleroux]: Basically that updated jar is not compatible with the current 
implementation. Either we need to move back to old jar version or we need to 
update current code. :) 

> TrialBalance PDF export fails
> -
>
> Key: OFBIZ-6638
> URL: https://issues.apache.org/jira/browse/OFBIZ-6638
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png
>
>
> # Get to 
> http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company
> #pick a "Custom Time Period Id" (default works also)
> #Submit
> Then the CSV export works but not the PDF, this in trunk demo.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-22 Thread Ankush Upadhyay (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182457#comment-17182457
 ] 

Ankush Upadhyay edited comment on OFBIZ-11928 at 8/22/20, 5:23 PM:
---

[~pradeep.choudhary1994], [~surajk],

In order creation workflow, it calls makeOrderItems() that internally call 
explodeItems() so the explodeItems() iterate all items and start to explode 
them one by one using method ShoppingCartItem.explodeItem() so to explode each 
quantity, it uses setQuantity() method of ShoppingCartItem that clear cart's 
ship info object using method

cart.clearItemShipInfo(this); So from here the tax details are getting removed.

I think the tax should also needs to explode with items. To do so there can be 
possible solutions like
 # Can calculate and add tax again for exploded items using method 
CheckoutHelper.calcAndAddTax().
 # Before calling explodeItem(), somehow get the tax info from ship info 
object, prorate tax for exploded items.

I tried to verify #1 solution and it worked as expected, it exploded item tax 
as well. I would try to verify all order level data.

But in meantime, if anyone has any thoughts then please share.


was (Author: ankush.upadhyay):
[~pradeep.choudhary1994], [~surajk],

In order creation workflow, it calls makeOrderItems() that internally call 
explodeItems() so the explodeItems() iterate all items and start to explode 
them one by one using method ShoppingCartItem.explodeItem() so to explode each 
quantity, it uses setQuantity() method of ShoppingCartItem that clear cart's 
ship info object using method

cart.clearItemShipInfo(this); So from here the tax details are getting removed.

I think the tax should also needs to explode with items. To do so there can be 
possible solutions like
 # Can calculate and add tax again for exploded items using method 
CheckoutHelper.calcAndAddTax().
 # Before calling explodeItem(), somehow get the tax info from ship info 
object, prorate tax for exploded items.

I tried to verify #1 solution and it worked as expected, it exploded item tax 
as well. I would try to verify all order level data.

> Explode items not handling tax and adjustments properly
> ---
>
> Key: OFBIZ-11928
> URL: https://issues.apache.org/jira/browse/OFBIZ-11928
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Suraj Khurana
>Assignee: Pradeep Choudhary
>Priority: Major
> Attachments: image-2020-08-22-14-54-06-042.png
>
>
> Steps to re-generate:
> 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 
>  2) Now change explode item to Y
>  3) Again create same order with same products and same quantity
>  4) Notice difference in item subtotal and grand total
> I see two issues here:
>  - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is 
> correct when explode is set to N (default order)
>  Code reference: It should be handled inside ShoppingCartItem.java#explodeItem
>  - Total sales tax is different in both orders:
>  10.72 and -0.03 which can be checked if this is any configuration issue, or 
> taxes are not being handled while exploding items.
> Demo orders on trunk (will not last for long):
>  explode: N
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001
> ]explode: Y
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-6638) TrialBalance PDF export fails

2020-08-22 Thread Rohit Koushal (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182459#comment-17182459
 ] 

Rohit Koushal edited comment on OFBIZ-6638 at 8/22/20, 5:23 PM:


[~jleroux]: Basically new updated jar is not compatible with the current 
implementation. Either we need to move back to old jar version or we need to 
update current code. :) 


was (Author: rohit.koushal):
[~jleroux]: Basically that updated jar is not compatible with the current 
implementation. Either we need to move back to old jar version or we need to 
update current code. :) 

> TrialBalance PDF export fails
> -
>
> Key: OFBIZ-6638
> URL: https://issues.apache.org/jira/browse/OFBIZ-6638
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png
>
>
> # Get to 
> http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company
> #pick a "Custom Time Period Id" (default works also)
> #Submit
> Then the CSV export works but not the PDF, this in trunk demo.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-22 Thread Ankush Upadhyay (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182457#comment-17182457
 ] 

Ankush Upadhyay commented on OFBIZ-11928:
-

[~pradeep.choudhary1994], [~surajk],

In order creation workflow, it calls makeOrderItems() that internally call 
explodeItems() so the explodeItems() iterate all items and start to explode 
them one by one using method ShoppingCartItem.explodeItem() so to explode each 
quantity, it uses setQuantity() method of ShoppingCartItem that clear cart's 
ship info object using method

cart.clearItemShipInfo(this); So from here the tax details are getting removed.

I think the tax should also needs to explode with items. To do so there can be 
possible solutions like
 # Can calculate and add tax again for exploded items using method 
CheckoutHelper.calcAndAddTax().
 # Before calling explodeItem(), somehow get the tax info from ship info 
object, prorate tax for exploded items.

I tried to verify #1 solution and it worked as expected, it exploded item tax 
as well. I would try to verify all order level data.

> Explode items not handling tax and adjustments properly
> ---
>
> Key: OFBIZ-11928
> URL: https://issues.apache.org/jira/browse/OFBIZ-11928
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Suraj Khurana
>Assignee: Pradeep Choudhary
>Priority: Major
> Attachments: image-2020-08-22-14-54-06-042.png
>
>
> Steps to re-generate:
> 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 
>  2) Now change explode item to Y
>  3) Again create same order with same products and same quantity
>  4) Notice difference in item subtotal and grand total
> I see two issues here:
>  - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is 
> correct when explode is set to N (default order)
>  Code reference: It should be handled inside ShoppingCartItem.java#explodeItem
>  - Total sales tax is different in both orders:
>  10.72 and -0.03 which can be checked if this is any configuration issue, or 
> taxes are not being handled while exploding items.
> Demo orders on trunk (will not last for long):
>  explode: N
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001
> ]explode: Y
>  
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #231: WIP: Implemented: Added support for defining nested attributes.(OFBIZ-11902)

2020-08-22 Thread GitBox


JacquesLeRoux edited a comment on pull request #231:
URL: https://github.com/apache/ofbiz-framework/pull/231#issuecomment-678665728


   Hi Girish,
   
   Looks good to me, jsut that you should avoid to use tabs and left trailing 
spaces ;)
   
   C:\projectsASF\Git\ofbiz-framework>git apply 231.patch
   231.patch:22: space before tab in indent.
   
   231.patch:25: space before tab in indent.
   
   231.patch:54: trailing whitespace.
   231.patch:55: trailing whitespace.
   231.patch:61: space before tab in indent.
   children = new ArrayList<>();
   warning: squelched 4 whitespace errors
   warning: 9 lines add whitespace errors.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #231: WIP: Implemented: Added support for defining nested attributes.(OFBIZ-11902)

2020-08-22 Thread GitBox


JacquesLeRoux commented on pull request #231:
URL: https://github.com/apache/ofbiz-framework/pull/231#issuecomment-678665728


   Hi Girish,
   
   Looks good to me, jsut that you should avoid to use tabs in XML and left 
trailing spaces ;)
   
   C:\projectsASF\Git\ofbiz-framework>git apply 231.patch
   231.patch:22: space before tab in indent.
   
   231.patch:25: space before tab in indent.
   
   231.patch:54: trailing whitespace.
   
   231.patch:55: trailing whitespace.
   
   231.patch:61: space before tab in indent.
   children = new ArrayList<>();
   warning: squelched 4 whitespace errors
   warning: 9 lines add whitespace errors.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11919) Convert SystemInfoServices.xml mini lang to groovy

2020-08-22 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182432#comment-17182432
 ] 

Pawan Verma commented on OFBIZ-11919:
-

Hi [~rohit.koushal]

Your patch looks good to me. +1 for commit :) 

> Convert SystemInfoServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11919
> URL: https://issues.apache.org/jira/browse/OFBIZ-11919
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-11919.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-22 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182431#comment-17182431
 ] 

Jacques Le Roux commented on OFBIZ-11975:
-

Does OFBIZ-11955 depends on this bug? If so please create a such link between 
the issues, TIA

> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.
> the attached file is my example, it loads without error messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11969) bootstrap-bundle*.js contains bootstrap*.js

2020-08-22 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182429#comment-17182429
 ] 

Jacques Le Roux commented on OFBIZ-11969:
-

Does these loads fail because they try from 
ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap.-4.3.1.min.js?

Because there should no relations between plugins, they are supposed to be 
independent.

> bootstrap-bundle*.js contains bootstrap*.js
> ---
>
> Key: OFBIZ-11969
> URL: https://issues.apache.org/jira/browse/OFBIZ-11969
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: p-bootstrap-bundle-css.patch, 
> p-bootstrap-bundle-only.patch
>
>
> non-bundle is redundant, with performance hit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11919) Convert SystemInfoServices.xml mini lang to groovy

2020-08-22 Thread Rohit Koushal (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182428#comment-17182428
 ] 

Rohit Koushal commented on OFBIZ-11919:
---

Attaching patch [^OFBIZ-11919.patch] which contains conversion of 
SystemInfoServices.xml mini lang to DSL groovy.

> Convert SystemInfoServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11919
> URL: https://issues.apache.org/jira/browse/OFBIZ-11919
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-11919.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10669) Getting Insecure connection error while navigating from product link

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10669:

Sprint: OFBiz Community Day (Aug 2020)

> Getting Insecure connection error while navigating from product link
> 
>
> Key: OFBIZ-10669
> URL: https://issues.apache.org/jira/browse/OFBIZ-10669
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/processorder?checkoutpage=payment
>Reporter: Archana Asthana
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
> Attachments: Error.png, OFBIZ-10669.patch, OrderViewPage.png
>
>
> Steps to Regenerate
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/processorder?checkoutpage=payment
> 2. Created Order with few products
> 3. Login by creating a new user
> 4. Submitted the order
> 5 Click the product link
> *Actual: *
> Error is thrown as demo-trunk.ofbiz.apache.org sent an invalid response.
> This site can’t provide a secure connection.
> The Url is changing to 8080 in the url
> When this value is removed and enter resubmit the url
> View Product page gets open
> The Image is attached for reference for both the screens.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11919) Convert SystemInfoServices.xml mini lang to groovy

2020-08-22 Thread Rohit Koushal (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-11919:
--
Attachment: OFBIZ-11919.patch

> Convert SystemInfoServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11919
> URL: https://issues.apache.org/jira/browse/OFBIZ-11919
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-11919.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11735) Product link on Order confirmation page is not responding

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11735:

Sprint: OFBiz Community Day (Aug 2020)

> Product link on Order confirmation page is not responding
> -
>
> Key: OFBIZ-11735
> URL: https://issues.apache.org/jira/browse/OFBIZ-11735
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 17.12.03
>Reporter: Rashi Dhagat
>Assignee: Akash Jain
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-11735.patch, ProductlinkNotresponding.webm
>
>
> Steps to regenerate:
> 1. Open [https://demo-stable.ofbiz.apache.org/ecommerce/control/main]
> 2. Login
> 3. Add item to Cart
> 4. Checkout
> 5. Click on the product name in Order Items section
> Actual:  Page timeout error when click on product name link but working for 
> other links.
> Please refer the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11933) Checkbox not selected after searching with multiple options checked in form widget

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11933:

Sprint: OFBiz Community Day (Aug 2020)

> Checkbox not selected after searching with multiple options checked in form 
> widget
> --
>
> Key: OFBIZ-11933
> URL: https://issues.apache.org/jira/browse/OFBIZ-11933
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11933.patch
>
>
> No checkbox appears as selected when we click on find button even though the 
> order is filtered, this is happening on all the screens where form-widget is 
> used, as  tag has an attribute all-check for checkboxes which is set 
> to false.
> If the value of the checkbox is false then whenever the page loads, it 
> unchecks all checkboxes and displays no checkbox as selected, but filters the 
> result correctly.
> If we remove this attribute from the check element then it is working fine in 
> case of single checkbox selection, but if multiple checkboxes are selected 
> then again it shows all checkboxes as unchecked.
> This happens on all the find forms which are implemented using form-widgets.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-7480) Require check on Create Facility Content Screen

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7480:
---
Sprint: OFBiz Community Day (Aug 2020)

> Require check on Create Facility Content Screen
> ---
>
> Key: OFBIZ-7480
> URL: https://issues.apache.org/jira/browse/OFBIZ-7480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Jacopo Cappellato
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: CreateFacilityContentNote.png, OFBIZ-7480.patch
>
>
> Navigate to Content in facilities and add Facility Content. Require check is 
> not there on mandatory fields.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11405) Create new quote button should be removed from new quote screen

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11405:

Sprint: OFBiz Community Day (Aug 2020)

> Create new quote button should be removed from new quote screen
> ---
>
> Key: OFBIZ-11405
> URL: https://issues.apache.org/jira/browse/OFBIZ-11405
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Akash Jain
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11405.patch
>
>
> While reviewing OFBIZ-11221 noticed another issue.
> Steps to replicate the issue : 
>  * Go to ordermgr  application.
>  * On find quote screen clicks upon Create New Quote button.
>  * System will navigate you to to create new quote screen.
>  * On create new quote screen you will see Create New Quote button. 
> It make sense on other menu/tab items of quote screen (as user can create new 
> quote anytime from other quote screens) but it should not make any sense over 
> create new quote screen.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11968) Error when rendering renderSubmitField macro

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11968:

Sprint: OFBiz Community Day (Aug 2020)

> Error when rendering renderSubmitField macro
> 
>
> Key: OFBIZ-11968
> URL: https://issues.apache.org/jira/browse/OFBIZ-11968
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FindSkillsPageError.png, Image 001.png
>
>
> Error shown on page when accessing /humanres/control/FindPartySkills page
> {code:java}
> When calling macro "renderSubmitField", required parameter "id" (parameter 
> #8) was not specified{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9687) Bug in order manager main page when using Arab language

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9687:
---
Sprint: OFBiz Community Day (Aug 2020)

> Bug in order manager main page when using Arab language
> ---
>
> Key: OFBIZ-9687
> URL: https://issues.apache.org/jira/browse/OFBIZ-9687
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Jacques Le Roux
>Assignee: Mohammed Rehan Khan
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9687-Trunk.patch
>
>
> Here is the error
> {code}
> 2017-09-08 08:38:27,272 |http-nio-8459-exec-7 |ServiceDispatcher 
> |T| Sync service [order/getVisualThemeResources] finished in [1] milliseconds
> 2017-09-08 08:38:27,304 |http-nio-8459-exec-7 |ModelScreenWidget 
> |E| Error rendering widgets section [] in screen named [GlobalDecorator]: 
> freemarker.core.ParseException: Syntax error in template
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> freemarker.core.ParseException: Syntax error in template 
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> at 
> freemarker.core.TokenMgrError.toParseException(TokenMgrError.java:260) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:267) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:207) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:183) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:125) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:130)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.renderMenuOpen(MacroMenuRenderer.java:369)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderSimpleMenuString(ModelMenu.java:515)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderMenuString(ModelMenu.java:505) 
> ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.renderWidgetString(ModelScreenWidget.java:1585)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:294)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:780)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Commented] (OFBIZ-11976) svg files not removed on clean

2020-08-22 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182426#comment-17182426
 ] 

Jacques Le Roux commented on OFBIZ-11976:
-

Thanks Alex,

I have notice that for months. Like others, I guess, I did not report. Because 
it's just annoying. But yes we should clean them, not sure how though.

> svg files not removed on clean
> --
>
> Key: OFBIZ-11976
> URL: https://issues.apache.org/jira/browse/OFBIZ-11976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>
> files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg,
> in many plugins, don't get removed on clean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11969) bootstrap-bundle*.js contains bootstrap*.js

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182424#comment-17182424
 ] 

Alex Bodnaru commented on OFBIZ-11969:
--

my warning was not about touching angular.js,

but about some unexpected load of bootstrap-4.3.1.js locally

inside angular.js.

> bootstrap-bundle*.js contains bootstrap*.js
> ---
>
> Key: OFBIZ-11969
> URL: https://issues.apache.org/jira/browse/OFBIZ-11969
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: p-bootstrap-bundle-css.patch, 
> p-bootstrap-bundle-only.patch
>
>
> non-bundle is redundant, with performance hit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9687) Bug in order manager main page when using Arab language

2020-08-22 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182423#comment-17182423
 ] 

Jacques Le Roux commented on OFBIZ-9687:


Well spotted Mohammed !

> Bug in order manager main page when using Arab language
> ---
>
> Key: OFBIZ-9687
> URL: https://issues.apache.org/jira/browse/OFBIZ-9687
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Jacques Le Roux
>Assignee: Mohammed Rehan Khan
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9687-Trunk.patch
>
>
> Here is the error
> {code}
> 2017-09-08 08:38:27,272 |http-nio-8459-exec-7 |ServiceDispatcher 
> |T| Sync service [order/getVisualThemeResources] finished in [1] milliseconds
> 2017-09-08 08:38:27,304 |http-nio-8459-exec-7 |ModelScreenWidget 
> |E| Error rendering widgets section [] in screen named [GlobalDecorator]: 
> freemarker.core.ParseException: Syntax error in template
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> freemarker.core.ParseException: Syntax error in template 
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> at 
> freemarker.core.TokenMgrError.toParseException(TokenMgrError.java:260) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:267) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:207) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:183) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:125) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:130)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.renderMenuOpen(MacroMenuRenderer.java:369)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderSimpleMenuString(ModelMenu.java:515)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderMenuString(ModelMenu.java:505) 
> ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.renderWidgetString(ModelScreenWidget.java:1585)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:294)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:780)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Closed] (OFBIZ-9687) Bug in order manager main page when using Arab language

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9687.
--
Fix Version/s: 17.12.05
   18.12.01
   Resolution: Fixed

> Bug in order manager main page when using Arab language
> ---
>
> Key: OFBIZ-9687
> URL: https://issues.apache.org/jira/browse/OFBIZ-9687
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Jacques Le Roux
>Assignee: Mohammed Rehan Khan
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9687-Trunk.patch
>
>
> Here is the error
> {code}
> 2017-09-08 08:38:27,272 |http-nio-8459-exec-7 |ServiceDispatcher 
> |T| Sync service [order/getVisualThemeResources] finished in [1] milliseconds
> 2017-09-08 08:38:27,304 |http-nio-8459-exec-7 |ModelScreenWidget 
> |E| Error rendering widgets section [] in screen named [GlobalDecorator]: 
> freemarker.core.ParseException: Syntax error in template
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> freemarker.core.ParseException: Syntax error in template 
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> at 
> freemarker.core.TokenMgrError.toParseException(TokenMgrError.java:260) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:267) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:207) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:183) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:125) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:130)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.renderMenuOpen(MacroMenuRenderer.java:369)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderSimpleMenuString(ModelMenu.java:515)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderMenuString(ModelMenu.java:505) 
> ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.renderWidgetString(ModelScreenWidget.java:1585)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:294)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:780)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Commented] (OFBIZ-9687) Bug in order manager main page when using Arab language

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182422#comment-17182422
 ] 

ASF subversion and git services commented on OFBIZ-9687:


Commit c097341718da36495567e477214a092f061af61e in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c097341 ]

Fixed: Bug in order manager main page when using Arab language (OFBIZ-9687)

It seems that we are getting the issue due to the special character "/" which is
present in OrderManager Uilabel.
I just changed the OrderManager Uilabel value from Buy / Sell Order Manager to
Order Manager and removed the special character "/".

Thanks: Mohammed Rehan Khan


> Bug in order manager main page when using Arab language
> ---
>
> Key: OFBIZ-9687
> URL: https://issues.apache.org/jira/browse/OFBIZ-9687
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Jacques Le Roux
>Assignee: Mohammed Rehan Khan
>Priority: Minor
> Attachments: OFBIZ-9687-Trunk.patch
>
>
> Here is the error
> {code}
> 2017-09-08 08:38:27,272 |http-nio-8459-exec-7 |ServiceDispatcher 
> |T| Sync service [order/getVisualThemeResources] finished in [1] milliseconds
> 2017-09-08 08:38:27,304 |http-nio-8459-exec-7 |ModelScreenWidget 
> |E| Error rendering widgets section [] in screen named [GlobalDecorator]: 
> freemarker.core.ParseException: Syntax error in template
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> freemarker.core.ParseException: Syntax error in template 
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> at 
> freemarker.core.TokenMgrError.toParseException(TokenMgrError.java:260) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:267) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:207) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:183) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:125) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:130)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.renderMenuOpen(MacroMenuRenderer.java:369)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderSimpleMenuString(ModelMenu.java:515)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderMenuString(ModelMenu.java:505) 
> ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.renderWidgetString(ModelScreenWidget.java:1585)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:294)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Commented] (OFBIZ-9687) Bug in order manager main page when using Arab language

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182420#comment-17182420
 ] 

ASF subversion and git services commented on OFBIZ-9687:


Commit 5ebc88d21381f4ab423be6de6c3f6a60d53366f9 in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5ebc88d ]

Fixed: Bug in order manager main page when using Arab language (OFBIZ-9687)

It seems that we are getting the issue due to the special character "/" which is
present in OrderManager Uilabel.
I just changed the OrderManager Uilabel value from Buy / Sell Order Manager to
Order Manager and removed the special character "/".

Thanks: Mohammed Rehan Khan


> Bug in order manager main page when using Arab language
> ---
>
> Key: OFBIZ-9687
> URL: https://issues.apache.org/jira/browse/OFBIZ-9687
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Jacques Le Roux
>Assignee: Mohammed Rehan Khan
>Priority: Minor
> Attachments: OFBIZ-9687-Trunk.patch
>
>
> Here is the error
> {code}
> 2017-09-08 08:38:27,272 |http-nio-8459-exec-7 |ServiceDispatcher 
> |T| Sync service [order/getVisualThemeResources] finished in [1] milliseconds
> 2017-09-08 08:38:27,304 |http-nio-8459-exec-7 |ModelScreenWidget 
> |E| Error rendering widgets section [] in screen named [GlobalDecorator]: 
> freemarker.core.ParseException: Syntax error in template
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> freemarker.core.ParseException: Syntax error in template 
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> at 
> freemarker.core.TokenMgrError.toParseException(TokenMgrError.java:260) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:267) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:207) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:183) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:125) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:130)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.renderMenuOpen(MacroMenuRenderer.java:369)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderSimpleMenuString(ModelMenu.java:515)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderMenuString(ModelMenu.java:505) 
> ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.renderWidgetString(ModelScreenWidget.java:1585)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:294)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Created] (OFBIZ-11976) svg files not removed on clean

2020-08-22 Thread Alex Bodnaru (Jira)
Alex Bodnaru created OFBIZ-11976:


 Summary: svg files not removed on clean
 Key: OFBIZ-11976
 URL: https://issues.apache.org/jira/browse/OFBIZ-11976
 Project: OFBiz
  Issue Type: Bug
  Components: ALL PLUGINS
Affects Versions: Trunk, Release Branch 17.12
Reporter: Alex Bodnaru


files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg,

in many plugins, don't get removed on clean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9687) Bug in order manager main page when using Arab language

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182421#comment-17182421
 ] 

ASF subversion and git services commented on OFBIZ-9687:


Commit dbec7e766c5243fafafe6b61be2a5a346cc015f9 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=dbec7e7 ]

Fixed: Bug in order manager main page when using Arab language (OFBIZ-9687)

It seems that we are getting the issue due to the special character "/" which is
present in OrderManager Uilabel.
I just changed the OrderManager Uilabel value from Buy / Sell Order Manager to
Order Manager and removed the special character "/".

Thanks: Mohammed Rehan Khan


> Bug in order manager main page when using Arab language
> ---
>
> Key: OFBIZ-9687
> URL: https://issues.apache.org/jira/browse/OFBIZ-9687
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Jacques Le Roux
>Assignee: Mohammed Rehan Khan
>Priority: Minor
> Attachments: OFBIZ-9687-Trunk.patch
>
>
> Here is the error
> {code}
> 2017-09-08 08:38:27,272 |http-nio-8459-exec-7 |ServiceDispatcher 
> |T| Sync service [order/getVisualThemeResources] finished in [1] milliseconds
> 2017-09-08 08:38:27,304 |http-nio-8459-exec-7 |ModelScreenWidget 
> |E| Error rendering widgets section [] in screen named [GlobalDecorator]: 
> freemarker.core.ParseException: Syntax error in template
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> freemarker.core.ParseException: Syntax error in template 
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> at 
> freemarker.core.TokenMgrError.toParseException(TokenMgrError.java:260) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:267) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:207) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:183) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:125) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:130)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.renderMenuOpen(MacroMenuRenderer.java:369)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderSimpleMenuString(ModelMenu.java:515)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderMenuString(ModelMenu.java:505) 
> ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.renderWidgetString(ModelScreenWidget.java:1585)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:294)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Commented] (OFBIZ-11405) Create new quote button should be removed from new quote screen

2020-08-22 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182416#comment-17182416
 ] 

Akash Jain commented on OFBIZ-11405:


Thanks, [~upadhyay.ratnesh]!

> Create new quote button should be removed from new quote screen
> ---
>
> Key: OFBIZ-11405
> URL: https://issues.apache.org/jira/browse/OFBIZ-11405
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Akash Jain
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11405.patch
>
>
> While reviewing OFBIZ-11221 noticed another issue.
> Steps to replicate the issue : 
>  * Go to ordermgr  application.
>  * On find quote screen clicks upon Create New Quote button.
>  * System will navigate you to to create new quote screen.
>  * On create new quote screen you will see Create New Quote button. 
> It make sense on other menu/tab items of quote screen (as user can create new 
> quote anytime from other quote screens) but it should not make any sense over 
> create new quote screen.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11405) Create new quote button should be removed from new quote screen

2020-08-22 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11405.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Create new quote button should be removed from new quote screen
> ---
>
> Key: OFBIZ-11405
> URL: https://issues.apache.org/jira/browse/OFBIZ-11405
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Akash Jain
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11405.patch
>
>
> While reviewing OFBIZ-11221 noticed another issue.
> Steps to replicate the issue : 
>  * Go to ordermgr  application.
>  * On find quote screen clicks upon Create New Quote button.
>  * System will navigate you to to create new quote screen.
>  * On create new quote screen you will see Create New Quote button. 
> It make sense on other menu/tab items of quote screen (as user can create new 
> quote anytime from other quote screens) but it should not make any sense over 
> create new quote screen.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11405) Create new quote button should be removed from new quote screen

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182413#comment-17182413
 ] 

ASF subversion and git services commented on OFBIZ-11405:
-

Commit b67eb606a682d0e20faf2f78b284b5889bfb0a50 in ofbiz-framework's branch 
refs/heads/trunk from Akash Jain
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b67eb60 ]

Improved: Create new quote button should be removed from new quote screen 
(OFBIZ-11405)

Thanks, Ratnesh for reporting the issue.


> Create new quote button should be removed from new quote screen
> ---
>
> Key: OFBIZ-11405
> URL: https://issues.apache.org/jira/browse/OFBIZ-11405
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-11405.patch
>
>
> While reviewing OFBIZ-11221 noticed another issue.
> Steps to replicate the issue : 
>  * Go to ordermgr  application.
>  * On find quote screen clicks upon Create New Quote button.
>  * System will navigate you to to create new quote screen.
>  * On create new quote screen you will see Create New Quote button. 
> It make sense on other menu/tab items of quote screen (as user can create new 
> quote anytime from other quote screens) but it should not make any sense over 
> create new quote screen.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-22 Thread Alex Bodnaru (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Bodnaru updated OFBIZ-11975:
-
Attachment: variantinfojs-data.xml

> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-22 Thread Alex Bodnaru (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Bodnaru updated OFBIZ-11975:
-
Description: 
i loaded the attached xml (in admin).

the product (wg3-) shows in the product search in admin.

it also shows in keyword search in ecomseo.

the attached file is my example, it loads without error messages.

  was:
i loaded the attached xml (in admin).

the product (wg3-) shows in the product search in admin.

it also shows in keyword search in ecomseo.


> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.
> the attached file is my example, it loads without error messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11405) Create new quote button should be removed from new quote screen

2020-08-22 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182410#comment-17182410
 ] 

Akash Jain commented on OFBIZ-11405:


Here is the ticket OFBIZ-11974 for other create screens.

> Create new quote button should be removed from new quote screen
> ---
>
> Key: OFBIZ-11405
> URL: https://issues.apache.org/jira/browse/OFBIZ-11405
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-11405.patch
>
>
> While reviewing OFBIZ-11221 noticed another issue.
> Steps to replicate the issue : 
>  * Go to ordermgr  application.
>  * On find quote screen clicks upon Create New Quote button.
>  * System will navigate you to to create new quote screen.
>  * On create new quote screen you will see Create New Quote button. 
> It make sense on other menu/tab items of quote screen (as user can create new 
> quote anytime from other quote screens) but it should not make any sense over 
> create new quote screen.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-22 Thread Alex Bodnaru (Jira)
Alex Bodnaru created OFBIZ-11975:


 Summary: products loaded from xml file don't show in category
 Key: OFBIZ-11975
 URL: https://issues.apache.org/jira/browse/OFBIZ-11975
 Project: OFBiz
  Issue Type: Bug
  Components: datamodel
Affects Versions: Trunk
Reporter: Alex Bodnaru


i loaded the attached xml (in admin).

the product (wg3-) shows in the product search in admin.

it also shows in keyword search in ecomseo.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11974) Create button should be removed from create screen of various features

2020-08-22 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11974:
---
Summary: Create button should be removed from create screen of various 
features  (was: Create button should be remove from create screen)

> Create button should be removed from create screen of various features
> --
>
> Key: OFBIZ-11974
> URL: https://issues.apache.org/jira/browse/OFBIZ-11974
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Akash Jain
>Priority: Minor
>
> There are various create screens where create button showing, like, Create 
> new quote button showing on new quote screen reported in OFBIZ-11405.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11974) Create button should be removed from create screen of various features

2020-08-22 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-11974:
--

Assignee: Akash Jain

> Create button should be removed from create screen of various features
> --
>
> Key: OFBIZ-11974
> URL: https://issues.apache.org/jira/browse/OFBIZ-11974
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>
> There are various create screens where create button showing, like, Create 
> new quote button showing on new quote screen reported in OFBIZ-11405.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11974) Create button should be remove from create screen

2020-08-22 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-11974:
--

 Summary: Create button should be remove from create screen
 Key: OFBIZ-11974
 URL: https://issues.apache.org/jira/browse/OFBIZ-11974
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Reporter: Akash Jain


There are various create screens where create button showing, like, Create new 
quote button showing on new quote screen reported in OFBIZ-11405.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11405) Create new quote button should be removed from new quote screen

2020-08-22 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182408#comment-17182408
 ] 

Akash Jain commented on OFBIZ-11405:


There are various create screens where create button available, will create 
separate ticket for all create screens. Attached patch to fix this issue on 
Create Quote screen.

> Create new quote button should be removed from new quote screen
> ---
>
> Key: OFBIZ-11405
> URL: https://issues.apache.org/jira/browse/OFBIZ-11405
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-11405.patch
>
>
> While reviewing OFBIZ-11221 noticed another issue.
> Steps to replicate the issue : 
>  * Go to ordermgr  application.
>  * On find quote screen clicks upon Create New Quote button.
>  * System will navigate you to to create new quote screen.
>  * On create new quote screen you will see Create New Quote button. 
> It make sense on other menu/tab items of quote screen (as user can create new 
> quote anytime from other quote screens) but it should not make any sense over 
> create new quote screen.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11405) Create new quote button should be removed from new quote screen

2020-08-22 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11405:
---
Attachment: OFBIZ-11405.patch

> Create new quote button should be removed from new quote screen
> ---
>
> Key: OFBIZ-11405
> URL: https://issues.apache.org/jira/browse/OFBIZ-11405
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-11405.patch
>
>
> While reviewing OFBIZ-11221 noticed another issue.
> Steps to replicate the issue : 
>  * Go to ordermgr  application.
>  * On find quote screen clicks upon Create New Quote button.
>  * System will navigate you to to create new quote screen.
>  * On create new quote screen you will see Create New Quote button. 
> It make sense on other menu/tab items of quote screen (as user can create new 
> quote anytime from other quote screens) but it should not make any sense over 
> create new quote screen.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11973) enclose productsummary list in div.row to better use the screen

2020-08-22 Thread Alex Bodnaru (Jira)
Alex Bodnaru created OFBIZ-11973:


 Summary: enclose productsummary list in div.row to better use the 
screen
 Key: OFBIZ-11973
 URL: https://issues.apache.org/jira/browse/OFBIZ-11973
 Project: OFBiz
  Issue Type: Bug
Affects Versions: Trunk, Release Branch 17.12
Reporter: Alex Bodnaru
 Attachments: missing-div-row.patch

as the summary says.

showcase: the list of products from a keyword search shows products in narrow 
summary format, but not side by side.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #231: WIP: Implemented: Added support for defining nested attributes.(OFBIZ-11902)

2020-08-22 Thread GitBox


sonarcloud[bot] commented on pull request #231:
URL: https://github.com/apache/ofbiz-framework/pull/231#issuecomment-678649798


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_ofbiz-framework=231=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=231=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=231)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=231=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=231=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182403#comment-17182403
 ] 

Alex Bodnaru commented on OFBIZ-11955:
--

i reloaded the data and changed the price, since the price difference is 
important for another part of the same bug.

 

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] girishvasmatkar opened a new pull request #231: WIP: Implemented: Added support for defining nested attributes.(OFBIZ-11902)

2020-08-22 Thread GitBox


girishvasmatkar opened a new pull request #231:
URL: https://github.com/apache/ofbiz-framework/pull/231


   Implemented: Added support for defining nested attributes.
   (OFBIZ- 11902)
   
   Explanation:
   - Current implementation reads nested attributes but does not perform 
validation for the child attributes.
   - Primarily useful and essential for OpenAPI definitions and GraphQL schema.
   
   Thanks:
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-22 Thread Alex Bodnaru (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Bodnaru updated OFBIZ-11955:
-
Attachment: variantinfojs-data.xml

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-22 Thread Alex Bodnaru (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Bodnaru updated OFBIZ-11955:
-
Attachment: (was: variantinfojs-data.xml)

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2020-08-22 Thread GitBox


sonarcloud[bot] commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-678647972


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_ofbiz-framework=230=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=230)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=230=new_duplicated_lines_density=list)
 [4.2% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=230=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182395#comment-17182395
 ] 

Alex Bodnaru commented on OFBIZ-11955:
--

indeed, i can't see wg3-* in the category listing, but i see them both in 
the search

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11845) Getting error while generating ApprovedProductRequirementsReport PDF

2020-08-22 Thread Chandan Khandelwal (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal updated OFBIZ-11845:
---
Attachment: OFBIZ-11845.patch

> Getting error while generating ApprovedProductRequirementsReport PDF
> 
>
> Key: OFBIZ-11845
> URL: https://issues.apache.org/jira/browse/OFBIZ-11845
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Chandan Khandelwal
>Priority: Major
> Attachments: OFBIZ-11845.patch, Screenshot from 2020-06-27 
> 19-27-18.png
>
>
> Reference URL:
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/ApprovedProductRequirementsReport]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11845) Getting error while generating ApprovedProductRequirementsReport PDF

2020-08-22 Thread Chandan Khandelwal (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182391#comment-17182391
 ] 

Chandan Khandelwal commented on OFBIZ-11845:


Added an initial patch but it need good round of testing to avoid regression. 

> Getting error while generating ApprovedProductRequirementsReport PDF
> 
>
> Key: OFBIZ-11845
> URL: https://issues.apache.org/jira/browse/OFBIZ-11845
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Chandan Khandelwal
>Priority: Major
> Attachments: Screenshot from 2020-06-27 19-27-18.png
>
>
> Reference URL:
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/ApprovedProductRequirementsReport]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies

2020-08-22 Thread Aditya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-11960:
--
Sprint: OFBiz Community Day (Aug 2020)

> Use NPM with gradle to get external JS dependencies
> ---
>
> Key: OFBIZ-11960
> URL: https://issues.apache.org/jira/browse/OFBIZ-11960
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
>
> 1. Add 
> [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: 
> Gradle plugin for integrating NodeJS in your build
> 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in 
> webapp
> 3. Use available tasks to install dependencies
> [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks]
>  
> [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin]
> 4. Use the downloaded JS files in node_modules, updating the current path of 
> the JS files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

2020-08-22 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182390#comment-17182390
 ] 

Suraj Khurana edited comment on OFBIZ-11944 at 8/22/20, 2:15 PM:
-

I was about to review this, though it is committed pretty soon (less than 2 
hours), will review it later.


was (Author: suraj.khurana):
I was about to reviw this, though it is committed pretty soon (less than 2 
hours), will review it later.

> Replace .size() == 0 with isEmpty() in Java files
> -
>
> Key: OFBIZ-11944
> URL: https://issues.apache.org/jira/browse/OFBIZ-11944
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Priya Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch
>
>
> For a better understanding of how it may be helpful, this article puts some 
> light
> https://rb.gy/mhpuzg



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

2020-08-22 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182390#comment-17182390
 ] 

Suraj Khurana commented on OFBIZ-11944:
---

I was about to reviw this, though it is committed pretty soon (less than 2 
hours), will review it later.

> Replace .size() == 0 with isEmpty() in Java files
> -
>
> Key: OFBIZ-11944
> URL: https://issues.apache.org/jira/browse/OFBIZ-11944
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Priya Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch
>
>
> For a better understanding of how it may be helpful, this article puts some 
> light
> https://rb.gy/mhpuzg



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] adityasharma7 opened a new pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2020-08-22 Thread GitBox


adityasharma7 opened a new pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230


   
   1. Added gradle-node-plugin Gradle plugin for integrating NodeJS in your 
build (https://github.com/node-gradle/gradle-node-plugin)
   2. Created NPM package.json with JS dependencies in webapp based upon 
https://docs.npmjs.com/files/package.json
   3. Added license information in package.json based upon SPDX License List 
(https://spdx.org/licenses/) as supported by NPM 
(https://docs.npmjs.com/files/package.json#license)
   4. Added package-lock.json as suggested in NPM documentation 
(https://github.com/npm/cli/blob/release-6.14.7/docs/content/configuring-npm/package-lock-json.md#description)
   5. Added jQuery and jQuery Migrate using NPM and used it throughout
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11933) Checkbox not selected after searching with multiple options checked in form widget

2020-08-22 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11933.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

All sub task closed. Done for all find screens.

> Checkbox not selected after searching with multiple options checked in form 
> widget
> --
>
> Key: OFBIZ-11933
> URL: https://issues.apache.org/jira/browse/OFBIZ-11933
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11933.patch
>
>
> No checkbox appears as selected when we click on find button even though the 
> order is filtered, this is happening on all the screens where form-widget is 
> used, as  tag has an attribute all-check for checkboxes which is set 
> to false.
> If the value of the checkbox is false then whenever the page loads, it 
> unchecks all checkboxes and displays no checkbox as selected, but filters the 
> result correctly.
> If we remove this attribute from the check element then it is working fine in 
> case of single checkbox selection, but if multiple checkboxes are selected 
> then again it shows all checkboxes as unchecked.
> This happens on all the find forms which are implemented using form-widgets.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11933) Checkbox not selected after searching with multiple options checked in form widget

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182388#comment-17182388
 ] 

ASF subversion and git services commented on OFBIZ-11933:
-

Commit 8da5da9a28e7ced1441b75ec983ed9f5b508c7a5 in ofbiz-framework's branch 
refs/heads/trunk from Akash Jain
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8da5da9 ]

Improved: Status ID checkbox for Find InventoryItems screen (OFBIZ-11933)


> Checkbox not selected after searching with multiple options checked in form 
> widget
> --
>
> Key: OFBIZ-11933
> URL: https://issues.apache.org/jira/browse/OFBIZ-11933
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11933.patch
>
>
> No checkbox appears as selected when we click on find button even though the 
> order is filtered, this is happening on all the screens where form-widget is 
> used, as  tag has an attribute all-check for checkboxes which is set 
> to false.
> If the value of the checkbox is false then whenever the page loads, it 
> unchecks all checkboxes and displays no checkbox as selected, but filters the 
> result correctly.
> If we remove this attribute from the check element then it is working fine in 
> case of single checkbox selection, but if multiple checkboxes are selected 
> then again it shows all checkboxes as unchecked.
> This happens on all the find forms which are implemented using form-widgets.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10536:

Sprint: OFBiz Community Day (Aug 2020)

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, Release Branch 17.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
> Attachments: Image 002.png, OFBIZ-10536.patch, 
> OFBIZ-10536_16-11.patch, Screenshot from 2018-12-24 17-37-07.png
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

2020-08-22 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182387#comment-17182387
 ] 

Jacques Le Roux commented on OFBIZ-11944:
-

BTW, I completely reviewed plugins and was reviewing framework, found no issues 
(y)

> Replace .size() == 0 with isEmpty() in Java files
> -
>
> Key: OFBIZ-11944
> URL: https://issues.apache.org/jira/browse/OFBIZ-11944
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Priya Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch
>
>
> For a better understanding of how it may be helpful, this article puts some 
> light
> https://rb.gy/mhpuzg



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11966) problem loading files by path

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182386#comment-17182386
 ] 

Alex Bodnaru commented on OFBIZ-11966:
--

sure, I'll do it 

> problem loading files by path
> -
>
> Key: OFBIZ-11966
> URL: https://issues.apache.org/jira/browse/OFBIZ-11966
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>
> the data load failed with the following message:
> Could not create task ':ofbiz --load-data 
> file=../trunk-patches/variantinfojs-data.patch'.
> > The task name 'ofbiz --load-data 
> > file=../trunk-patches/variantinfojs-data.patch' must not contain any of the 
> > following characters: [/, \, :, <, >, ", ?, *, |].
> it seemed to work with a local file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11933) Checkbox not selected after searching with multiple options checked in form widget

2020-08-22 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182384#comment-17182384
 ] 

Akash Jain commented on OFBIZ-11933:


Verified for all find screens; missing only on Inventory Items screen, attached 
patch for the same.

> Checkbox not selected after searching with multiple options checked in form 
> widget
> --
>
> Key: OFBIZ-11933
> URL: https://issues.apache.org/jira/browse/OFBIZ-11933
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11933.patch
>
>
> No checkbox appears as selected when we click on find button even though the 
> order is filtered, this is happening on all the screens where form-widget is 
> used, as  tag has an attribute all-check for checkboxes which is set 
> to false.
> If the value of the checkbox is false then whenever the page loads, it 
> unchecks all checkboxes and displays no checkbox as selected, but filters the 
> result correctly.
> If we remove this attribute from the check element then it is working fine in 
> case of single checkbox selection, but if multiple checkboxes are selected 
> then again it shows all checkboxes as unchecked.
> This happens on all the find forms which are implemented using form-widgets.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182383#comment-17182383
 ] 

Alex Bodnaru edited comment on OFBIZ-11955 at 8/22/20, 1:53 PM:


hello [~jleroux]

i have imported the xml again in the admin gui, with 73 entries saved, just 
like yours.

in ecomseo, in the search catalog box, there is a catalog field.

i searched for wg3-, and got 2 results, in summary format: wg- and 
wg3-.

could you please try too?

now go to the second product in the list, and select an alternative uom, 
including click on the option.


was (Author: alexbodn):
hello [~jleroux]

i have imported the xml again in the admin gui, with 73 entries saved, just 
like yours.

in ecomseo, in the search catalog box, there is a catalog field.

i searched for wg3-, and got 2 results, in summary format: wg- and 
wg3-.

could you please try too?

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182383#comment-17182383
 ] 

Alex Bodnaru commented on OFBIZ-11955:
--

hello [~jleroux]

i have imported the xml again in the admin gui, with 73 entries saved, just 
like yours.

in ecomseo, in the search catalog box, there is a catalog field.

i searched for wg3-, and got 2 results, in summary format: wg- and 
wg3-.

could you please try too?

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

2020-08-22 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182382#comment-17182382
 ] 

Pawan Verma commented on OFBIZ-11944:
-

Thanks, [~priya.sharma.9362] and [~jleroux]!

> Replace .size() == 0 with isEmpty() in Java files
> -
>
> Key: OFBIZ-11944
> URL: https://issues.apache.org/jira/browse/OFBIZ-11944
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Priya Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch
>
>
> For a better understanding of how it may be helpful, this article puts some 
> light
> https://rb.gy/mhpuzg



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

2020-08-22 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11944.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Replace .size() == 0 with isEmpty() in Java files
> -
>
> Key: OFBIZ-11944
> URL: https://issues.apache.org/jira/browse/OFBIZ-11944
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Priya Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch
>
>
> For a better understanding of how it may be helpful, this article puts some 
> light
> https://rb.gy/mhpuzg



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182380#comment-17182380
 ] 

ASF subversion and git services commented on OFBIZ-11944:
-

Commit 5545b13b137fa30afe1edad97e7af0944f7dd4d8 in ofbiz-plugins's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=5545b13 ]

Improved: Replace .size() == 0 with isEmpty() in Java files(OFBIZ-11944)

Thanks, priya for the report and patch and jacques for the review.


> Replace .size() == 0 with isEmpty() in Java files
> -
>
> Key: OFBIZ-11944
> URL: https://issues.apache.org/jira/browse/OFBIZ-11944
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Priya Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch
>
>
> For a better understanding of how it may be helpful, this article puts some 
> light
> https://rb.gy/mhpuzg



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182379#comment-17182379
 ] 

ASF subversion and git services commented on OFBIZ-11944:
-

Commit 6cb67c1a404957c26c964c0f6e6579360abaf4d9 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6cb67c1 ]

Improved: Replace .size() == 0 with isEmpty() in Java files(OFBIZ-11944)

Thanks, priya for the report and patch and jacques for the review.


> Replace .size() == 0 with isEmpty() in Java files
> -
>
> Key: OFBIZ-11944
> URL: https://issues.apache.org/jira/browse/OFBIZ-11944
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Priya Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch
>
>
> For a better understanding of how it may be helpful, this article puts some 
> light
> https://rb.gy/mhpuzg



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

2020-08-22 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11944:
---

Assignee: Pawan Verma  (was: Priya Sharma)

> Replace .size() == 0 with isEmpty() in Java files
> -
>
> Key: OFBIZ-11944
> URL: https://issues.apache.org/jira/browse/OFBIZ-11944
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Priya Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch
>
>
> For a better understanding of how it may be helpful, this article puts some 
> light
> https://rb.gy/mhpuzg



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-22 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11955:

Sprint: OFBiz Community Day (Aug 2020)

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap

2020-08-22 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11971:
--
Sprint: OFBiz Community Day (Aug 2020)

> Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
> ---
>
> Key: OFBIZ-11971
> URL: https://issues.apache.org/jira/browse/OFBIZ-11971
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-11971.patch
>
>
> 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId  in ReturnItemTypeMap data 
> and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type 
> data does not exists.
> The following data exist for miscellaneous charges in data files:
>  returnAdjustmentTypeId="RET_MISC_ADJ"/>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files

2020-08-22 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-11944:

Sprint: OFBiz Community Day (Aug 2020)

> Replace .size() == 0 with isEmpty() in Java files
> -
>
> Key: OFBIZ-11944
> URL: https://issues.apache.org/jira/browse/OFBIZ-11944
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Priya Sharma
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch
>
>
> For a better understanding of how it may be helpful, this article puts some 
> light
> https://rb.gy/mhpuzg



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-22 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182378#comment-17182378
 ] 

Jacques Le Roux commented on OFBIZ-11686:
-

# Navigate in few screen (I only used 
https://localhost:8443/catalog/control/login?USERNAME=admin=ofbiz=Y
 and https://localhost:8443/ecomseo)
# Open the ofbiz.log
# count the number of "getJs (Domain:https://localhost)] Request" in this log. 

Even in a fresh install (cleanAll loadAll), you get 32 "getJs 
(Domain:https://localhost)] Request". I think we should hide that.


> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11380) Convert createCommEventContentAssoc service from mini-lang to groovy DSL

2020-08-22 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11380.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Convert createCommEventContentAssoc service from mini-lang to groovy DSL
> 
>
> Key: OFBIZ-11380
> URL: https://issues.apache.org/jira/browse/OFBIZ-11380
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11380.patch, OFBIZ-11380.patch
>
>
> Convert createCommEventContentAssoc service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9350) Deprecate Mini Lang

2020-08-22 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-9350:
---
Sprint: OFBiz Community Day (Feb 2020), OFBiz Community Day (May 2020), 
OFBiz Community Day (Aug 2020)  (was: OFBiz Community Day (Feb 2020), OFBiz 
Community Day (May 2020))

> Deprecate Mini Lang
> ---
>
> Key: OFBIZ-9350
> URL: https://issues.apache.org/jira/browse/OFBIZ-9350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: documentation, refactoring
>
> According to the proposal thread in [1] we decided to deprecate mini lang.
> This issue tracks the next steps proposed in the aformentioned thread, namely:
> 1. create a Wiki page for the documentation and description of the migration 
> process and how mini lang will be replaced.
> 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2]
> 3. put deprecation tags in the corresponding code
> 4. kindly ask contributors with open patches written in mini lang to replace 
> them by Groovy code [3]
> 5. start an initiative to replace existing mini lang code with Groovy code 
> where applicable. This needs some more planning and discussion which parts 
> we'll like to replace with Groovy code and which parts will better be 
> replaced by some kind of DSL. A good starting point can be [4][5][6].
> [1] 
> [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E]
>  [2] 
> [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference]
>  [3] does anyone know a way to batch comment Jira issues like it is possible 
> in Redmine?
>  [4] 
> [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic]
>  [5] 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide]
>  [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11380) Convert createCommEventContentAssoc service from mini-lang to groovy DSL

2020-08-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182377#comment-17182377
 ] 

ASF subversion and git services commented on OFBIZ-11380:
-

Commit 271e3c9bd56ead7f5f1db8bc47b8ac8b32a6d852 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=271e3c9 ]

Improved: Convert createCommEventContentAssoc service from mini-lang to groovy 
DSL(OFBIZ-11380)

Thanks, Devanshu for report, rushikesh and priya for the patch and Suraj and 
jacques for the review.


> Convert createCommEventContentAssoc service from mini-lang to groovy DSL
> 
>
> Key: OFBIZ-11380
> URL: https://issues.apache.org/jira/browse/OFBIZ-11380
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11380.patch, OFBIZ-11380.patch
>
>
> Convert createCommEventContentAssoc service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails

2020-08-22 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182376#comment-17182376
 ] 

Jacques Le Roux commented on OFBIZ-6638:


Oops, wrong copied link above :/ 

Anyawy, seems that [~lalit.dashora] has a clue at OFBIZ-8376

> TrialBalance PDF export fails
> -
>
> Key: OFBIZ-6638
> URL: https://issues.apache.org/jira/browse/OFBIZ-6638
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png
>
>
> # Get to 
> http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company
> #pick a "Custom Time Period Id" (default works also)
> #Submit
> Then the CSV export works but not the PDF, this in trunk demo.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182373#comment-17182373
 ] 

Alex Bodnaru edited comment on OFBIZ-11955 at 8/22/20, 1:39 PM:


the problem occurs *only* when there are more than one products in the same 
page with the uom selection option.

that's why i have duplicated wg-, to have 2 displayed side by side in the 
same category.


was (Author: alexbodn):
the problem occurs when there are more than one products in the same page with 
the uom selection option.

that's why i have duplicated wg-, to have 2 displayed side by side in the 
same category.

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-22 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182375#comment-17182375
 ] 

Alex Bodnaru commented on OFBIZ-11955:
--

could you please duplicate wg- to wg2- in admin, 

and make sure the alternative package relationship is between the wg2- and 
wg2--bx2 and between wg2- and wg2--bx4?

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11380) Convert createCommEventContentAssoc service from mini-lang to groovy DSL

2020-08-22 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11380:
---

Assignee: Pawan Verma  (was: Rushikesh Mawal)

> Convert createCommEventContentAssoc service from mini-lang to groovy DSL
> 
>
> Key: OFBIZ-11380
> URL: https://issues.apache.org/jira/browse/OFBIZ-11380
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11380.patch, OFBIZ-11380.patch
>
>
> Convert createCommEventContentAssoc service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   3   >