[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190950#comment-17190950 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] please apply the -undo patch. then apply the -final patch. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11955: - Attachment: variantinfojs-undo.patch > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190748#comment-17190748 ] Alex Bodnaru commented on OFBIZ-11955: -- ok, [~jleroux] , i will revert this, pull, then re-apply to fix conflicts. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.
[ https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190742#comment-17190742 ] Pawan Verma commented on OFBIZ-11995: - +1, looks good to me. Agree, we should use services instead of fetching data from entities. > Define schema for RESTFul resources mapping. > > > Key: OFBIZ-11995 > URL: https://issues.apache.org/jira/browse/OFBIZ-11995 > Project: OFBiz > Issue Type: Sub-task > Components: ALL PLUGINS >Affects Versions: Trunk >Reporter: Girish Vasmatkar >Assignee: Girish Vasmatkar >Priority: Major > Attachments: rest-api.xsd > > > As a developer, I need to have the ability to define REST resources using XML > DSL allowing to plug in OFBiz services to the resources that can serve the > HTTP requests. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190699#comment-17190699
]
Jacques Le Roux commented on OFBIZ-11955:
-
Sorry again Alex, the patch does not completely apply:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git status
On branch trunk
Your branch is up to date with 'origin/trunk'.
C:\projectsASF\Git\ofbiz-framework>git apply variantinfojs-final.patch
variantinfojs-final.patch:367: trailing whitespace.
});
variantinfojs-final.patch:443: trailing whitespace.
variantinfojs-final.patch:479: trailing whitespace.
});
error: patch failed:
applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy:102
error:
applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy:
patch does not apply
error: patch failed:
applications/order/groovyScripts/entry/catalog/ProductDetail.groovy:106
error: applications/order/groovyScripts/entry/catalog/ProductDetail.groovy:
patch does not apply
error: patch failed:
applications/order/groovyScripts/entry/catalog/ProductSummary.groovy:97
error: applications/order/groovyScripts/entry/catalog/ProductSummary.groovy:
patch does not apply
error: patch failed:
applications/order/template/entry/catalog/ProductDetail.ftl:265
error: applications/order/template/entry/catalog/ProductDetail.ftl: patch does
not apply
error: patch failed:
applications/order/template/entry/catalog/ProductSummary.ftl:49
error: applications/order/template/entry/catalog/ProductSummary.ftl: patch does
not apply
error: patch failed:
applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl:17
error: applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl:
patch does not apply
error: applications/order/template/entry/catalog/ProductVariantJS.ftl: already
exists in working directory
{noformat}
> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png,
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png,
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png,
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch,
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml,
> variantinfojs-final.patch
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple
> forms, one for each product: whether detailed or in summary. thus, they
> should be marked by names and classes, not by ids, that are unique in the
> entire document.
> the bug did not manifest in demo data, since only one product has alternative
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11921. - Fix Version/s: Upcoming Branch Resolution: Implemented Last pair of patches fixed around *1250* checkstyle issues. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190591#comment-17190591 ] ASF subversion and git services commented on OFBIZ-11921: - Commit 26ddcc0c8e2189b0adb421fa4669b934b372407d in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=26ddcc0 ] Improved: Corrected line is longer than 150 characters checkstyle issues in plugins component. (OFBIZ-11921) Also fixed some other extra space and naming related checkstyle issues observed. Thanks Jacques for review. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190585#comment-17190585 ] ASF subversion and git services commented on OFBIZ-11921: - Commit bc5e945dedd25fbd7ffa8f45c1c05c9cf131fdd1 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bc5e945 ] Improved: Corrected line is longer than 150 characters checkstyle issues in framework component. (OFBIZ-11921) Also fixed some other extra space and naming related checkstyle issues observed. Thanks Jacques for review. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190583#comment-17190583 ] ASF subversion and git services commented on OFBIZ-11921: - Commit 5f021ce06b3ae593fb06f627a60168be01702c6a in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5f021ce ] Improved: Corrected line is longer than 150 characters checkstyle issues in applications component. (OFBIZ-11921) Also fixed some other extra space and naming related checkstyle issues observed. Thanks Jacques for review. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
