[jira] [Commented] (OFBIZ-9361) Newsletter can be subscribed with same email address multiple times
[ https://issues.apache.org/jira/browse/OFBIZ-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1763#comment-1763 ] Aditya Sharma commented on OFBIZ-9361: -- Hello [~Giulio_MpStyle], Didn't get a chance to look into the details, but after reading your inputs, the given solution makes sense. > Newsletter can be subscribed with same email address multiple times > --- > > Key: OFBIZ-9361 > URL: https://issues.apache.org/jira/browse/OFBIZ-9361 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 16.11, Trunk, Upcoming Branch >Reporter: Aditya Sharma >Assignee: Giulio Speri >Priority: Trivial > Attachments: OFBIZ-9361.patch > > > Steps to regenerate: > 1. Go to Ecommerce component > (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main) > 2. In Sign Up For Contact List section from the left panel, select > contactList for Newsletter. > 3. Fill out the email address and Click on Subscribe button. > Try subscribing with the same email address for the newsletter. Email is > again added to Newsletter subscription list even if it is already subscribed > for it. Email address with pending and accepted status can be again added to > the list with pending status. > Multiple entries are created in ContactListParty entity for the same > preferredContactMechId. > At Service level, it should check if already an entry in pending or accepted > status exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9361) Newsletter can be subscribed with same email address multiple times
[
https://issues.apache.org/jira/browse/OFBIZ-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619504#comment-17619504
]
Aditya Sharma commented on OFBIZ-9361:
--
Thanks for looking into it [~Giulio_MpStyle]!
{quote}If I sign up many times, the service will add more and more records to
the ContactListParty entity: shouldn't we delete or at least expire the older
active (pending) records before adding new ones ?
{quote}
Makes sense. I worked on it long back, but based upon information you shared,
we could delete the old pending request as it might no longer be applicable. I
can't think of any use case as of now for keeping that data.
> Newsletter can be subscribed with same email address multiple times
> ---
>
> Key: OFBIZ-9361
> URL: https://issues.apache.org/jira/browse/OFBIZ-9361
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Release Branch 16.11, Trunk, Upcoming Branch
>Reporter: Aditya Sharma
>Assignee: Giulio Speri
>Priority: Trivial
> Attachments: OFBIZ-9361.patch
>
>
> Steps to regenerate:
> 1. Go to Ecommerce component
> (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main)
> 2. In Sign Up For Contact List section from the left panel, select
> contactList for Newsletter.
> 3. Fill out the email address and Click on Subscribe button.
> Try subscribing with the same email address for the newsletter. Email is
> again added to Newsletter subscription list even if it is already subscribed
> for it. Email address with pending and accepted status can be again added to
> the list with pending status.
> Multiple entries are created in ContactListParty entity for the same
> preferredContactMechId.
> At Service level, it should check if already an entry in pending or accepted
> status exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-9361) Newsletter can be subscribed with same email address multiple times
[ https://issues.apache.org/jira/browse/OFBIZ-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618202#comment-17618202 ] Aditya Sharma commented on OFBIZ-9361: -- Sure [~Giulio_MpStyle] > Newsletter can be subscribed with same email address multiple times > --- > > Key: OFBIZ-9361 > URL: https://issues.apache.org/jira/browse/OFBIZ-9361 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 16.11, Trunk, Upcoming Branch >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Attachments: OFBIZ-9361.patch > > > Steps to regenerate: > 1. Go to Ecommerce component > (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main) > 2. In Sign Up For Contact List section from the left panel, select > contactList for Newsletter. > 3. Fill out the email address and Click on Subscribe button. > Try subscribing with the same email address for the newsletter. Email is > again added to Newsletter subscription list even if it is already subscribed > for it. Email address with pending and accepted status can be again added to > the list with pending status. > Multiple entries are created in ContactListParty entity for the same > preferredContactMechId. > At Service level, it should check if already an entry in pending or accepted > status exists. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12682) Upgrade inputmask to 5.0.7 and use it via npm dependency
[ https://issues.apache.org/jira/browse/OFBIZ-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-12682. - Fix Version/s: Upcoming Branch Resolution: Done > Upgrade inputmask to 5.0.7 and use it via npm dependency > > > Key: OFBIZ-12682 > URL: https://issues.apache.org/jira/browse/OFBIZ-12682 > Project: OFBiz > Issue Type: Task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Labels: Hacktoberfest > Fix For: Upcoming Branch > > Attachments: Screenshot from 2022-10-14 14-12-03.png > > > We are using 5.0.6 Beta 11 last adding with OFBIZ-11964 > https://issues.apache.org/jira/browse/OFBIZ-11964 > [https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=90e43c9] > https://github.com/apache/ofbiz-framework/blob/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/inputmask/jquery.inputmask-5.0.6-beta.11.js > Moving to npm version will ease out the upgrades > [https://www.npmjs.com/package/inputmask] > https://github.com/RobinHerbots/Inputmask -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12682) Upgrade inputmask to 5.0.7 and use it via npm dependency
[ https://issues.apache.org/jira/browse/OFBIZ-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617575#comment-17617575 ] Aditya Sharma commented on OFBIZ-12682: --- Thanks [~priyaljain]! This has been merged into trunk > Upgrade inputmask to 5.0.7 and use it via npm dependency > > > Key: OFBIZ-12682 > URL: https://issues.apache.org/jira/browse/OFBIZ-12682 > Project: OFBiz > Issue Type: Task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Labels: Hacktoberfest > Attachments: Screenshot from 2022-10-14 14-12-03.png > > > We are using 5.0.6 Beta 11 last adding with OFBIZ-11964 > https://issues.apache.org/jira/browse/OFBIZ-11964 > [https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=90e43c9] > https://github.com/apache/ofbiz-framework/blob/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/inputmask/jquery.inputmask-5.0.6-beta.11.js > Moving to npm version will ease out the upgrades > [https://www.npmjs.com/package/inputmask] > https://github.com/RobinHerbots/Inputmask -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12704) Upgrade select2 and use it via npm
[ https://issues.apache.org/jira/browse/OFBIZ-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-12704: -- Labels: Hacktoberfest (was: ) > Upgrade select2 and use it via npm > -- > > Key: OFBIZ-12704 > URL: https://issues.apache.org/jira/browse/OFBIZ-12704 > Project: OFBiz > Issue Type: Task >Reporter: Aditya Sharma >Priority: Trivial > Labels: Hacktoberfest > > https://github.com/apache/ofbiz-framework/tree/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/select2 > [https://www.npmjs.com/package/select2] > https://github.com/select2/select2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12704) Upgrade select2 and use it via npm
Aditya Sharma created OFBIZ-12704: - Summary: Upgrade select2 and use it via npm Key: OFBIZ-12704 URL: https://issues.apache.org/jira/browse/OFBIZ-12704 Project: OFBiz Issue Type: Task Reporter: Aditya Sharma https://github.com/apache/ofbiz-framework/tree/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/select2 [https://www.npmjs.com/package/select2] https://github.com/select2/select2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12703) Upgrade Featherlight to 1.7.14 and use it via npm
[ https://issues.apache.org/jira/browse/OFBIZ-12703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-12703: -- Labels: Hacktoberfest (was: ) > Upgrade Featherlight to 1.7.14 and use it via npm > - > > Key: OFBIZ-12703 > URL: https://issues.apache.org/jira/browse/OFBIZ-12703 > Project: OFBiz > Issue Type: Task >Reporter: Aditya Sharma >Priority: Trivial > Labels: Hacktoberfest > > https://github.com/apache/ofbiz-framework/tree/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/featherlight > [https://www.npmjs.com/package/featherlight] > https://github.com/noelboss/featherlight -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12703) Upgrade Featherlight to 1.7.14 and use it via npm
Aditya Sharma created OFBIZ-12703: - Summary: Upgrade Featherlight to 1.7.14 and use it via npm Key: OFBIZ-12703 URL: https://issues.apache.org/jira/browse/OFBIZ-12703 Project: OFBiz Issue Type: Task Reporter: Aditya Sharma https://github.com/apache/ofbiz-framework/tree/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/featherlight [https://www.npmjs.com/package/featherlight] https://github.com/noelboss/featherlight -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12701) Use datejs via npm dependency
[ https://issues.apache.org/jira/browse/OFBIZ-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-12701: -- Labels: Hacktoberfest (was: ) > Use datejs via npm dependency > - > > Key: OFBIZ-12701 > URL: https://issues.apache.org/jira/browse/OFBIZ-12701 > Project: OFBiz > Issue Type: Task >Reporter: Aditya Sharma >Priority: Trivial > Labels: Hacktoberfest > > [https://github.com/apache/ofbiz-framework/tree/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/datejs] > https://github.com/datejs/Datejs > Possible packages: > DateJS: Evolved. An updated, bug fixed, and actively maintained continuation > of DateJS > https://github.com/abritinthebay/datejs > [https://www.npmjs.com/package/datejs] > date.js > https://www.npmjs.com/package/date.js?activeTab=readme > https://github.com/MatthewMueller/date > We could initially go with the most compatible one and then plan migration to > libraries like Luxon > https://moment.github.io/luxon/#/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12701) Use datejs via npm dependency
Aditya Sharma created OFBIZ-12701: - Summary: Use datejs via npm dependency Key: OFBIZ-12701 URL: https://issues.apache.org/jira/browse/OFBIZ-12701 Project: OFBiz Issue Type: Task Reporter: Aditya Sharma [https://github.com/apache/ofbiz-framework/tree/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/datejs] https://github.com/datejs/Datejs Possible packages: DateJS: Evolved. An updated, bug fixed, and actively maintained continuation of DateJS https://github.com/abritinthebay/datejs [https://www.npmjs.com/package/datejs] date.js https://www.npmjs.com/package/date.js?activeTab=readme https://github.com/MatthewMueller/date We could initially go with the most compatible one and then plan migration to libraries like Luxon https://moment.github.io/luxon/#/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-10754) Refactor getServiceResult() method in miscAjaxFunctions.js
[ https://issues.apache.org/jira/browse/OFBIZ-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10754: -- Labels: Hacktoberfest (was: ) > Refactor getServiceResult() method in miscAjaxFunctions.js > -- > > Key: OFBIZ-10754 > URL: https://issues.apache.org/jira/browse/OFBIZ-10754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Labels: Hacktoberfest > > In the current implementation, the following method makes all calls > synchronously. In sync calls script stops and waits for the server to send > back a reply before continuing. The method should provision overriding async > value when required. The synchronous call should be used only when required. > The method should either allow callbacks to be passed or should return > promise to perform dependent tasks. > Refer: > [https://stackoverflow.com/questions/20209097/what-is-the-difference-between-asyncfalse-and-asynctrue-in-jquery-ajax] > [https://www.thoughtco.com/use-asynchronous-or-synchronous-ajax-2037228] > [https://www.aspsnippets.com/Articles/Difference-between-Synchronous-Sync-and-Asynchronous-Async-Request-Call-in-AJAX.aspx] > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-11987) Upgrade jstree js plugin to latest
[ https://issues.apache.org/jira/browse/OFBIZ-11987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11987: -- Labels: Hacktoberfest (was: ) > Upgrade jstree js plugin to latest > -- > > Key: OFBIZ-11987 > URL: https://issues.apache.org/jira/browse/OFBIZ-11987 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk, Upcoming Branch >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Labels: Hacktoberfest > > Upgrade Jstree library to its latest version i.e. 3.3.10 > [https://www.jstree.com/] > [https://github.com/vakata/jstree] > [https://www.npmjs.com/package/jstree] > Current version used is jsTree - v3.0.0-beta3 - 2014-01-16 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-11988) Replace jquery.cookie with js-cookie
[ https://issues.apache.org/jira/browse/OFBIZ-11988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11988: -- Labels: Hacktoberfest (was: ) > Replace jquery.cookie with js-cookie > > > Key: OFBIZ-11988 > URL: https://issues.apache.org/jira/browse/OFBIZ-11988 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk, Upcoming Branch >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Labels: Hacktoberfest > > [https://github.com/carhartl/jquery-cookie] > jquery-cookie is no longer maintained,and superseded by JS Cookie: > > [https://github.com/js-cookie/js-cookie] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12682) Upgrade inputmask to 5.0.7 and use it via npm dependency
[ https://issues.apache.org/jira/browse/OFBIZ-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-12682: -- Labels: Hacktoberfest (was: ) > Upgrade inputmask to 5.0.7 and use it via npm dependency > > > Key: OFBIZ-12682 > URL: https://issues.apache.org/jira/browse/OFBIZ-12682 > Project: OFBiz > Issue Type: Task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Labels: Hacktoberfest > > We are using 5.0.6 Beta 11 last adding with OFBIZ-11964 > https://issues.apache.org/jira/browse/OFBIZ-11964 > [https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=90e43c9] > https://github.com/apache/ofbiz-framework/blob/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/inputmask/jquery.inputmask-5.0.6-beta.11.js > Moving to npm version will ease out the upgrades > [https://www.npmjs.com/package/inputmask] > https://github.com/RobinHerbots/Inputmask -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-10782) Replace jQuery-Timepicker-Addon with flatpickr.js
[ https://issues.apache.org/jira/browse/OFBIZ-10782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10782: -- Labels: Hacktoberfest (was: ) > Replace jQuery-Timepicker-Addon with flatpickr.js > - > > Key: OFBIZ-10782 > URL: https://issues.apache.org/jira/browse/OFBIZ-10782 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk, Upcoming Branch >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Labels: Hacktoberfest > > [jQuery-Timepicker-Addon|https://github.com/trentrichardson/jQuery-Timepicker-Addon] > seems to be a dead end now. Refer > [#955|https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/955] > As suggested in > [#955|https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/955]. > [Flatpickr|https://github.com/flatpickr/flatpickr] seems a better > proposition. MIT license with a community of 158 contributors and 123 > releases. A lightweight, powerful javascript datetimepicker with no > dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12682) Upgrade inputmask to 5.0.7 and use it via npm dependency
Aditya Sharma created OFBIZ-12682: - Summary: Upgrade inputmask to 5.0.7 and use it via npm dependency Key: OFBIZ-12682 URL: https://issues.apache.org/jira/browse/OFBIZ-12682 Project: OFBiz Issue Type: Task Components: ALL APPLICATIONS Affects Versions: Upcoming Branch Reporter: Aditya Sharma Assignee: Aditya Sharma We are using 5.0.6 Beta 11 last adding with OFBIZ-11964 https://issues.apache.org/jira/browse/OFBIZ-11964 [https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=90e43c9] https://github.com/apache/ofbiz-framework/blob/trunk/themes/common-theme/webapp/common-theme/js/jquery/plugins/inputmask/jquery.inputmask-5.0.6-beta.11.js Moving to npm version will ease out the upgrades [https://www.npmjs.com/package/inputmask] https://github.com/RobinHerbots/Inputmask -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12640) Add support to pass distinct to performFindList service
Aditya Sharma created OFBIZ-12640: - Summary: Add support to pass distinct to performFindList service Key: OFBIZ-12640 URL: https://issues.apache.org/jira/browse/OFBIZ-12640 Project: OFBiz Issue Type: Task Affects Versions: Upcoming Branch Reporter: Aditya Sharma Assignee: Aditya Sharma [https://github.com/apache/ofbiz-framework/blob/trunk/framework/common/servicedef/services.xml#L257] performFindList uses performFind internally and passes context, so only attribute needs to be added to service definition https://github.com/apache/ofbiz-framework/blob/trunk/framework/common/src/main/java/org/apache/ofbiz/common/FindServices.java#L478 https://github.com/apache/ofbiz-framework/blob/trunk/framework/common/servicedef/services.xml#L244 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (OFBIZ-12613) StackOverflowError and database blocking when exporting "performFind" via rest-api
[
https://issues.apache.org/jira/browse/OFBIZ-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma closed OFBIZ-12613.
-
Resolution: Not A Problem
Considering it solved the problem. Closing the issue.
> StackOverflowError and database blocking when exporting "performFind" via
> rest-api
> --
>
> Key: OFBIZ-12613
> URL: https://issues.apache.org/jira/browse/OFBIZ-12613
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Sixty One
>Priority: Minor
> Attachments: image-2022-05-11-15-18-56-803.png,
> image-2022-05-11-15-23-54-422.png, image-2022-05-11-15-29-11-425.png,
> rest-expose-performFind-no-iterator.patch, rest-expose-performFind.patch
>
>
> I am running on latest trunk but cannot select trunk within "Affects
> Version/s" here.
>
> I experimented with OFBiz findServices (performFind, performFindList,
> performFindItem) via rest-api. I observed two things that I'd like to
> understand as I do not know if those are really bugs and such things are of
> interest for the OFBiz community in general.
> h1. performFind leads to StackOverflowError
> I exposed the performFindService within "rest-expose-performFind.patch".
> Requesting a search via rest-api:
> {code:java}
> POST /rest/services/performFind HTTP/1.1
> Host: localhost:8443
> Authorization: Bearer ...
> Content-Type: application/json
> {
> "entityName": "Facility",
> "inputFields": {
> "facilityName": "a",
> "facilityName_ic": "Y",
> "facilityName_op": "contains"
> }
> } {code}
> Leads to an infinite loop that "finishes" with an StackOverFlowError:
> !image-2022-05-11-15-18-56-803.png!
> I reckon that this is due to the fact that the performFind-service retunrs an
> Iterator instead of a List.
> h1. performFind without ListIterator leaves database connections open
> What I tried next is to get rid of that ListIterator within
> rest-expose-performFind-no-iterator.patch
> !image-2022-05-11-15-23-54-422.png!
> It "works" (at least I can work with the response) but somehow the
> performFind-service leaves the database connections open until they finally
> block after ~250 requests. Afterwards there's no chance to send new requests
> or login to OFBiz without a restart.
> {code:java}
> 2022-05-11 15:24:47,140 |jsse-nio-8443-exec-7 |ServiceDispatcher
> |T| Sync service [rest-api/prepareFind] finished in [1] milliseconds
> 2022-05-11 15:24:47,141 |jsse-nio-8443-exec-7 |ServiceDispatcher
> |T| Sync service [rest-api/executeFind] finished in [1] milliseconds
> 2022-05-11 15:24:47,141 |jsse-nio-8443-exec-7 |ServiceDispatcher
> |T| Sync service [rest-api/performFind] finished in [2] milliseconds
> 2022-05-11 15:24:48,038 |jsse-nio-8443-exec-1 |ServiceRequestFilter
> |I| Service request is going to get validated!
> 2022-05-11 15:24:48,040 |jsse-nio-8443-exec-1 |ServiceDispatcher
> |T| Sync service [rest-api/executeFind] finished in [1] milliseconds
> 2022-05-11 15:24:48,040 |jsse-nio-8443-exec-1 |ServiceDispatcher
> |T| Sync service [rest-api/performFind] finished in [1] milliseconds
> 2022-05-11 15:26:48,826 |sse-nio-8443-exec-10 |GenericDelegator
> |E| Failure in findByCondition operation for entity [UserLogin]:
> org.apache.ofbiz.entity.GenericDataSourceException: Unable to establish a
> connection with the database. (Unable to acquire a new connection from the
> pool). Rolling back transaction.
> org.apache.ofbiz.entity.GenericDataSourceException: Unable to establish a
> connection with the database. (Unable to acquire a new connection from the
> pool)
> at
> org.apache.ofbiz.entity.jdbc.SQLProcessor.getConnection(SQLProcessor.java:287)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:372)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java:806)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.datasource.GenericHelperDAO.findListIteratorByCondition(GenericHelperDAO.java:157)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1600)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1648)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.util.EntityQuery.query(EntityQuery.java:468)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.util.EntityQuery.queryList(EntityQuery.java:397)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.util.EntityQuery.queryOne(EntityQuery.java:441)
> ~[main/:?]
> at
> org.apache.ofbiz.ws.rs.security.auth.APIAuthFilter.extractUserLoginFromJwtClaim(APIAuthFilter.java:143)
> ~[main/:?]
>
[jira] [Commented] (OFBIZ-12613) StackOverflowError and database blocking when exporting "performFind" via rest-api
[
https://issues.apache.org/jira/browse/OFBIZ-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536028#comment-17536028
]
Aditya Sharma commented on OFBIZ-12613:
---
Hello [~sixtyone]
I think you should use the performFindList service which closes the
EntityListIterator.
https://github.com/apache/ofbiz-framework/blob/trunk/framework/common/src/main/java/org/apache/ofbiz/common/FindServices.java#L466
> StackOverflowError and database blocking when exporting "performFind" via
> rest-api
> --
>
> Key: OFBIZ-12613
> URL: https://issues.apache.org/jira/browse/OFBIZ-12613
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Sixty One
>Priority: Minor
> Attachments: image-2022-05-11-15-18-56-803.png,
> image-2022-05-11-15-23-54-422.png, image-2022-05-11-15-29-11-425.png,
> rest-expose-performFind-no-iterator.patch, rest-expose-performFind.patch
>
>
> I am running on latest trunk but cannot select trunk within "Affects
> Version/s" here.
>
> I experimented with OFBiz findServices (performFind, performFindList,
> performFindItem) via rest-api. I observed two things that I'd like to
> understand as I do not know if those are really bugs and such things are of
> interest for the OFBiz community in general.
> h1. performFind leads to StackOverflowError
> I exposed the performFindService within "rest-expose-performFind.patch".
> Requesting a search via rest-api:
> {code:java}
> POST /rest/services/performFind HTTP/1.1
> Host: localhost:8443
> Authorization: Bearer ...
> Content-Type: application/json
> {
> "entityName": "Facility",
> "inputFields": {
> "facilityName": "a",
> "facilityName_ic": "Y",
> "facilityName_op": "contains"
> }
> } {code}
> Leads to an infinite loop that "finishes" with an StackOverFlowError:
> !image-2022-05-11-15-18-56-803.png!
> I reckon that this is due to the fact that the performFind-service retunrs an
> Iterator instead of a List.
> h1. performFind without ListIterator leaves database connections open
> What I tried next is to get rid of that ListIterator within
> rest-expose-performFind-no-iterator.patch
> !image-2022-05-11-15-23-54-422.png!
> It "works" (at least I can work with the response) but somehow the
> performFind-service leaves the database connections open until they finally
> block after ~250 requests. Afterwards there's no chance to send new requests
> or login to OFBiz without a restart.
> {code:java}
> 2022-05-11 15:24:47,140 |jsse-nio-8443-exec-7 |ServiceDispatcher
> |T| Sync service [rest-api/prepareFind] finished in [1] milliseconds
> 2022-05-11 15:24:47,141 |jsse-nio-8443-exec-7 |ServiceDispatcher
> |T| Sync service [rest-api/executeFind] finished in [1] milliseconds
> 2022-05-11 15:24:47,141 |jsse-nio-8443-exec-7 |ServiceDispatcher
> |T| Sync service [rest-api/performFind] finished in [2] milliseconds
> 2022-05-11 15:24:48,038 |jsse-nio-8443-exec-1 |ServiceRequestFilter
> |I| Service request is going to get validated!
> 2022-05-11 15:24:48,040 |jsse-nio-8443-exec-1 |ServiceDispatcher
> |T| Sync service [rest-api/executeFind] finished in [1] milliseconds
> 2022-05-11 15:24:48,040 |jsse-nio-8443-exec-1 |ServiceDispatcher
> |T| Sync service [rest-api/performFind] finished in [1] milliseconds
> 2022-05-11 15:26:48,826 |sse-nio-8443-exec-10 |GenericDelegator
> |E| Failure in findByCondition operation for entity [UserLogin]:
> org.apache.ofbiz.entity.GenericDataSourceException: Unable to establish a
> connection with the database. (Unable to acquire a new connection from the
> pool). Rolling back transaction.
> org.apache.ofbiz.entity.GenericDataSourceException: Unable to establish a
> connection with the database. (Unable to acquire a new connection from the
> pool)
> at
> org.apache.ofbiz.entity.jdbc.SQLProcessor.getConnection(SQLProcessor.java:287)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:372)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java:806)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.datasource.GenericHelperDAO.findListIteratorByCondition(GenericHelperDAO.java:157)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1600)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1648)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.util.EntityQuery.query(EntityQuery.java:468)
> ~[main/:?]
> at
> org.apache.ofbiz.entity.util.EntityQuery.queryList(EntityQuery.java:397)
> ~[main/:?]
> at
>
[jira] [Comment Edited] (OFBIZ-9976) Introduce require.js to organise JavaScript files
[ https://issues.apache.org/jira/browse/OFBIZ-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480017#comment-17480017 ] Aditya Sharma edited comment on OFBIZ-9976 at 1/21/22, 11:49 AM: - Hello Jacques, Thanks for sharing those links! I was thinking Gulp or Grunt for minifying initially, further with webpack we could use it as module bundler[1][2][3][4] something similar to what we want to achieve with require js except here it will be taken care while bundling the code with advance tree shaking[5]. Also, we do not need a separate gradle plugin the current plugin supports it [6] [7] 1. [https://webpack.js.org/concepts/] 2. [https://irian.to/blogs/bundle-your-javascript-code-from-scratch/] 3. [https://lihautan.com/what-is-module-bundler-and-how-does-it-work/] 4. [https://medium.com/@gimenete/how-javascript-bundlers-work-1fc0d0caf2da] 5. [https://webpack.js.org/guides/tree-shaking/] 6. [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] 7. [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages] was (Author: aditya.sharma): Hello Jacques, Thanks for sharing those links! I was thinking Gulp and Grunt for minifying initially, further with webpack we could use it as module bundler[1][2][3][4] something similar to what we want to achieve with require js except here it will be taken care while bundling the code with advance tree shaking[5]. Also, we do not need a separate gradle plugin the current plugin supports it [6] [7] 1. [https://webpack.js.org/concepts/] 2. [https://irian.to/blogs/bundle-your-javascript-code-from-scratch/] 3. [https://lihautan.com/what-is-module-bundler-and-how-does-it-work/] 4. [https://medium.com/@gimenete/how-javascript-bundlers-work-1fc0d0caf2da] 5. [https://webpack.js.org/guides/tree-shaking/] 6. [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] 7. [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages] > Introduce require.js to organise JavaScript files > - > > Key: OFBIZ-9976 > URL: https://issues.apache.org/jira/browse/OFBIZ-9976 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk, Upcoming Branch >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > > As suggested by [~jacques.le.roux] in > http://markmail.org/message/eec2anlwdt4azaac and > http://ofbiz.markmail.org/thread/ti54omjdt4fy662m and as per the discussion > with [~amardeepsj] in OFBIZ-7758, introduce require.js http://requirejs.org/ > to load javascript files. > Require.js offers a lot of benefits some of them includes: > * Asynchronous module loading. > * Well-structured code > * Creating and re-using modules without polluting the global namespace > * Explicit defining of dependencies between module -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-9976) Introduce require.js to organise JavaScript files
[ https://issues.apache.org/jira/browse/OFBIZ-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480017#comment-17480017 ] Aditya Sharma commented on OFBIZ-9976: -- Hello Jacques, Thanks for sharing those links! I was thinking Gulp and Grunt for minifying initially, further with webpack we could use it as module bundler[1][2][3][4] something similar to what we want to achieve with require js except here it will be taken care while bundling the code with advance tree shaking[5]. Also, we do not need a separate gradle plugin the current plugin supports it [6] [7] 1. [https://webpack.js.org/concepts/] 2. [https://irian.to/blogs/bundle-your-javascript-code-from-scratch/] 3. [https://lihautan.com/what-is-module-bundler-and-how-does-it-work/] 4. [https://medium.com/@gimenete/how-javascript-bundlers-work-1fc0d0caf2da] 5. [https://webpack.js.org/guides/tree-shaking/] 6. [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] 7. [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages] > Introduce require.js to organise JavaScript files > - > > Key: OFBIZ-9976 > URL: https://issues.apache.org/jira/browse/OFBIZ-9976 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk, Upcoming Branch >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > > As suggested by [~jacques.le.roux] in > http://markmail.org/message/eec2anlwdt4azaac and > http://ofbiz.markmail.org/thread/ti54omjdt4fy662m and as per the discussion > with [~amardeepsj] in OFBIZ-7758, introduce require.js http://requirejs.org/ > to load javascript files. > Require.js offers a lot of benefits some of them includes: > * Asynchronous module loading. > * Well-structured code > * Creating and re-using modules without polluting the global namespace > * Explicit defining of dependencies between module -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (OFBIZ-10093) Replace ELRTE plugin with Trumbowyg
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10093. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks [~bjugl] for your contribution and to everyone who shared their valuable inputs! > Replace ELRTE plugin with Trumbowyg > --- > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > Fix For: Upcoming Branch > > > As there is no support for elrte since elrte-1.3 > [https://github.com/Studio-42/elRTE] it is to be replaced with some other > good editor & we found Quill Js editor as quite suitable: > * 139 releases > * Good community support of 101 contributors > * Licence - BSD 3-Clause "New" or "Revised" License > Links for reference: > [https://quilljs.com/] > [https://github.com/quilljs/quill] > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (OFBIZ-10093) Replace ELRTE plugin with Trumbowyg
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-10093: - Assignee: Aditya Sharma (was: Benjamin Jugl) > Replace ELRTE plugin with Trumbowyg > --- > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > [https://github.com/Studio-42/elRTE] it is to be replaced with some other > good editor & we found Quill Js editor as quite suitable: > * 139 releases > * Good community support of 101 contributors > * Licence - BSD 3-Clause "New" or "Revised" License > Links for reference: > [https://quilljs.com/] > [https://github.com/quilljs/quill] > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-9976) Introduce require.js to organise JavaScript files
[ https://issues.apache.org/jira/browse/OFBIZ-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468380#comment-17468380 ] Aditya Sharma commented on OFBIZ-9976: -- I think we should stick to npm at max. I would suggest to initially use tools like gulp[1], grunt[2] for minifying JS & CSS and further use webpack[3]. As I find some time, I will try to pick them up. 1. [https://gulpjs.com/] 2. [https://gruntjs.com/] 3. [https://webpack.js.org/] > Introduce require.js to organise JavaScript files > - > > Key: OFBIZ-9976 > URL: https://issues.apache.org/jira/browse/OFBIZ-9976 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > > As suggested by [~jacques.le.roux] in > http://markmail.org/message/eec2anlwdt4azaac and > http://ofbiz.markmail.org/thread/ti54omjdt4fy662m and as per the discussion > with [~amardeepsj] in OFBIZ-7758, introduce require.js http://requirejs.org/ > to load javascript files. > Require.js offers a lot of benefits some of them includes: > * Asynchronous module loading. > * Well-structured code > * Creating and re-using modules without polluting the global namespace > * Explicit defining of dependencies between module -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with Quill.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386295#comment-17386295 ] Aditya Sharma commented on OFBIZ-10093: --- Hi [~bjugl] Thanks for jumping in for help! As I may not be available to handle this sooner, It would be good if you could take care of it. Thanks in advance! > Replace ELRTE plugin with Quill. > > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > [https://github.com/Studio-42/elRTE] it is to be replaced with some other > good editor & we found Quill Js editor as quite suitable: > * 139 releases > * Good community support of 101 contributors > * Licence - BSD 3-Clause "New" or "Revised" License > Links for reference: > [https://quilljs.com/] > [https://github.com/quilljs/quill] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346971#comment-17346971 ] Aditya Sharma commented on OFBIZ-11960: --- Hi [~mbrohl], As explained in the description of plugin, it integrates Node.js based system with Gradle. Here is how we can benefit from it: 1. We have access to all the JavaScript packages that can be installed with npm or Yarn, so instead of adding JavaScript to OFBiz we can simply add a entry in [package.json|https://github.com/apache/ofbiz-framework/pull/230/files#diff-d99da454386376715bb13bf5c5c7f778a1aaefdc396c665e732d8287039e8cc2R7] and files will downloaded to user's system from the registry like the Gradle dependencies. 2. Minor updates can be handled implicity by node when specified with [tilde|https://github.com/npm/node-semver#tilde-ranges-123-12-1] range or [caret|https://github.com/npm/node-semver#caret-ranges-123-025-004] range for version. For major updates, we just have to change the version and use npm install. No explicit download thus making upgrade process quite easy. 3. Currently, we use non minified versions of JavaScript & CSS files with custom code. We can use task runner libraries like Gulp or Grunt to automate minification. Similarly, we can merge all the JavaScript libraries into single file and use. This will give optimised performance to page load as JS file size will be reduced along with reduction to no of resource calls (in a way reducing the server load too). 4. With time JavaScript has evolved, introduction to ES6 (ECMAScript 2015) brought great capabilites to write complex modularized code. We would be able to add code as per the new standards that can be easily transpiled with available npm utilities. With this MR, I have added JQuery, jQuery browser and JQuery validate library only. Further I plan to implement logic to minify and merge the files. > Use NPM with gradle to get external JS dependencies > --- > > Key: OFBIZ-11960 > URL: https://issues.apache.org/jira/browse/OFBIZ-11960 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > > As discussed > [here|https://lists.apache.org/thread.html/re16808eb5b1084f822c74194d23ca073dea4f4df443184f40f5f58c6%40%3Cdev.ofbiz.apache.org%3E], > use gradle-js-plugin to ease out managing the JavaScript dependencies. The > Gradle plugin allows us to automatically download the js libraries to the > user's system like the Gradle dependencies, so we no longer need to include > them with the package. It opens door to all the packages and modules > available at [npm registry|https://www.npmjs.com/]. Also, it can be clubbed > with Grunt or Gulp implementing tasks to minify external JS and CSS files > with the custom ones, see > [here|https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages]. > 1. Add > [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: > Gradle plugin for integrating NodeJS in your build > 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in > webapp > 3. Use available tasks to install dependencies > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] > > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] > 4. Use the downloaded JS files in node_modules, updating the current path of > the JS files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346195#comment-17346195 ] Aditya Sharma commented on OFBIZ-11960: --- Thanks [~pierresmits] for the heads up. I have updated the description. > Use NPM with gradle to get external JS dependencies > --- > > Key: OFBIZ-11960 > URL: https://issues.apache.org/jira/browse/OFBIZ-11960 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > > As discussed > [here|https://lists.apache.org/thread.html/re16808eb5b1084f822c74194d23ca073dea4f4df443184f40f5f58c6%40%3Cdev.ofbiz.apache.org%3E], > use gradle-js-plugin to ease out managing the JavaScript dependencies. The > Gradle plugin allows us to automatically download the js libraries to the > user's system like the Gradle dependencies, so we no longer need to include > them with the package. It opens door to all the packages and modules > available at [npm registry|https://www.npmjs.com/]. Also, it can be clubbed > with Grunt or Gulp implementing tasks to minify external JS and CSS files > with the custom ones, see > [here|https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages]. > 1. Add > [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: > Gradle plugin for integrating NodeJS in your build > 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in > webapp > 3. Use available tasks to install dependencies > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] > > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] > 4. Use the downloaded JS files in node_modules, updating the current path of > the JS files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11960: -- Description: As discussed [here|https://lists.apache.org/thread.html/re16808eb5b1084f822c74194d23ca073dea4f4df443184f40f5f58c6%40%3Cdev.ofbiz.apache.org%3E], use gradle-js-plugin to ease out managing the JavaScript dependencies. The Gradle plugin allows us to automatically download the js libraries to the user's system like the Gradle dependencies, so we no longer need to include them with the package. It opens door to all the packages and modules available at [npm registry|https://www.npmjs.com/]. Also, it can be clubbed with Grunt or Gulp implementing tasks to minify external JS and CSS files with the custom ones, see [here|https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages]. 1. Add [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: Gradle plugin for integrating NodeJS in your build 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in webapp 3. Use available tasks to install dependencies [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] 4. Use the downloaded JS files in node_modules, updating the current path of the JS files. was: 1. Add [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: Gradle plugin for integrating NodeJS in your build 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in webapp 3. Use available tasks to install dependencies [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] 4. Use the downloaded JS files in node_modules, updating the current path of the JS files. > Use NPM with gradle to get external JS dependencies > --- > > Key: OFBIZ-11960 > URL: https://issues.apache.org/jira/browse/OFBIZ-11960 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > > As discussed > [here|https://lists.apache.org/thread.html/re16808eb5b1084f822c74194d23ca073dea4f4df443184f40f5f58c6%40%3Cdev.ofbiz.apache.org%3E], > use gradle-js-plugin to ease out managing the JavaScript dependencies. The > Gradle plugin allows us to automatically download the js libraries to the > user's system like the Gradle dependencies, so we no longer need to include > them with the package. It opens door to all the packages and modules > available at [npm registry|https://www.npmjs.com/]. Also, it can be clubbed > with Grunt or Gulp implementing tasks to minify external JS and CSS files > with the custom ones, see > [here|https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages]. > 1. Add > [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: > Gradle plugin for integrating NodeJS in your build > 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in > webapp > 3. Use available tasks to install dependencies > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] > > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] > 4. Use the downloaded JS files in node_modules, updating the current path of > the JS files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343114#comment-17343114 ] Aditya Sharma commented on OFBIZ-10113: --- Renaming the variable names is still remaining, I tried to find and replace them but it was breaking it. I will soon try again > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01 > > Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, > OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reopened OFBIZ-10113: --- Assignee: Aditya Sharma (was: Jacques Le Roux) > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01 > > Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, > OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12230) accounting/control/CostCenters fails
[ https://issues.apache.org/jira/browse/OFBIZ-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-12230: - Assignee: (was: Aditya Sharma) > accounting/control/CostCenters fails > > > Key: OFBIZ-12230 > URL: https://issues.apache.org/jira/browse/OFBIZ-12230 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > > While trying to reproduce OFBIZ-12226 I got this: > 2021-04-28 11:44:56,489 |jsse-nio-8443-exec-7 |ServiceDispatcher > |E| Incoming context (in runSync : getGlAcctgAndAmountPercentage) does not > match expected requirements > org.apache.ofbiz.service.ServiceValidationException: The following required > parameter is missing: [getGlAcctgAndAmountPercentage.organizationPartyId] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12230) accounting/control/CostCenters fails
[ https://issues.apache.org/jira/browse/OFBIZ-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-12230: - Assignee: Aditya Sharma > accounting/control/CostCenters fails > > > Key: OFBIZ-12230 > URL: https://issues.apache.org/jira/browse/OFBIZ-12230 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Aditya Sharma >Priority: Major > > While trying to reproduce OFBIZ-12226 I got this: > 2021-04-28 11:44:56,489 |jsse-nio-8443-exec-7 |ServiceDispatcher > |E| Incoming context (in runSync : getGlAcctgAndAmountPercentage) does not > match expected requirements > org.apache.ofbiz.service.ServiceValidationException: The following required > parameter is missing: [getGlAcctgAndAmountPercentage.organizationPartyId] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311265#comment-17311265 ] Aditya Sharma commented on OFBIZ-11684: --- Makes sense Jacques :) > Form to add an employee position doesn't function properly when invoked from > Humanres tree > -- > > Key: OFBIZ-11684 > URL: https://issues.apache.org/jira/browse/OFBIZ-11684 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Aditya Sharma >Priority: Major > Labels: usability > Fix For: 18.12.01 > > > Selecting Add Employee Position or Add Person from the context menu opens the > corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311149#comment-17311149 ] Aditya Sharma commented on OFBIZ-11684: --- I also cherry-picked to 17.12 as I have seen some other commits too. It seems 17.12.07 label is missing in Fix versions > Form to add an employee position doesn't function properly when invoked from > Humanres tree > -- > > Key: OFBIZ-11684 > URL: https://issues.apache.org/jira/browse/OFBIZ-11684 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Aditya Sharma >Priority: Major > Labels: usability > Fix For: 18.12.01 > > > Selecting Add Employee Position or Add Person from the context menu opens the > corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-11684. - Fix Version/s: 18.12.01 Resolution: Fixed > Form to add an employee position doesn't function properly when invoked from > Humanres tree > -- > > Key: OFBIZ-11684 > URL: https://issues.apache.org/jira/browse/OFBIZ-11684 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Aditya Sharma >Priority: Major > Labels: usability > Fix For: 18.12.01 > > > Selecting Add Employee Position or Add Person from the context menu opens the > corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311146#comment-17311146 ] Aditya Sharma commented on OFBIZ-11684: --- This is done. Thanks [~jleroux] for the review! I will create a separate Jira for the error. > Form to add an employee position doesn't function properly when invoked from > Humanres tree > -- > > Key: OFBIZ-11684 > URL: https://issues.apache.org/jira/browse/OFBIZ-11684 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Aditya Sharma >Priority: Major > Labels: usability > > Selecting Add Employee Position or Add Person from the context menu opens the > corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree
[
https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309966#comment-17309966
]
Aditya Sharma commented on OFBIZ-11684:
---
Hi [~jleroux] , all,
The issue doesn't exist on trunk due to work by James where we moved the logic
to load datejs library in specific macros when needed
https://github.com/apache/ofbiz-framework/commit/bc5b0d595cab9103e9ec0c03234cec81c80f47c3
In releases 18.12 and 17.12, we include them through GlobalAction decorator.
The issue with the current approach is the current page and the
EditEmplPosition page both have GlobalActions decorator all the js files in
GlobalActions are loaded twice. Either we should Ajaxify a section of the page
or we should navigate the user to the EditEmplPosition page.
Here is my solution:
[https://github.com/apache/ofbiz-framework/pull/289/files]
Replaced logic to Ajaxify the response from EditEmplPosition with navigating
the user to EditEmplPosition page.
When we are getting the entire page and updating it into the DOM, it would be
better if we navigate the user to the page.
Other than that, I noticed that all the labels are not internationalized and
there is an error for Add Internal Organisation on console:
{code:java}
jquery-3.5.1.min.js:2 Uncaught Error: cannot call methods on dialog prior to
initialization; attempted to call method 'open'
at Function.error (jquery-3.5.1.min.js:2)
at HTMLDivElement. (jquery-ui-1.12.1.min.js:6)
at Function.each (jquery-3.5.1.min.js:2)
at s.fn.init.each (jquery-3.5.1.min.js:2)
at s.fn.init.t.fn. [as dialog] (jquery-ui-1.12.1.min.js:6)
at :2:18
at b (jquery-3.5.1.min.js:2)
at Pe (jquery-3.5.1.min.js:2)
at s.fn.init.append (jquery-3.5.1.min.js:2)
at s.fn.init. (jquery-3.5.1.min.js:2){code}
> Form to add an employee position doesn't function properly when invoked from
> Humanres tree
> --
>
> Key: OFBIZ-11684
> URL: https://issues.apache.org/jira/browse/OFBIZ-11684
> Project: OFBiz
> Issue Type: Bug
> Components: humanres
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12,
> 17.12.03, Trunk, 17.12.04
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: usability
>
> Selecting Add Employee Position or Add Person from the context menu opens the
> corresponding edit forms with calendar lookup fields.
> The calendar form does no open when the lookup icon is clicked.
> Expected calendar to open on click.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304885#comment-17304885 ] Aditya Sharma commented on OFBIZ-11684: --- Hi [~jleroux], Let me give it a try > Form to add an employee position doesn't function properly when invoked from > Humanres tree > -- > > Key: OFBIZ-11684 > URL: https://issues.apache.org/jira/browse/OFBIZ-11684 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: usability > > Selecting Add Employee Position or Add Person from the context menu opens the > corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304795#comment-17304795 ] Aditya Sharma commented on OFBIZ-10113: --- Hi [~jleroux], Thanks for the heads up. >> Do you think it's normal? Should we not remove it now? That's strange I think we should remove it if there are no other references for it. Give me some time I will check and take care of it >> Also maybe we could replace the "asmselect" string everywhere in code though >> that's not really a problem. Yes. I think we can rename it with some generic name to be used with any plugin irrespective of plugin name. Let me handle that too. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.01 > > Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, > OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10729) Add subscribe email on website mailing list page
[ https://issues.apache.org/jira/browse/OFBIZ-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259781#comment-17259781 ] Aditya Sharma edited comment on OFBIZ-10729 at 1/6/21, 3:04 PM: Merged the changes. Reflecting at [https://ofbiz.apache.org/mailing-lists.html] Thanks [~deepak] , [~jleroux] and [~swapnilmmane]! Closing for now. was (Author: aditya.sharma): Merged the changes. Reflecting at https://ofbiz.apache.org/mailing-lists.html Thanks [~jleroux] and [~swapnilmmane]! Closing for now. > Add subscribe email on website mailing list page > > > Key: OFBIZ-10729 > URL: https://issues.apache.org/jira/browse/OFBIZ-10729 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Deepak Dixit >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-10729-Alt.patch, OFBIZ-10729.patch, > OFBIZ-10729.patch, SubscribeMailingList-Mid.png, > SubscribeMailingList-Top-Alt.png, SubscribeMailingList-bottom.png, > SubscribeMailingList.png, SubscribeMailingList.png, > SubscribeMailingListAlt-1.png, SubscribeMailingListAlt-2.png, > image-2021-01-05-20-12-26-274.png > > > As per current implementation, we have a link of lists.apache.org for > subscribing mailing list, > When a user visited lists.apache.org website it has the option to subscribe, > this tries to open email client, if no email client setup on a user machine, > so its difficult to subscribe. > We can add an alternate option as well along with lists.apache.org link. A > simple text with subscribe email address. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10729) Add subscribe email on website mailing list page
[ https://issues.apache.org/jira/browse/OFBIZ-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259781#comment-17259781 ] Aditya Sharma edited comment on OFBIZ-10729 at 1/6/21, 3:04 PM: Merged the changes. Reflecting at [https://ofbiz.apache.org/mailing-lists.html] Thanks [~deepak] , [~jleroux] and [~swapnilmmane]! Closing now. was (Author: aditya.sharma): Merged the changes. Reflecting at [https://ofbiz.apache.org/mailing-lists.html] Thanks [~deepak] , [~jleroux] and [~swapnilmmane]! Closing for now. > Add subscribe email on website mailing list page > > > Key: OFBIZ-10729 > URL: https://issues.apache.org/jira/browse/OFBIZ-10729 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Deepak Dixit >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-10729-Alt.patch, OFBIZ-10729.patch, > OFBIZ-10729.patch, SubscribeMailingList-Mid.png, > SubscribeMailingList-Top-Alt.png, SubscribeMailingList-bottom.png, > SubscribeMailingList.png, SubscribeMailingList.png, > SubscribeMailingListAlt-1.png, SubscribeMailingListAlt-2.png, > image-2021-01-05-20-12-26-274.png > > > As per current implementation, we have a link of lists.apache.org for > subscribing mailing list, > When a user visited lists.apache.org website it has the option to subscribe, > this tries to open email client, if no email client setup on a user machine, > so its difficult to subscribe. > We can add an alternate option as well along with lists.apache.org link. A > simple text with subscribe email address. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10729) Add subscribe email on website mailing list page
[ https://issues.apache.org/jira/browse/OFBIZ-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10729. - Resolution: Done > Add subscribe email on website mailing list page > > > Key: OFBIZ-10729 > URL: https://issues.apache.org/jira/browse/OFBIZ-10729 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Deepak Dixit >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-10729-Alt.patch, OFBIZ-10729.patch, > OFBIZ-10729.patch, SubscribeMailingList-Mid.png, > SubscribeMailingList-Top-Alt.png, SubscribeMailingList-bottom.png, > SubscribeMailingList.png, SubscribeMailingList.png, > SubscribeMailingListAlt-1.png, SubscribeMailingListAlt-2.png, > image-2021-01-05-20-12-26-274.png > > > As per current implementation, we have a link of lists.apache.org for > subscribing mailing list, > When a user visited lists.apache.org website it has the option to subscribe, > this tries to open email client, if no email client setup on a user machine, > so its difficult to subscribe. > We can add an alternate option as well along with lists.apache.org link. A > simple text with subscribe email address. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10729) Add subscribe email on website mailing list page
[ https://issues.apache.org/jira/browse/OFBIZ-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259781#comment-17259781 ] Aditya Sharma commented on OFBIZ-10729: --- Merged the changes. Reflecting at https://ofbiz.apache.org/mailing-lists.html Thanks [~jleroux] and [~swapnilmmane]! Closing for now. > Add subscribe email on website mailing list page > > > Key: OFBIZ-10729 > URL: https://issues.apache.org/jira/browse/OFBIZ-10729 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Deepak Dixit >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-10729-Alt.patch, OFBIZ-10729.patch, > OFBIZ-10729.patch, SubscribeMailingList-Mid.png, > SubscribeMailingList-Top-Alt.png, SubscribeMailingList-bottom.png, > SubscribeMailingList.png, SubscribeMailingList.png, > SubscribeMailingListAlt-1.png, SubscribeMailingListAlt-2.png, > image-2021-01-05-20-12-26-274.png > > > As per current implementation, we have a link of lists.apache.org for > subscribing mailing list, > When a user visited lists.apache.org website it has the option to subscribe, > this tries to open email client, if no email client setup on a user machine, > so its difficult to subscribe. > We can add an alternate option as well along with lists.apache.org link. A > simple text with subscribe email address. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258970#comment-17258970 ] Aditya Sharma commented on OFBIZ-11333: --- Hi [~mbrohl], I think we can close it > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10729) Add subscribe email on website mailing list page
[ https://issues.apache.org/jira/browse/OFBIZ-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258968#comment-17258968 ] Aditya Sharma commented on OFBIZ-10729: --- Created a PR for it and added an image for the preview. I kept the instructions for subscription as it is because the original ones were consistent with the unsubscribe ones. I will soon merge. > Add subscribe email on website mailing list page > > > Key: OFBIZ-10729 > URL: https://issues.apache.org/jira/browse/OFBIZ-10729 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Deepak Dixit >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-10729-Alt.patch, OFBIZ-10729.patch, > OFBIZ-10729.patch, SubscribeMailingList-Mid.png, > SubscribeMailingList-Top-Alt.png, SubscribeMailingList-bottom.png, > SubscribeMailingList.png, SubscribeMailingList.png, > SubscribeMailingListAlt-1.png, SubscribeMailingListAlt-2.png, > image-2021-01-05-20-12-26-274.png > > > As per current implementation, we have a link of lists.apache.org for > subscribing mailing list, > When a user visited lists.apache.org website it has the option to subscribe, > this tries to open email client, if no email client setup on a user machine, > so its difficult to subscribe. > We can add an alternate option as well along with lists.apache.org link. A > simple text with subscribe email address. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10729) Add subscribe email on website mailing list page
[ https://issues.apache.org/jira/browse/OFBIZ-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10729: -- Attachment: image-2021-01-05-20-12-26-274.png > Add subscribe email on website mailing list page > > > Key: OFBIZ-10729 > URL: https://issues.apache.org/jira/browse/OFBIZ-10729 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Deepak Dixit >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-10729-Alt.patch, OFBIZ-10729.patch, > OFBIZ-10729.patch, SubscribeMailingList-Mid.png, > SubscribeMailingList-Top-Alt.png, SubscribeMailingList-bottom.png, > SubscribeMailingList.png, SubscribeMailingList.png, > SubscribeMailingListAlt-1.png, SubscribeMailingListAlt-2.png, > image-2021-01-05-20-12-26-274.png > > > As per current implementation, we have a link of lists.apache.org for > subscribing mailing list, > When a user visited lists.apache.org website it has the option to subscribe, > this tries to open email client, if no email client setup on a user machine, > so its difficult to subscribe. > We can add an alternate option as well along with lists.apache.org link. A > simple text with subscribe email address. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12117) Having an issue to install
[ https://issues.apache.org/jira/browse/OFBIZ-12117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258146#comment-17258146 ] Aditya Sharma commented on OFBIZ-12117: --- Thanks [~r.subhaw] for reporting! This is already fixed at OFBIZ-12100. > Having an issue to install > -- > > Key: OFBIZ-12117 > URL: https://issues.apache.org/jira/browse/OFBIZ-12117 > Project: OFBiz > Issue Type: Bug > Components: setup >Affects Versions: 17.12.04 >Reporter: Rossi Subhaw >Priority: Major > Attachments: Capture.JPG, Capture2.JPG, Capture3.JPG > > > Disclaimer: I'm very new to this so please be kind. > So i've been following the installation instructions properly (i hope) > however i seem be getting this issue when i run the gradlew cleanAll loadAll > command. > FAILURE: Build failed with an exception. > * Where: > Build file 'C:\apache-ofbiz-17.12.04\build.gradle' line: 1092 > * What went wrong: > A problem occurred evaluating root project 'ofbiz'. > > Could not resolve all dependencies for configuration ':runtime'. > > Could not determine artifacts for javax.ws.rs:javax.ws.rs-api:2.1.1 > > Could not get resource > 'https://jcenter.bintray.com/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.$%7Bpackaging.type%7D'. > > Could not HEAD > 'https://jcenter.bintray.com/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.$%7Bpackaging.type%7D'. > Received status code 400 from server: Bad Request > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > BUILD FAILED > Total time: 7.606 secs > I've looked for possible solutions online however i'm not really getting > anywhere. I really like this project and its going to help my business so > much. I've also attached some screenshots of what i've done so far. > I appreciate any assistance someone can offer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12117) Having an issue to install
[ https://issues.apache.org/jira/browse/OFBIZ-12117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-12117. - Fix Version/s: (was: 17.12.04) Resolution: Duplicate > Having an issue to install > -- > > Key: OFBIZ-12117 > URL: https://issues.apache.org/jira/browse/OFBIZ-12117 > Project: OFBiz > Issue Type: Bug > Components: setup >Affects Versions: 17.12.04 >Reporter: Rossi Subhaw >Priority: Major > Attachments: Capture.JPG, Capture2.JPG, Capture3.JPG > > > Disclaimer: I'm very new to this so please be kind. > So i've been following the installation instructions properly (i hope) > however i seem be getting this issue when i run the gradlew cleanAll loadAll > command. > FAILURE: Build failed with an exception. > * Where: > Build file 'C:\apache-ofbiz-17.12.04\build.gradle' line: 1092 > * What went wrong: > A problem occurred evaluating root project 'ofbiz'. > > Could not resolve all dependencies for configuration ':runtime'. > > Could not determine artifacts for javax.ws.rs:javax.ws.rs-api:2.1.1 > > Could not get resource > 'https://jcenter.bintray.com/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.$%7Bpackaging.type%7D'. > > Could not HEAD > 'https://jcenter.bintray.com/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.$%7Bpackaging.type%7D'. > Received status code 400 from server: Bad Request > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > BUILD FAILED > Total time: 7.606 secs > I've looked for possible solutions online however i'm not really getting > anywhere. I really like this project and its going to help my business so > much. I've also attached some screenshots of what i've done so far. > I appreciate any assistance someone can offer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12100) Gradle build of 17.12.04 crashes on Centos 8
[ https://issues.apache.org/jira/browse/OFBIZ-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256924#comment-17256924 ] Aditya Sharma commented on OFBIZ-12100: --- Thanks [~deepak], the fix works well for me. > Gradle build of 17.12.04 crashes on Centos 8 > > > Key: OFBIZ-12100 > URL: https://issues.apache.org/jira/browse/OFBIZ-12100 > Project: OFBiz > Issue Type: Bug >Affects Versions: 17.12.04 > Environment: CentOS 8 > OpenJDK 1.8 >Reporter: Alexander Tzvetanov >Assignee: Deepak Dixit >Priority: Major > > Running gradlew under Centos8 with OpenJDK 1.8 (built in). > ./gradlew cleanAll loadDefault > FAILURE: Build failed with an exception. > * Where: > Build file '/home/midax/sigma/Sigma17/build.gradle' line: 1096 > * What went wrong: > A problem occurred evaluating root project 'ofbiz'. > > Could not resolve all dependencies for configuration ':runtime'. > > Could not determine artifacts for javax.ws.rs:javax.ws.rs-api:2.1.1 > > Could not get resource > 'https://jcenter.bintray.com/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.$%7Bpackaging.type%7D'. > > Could not HEAD > 'https://jcenter.bintray.com/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.$%7Bpackaging.type%7D'. > Received status code 400 from server: Bad Request > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > BUILD FAILED > Total time: 3.747 secs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12100) Gradle build of 17.12.04 crashes on Centos 8
[ https://issues.apache.org/jira/browse/OFBIZ-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256916#comment-17256916 ] Aditya Sharma commented on OFBIZ-12100: --- Thanks Deepak I can regenerate it too. Not sure about the permanent fix but if it is a blocker for someone, using mavenCentral() for fetching dependencies can be a temporary arrangement till it is fixed OOTB. [https://docs.gradle.org/current/userguide/declaring_repositories.html#sub:maven_central] Just add mavenCentral() before jcenter() for repositories [https://github.com/apache/ofbiz-framework/blob/release17.12/build.gradle#L81] > Gradle build of 17.12.04 crashes on Centos 8 > > > Key: OFBIZ-12100 > URL: https://issues.apache.org/jira/browse/OFBIZ-12100 > Project: OFBiz > Issue Type: Bug >Affects Versions: 17.12.04 > Environment: CentOS 8 > OpenJDK 1.8 >Reporter: Alexander Tzvetanov >Assignee: Deepak Dixit >Priority: Major > > Running gradlew under Centos8 with OpenJDK 1.8 (built in). > ./gradlew cleanAll loadDefault > FAILURE: Build failed with an exception. > * Where: > Build file '/home/midax/sigma/Sigma17/build.gradle' line: 1096 > * What went wrong: > A problem occurred evaluating root project 'ofbiz'. > > Could not resolve all dependencies for configuration ':runtime'. > > Could not determine artifacts for javax.ws.rs:javax.ws.rs-api:2.1.1 > > Could not get resource > 'https://jcenter.bintray.com/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.$%7Bpackaging.type%7D'. > > Could not HEAD > 'https://jcenter.bintray.com/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.$%7Bpackaging.type%7D'. > Received status code 400 from server: Bad Request > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > BUILD FAILED > Total time: 3.747 secs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11988) Replace jquery.cookie with js-cookie
Aditya Sharma created OFBIZ-11988: - Summary: Replace jquery.cookie with js-cookie Key: OFBIZ-11988 URL: https://issues.apache.org/jira/browse/OFBIZ-11988 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: Trunk Reporter: Aditya Sharma Assignee: Aditya Sharma [https://github.com/carhartl/jquery-cookie] jquery-cookie is no longer maintained,and superseded by JS Cookie: [https://github.com/js-cookie/js-cookie] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11987) Upgrade jstree js plugin to latest
Aditya Sharma created OFBIZ-11987: - Summary: Upgrade jstree js plugin to latest Key: OFBIZ-11987 URL: https://issues.apache.org/jira/browse/OFBIZ-11987 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: Trunk Reporter: Aditya Sharma Assignee: Aditya Sharma Upgrade Jstree library to its latest version i.e. 3.3.10 [https://www.jstree.com/] [https://github.com/vakata/jstree] [https://www.npmjs.com/package/jstree] Current version used is jsTree - v3.0.0-beta3 - 2014-01-16 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183883#comment-17183883
]
Aditya Sharma edited comment on OFBIZ-11686 at 8/25/20, 9:27 AM:
-
Hi Jacques, Suraj,
We already did it for the ofbiz-framework PRs using the GitHub Actions[1] and
for plugins, I shared some alternatives[2] but concluded to skip[3] as we
decided to handle it with the Buildbot.
For the current ticket, I can't find any PR related, it seems to me direct
commit. I think the Git push hook should have worked.
1. [https://github.com/apache/ofbiz-framework/actions]
2. [https://s.apache.org/gc3d8]
3. [https://s.apache.org/qbaei]
was (Author: aditya.sharma):
Hi Jacques, Suraj,
We did it for the ofbiz-framework using the GitHub Actions[1] and for plugins,
I shared some alternatives[2] but concluded to skip[3] as we decided to handle
it with the Buildbot. For the current ticket, I can't find any PR related, it
seems to me direct commit. I think the Git push hook should have worked.
1. [https://github.com/apache/ofbiz-framework/actions]
2. [https://s.apache.org/gc3d8]
3. [https://s.apache.org/qbaei]
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183883#comment-17183883
]
Aditya Sharma edited comment on OFBIZ-11686 at 8/25/20, 9:17 AM:
-
Hi Jacques, Suraj,
We did it for the ofbiz-framework using the GitHub Actions[1] and for plugins,
I shared some alternatives[2] but concluded to skip[3] as we decided to handle
it with the Buildbot. For the current ticket, I can't find any PR related, it
seems to me direct commit. I think the Git push hook should have worked.
1. [https://github.com/apache/ofbiz-framework/actions]
2. [https://s.apache.org/gc3d8]
3. [https://s.apache.org/qbaei]
was (Author: aditya.sharma):
Hi Jacques, Suraj,
We did it for the ofbiz-framework using the GitHub Actions[1] and for plugins,
I shared some alternatives[2] but concluded to skip[3] as we decided to handle
it with the Buildbot. For the current ticket, I can't find any PR related, it
seems to me direct commit. I think the Git push hook should have worked.
1. [https://github.com/apache/ofbiz-framework/actions]
2. [https://s.apache.org/gc3d8] [
|https://s.apache.org/qbaei]3. [https://s.apache.org/qbaei]
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183883#comment-17183883
]
Aditya Sharma commented on OFBIZ-11686:
---
Hi Jacques, Suraj,
We did it for the ofbiz-framework using the GitHub Actions[1] and for plugins,
I shared some alternatives[2] but concluded to skip[3] as we decided to handle
it with the Buildbot. For the current ticket, I can't find any PR related, it
seems to me direct commit. I think the Git push hook should have worked.
1. [https://github.com/apache/ofbiz-framework/actions]
2. [https://s.apache.org/gc3d8] [
|https://s.apache.org/qbaei]3. [https://s.apache.org/qbaei]
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11960: -- Sprint: OFBiz Community Day (Aug 2020) > Use NPM with gradle to get external JS dependencies > --- > > Key: OFBIZ-11960 > URL: https://issues.apache.org/jira/browse/OFBIZ-11960 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > > 1. Add > [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: > Gradle plugin for integrating NodeJS in your build > 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in > webapp > 3. Use available tasks to install dependencies > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] > 4. Use the downloaded JS files in node_modules, updating the current path of > the JS files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11966) problem loading files by path
[
https://issues.apache.org/jira/browse/OFBIZ-11966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181152#comment-17181152
]
Aditya Sharma commented on OFBIZ-11966:
---
Hi Jacques,
I was not able to look into it since then. Though the above error seems to be
different I guess.
{code:java}
Could not create task ':ofbiz --load-data
file=../trunk-patches/variantinfojs-data.patch'.
> The task name 'ofbiz --load-data
file=../trunk-patches/variantinfojs-data.patch' must not contain any of
the following characters: [/, \, :, <, >, ", ?, *, |].{code}
[~alexbodn], I noticed in the error message that you are loading data through a
patch file and that too kept outside the OFBiz directory. I think you should
use the XML file to store data and it would be better if you store it in OFBiz
directory preferably in data folders.
> problem loading files by path
> -
>
> Key: OFBIZ-11966
> URL: https://issues.apache.org/jira/browse/OFBIZ-11966
> Project: OFBiz
> Issue Type: Bug
> Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>
> the data load failed with the following message:
> Could not create task ':ofbiz --load-data
> file=../trunk-patches/variantinfojs-data.patch'.
> > The task name 'ofbiz --load-data
> > file=../trunk-patches/variantinfojs-data.patch' must not contain any of the
> > following characters: [/, \, :, <, >, ", ?, *, |].
> it seemed to work with a local file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies
Aditya Sharma created OFBIZ-11960: - Summary: Use NPM with gradle to get external JS dependencies Key: OFBIZ-11960 URL: https://issues.apache.org/jira/browse/OFBIZ-11960 Project: OFBiz Issue Type: New Feature Components: ALL APPLICATIONS Affects Versions: Trunk Reporter: Aditya Sharma Assignee: Aditya Sharma 1. Add [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: Gradle plugin for integrating NodeJS in your build 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in webapp 3. Use available tasks to install dependencies [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] 4. Use the downloaded JS files in node_modules, updating the current path of the JS files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11899) Can't enter decimals when ordering on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173080#comment-17173080 ] Aditya Sharma edited comment on OFBIZ-11899 at 8/7/20, 11:46 AM: - Hi [~jleroux] , Added a patch with some refactoring of js code and used form attribute to get quantity value for addform. This might work with the provided patch but I think a better solution could be through markup. Also, due to some time constraints, I was not able to dig deep into how it is working in another branch. was (Author: aditya.sharma): Hi [~jleroux] , Added a patch with some refactoring of js code and used form attribute to get quantity value for addform. This might work with the provided patch but I think a better solution could be through markup. Also, due to some time constraints, I was able to dig deep how it is working in other branch. > Can't enter decimals when ordering on ecommerce > --- > > Key: OFBIZ-11899 > URL: https://issues.apache.org/jira/browse/OFBIZ-11899 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-11899.patch > > > In stable demo, and R18 locally, you can order a half pizza, that's no longer > possible in trunk demo. > Moreover you can't use the Add button in trunk, And if you use the Config > button then it orders. There must be a mix between the 2 buttons, maybe the > reason why we can't no longer enter decimals in trunk... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11899) Can't enter decimals when ordering on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173080#comment-17173080 ] Aditya Sharma edited comment on OFBIZ-11899 at 8/7/20, 11:18 AM: - Hi [~jleroux] , Added a patch with some refactoring of js code and used form attribute to get quantity value for addform. This might work with the provided patch but I think a better solution could be through markup. Also, due to some time constraints, I was able to dig deep how it is working in other branch. was (Author: aditya.sharma): Hi [~jleroux] , Added a patch with some refactoring of js code and used form attribute to get quantity value for addform. This might work with the provided patch but I think a better solution could be through markup. > Can't enter decimals when ordering on ecommerce > --- > > Key: OFBIZ-11899 > URL: https://issues.apache.org/jira/browse/OFBIZ-11899 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-11899.patch > > > In stable demo, and R18 locally, you can order a half pizza, that's no longer > possible in trunk demo. > Moreover you can't use the Add button in trunk, And if you use the Config > button then it orders. There must be a mix between the 2 buttons, maybe the > reason why we can't no longer enter decimals in trunk... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11899) Can't enter decimals when ordering on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173080#comment-17173080 ] Aditya Sharma commented on OFBIZ-11899: --- Hi [~jleroux] , Added a patch with some refactoring of js code and used form attribute to get quantity value for addform. This might work with the provided patch but I think a better solution could be through markup. > Can't enter decimals when ordering on ecommerce > --- > > Key: OFBIZ-11899 > URL: https://issues.apache.org/jira/browse/OFBIZ-11899 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-11899.patch > > > In stable demo, and R18 locally, you can order a half pizza, that's no longer > possible in trunk demo. > Moreover you can't use the Add button in trunk, And if you use the Config > button then it orders. There must be a mix between the 2 buttons, maybe the > reason why we can't no longer enter decimals in trunk... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11899) Can't enter decimals when ordering on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11899: -- Attachment: OFBIZ-11899.patch > Can't enter decimals when ordering on ecommerce > --- > > Key: OFBIZ-11899 > URL: https://issues.apache.org/jira/browse/OFBIZ-11899 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-11899.patch > > > In stable demo, and R18 locally, you can order a half pizza, that's no longer > possible in trunk demo. > Moreover you can't use the Add button in trunk, And if you use the Config > button then it orders. There must be a mix between the 2 buttons, maybe the > reason why we can't no longer enter decimals in trunk... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165160#comment-17165160 ] Aditya Sharma commented on OFBIZ-9901: -- Thanks Jacques for taking care of it :) I will try to ensure that further > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9901. Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164933#comment-17164933 ] Aditya Sharma commented on OFBIZ-9901: -- This has been fixed. Thanks Rubia Elza Joshep for reporting the issue and Aditi Patidar for providing the patch > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-9901: Assignee: Aditya Sharma (was: Aditi Patidar) > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10740) Ellipsis on product name and description
[ https://issues.apache.org/jira/browse/OFBIZ-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164903#comment-17164903 ] Aditya Sharma commented on OFBIZ-10740: --- Hi [~Dikpal.Kanungo] , [~sourabh.punyani] , It seems the changes applied are reflecting on category page too. [https://localhost:8443/ecommerce/best-sell-2-BEST-SELL-2-c] Please verify once if these changes are applied on other pages too. Apart from that, in ShowBestsellingCategories we are listing child categories and not the products, I think we can skip making a change to it > Ellipsis on product name and description > > > Key: OFBIZ-10740 > URL: https://issues.apache.org/jira/browse/OFBIZ-10740 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Aditya Sharma >Priority: Trivial > Attachments: 1046.png, 1046.png, OFBIZ-10740.patch, Screenshot.png, > ellipsis for consistency.png, ellipsis for consistency.png > > > We can apply ellipsis to various places at home page like on name and > description of the product to keep the symmetry of the page aligned and to > attain consistency. > Please have a look at the attached screenshot > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10740) Ellipsis on product name and description
[ https://issues.apache.org/jira/browse/OFBIZ-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10740: -- Description: We can apply ellipsis to various places at home page like on name and description of the product to keep the symmetry of the page aligned and to attain consistency. Please have a look at the attached screenshot was: We can apply ellipsis to various places at home page like on name and description of the product to keep the symmetry of the page aligned and to attain consistency. Please have a look at the attached screenshot !ellipsis for consistency.png! > Ellipsis on product name and description > > > Key: OFBIZ-10740 > URL: https://issues.apache.org/jira/browse/OFBIZ-10740 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Aditya Sharma >Priority: Trivial > Attachments: 1046.png, 1046.png, OFBIZ-10740.patch, Screenshot.png, > ellipsis for consistency.png, ellipsis for consistency.png > > > We can apply ellipsis to various places at home page like on name and > description of the product to keep the symmetry of the page aligned and to > attain consistency. > Please have a look at the attached screenshot > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10740) Ellipsis on product name and description
[ https://issues.apache.org/jira/browse/OFBIZ-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10740: -- Issue Type: Improvement (was: Bug) > Ellipsis on product name and description > > > Key: OFBIZ-10740 > URL: https://issues.apache.org/jira/browse/OFBIZ-10740 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Aditya Sharma >Priority: Trivial > Attachments: 1046.png, 1046.png, OFBIZ-10740.patch, Screenshot.png, > ellipsis for consistency.png, ellipsis for consistency.png > > > We can apply ellipsis to various places at home page like on name and > description of the product to keep the symmetry of the page aligned and to > attain consistency. > Please have a look at the attached screenshot > > !ellipsis for consistency.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10740) Ellipsis on product name and description
[ https://issues.apache.org/jira/browse/OFBIZ-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-10740: - Assignee: Aditya Sharma > Ellipsis on product name and description > > > Key: OFBIZ-10740 > URL: https://issues.apache.org/jira/browse/OFBIZ-10740 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Aditya Sharma >Priority: Trivial > Attachments: 1046.png, 1046.png, OFBIZ-10740.patch, Screenshot.png, > ellipsis for consistency.png, ellipsis for consistency.png > > > We can apply ellipsis to various places at home page like on name and > description of the product to keep the symmetry of the page aligned and to > attain consistency. > Please have a look at the attached screenshot > > !ellipsis for consistency.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164857#comment-17164857 ] Aditya Sharma edited comment on OFBIZ-10111 at 7/25/20, 10:03 AM: -- I think it should rather be Open as we are waiting for the patch for the repeated label issue. Hence changing the status was (Author: aditya.sharma): I think it should rather be Open as we are waiting for the patch for the repeated label issue. > The child event added is not listed in the Child Work Efforts. While if we > add an existing event it is listed in the WorkEffort component > - > > Key: OFBIZ-10111 > URL: https://issues.apache.org/jira/browse/OFBIZ-10111 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-10111.patch, screenshot-1.png > > > Steps to regenerate: > 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events] > 2) Click on the event created. > 3) To create the child events, click on the "Children" button. > 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill > in the details of the child events. Click on the Save button. > Actual: The child event added is not listed in the Child Work Efforts. While > if we add an existing event it is listed. > 5) Open URL > [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001] > 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details > below" label is repeated twice. > Note: ScreenShot Attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164857#comment-17164857 ] Aditya Sharma commented on OFBIZ-10111: --- I think it should rather be Open as we are waiting for the patch for the repeated label issue. > The child event added is not listed in the Child Work Efforts. While if we > add an existing event it is listed in the WorkEffort component > - > > Key: OFBIZ-10111 > URL: https://issues.apache.org/jira/browse/OFBIZ-10111 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-10111.patch, screenshot-1.png > > > Steps to regenerate: > 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events] > 2) Click on the event created. > 3) To create the child events, click on the "Children" button. > 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill > in the details of the child events. Click on the Save button. > Actual: The child event added is not listed in the Child Work Efforts. While > if we add an existing event it is listed. > 5) Open URL > [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001] > 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details > below" label is repeated twice. > Note: ScreenShot Attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164756#comment-17164756
]
Aditya Sharma commented on OFBIZ-11882:
---
Thanks Jacques! Sounds promising.
{quote}I have notably found that I can't view jQuery source
{quote}
We will get source map URL in most of the libraries except jQuery, we will have
to manually add it
[https://github.com/jquery/jquery/issues/4166]
> Rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, 17.12.05
>
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11905) associated products should show in rows
[ https://issues.apache.org/jira/browse/OFBIZ-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-11905: - Assignee: Aditya Sharma > associated products should show in rows > --- > > Key: OFBIZ-11905 > URL: https://issues.apache.org/jira/browse/OFBIZ-11905 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: ProductDetail.ftl.diff, ProductSummary.ftl.diff, Screen > Shot changed.png, Screen Shot original.png > > > list of associated products is broken by the subtitle. > solution: passing the subtitle as a highlighted label > to be shown in each listed summary. > screenshots are included. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164367#comment-17164367 ] Aditya Sharma commented on OFBIZ-11906: --- Thanks [~alexbodn]. This has been fixed. > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-11906. - Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11906: -- Affects Version/s: Release Branch 18.12 > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164326#comment-17164326 ] Aditya Sharma commented on OFBIZ-11906: --- Hi Alex, Instead of adding a class to make the width 100%, I would recommend that we could identify the promotion products card with some class and apply CSS to products-card. Check OFBIZ-11906.patch, it will reduce the additional code written just to add class. WDYT? > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, > PromotionProducts.ftl.diff, Screen Shot change.png, Screen Shot original.png, > custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11906: -- Attachment: OFBIZ-11906.patch > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, > PromotionProducts.ftl.diff, Screen Shot change.png, Screen Shot original.png, > custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11905) associated products should show in rows
[ https://issues.apache.org/jira/browse/OFBIZ-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164170#comment-17164170 ] Aditya Sharma commented on OFBIZ-11905: --- Hi Alex, Thanks for your contribution. It would be good if you could provide a single patch file, instead of individual files diff. > associated products should show in rows > --- > > Key: OFBIZ-11905 > URL: https://issues.apache.org/jira/browse/OFBIZ-11905 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: ProductDetail.ftl.diff, ProductSummary.ftl.diff, Screen > Shot changed.png, Screen Shot original.png > > > list of associated products is broken by the subtitle. > solution: passing the subtitle as a highlighted label > to be shown in each listed summary. > screenshots are included. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11905) associated products should show in rows
[ https://issues.apache.org/jira/browse/OFBIZ-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11905: -- Affects Version/s: Release Branch 18.12 > associated products should show in rows > --- > > Key: OFBIZ-11905 > URL: https://issues.apache.org/jira/browse/OFBIZ-11905 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: ProductDetail.ftl.diff, ProductSummary.ftl.diff, Screen > Shot changed.png, Screen Shot original.png > > > list of associated products is broken by the subtitle. > solution: passing the subtitle as a highlighted label > to be shown in each listed summary. > screenshots are included. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-11906: - Assignee: Aditya Sharma > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: ProductSummary.ftl.diff, PromotionProducts.ftl.diff, > Screen Shot change.png, Screen Shot original.png, custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163377#comment-17163377 ] Aditya Sharma commented on OFBIZ-11304: --- Okay. Thanks Jacques :) > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-11304. - Fix Version/s: 18.12.01 Resolution: Done > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Aditya Sharma >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163303#comment-17163303
]
Aditya Sharma commented on OFBIZ-11304:
---
Hi Jacques,
I think there is some confusion as there is no comment from Suraj here. Is
there anything I am missing here?
{quote}
We can close here, nothins should be needed in plugins. It's checked while
checking the trunk in Buildbot. I also have have plugins embedded as a clone
into framework locally. So it's part of the checkstyle when pushing framework.
I suggest that all committers do the same
{quote}
Makes sense, I will close it along with OFBIZ-11251.
> Install a Checkstyle pre-push (on every committer machine?)
> ---
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by
> the check gradle task. It's "hard" to exactly know from where lint errors
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like
> https://gist.github.com/davetron5000/37350 to complement
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when
> a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone
> with some committers good will. I started a discussion about it at
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-11251. - Fix Version/s: 18.12.01 Resolution: Fixed > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Aditya Sharma >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159260#comment-17159260 ] Aditya Sharma commented on OFBIZ-11882: --- Hi Jacques, For most of the libraries we have added/upgraded we simply download the official packages and added/replaced. We tried to ensure that we do least or no changes to original packages. Also, we haven't minified any of the files, most of the minified files are from the official release. I think for jQuery I have downloaded the files through the links from the official blog and simply replaced them. [https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/] But, it seems the path through [download|https://jquery.com/download/] page or [GitHub|https://github.com/jquery/jquery/releases/tag/3.5.1] would have been a much better option. I noticed that the minified files for jQuery don't come with a sourceMappingUrl as a comment in them [https://github.com/jquery/jquery/issues/4166] [|https://blog.jquery.com/2014/01/24/jquery-1-11-and-2-1-released/] |We've removed the comment on purpose, see [https://blog.jquery.com/2014/01/24/jquery-1-11-and-2-1-released/]. There are many problems with including the comment, one of them being that different CDNs use different file names so the comment would have to be different for different CDNs and that kills security features like Subresource Integrity. You can still attach the map manually via DevTools, at least Chrome supports that.| We will have to add the sourceMappingUrl to the minified file manually and add the source map file. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158984#comment-17158984 ] Aditya Sharma commented on OFBIZ-11882: --- Hi Jacques, Alex, [gradle-js-plugin|https://github.com/eriwen/gradle-js-plugin] did catch my eye too, but for me, it's a dead end. Last release in 2016 [https://github.com/eriwen/gradle-js-plugin/releases] Lacks support for current Gradle versions [https://github.com/eriwen/gradle-js-plugin/pull/176] Not sure if we should place a bet on it > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158958#comment-17158958 ] Aditya Sharma edited comment on OFBIZ-11251 at 7/16/20, 6:59 AM: - Not sure about that, maybe we can have Gradle system in place with just checkstyle plugin. I am not sure how feasible will that be. I will dig more. Though I did found some existing solution on GitHub Action [marketplace|https://github.com/marketplace] Java [Google Java Format|https://github.com/marketplace/actions/google-java-format] [Run java checkstyle|https://github.com/marketplace/actions/run-java-checkstyle] [Prettier Java Action|https://github.com/marketplace/actions/prettier-java-action] XML [xmllint problem matcher|https://github.com/marketplace/actions/xmllint-problem-matcher] XML, JavaScript, Groovy [Super-Linter|https://github.com/marketplace/actions/super-linter] These can solve the problem for the PRs but commits done directly may remain unaffected. was (Author: aditya.sharma): Not sure about that, maybe we can have Gradle system in place with just checkstyle plugin. I am not sure how feasible will that be. I will dig more. Though I did found some existing solution on GitHub Action [marketplace. |https://github.com/marketplace] Java [Google Java Format|https://github.com/marketplace/actions/google-java-format] [Run java checkstyle|https://github.com/marketplace/actions/run-java-checkstyle] [Prettier Java Action|https://github.com/marketplace/actions/prettier-java-action] XML [xmllint problem matcher|https://github.com/marketplace/actions/xmllint-problem-matcher] XML, JavaScript, Groovy [Super-Linter|https://github.com/marketplace/actions/super-linter] These can solve the problem for the PRs but commits done directly may remain unaffected. > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158246#comment-17158246 ] Aditya Sharma commented on OFBIZ-11251: --- That makes sense. I am only concerned about the pre-push hook that will fail due to the absence of checkstyleMain. We won't be able to remove the hook programmatically, maybe we should add a dummy empty Gradle task with name checkstyleMain. I will check more with the Gradle hook plugin if I can get something better. > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158029#comment-17158029 ] Aditya Sharma commented on OFBIZ-11251: --- I am checking if I can create custom task that can check maxErrors like the below solution. I did found a [solution|https://gist.github.com/mauricegavin/2fced2dea175898fb1768ae05ac0c303] but it requires some changes as per our requirements. > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158025#comment-17158025 ] Aditya Sharma edited comment on OFBIZ-11251 at 7/15/20, 9:44 AM: - Hi Jacques, I tried backporting but got blocked as R17, we have Gradle 3.2 and as per the official [documentation|https://docs.gradle.org/3.2.1/dsl/org.gradle.api.plugins.quality.Checkstyle.html] we do not have support for maxErrors. Along with that I got errors for configuration as well, it seems the some of the modules added in config.xml didn't existed for 3.2. was (Author: aditya.sharma): Hi Jacques, I tried backporting but got blocked as R17, we have Gradle 3 > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158025#comment-17158025 ] Aditya Sharma commented on OFBIZ-11251: --- Hi Jacques, I tried backporting but got blocked as R17, we have Gradle 3 > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reopened OFBIZ-11251: --- Assignee: Aditya Sharma (was: Mathieu Lirzin) Reopening to backport as per the discussion on the mailing list https://markmail.org/message/wqzrxchgzam7el74 > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140490#comment-17140490 ] Aditya Sharma commented on OFBIZ-11304: --- Hi Jacques, I think we still have to handle the release branches. We can use the same ticket to backport checkstyle plugin and add the pre-push hook after consensus. Wdyt? > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11752) CLONE - Check embedded Javascript libs vulnerabilities using retire.js
[
https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139172#comment-17139172
]
Aditya Sharma commented on OFBIZ-11752:
---
Thanks Olivier!
> CLONE - Check embedded Javascript libs vulnerabilities using retire.js
> --
>
> Key: OFBIZ-11752
> URL: https://issues.apache.org/jira/browse/OFBIZ-11752
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Major
> Labels: Javascript, retire.js, vulnerabilities
> Fix For: 18.12.01, 17.12.04
>
>
> Trunk
> {code:java}
> /ofbiz-framework/plugins/solr/webapp/solr/js/require.js
> ↳ jquery 1.7.1
> jquery 1.7.1 has known vulnerabilities: severity: medium; CVE: CVE-2012-6708,
> bug: 11290, summary: Selector interpreted as HTML;
> http://bugs.jquery.com/ticket/11290
> https://nvd.nist.gov/vuln/detail/CVE-2012-6708
> http://research.insecurelabs.org/jquery/test/ severity: medium; issue: 2432,
> summary: 3rd party CORS request may execute, CVE: CVE-2015-9251;
> https://github.com/jquery/jquery/issues/2432
> http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/
> https://nvd.nist.gov/vuln/detail/CVE-2015-9251
> http://research.insecurelabs.org/jquery/test/ severity: low; CVE:
> CVE-2019-11358, summary: jQuery before 3.4.0, as used in Drupal, Backdrop
> CMS, and other products, mishandles jQuery.extend(true, {}, ...) because of
> Object.prototype pollution;
> https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/
> https://nvd.nist.gov/vuln/detail/CVE-2019-11358
> https://github.com/jquery/jquery/commit/753d591aea698e57d6db58c9f722cd0808619b1b
> severity: medium; summary: Regex in its jQuery.htmlPrefilter sometimes may
> introduce XSS; https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/
> /ofbiz-framework/plugins/solr/webapp/solr/libs/angular-cookies.min.js
> ↳ angularjs 1.3.8
> angularjs 1.3.8 has known vulnerabilities: severity: medium; summary:
> Prototype pollution;
> https://github.com/angular/angular.js/commit/726f49dcf6c23106ddaf5cfd5e2e592841db743a
>
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#179-pollution-eradication-2019-11-19
> severity: medium; summary: The attribute usemap can be used as a security
> exploit;
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#1230-patronal-resurrection-2016-07-21
> severity: medium; summary: Universal CSP bypass via add-on in Firefox;
> https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435
> http://pastebin.com/raw/kGrdaypP severity: medium; summary: DOS in $sanitize;
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md
> https://github.com/angular/angular.js/pull/15699 severity: low; summary: XSS
> in $sanitize in Safari/Firefox;
> https://github.com/angular/angular.js/commit/8f31f1ff43b673a24f84422d5c13d6312b2c4d94
> /ofbiz-framework/plugins/solr/webapp/solr/libs/angular-resource.min.js
> ↳ angularjs 1.3.8
> angularjs 1.3.8 has known vulnerabilities: severity: medium; summary:
> Prototype pollution;
> https://github.com/angular/angular.js/commit/726f49dcf6c23106ddaf5cfd5e2e592841db743a
>
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#179-pollution-eradication-2019-11-19
> severity: medium; summary: The attribute usemap can be used as a security
> exploit;
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#1230-patronal-resurrection-2016-07-21
> severity: medium; summary: Universal CSP bypass via add-on in Firefox;
> https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435
> http://pastebin.com/raw/kGrdaypP severity: medium; summary: DOS in $sanitize;
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md
> https://github.com/angular/angular.js/pull/15699 severity: low; summary: XSS
> in $sanitize in Safari/Firefox;
> https://github.com/angular/angular.js/commit/8f31f1ff43b673a24f84422d5c13d6312b2c4d94
> /ofbiz-framework/plugins/solr/webapp/solr/libs/angular-route.min.js
> ↳ angularjs 1.3.8
> angularjs 1.3.8 has known vulnerabilities: severity: medium; summary:
> Prototype pollution;
> https://github.com/angular/angular.js/commit/726f49dcf6c23106ddaf5cfd5e2e592841db743a
>
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#179-pollution-eradication-2019-11-19
> severity: medium; summary: The attribute usemap can be used as a security
> exploit;
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#1230-patronal-resurrection-2016-07-21
> severity: medium; summary: Universal CSP bypass via add-on in Firefox;
> https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435
>
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139169#comment-17139169 ] Aditya Sharma commented on OFBIZ-11304: --- Awesome. Thank you Jacques! >> I have still to see how to prevent a PR merge in case of failure We can make it part of [Committers Roles and Responsibilities |https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities] >> Maybe we can create our own CI server and use BuildBot has our status >> server. But how to relate the failure of the checkstyle step there to GH >> status is still to investigate... +1. Let me explore more on it >> Begin to be a lot for rejecting check style failures on PR merge, I better >> understand Infra reaction now ;) :) > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138097#comment-17138097 ] Aditya Sharma commented on OFBIZ-11304: --- Hi Jacques, I think we can also use GitHub actions with Gradle for the PR test, just like we are using for Sonarcloud. Some quick links for the same: 1. [https://github.com/marketplace/actions/setup-java-jdk] 2. [https://github.com/apache/ofbiz-framework/actions/new] 3. [Setup link|https://github.com/apache/ofbiz-framework/new/trunk?filename=.github%2Fworkflows%2Fgradle.yml_template=gradle] This way all the PR needs to pass the checkstyle test before they are merged. Locally committers can use the pre-push hook. >> What about checking branches? The hook is present in all branches but not >> checkstyle I think we should add it to all branches. We are not making any major change to OFBiz rather it is an add-on to the development process. Wdyt? > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138097#comment-17138097 ] Aditya Sharma edited comment on OFBIZ-11304 at 6/17/20, 4:51 AM: - Hi Jacques, I think we can also use GitHub actions with Gradle for the PR test, just like we are using for Sonarcloud. Some quick links for the same: 1. [https://github.com/marketplace/actions/setup-java-jdk] 2. [https://github.com/apache/ofbiz-framework/actions/new] 3. [Setup link for OFBiz|https://github.com/apache/ofbiz-framework/new/trunk?filename=.github%2Fworkflows%2Fgradle.yml_template=gradle] This way all the PR needs to pass the checkstyle test before they are merged. Locally committers can use the pre-push hook. >> What about checking branches? The hook is present in all branches but not >> checkstyle I think we should add it to all branches. We are not making any major change to OFBiz rather it is an add-on to the development process. Wdyt? was (Author: aditya.sharma): Hi Jacques, I think we can also use GitHub actions with Gradle for the PR test, just like we are using for Sonarcloud. Some quick links for the same: 1. [https://github.com/marketplace/actions/setup-java-jdk] 2. [https://github.com/apache/ofbiz-framework/actions/new] 3. [Setup link|https://github.com/apache/ofbiz-framework/new/trunk?filename=.github%2Fworkflows%2Fgradle.yml_template=gradle] This way all the PR needs to pass the checkstyle test before they are merged. Locally committers can use the pre-push hook. >> What about checking branches? The hook is present in all branches but not >> checkstyle I think we should add it to all branches. We are not making any major change to OFBiz rather it is an add-on to the development process. Wdyt? > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
