[jira] [Commented] (OFBIZ-12068) Order processing issue for dropship only products
[ https://issues.apache.org/jira/browse/OFBIZ-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331604#comment-17331604 ] Amit Gadaley commented on OFBIZ-12068: -- Hello [~jleroux] , Thank You for looking into this. I have updated the patch. I also checked with "gradlew check" and build was successful. > Order processing issue for dropship only products > - > > Key: OFBIZ-12068 > URL: https://issues.apache.org/jira/browse/OFBIZ-12068 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Attachments: OFBIZ-12068-1.patch, OFBIZ-12068-2.patch > > > When a dropship only (or dropship on low ATP) product with no qualified > supplier added to shopping cart and cart converted to sales order. System > should return errors and should not create sales order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12068) Order processing issue for dropship only products
[ https://issues.apache.org/jira/browse/OFBIZ-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-12068: - Attachment: OFBIZ-12068-1.patch > Order processing issue for dropship only products > - > > Key: OFBIZ-12068 > URL: https://issues.apache.org/jira/browse/OFBIZ-12068 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Attachments: OFBIZ-12068-1.patch, OFBIZ-12068-2.patch > > > When a dropship only (or dropship on low ATP) product with no qualified > supplier added to shopping cart and cart converted to sales order. System > should return errors and should not create sales order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12068) Order processing issue for dropship only products
[ https://issues.apache.org/jira/browse/OFBIZ-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-12068: - Attachment: (was: OFBIZ-12068-1.patch) > Order processing issue for dropship only products > - > > Key: OFBIZ-12068 > URL: https://issues.apache.org/jira/browse/OFBIZ-12068 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Attachments: OFBIZ-12068-1.patch, OFBIZ-12068-2.patch > > > When a dropship only (or dropship on low ATP) product with no qualified > supplier added to shopping cart and cart converted to sales order. System > should return errors and should not create sales order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12203) WebPos: Product price cannot be updated
[ https://issues.apache.org/jira/browse/OFBIZ-12203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331577#comment-17331577 ] Amit Gadaley commented on OFBIZ-12203: -- Hello [~jleroux] and [~sa_james], Thank You for looking into this. I think we are having confusion due to unclear UI available on 'Cart Item Selected' section of the webpos main screen. The request to update the price only submitted when an application user enters the price for 'New price' input and presses the 'Enter' button on the keyboard. The "+/-" buttons and 'Update' button are only used to update the quantity of the selected item. The "+/-" buttons are working fine for me but the image at the left of the search area is not working. I am happy to discuss and work on improving the UI on this jira ticket or a new Jira ticket. Please let me know your thoughts on this. > WebPos: Product price cannot be updated > --- > > Key: OFBIZ-12203 > URL: https://issues.apache.org/jira/browse/OFBIZ-12203 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: 17.12.06 >Reporter: Woyce Batkins >Assignee: Amit Gadaley >Priority: Critical > Attachments: OFBIZ-12203.patch > > > * Go to the WebPos application > * Search for a product > * Update the price with a new value > * The Update is not working -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12203) WebPos: Product price cannot be updated
[ https://issues.apache.org/jira/browse/OFBIZ-12203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310288#comment-17310288 ] Amit Gadaley commented on OFBIZ-12203: -- Thank You [~sa_james] for reporting it. I have debugged the issue and found that we are using the method 'getDisplayPrice()' [Class: ShoppingCartItem] to display item unit price and the method 'getDisplayItemSubTotal()' [Class: ShoppingCartItem] to display item total. These two methods use the display price of the item. And, while updating the price for an item from the POS application, we are only updating the base price of that item using the method 'modifyPrice' [Class: WebPosTransaction]. To fix the issue, I have updated the method 'modifyPrice' by adding logic to update the display price of the item as well. > WebPos: Product price cannot be updated > --- > > Key: OFBIZ-12203 > URL: https://issues.apache.org/jira/browse/OFBIZ-12203 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: 17.12.06 >Reporter: Woyce Batkins >Assignee: Amit Gadaley >Priority: Critical > Attachments: OFBIZ-12203.patch > > > * Go to the WebPos application > * Search for a product > * Update the price with a new value > * The Update is not working -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12203) WebPos: Product price cannot be updated
[ https://issues.apache.org/jira/browse/OFBIZ-12203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-12203: - Attachment: OFBIZ-12203.patch > WebPos: Product price cannot be updated > --- > > Key: OFBIZ-12203 > URL: https://issues.apache.org/jira/browse/OFBIZ-12203 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: 17.12.06 >Reporter: Woyce Batkins >Assignee: Amit Gadaley >Priority: Critical > Attachments: OFBIZ-12203.patch > > > * Go to the WebPos application > * Search for a product > * Update the price with a new value > * The Update is not working -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12203) WebPos: Product price cannot be updated
[ https://issues.apache.org/jira/browse/OFBIZ-12203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-12203: Assignee: Amit Gadaley > WebPos: Product price cannot be updated > --- > > Key: OFBIZ-12203 > URL: https://issues.apache.org/jira/browse/OFBIZ-12203 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: 17.12.06 >Reporter: Woyce Batkins >Assignee: Amit Gadaley >Priority: Critical > > * Go to the WebPos application > * Search for a product > * Update the price with a new value > * The Update is not working -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12113) Unable to set Default Shipment Method for a customer on e-commerce
[ https://issues.apache.org/jira/browse/OFBIZ-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270637#comment-17270637 ] Amit Gadaley edited comment on OFBIZ-12113 at 1/23/21, 12:32 PM: - Thanks [~arpit.mor] for reporting it. Provided patch for the same. I also have looked at issue OFBIZ-12103, it is assigned to [~pradeep.chaudhary]. I will assign it to myself and will look into it. was (Author: amit.gadaley): Thanks [~arpit.mor] for reporting it. Provided patch for the same. I also have looked at issue OFBIZ-12103, it is assigned to [~pradeep.chaudhary]. > Unable to set Default Shipment Method for a customer on e-commerce > -- > > Key: OFBIZ-12113 > URL: https://issues.apache.org/jira/browse/OFBIZ-12113 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Amit Gadaley >Priority: Minor > Attachments: Image01.png, OFBIZ-12113.patch > > > Steps to regenerate: > * Navigate to: [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * Register a new customer > * Navigate to the profile page of the customer and set the default shipping > address > * Try to set the default shipment method for the customer > Result: Radio button to select shipment method is not displayed. If the user > click on set default link then the following error message is displayed: "You > haven't the permission for the service setPartyProfileDefaults, reason : > Security Error: you do not have permission to perform setPartyProfileDefaults > for this party." Please refer attachment: Image01 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12113) Unable to set Default Shipment Method for a customer on e-commerce
[ https://issues.apache.org/jira/browse/OFBIZ-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270637#comment-17270637 ] Amit Gadaley commented on OFBIZ-12113: -- Thanks [~arpit.mor] for reporting it. Provided patch for the same. I also have looked at issue OFBIZ-12103, it is assigned to [~pradeep.chaudhary]. > Unable to set Default Shipment Method for a customer on e-commerce > -- > > Key: OFBIZ-12113 > URL: https://issues.apache.org/jira/browse/OFBIZ-12113 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Amit Gadaley >Priority: Minor > Attachments: Image01.png, OFBIZ-12113.patch > > > Steps to regenerate: > * Navigate to: [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * Register a new customer > * Navigate to the profile page of the customer and set the default shipping > address > * Try to set the default shipment method for the customer > Result: Radio button to select shipment method is not displayed. If the user > click on set default link then the following error message is displayed: "You > haven't the permission for the service setPartyProfileDefaults, reason : > Security Error: you do not have permission to perform setPartyProfileDefaults > for this party." Please refer attachment: Image01 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12113) Unable to set Default Shipment Method for a customer on e-commerce
[ https://issues.apache.org/jira/browse/OFBIZ-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-12113: - Attachment: OFBIZ-12113.patch > Unable to set Default Shipment Method for a customer on e-commerce > -- > > Key: OFBIZ-12113 > URL: https://issues.apache.org/jira/browse/OFBIZ-12113 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Amit Gadaley >Priority: Minor > Attachments: Image01.png, OFBIZ-12113.patch > > > Steps to regenerate: > * Navigate to: [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * Register a new customer > * Navigate to the profile page of the customer and set the default shipping > address > * Try to set the default shipment method for the customer > Result: Radio button to select shipment method is not displayed. If the user > click on set default link then the following error message is displayed: "You > haven't the permission for the service setPartyProfileDefaults, reason : > Security Error: you do not have permission to perform setPartyProfileDefaults > for this party." Please refer attachment: Image01 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12113) Unable to set Default Shipment Method for a customer on e-commerce
[ https://issues.apache.org/jira/browse/OFBIZ-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-12113: - Sprint: OFBiz Community Day (Nov 2020) > Unable to set Default Shipment Method for a customer on e-commerce > -- > > Key: OFBIZ-12113 > URL: https://issues.apache.org/jira/browse/OFBIZ-12113 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Amit Gadaley >Priority: Minor > Attachments: Image01.png > > > Steps to regenerate: > * Navigate to: [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * Register a new customer > * Navigate to the profile page of the customer and set the default shipping > address > * Try to set the default shipment method for the customer > Result: Radio button to select shipment method is not displayed. If the user > click on set default link then the following error message is displayed: "You > haven't the permission for the service setPartyProfileDefaults, reason : > Security Error: you do not have permission to perform setPartyProfileDefaults > for this party." Please refer attachment: Image01 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12113) Unable to set Default Shipment Method for a customer on e-commerce
[ https://issues.apache.org/jira/browse/OFBIZ-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-12113: Assignee: Amit Gadaley > Unable to set Default Shipment Method for a customer on e-commerce > -- > > Key: OFBIZ-12113 > URL: https://issues.apache.org/jira/browse/OFBIZ-12113 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Amit Gadaley >Priority: Minor > Attachments: Image01.png > > > Steps to regenerate: > * Navigate to: [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * Register a new customer > * Navigate to the profile page of the customer and set the default shipping > address > * Try to set the default shipment method for the customer > Result: Radio button to select shipment method is not displayed. If the user > click on set default link then the following error message is displayed: "You > haven't the permission for the service setPartyProfileDefaults, reason : > Security Error: you do not have permission to perform setPartyProfileDefaults > for this party." Please refer attachment: Image01 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12068) Order processing issue for dropship only products
[ https://issues.apache.org/jira/browse/OFBIZ-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254981#comment-17254981 ] Amit Gadaley commented on OFBIZ-12068: -- Changed return type to 'Map' from 'void' of method 'createDropShipGroups' (class: ShoppingCart). Returned error message if no valid supplier found for drop ship products in order entry process. Attached patches with required changes. > Order processing issue for dropship only products > - > > Key: OFBIZ-12068 > URL: https://issues.apache.org/jira/browse/OFBIZ-12068 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Attachments: OFBIZ-12068-1.patch, OFBIZ-12068-2.patch > > > When a dropship only (or dropship on low ATP) product with no qualified > supplier added to shopping cart and cart converted to sales order. System > should return errors and should not create sales order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12068) Order processing issue for dropship only products
[ https://issues.apache.org/jira/browse/OFBIZ-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-12068: - Attachment: OFBIZ-12068-2.patch OFBIZ-12068-1.patch > Order processing issue for dropship only products > - > > Key: OFBIZ-12068 > URL: https://issues.apache.org/jira/browse/OFBIZ-12068 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Attachments: OFBIZ-12068-1.patch, OFBIZ-12068-2.patch > > > When a dropship only (or dropship on low ATP) product with no qualified > supplier added to shopping cart and cart converted to sales order. System > should return errors and should not create sales order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12068) Order processing issue for dropship only products
[ https://issues.apache.org/jira/browse/OFBIZ-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-12068: - Description: When a dropship only (or dropship on low ATP) product with no qualified supplier added to shopping cart and cart converted to sales order. System should return errors and should not create sales order. (was: When a dropship only (or dropship on low ATP) product with no qualified supplier added to shopping cart and cart converted to sales order. System only logs error messages, it should also return errors and should not create sales order.) > Order processing issue for dropship only products > - > > Key: OFBIZ-12068 > URL: https://issues.apache.org/jira/browse/OFBIZ-12068 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > > When a dropship only (or dropship on low ATP) product with no qualified > supplier added to shopping cart and cart converted to sales order. System > should return errors and should not create sales order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12068) Order processing issue for dropship only products
[ https://issues.apache.org/jira/browse/OFBIZ-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-12068: Assignee: Amit Gadaley > Order processing issue for dropship only products > - > > Key: OFBIZ-12068 > URL: https://issues.apache.org/jira/browse/OFBIZ-12068 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > > When a dropship only (or dropship on low ATP) product with no qualified > supplier added to shopping cart and cart converted to sales order. System > only logs error messages, it should also return errors and should not create > sales order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12068) Order processing issue for dropship only products
Amit Gadaley created OFBIZ-12068: Summary: Order processing issue for dropship only products Key: OFBIZ-12068 URL: https://issues.apache.org/jira/browse/OFBIZ-12068 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Amit Gadaley When a dropship only (or dropship on low ATP) product with no qualified supplier added to shopping cart and cart converted to sales order. System only logs error messages, it should also return errors and should not create sales order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
[ https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-11971: Assignee: Suraj Khurana (was: Amit Gadaley) > Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap > --- > > Key: OFBIZ-11971 > URL: https://issues.apache.org/jira/browse/OFBIZ-11971 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Suraj Khurana >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-11971.patch > > > 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId in ReturnItemTypeMap data > and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type > data does not exists. > The following data exist for miscellaneous charges in data files: > returnAdjustmentTypeId="RET_MISC_ADJ"/> -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
[ https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182326#comment-17182326 ] Amit Gadaley commented on OFBIZ-11971: -- Provided patch. Thanks [~surajk]. > Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap > --- > > Key: OFBIZ-11971 > URL: https://issues.apache.org/jira/browse/OFBIZ-11971 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-11971.patch > > > 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId in ReturnItemTypeMap data > and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type > data does not exists. > The following data exist for miscellaneous charges in data files: > returnAdjustmentTypeId="RET_MISC_ADJ"/> -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
[ https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-11971: - Attachment: OFBIZ-11971.patch > Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap > --- > > Key: OFBIZ-11971 > URL: https://issues.apache.org/jira/browse/OFBIZ-11971 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-11971.patch > > > 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId in ReturnItemTypeMap data > and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type > data does not exists. > The following data exist for miscellaneous charges in data files: > returnAdjustmentTypeId="RET_MISC_ADJ"/> -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
Amit Gadaley created OFBIZ-11971: Summary: Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap Key: OFBIZ-11971 URL: https://issues.apache.org/jira/browse/OFBIZ-11971 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Amit Gadaley Assignee: Amit Gadaley Fix For: Trunk 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId in ReturnItemTypeMap data and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type data does not exists. The following data exist for miscellaneous charges in data files: -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-11185: Assignee: Suraj Khurana (was: Amit Gadaley) > OrderReadHelper.getAvailableOrderHeaderAdjustments improvements > --- > > Key: OFBIZ-11185 > URL: https://issues.apache.org/jira/browse/OFBIZ-11185 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11185.patch > > > We have a helper method in OrderReadHelper named as > getAvailableOrderHeaderAdjustments which is used to fetch order header > adjustments available for return. > It should also check for amount, it might possible, orderHeader adjustment > was of $100 and once a return is created for $20, then available $80 would > not render while creating second return for the same order. > So instead of checking only for orderAdjustmentId in ReturnAdjustment, it > should also check for adjustment amount. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182306#comment-17182306 ] Amit Gadaley commented on OFBIZ-11185: -- Provided patch. Thanks [~surajk] for reporting it. > OrderReadHelper.getAvailableOrderHeaderAdjustments improvements > --- > > Key: OFBIZ-11185 > URL: https://issues.apache.org/jira/browse/OFBIZ-11185 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Amit Gadaley >Priority: Major > Attachments: OFBIZ-11185.patch > > > We have a helper method in OrderReadHelper named as > getAvailableOrderHeaderAdjustments which is used to fetch order header > adjustments available for return. > It should also check for amount, it might possible, orderHeader adjustment > was of $100 and once a return is created for $20, then available $80 would > not render while creating second return for the same order. > So instead of checking only for orderAdjustmentId in ReturnAdjustment, it > should also check for adjustment amount. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-11185: - Attachment: OFBIZ-11185.patch > OrderReadHelper.getAvailableOrderHeaderAdjustments improvements > --- > > Key: OFBIZ-11185 > URL: https://issues.apache.org/jira/browse/OFBIZ-11185 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Amit Gadaley >Priority: Major > Attachments: OFBIZ-11185.patch > > > We have a helper method in OrderReadHelper named as > getAvailableOrderHeaderAdjustments which is used to fetch order header > adjustments available for return. > It should also check for amount, it might possible, orderHeader adjustment > was of $100 and once a return is created for $20, then available $80 would > not render while creating second return for the same order. > So instead of checking only for orderAdjustmentId in ReturnAdjustment, it > should also check for adjustment amount. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11294) EntityQuery queryCount is throwing error with distinct method
[
https://issues.apache.org/jira/browse/OFBIZ-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114708#comment-17114708
]
Amit Gadaley commented on OFBIZ-11294:
--
Hello [~pawan],
I have faced the same issue and this solution looks good to me.
I have tested it and it is working fine for me.
> EntityQuery queryCount is throwing error with distinct method
> -
>
> Key: OFBIZ-11294
> URL: https://issues.apache.org/jira/browse/OFBIZ-11294
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
>
> We have a bug/missing support for distinct when used with queryCount method
> of EntityQuery.
> Below is the more detail
> {code:java}
> EntityCondition cond = EntityCondition.makeCondition(UtilMisc.toList(
> EntityCondition.makeCondition("locationSeqId", "00test123"),
> EntityCondition.makeCondition("facilityId", EntityOperator.EQUALS,
> "10070"),
> EntityCondition.makeCondition("quantityOnHandTotal",
> EntityOperator.GREATER_THAN, BigDecimal.ZERO)),
> EntityOperator.AND);{code}
> *Case 1:* queryList().size() with distinct
> {code:java}
> int productAtLocation =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).distinct().queryList().size();{code}
> Result Query: SELECT DISTINCT PRODUCT_ID FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case works well.
> *Case 2:* queryCount without distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(1) FROM INVENTORY_ITEM WHERE ((LOCATION_SEQ_ID =
> ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case also works well
> *Case 3:* queryCount with distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(DISTINCT *) FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case throw an error
> org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception while
> executing the following:SELECT COUNT(DISTINCT *) FROM OFBIZ.INVENTORY_ITEM
> (Syntax error: Encountered "*" at line 1, column 23.)
>
> *Below is the research I have done for the issue:*
> In EntityQuery.queryCount(), return method is
> delegator.findCountByCondition(). This method doesn't have support for
> fieldsToSelect.
> When we reach till GenericDAO.selectCountByCondition() at line 949,
> returning method is setting *null* for selectFields.
> And at the implementation of selectCountByCondition, at line 994 we have a
> check for selectFields, that's why we are having *COUNT(DISTINCT *)* in our
> query.
>
> *To test this, I have used a simple way:*
> Just include below code at any groovy file and run it:
> {code:java}
> testCount = select("productId").from("InventoryItem").distinct().queryCount()
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10891) Send me this every month link is not working in order items section.
[ https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114707#comment-17114707 ] Amit Gadaley commented on OFBIZ-10891: -- Hello [~pawan], This issue exists on release branch as well. > Send me this every month link is not working in order items section. > > > Key: OFBIZ-10891 > URL: https://issues.apache.org/jira/browse/OFBIZ-10891 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, > OFBIZ-10891.png > > > *Steps to Reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Place a order. > 4. Navigate to order history and click on view link. > 5. Click on link “send me this every month” in order items section. > *Actual Result:* Error message is displayed. > *Screen print attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10891) Send me this every month link is not working in order items section.
[ https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10891: - Affects Version/s: Release Branch 18.12 > Send me this every month link is not working in order items section. > > > Key: OFBIZ-10891 > URL: https://issues.apache.org/jira/browse/OFBIZ-10891 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ashish Sharma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, > OFBIZ-10891.png > > > *Steps to Reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Place a order. > 4. Navigate to order history and click on view link. > 5. Click on link “send me this every month” in order items section. > *Actual Result:* Error message is displayed. > *Screen print attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10891) Send me this every month link is not working in order items section.
[ https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10891: - Affects Version/s: Release Branch 17.12 > Send me this every month link is not working in order items section. > > > Key: OFBIZ-10891 > URL: https://issues.apache.org/jira/browse/OFBIZ-10891 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ashish Sharma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, > OFBIZ-10891.png > > > *Steps to Reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Place a order. > 4. Navigate to order history and click on view link. > 5. Click on link “send me this every month” in order items section. > *Actual Result:* Error message is displayed. > *Screen print attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11120) Issue while creating an order for product of type (Fixed) Asset Usage
[ https://issues.apache.org/jira/browse/OFBIZ-11120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980751#comment-16980751 ] Amit Gadaley commented on OFBIZ-11120: -- Verified the issue. The issue reported in ProductAO04.png is the only real issue, rest are working as expected. > Issue while creating an order for product of type (Fixed) Asset Usage > - > > Key: OFBIZ-11120 > URL: https://issues.apache.org/jira/browse/OFBIZ-11120 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Vedansh Tiwari >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk, Release Branch 16.11 > > Attachments: ProductAO03.png, ProductAO04.png, ProductAO1.png, > ProductAO2.png > > > Steps to regenerate > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem] > # Click on the product lookup icon > # Click on the "Find" button > # Select the "(Fixed) Asset Usage" product (FORKLIFT_PROPANE) > # Click on "Add to order" button > Actual: Error message "The following occurred: Enter Booking Information > Before Adding to Cart" is showing. Please refer the attachment: ProductAO1.jpg > Expected: Error message should be corrected > > Issue 2: > Steps to regenerate: > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem] > # Click on the product lookup icon > # Click on the "Find" button > # Select the "(Fixed) Asset Usage" product (FORKLIFT_PROPANE) > # Click on "Add to order" button > # Select the date and time > # Click on the "Add to cart" > # Again click on the product look-up for selecting the product. > > Actual: UI issue on the model. Please refer the attachment: ProductAO04 > > Note: please refer the attachment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11120) Issue while creating an order for product of type (Fixed) Asset Usage
[ https://issues.apache.org/jira/browse/OFBIZ-11120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-11120: Assignee: Amit Gadaley (was: Rushikesh Mawal) > Issue while creating an order for product of type (Fixed) Asset Usage > - > > Key: OFBIZ-11120 > URL: https://issues.apache.org/jira/browse/OFBIZ-11120 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Vedansh Tiwari >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk, Release Branch 16.11 > > Attachments: ProductAO03.png, ProductAO04.png, ProductAO1.png, > ProductAO2.png > > > Steps to regenerate > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem] > # Click on the product lookup icon > # Click on the "Find" button > # Select the "(Fixed) Asset Usage" product (FORKLIFT_PROPANE) > # Click on "Add to order" button > Actual: Error message "The following occurred: Enter Booking Information > Before Adding to Cart" is showing. Please refer the attachment: ProductAO1.jpg > Expected: Error message should be corrected > > Issue 2: > Steps to regenerate: > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem] > # Click on the product lookup icon > # Click on the "Find" button > # Select the "(Fixed) Asset Usage" product (FORKLIFT_PROPANE) > # Click on "Add to order" button > # Select the date and time > # Click on the "Add to cart" > # Again click on the product look-up for selecting the product. > > Actual: UI issue on the model. Please refer the attachment: ProductAO04 > > Note: please refer the attachment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10375) Issues with Recurrence Info ID at Edit Invoice
[ https://issues.apache.org/jira/browse/OFBIZ-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939935#comment-16939935 ] Amit Gadaley commented on OFBIZ-10375: -- It seems this issue no longer exists. I also agree with [~pierresmits], we should remove Recurrence Info ID field from invoice. > Issues with Recurrence Info ID at Edit Invoice > -- > > Key: OFBIZ-10375 > URL: https://issues.apache.org/jira/browse/OFBIZ-10375 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ap/control/updateInvoice >Reporter: Aayush jain >Assignee: Amit Gadaley >Priority: Major > Attachments: Screenshot from 2018-04-28 11-13-03.png > > > Steps: > 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/updateInvoice > 2. Navigate to Edit Invoice > 3. Enter Recurrence Info ID like ABCTEST001 > 4. Check on Update button > Actual Result: > Throwing an exception error, kindly refer attachment for the same. > Expected Result: > An exception should be handled properly and the proper error message should > be displayed on the screen > Note: > Recurrence Info ID is Key of another table, so we can not enter any kind of > ramdom value. > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10375) Issues with Recurrence Info ID at Edit Invoice
[ https://issues.apache.org/jira/browse/OFBIZ-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-10375: Assignee: Amit Gadaley > Issues with Recurrence Info ID at Edit Invoice > -- > > Key: OFBIZ-10375 > URL: https://issues.apache.org/jira/browse/OFBIZ-10375 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ap/control/updateInvoice >Reporter: Aayush jain >Assignee: Amit Gadaley >Priority: Major > Attachments: Screenshot from 2018-04-28 11-13-03.png > > > Steps: > 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/updateInvoice > 2. Navigate to Edit Invoice > 3. Enter Recurrence Info ID like ABCTEST001 > 4. Check on Update button > Actual Result: > Throwing an exception error, kindly refer attachment for the same. > Expected Result: > An exception should be handled properly and the proper error message should > be displayed on the screen > Note: > Recurrence Info ID is Key of another table, so we can not enter any kind of > ramdom value. > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11219) Issue with check box functionality on show cart page
[ https://issues.apache.org/jira/browse/OFBIZ-11219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley closed OFBIZ-11219. Resolution: Fixed > Issue with check box functionality on show cart page > > > Key: OFBIZ-11219 > URL: https://issues.apache.org/jira/browse/OFBIZ-11219 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Vedansh Tiwari >Assignee: Amit Gadaley >Priority: Major > > *Steps to regenerate:* > 1. Open [URL https://demo-trunk.ofbiz.apache.org|http://example.com] > 2. Login with valid ID and password > 3. Add the at least 4-5 product into the cart > 4. Click on the "View Cart" link > 5. Select the checkbox of only 2 products on the show cart page > 6. Click on the "Checkout" button > *Actual:* All products are displaying in the cart summary section, after > selecting only 2 products > *Expected:* Only selected products should be displayed in the cart summary > section -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11219) Issue with check box functionality on show cart page
[ https://issues.apache.org/jira/browse/OFBIZ-11219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939914#comment-16939914 ] Amit Gadaley commented on OFBIZ-11219: -- This is not an issue. The checkboxes given in front of cart items are part of the functionality 'Remove Selected'. The checkout button is working as per expectation. > Issue with check box functionality on show cart page > > > Key: OFBIZ-11219 > URL: https://issues.apache.org/jira/browse/OFBIZ-11219 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Vedansh Tiwari >Assignee: Amit Gadaley >Priority: Major > > *Steps to regenerate:* > 1. Open [URL https://demo-trunk.ofbiz.apache.org|http://example.com] > 2. Login with valid ID and password > 3. Add the at least 4-5 product into the cart > 4. Click on the "View Cart" link > 5. Select the checkbox of only 2 products on the show cart page > 6. Click on the "Checkout" button > *Actual:* All products are displaying in the cart summary section, after > selecting only 2 products > *Expected:* Only selected products should be displayed in the cart summary > section -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11219) Issue with check box functionality on show cart page
[ https://issues.apache.org/jira/browse/OFBIZ-11219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-11219: Assignee: Amit Gadaley > Issue with check box functionality on show cart page > > > Key: OFBIZ-11219 > URL: https://issues.apache.org/jira/browse/OFBIZ-11219 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Vedansh Tiwari >Assignee: Amit Gadaley >Priority: Major > > *Steps to regenerate:* > 1. Open [URL https://demo-trunk.ofbiz.apache.org|http://example.com] > 2. Login with valid ID and password > 3. Add the at least 4-5 product into the cart > 4. Click on the "View Cart" link > 5. Select the checkbox of only 2 products on the show cart page > 6. Click on the "Checkout" button > *Actual:* All products are displaying in the cart summary section, after > selecting only 2 products > *Expected:* Only selected products should be displayed in the cart summary > section -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10891) Send me this every month link is not working in order items section.
[ https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939906#comment-16939906 ] Amit Gadaley commented on OFBIZ-10891: -- Provided patch. Thanks, [~ashish.sharma] for reporting this issue. > Send me this every month link is not working in order items section. > > > Key: OFBIZ-10891 > URL: https://issues.apache.org/jira/browse/OFBIZ-10891 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Amit Gadaley >Priority: Minor > Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, > OFBIZ-10891.png > > > *Steps to Reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Place a order. > 4. Navigate to order history and click on view link. > 5. Click on link “send me this every month” in order items section. > *Actual Result:* Error message is displayed. > *Screen print attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10891) Send me this every month link is not working in order items section.
[ https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10891: - Attachment: OFBIZ-10891.patch > Send me this every month link is not working in order items section. > > > Key: OFBIZ-10891 > URL: https://issues.apache.org/jira/browse/OFBIZ-10891 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Amit Gadaley >Priority: Minor > Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, > OFBIZ-10891.png > > > *Steps to Reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Place a order. > 4. Navigate to order history and click on view link. > 5. Click on link “send me this every month” in order items section. > *Actual Result:* Error message is displayed. > *Screen print attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10891) Send me this every month link is not working in order items section.
[ https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-10891: Assignee: Amit Gadaley (was: vivek singh bisen) > Send me this every month link is not working in order items section. > > > Key: OFBIZ-10891 > URL: https://issues.apache.org/jira/browse/OFBIZ-10891 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Amit Gadaley >Priority: Minor > Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.png > > > *Steps to Reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Place a order. > 4. Navigate to order history and click on view link. > 5. Click on link “send me this every month” in order items section. > *Actual Result:* Error message is displayed. > *Screen print attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-11185: Assignee: Amit Gadaley > OrderReadHelper.getAvailableOrderHeaderAdjustments improvements > --- > > Key: OFBIZ-11185 > URL: https://issues.apache.org/jira/browse/OFBIZ-11185 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Amit Gadaley >Priority: Major > > We have a helper method in OrderReadHelper named as > getAvailableOrderHeaderAdjustments which is used to fetch order header > adjustments available for return. > It should also check for amount, it might possible, orderHeader adjustment > was of $100 and once a return is created for $20, then available $80 would > not render while creating second return for the same order. > So instead of checking only for orderAdjustmentId in ReturnAdjustment, it > should also check for adjustment amount. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11063) Some items showing price values upto 3 precision
[ https://issues.apache.org/jira/browse/OFBIZ-11063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914894#comment-16914894 ] Amit Gadaley commented on OFBIZ-11063: -- Hello [~padma.rawat], I don't think this is a bug. There is no rounding throughout the framework. If we do rounding for this particular case then we have to make sure that this rounding used at everywhere. > Some items showing price values upto 3 precision > > > Key: OFBIZ-11063 > URL: https://issues.apache.org/jira/browse/OFBIZ-11063 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > Attachments: decimalplace.png > > > Steps: > 1. Visit the e-commerce page of the trunk. > 2. Add .NIT Gismo product into the cart. > https://demo-trunk.ofbiz.apache.org/ecommerce/dot-net-gismo-GZ-1005-p > 3. Now check the applied adjustment on the corresponding product. > Actual: > Three decimal place values showing in the applied adjustment values. > Expected: > Values should be two decimal places throughout. > Please refer screenshot: -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (OFBIZ-11063) Some items showing price values upto 3 precision
[ https://issues.apache.org/jira/browse/OFBIZ-11063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-11063: Assignee: Amit Gadaley (was: Ayushi Rathod) > Some items showing price values upto 3 precision > > > Key: OFBIZ-11063 > URL: https://issues.apache.org/jira/browse/OFBIZ-11063 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > Attachments: decimalplace.png > > > Steps: > 1. Visit the e-commerce page of the trunk. > 2. Add .NIT Gismo product into the cart. > https://demo-trunk.ofbiz.apache.org/ecommerce/dot-net-gismo-GZ-1005-p > 3. Now check the applied adjustment on the corresponding product. > Actual: > Three decimal place values showing in the applied adjustment values. > Expected: > Values should be two decimal places throughout. > Please refer screenshot: -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Closed] (OFBIZ-9163) Purchase Invoice - Sales Tax & Accounting transaction
[ https://issues.apache.org/jira/browse/OFBIZ-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley closed OFBIZ-9163. --- Resolution: Fixed Fix Version/s: Trunk > Purchase Invoice - Sales Tax & Accounting transaction > -- > > Key: OFBIZ-9163 > URL: https://issues.apache.org/jira/browse/OFBIZ-9163 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Release Branch 16.11 > Environment: Windows 10, demo data >Reporter: Tyrone Winn >Assignee: Amit Gadaley >Priority: Minor > Fix For: Trunk > > > When posting the accounting transactions for purchase invoices with tax the > journal is suspended as does not balance. (using demo data) > The process is: > 1. Create new invoice from "BigSupplier" > 2. Choose product "GZ-1006-1" and add a quantity and amount > 3. Click "Add Tax" > 4. Status to Approved > 5. Status to Ready > It would seem the creditors amount does not increase with the value of the > tax. > In looking at the service "createAcctgTransForPurchaseInvoice" in the > following file: > applications\accounting\minilang\ledger\GeneralLedgerServices.xml > it seems to be missing a call to the method "getInvoiceTaxTotal" when > compared to the "createAcctgTransForSalesInvoice" service. > When adding this to the "createAcctgTransForPurchaseInvoice" it works as > expected. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-9163) Purchase Invoice - Sales Tax & Accounting transaction
[ https://issues.apache.org/jira/browse/OFBIZ-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894304#comment-16894304 ] Amit Gadaley commented on OFBIZ-9163: - Closing this bug as it has been fixed. > Purchase Invoice - Sales Tax & Accounting transaction > -- > > Key: OFBIZ-9163 > URL: https://issues.apache.org/jira/browse/OFBIZ-9163 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Release Branch 16.11 > Environment: Windows 10, demo data >Reporter: Tyrone Winn >Assignee: Amit Gadaley >Priority: Minor > > When posting the accounting transactions for purchase invoices with tax the > journal is suspended as does not balance. (using demo data) > The process is: > 1. Create new invoice from "BigSupplier" > 2. Choose product "GZ-1006-1" and add a quantity and amount > 3. Click "Add Tax" > 4. Status to Approved > 5. Status to Ready > It would seem the creditors amount does not increase with the value of the > tax. > In looking at the service "createAcctgTransForPurchaseInvoice" in the > following file: > applications\accounting\minilang\ledger\GeneralLedgerServices.xml > it seems to be missing a call to the method "getInvoiceTaxTotal" when > compared to the "createAcctgTransForSalesInvoice" service. > When adding this to the "createAcctgTransForPurchaseInvoice" it works as > expected. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (OFBIZ-9163) Purchase Invoice - Sales Tax & Accounting transaction
[ https://issues.apache.org/jira/browse/OFBIZ-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-9163: --- Assignee: Amit Gadaley > Purchase Invoice - Sales Tax & Accounting transaction > -- > > Key: OFBIZ-9163 > URL: https://issues.apache.org/jira/browse/OFBIZ-9163 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Release Branch 16.11 > Environment: Windows 10, demo data >Reporter: Tyrone Winn >Assignee: Amit Gadaley >Priority: Minor > > When posting the accounting transactions for purchase invoices with tax the > journal is suspended as does not balance. (using demo data) > The process is: > 1. Create new invoice from "BigSupplier" > 2. Choose product "GZ-1006-1" and add a quantity and amount > 3. Click "Add Tax" > 4. Status to Approved > 5. Status to Ready > It would seem the creditors amount does not increase with the value of the > tax. > In looking at the service "createAcctgTransForPurchaseInvoice" in the > following file: > applications\accounting\minilang\ledger\GeneralLedgerServices.xml > it seems to be missing a call to the method "getInvoiceTaxTotal" when > compared to the "createAcctgTransForSalesInvoice" service. > When adding this to the "createAcctgTransForPurchaseInvoice" it works as > expected. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (OFBIZ-7377) Introduce the option for specifying Check (Reference) Number upon using Check as payment method during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-7377: --- Assignee: Amit Gadaley > Introduce the option for specifying Check (Reference) Number upon using Check > as payment method during ordering > --- > > Key: OFBIZ-7377 > URL: https://issues.apache.org/jira/browse/OFBIZ-7377 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Swapnil Shah >Assignee: Amit Gadaley >Priority: Major > Attachments: OrdPmt.png > > > Currently there is no option during ordering to specify the actual Check > Number that could be used for making payment upon selecting Check as payment > method. > We could provide a text entry box for recording check number and same could > be set as Payment.PaymentRefNumber upon order creation. > Please refer to attached screenshot -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894286#comment-16894286 ] Amit Gadaley commented on OFBIZ-11127: -- Provided updated patch. Thanks [~pawan.verma] for your inputs. > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at > some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-11127: - Attachment: (was: OFBIZ-11127.patch) > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at > some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-11127: - Attachment: OFBIZ-11127.patch > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at > some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-11127: - Attachment: OFBIZ-11127.patch > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Minor > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at > some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873862#comment-16873862 ] Amit Gadaley commented on OFBIZ-11127: -- Provided patch. > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Minor > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at > some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
Amit Gadaley created OFBIZ-11127: Summary: Code improvement in ShoppingCartEvents.java Key: OFBIZ-11127 URL: https://issues.apache.org/jira/browse/OFBIZ-11127 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Amit Gadaley Assignee: Amit Gadaley Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at some places in ShoppingCartEvents class. It should be called by following below syntax: getCartObject(parameters); But, at some places, it is called incorrectly like this: ShoppingCartEvents.getCartObject(parameters) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10538) Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity
[ https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870151#comment-16870151 ] Amit Gadaley commented on OFBIZ-10538: -- Attached patch. Thanks, [~deepak.nigam] Sir for the guidance. > Promised Datetime & Current Promised Date values not getting updated in > OISGIR Entity > - > > Key: OFBIZ-10538 > URL: https://issues.apache.org/jira/browse/OFBIZ-10538 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Amit Gadaley >Priority: Major > Attachments: OFBIZ-10538.patch > > > While creating the sales order from the backend, if we set the 'Ship Before > Date' it will be stored in OrderItemShipGroup.shipByDate field and same will > be propagated to OrderItemShipGrpInvRes.promisedDateTime and > OrderItemShipGrpInvRes.currentPromisedDate fields. > > On updating the 'Ship Before Date' from the order view page later, the > promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup > entity but remains the same in OrderItemShipGroupInvRes entity. > > As OrderItemShipGrpInvRes.promisedDateTime & > OrderItemShipGrpInvRes.currentPromisedDate are being used in many services > like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity', > 'reserveProductInventory' etc., we should also update these on updating the > 'Ship Before Date' from the order overview page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10538) Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity
[ https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10538: - Attachment: OFBIZ-10538.patch > Promised Datetime & Current Promised Date values not getting updated in > OISGIR Entity > - > > Key: OFBIZ-10538 > URL: https://issues.apache.org/jira/browse/OFBIZ-10538 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Amit Gadaley >Priority: Major > Attachments: OFBIZ-10538.patch > > > While creating the sales order from the backend, if we set the 'Ship Before > Date' it will be stored in OrderItemShipGroup.shipByDate field and same will > be propagated to OrderItemShipGrpInvRes.promisedDateTime and > OrderItemShipGrpInvRes.currentPromisedDate fields. > > On updating the 'Ship Before Date' from the order view page later, the > promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup > entity but remains the same in OrderItemShipGroupInvRes entity. > > As OrderItemShipGrpInvRes.promisedDateTime & > OrderItemShipGrpInvRes.currentPromisedDate are being used in many services > like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity', > 'reserveProductInventory' etc., we should also update these on updating the > 'Ship Before Date' from the order overview page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10538) Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity
[ https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-10538: Assignee: Amit Gadaley > Promised Datetime & Current Promised Date values not getting updated in > OISGIR Entity > - > > Key: OFBIZ-10538 > URL: https://issues.apache.org/jira/browse/OFBIZ-10538 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Amit Gadaley >Priority: Major > > While creating the sales order from the backend, if we set the 'Ship Before > Date' it will be stored in OrderItemShipGroup.shipByDate field and same will > be propagated to OrderItemShipGrpInvRes.promisedDateTime and > OrderItemShipGrpInvRes.currentPromisedDate fields. > > On updating the 'Ship Before Date' from the order view page later, the > promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup > entity but remains the same in OrderItemShipGroupInvRes entity. > > As OrderItemShipGrpInvRes.promisedDateTime & > OrderItemShipGrpInvRes.currentPromisedDate are being used in many services > like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity', > 'reserveProductInventory' etc., we should also update these on updating the > 'Ship Before Date' from the order overview page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10742) Survey form does not appears when survey product added to an order
[ https://issues.apache.org/jira/browse/OFBIZ-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley closed OFBIZ-10742. Resolution: Cannot Reproduce > Survey form does not appears when survey product added to an order > -- > > Key: OFBIZ-10742 > URL: https://issues.apache.org/jira/browse/OFBIZ-10742 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > > Survey form does not appear when survey product added to an order. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10733) HTML Code is rendering in Sales Invoice
[ https://issues.apache.org/jira/browse/OFBIZ-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-10733: Assignee: Sanjay Yadav (was: Amit Gadaley) > HTML Code is rendering in Sales Invoice > --- > > Key: OFBIZ-10733 > URL: https://issues.apache.org/jira/browse/OFBIZ-10733 > Project: OFBiz > Issue Type: Bug > Components: accounting > Environment: demo-trunk >Reporter: Sanjay Yadav >Assignee: Sanjay Yadav >Priority: Major > Attachments: InvoiceWithHtmlCode.pdf > > > Steps to regenerate issue - > # Go to Url - > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10002] > # Invoice section > # Click PDF button > Actual - Opened a Sales Invoice with HTML code > Expected - HTML code should not display in the invoice. Please refer > attachment for quick review. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10735) Unable to add survey product to cart in order entry form
[ https://issues.apache.org/jira/browse/OFBIZ-10735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805643#comment-16805643 ] Amit Gadaley commented on OFBIZ-10735: -- Hello [~suraj.khurana] , I have added the affected versions to the details section. FYI It is working fine in release 16. > Unable to add survey product to cart in order entry form > > > Key: OFBIZ-10735 > URL: https://issues.apache.org/jira/browse/OFBIZ-10735 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10735.patch > > > When a survey product added to cart, system return error "No product > information passed, not adding anything to cart.". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10735) Unable to add survey product to cart in order entry form
[ https://issues.apache.org/jira/browse/OFBIZ-10735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10735: - Affects Version/s: Release Branch 18.12 Release Branch 17.12 > Unable to add survey product to cart in order entry form > > > Key: OFBIZ-10735 > URL: https://issues.apache.org/jira/browse/OFBIZ-10735 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10735.patch > > > When a survey product added to cart, system return error "No product > information passed, not adding anything to cart.". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10403) Multiple services for checking party permissions
[ https://issues.apache.org/jira/browse/OFBIZ-10403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-10403: Assignee: Amit Gadaley > Multiple services for checking party permissions > > > Key: OFBIZ-10403 > URL: https://issues.apache.org/jira/browse/OFBIZ-10403 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Amit Gadaley >Priority: Major > > Found two different services for check party permission: > *ServiceUtil.java* has _getPartyIdCheckSecurity_ > *PartyPermissionServices.xml* has _partyIdPermissionCheck_ > _getPartyIdCheckSecurity_ can be deleted as it is not in proper place and > some enhancements (check admin permission) could be done in > _partyIdPermissionCheck_ so that single permission service could be used for > partyId permission checking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10733) HTML Code is rendering in Sales Invoice
[ https://issues.apache.org/jira/browse/OFBIZ-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-10733: Assignee: Amit Gadaley > HTML Code is rendering in Sales Invoice > --- > > Key: OFBIZ-10733 > URL: https://issues.apache.org/jira/browse/OFBIZ-10733 > Project: OFBiz > Issue Type: Bug > Components: accounting > Environment: demo-trunk >Reporter: Sanjay Yadav >Assignee: Amit Gadaley >Priority: Major > Attachments: InvoiceWithHtmlCode.pdf > > > Steps to regenerate issue - > # Go to Url - > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10002] > # Invoice section > # Click PDF button > Actual - Opened a Sales Invoice with HTML code > Expected - HTML code should not display in the invoice. Please refer > attachment for quick review. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10747) Update "convertUom" service, give priority to 'UomConversionDated' entity to fetch conversion factor
[ https://issues.apache.org/jira/browse/OFBIZ-10747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10747: - Issue Type: Improvement (was: Bug) > Update "convertUom" service, give priority to 'UomConversionDated' entity to > fetch conversion factor > > > Key: OFBIZ-10747 > URL: https://issues.apache.org/jira/browse/OFBIZ-10747 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Suraj Khurana >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10747.patch > > > Update "convertUom" service. Use first 'UomConversionDated' entity to fetch > conversion factor, if the factor is not available then use 'UomConversion' > entity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10727: - Attachment: (was: OFBIZ-10727.patch) > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10727.patch > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741012#comment-16741012 ] Amit Gadaley commented on OFBIZ-10727: -- Added updated patch. Thanks [~jacopoc] for the help. > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10727.patch > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10727: - Attachment: OFBIZ-10727.patch > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10727.patch > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10747) Update "convertUom" service, give priority to 'UomConversionDated' entity to fetch conversion factor
[ https://issues.apache.org/jira/browse/OFBIZ-10747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727375#comment-16727375 ] Amit Gadaley commented on OFBIZ-10747: -- Provided patch. Thanks [~jacopoc] for the guidance. > Update "convertUom" service, give priority to 'UomConversionDated' entity to > fetch conversion factor > > > Key: OFBIZ-10747 > URL: https://issues.apache.org/jira/browse/OFBIZ-10747 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10747.patch > > > Update "convertUom" service. Use first 'UomConversionDated' entity to fetch > conversion factor, if the factor is not available then use 'UomConversion' > entity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10747) Update "convertUom" service, give priority to 'UomConversionDated' entity to fetch conversion factor
[ https://issues.apache.org/jira/browse/OFBIZ-10747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10747: - Attachment: OFBIZ-10747.patch > Update "convertUom" service, give priority to 'UomConversionDated' entity to > fetch conversion factor > > > Key: OFBIZ-10747 > URL: https://issues.apache.org/jira/browse/OFBIZ-10747 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10747.patch > > > Update "convertUom" service. Use first 'UomConversionDated' entity to fetch > conversion factor, if the factor is not available then use 'UomConversion' > entity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10747) Update "convertUom" service, give priority to 'UomConversionDated' entity to fetch conversion factor
Amit Gadaley created OFBIZ-10747: Summary: Update "convertUom" service, give priority to 'UomConversionDated' entity to fetch conversion factor Key: OFBIZ-10747 URL: https://issues.apache.org/jira/browse/OFBIZ-10747 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Trunk Reporter: Amit Gadaley Assignee: Amit Gadaley Fix For: Trunk Update "convertUom" service. Use first 'UomConversionDated' entity to fetch conversion factor, if the factor is not available then use 'UomConversion' entity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10727: - Attachment: OFBIZ-10727.patch > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10727.patch > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727358#comment-16727358 ] Amit Gadaley commented on OFBIZ-10727: -- Provided updated patch. > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10727.patch > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10727: - Attachment: (was: OFBIZ-10727.patch) > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10742) Survey form does not appears when survey product added to an order
Amit Gadaley created OFBIZ-10742: Summary: Survey form does not appears when survey product added to an order Key: OFBIZ-10742 URL: https://issues.apache.org/jira/browse/OFBIZ-10742 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Amit Gadaley Assignee: Amit Gadaley Fix For: Trunk Survey form does not appear when survey product added to an order. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10735) Unable to add survey product to cart in order entry form
[ https://issues.apache.org/jira/browse/OFBIZ-10735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727332#comment-16727332 ] Amit Gadaley commented on OFBIZ-10735: -- Provided patch. Thanks [~deepakddixit] for the guidance. > Unable to add survey product to cart in order entry form > > > Key: OFBIZ-10735 > URL: https://issues.apache.org/jira/browse/OFBIZ-10735 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10735.patch > > > When a survey product added to cart, system return error "No product > information passed, not adding anything to cart.". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10735) Unable to add survey product to cart in order entry form
[ https://issues.apache.org/jira/browse/OFBIZ-10735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10735: - Attachment: OFBIZ-10735.patch > Unable to add survey product to cart in order entry form > > > Key: OFBIZ-10735 > URL: https://issues.apache.org/jira/browse/OFBIZ-10735 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10735.patch > > > When a survey product added to cart, system return error "No product > information passed, not adding anything to cart.". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10735) Unable to add survey product to cart in order entry form
Amit Gadaley created OFBIZ-10735: Summary: Unable to add survey product to cart in order entry form Key: OFBIZ-10735 URL: https://issues.apache.org/jira/browse/OFBIZ-10735 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Amit Gadaley Assignee: Amit Gadaley Fix For: Trunk When a survey product added to cart, system return error "No product information passed, not adding anything to cart.". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727249#comment-16727249 ] Amit Gadaley edited comment on OFBIZ-10727 at 12/22/18 6:20 AM: Provided patch. Thanks [~jacopoc] for the guidance. was (Author: amit.gadaley): Provided patch. Thanks, [~jacopoc] for the guidance. > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10727.patch > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727249#comment-16727249 ] Amit Gadaley commented on OFBIZ-10727: -- Provided patch. Thanks, [~jacopoc] for the guidance. > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10727.patch > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10727: - Attachment: OFBIZ-10727.patch > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10727.patch > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10727: - Description: Service failed to mark expired authorized payments of Authorize.net as void (was: OOTB OFBiz failed to mark expired authorized payments of Authorize.net as void. ) > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > > Service failed to mark expired authorized payments of Authorize.net as void -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void
[ https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10727: - Summary: Service failed to mark expired authorized payments of Authorize.net as void (was: OOTB OFBiz failed to mark expired authorized payments of Authorize.net as void) > Service failed to mark expired authorized payments of Authorize.net as void > --- > > Key: OFBIZ-10727 > URL: https://issues.apache.org/jira/browse/OFBIZ-10727 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.01, Release Branch 16.11 >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > > OOTB OFBiz failed to mark expired authorized payments of Authorize.net as > void. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10727) OOTB OFBiz failed to mark expired authorized payments of Authorize.net as void
Amit Gadaley created OFBIZ-10727: Summary: OOTB OFBiz failed to mark expired authorized payments of Authorize.net as void Key: OFBIZ-10727 URL: https://issues.apache.org/jira/browse/OFBIZ-10727 Project: OFBiz Issue Type: Bug Affects Versions: Release Branch 16.11, Trunk, 17.12.01 Reporter: Amit Gadaley Assignee: Amit Gadaley Fix For: Trunk OOTB OFBiz failed to mark expired authorized payments of Authorize.net as void. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9864) Label manager gives no results for All Components
[ https://issues.apache.org/jira/browse/OFBIZ-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-9864: --- Assignee: Amit Gadaley > Label manager gives no results for All Components > - > > Key: OFBIZ-9864 > URL: https://issues.apache.org/jira/browse/OFBIZ-9864 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Aditya Sharma >Assignee: Amit Gadaley >Priority: Minor > > Steps to regenerate: > 1. Go to Webtools (https://demo-trunk.ofbiz.apache.org/webtools/control/main) > 2. Click on ArtifactInfo tab > (https://demo-trunk.ofbiz.apache.org/webtools/control/ViewComponents) > 3. Click on Label Manager subtab > (https://demo-trunk.ofbiz.apache.org/webtools/control/SearchLabels) > Click on Find button with Component Name value as All Components. > It shows 0 results. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9921) Payment transactions should use company currency
[ https://issues.apache.org/jira/browse/OFBIZ-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-9921: --- Assignee: Akshay Modak (was: Amit Gadaley) > Payment transactions should use company currency > > > Key: OFBIZ-9921 > URL: https://issues.apache.org/jira/browse/OFBIZ-9921 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Akshay Modak >Priority: Minor > > In case of multi-currency, payment transactions posted in company currency > for purchase order (PO) and customer currency for sales order (SO). For > consistency, payment transactions should be posted in company currency for > SO. For more detail, http://markmail.org/message/klrnzkpvcr2mk33l -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9921) Payment transactions should use company currency
[ https://issues.apache.org/jira/browse/OFBIZ-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-9921: --- Assignee: Amit Gadaley (was: Akshay Modak) > Payment transactions should use company currency > > > Key: OFBIZ-9921 > URL: https://issues.apache.org/jira/browse/OFBIZ-9921 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Amit Gadaley >Priority: Minor > > In case of multi-currency, payment transactions posted in company currency > for purchase order (PO) and customer currency for sales order (SO). For > consistency, payment transactions should be posted in company currency for > SO. For more detail, http://markmail.org/message/klrnzkpvcr2mk33l -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10009) Issue with Invoices created against returns of 'replacement' type items
[ https://issues.apache.org/jira/browse/OFBIZ-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley closed OFBIZ-10009. Resolution: Invalid > Issue with Invoices created against returns of 'replacement' type items > - > > Key: OFBIZ-10009 > URL: https://issues.apache.org/jira/browse/OFBIZ-10009 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > > In RMA process, there are two types of return items i.e. Refund and > Replacement. Actually, there are few more types but consider these two to > focus on the actual problem. > CASE 1: Create return with return items of type 'Refund'. When return is > received, an invoice is created to refund to the customer. > Issue: No Issue > CASE 2: Create return with return items of type 'Replacement'. When return is > received, a sales order with order total zero ($ 0) is created against > return. And, can be processed as usual. > Issue: An Invoice is created against the return. I think it should not be > created as an order is already created in replacement of received items. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-9913) Payment capturing twice on single action
[ https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley resolved OFBIZ-9913. - Resolution: Cannot Reproduce Fix Version/s: Trunk > Payment capturing twice on single action > > > Key: OFBIZ-9913 > URL: https://issues.apache.org/jira/browse/OFBIZ-9913 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > > Steps: > 1. Navigate order component. > 2. Set customer and select product for the order. > 3. Set payment method ( Credit Card and EFT Account ) and shipping method > for the corresponding order. > 4. Create an order. > 5. Captured amount in associated payment method. > Actual: > Payment capturing twice on single action on view order screen. > Expected: > Payment should captured single time on single action. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-6932) In the case of MARKETING_PKG_PICK the invoice gets created of product components, Ideally the invoice should be created of package.
[ https://issues.apache.org/jira/browse/OFBIZ-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley resolved OFBIZ-6932. - Resolution: Pending Closed Fix Version/s: Trunk Waiting for others to close this ticket. > In the case of MARKETING_PKG_PICK the invoice gets created of product > components, Ideally the invoice should be created of package. > --- > > Key: OFBIZ-6932 > URL: https://issues.apache.org/jira/browse/OFBIZ-6932 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > > Steps to reproduce: > 1. Create sales order with MARKETING_PKG_PICK. > 2. Completed the order with its shipment. > 3. Invoice should be created. > Actual: Invoice created with its components. > Expected: Invoice should be created for its package. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6932) In the case of MARKETING_PKG_PICK the invoice gets created of product components, Ideally the invoice should be created of package.
[ https://issues.apache.org/jira/browse/OFBIZ-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697666#comment-16697666 ] Amit Gadaley commented on OFBIZ-6932: - Reviewed the order fulfillment and invoice creation processes for pick type of kit products. It is working as expected. Invoice is created for pick type of kit products, not for its components. > In the case of MARKETING_PKG_PICK the invoice gets created of product > components, Ideally the invoice should be created of package. > --- > > Key: OFBIZ-6932 > URL: https://issues.apache.org/jira/browse/OFBIZ-6932 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Amit Gadaley >Priority: Major > > Steps to reproduce: > 1. Create sales order with MARKETING_PKG_PICK. > 2. Completed the order with its shipment. > 3. Invoice should be created. > Actual: Invoice created with its components. > Expected: Invoice should be created for its package. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-6932) In the case of MARKETING_PKG_PICK the invoice gets created of product components, Ideally the invoice should be created of package.
[ https://issues.apache.org/jira/browse/OFBIZ-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-6932: --- Assignee: Amit Gadaley > In the case of MARKETING_PKG_PICK the invoice gets created of product > components, Ideally the invoice should be created of package. > --- > > Key: OFBIZ-6932 > URL: https://issues.apache.org/jira/browse/OFBIZ-6932 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Amit Gadaley >Priority: Major > > Steps to reproduce: > 1. Create sales order with MARKETING_PKG_PICK. > 2. Completed the order with its shipment. > 3. Invoice should be created. > Actual: Invoice created with its components. > Expected: Invoice should be created for its package. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9912) Force complete Purchase Order button throws error
[ https://issues.apache.org/jira/browse/OFBIZ-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1063#comment-1063 ] Amit Gadaley commented on OFBIZ-9912: - Provided patch. Thanks, [~mridul.pathak] for guidance. > Force complete Purchase Order button throws error > - > > Key: OFBIZ-9912 > URL: https://issues.apache.org/jira/browse/OFBIZ-9912 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/facility >Reporter: Priya Sharma >Assignee: Amit Gadaley >Priority: Major > Attachments: Force-receive-PO.png, OFBIZ-9912.patch > > > 1) Create a Purchase order. > 2) Create shipment for it. > 3) Click on receive against PO button > [https://demo-trunk.ofbiz.apache.org/facility/control/ReceiveInventoryAgainstPurchaseOrder?shipmentId=10024&purchaseOrderId=10040] > 4) Click on the force complete PO button, error is thrown. > [https://demo-trunk.ofbiz.apache.org/facility/control/completePurchaseOrder?orderId=10040&facilityId=WebStoreWarehouse&shipmentId=10024] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9912) Force complete Purchase Order button throws error
[ https://issues.apache.org/jira/browse/OFBIZ-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-9912: Attachment: OFBIZ-9912.patch > Force complete Purchase Order button throws error > - > > Key: OFBIZ-9912 > URL: https://issues.apache.org/jira/browse/OFBIZ-9912 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/facility >Reporter: Priya Sharma >Assignee: Amit Gadaley >Priority: Major > Attachments: Force-receive-PO.png, OFBIZ-9912.patch > > > 1) Create a Purchase order. > 2) Create shipment for it. > 3) Click on receive against PO button > [https://demo-trunk.ofbiz.apache.org/facility/control/ReceiveInventoryAgainstPurchaseOrder?shipmentId=10024&purchaseOrderId=10040] > 4) Click on the force complete PO button, error is thrown. > [https://demo-trunk.ofbiz.apache.org/facility/control/completePurchaseOrder?orderId=10040&facilityId=WebStoreWarehouse&shipmentId=10024] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9912) Force complete Purchase Order button throws error
[ https://issues.apache.org/jira/browse/OFBIZ-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-9912: --- Assignee: Amit Gadaley > Force complete Purchase Order button throws error > - > > Key: OFBIZ-9912 > URL: https://issues.apache.org/jira/browse/OFBIZ-9912 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/facility >Reporter: Priya Sharma >Assignee: Amit Gadaley >Priority: Major > Attachments: Force-receive-PO.png > > > 1) Create a Purchase order. > 2) Create shipment for it. > 3) Click on receive against PO button > [https://demo-trunk.ofbiz.apache.org/facility/control/ReceiveInventoryAgainstPurchaseOrder?shipmentId=10024&purchaseOrderId=10040] > 4) Click on the force complete PO button, error is thrown. > [https://demo-trunk.ofbiz.apache.org/facility/control/completePurchaseOrder?orderId=10040&facilityId=WebStoreWarehouse&shipmentId=10024] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9913) Payment capturing twice on single action
[ https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624636#comment-16624636 ] Amit Gadaley commented on OFBIZ-9913: - Hello [~padma.rawat] , It is working fine on OFBiz trunk. Could you please verify it or share the version details on which this issue occurred. > Payment capturing twice on single action > > > Key: OFBIZ-9913 > URL: https://issues.apache.org/jira/browse/OFBIZ-9913 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > > Steps: > 1. Navigate order component. > 2. Set customer and select product for the order. > 3. Set payment method ( Credit Card and EFT Account ) and shipping method > for the corresponding order. > 4. Create an order. > 5. Captured amount in associated payment method. > Actual: > Payment capturing twice on single action on view order screen. > Expected: > Payment should captured single time on single action. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9913) Payment capturing twice on single action
[ https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-9913: --- Assignee: Amit Gadaley > Payment capturing twice on single action > > > Key: OFBIZ-9913 > URL: https://issues.apache.org/jira/browse/OFBIZ-9913 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > > Steps: > 1. Navigate order component. > 2. Set customer and select product for the order. > 3. Set payment method ( Credit Card and EFT Account ) and shipping method > for the corresponding order. > 4. Create an order. > 5. Captured amount in associated payment method. > Actual: > Payment capturing twice on single action on view order screen. > Expected: > Payment should captured single time on single action. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10236) UI Issue with Status ID at Parties page
[ https://issues.apache.org/jira/browse/OFBIZ-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley closed OFBIZ-10236. Resolution: Not A Bug > UI Issue with Status ID at Parties page > --- > > Key: OFBIZ-10236 > URL: https://issues.apache.org/jira/browse/OFBIZ-10236 > Project: OFBiz > Issue Type: Bug > Components: party > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Assignee: Amit Gadaley >Priority: Trivial > Attachments: Enabled.png > > > Steps: > # Open URL > [https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?partyId=BLOGUSER_GUEST] > # Navigate to Status Id drop-down > # Check for Enabled > Actual: Displaying Enabled twice in drop-down section, Kindly refer > attachment for same. Thanks! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10236) UI Issue with Status ID at Parties page
[ https://issues.apache.org/jira/browse/OFBIZ-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624626#comment-16624626 ] Amit Gadaley commented on OFBIZ-10236: -- This is not an issue. It is OOTB OFBiz behavior. Hence closing it. > UI Issue with Status ID at Parties page > --- > > Key: OFBIZ-10236 > URL: https://issues.apache.org/jira/browse/OFBIZ-10236 > Project: OFBiz > Issue Type: Bug > Components: party > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Assignee: Amit Gadaley >Priority: Trivial > Attachments: Enabled.png > > > Steps: > # Open URL > [https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?partyId=BLOGUSER_GUEST] > # Navigate to Status Id drop-down > # Check for Enabled > Actual: Displaying Enabled twice in drop-down section, Kindly refer > attachment for same. Thanks! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10236) UI Issue with Status ID at Parties page
[ https://issues.apache.org/jira/browse/OFBIZ-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-10236: Assignee: Amit Gadaley > UI Issue with Status ID at Parties page > --- > > Key: OFBIZ-10236 > URL: https://issues.apache.org/jira/browse/OFBIZ-10236 > Project: OFBiz > Issue Type: Bug > Components: party > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Assignee: Amit Gadaley >Priority: Trivial > Attachments: Enabled.png > > > Steps: > # Open URL > [https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?partyId=BLOGUSER_GUEST] > # Navigate to Status Id drop-down > # Check for Enabled > Actual: Displaying Enabled twice in drop-down section, Kindly refer > attachment for same. Thanks! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624544#comment-16624544 ] Amit Gadaley commented on OFBIZ-9761: - Hi [~arunpati] I have provided the patch for release OFBIZ.16.11. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Labels: backport-needed > Fix For: Trunk > > Attachments: OFBIZ-9761-16.11.patch, OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-9761: Attachment: OFBIZ-9761-16.11.patch > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Labels: backport-needed > Fix For: Trunk > > Attachments: OFBIZ-9761-16.11.patch, OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10496) Defective inventories are valuating in Inventory valuation report
[ https://issues.apache.org/jira/browse/OFBIZ-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10496: - Attachment: (was: OFBIZ-10496.patch) > Defective inventories are valuating in Inventory valuation report > -- > > Key: OFBIZ-10496 > URL: https://issues.apache.org/jira/browse/OFBIZ-10496 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10496.patch > > > Inventory items with status 'INV_NS_DEFECTIVE' and 'INV_DEFECTIVE' are also > included in the inventory valuation report. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10496) Defective inventories are valuating in Inventory valuation report
[ https://issues.apache.org/jira/browse/OFBIZ-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-10496: - Attachment: OFBIZ-10496.patch > Defective inventories are valuating in Inventory valuation report > -- > > Key: OFBIZ-10496 > URL: https://issues.apache.org/jira/browse/OFBIZ-10496 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10496.patch > > > Inventory items with status 'INV_NS_DEFECTIVE' and 'INV_DEFECTIVE' are also > included in the inventory valuation report. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
