[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount
[ https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850721#comment-17850721 ] ASF subversion and git services commented on OFBIZ-13068: - Commit a7afe3ccbd2ce69253fcacca0d8a34c1ec14b4bf in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a7afe3ccbd ] Fixed: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId (OFBIZ-13068) Thanks to Deepak's review (much appreciated see https://lists.apache.org/thread/94xw3rpdr0o44n6sd2s7m250joy4c7q6) this improves previous commit (6718c46) This also removes few trailing blanks (Eclipse automation) > Accounts Payable Past Due Invoices doesn't show outstanding amount > -- > > Key: OFBIZ-13068 > URL: https://issues.apache.org/jira/browse/OFBIZ-13068 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: Image 016.png, Screenshot 2024-04-29 at 11.52.07.png, > image-2024-04-29-09-05-28-760.png > > > With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d > [ec0adc02f1] the field outstanding got replaced with amountToApply in grid > ListApReport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount
[ https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850659#comment-17850659 ] ASF subversion and git services commented on OFBIZ-13068: - Commit 6718c4645dba7195317de3084cf2a24116f7dfdc in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6718c4645d ] Fixed: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId (OFBIZ-13068) This fixes an old bug (at least 8 years) > Accounts Payable Past Due Invoices doesn't show outstanding amount > -- > > Key: OFBIZ-13068 > URL: https://issues.apache.org/jira/browse/OFBIZ-13068 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: Image 016.png, Screenshot 2024-04-29 at 11.52.07.png, > image-2024-04-29-09-05-28-760.png > > > With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d > [ec0adc02f1] the field outstanding got replaced with amountToApply in grid > ListApReport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13100) LInk to supplier in Accounting Main does not show PartyFinancialHistory
[ https://issues.apache.org/jira/browse/OFBIZ-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850650#comment-17850650 ] ASF subversion and git services commented on OFBIZ-13100: - Commit 68062ae6d30ff9e55ec867f3ff3400c307811d9f in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=68062ae6d3 ] Fixed: Link to supplier in Accounting Main does not show PartyFinancialHistory (OFBIZ-13100) Fixes a missing from-field in a hyperlink > LInk to supplier in Accounting Main does not show PartyFinancialHistory > --- > > Key: OFBIZ-13100 > URL: https://issues.apache.org/jira/browse/OFBIZ-13100 > Project: OFBiz > Issue Type: Bug >Reporter: Pierre Smits >Priority: Major > > When accessing the link to the PartyFinancialHistory screen of the supplier > in > [https://demo-trunk.ofbiz.apache.org/accounting/control/main|https://demo-trunk.ofbiz.apache.org/accounting/control/main,] > the resulting PartyFinancialHistory in partymgr shows no data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount
[ https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13068. --- Resolution: Fixed > Accounts Payable Past Due Invoices doesn't show outstanding amount > -- > > Key: OFBIZ-13068 > URL: https://issues.apache.org/jira/browse/OFBIZ-13068 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: Image 016.png, Screenshot 2024-04-29 at 11.52.07.png, > image-2024-04-29-09-05-28-760.png > > > With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d > [ec0adc02f1] the field outstanding got replaced with amountToApply in grid > ListApReport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12984) CreateFacilityLocation throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850640#comment-17850640 ] ASF subversion and git services commented on OFBIZ-12984: - Commit e583d221f96f16a25c971a816def92a8e4aecea9 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e583d221f9 ] Fixed: CreateFacilityLocation throws an error (OFBIZ-12984) Unlike Java Groovy does not support multi-lines with "+" ad head. You need to put it at end of previous line > CreateFacilityLocation throws an error > -- > > Key: OFBIZ-12984 > URL: https://issues.apache.org/jira/browse/OFBIZ-12984 > Project: OFBiz > Issue Type: Bug > Components: product/facility >Reporter: Pierre Smits >Priority: Major > Attachments: Screenshot 2024-04-01 at 12.27.37.png, Screenshot > 2024-04-01 at 12.27.50.png > > > Creating a new facility location throws following error: > {code:java}The Following Errors Occurred: > Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: > Service invocation error (groovy.lang.MissingMethodException: No signature of > method: java.lang.String.positive() is applicable for argument types: () > values: []Possible solutions: notify(), tokenize(), size()) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12935) Test 2.3.33 FreeMarker release
[ https://issues.apache.org/jira/browse/OFBIZ-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12935. --- Fix Version/s: Upcoming Branch Resolution: Done This has been tested for almost 3 months on trunk demo. The vote is going on on Freemarker dev ML for 3 weeks with enough positive votes and should be soon closed. So the 2.3.33 release will be soon done, closing here. > Test 2.3.33 FreeMarker release > --- > > Key: OFBIZ-12935 > URL: https://issues.apache.org/jira/browse/OFBIZ-12935 > Project: OFBiz > Issue Type: Sub-task > Components: Freemarker >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12935-StringModel.patch, OFBIZ-12935.patch, > OFBIZ-12935.txt > > > It's intended to test the 2.3.33 FreeMarker releases [as requested by the > FreeMarker > team|https://lists.apache.org/thread/t4c9z7wkcp3dbdokmnjd32fcptq8h9tz] > I attach a patch based on the test requested above: [^OFBIZ-12935.patch] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13110) PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId
[ https://issues.apache.org/jira/browse/OFBIZ-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-13110. - Resolution: Won't Do > PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId > -- > > Key: OFBIZ-13110 > URL: https://issues.apache.org/jira/browse/OFBIZ-13110 > Project: OFBiz > Issue Type: Bug >Reporter: Pierre Smits >Priority: Major > > Currently the PartyFinancialHistory shows the description of the parentTypeId > of the invoices shown in the overviews. This must be description of the > invoiceTypeId. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13048) createPlugin - improve templates
[ https://issues.apache.org/jira/browse/OFBIZ-13048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-13048. - Resolution: Won't Do > createPlugin - improve templates > > > Key: OFBIZ-13048 > URL: https://issues.apache.org/jira/browse/OFBIZ-13048 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Pierre Smits >Priority: Major > Labels: development > > With the parameterization of the menu location, improvements to the > createPlugin templates are warranted. > Replacing minilang folder with script folder, to ensure developers have a > place to have their non-compiled script files (groovy and others). > Removing non English labels, as in coding English is the internationally used > language (and more particarly within the ASF communities). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13100) LInk to supplier in Accounting Main does not show PartyFinancialHistory
[ https://issues.apache.org/jira/browse/OFBIZ-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-13100. - Resolution: Won't Do > LInk to supplier in Accounting Main does not show PartyFinancialHistory > --- > > Key: OFBIZ-13100 > URL: https://issues.apache.org/jira/browse/OFBIZ-13100 > Project: OFBiz > Issue Type: Bug >Reporter: Pierre Smits >Priority: Major > > When accessing the link to the PartyFinancialHistory screen of the supplier > in > [https://demo-trunk.ofbiz.apache.org/accounting/control/main|https://demo-trunk.ofbiz.apache.org/accounting/control/main,] > the resulting PartyFinancialHistory in partymgr shows no data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13107) MainActionMenu not shown on findreturn screen
[ https://issues.apache.org/jira/browse/OFBIZ-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850263#comment-17850263 ] ASF subversion and git services commented on OFBIZ-13107: - Commit 8184dc3902a7c1f01a39526094b1dcf94daf5198 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8184dc3902 ] Fixed: MainActionMenu not shown on findreturn screen (OFBIZ-13107) (#810) The MainActionMenu of the order component is shown on various screens, but not on the findreturn screen. modified: OrderReturnScreens,xml - added pre-body decorator section having MainActionMenu to screen CommonOrderReturnDecorator and screen OrderFindReturn > MainActionMenu not shown on findreturn screen > - > > Key: OFBIZ-13107 > URL: https://issues.apache.org/jira/browse/OFBIZ-13107 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pierre Smits >Priority: Major > > The MainActionMenu of the order component is shown on various screens, but > not on the findreturn screen. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13107) MainActionMenu not shown on findreturn screen
[ https://issues.apache.org/jira/browse/OFBIZ-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13107. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Fixed > MainActionMenu not shown on findreturn screen > - > > Key: OFBIZ-13107 > URL: https://issues.apache.org/jira/browse/OFBIZ-13107 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > The MainActionMenu of the order component is shown on various screens, but > not on the findreturn screen. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850042#comment-17850042 ] Jacques Le Roux commented on OFBIZ-13101: - As Pierre mentions in description, it's handled, in ManufacturingMenus::MainActionMenu. Do we really need to duplicate this action trigger as Pierre call them? I'll start a discussion in dev ML about that, because there are much other places to check then... > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850030#comment-17850030 ] Michael Brohl edited comment on OFBIZ-13101 at 5/28/24 1:11 PM: [~jleroux] instead of removing those actions, they should properly behandled in the UI to only be shown when the user has the right permission. Removing them completely is a loss of functionality for users who have the permission. In any case, this should be discussed first because it is existing functionality which is removed there. was (Author: mbrohl): [~jleroux] instead of removing those actions, they should properly behandled in the UI to only be shown when the user has the right permission. Removing them completely is a loss of functionality for users who have the permission. > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reopened OFBIZ-13101: --- [~jleroux] instead of removing those actions, they should properly behandled in the UI to only be shown when the user has the right permission. Removing them completely is a loss of functionality for users who have the permission. > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850025#comment-17850025 ] Jacques Le Roux commented on OFBIZ-11378: - Thanks! > Convert createCommContentDataResource service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11378 > URL: https://issues.apache.org/jira/browse/OFBIZ-11378 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Devanshu Vyas >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-11378.patch > > > Convert createCommContentDataResource service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850021#comment-17850021 ] Pierre Smits commented on OFBIZ-13101: -- Thanks Jacques. > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850022#comment-17850022 ] Nicolas Malin commented on OFBIZ-11378: --- Maybe just a forget :) > Convert createCommContentDataResource service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11378 > URL: https://issues.apache.org/jira/browse/OFBIZ-11378 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Devanshu Vyas >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-11378.patch > > > Convert createCommContentDataResource service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-11378. - Resolution: Done > Convert createCommContentDataResource service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11378 > URL: https://issues.apache.org/jira/browse/OFBIZ-11378 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Devanshu Vyas >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-11378.patch > > > Convert createCommContentDataResource service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850010#comment-17850010 ] Jacques Le Roux commented on OFBIZ-9984: Hi [~pgil], Would you mind takeover? It seems to me that [Sebastian is no longer working on OFBiz for almost a year|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=sberg] > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk, Upcoming Branch >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850007#comment-17850007 ] Jacques Le Roux commented on OFBIZ-11378: - Hi [~nmalin], Is there reasons to not close this issue? > Convert createCommContentDataResource service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11378 > URL: https://issues.apache.org/jira/browse/OFBIZ-11378 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Devanshu Vyas >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-11378.patch > > > Convert createCommContentDataResource service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13101. --- Resolution: Implemented Thanks Pierre for your clear explanation. I see now no reasons to not definitely close this Jira as I thought initially. > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849725#comment-17849725 ] Jacques Le Roux edited comment on OFBIZ-13101 at 5/28/24 11:57 AM: --- Hi [~jleroux] re: {quote}So [~pierresmits], in what Removing this duplicate also improves the experience for users with only VIEW permissions, like auditor in the demo site. Could you please explain, that's the most important point IMO {quote} Given that action triggers to create, update, expire or delete something must be on permission conditions, a user with only VIEW permissions should not see such action triggers. Like the one in this PR, the majority of link definitions in screens xml files are without any kind of permission condition. As such, they diminish the experience of such a user, as in most of those cases, the user will see the screen/form to perform the action including the action trigger on the presented form. If and when the user then activates the trigger (add, updated, submit, etc.) on the form, that user is presented with ' {quote}The Following Errors Occurred: You haven't the permission for the service createAgreementItem, reason : Access refused {quote} message. Which could lead to unnecessary call to the DEVOPS team (and wasted time/effort). Thus, it is preferred not to show such action triggers at all to that kind of user. IMO, the best user experience is based on process flows (and its screens/forms/etc. when there is no ambiguity. I trust the above answers your question. Best regards, was (Author: pfm.smits): Hi [~jleroux] re: {quote}So [~pierresmits], in what {quote}Removing this duplicate also improves the experience for users with only VIEW permissions, like auditor in the demo site. {quote} Could you please explain, that's the most important point IMO {quote} Given that action triggers to create, update, expire or delete something must be on permission conditions, a user with only VIEW permissions should not see such action triggers. Like the one in this PR, the majority of link definitions in screens xml files are without any kind of permission condition. As such, they diminish the experience of such a user, as in most of those cases, the user will see the screen/form to perform the action including the action trigger on the presented form. If and when the user then activates the trigger (add, updated, submit, etc.) on the form, that user is presented with ' {quote}The Following Errors Occurred: You haven't the permission for the service createAgreementItem, reason : Access refused {quote} message. Which could lead to unnecessary call to the DEVOPS team (and wasted time/effort). Thus, it is preferred not to show such action triggers at all to that kind of user. IMO, the best user experience is based on process flows (and its screens/forms/etc. when there is no ambiguity. I trust the above answers your question. Best regards, > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849725#comment-17849725 ] Jacques Le Roux edited comment on OFBIZ-13101 at 5/28/24 11:57 AM: --- Hi [~jleroux] re: {quote}So [~pierresmits], in what <> Could you please explain, that's the most important point IMO {quote} Given that action triggers to create, update, expire or delete something must be on permission conditions, a user with only VIEW permissions should not see such action triggers. Like the one in this PR, the majority of link definitions in screens xml files are without any kind of permission condition. As such, they diminish the experience of such a user, as in most of those cases, the user will see the screen/form to perform the action including the action trigger on the presented form. If and when the user then activates the trigger (add, updated, submit, etc.) on the form, that user is presented with ' {quote}The Following Errors Occurred: You haven't the permission for the service createAgreementItem, reason : Access refused {quote} message. Which could lead to unnecessary call to the DEVOPS team (and wasted time/effort). Thus, it is preferred not to show such action triggers at all to that kind of user. IMO, the best user experience is based on process flows (and its screens/forms/etc. when there is no ambiguity. I trust the above answers your question. Best regards, was (Author: pfm.smits): Hi [~jleroux] re: {quote}So [~pierresmits], in what Removing this duplicate also improves the experience for users with only VIEW permissions, like auditor in the demo site. Could you please explain, that's the most important point IMO {quote} Given that action triggers to create, update, expire or delete something must be on permission conditions, a user with only VIEW permissions should not see such action triggers. Like the one in this PR, the majority of link definitions in screens xml files are without any kind of permission condition. As such, they diminish the experience of such a user, as in most of those cases, the user will see the screen/form to perform the action including the action trigger on the presented form. If and when the user then activates the trigger (add, updated, submit, etc.) on the form, that user is presented with ' {quote}The Following Errors Occurred: You haven't the permission for the service createAgreementItem, reason : Access refused {quote} message. Which could lead to unnecessary call to the DEVOPS team (and wasted time/effort). Thus, it is preferred not to show such action triggers at all to that kind of user. IMO, the best user experience is based on process flows (and its screens/forms/etc. when there is no ambiguity. I trust the above answers your question. Best regards, > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-11578) Convert PriceServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11578. --- Fix Version/s: Upcoming Branch Resolution: Implemented This was fixed by https://github.com/apache/ofbiz-framework/commit/80026c76c066f589a652bd00bb7699108cd66163 > Convert PriceServices.xml minilang to groovy > > > Key: OFBIZ-11578 > URL: https://issues.apache.org/jira/browse/OFBIZ-11578 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk, Upcoming Branch >Reporter: Sebastian Berg >Assignee: Nicolas Malin >Priority: Minor > Fix For: Upcoming Branch > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13111) Generated Customer Return invoice throws error in PartyFinancialHistory
[ https://issues.apache.org/jira/browse/OFBIZ-13111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13111: - Summary: Generated Customer Return invoice throws error in PartyFinancialHistory (was: Generated Customer Return invoice twrows error in PartyFinancialHistory) > Generated Customer Return invoice throws error in PartyFinancialHistory > --- > > Key: OFBIZ-13111 > URL: https://issues.apache.org/jira/browse/OFBIZ-13111 > Project: OFBiz > Issue Type: Bug >Reporter: Pierre Smits >Priority: Major > > When a customer return invoice has been created in Accounting, following > error is thrown when the PartyFinancialHistor screen in party is shown: > {code:java} > java.lang.RuntimeException: Error rendering included grid named > [ListUnAppliedInvoices] at location > [component://party/widget/partymgr/PartyForms.xml]: > java.lang.IllegalArgumentException: Error running script at location > [component://party/src/main/groovy/org/apache/ofbiz/party/party/UnAppliedInvoicesForParty.groovy]: > java.lang.NullPointerException: Cannot invoke "String.equals(Object)" > because the return value of > "org.apache.ofbiz.entity.GenericValue.getString(String)" is > nulljava.lang.IllegalArgumentException: Error running script at location > [component://party/src/main/groovy/org/apache/ofbiz/party/party/UnAppliedInvoicesForParty.groovy]: > java.lang.NullPointerException: Cannot invoke "String.equals(Object)" > because the return value of > "org.apache.ofbiz.entity.GenericValue.getString(String)" is null{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13112) On purchase order, payment method/preference can't be set
Pierre Smits created OFBIZ-13112: Summary: On purchase order, payment method/preference can't be set Key: OFBIZ-13112 URL: https://issues.apache.org/jira/browse/OFBIZ-13112 Project: OFBiz Issue Type: Bug Components: order Reporter: Pierre Smits While on a sales order for a customer the payment method/preference can be set for the order, this can not be done on a purchase order. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13111) Generated Customer Return invoice twrows error in PartyFinancialHistory
Pierre Smits created OFBIZ-13111: Summary: Generated Customer Return invoice twrows error in PartyFinancialHistory Key: OFBIZ-13111 URL: https://issues.apache.org/jira/browse/OFBIZ-13111 Project: OFBiz Issue Type: Bug Reporter: Pierre Smits When a customer return invoice has been created in Accounting, following error is thrown when the PartyFinancialHistor screen in party is shown: {code:java} java.lang.RuntimeException: Error rendering included grid named [ListUnAppliedInvoices] at location [component://party/widget/partymgr/PartyForms.xml]: java.lang.IllegalArgumentException: Error running script at location [component://party/src/main/groovy/org/apache/ofbiz/party/party/UnAppliedInvoicesForParty.groovy]: java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.apache.ofbiz.entity.GenericValue.getString(String)" is nulljava.lang.IllegalArgumentException: Error running script at location [component://party/src/main/groovy/org/apache/ofbiz/party/party/UnAppliedInvoicesForParty.groovy]: java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.apache.ofbiz.entity.GenericValue.getString(String)" is null{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13110) PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId
Pierre Smits created OFBIZ-13110: Summary: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId Key: OFBIZ-13110 URL: https://issues.apache.org/jira/browse/OFBIZ-13110 Project: OFBiz Issue Type: Bug Reporter: Pierre Smits Currently the PartyFinancialHistory shows the description of the parentTypeId of the invoices shown in the overviews. This must be description of the invoiceTypeId. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13109) Numbering of Customer return invoice does not apply numbering scheme preference
Pierre Smits created OFBIZ-13109: Summary: Numbering of Customer return invoice does not apply numbering scheme preference Key: OFBIZ-13109 URL: https://issues.apache.org/jira/browse/OFBIZ-13109 Project: OFBiz Issue Type: Bug Components: accounting Reporter: Pierre Smits When a customer return invoice are created, the numbering thereof should follow the preferences set for customer invoices in PartyAcctgPreference. Instead, a customer return invoice get a number per the methodology for supplier invoices. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13108) Return invoice does not allow selectin of appropriate party
Pierre Smits created OFBIZ-13108: Summary: Return invoice does not allow selectin of appropriate party Key: OFBIZ-13108 URL: https://issues.apache.org/jira/browse/OFBIZ-13108 Project: OFBiz Issue Type: Bug Components: accounting Reporter: Pierre Smits When creating a purchase return invoice (credit note), the user can't select the appropriate supplier. Similarly, when creating a customer return invoice (also a credit note), the user can't select the appropriate customer. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13107) MainActionMenu not shown on findreturn screen
Pierre Smits created OFBIZ-13107: Summary: MainActionMenu not shown on findreturn screen Key: OFBIZ-13107 URL: https://issues.apache.org/jira/browse/OFBIZ-13107 Project: OFBiz Issue Type: Bug Components: order Reporter: Pierre Smits The MainActionMenu of the order component is shown on various screens, but not on the findreturn screen. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13106) Order: Return process creates payment, substracted from available invoice
Pierre Smits created OFBIZ-13106: Summary: Order: Return process creates payment, substracted from available invoice Key: OFBIZ-13106 URL: https://issues.apache.org/jira/browse/OFBIZ-13106 Project: OFBiz Issue Type: Bug Reporter: Pierre Smits When going through the process of creating a return (e.g. because of defective goods delivered), the process - upon completion automatically creates a payment which is applied to available invoice(s), without the intervention/involvement of the accounting department and without creation of a return invoice. This is wrong. As the accounting department is responsible for financial control and accountable of correct accounting and financial transactions, the department determines which invoices get paid and which credit notes get deducted from available (and approved) invoices before payment is done. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13088) CATALOG-Main: VIEW permission
[ https://issues.apache.org/jira/browse/OFBIZ-13088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13088: - Parent: OFBIZ-13105 Issue Type: Sub-task (was: Improvement) > CATALOG-Main: VIEW permission > - > > Key: OFBIZ-13088 > URL: https://issues.apache.org/jira/browse/OFBIZ-13088 > Project: OFBiz > Issue Type: Sub-task > Components: product/catalog >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: usability > > Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo > with userId = auditor, accessing the Catalog Main Page, sees triggers (to > requests) reserved for users with 'CREATE' or 'UPDATE' permissions. > To see/test: https://demo-trunk.ofbiz.apache.org/catalog/control/main -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849725#comment-17849725 ] Pierre Smits commented on OFBIZ-13101: -- Hi [~jleroux] re: {quote}So [~pierresmits], in what {quote}Removing this duplicate also improves the experience for users with only VIEW permissions, like auditor in the demo site. {quote} Could you please explain, that's the most important point IMO {quote} Given that action triggers to create, update, expire or delete something must be on permission conditions, a user with only VIEW permissions should not see such action triggers. Like the one in this PR, the majority of link definitions in screens xml files are without any kind of permission condition. As such, they diminish the experience of such a user, as in most of those cases, the user will see the screen/form to perform the action including the action trigger on the presented form. If and when the user then activates the trigger (add, updated, submit, etc.) on the form, that user is presented with ' {quote}The Following Errors Occurred: You haven't the permission for the service createAgreementItem, reason : Access refused {quote} message. Which could lead to unnecessary call to the DEVOPS team (and wasted time/effort). Thus, it is preferred not to show such action triggers at all to that kind of user. IMO, the best user experience is based on process flows (and its screens/forms/etc. when there is no ambiguity. I trust the above answers your question. Best regards, > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12653) Sanitizer fail
[ https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849710#comment-17849710 ] Jacques Le Roux commented on OFBIZ-12653: - I know, I thought you had a better idea. Let's keep this issue closed ;) > Sanitizer fail > --- > > Key: OFBIZ-12653 > URL: https://issues.apache.org/jira/browse/OFBIZ-12653 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, > UtilCodec.patch > > > I copied a text with multiple lines from a text editor into the Trumbowyg > Html field.The editor creates the Html structure using unclosed elements. > Unfortunately the sanitizer logic just takes . A security warning is > thrown and the content will not be stored. > Issue also a request on Trumbowyg request list: > [https://github.com/Alex-D/Trumbowyg/issues/1283] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12653) Sanitizer fail
[ https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849708#comment-17849708 ] Chenghu Shan edited comment on OFBIZ-12653 at 5/27/24 11:40 AM: Hi [~jleroux]. there might be a missunderstanding. I meant the most above change already did fix my current problem. That change is already in trunk. was (Author: JIRAUSER298655): Hi [~jleroux]. there might be a missunderstanding. I meant the most recent change in trunk already did fix my current problem. > Sanitizer fail > --- > > Key: OFBIZ-12653 > URL: https://issues.apache.org/jira/browse/OFBIZ-12653 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, > UtilCodec.patch > > > I copied a text with multiple lines from a text editor into the Trumbowyg > Html field.The editor creates the Html structure using unclosed elements. > Unfortunately the sanitizer logic just takes . A security warning is > thrown and the content will not be stored. > Issue also a request on Trumbowyg request list: > [https://github.com/Alex-D/Trumbowyg/issues/1283] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12653) Sanitizer fail
[ https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849708#comment-17849708 ] Chenghu Shan edited comment on OFBIZ-12653 at 5/27/24 11:40 AM: Hi [~jleroux]. there might be a missunderstanding. I meant the above change already did fix my current problem. That change is already in trunk. was (Author: JIRAUSER298655): Hi [~jleroux]. there might be a missunderstanding. I meant the most above change already did fix my current problem. That change is already in trunk. > Sanitizer fail > --- > > Key: OFBIZ-12653 > URL: https://issues.apache.org/jira/browse/OFBIZ-12653 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, > UtilCodec.patch > > > I copied a text with multiple lines from a text editor into the Trumbowyg > Html field.The editor creates the Html structure using unclosed elements. > Unfortunately the sanitizer logic just takes . A security warning is > thrown and the content will not be stored. > Issue also a request on Trumbowyg request list: > [https://github.com/Alex-D/Trumbowyg/issues/1283] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12653) Sanitizer fail
[ https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849708#comment-17849708 ] Chenghu Shan commented on OFBIZ-12653: -- Hi [~jleroux]. there might be a missunderstanding. I meant the most recent change in trunk already did fix my current problem. > Sanitizer fail > --- > > Key: OFBIZ-12653 > URL: https://issues.apache.org/jira/browse/OFBIZ-12653 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, > UtilCodec.patch > > > I copied a text with multiple lines from a text editor into the Trumbowyg > Html field.The editor creates the Html structure using unclosed elements. > Unfortunately the sanitizer logic just takes . A security warning is > thrown and the content will not be stored. > Issue also a request on Trumbowyg request list: > [https://github.com/Alex-D/Trumbowyg/issues/1283] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12653) Sanitizer fail
[ https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849686#comment-17849686 ] Jacques Le Roux commented on OFBIZ-12653: - Hi [~cshan], Great, please create a PR for that. > Sanitizer fail > --- > > Key: OFBIZ-12653 > URL: https://issues.apache.org/jira/browse/OFBIZ-12653 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, > UtilCodec.patch > > > I copied a text with multiple lines from a text editor into the Trumbowyg > Html field.The editor creates the Html structure using unclosed elements. > Unfortunately the sanitizer logic just takes . A security warning is > thrown and the content will not be stored. > Issue also a request on Trumbowyg request list: > [https://github.com/Alex-D/Trumbowyg/issues/1283] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12653) Sanitizer fail
[ https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849644#comment-17849644 ] Chenghu Shan commented on OFBIZ-12653: -- Hi [~jleroux], thanks for your help. The last commit I'm referring to is the one mentioned in the comment directly above my first: [ [https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ed6e413569] ]. The changes in UtilCodec.java introduce additional logic to change the given input string (value). Yes, both changing @ to "at" and the most recent change in OFBIZ-12691 would solve my current problem. But I was assuming the "safe" logic should be configured by using a CustomSafePolicy class. > Sanitizer fail > --- > > Key: OFBIZ-12653 > URL: https://issues.apache.org/jira/browse/OFBIZ-12653 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, > UtilCodec.patch > > > I copied a text with multiple lines from a text editor into the Trumbowyg > Html field.The editor creates the Html structure using unclosed elements. > Unfortunately the sanitizer logic just takes . A security warning is > thrown and the content will not be stored. > Issue also a request on Trumbowyg request list: > [https://github.com/Alex-D/Trumbowyg/issues/1283] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849562#comment-17849562 ] Jacques Le Roux commented on OFBIZ-13101: - [~mbrohl], Thinking about it, I should have asked a question to Pierre before pushing. So [~pierresmits], in what bq. Removing this duplicate also improves the experience for users with only VIEW permissions, like auditor in the demo site. Could you please explain, that's the most important point IMO > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reopened OFBIZ-13101: --- [~jleroux] I think this needs discussion before we do those changes. Having action buttons in context within the UI as well as a menu is a commonly used pattern. Additionally, screens are defined to be reused and can be used without a UI with menus. I propose to revert the change and discuss this pattern first. > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13066) Remove duplicated menu main buttons
[ https://issues.apache.org/jira/browse/OFBIZ-13066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-13066: Parent: OFBIZ-13105 Issue Type: Sub-task (was: Improvement) > Remove duplicated menu main buttons > --- > > Key: OFBIZ-13066 > URL: https://issues.apache.org/jira/browse/OFBIZ-13066 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Priority: Major > > Since the almost generalised use of portal and portlet, and maybe before, > some apps show duplicated menu main buttons. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13066) Remove duplicated menu main buttons
[ https://issues.apache.org/jira/browse/OFBIZ-13066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849509#comment-17849509 ] Pierre Smits commented on OFBIZ-13066: -- Hi Jacques, Can you convert this to a sub-task under OFBIZ-13105 ? > Remove duplicated menu main buttons > --- > > Key: OFBIZ-13066 > URL: https://issues.apache.org/jira/browse/OFBIZ-13066 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Priority: Major > > Since the almost generalised use of portal and portlet, and maybe before, > some apps show duplicated menu main buttons. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13102) Duplicate trigger in Invoices
[ https://issues.apache.org/jira/browse/OFBIZ-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13102: - Parent: OFBIZ-13105 Issue Type: Sub-task (was: Improvement) > Duplicate trigger in Invoices > - > > Key: OFBIZ-13102 > URL: https://issues.apache.org/jira/browse/OFBIZ-13102 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Pierre Smits >Priority: Major > > On the 'FindInvoices' an action trigger to create a new invoice is shown. > This action trigger is already available via the MainActionMenu. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13101: - Parent: OFBIZ-13105 Issue Type: Sub-task (was: Improvement) > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13105) (Re)Move screen action trigger
Pierre Smits created OFBIZ-13105: Summary: (Re)Move screen action trigger Key: OFBIZ-13105 URL: https://issues.apache.org/jira/browse/OFBIZ-13105 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS, ALL PLUGINS Reporter: Pierre Smits Currently a lot of screen definitions have action triggers included to have the user do something in relation to the object (entity record) of the screen. The action trigger must be removed from the screen and added to the object's ActionMenu to create a unified user experience across the screens in all applications. In addition to that, it is easier to do permission conditions in a menu than in a screen. A menu-item just needs the condition, while a screen - on top of the condition - needs a section/widget/etc. to comply with the project's best practices. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws a warning
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849503#comment-17849503 ] Jacques Le Roux commented on OFBIZ-13099: - I was confronted with that some times ago and used the same technique. Weirdly I can't remember nor find it. I thought it was with SpotBugs but it uses exclude.xml. Anyway just for telling :) > PartyFinancialHistory throws a warning > -- > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWi
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws a warning
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849500#comment-17849500 ] Pierre Smits commented on OFBIZ-13099: -- Thanks [~jleroux] , I had your solution {code:java} while (object = objectIterator.next()) {{code} initially too, but could not get it pushed due to the codenarc rule. Thank you for fixing this and showing the way. > PartyFinancialHistory throws a warning > -- > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWi
[jira] [Commented] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page
[ https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849498#comment-17849498 ] Jacques Le Roux commented on OFBIZ-13104: - I clearly see it indeed. > 'Helveticus' theme,Abnormal display on the 'React Example' page > --- > > Key: OFBIZ-13104 > URL: https://issues.apache.org/jira/browse/OFBIZ-13104 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: Upcoming Branch > Environment: > [https://demo-next.ofbiz.apache.org/example/control/ReactExample] > https://demo-trunk.ofbiz.apache.org/example/control/ReactExample >Reporter: gavinju >Priority: Major > Attachments: 20240526_124839.mp4 > > > In the 'Helveticus' theme style, when entering the Example module and > accessing 'React Example', the overall page will show scaling from large to > small. > But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' > displays normally. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page
[ https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849496#comment-17849496 ] gavinju commented on OFBIZ-13104: - My OS is : window 11 Browser is : Chrome In the 'Helveticus' theme,'React Example' displays abnormal,Other theme displays normally. Please review the screenshot video I submitted. > 'Helveticus' theme,Abnormal display on the 'React Example' page > --- > > Key: OFBIZ-13104 > URL: https://issues.apache.org/jira/browse/OFBIZ-13104 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: Upcoming Branch > Environment: > [https://demo-next.ofbiz.apache.org/example/control/ReactExample] > https://demo-trunk.ofbiz.apache.org/example/control/ReactExample >Reporter: gavinju >Priority: Major > Attachments: 20240526_124839.mp4 > > > In the 'Helveticus' theme style, when entering the Example module and > accessing 'React Example', the overall page will show scaling from large to > small. > But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' > displays normally. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page
[ https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gavinju updated OFBIZ-13104: Attachment: 20240526_124839.mp4 > 'Helveticus' theme,Abnormal display on the 'React Example' page > --- > > Key: OFBIZ-13104 > URL: https://issues.apache.org/jira/browse/OFBIZ-13104 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: Upcoming Branch > Environment: > [https://demo-next.ofbiz.apache.org/example/control/ReactExample] > https://demo-trunk.ofbiz.apache.org/example/control/ReactExample >Reporter: gavinju >Priority: Major > Attachments: 20240526_124839.mp4 > > > In the 'Helveticus' theme style, when entering the Example module and > accessing 'React Example', the overall page will show scaling from large to > small. > But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' > displays normally. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page
[ https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849431#comment-17849431 ] Jacques Le Roux commented on OFBIZ-13104: - Hi [~gavinju], I can't reproduce on Windows with Edge. What environment (OS, browser) are you using? > 'Helveticus' theme,Abnormal display on the 'React Example' page > --- > > Key: OFBIZ-13104 > URL: https://issues.apache.org/jira/browse/OFBIZ-13104 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: Upcoming Branch > Environment: > [https://demo-next.ofbiz.apache.org/example/control/ReactExample] > https://demo-trunk.ofbiz.apache.org/example/control/ReactExample >Reporter: gavinju >Priority: Major > > In the 'Helveticus' theme style, when entering the Example module and > accessing 'React Example', the overall page will show scaling from large to > small. > But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' > displays normally. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page
[ https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-13104: Affects Version/s: (was: 22.01.01) (was: 22.01) Removing 22.01 as it's abandonned > 'Helveticus' theme,Abnormal display on the 'React Example' page > --- > > Key: OFBIZ-13104 > URL: https://issues.apache.org/jira/browse/OFBIZ-13104 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: Upcoming Branch > Environment: > [https://demo-next.ofbiz.apache.org/example/control/ReactExample] > https://demo-trunk.ofbiz.apache.org/example/control/ReactExample >Reporter: gavinju >Priority: Major > > In the 'Helveticus' theme style, when entering the Example module and > accessing 'React Example', the overall page will show scaling from large to > small. > But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' > displays normally. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page
[ https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-13104: Parent: OFBIZ-12276 Issue Type: Sub-task (was: Bug) > 'Helveticus' theme,Abnormal display on the 'React Example' page > --- > > Key: OFBIZ-13104 > URL: https://issues.apache.org/jira/browse/OFBIZ-13104 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: 22.01.01, Upcoming Branch, 22.01 > Environment: > [https://demo-next.ofbiz.apache.org/example/control/ReactExample] > https://demo-trunk.ofbiz.apache.org/example/control/ReactExample >Reporter: gavinju >Priority: Major > > In the 'Helveticus' theme style, when entering the Example module and > accessing 'React Example', the overall page will show scaling from large to > small. > But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' > displays normally. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page
gavinju created OFBIZ-13104: --- Summary: 'Helveticus' theme,Abnormal display on the 'React Example' page Key: OFBIZ-13104 URL: https://issues.apache.org/jira/browse/OFBIZ-13104 Project: OFBiz Issue Type: Bug Components: example Affects Versions: 22.01.01, Upcoming Branch, 22.01 Environment: [https://demo-next.ofbiz.apache.org/example/control/ReactExample] https://demo-trunk.ofbiz.apache.org/example/control/ReactExample Reporter: gavinju In the 'Helveticus' theme style, when entering the Example module and accessing 'React Example', the overall page will show scaling from large to small. But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' displays normally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13099) PartyFinancialHistory throws a warning
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13099. --- Resolution: Implemented > PartyFinancialHistory throws a warning > -- > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSect
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws a warning
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849385#comment-17849385 ] ASF subversion and git services commented on OFBIZ-13099: - Commit 6b57e35dbc25d32fdaff8b956fe8eb22a3ed5bf7 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6b57e35dbc ] fixed: PartyFinancialHistory throws an error (OFBIZ-13099) This is a rewrite for different reasons. The queryIterators were called twice, for instance while (invIterator.next()) { invoice = nvIterator.next() They are now called only once, else an instance would be lost while (invoice = invIterator.next()) { The expression above raises the CodeNarc rule AssignmentInConditional So I had to locally bypass it using comments I have added a warning in EntityListIterator::hasNext about that. Also the queryIterators must be closed as documented in EntityQuery::queryIterator: NOTE: THAT THIS MUST BE CLOSED (preferably in a finally block) WHEN YOU ARE DONE WITH IT, AND DON'T LEAVE IT OPEN TOO LONG BEACUSE IT WILL MAINTAIN A DATABASE CONNECTION. It could be possible to implements AutoCloseable in the call stack but not evident... EntityListIterator implements it... > PartyFinancialHistory throws a warning > -- > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.render
[jira] [Updated] (OFBIZ-13099) PartyFinancialHistory throws a warning
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-13099: Summary: PartyFinancialHistory throws a warning (was: PartyFinancialHistory throws an error) > PartyFinancialHistory throws a warning > -- > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(Mod
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849339#comment-17849339 ] ASF subversion and git services commented on OFBIZ-13099: - Commit f6e6eb602d6dad04a6f12b36073aa7f86d30449d in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f6e6eb602d ] Fixed: Replace deprecated BigDecimal.ROUND_HALF by RoundingMode.HALF (OFBIZ-13103) RoundingMode.HALF_UP is not returning an int. This, at least, prevents integration tests to pass. Maybe more due to OFBIZ-13099 that need to be fixed anyway. > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:
[jira] [Closed] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13101. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Pierre > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849326#comment-17849326 ] ASF subversion and git services commented on OFBIZ-13101: - Commit 0fc9a06435aa6f5d8d8aad806315295d63055b9f in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0fc9a06435 ] improved: Duplicate action trigger in Manufacturing (OFBIZ-13101) (#806) On the 'FndProductionRun' an action trigger to create something is shown. This links to CreateProductionRun. This action trigger is already available via the MainActionMenu. Removing this duplicate also improves the experience for users with only VIEW permissions, like auditor in the demo site. modified: JopshopScreens.xml - removed decorator-section having action trigger > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-13101: --- Assignee: Jacques Le Roux > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849322#comment-17849322 ] Jacques Le Roux commented on OFBIZ-13099: - Also [~mleila] just pointed out to me that you made a typo at bq. invoice = nvIterator.next() it's bq. invoice = invIterator.next() Looking forward for your fixes > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWi
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849314#comment-17849314 ] Jacques Le Roux commented on OFBIZ-13099: - Redundant to what? Maybe you confused with Groovy Iterator that are indeed AutoCloseable https://docs.groovy-lang.org/latest/html/groovy-jdk/java/util/Iterator.html But there we are using queryIterator and the documentation is clear (apart the BEACUSE typo :)) {quote} Open Declaration EntityListIterator org.apache.ofbiz.entity.util.EntityQuery.queryIterator() throws GenericEntityException Executes the EntityQuery and returns an EntityListIterator representing the result of the query. NOTE: THAT THIS MUST BE CLOSED (preferably in a finally block) WHEN YOU ARE DONE WITH IT, AND DON'T LEAVE IT OPEN TOO LONG BEACUSE IT WILL MAINTAIN A DATABASE CONNECTION. Returns:Returns an EntityListIterator representing the result of the queryThrows:GenericEntityException {quote} You don't need a finally block in Groovy but you need to use hasNext and close as it was before your changes. TIA > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] >
[jira] [Closed] (OFBIZ-13103) Replace deprecated BigDecimal.ROUND_HALF by RoundingMode.HALF
[ https://issues.apache.org/jira/browse/OFBIZ-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13103. --- Resolution: Done > Replace deprecated BigDecimal.ROUND_HALF by RoundingMode.HALF > -- > > Key: OFBIZ-13103 > URL: https://issues.apache.org/jira/browse/OFBIZ-13103 > Project: OFBiz > Issue Type: Improvement > Components: accounting, birt, party, product/catalog >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Address this deprecation > {quote} > int java.math.BigDecimal.ROUND_HALF_UP > Deprecated. Use RoundingMode.HALF_UP instead. > Rounding mode to round towards "nearest neighbor" unless both neighbors are > equidistant, in which case round up. Behaves as for ROUND_UP if the discarded > fraction is ≥ 0.5; otherwise, behaves as for ROUND_DOWN. Note that this is > the rounding mode that most of us were taught in grade school. > {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13103) Replace deprecated BigDecimal.ROUND_HALF by RoundingMode.HALF
Jacques Le Roux created OFBIZ-13103: --- Summary: Replace deprecated BigDecimal.ROUND_HALF by RoundingMode.HALF Key: OFBIZ-13103 URL: https://issues.apache.org/jira/browse/OFBIZ-13103 Project: OFBiz Issue Type: Improvement Components: accounting, birt, party, product/catalog Affects Versions: Upcoming Branch Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Upcoming Branch Address this deprecation {quote} int java.math.BigDecimal.ROUND_HALF_UP Deprecated. Use RoundingMode.HALF_UP instead. Rounding mode to round towards "nearest neighbor" unless both neighbors are equidistant, in which case round up. Behaves as for ROUND_UP if the discarded fraction is ≥ 0.5; otherwise, behaves as for ROUND_DOWN. Note that this is the rounding mode that most of us were taught in grade school. {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13102) Duplicate trigger in Invoices
Pierre Smits created OFBIZ-13102: Summary: Duplicate trigger in Invoices Key: OFBIZ-13102 URL: https://issues.apache.org/jira/browse/OFBIZ-13102 Project: OFBiz Issue Type: Improvement Components: accounting Reporter: Pierre Smits On the 'FindInvoices' an action trigger to create a new invoice is shown. This action trigger is already available via the MainActionMenu. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13101) Duplicate action trigger in Manufacturing
Pierre Smits created OFBIZ-13101: Summary: Duplicate action trigger in Manufacturing Key: OFBIZ-13101 URL: https://issues.apache.org/jira/browse/OFBIZ-13101 Project: OFBiz Issue Type: Improvement Components: manufacturing Reporter: Pierre Smits On the 'FndProductionRun' an action trigger to create something is shown. This links to CreateProductionRun. This action trigger is already available via the MainActionMenu. Removing this duplicate also improves the experience for users with only VIEW permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849278#comment-17849278 ] Pierre Smits commented on OFBIZ-13099: -- Hi Jacques, Are they now not redundant? > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.a
[jira] [Reopened] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-13099: - Pierre, Reopening for this question: Why did you remove the iterators closing? > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.a
[jira] [Closed] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13099. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Done > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(Mod
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849275#comment-17849275 ] Jacques Le Roux commented on OFBIZ-13099: - Thanks Pierre > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Minor > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWi
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849274#comment-17849274 ] ASF subversion and git services commented on OFBIZ-13099: - Commit bc384fd978a36a51bad71a63135165f40f3676b3 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bc384fd978 ] fixed: PartyFinancialHistory throws an error (OFBIZ-13099) (#804) * fixed: PartyFinancialHistory throws an error (OFBIZ-13099) When accessing the financial history screen in the partymgr application (e.g. via https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier), following error multiple times are thrown: modified: - replaced .hasNext() in PartyFinancialHistory.groovy, UnAppliedInvoicesForParty.groovy, UnAppliedPaymentsForParty.groovy * cleanup * fixed: PartyFinancialHistory throws an error (OFBIZ-13099) fixed while issue * fixed: PartyFinancialHistory throws an error (OFBIZ-13099) removed iterator .close() * Update UnAppliedInvoicesForParty.groovy Fixes: C:\projectsASF\Git\ofbiz-framework>git apply 804.patch 804.patch:69: trailing whitespace. warning: 1 line adds whitespace errors. - Co-authored-by: Jacques Le Roux > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Minor > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apa
[jira] [Created] (OFBIZ-13100) LInk to supplier in Accounting Main does not show PartyFinancialHistory
Pierre Smits created OFBIZ-13100: Summary: LInk to supplier in Accounting Main does not show PartyFinancialHistory Key: OFBIZ-13100 URL: https://issues.apache.org/jira/browse/OFBIZ-13100 Project: OFBiz Issue Type: Bug Reporter: Pierre Smits When accessing the link to the PartyFinancialHistory screen of the supplier in [https://demo-trunk.ofbiz.apache.org/accounting/control/main|https://demo-trunk.ofbiz.apache.org/accounting/control/main,] the resulting PartyFinancialHistory in partymgr shows no data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849238#comment-17849238 ] Pierre Smits commented on OFBIZ-13099: -- Thanks Jacques. > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Minor > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWi
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849235#comment-17849235 ] Jacques Le Roux commented on OFBIZ-13099: - Hi Pierre, Locally in trunk as admin I see only a warning in log, so not really a bug, rather an improvement. > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Bug > Components: party >Reporter: Pierre Smits >Priority: Major > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.r
[jira] [Updated] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-13099: Affects Version/s: Upcoming Branch Issue Type: Improvement (was: Bug) Priority: Minor (was: Major) > PartyFinancialHistory throws an error > - > > Key: OFBIZ-13099 > URL: https://issues.apache.org/jira/browse/OFBIZ-13099 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Minor > > When accessing the financial history screen in the partymgr application (e.g. > via > [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] > following error multiple times are thrown: > {code:java} > 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator > |W| For performance reasons do not use the EntityListIterator.hasNext() > method, just call next() until it returns null; see JavaDoc comments in the > EntityListIterator class for details and an example > java.lang.Exception: null > at > org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) > [main/:?] > at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > [groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) > [groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) > [script:?] > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) > [main/:?] > at > org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) > [main/:?] > at > org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) > [main/:?] > at > org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) > [main/:?] > at > org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) > [main/:?] > at > org.apache.ofbiz.widget.model.ModelScreenWi
[jira] [Updated] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-13099: Description: When accessing the financial history screen in the partymgr application (e.g. via [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] following error multiple times are thrown: {code:java} 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator |W| For performance reasons do not use the EntityListIterator.hasNext() method, just call next() until it returns null; see JavaDoc comments in the EntityListIterator class for details and an example java.lang.Exception: null at org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) [main/:?] at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) [groovy-3.0.21.jar:3.0.21] at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) [groovy-3.0.21.jar:3.0.21] at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) [groovy-3.0.21.jar:3.0.21] at org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) [script:?] at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) [main/:?] at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) [main/:?] at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) [main/:?] at org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) [main/:?] at org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) [main/:?] at org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) [main/:?] at org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) [main/:?] at org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main
[jira] [Updated] (OFBIZ-13099) PartyFinancialHistory throws an error
[ https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13099: - Description: When accessing the financial history screen in the partymgr application (e.g. via [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier),] following error multiple times are thrown: {code:java} 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator |W| For performance reasons do not use the EntityListIterator.hasNext() method, just call next() until it returns null; see JavaDoc comments in the EntityListIterator class for details and an example java.lang.Exception: null at org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) [main/:?] at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) [groovy-3.0.21.jar:3.0.21] at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) [groovy-3.0.21.jar:3.0.21] at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) [groovy-3.0.21.jar:3.0.21] at org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) [script:?] at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) [main/:?] at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) [main/:?] at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) [main/:?] at org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) [main/:?] at org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) [main/:?] at org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) [main/:?] at org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) [main/:?] at org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main
[jira] [Created] (OFBIZ-13099) PartyFinancialHistory throws an error
Pierre Smits created OFBIZ-13099: Summary: PartyFinancialHistory throws an error Key: OFBIZ-13099 URL: https://issues.apache.org/jira/browse/OFBIZ-13099 Project: OFBiz Issue Type: Bug Components: party Reporter: Pierre Smits When accessing the financial history screen in the partymgr application (e.g. via [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier),] following error multiple times: {code:java} 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator |W| For performance reasons do not use the EntityListIterator.hasNext() method, just call next() until it returns null; see JavaDoc comments in the EntityListIterator class for details and an example java.lang.Exception: null at org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283) [main/:?] at java_util_ListIterator$hasNext.call(Unknown Source) [?:?] at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) [groovy-3.0.21.jar:3.0.21] at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) [groovy-3.0.21.jar:3.0.21] at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130) [groovy-3.0.21.jar:3.0.21] at org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49) [script:?] at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) [main/:?] at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) [main/:?] at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) [main/:?] at org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716) [main/:?] at org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138) [main/:?] at org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) [main/:?] at org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188) [main/:?] at org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?] at org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481) [main
[jira] [Commented] (OFBIZ-13092) Prevent special encoded characters sequences in URLs
[ https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849204#comment-17849204 ] ASF subversion and git services commented on OFBIZ-13092: - Commit 474e806816e4a1d0c16667972e5044ce2ded9d13 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=474e806816 ] Improved: Prevent special encoded characters sequences in URLs (OFBIZ-13092) Removes now redundant calls to URI::normalize in ControlFilter and LoginWorker classes Also removes few trailing blanks when needed (automatically done by Eclipse) > Prevent special encoded characters sequences in URLs > > > Key: OFBIZ-13092 > URL: https://issues.apache.org/jira/browse/OFBIZ-13092 > Project: OFBiz > Issue Type: Sub-task > Components: framework/webapp >Affects Versions: 18.12.14 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.14 > > > Better avoid special encoded characters sequences -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12653) Sanitizer fail
[ https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849199#comment-17849199 ] Jacques Le Roux commented on OFBIZ-12653: - It was unrelated to this Jira but related to OFBIZ-12691. Improved with https://github.com/apache/ofbiz-framework/commit/98febce8c3594d0f8bb5e1fc7a6c09dadffd113d > Sanitizer fail > --- > > Key: OFBIZ-12653 > URL: https://issues.apache.org/jira/browse/OFBIZ-12653 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, > UtilCodec.patch > > > I copied a text with multiple lines from a text editor into the Trumbowyg > Html field.The editor creates the Html structure using unclosed elements. > Unfortunately the sanitizer logic just takes . A security warning is > thrown and the content will not be stored. > Issue also a request on Trumbowyg request list: > [https://github.com/Alex-D/Trumbowyg/issues/1283] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12691) Extend HTML Sanitizer - style attribute
[ https://issues.apache.org/jira/browse/OFBIZ-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849198#comment-17849198 ] ASF subversion and git services commented on OFBIZ-12691: - Commit 98febce8c3594d0f8bb5e1fc7a6c09dadffd113d in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=98febce8c3 ] Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691) Like we allowed ' and \ this allows @ to be used in email addresses. There is no risk with that. If someone try to add something risky beside like it will be rejected anyway > Extend HTML Sanitizer - style attribute > --- > > Key: OFBIZ-12691 > URL: https://issues.apache.org/jira/browse/OFBIZ-12691 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: SanitizerStyle.patch > > > Right now it is not possible to assign inline style to html content. > Trumbowyg Editor uses such tags for align paragraphs. > style="text-align:right" > It is necessary to remove space within the attribute and remove the trailing > semicolon in order to apply with OWASP filter rules. > Create or open content with "Long text". Goto dataresource and edit HTML. Put > in some text and use the align icons (right, center ...) to format the text. > Save. You will get a security info. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12691) Extend HTML Sanitizer - style attribute
[ https://issues.apache.org/jira/browse/OFBIZ-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17605242#comment-17605242 ] Jacques Le Roux edited comment on OFBIZ-12691 at 5/24/24 6:31 AM: -- Commit 71cf2a8b8d9a0beea5960442706320561351f1f6 in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=71cf2a8b8d ] Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691) This is a no functional changes. It makes things clearer. I initially wanted to rather do that and forgot. The idea is to no change the sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the comparison with unescapeEcmaScriptAndHtml4 works. Maybe later we will figure out that some more HTML entities will need to be added to {noformat} "" and "" {noformat} ... was (Author: jira-bot): Commit 71cf2a8b8d9a0beea5960442706320561351f1f6 in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=71cf2a8b8d ] Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691) This is a no functional changes. It makes things clearer. I initially wanted to rather do that and forgot. The idea is to no change the sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the comparison with unescapeEcmaScriptAndHtml4 works. Maybe later we will figure out that some more HTML entities will need to be added to "" and ""... > Extend HTML Sanitizer - style attribute > --- > > Key: OFBIZ-12691 > URL: https://issues.apache.org/jira/browse/OFBIZ-12691 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: SanitizerStyle.patch > > > Right now it is not possible to assign inline style to html content. > Trumbowyg Editor uses such tags for align paragraphs. > style="text-align:right" > It is necessary to remove space within the attribute and remove the trailing > semicolon in order to apply with OWASP filter rules. > Create or open content with "Long text". Goto dataresource and edit HTML. Put > in some text and use the align icons (right, center ...) to format the text. > Save. You will get a security info. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12691) Extend HTML Sanitizer - style attribute
[ https://issues.apache.org/jira/browse/OFBIZ-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17605243#comment-17605243 ] Jacques Le Roux edited comment on OFBIZ-12691 at 5/24/24 6:31 AM: -- Commit c005971e4be56ef7928a6f7d0b7f438e4aa64765 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c005971e4b ] Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691) This is a no functional changes. It makes things clearer. I initially wanted to rather do that and forgot. The idea is to no change the sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the comparison with unescapeEcmaScriptAndHtml4 works. Maybe later we will figure out that some more HTML entities will need to be added to {noformat} "" and "" {noformat} ... was (Author: jira-bot): Commit c005971e4be56ef7928a6f7d0b7f438e4aa64765 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c005971e4b ] Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691) This is a no functional changes. It makes things clearer. I initially wanted to rather do that and forgot. The idea is to no change the sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the comparison with unescapeEcmaScriptAndHtml4 works. Maybe later we will figure out that some more HTML entities will need to be added to "" and ""... > Extend HTML Sanitizer - style attribute > --- > > Key: OFBIZ-12691 > URL: https://issues.apache.org/jira/browse/OFBIZ-12691 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: SanitizerStyle.patch > > > Right now it is not possible to assign inline style to html content. > Trumbowyg Editor uses such tags for align paragraphs. > style="text-align:right" > It is necessary to remove space within the attribute and remove the trailing > semicolon in order to apply with OWASP filter rules. > Create or open content with "Long text". Goto dataresource and edit HTML. Put > in some text and use the align icons (right, center ...) to format the text. > Save. You will get a security info. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12653) Sanitizer fail
[ https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849164#comment-17849164 ] Jacques Le Roux commented on OFBIZ-12653: - BTW could you not replace exam...@example.com by example at example.com? > Sanitizer fail > --- > > Key: OFBIZ-12653 > URL: https://issues.apache.org/jira/browse/OFBIZ-12653 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, > UtilCodec.patch > > > I copied a text with multiple lines from a text editor into the Trumbowyg > Html field.The editor creates the Html structure using unclosed elements. > Unfortunately the sanitizer logic just takes . A security warning is > thrown and the content will not be stored. > Issue also a request on Trumbowyg request list: > [https://github.com/Alex-D/Trumbowyg/issues/1283] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12653) Sanitizer fail
[ https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849163#comment-17849163 ] Jacques Le Roux commented on OFBIZ-12653: - Hi Chenghu Shan, When you say the last commit I guess you speak about the trunk? Because the 22.01 branch has been somehow deprecated. > Sanitizer fail > --- > > Key: OFBIZ-12653 > URL: https://issues.apache.org/jira/browse/OFBIZ-12653 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, > UtilCodec.patch > > > I copied a text with multiple lines from a text editor into the Trumbowyg > Html field.The editor creates the Html structure using unclosed elements. > Unfortunately the sanitizer logic just takes . A security warning is > thrown and the content will not be stored. > Issue also a request on Trumbowyg request list: > [https://github.com/Alex-D/Trumbowyg/issues/1283] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12765) Improvement to createPartyRelationship service
[ https://issues.apache.org/jira/browse/OFBIZ-12765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849113#comment-17849113 ] Michael Brohl commented on OFBIZ-12765: --- [~thahn] sorry, I meant to address this to [~cshan] > Improvement to createPartyRelationship service > --- > > Key: OFBIZ-12765 > URL: https://issues.apache.org/jira/browse/OFBIZ-12765 > Project: OFBiz > Issue Type: Improvement > Components: party >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > Currently, createPartyRelationship service does not allow the creation of a > new PartyRelationship of the same parties until the thruDate has passed. This > also disallows the creation new PartyRelationships of the same parties beyond > that thruDate. > This improvement checks for time interval conflicts and allows the creation > of a different PartyRelationship of the same parties before the thruDate has > passed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12765) Improvement to createPartyRelationship service
[ https://issues.apache.org/jira/browse/OFBIZ-12765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849112#comment-17849112 ] Michael Brohl commented on OFBIZ-12765: --- [~thahn] can you please resolve the PR conflicts and provide an new PR, thanks! > Improvement to createPartyRelationship service > --- > > Key: OFBIZ-12765 > URL: https://issues.apache.org/jira/browse/OFBIZ-12765 > Project: OFBiz > Issue Type: Improvement > Components: party >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > Currently, createPartyRelationship service does not allow the creation of a > new PartyRelationship of the same parties until the thruDate has passed. This > also disallows the creation new PartyRelationships of the same parties beyond > that thruDate. > This improvement checks for time interval conflicts and allows the creation > of a different PartyRelationship of the same parties before the thruDate has > passed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12815) EntityUtil getProperty Methods dont use entity
[ https://issues.apache.org/jira/browse/OFBIZ-12815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849110#comment-17849110 ] Michael Brohl commented on OFBIZ-12815: --- [~thahn] please check the comments in the pull requests, thanks! > EntityUtil getProperty Methods dont use entity > -- > > Key: OFBIZ-12815 > URL: https://issues.apache.org/jira/browse/OFBIZ-12815 > Project: OFBiz > Issue Type: Improvement > Components: framework/entity >Affects Versions: 18.12.07 >Reporter: Tobias Hahn >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > The getProperty methods in EntityUtilProperties don't use entity at all. All > of the getProperty methods simply lead to UtilProperties and therefore no > configure during runtime is possible. New methods have been written so the > entity usage is now functional. > Due to a wrong commit description/title the PR #634 were closed. i opened a > new PR #635. > Also i will adjust the code with an upcoming commit, thanks to Gil who > commented on PR #634. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12829) Improvements for ContentWorker methods and view-entities
[ https://issues.apache.org/jira/browse/OFBIZ-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12829. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks [~cshan] ! > Improvements for ContentWorker methods and view-entities > > > Key: OFBIZ-12829 > URL: https://issues.apache.org/jira/browse/OFBIZ-12829 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > Adds additional methods to ContentWorker: > * New method findAlternateLocalContents to find all alternate locale > contents instead of just one specific. > * Overloaded methods of findAlternateLocalContents and > findAlternateLocalContent to enable/disable cache use. > * These methods are no longer case sensitive when comparing localeStrings > Changes to view-entites ProductContentAndInfo and > ProductCategoryContentAndInfo: > * Both now use an outer join instead of inner join between DataResource and > Content, because there may be a Content object without a DataResource for its > locale but with alternate locale content objects associated to it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12829) Improvements for ContentWorker methods and view-entities
[ https://issues.apache.org/jira/browse/OFBIZ-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849106#comment-17849106 ] ASF subversion and git services commented on OFBIZ-12829: - Commit e7420fe4cf40f21e03bba3566d9b99d63a6e79a5 in ofbiz-framework's branch refs/heads/trunk from Cheng Hu Shan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e7420fe4cf ] Improvements for ContentWorker methods and view-entities (OFBIZ-12829) > Improvements for ContentWorker methods and view-entities > > > Key: OFBIZ-12829 > URL: https://issues.apache.org/jira/browse/OFBIZ-12829 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > Adds additional methods to ContentWorker: > * New method findAlternateLocalContents to find all alternate locale > contents instead of just one specific. > * Overloaded methods of findAlternateLocalContents and > findAlternateLocalContent to enable/disable cache use. > * These methods are no longer case sensitive when comparing localeStrings > Changes to view-entites ProductContentAndInfo and > ProductCategoryContentAndInfo: > * Both now use an outer join instead of inner join between DataResource and > Content, because there may be a Content object without a DataResource for its > locale but with alternate locale content objects associated to it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12843) Refactoring WebSiteProperties.java
[ https://issues.apache.org/jira/browse/OFBIZ-12843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12843. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks [~cshan] ! > Refactoring WebSiteProperties.java > -- > > Key: OFBIZ-12843 > URL: https://issues.apache.org/jira/browse/OFBIZ-12843 > Project: OFBiz > Issue Type: Improvement > Components: framework/webapp >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Trivial > Fix For: Upcoming Branch > > > Class WebSiteProperties.java contains some duplicate code and should be > refactored. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12843) Refactoring WebSiteProperties.java
[ https://issues.apache.org/jira/browse/OFBIZ-12843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849104#comment-17849104 ] ASF subversion and git services commented on OFBIZ-12843: - Commit a1e700b7d2d801d0c74298ca22c28c2e373281d9 in ofbiz-framework's branch refs/heads/trunk from Cheng Hu Shan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a1e700b7d2 ] Improved: Refactoring WebSiteProperties.java (OFBIZ-12843) > Refactoring WebSiteProperties.java > -- > > Key: OFBIZ-12843 > URL: https://issues.apache.org/jira/browse/OFBIZ-12843 > Project: OFBiz > Issue Type: Improvement > Components: framework/webapp >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Trivial > > Class WebSiteProperties.java contains some duplicate code and should be > refactored. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12843) Refactoring WebSiteProperties.java
[ https://issues.apache.org/jira/browse/OFBIZ-12843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12843: - Assignee: Michael Brohl (was: Chenghu Shan) > Refactoring WebSiteProperties.java > -- > > Key: OFBIZ-12843 > URL: https://issues.apache.org/jira/browse/OFBIZ-12843 > Project: OFBiz > Issue Type: Improvement > Components: framework/webapp >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Trivial > > Class WebSiteProperties.java contains some duplicate code and should be > refactored. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12886) Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder
[ https://issues.apache.org/jira/browse/OFBIZ-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12886. - Fix Version/s: Upcoming Branch Resolution: Fixed Thanks [~elolaki] ! > Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder > - > > Key: OFBIZ-12886 > URL: https://issues.apache.org/jira/browse/OFBIZ-12886 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Elaheh Lolaki >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > When adding products with an attribute, these are not transferred via the > addToCartFromOrder function -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12886) Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder
[ https://issues.apache.org/jira/browse/OFBIZ-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849041#comment-17849041 ] ASF subversion and git services commented on OFBIZ-12886: - Commit da3e353e51ac270c328c1f307d4c77ed356a8c75 in ofbiz-framework's branch refs/heads/trunk from Elaheh Lolaki [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=da3e353e51 ] Fixed: Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder. (OFBIZ-12886) > Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder > - > > Key: OFBIZ-12886 > URL: https://issues.apache.org/jira/browse/OFBIZ-12886 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Elaheh Lolaki >Assignee: Michael Brohl >Priority: Minor > > When adding products with an attribute, these are not transferred via the > addToCartFromOrder function -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13098) createTimesheetForThisWeek as admin fails
[ https://issues.apache.org/jira/browse/OFBIZ-13098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13098. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Fixed > createTimesheetForThisWeek as admin fails > - > > Key: OFBIZ-13098 > URL: https://issues.apache.org/jira/browse/OFBIZ-13098 > Project: OFBiz > Issue Type: Bug > Components: workeffort/workeffort >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > It works in 18.12 > Here is the error in UI: > org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request > [createTimesheetForThisWeek]; this request does not exist or cannot be called > directly. > In log: > 2024-05-23 08:40:43,872 |jsse-nio-8443-exec-3 |ControlServlet > |E| Error in request handler: > org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request > [createTimesheetForThisWeek]; this request does not exist or cannot be called > directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12262) Execute a callback with parameters from the request
[ https://issues.apache.org/jira/browse/OFBIZ-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848843#comment-17848843 ] ASF subversion and git services commented on OFBIZ-12262: - Commit e4bb0757a43e1194d82354b218ff2816741a420a in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e4bb0757a4 ] Fixed: createTimesheetForThisWeek as admin fails (OFBIZ-13098) At least the below block of controller request-maps was removed by OFBIZ-12262 Maybe more there are a log of changes in the controller > Execute a callback with parameters from the request > --- > > Key: OFBIZ-12262 > URL: https://issues.apache.org/jira/browse/OFBIZ-12262 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Gil Portenseigne >Priority: Minor > Attachments: > 0001-Execute-a-callback-with-parameters-from-the-request-.patch > > > With the new element set-callback (OFBIZ-11812) we have the possibility to > call a request with event and wait the success/error before continue and > update an area. > If the event generate a new value (createProduct, createPerson, ...) where we > need it for update the area, we can't generate the call. > A possible idea would be add a new parameter type when we define a callback > to indicate that we will wait the event return to resolve the value. Like > {code:java} > > > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)