[jira] [Comment Edited] (OFBIZ-9501) Move all data in applications to the datamodel component
[ https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432270#comment-16432270 ] Rishi Solanki edited comment on OFBIZ-9501 at 4/10/18 1:38 PM: --- Done at -r1828817. Thanks Taher! was (Author: rishisolankii): Done at -r1828817. > Move all data in applications to the datamodel component > > > Key: OFBIZ-9501 > URL: https://issues.apache.org/jira/browse/OFBIZ-9501 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: 17.12.01 >Reporter: Taher Alkhateeb >Assignee: Rishi Solanki >Priority: Minor > Labels: application, data > Fix For: Upcoming Branch > > Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, > OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, > OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, > OFBIZ-9501_Consolidated.patch > > > As per a community [discussion > thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E] > we decided to move all data (seed, seed-initial, demo) to the datamodel > component. and to also reduce and cleanup this data to ease debugging and > maintenance. > After moving all the data, the directory and file structure would be similar > to the below: > data/ > ├── demo > │ ├── AccountingDemoData.xml > │ ├── CommonDemoData.xml > │ ├── ContentDemoData.xml > │ ├── HumanresDemo.xml > │ ├── ManufacturingDemoData.xml > │ ├── MarketingDemoData.xml > │ ├── OrderDemoData.xml > │ ├── PartyDemoData.xml > │ ├── ProductDemoData.xml > │ ├── ShipmentDemoData.xml > │ └── WorkEffortDemoData.xml > ├── seed > │ ├── AccountingSeedData.xml > │ ├── CommonSeedData.xml > │ ├── ContentSeedData.xml > │ ├── HumanresSeedData.xml > │ ├── ManufacturingSeedData.xml > │ ├── MarketingSeedData.xml > │ ├── OrderSeedData.xml > │ ├── PartySeedData.xml > │ ├── ProductSeedData.xml > │ ├── ShipmentSeedData.xml > │ └── WorkEffortSeedData.xml > └── seed-initial > ├── AccountingSeedInitialData.xml > ├── CommonSeedInitialData.xml > ├── ContentSeedInitialData.xml > ├── HumanresSeedInitialData.xml > ├── ManufacturingSeedInitialData.xml > ├── MarketingSeedInitialData.xml > ├── OrderSeedInitialData.xml > ├── PartySeedInitialData.xml > ├── ProductSeedInitialData.xml > ├── ShipmentSeedInitialData.xml > └── WorkEffortSeedInitialData.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9501) Move all data in applications to the datamodel component
[ https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355016#comment-16355016 ] Rishi Solanki edited comment on OFBIZ-9501 at 2/7/18 6:26 AM: -- Thanks [~taher] for your continuous support and all who involve/help in this effort. Closing the ticket. All thanks again for your help. was (Author: rishisolankii): Thanks [~taher] for your continuous support and all who involve/help in this effort. Closing the ticket. All thanks again for your help. > Move all data in applications to the datamodel component > > > Key: OFBIZ-9501 > URL: https://issues.apache.org/jira/browse/OFBIZ-9501 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: 17.12.01 >Reporter: Taher Alkhateeb >Assignee: Rishi Solanki >Priority: Minor > Labels: application, data > Fix For: Upcoming Branch > > Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, > OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, > OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, > OFBIZ-9501_Consolidated.patch > > > As per a community [discussion > thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E] > we decided to move all data (seed, seed-initial, demo) to the datamodel > component. and to also reduce and cleanup this data to ease debugging and > maintenance. > After moving all the data, the directory and file structure would be similar > to the below: > data/ > ├── demo > │ ├── AccountingDemoData.xml > │ ├── CommonDemoData.xml > │ ├── ContentDemoData.xml > │ ├── HumanresDemo.xml > │ ├── ManufacturingDemoData.xml > │ ├── MarketingDemoData.xml > │ ├── OrderDemoData.xml > │ ├── PartyDemoData.xml > │ ├── ProductDemoData.xml > │ ├── ShipmentDemoData.xml > │ └── WorkEffortDemoData.xml > ├── seed > │ ├── AccountingSeedData.xml > │ ├── CommonSeedData.xml > │ ├── ContentSeedData.xml > │ ├── HumanresSeedData.xml > │ ├── ManufacturingSeedData.xml > │ ├── MarketingSeedData.xml > │ ├── OrderSeedData.xml > │ ├── PartySeedData.xml > │ ├── ProductSeedData.xml > │ ├── ShipmentSeedData.xml > │ └── WorkEffortSeedData.xml > └── seed-initial > ├── AccountingSeedInitialData.xml > ├── CommonSeedInitialData.xml > ├── ContentSeedInitialData.xml > ├── HumanresSeedInitialData.xml > ├── ManufacturingSeedInitialData.xml > ├── MarketingSeedInitialData.xml > ├── OrderSeedInitialData.xml > ├── PartySeedInitialData.xml > ├── ProductSeedInitialData.xml > ├── ShipmentSeedInitialData.xml > └── WorkEffortSeedInitialData.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9501) Move all data in applications to the datamodel component
[ https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323591#comment-16323591 ] Taher Alkhateeb edited comment on OFBIZ-9501 at 1/12/18 5:53 AM: - Hi Rishi It seems to me that maybe all demo data might be better placed in the datamodel component. I could be wrong but here are my thoughts: - first I think most of the demo data above populates entities defined in the data model component. It might be better for data to follow its entities location. - the reason why this JIRA was created is becauae I suffered while disentangling application dependencies on ecommerce. I think my life would have been easier if everything was in one place. - also demo data might be very useful even without the components. Demo data helps developers understand the entities by showing examples of populated data. Also if someone wants to develop their own custom accounting component for example then they can test it and check the interface using that demo data. Do I make sense? Or did I misunderstand something? Either way I'd love to hear your thoughts. And hats off for the great work you've done already. was (Author: taher): Hi Riahi It seems to me that maybe all demo data might be better placed in the datamodel component. I could be wrong but here are my thoughts: - first I think most of the demo data above populates entities defined in the data model component. It might be better for data to follow its entities location. - the reason why this JIRA was created is becauae I suffered while disentangling application dependencies on ecommerce. I think my life would have been easier if everything was in one place. - also demo data might be very useful even without the components. Demo data helps developers understand the entities by showing examples of populated data. Also if someone wants to develop their own custom accounting component for example then they can test it and check the interface using that demo data. Do I make sense? Or did I misunderstand something? Either way I'd love to hear your thoughts. And hats off for the great work you've done already. > Move all data in applications to the datamodel component > > > Key: OFBIZ-9501 > URL: https://issues.apache.org/jira/browse/OFBIZ-9501 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: 17.12.01 >Reporter: Taher Alkhateeb >Assignee: Rishi Solanki >Priority: Minor > Labels: application, data > Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, > OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, > OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, > OFBIZ-9501_Consolidated.patch > > > As per a community [discussion > thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E] > we decided to move all data (seed, seed-initial, demo) to the datamodel > component. and to also reduce and cleanup this data to ease debugging and > maintenance. > After moving all the data, the directory and file structure would be similar > to the below: > data/ > ├── demo > │ ├── AccountingDemoData.xml > │ ├── CommonDemoData.xml > │ ├── ContentDemoData.xml > │ ├── HumanresDemo.xml > │ ├── ManufacturingDemoData.xml > │ ├── MarketingDemoData.xml > │ ├── OrderDemoData.xml > │ ├── PartyDemoData.xml > │ ├── ProductDemoData.xml > │ ├── ShipmentDemoData.xml > │ └── WorkEffortDemoData.xml > ├── seed > │ ├── AccountingSeedData.xml > │ ├── CommonSeedData.xml > │ ├── ContentSeedData.xml > │ ├── HumanresSeedData.xml > │ ├── ManufacturingSeedData.xml > │ ├── MarketingSeedData.xml > │ ├── OrderSeedData.xml > │ ├── PartySeedData.xml > │ ├── ProductSeedData.xml > │ ├── ShipmentSeedData.xml > │ └── WorkEffortSeedData.xml > └── seed-initial > ├── AccountingSeedInitialData.xml > ├── CommonSeedInitialData.xml > ├── ContentSeedInitialData.xml > ├── HumanresSeedInitialData.xml > ├── ManufacturingSeedInitialData.xml > ├── MarketingSeedInitialData.xml > ├── OrderSeedInitialData.xml > ├── PartySeedInitialData.xml > ├── ProductSeedInitialData.xml > ├── ShipmentSeedInitialData.xml > └── WorkEffortSeedInitialData.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9501) Move all data in applications to the datamodel component
[ https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296256#comment-16296256 ] Swapnil M Mane edited comment on OFBIZ-9501 at 12/19/17 5:51 AM: - Kudos team, thanks to everyone who participated in this!! :-) was (Author: swapnilmmane): Kudos team, thank to everyone who participated in this!! :-) > Move all data in applications to the datamodel component > > > Key: OFBIZ-9501 > URL: https://issues.apache.org/jira/browse/OFBIZ-9501 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Assignee: Rishi Solanki >Priority: Minor > Labels: application, data > Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, > OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, > OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, > OFBIZ-9501_Consolidated.patch > > > As per a community [discussion > thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E] > we decided to move all data (seed, seed-initial, demo) to the datamodel > component. and to also reduce and cleanup this data to ease debugging and > maintenance. > After moving all the data, the directory and file structure would be similar > to the below: > data/ > ├── demo > │ ├── AccountingDemoData.xml > │ ├── CommonDemoData.xml > │ ├── ContentDemoData.xml > │ ├── HumanresDemo.xml > │ ├── ManufacturingDemoData.xml > │ ├── MarketingDemoData.xml > │ ├── OrderDemoData.xml > │ ├── PartyDemoData.xml > │ ├── ProductDemoData.xml > │ ├── ShipmentDemoData.xml > │ └── WorkEffortDemoData.xml > ├── seed > │ ├── AccountingSeedData.xml > │ ├── CommonSeedData.xml > │ ├── ContentSeedData.xml > │ ├── HumanresSeedData.xml > │ ├── ManufacturingSeedData.xml > │ ├── MarketingSeedData.xml > │ ├── OrderSeedData.xml > │ ├── PartySeedData.xml > │ ├── ProductSeedData.xml > │ ├── ShipmentSeedData.xml > │ └── WorkEffortSeedData.xml > └── seed-initial > ├── AccountingSeedInitialData.xml > ├── CommonSeedInitialData.xml > ├── ContentSeedInitialData.xml > ├── HumanresSeedInitialData.xml > ├── ManufacturingSeedInitialData.xml > ├── MarketingSeedInitialData.xml > ├── OrderSeedInitialData.xml > ├── PartySeedInitialData.xml > ├── ProductSeedInitialData.xml > ├── ShipmentSeedInitialData.xml > └── WorkEffortSeedInitialData.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9501) Move all data in applications to the datamodel component
[ https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159951#comment-16159951 ] Prakhar Kumar edited comment on OFBIZ-9501 at 9/9/17 2:05 PM: -- Provided the patch to move data from work effort component to data model component. In this patch, I have moved only the seed data. Also, I have moved some of the dependent party and content seed data to their respective files in data model component. Reference: [^OFBIZ-9501-WorkEffortSeedData.patch] was (Author: prakhar.kumar): Provided the patch to move data from work effort component to data model component. In this patch, I have moved only the seed data. Also, I have moved some of the dependent party and content seed data to their respective files in data model component. > Move all data in applications to the datamodel component > > > Key: OFBIZ-9501 > URL: https://issues.apache.org/jira/browse/OFBIZ-9501 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Assignee: Rishi Solanki >Priority: Minor > Labels: application, data > Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, > OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, > OFBIZ-9501-WorkEffortSeedData.patch > > > As per a community [discussion > thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E] > we decided to move all data (seed, seed-initial, demo) to the datamodel > component. and to also reduce and cleanup this data to ease debugging and > maintenance. > After moving all the data, the directory and file structure would be similar > to the below: > data/ > ├── demo > │ ├── AccountingDemoData.xml > │ ├── CommonDemoData.xml > │ ├── ContentDemoData.xml > │ ├── HumanresDemo.xml > │ ├── ManufacturingDemoData.xml > │ ├── MarketingDemoData.xml > │ ├── OrderDemoData.xml > │ ├── PartyDemoData.xml > │ ├── ProductDemoData.xml > │ ├── ShipmentDemoData.xml > │ └── WorkEffortDemoData.xml > ├── seed > │ ├── AccountingSeedData.xml > │ ├── CommonSeedData.xml > │ ├── ContentSeedData.xml > │ ├── HumanresSeedData.xml > │ ├── ManufacturingSeedData.xml > │ ├── MarketingSeedData.xml > │ ├── OrderSeedData.xml > │ ├── PartySeedData.xml > │ ├── ProductSeedData.xml > │ ├── ShipmentSeedData.xml > │ └── WorkEffortSeedData.xml > └── seed-initial > ├── AccountingSeedInitialData.xml > ├── CommonSeedInitialData.xml > ├── ContentSeedInitialData.xml > ├── HumanresSeedInitialData.xml > ├── ManufacturingSeedInitialData.xml > ├── MarketingSeedInitialData.xml > ├── OrderSeedInitialData.xml > ├── PartySeedInitialData.xml > ├── ProductSeedInitialData.xml > ├── ShipmentSeedInitialData.xml > └── WorkEffortSeedInitialData.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9501) move all data in applications to the datamodel component
[ https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097308#comment-16097308 ] Saurabh Dixit edited comment on OFBIZ-9501 at 7/22/17 2:14 PM: --- Provided patch to move data from content component to datamodel component. In the patch we have moved the data which only belongs to content. For now leaving other data in the file. Also I noticed that DataResource and ElectronicText exists in the seed data. On exploring I came to know that the data is for rendering the subcontent. Please suggest if we should consider it as demo or it is fine to have such data in seed/type data file. Reference: OFBIZ-9501-003.patch was (Author: saurabh.dixit): Attached the third patch in the sequence for review. Moved data from content component under applications to datamodel component. Although, I'm not sure if we should move some of them to demo instead of seed, like DataResource and its associated ElectronicText for rendering standard sub content? > move all data in applications to the datamodel component > > > Key: OFBIZ-9501 > URL: https://issues.apache.org/jira/browse/OFBIZ-9501 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: application, data > Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, > OFBIZ-9501-002.patch, OFBIZ-9501-003.patch > > > As per a community [discussion > thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E] > we decided to move all data (seed, seed-initial, demo) to the datamodel > component. and to also reduce and cleanup this data to ease debugging and > maintenance. > After moving all the data, the directory and file structure would be similar > to the below: > data/ > ├── demo > │ ├── AccountingDemoData.xml > │ ├── CommonDemoData.xml > │ ├── ContentDemoData.xml > │ ├── HumanresDemo.xml > │ ├── ManufacturingDemoData.xml > │ ├── MarketingDemoData.xml > │ ├── OrderDemoData.xml > │ ├── PartyDemoData.xml > │ ├── ProductDemoData.xml > │ ├── ShipmentDemoData.xml > │ └── WorkEffortDemoData.xml > ├── seed > │ ├── AccountingSeedData.xml > │ ├── CommonSeedData.xml > │ ├── ContentSeedData.xml > │ ├── HumanresSeedData.xml > │ ├── ManufacturingSeedData.xml > │ ├── MarketingSeedData.xml > │ ├── OrderSeedData.xml > │ ├── PartySeedData.xml > │ ├── ProductSeedData.xml > │ ├── ShipmentSeedData.xml > │ └── WorkEffortSeedData.xml > └── seed-initial > ├── AccountingSeedInitialData.xml > ├── CommonSeedInitialData.xml > ├── ContentSeedInitialData.xml > ├── HumanresSeedInitialData.xml > ├── ManufacturingSeedInitialData.xml > ├── MarketingSeedInitialData.xml > ├── OrderSeedInitialData.xml > ├── PartySeedInitialData.xml > ├── ProductSeedInitialData.xml > ├── ShipmentSeedInitialData.xml > └── WorkEffortSeedInitialData.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9501) move all data in applications to the datamodel component
[
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097233#comment-16097233
]
Taher Alkhateeb edited comment on OFBIZ-9501 at 7/22/17 10:36 AM:
--
Hi Prakhar,
Thank you for your work, its really great to see people contributing to this
JIRA.
I have a question: Aren't the below records from your patch belonging to the
"project" component? If yes wouldn't it be better to move it to that component
instead? I'm not sure if there are also more records, that was just a quick
skim.
{code:xml}
{code}
was (Author: taher):
Hi Prakhar,
Thank you for your work, its really great to see people contributing to this
JIRA.
I have a question: Aren't the below records from your patch belonging to the
"project" component? If yes wouldn't it be better to move it to that component
instead? I'm not sure if there are also more records, that was just a quick
skim.
{code: xml}
{code}
> move all data in applications to the datamodel component
>
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
> Labels: application, data
> Attachments: OFBIZ-9501-001.patch, OFBIZ-9501-002.patch
>
>
> As per a community [discussion
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
> we decided to move all data (seed, seed-initial, demo) to the datamodel
> component. and to also reduce and cleanup this data to ease debugging and
> maintenance.
> After moving all the data, the directory and file structure would be similar
> to the below:
> data/
> ├── demo
> │ ├── AccountingDemoData.xml
> │ ├── CommonDemoData.xml
> │ ├── ContentDemoData.xml
> │ ├── HumanresDemo.xml
> │ ├── ManufacturingDemoData.xml
> │ ├── MarketingDemoData.xml
> │ ├── OrderDemoData.xml
> │ ├── PartyDemoData.xml
> │ ├── ProductDemoData.xml
> │ ├── ShipmentDemoData.xml
> │ └── WorkEffortDemoData.xml
> ├── seed
> │ ├── AccountingSeedData.xml
> │ ├── CommonSeedData.xml
> │ ├── ContentSeedData.xml
> │ ├── HumanresSeedData.xml
> │ ├── ManufacturingSeedData.xml
> │ ├── MarketingSeedData.xml
> │ ├── OrderSeedData.xml
> │ ├── PartySeedData.xml
> │ ├── ProductSeedData.xml
> │ ├── ShipmentSeedData.xml
> │ └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
