[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026961#comment-17026961 ] ASF subversion and git services commented on OFBIZ-10607: - Commit 5570986d6dddb05ac385712b8149b1a28b4e5693 in ofbiz-framework's branch refs/heads/release18.12 from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5570986 ] Improved: ‘EntityOperator#getId()’ is not used in the framework (OFBIZ-10607) Thanks Mathieu Lirzin for reporting and providing the patch. > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Labels: backport-needed > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026959#comment-17026959 ] ASF subversion and git services commented on OFBIZ-10607: - Commit b0aff701d05989214a7be932915bcc6c6489fa09 in ofbiz-framework's branch refs/heads/release17.12 from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b0aff70 ] Improved: ‘EntityOperator#getId()’ is not used in the framework (OFBIZ-10607) Thanks Mathieu Lirzin for reporting and providing the patch. > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Labels: backport-needed > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740304#comment-16740304 ] Michael Brohl commented on OFBIZ-10607: --- I'll backport to 17.12/18.12 soon. > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Labels: backport-needed > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[
https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740303#comment-16740303
]
Michael Brohl commented on OFBIZ-10607:
---
{quote}Can you explain the issue with the patch I submitted?
{quote}
The patch format itself had no issue, but the patchfile itself contains more
than the patch. It seems it contains some surrounding email content.
Depending on the IDE used, this breaks automatic patch application. It's better
to only have the raw diff information inside the patch file to avoid extra work
for the reviewer/committer.
> ‘EntityOperator#getId()’ is not used in the framework
> -
>
> Key: OFBIZ-10607
> URL: https://issues.apache.org/jira/browse/OFBIZ-10607
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that
> ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added
> in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of
> additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a
> test demonstrated its purpose and describing how to use it. Otherwise we
> should simply delete it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740107#comment-16740107 ] Gil Portenseigne commented on OFBIZ-10607: -- Since it is an improvement and not a bugfix, no need to backport it IMO. But if done, it is not problematic :) > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[
https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740099#comment-16740099
]
Mathieu Lirzin commented on OFBIZ-10607:
Thanks Michael for reviewing and applying this patch,
Can you explain the issue with the patch I submitted? did it fail to apply with
the metadata? I am using {{git format-patch --no-prefix}} to generate my
patches which is a common practice in a lot of Free Software communities (Linux
Kernel/most GNU packages). I am willing to adapt the format of my patches. I
just want to understand what is the issue you are facing which is not obvious
for me.
> ‘EntityOperator#getId()’ is not used in the framework
> -
>
> Key: OFBIZ-10607
> URL: https://issues.apache.org/jira/browse/OFBIZ-10607
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that
> ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added
> in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of
> additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a
> test demonstrated its purpose and describing how to use it. Otherwise we
> should simply delete it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739594#comment-16739594 ] Jacques Le Roux commented on OFBIZ-10607: - We could since we should not expect any regression (unused code). But is it worth it? > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739575#comment-16739575 ] Michael Brohl commented on OFBIZ-10607: --- Not sure if we should backport it to 17.12/18.12 too? > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713971#comment-16713971 ] Jacques Le Roux commented on OFBIZ-10607: - I see no use OOTB, +1 > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713671#comment-16713671 ] Michael Brohl commented on OFBIZ-10607: --- +1 for removing the code. Any objections? > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650749#comment-16650749 ] Mathieu Lirzin commented on OFBIZ-10607: I have included [^OFBIZ-10607_Remove-EntityOperator-requestId.patch] which removes the unused code. > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
