[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929742#comment-16929742 ] Aditya Sharma commented on OFBIZ-10725: --- Thanks Jacques :) +1 for closing it. > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929732#comment-16929732 ] Jacques Le Roux commented on OFBIZ-10725: - If nobody is against I'd like to close this issue in a week. I fear it's hard to do better... > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929729#comment-16929729 ] Jacques Le Roux commented on OFBIZ-10725: - I added a last one in revision: 1866931, was fun but ain't easy to use regexp to automate the thing > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929728#comment-16929728 ] Jacques Le Roux commented on OFBIZ-10725: - I made some change in r1866929 and then fixed 2 of them in 1866930 > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829594#comment-16829594 ] Jacques Le Roux commented on OFBIZ-10725: - Thanks Guys, I intend to do some also... > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829046#comment-16829046
]
Jacques Le Roux commented on OFBIZ-10725:
-
Hi Aditya,
Even if this is not functional and minor, it's delicate, thanks for all your
work cleaning the code :)
I was wondering if we should close here. I just had a look and using this
regexp:
{code:java}
if \(.*\) \{\R.*return true;
{code}
I found
* 60 matches in applications
* 138 in framework
* 4 in plugins
I only checked the 1st two in applications and they really match (the regexp is
very simple).
While at it I improved 3 of the 4 in plugins (the other is in a loop) at
revision: 1858350
So let's keep it open, most if done, but if we get some spare time why not
continue :) For now I guess we have bigger fishes to fry even if it's always
hard to clearly define priority when it's about code.
> Refactor boolean returns from methods
> -
>
> Key: OFBIZ-10725
> URL: https://issues.apache.org/jira/browse/OFBIZ-10725
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745790#comment-16745790 ] Aditya Sharma commented on OFBIZ-10725: --- Verified and done for all the instances in classes under application at r1851602. > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743821#comment-16743821 ] Aditya Sharma commented on OFBIZ-10725: --- Done for GiftCertificateServices, UtilAccounting and ContentSearch for trunk at R1851425 > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732768#comment-16732768 ] Aditya Sharma commented on OFBIZ-10725: --- Done for all classes directly under org.apache.ofbiz.base.util & SeoConfigUtil.java for trunk at r1850223. > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730268#comment-16730268 ] Aditya Sharma commented on OFBIZ-10725: --- Done for all classes under org.apache.ofbiz.entity.condition for trunk at r1849846 > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728930#comment-16728930 ] Aditya Sharma commented on OFBIZ-10725: --- Improves code in methods: isPrimaryKey() of GenericEntity hasNext() and hasPrevious() of EntityListIterator isValueActive() of EntityUtil Additional change: Improved return for getStartIndexFromViewIndex() method in EntityUtil. Instead of using if-else block, a ternary operator is used for improving readability. Done for trunk at R1849741. > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
