[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager
[
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554580#comment-15554580
]
Jacques Le Roux commented on OFBIZ-8154:
Ouch, this is very tedious now and I'd appreciate some help, else this will
remain open a long time I guess...
Nevertheless, at r1763695 and r1763701 and I have kept labels wich are actually
used or are useful even if empty.
Now I was removing really unused labels, but I feel it's a pity to do so. I
guess most of them are from pre Apache era and were really never used but since
then the community filled the l10n parts and it does not hurt to not remove
them. I speak for instance about:
{code}
Index: OrderErrorUiLabels.xml
===
--- OrderErrorUiLabels.xml (revision 1763694)
+++ OrderErrorUiLabels.xml (working copy)
@@ -5119,16 +5119,6 @@
在添加到购物车之前请配置产品
在添加到購物車之前請配置產品
-
-Fehler: Eine Abhängigkeit zu einem anderen
Merkmal konnte nicht aufgelöst werden.
-Error: a dependency to another feature has not
been resolved.
-Erreur : une dépendance envers une autre option
n'a pu être résolue.
-エラー: 別の機能への依存関係が解消していません
-Erro: uma dependência de outra funcionalidade
não foi resolvida
-Lỗi xảy ra: một phụ thuộc (dependency) vào tính
năng khác (feature) chưa được xử lý
-错误：尚未解决对另一个特性的依赖。
-錯誤：尚未解決對另一個特性的依賴。
-
ادخل المبلغ قبل الإضافة إلى العربة
Geben sie einen Betrag vor dem Hinzufügen zum
Warenkorb ein
@@ -5183,23 +5173,6 @@
没有传递产品信息，没有向购物车添加任何明细。
沒有傳遞產品資訊，沒有向購物車添加任何明細。
-
-الإعدادات غير صالحة
-Konfiguration ist nicht gültig
-Configuration Is Not Valid
-La configuración no es válida
-La configuration n'est pas valide
-Configurazione Non E' Valida
-設定が正しくありません
-A configuração não é válida
-Configurarea Nu este Valida
-Неверная конфигурация
-ไม่มีค่าองค์ประกอบ
-Cấu hình tùy chọn không hợp lệ
-配置无效
-配置无效
-配置無效
-
Dezimalmenge ist nicht erlaubt.
Quantity in decimal is not allowed.
@@ -5244,23 +5217,6 @@
把 ${totalQuantity} 明细添加到购物车。
把 ${totalQuantity} 明細添加到購物車。
-
-لم تحدد إتفاقية للإضافة من.
-Kein Vertrag angegeben, aus dem hinzugefügt
werden kann.
-No agreement specified to add from.
-No se ha indicado un acuerdo del que se pueda
añadir.
-Aucun accord spécifié à partir duquel
ajouter.
-Nessun contratto specificato da
aggiungere.
-追加元の同意が指定されていません。
-Nenhum acordo especificado como fonte da
adição.
-Nici-un contract specificat de adaugat.
-Не указаны договора.
-ไม่ระบุสัญญาจากการเพิ่ม
-Không có thỏa thuận nào để thêm vào.
-没有指定要添加进来的合同。
-没有指定的协议被加入
-沒有指定要添加進來的合同。
-
المبلغ يجب أن يكون رقم موجب
Der Betrag muss eine positive Zahl sein
@@ -5302,40 +5258,6 @@
没有指定的分类被加入
沒有指定要添加進來的分類。
-
-لا يمكن إضافة السلعة ${productId} إلى
العربة
-Produkt ${productId} konnte dem Warenkorb NICHT
hinzugefügt werden.
-Could NOT add product ${productId} to
cart.
-No se puede añadir el producto ${productId} al
carro.
-Impossible d'ajouter l'article ${productId} au
panier.
-NON è Possibile aggiungere prodotto ${productId}
al carrello.
-製品 ${productId} を買い物かごに追加できません。
-Não foi possível adicionar produto
${productId}
-Nu este Posibila adaugare produs ${productId} in
cos.
-Не смог добавить продукт ${productId} в
корзину.
-ไม่สามารถเพิ่มสินค้า ${productId}
ลงตระกร้า
-Không thể thêm sản phẩm ${productId} vào giỏ
hàng.
-不能把产品 ${productId} 添加到购物车。
-不能加入产品 ${productId} 到购物车.
-不能把產品 ${productId} 添加到購物車。
-
-
-لا يمكن المرور للإتفاقية ${agreementId} {read
error}: ${message}.
-Konnte Vertrag nicht holen mit der Vertrag ID
${agreementId} (Lesefehler): ${message}
-Could not get agreement through ${agreementId}
{read error}: ${message}.
-No se pudo obtener el acuerdo con ${agreementId}
{read error}: ${message}.
-Impossible d'obtenir un accord par ${agreementId}
{read error} : ${message}.
-Non è possibile leggere il contratto attraverso
${agreementId} {read error}: ${message}.
-同意を取得できません ${agreementId} {読み込みエラー}:
${message}。
-Não foi possível obter acordo através do
Acordo ${agreementId} {read error} : ${message}.
-Nu este posibila Citirea contractului prin
${agreementId} {read error}: ${message}.
-Не смог получить договор в результате
${agreementId} {read error}: ${message}.
-ไม่สามารถรับข้อสัญญาเนื่องจาก ${agreementId}
[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager
[ https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495480#comment-15495480 ] Jacques Le Roux commented on OFBIZ-8154: It's a pity, because of the translations, but the labels starting by "HumanResServices.", which dates from pre Apache era, are not used OOTB, so I removed them .portalPageName. is used by demo data ProductStoreGroup.productStoreGroupName.NA is used as data by ProductTypeData.xml FormFieldTitle_timesheetPartyId in ProjectMgrUiLabels.xml seems an error. As it duplicates the same in AccountingUiLabels.xml, which is accurate, I remove it from ProjectMgrUiLabels Committed at revision: 1760995 We have now only 1838 (instead of 5237 initially) "Not Used Labels". Still to consider: the labels following WorkEffortWorkEffortIdEmpty in the list returned by the "Not Used Labels" options > The entity description labels are considered not used by the Label Manager > -- > > Key: OFBIZ-8154 > URL: https://issues.apache.org/jira/browse/OFBIZ-8154 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > As I said in my r1759457 commit comment: > bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just > checked some an indeed, they were not used. But there are also a huge bunch > of *.description.* labels which certainly make sense. I'll remove them from > the "Only Not Used Labels" result in another Jira I'll create > Here is the promised Jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager
[ https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490060#comment-15490060 ] Jacques Le Roux commented on OFBIZ-8154: FieldDescription. is used in 2 places UtilHelpText.java (widget) WebToolsServices.java HumanResServices. seems unused and should be removed .portalPageName. is doubtful to be double checked ProductShipmentUomAbbreviation_ used in PackOrder.ftl and WeightPackage.ftl ProductStoreGroup.productStoreGroupName.NA not sure TemporalExpression_ used in many place: ServiceDemoData.xml, ExpressionUiHelper.java, TempExprMaint.ftl and TemporalExpressions.java Committed at revision: 1760668 > The entity description labels are considered not used by the Label Manager > -- > > Key: OFBIZ-8154 > URL: https://issues.apache.org/jira/browse/OFBIZ-8154 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > As I said in my r1759457 commit comment: > bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just > checked some an indeed, they were not used. But there are also a huge bunch > of *.description.* labels which certainly make sense. I'll remove them from > the "Only Not Used Labels" result in another Jira I'll create > Here is the promised Jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager
[
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488186#comment-15488186
]
Jacques Le Roux commented on OFBIZ-8154:
Current situation, still to check
{quote}
FormFieldTitle_???
FieldDescription.ProductStore.???
FieldDescription.ProdCatalog.???
HumanResServices.???
.portalPageName.???
ProductShipmentUomAbbreviation_???
ProductStoreGroup.productStoreGroupName.NA???
TemporalExpression_???
After WorkEffortWorkEffortIdEmpty
FormFieldTitle_timesheetPartyId x2
{quote}
> The entity description labels are considered not used by the Label Manager
> --
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just
> checked some an indeed, they were not used. But there are also a huge bunch
> of *.description.* labels which certainly make sense. I'll remove them from
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager
[ https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479501#comment-15479501 ] Jacques Le Roux commented on OFBIZ-8154: At r1760139, I commited a fix We had 5237 "Not Used Labels". I wondered if they were all real. There is actually a huge bunch of *.description.* labels and alike which are certainly used, notably automatically by the widget dropdowns. This commit removes them from the "Only Not Used Labels" result. Net result: from 5237 to decent 2188 "Not Used Labels", this begins to be useful... It only begins because I removed from the "Not Used Labels" a number of other cases similar to the obvious *.description.* labels. those are .transitionName. .partyRelationshipName. .geoName. .categoryName. .ProductPromoCondition.. .ProductPromoOperatorEquality.. .Example. // TODO check all is used here But a number of others need to be verified, at least: FormFieldTitle_??? FieldDescription.ProductStore.??? FieldDescription.ProdCatalog.??? HumanResServices.??? .portalPageName.??? ProductShipmentUomAbbreviation_??? ProductStoreGroup.productStoreGroupName._NA_??? TemporalExpression_??? After WorkEffortWorkEffortIdEmpty FormFieldTitle_timesheetPartyId x2 > The entity description labels are considered not used by the Label Manager > -- > > Key: OFBIZ-8154 > URL: https://issues.apache.org/jira/browse/OFBIZ-8154 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > As I said in my r1759457 commit comment: > bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just > checked some an indeed, they were not used. But there are also a huge bunch > of *.description.* labels which certainly make sense. I'll remove them from > the "Only Not Used Labels" result in another Jira I'll create > Here is the promised Jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
