[GitHub] [ofbiz-framework] PierreSmits commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
PierreSmits commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560 Jaqcues, The pull request is good enough, and can be committed as such. When committed it will create an opportunity for other contributors to enhance when that need arises. I would not want to deprive others from participating. Best regards, Pierre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits edited a comment on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
PierreSmits edited a comment on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560 Jaqcues, The pull request is good enough, and can be merged as such. When committed it will create an opportunity for other contributors to enhance when that need arises. I would not want to deprive others from participating. Best regards, Pierre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346036#comment-17346036
]
ASF subversion and git services commented on OFBIZ-12233:
-
Commit b8f9c029cedea15d6145a6325e8b203a05bd27cf in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b8f9c02 ]
Fixed: Plugin not showing in menu due to permission (OFBIZ-12233)
When creating a plugin via gradle :
./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
-PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
and loading all the required data and permissions, the plugin doesn't appear
in the menu.
It comes from the ComponentConfig.java file, L1229, when the permissions gets
trimmed and modified. I tried removing it locally and it fixed the problem.
Thanks: Gaetan Chaboussie
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346035#comment-17346035
]
ASF subversion and git services commented on OFBIZ-12233:
-
Commit 69ce0dffc88a35a5a4753754e36685c6824ad43a in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=69ce0df ]
Fixed: Plugin not showing in menu due to permission (OFBIZ-12233)
When creating a plugin via gradle :
./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
-PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
and loading all the required data and permissions, the plugin doesn't appear
in the menu.
It comes from the ComponentConfig.java file, L1229, when the permissions gets
trimmed and modified. I tried removing it locally and it fixed the problem.
Thanks: Gaetan Chaboussie
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-12233:
---
Assignee: Jacques Le Roux
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-12233.
---
Fix Version/s: Release Branch 17.12
18.12.01
Resolution: Fixed
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, Release Branch 17.12
>
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346037#comment-17346037
]
ASF subversion and git services commented on OFBIZ-12233:
-
Commit fb0701b7bdf0e5c0e75f51237e2ee85689413b51 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fb0701b ]
Fixed: Plugin not showing in menu due to permission (OFBIZ-12233)
When creating a plugin via gradle :
./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
-PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
and loading all the required data and permissions, the plugin doesn't appear
in the menu.
It comes from the ComponentConfig.java file, L1229, when the permissions gets
trimmed and modified. I tried removing it locally and it fixed the problem.
Thanks: Gaetan Chaboussie
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346040#comment-17346040
]
Jacques Le Roux commented on OFBIZ-12233:
-
I wanted to assign to Gaetan, but it's impossible (no Gaetan in Jira, weird)
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, Release Branch 17.12
>
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #283: OFBIZ-11683 Fixed: Humanres tree allows existing OU to be added again
PierreSmits commented on pull request #283: URL: https://github.com/apache/ofbiz-framework/pull/283#issuecomment-842198387 Hi Sebastian, all, We should not regard departments as internal organisations (we should reserve that for fiscal/legal entities, requiring their own CoAs). The roll-up for departments should be: Best regards, Pierre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy
PierreSmits commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-842201456 Is this still not good enough to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
JacquesLeRoux commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842213276 Oh, too bad, it's impossible to me to add the change in your forked repo. I can merge/push as is but then I need to redo the trivial work again locally and commit from there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
PierreSmits commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842214368 Yeah. Let's not bother with trivial work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
PierreSmits commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842215549 You don't have to do everything yourself, Jacques. Don't deprive other contributors of the opportunity. :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
sonarcloud[bot] commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) [4.2% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #239: Added Spanish Translations
PierreSmits commented on pull request #239: URL: https://github.com/apache/ofbiz-framework/pull/239#issuecomment-842225413 This appears good enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346075#comment-17346075 ] Pierre Smits commented on OFBIZ-11960: -- Hi Aditya, What is the rationale behind wanting this in the code base? Is there a discussion on dev? Best regards, Pierre > Use NPM with gradle to get external JS dependencies > --- > > Key: OFBIZ-11960 > URL: https://issues.apache.org/jira/browse/OFBIZ-11960 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > > 1. Add > [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: > Gradle plugin for integrating NodeJS in your build > 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in > webapp > 3. Use available tasks to install dependencies > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] > 4. Use the downloaded JS files in node_modules, updating the current path of > the JS files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
JacquesLeRoux merged pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12234) Have a entity label for OrderAdjustmentType.description.VAT_TAX
[
https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346093#comment-17346093
]
ASF subversion and git services commented on OFBIZ-12234:
-
Commit edcaf9d7054ed9070a972a61e0b084f993302949 in ofbiz-framework's branch
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=edcaf9d ]
Improvement: label OrderAdjustmentType (OFBIZ-12234) (#295)
-added the label
> Have a entity label for OrderAdjustmentType.description.VAT_TAX
> ---
>
> Key: OFBIZ-12234
> URL: https://issues.apache.org/jira/browse/OFBIZ-12234
> Project: OFBiz
> Issue Type: Improvement
> Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Currently there are no labels for
> {color:#ff}OrderAdjustmentType.description.VAT_TAX{color}
> and thus there is no correct translation shown for the user with a different
> locale in the checkout process
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12234) Have a entity label for OrderAdjustmentType.description.VAT_TAX
[
https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-12234:
-
Fix Version/s: Trunk
> Have a entity label for OrderAdjustmentType.description.VAT_TAX
> ---
>
> Key: OFBIZ-12234
> URL: https://issues.apache.org/jira/browse/OFBIZ-12234
> Project: OFBiz
> Issue Type: Improvement
> Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Trunk
>
>
> Currently there are no labels for
> {color:#ff}OrderAdjustmentType.description.VAT_TAX{color}
> and thus there is no correct translation shown for the user with a different
> locale in the checkout process
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-12234) Have a entity label for OrderAdjustmentType.description.VAT_TAX
[
https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits closed OFBIZ-12234.
Resolution: Implemented
> Have a entity label for OrderAdjustmentType.description.VAT_TAX
> ---
>
> Key: OFBIZ-12234
> URL: https://issues.apache.org/jira/browse/OFBIZ-12234
> Project: OFBiz
> Issue Type: Improvement
> Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Trunk
>
>
> Currently there are no labels for
> {color:#ff}OrderAdjustmentType.description.VAT_TAX{color}
> and thus there is no correct translation shown for the user with a different
> locale in the checkout process
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12234) Have a entity label for OrderAdjustmentType.description.VAT_TAX
[
https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits reassigned OFBIZ-12234:
Assignee: Pierre Smits
> Have a entity label for OrderAdjustmentType.description.VAT_TAX
> ---
>
> Key: OFBIZ-12234
> URL: https://issues.apache.org/jira/browse/OFBIZ-12234
> Project: OFBiz
> Issue Type: Improvement
> Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Trunk
>
>
> Currently there are no labels for
> {color:#ff}OrderAdjustmentType.description.VAT_TAX{color}
> and thus there is no correct translation shown for the user with a different
> locale in the checkout process
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-12240) Correct translation for OrderAdjustmentType is not show in order
Pierre Smits created OFBIZ-12240: Summary: Correct translation for OrderAdjustmentType is not show in order Key: OFBIZ-12240 URL: https://issues.apache.org/jira/browse/OFBIZ-12240 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk, Release Branch 18.12, Release Branch 17.12 Reporter: Pierre Smits When using a 'ecommerce' customer with a different locale (e.g. EuroCustomer, or FrenchCustomer' the line items for order adjustments don't show the description in the correct language. Only the 'English' variant is shown. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12240) Correct translation for OrderAdjustmentType is not shown in order
[ https://issues.apache.org/jira/browse/OFBIZ-12240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12240: - Summary: Correct translation for OrderAdjustmentType is not shown in order (was: Correct translation for OrderAdjustmentType is not show in order) > Correct translation for OrderAdjustmentType is not shown in order > - > > Key: OFBIZ-12240 > URL: https://issues.apache.org/jira/browse/OFBIZ-12240 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Priority: Major > > When using a 'ecommerce' customer with a different locale (e.g. EuroCustomer, > or FrenchCustomer' the line items for order adjustments don't show the > description in the correct language. Only the 'English' variant is shown. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12241) Improve EuroCustomer data
Pierre Smits created OFBIZ-12241: Summary: Improve EuroCustomer data Key: OFBIZ-12241 URL: https://issues.apache.org/jira/browse/OFBIZ-12241 Project: OFBiz Issue Type: Improvement Components: ecommerce, order Affects Versions: Trunk Reporter: Pierre Smits The demo data set for the party 'EuroCustomer' is intended to show functionallity in the ecommerce component, like ordering, viewing orders, showing labels in the Dutch locale (given that the address details are in the Netherlands. However, this can not be demonstrated as a user can't log in as such. This ticket is intended to improve such demo data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12241) Improve EuroCustomer data
[ https://issues.apache.org/jira/browse/OFBIZ-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-12241: Assignee: Pierre Smits > Improve EuroCustomer data > - > > Key: OFBIZ-12241 > URL: https://issues.apache.org/jira/browse/OFBIZ-12241 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: demo > > The demo data set for the party 'EuroCustomer' is intended to show > functionallity in the ecommerce component, like ordering, viewing orders, > showing labels in the Dutch locale (given that the address details are in the > Netherlands. > However, this can not be demonstrated as a user can't log in as such. > This ticket is intended to improve such demo data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11960: -- Description: As discussed [here|https://lists.apache.org/thread.html/re16808eb5b1084f822c74194d23ca073dea4f4df443184f40f5f58c6%40%3Cdev.ofbiz.apache.org%3E], use gradle-js-plugin to ease out managing the JavaScript dependencies. The Gradle plugin allows us to automatically download the js libraries to the user's system like the Gradle dependencies, so we no longer need to include them with the package. It opens door to all the packages and modules available at [npm registry|https://www.npmjs.com/]. Also, it can be clubbed with Grunt or Gulp implementing tasks to minify external JS and CSS files with the custom ones, see [here|https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages]. 1. Add [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: Gradle plugin for integrating NodeJS in your build 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in webapp 3. Use available tasks to install dependencies [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] 4. Use the downloaded JS files in node_modules, updating the current path of the JS files. was: 1. Add [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: Gradle plugin for integrating NodeJS in your build 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in webapp 3. Use available tasks to install dependencies [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] 4. Use the downloaded JS files in node_modules, updating the current path of the JS files. > Use NPM with gradle to get external JS dependencies > --- > > Key: OFBIZ-11960 > URL: https://issues.apache.org/jira/browse/OFBIZ-11960 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > > As discussed > [here|https://lists.apache.org/thread.html/re16808eb5b1084f822c74194d23ca073dea4f4df443184f40f5f58c6%40%3Cdev.ofbiz.apache.org%3E], > use gradle-js-plugin to ease out managing the JavaScript dependencies. The > Gradle plugin allows us to automatically download the js libraries to the > user's system like the Gradle dependencies, so we no longer need to include > them with the package. It opens door to all the packages and modules > available at [npm registry|https://www.npmjs.com/]. Also, it can be clubbed > with Grunt or Gulp implementing tasks to minify external JS and CSS files > with the custom ones, see > [here|https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages]. > 1. Add > [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: > Gradle plugin for integrating NodeJS in your build > 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in > webapp > 3. Use available tasks to install dependencies > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] > > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] > 4. Use the downloaded JS files in node_modules, updating the current path of > the JS files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346195#comment-17346195 ] Aditya Sharma commented on OFBIZ-11960: --- Thanks [~pierresmits] for the heads up. I have updated the description. > Use NPM with gradle to get external JS dependencies > --- > > Key: OFBIZ-11960 > URL: https://issues.apache.org/jira/browse/OFBIZ-11960 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > > As discussed > [here|https://lists.apache.org/thread.html/re16808eb5b1084f822c74194d23ca073dea4f4df443184f40f5f58c6%40%3Cdev.ofbiz.apache.org%3E], > use gradle-js-plugin to ease out managing the JavaScript dependencies. The > Gradle plugin allows us to automatically download the js libraries to the > user's system like the Gradle dependencies, so we no longer need to include > them with the package. It opens door to all the packages and modules > available at [npm registry|https://www.npmjs.com/]. Also, it can be clubbed > with Grunt or Gulp implementing tasks to minify external JS and CSS files > with the custom ones, see > [here|https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages]. > 1. Add > [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: > Gradle plugin for integrating NodeJS in your build > 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in > webapp > 3. Use available tasks to install dependencies > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks] > > > [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin] > 4. Use the downloaded JS files in node_modules, updating the current path of > the JS files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
sonarcloud[bot] commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842384525 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) [4.2% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
sonarcloud[bot] removed a comment on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) [4.2% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
adityasharma7 commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842388591 Hi @JacquesLeRoux, This is done now. Initially, I have added only jQuery, jQuery browser, and Validate plugin through npm. As these are the libraries required for the front end to work I have kept the npmInstall task part of the Java build, so it executes on each tasks. Steps to verify: 1. Fetch the branch on your local 2. Start the server You will notice packages being downloaded with npmInstall task https://user-images.githubusercontent.com/15027245/118508711-0dfd4900-b74d-11eb--18863cd40dcc.png";> You will find the node_modules under the js folder https://user-images.githubusercontent.com/15027245/118508970-4866e600-b74d-11eb-820c-2db716fd3b11.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
sonarcloud[bot] removed a comment on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842384525 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) [4.2% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
sonarcloud[bot] commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842389591 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) [3.7% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=230&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
JacquesLeRoux commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
JacquesLeRoux edited a comment on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683 Hi Pierre, Would you mind adding `TVA` in your forked repo and then update this PR? TIA :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
sonarcloud[bot] commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy
PierreSmits commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-842201456 Is this still not good enough to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #283: OFBIZ-11683 Fixed: Humanres tree allows existing OU to be added again
PierreSmits commented on pull request #283: URL: https://github.com/apache/ofbiz-framework/pull/283#issuecomment-842198387 Hi Sebastian, all, We should not regard departments as internal organisations (we should reserve that for fiscal/legal entities, requiring their own CoAs). The roll-up for departments should be: Best regards, Pierre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits edited a comment on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
PierreSmits edited a comment on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560 Jaqcues, The pull request is good enough, and can be merged as such. When committed it will create an opportunity for other contributors to enhance when that need arises. I would not want to deprive others from participating. Best regards, Pierre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
JacquesLeRoux merged pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
adityasharma7 commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842388591 Hi @JacquesLeRoux, This is done now. Initially, I have added only jQuery, jQuery browser, and Validate plugin through npm. As these are the libraries required for the front end to work I have kept the npmInstall task part of the Java build, so it executes on each tasks. Steps to verify: 1. Fetch the branch on your local 2. Start the server You will notice packages being downloaded with npmInstall task https://user-images.githubusercontent.com/15027245/118508711-0dfd4900-b74d-11eb--18863cd40dcc.png";> You will find the node_modules under the js folder https://user-images.githubusercontent.com/15027245/118508970-4866e600-b74d-11eb-820c-2db716fd3b11.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
sonarcloud[bot] removed a comment on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #239: Added Spanish Translations
PierreSmits commented on pull request #239: URL: https://github.com/apache/ofbiz-framework/pull/239#issuecomment-842225413 This appears good enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)
PierreSmits commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
