[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2666: Fixes #2629
sunbufu commented on issue #2666: Fixes #2629 URL: https://github.com/apache/incubator-shardingsphere/pull/2666#issuecomment-509087320 You are right, ShardingRule is meaningless with a null ShardingRuleConfig. So, we need a judge in ShardingRule's constructor. and I notice there may throw a NPE in `ShardingRule.createEncryptRule()` when `shardingRuleConfig` is null. There is a question. Should I throw a `ShardingException` or `IllegalArgumentException` on this case? If we choose `ShardingException`, I need modify `dataSourceNames`'s judge too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #2668: add `getValueByColumnType` method
tuohai666 commented on a change in pull request #2668: add
`getValueByColumnType` method
URL:
https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300927416
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/StreamQueryResult.java
##
@@ -68,12 +68,12 @@ public boolean next() throws SQLException {
@Override
public Object getValue(final int columnIndex, final Class type) throws
SQLException {
-return decrypt(columnIndex, QueryResultUtil.getValue(resultSet,
columnIndex));
+return decrypt(columnIndex, QueryResultUtil.getValue(resultSet,
columnIndex, type));
Review comment:
If so, the problem was not resolved. Two modes get two different value is
even worse, isn't?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on a change in pull request #2668: add `getValueByColumnType` method
sunbufu commented on a change in pull request #2668: add `getValueByColumnType`
method
URL:
https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300925257
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/StreamQueryResult.java
##
@@ -68,12 +68,12 @@ public boolean next() throws SQLException {
@Override
public Object getValue(final int columnIndex, final Class type) throws
SQLException {
-return decrypt(columnIndex, QueryResultUtil.getValue(resultSet,
columnIndex));
+return decrypt(columnIndex, QueryResultUtil.getValue(resultSet,
columnIndex, type));
Review comment:
> StreamQueryResult pass the type to getValue(), but what about
MemoryQueryResult?
This is why I doesn't deleted `QueryResultUtil.getValueByColumnType()`, I
just have overload a `getValue()` method with `Class type` in
`QueryResultUtil`, `StreamQueryResult` will call the new `getValue()` with
`Class type`, and `MemoryQueryResult ` will continue to call the old
`getValue()`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] core1942 opened a new issue #2671: sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？
core1942 opened a new issue #2671: sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？ URL: https://github.com/apache/incubator-shardingsphere/issues/2671 sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？ 如果可以的话是否只需要配置sharding-proxy的server.yaml中的orchestration配置，其他配置文件直接置空就行了？但目前我这样做回抛NullPointerException。 Exception in thread "main" java.lang.NullPointerException at java.util.regex.Matcher.getTextLength(Matcher.java:1283) at java.util.regex.Matcher.reset(Matcher.java:309) at java.util.regex.Matcher.(Matcher.java:229) at java.util.regex.Pattern.matcher(Pattern.java:1093) at org.yaml.snakeyaml.reader.StreamReader.checkPrintable(StreamReader.java:64) at org.yaml.snakeyaml.reader.StreamReader.(StreamReader.java:47) at org.yaml.snakeyaml.Yaml.loadAs(Yaml.java:427) at org.apache.shardingsphere.core.yaml.engine.YamlEngine.unmarshal(YamlEngine.java:87) at org.apache.shardingsphere.orchestration.internal.registry.config.service.ConfigurationService.loadAuthentication(ConfigurationService.java:214) at org.apache.shardingsphere.shardingproxy.Bootstrap.startWithRegistryCenter(Bootstrap.java:102) at org.apache.shardingsphere.shardingproxy.Bootstrap.main(Bootstrap.java:75) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？
AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509062862 Oh, it's only a tag. That's confuse me at first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 commented on issue #1951: Optimization of table metadata initialization
wgy8283335 commented on issue #1951: Optimization of table metadata initialization URL: https://github.com/apache/incubator-shardingsphere/issues/1951#issuecomment-509062384 @tristaZero @terrymanu. Does this issue still need a volunteer? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] AlbertTao edited a comment on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？
AlbertTao edited a comment on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509062284  Does it's no means 4.0.0-RC2 released alreay ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？
sunbufu commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509060965 > @terrymanu Still could not find 4.0.0-RC2 on search.maven.org Still not release, please focus on [sharding sphere releases](https://github.com/apache/incubator-shardingsphere/releases), or watch sharding sphere on gitlab.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-509058928 Of course, please go through #2597 first, after that let's discuss the rules. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？
AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509057650 Still could not find 4.0.0-RC2 on search.maven.org This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #2664: ResultSetReturnedDatabaseMetaData.getActualTableNamePattern() has a NullPointerException
KomachiSion closed issue #2664: ResultSetReturnedDatabaseMetaData.getActualTableNamePattern() has a NullPointerException URL: https://github.com/apache/incubator-shardingsphere/issues/2664 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
