[skywalking-satellite] branch chore/check-diff updated (f814821 -> 9a9fec0)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. discard f814821 Fix GitHub Action syntax add 9a9fec0 Fix GitHub Action syntax This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (f814821) \ N -- N -- N refs/heads/chore/check-diff (9a9fec0) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/build-and-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-satellite] branch chore/check-diff updated (a3176f0 -> f814821)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. discard a3176f0 Fix GitHub Action syntax add f814821 Fix GitHub Action syntax This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a3176f0) \ N -- N -- N refs/heads/chore/check-diff (f814821) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/build-and-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-satellite] branch chore/check-diff updated (2bf10df -> a3176f0)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. from 2bf10df Fix GitHub Action syntax add a3176f0 Fix GitHub Action syntax No new revisions were added by this update. Summary of changes: .github/workflows/build-and-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-satellite] branch chore/check-diff updated (ab2e612 -> 2bf10df)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. from ab2e612 Only make check on Go 1.15 add 2bf10df Fix GitHub Action syntax No new revisions were added by this update. Summary of changes: .github/workflows/build-and-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [skywalking-satellite] kezhenxu94 commented on pull request #18: Include go.sum|go.mod in CI consistency
kezhenxu94 commented on pull request #18:
URL:
https://github.com/apache/skywalking-satellite/pull/18#issuecomment-764448130
According to [the
doc](https://github.com/golang/go/wiki/Modules#why-does-go-mod-tidy-record-indirect-and-test-dependencies-in-my-gomod),
`go mod tidy` should be consistent in all platforms:
> go mod tidy also ensures your current go.mod reflects the dependency
requirements for all possible combinations of OS, architecture, and build tags
(as described here). In contrast, other commands like go build and go test only
update go.mod to provide the packages imported by the requested packages under
the current GOOS, GOARCH, and build tags (which is one reason go mod tidy might
add requirements that were not added by go build or similar).
I checked your issue in #10 , which is caused by the `packr` tool because it
used `GO111MODULE=on` so that it modifies the `go.{mod,sum}` always when no
`packr2` is installed (this happens on GitHub Action, but not on your local
machine unless you remove `$(go env GOPATH)/bin/packr2`), we don't use it and
thus I remove it here.
Another problem is that you had `$(GO) mod tidy &> /dev/null`, causing the
`go mod tidy` to run at background and the following command `git status -s`
will detect nothing because `go mod tidy` has not finished yet (mostly because
it cause some time), see
[here](https://github.com/apache/skywalking-satellite/runs/1740240310) for the
problem that was never detected before because of this .
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[skywalking-satellite] branch chore/check-diff updated (9665b89 -> ab2e612)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. discard 9665b89 Only make check on Go 1.15 add ab2e612 Only make check on Go 1.15 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (9665b89) \ N -- N -- N refs/heads/chore/check-diff (ab2e612) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/build-and-test.yaml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)
[skywalking] branch master updated: Support dynamic change SAMPLE_N_PER_3_SECS on java agent (#6232)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new db61015 Support dynamic change SAMPLE_N_PER_3_SECS on java agent
(#6232)
db61015 is described below
commit db6101524541cf3f4a7746e4e6a7162f0a764da0
Author: zifeihan
AuthorDate: Thu Jan 21 15:41:14 2021 +0800
Support dynamic change SAMPLE_N_PER_3_SECS on java agent (#6232)
---
CHANGES.md | 1 +
.../command/ConfigurationDiscoveryCommand.java | 2 +-
apm-protocol/apm-network/src/main/proto| 2 +-
.../core/commands/CommandExecutorService.java | 5 +
.../ConfigurationDiscoveryCommandExecutor.java | 45
.../skywalking/apm/agent/core/conf/Config.java | 4 +
.../conf/dynamic/AgentConfigChangeWatcher.java | 62 ++
.../dynamic/ConfigurationDiscoveryService.java | 240 +
.../agent/core/sampling/SamplingRateWatcher.java | 76 +++
.../apm/agent/core/sampling/SamplingService.java | 58 +++--
...ache.skywalking.apm.agent.core.boot.BootService | 3 +-
.../apm/agent/core/boot/ServiceManagerTest.java| 4 +-
.../core/sampling/SamplingRateWatcherTest.java | 57 +
.../trace/ignore/TraceIgnoreExtendService.java | 1 +
.../apm/plugin/trace/ignore/TraceIgnoreTest.java | 7 +-
docs/en/setup/service-agent/java-agent/README.md | 1 +
.../src/main/resources/application.yml | 2 +-
.../grpc/ConfigurationDiscoveryServiceHandler.java | 4 +-
18 files changed, 544 insertions(+), 30 deletions(-)
diff --git a/CHANGES.md b/CHANGES.md
index 00cc1a4..83704a2 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -36,6 +36,7 @@ Release Notes.
* Support reading segmentId and spanId with toolkit.
* Fix RestTemplate plugin recording url tag with wrong port
* Support collecting logs and forwarding through gRPC.
+* Support config `agent.sample_n_per_3_secs` can be changed in the runtime.
OAP-Backend
* Make meter receiver support MAL.
diff --git
a/apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/command/ConfigurationDiscoveryCommand.java
b/apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/command/ConfigurationDiscoveryCommand.java
index a1bb63f..b605d71 100644
---
a/apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/command/ConfigurationDiscoveryCommand.java
+++
b/apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/command/ConfigurationDiscoveryCommand.java
@@ -26,7 +26,7 @@ import
org.apache.skywalking.apm.network.common.v3.KeyStringValuePair;
public class ConfigurationDiscoveryCommand extends BaseCommand implements
Serializable, Deserializable {
public static final Deserializable
DESERIALIZER = new ConfigurationDiscoveryCommand(
"", "", new ArrayList<>());
-public static final String NAME =
ConfigurationDiscoveryCommand.class.getSimpleName();
+public static final String NAME = "ConfigurationDiscoveryCommand";
public static final String UUID_CONST_NAME = "UUID";
public static final String SERIAL_NUMBER_CONST_NAME = "SerialNumber";
diff --git a/apm-protocol/apm-network/src/main/proto
b/apm-protocol/apm-network/src/main/proto
index 101dc50..ce9e4e8 16
--- a/apm-protocol/apm-network/src/main/proto
+++ b/apm-protocol/apm-network/src/main/proto
@@ -1 +1 @@
-Subproject commit 101dc50429c98147b1109cb15c8a6c623e751759
+Subproject commit ce9e4e8bd9e552443cc970df67ee25f17ff0d3b8
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/commands/CommandExecutorService.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/commands/CommandExecutorService.java
index 81fc8d7..819b0b9 100755
---
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/commands/CommandExecutorService.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/commands/CommandExecutorService.java
@@ -21,9 +21,11 @@ import java.util.HashMap;
import java.util.Map;
import org.apache.skywalking.apm.agent.core.boot.BootService;
import org.apache.skywalking.apm.agent.core.boot.DefaultImplementor;
+import
org.apache.skywalking.apm.agent.core.commands.executor.ConfigurationDiscoveryCommandExecutor;
import
org.apache.skywalking.apm.agent.core.commands.executor.NoopCommandExecutor;
import
org.apache.skywalking.apm.agent.core.commands.executor.ProfileTaskCommandExecutor;
import org.apache.skywalking.apm.network.trace.component.command.BaseCommand;
+import
org.apache.skywalking.apm.network.trace.component.command.ConfigurationDiscoveryCommand;
import
org.apache.skywalking.apm.network.trace.component.command.ProfileTaskCommand;
[GitHub] [skywalking] wu-sheng merged pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
wu-sheng merged pull request #6232: URL: https://github.com/apache/skywalking/pull/6232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-satellite] branch chore/check-diff updated (04cd42d -> 9665b89)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. discard 04cd42d Only make check on Go 1.15 add 9665b89 Only make check on Go 1.15 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (04cd42d) \ N -- N -- N refs/heads/chore/check-diff (9665b89) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/build-and-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-satellite] branch chore/check-diff updated (280925b -> 04cd42d)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. discard 280925b Only make check on Go 1.15 add 04cd42d Only make check on Go 1.15 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (280925b) \ N -- N -- N refs/heads/chore/check-diff (04cd42d) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/build-and-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-satellite] branch chore/check-diff updated (e257aff -> 280925b)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. discard e257aff Only make check on Go 1.15 add 280925b Only make check on Go 1.15 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (e257aff) \ N -- N -- N refs/heads/chore/check-diff (280925b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/build-and-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-satellite] branch chore/check-diff updated (18ec7a5 -> e257aff)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. from 18ec7a5 Add diff when fail to check CI consistency add e257aff Only make check on Go 1.15 No new revisions were added by this update. Summary of changes: .github/workflows/build-and-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `3.68%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 48.68% -3.69% + Complexity 3643 3376 -267 Files 959 1748 +789 Lines 2369537089 +13394 Branches 2325 4072+1747 + Hits 1240818055+5647 - Misses1018918068+7879 + Partials 1098 966 -132 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `9.00 <9.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[skywalking-satellite] branch chore/check-diff updated (b1c0418 -> 18ec7a5)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. from b1c0418 Remove unused packr add 18ec7a5 Add diff when fail to check CI consistency No new revisions were added by this update. Summary of changes: Makefile | 1 + 1 file changed, 1 insertion(+)
[skywalking-satellite] branch chore/check-diff updated (d7da025 -> b1c0418)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. from d7da025 Include go.sum|go.mod in CI consistency add b1c0418 Remove unused packr No new revisions were added by this update. Summary of changes: Makefile | 2 -- 1 file changed, 2 deletions(-)
[skywalking-website] branch master updated: Post the recorded speech. (#201)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new 34cc2a0 Post the recorded speech. (#201)
34cc2a0 is described below
commit 34cc2a040af1c24ae1cf52ab3272b07a1b1d
Author: 吴晟 Wu Sheng
AuthorDate: Thu Jan 21 15:04:36 2021 +0800
Post the recorded speech. (#201)
---
content/zh/2021-01-21-educate-community/index.md | 17 +
1 file changed, 17 insertions(+)
diff --git a/content/zh/2021-01-21-educate-community/index.md
b/content/zh/2021-01-21-educate-community/index.md
new file mode 100644
index 000..b8ffc96
--- /dev/null
+++ b/content/zh/2021-01-21-educate-community/index.md
@@ -0,0 +1,17 @@
+---
+title: "[视频] 开放原子开源基金会2020年度峰会 - Educate community Over Support community"
+date: 2021-01-20
+author: "吴晟"
+description: "Apache SkyWalking社区的成功之道。教育社区，建设贡献者团队。"
+zh_tags:
+- Conference
+- Video
+---
+
+- 第一节：开篇介绍
+- 第二节：数字游戏（Number Game）
+- 第三节：社区原则（Community “Principles”）
+- 第四节：基金会原则（For public good）
+- 第五节：一些不太好的事情
+
+{{< bilibili BV125411E7GK >}}
[GitHub] [skywalking-website] wu-sheng merged pull request #201: Post the recorded speech.
wu-sheng merged pull request #201: URL: https://github.com/apache/skywalking-website/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-website] branch new-video updated (3f597c2 -> 913d794)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch new-video in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. from 3f597c2 A little udpate. add 913d794 Fix date. No new revisions were added by this update. Summary of changes: content/zh/2021-01-21-educate-community/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-website] branch new-video updated (f99bde0 -> 3f597c2)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch new-video in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. from f99bde0 Post the recorded speech. add 3f597c2 A little udpate. No new revisions were added by this update. Summary of changes: content/zh/2021-01-21-educate-community/index.md | 5 + 1 file changed, 5 insertions(+)
[GitHub] [skywalking-website] wu-sheng opened a new pull request #201: Post the recorded speech.
wu-sheng opened a new pull request #201: URL: https://github.com/apache/skywalking-website/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-website] branch new-video created (now f99bde0)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch new-video in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. at f99bde0 Post the recorded speech. This branch includes the following new commits: new f99bde0 Post the recorded speech. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[skywalking-website] 01/01: Post the recorded speech.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch new-video
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
commit f99bde09fc88e4dcec43027cea43d6ee7534c327
Author: Wu Sheng
AuthorDate: Thu Jan 21 14:49:52 2021 +0800
Post the recorded speech.
---
content/zh/2021-01-21-educate-community/index.md | 12
1 file changed, 12 insertions(+)
diff --git a/content/zh/2021-01-21-educate-community/index.md
b/content/zh/2021-01-21-educate-community/index.md
new file mode 100644
index 000..da075df
--- /dev/null
+++ b/content/zh/2021-01-21-educate-community/index.md
@@ -0,0 +1,12 @@
+---
+title: "[视频] 开放原子开源基金会2020年度峰会 - Educate community Over Support community"
+date: 2020-11-30
+author: "吴晟"
+description: "Apache SkyWalking社区的成功之道。教育社区，建设贡献者团队。"
+zh_tags:
+- Conference
+- Video
+---
+
+
+{{< bilibili BV125411E7GK >}}
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.84%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.21% +0.84% - Complexity 3643 3713 +70 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812623 +215 + Misses10189 9991 -198 - Partials 1098 1108 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.72%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.08% +0.72% - Complexity 3643 3710 +67 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812594 +186 + Misses1018910030 -159 Partials 1098 1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `4.90%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 47.46% -4.91% + Complexity 3643 3376 -267 Files 959 978 +19 Lines 2369524047 +352 Branches 2325 2363 +38 - Hits 1240811414 -994 - Misses1018911680+1491 + Partials 1098 953 -145 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.72%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.08% +0.72% - Complexity 3643 3710 +67 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812594 +186 + Misses1018910030 -159 Partials 1098 1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.61%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.97% +0.61% - Complexity 3643 3701 +58 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812567 +159 + Misses1018910055 -134 - Partials 1098 1100 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.25%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.62% +0.25% - Complexity 3643 3679 +36 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812483 +75 + Misses1018910152 -37 + Partials 1098 1087 -11 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.22%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.59% +0.22% - Complexity 3643 3678 +35 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812476 +68 + Misses1018910158 -31 + Partials 1098 1088 -10 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.41%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.94% -0.42% - Complexity 3643 3655 +12 Files 959 959 Lines 2369523712 +17 Branches 2325 2321 -4 - Hits 1240812318 -90 - Misses1018910323 +134 + Partials 1098 1071 -27 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.45%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.90% -0.46% - Complexity 3643 3652 +9 Files 959 959 Lines 2369523712 +17 Branches 2325 2321 -4 - Hits 1240812308 -100 - Misses1018910333 +144 + Partials 1098 1071 -27 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.29%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 52.06% -0.30% - Complexity 3643 3652 +9 Files 959 958 -1 Lines 2369523639 -56 Branches 2325 2304 -21 - Hits 1240812308 -100 - Misses1018910260 +71 + Partials 1098 1071 -27 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `9.53%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 42.83% -9.54% + Complexity 3643 2921 -722 Files 959 957 -2 Lines 2369523635 -60 Branches 2325 2304 -21 - Hits 1240810123-2285 - Misses1018912718+2529 + Partials 1098 794 -304 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%>
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `10.22%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 42.14% -10.23% + Complexity 3643 2886 -757 = Files 959 957-2 Lines 2369523635 -60 Branches 2325 2304 -21 = - Hits 12408 9960 -2448 - Misses1018912895 +2706 + Partials 1098 780 -318 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `10.41%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 41.95% -10.42% + Complexity 3643 2878 -765 = Files 959 957-2 Lines 2369523635 -60 Branches 2325 2304 -21 = - Hits 12408 9915 -2493 - Misses1018912942 +2753 + Partials 1098 778 -320 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `11.95%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.40% -11.96% + Complexity 3643 2756 -887 = Files 959 957-2 Lines 2369523617 -78 Branches 2325 2303 -22 = - Hits 12408 9543 -2865 - Misses1018913348 +3159 + Partials 1098 726 -372 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `12.66%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 39.70% -12.67% + Complexity 3643 2717 -926 = Files 959 957-2 Lines 2369523614 -81 Branches 2325 2303 -22 = - Hits 12408 9376 -3032 - Misses1018913511 +3322 + Partials 1098 727 -371 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `13.85%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 38.51% -13.86% + Complexity 3643 2635 -1008 = Files 959 957-2 Lines 2369523586 -109 Branches 2325 2298 -27 = - Hits 12408 9084 -3324 - Misses1018913796 +3607 + Partials 1098 706 -392 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.66%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.69% -17.67% + Complexity 3643 2415 -1228 = Files 959 957-2 Lines 2369523567 -128 Branches 2325 2298 -27 = - Hits 12408 8177 -4231 - Misses1018914774 +4585 + Partials 1098 616 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.65%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.71% -17.66% + Complexity 3643 2415 -1228 = Files 959 955-4 Lines 2369523556 -139 Branches 2325 2298 -27 = - Hits 12408 8177 -4231 - Misses1018914763 +4574 + Partials 1098 616 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.63%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.72% -17.64% + Complexity 3643 2415 -1228 = Files 959 955-4 Lines 2369523547 -148 Branches 2325 2283 -42 = - Hits 12408 8177 -4231 - Misses1018914754 +4565 + Partials 1098 616 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.65%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.70% -17.66% + Complexity 3643 2413 -1230 = Files 959 955-4 Lines 2369523547 -148 Branches 2325 2283 -42 = - Hits 12408 8173 -4235 - Misses1018914758 +4569 + Partials 1098 616 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.92%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.43% -17.93% + Complexity 3643 2396 -1247 = Files 959 955-4 Lines 2369523547 -148 Branches 2325 2283 -42 = - Hits 12408 8109 -4299 - Misses1018914824 +4635 + Partials 1098 614 -484 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `19.61%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 32.74% -19.62% + Complexity 3643 2304 -1339 = Files 959 955-4 Lines 2369523538 -157 Branches 2325 2283 -42 = - Hits 12408 7708 -4700 - Misses1018915259 +5070 + Partials 1098 571 -527 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `19.61%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 32.74% -19.62% + Complexity 3643 2304 -1339 = Files 959 955-4 Lines 2369523538 -157 Branches 2325 2283 -42 = - Hits 12408 7708 -4700 - Misses1018915259 +5070 + Partials 1098 571 -527 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `19.56%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 32.80% -19.57% + Complexity 3643 2304 -1339 = Files 959 954-5 Lines 2369523499 -196 Branches 2325 2282 -43 = - Hits 12408 7708 -4700 - Misses1018915220 +5031 + Partials 1098 571 -527 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `21.85%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 30.51% -21.86% + Complexity 3643 2088 -1555 = Files 959 925 -34 Lines 2369522658 -1037 Branches 2325 2186 -139 = - Hits 12408 6913 -5495 - Misses1018915216 +5027 + Partials 1098 529 -569 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `4.90%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 47.46% -4.91% + Complexity 3643 3376 -267 Files 959 978 +19 Lines 2369524047 +352 Branches 2325 2363 +38 - Hits 1240811414 -994 - Misses1018911680+1491 + Partials 1098 953 -145 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `5.54%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.81% -5.55% + Complexity 3643 3348 -295 Files 959 978 +19 Lines 2369524047 +352 Branches 2325 2363 +38 - Hits 1240811258-1150 - Misses1018911854+1665 + Partials 1098 935 -163 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `5.43%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.93% -5.44% + Complexity 3643 3348 -295 Files 959 976 +17 Lines 2369523988 +293 Branches 2325 2356 +31 - Hits 1240811258-1150 - Misses1018911795+1606 + Partials 1098 935 -163 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `5.35%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 47.01% -5.36% + Complexity 3643 3348 -295 Files 959 975 +16 Lines 2369523948 +253 Branches 2325 2352 +27 - Hits 1240811258-1150 - Misses1018911755+1566 + Partials 1098 935 -163 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.08%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.28% -6.09% + Complexity 3643 3317 -326 Files 959 975 +16 Lines 2369523948 +253 Branches 2325 2352 +27 - Hits 1240811084-1324 - Misses1018911932+1743 + Partials 1098 932 -166 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `5.40%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.96% -5.41% + Complexity 3643 3317 -326 Files 959 958 -1 Lines 2369523601 -94 Branches 2325 2302 -23 - Hits 1240811084-1324 - Misses1018911585+1396 + Partials 1098 932 -166 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.13%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.23% -6.14% + Complexity 3643 3280 -363 Files 959 958 -1 Lines 2369523601 -94 Branches 2325 2302 -23 - Hits 1240810911-1497 - Misses1018911775+1586 + Partials 1098 915 -183 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `8.04%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 44.32% -8.05% + Complexity 3643 3101 -542 Files 959 941 -18 Lines 2369523071 -624 Branches 2325 2246 -79 - Hits 1240810226-2182 - Misses1018911974+1785 + Partials 1098 871 -227 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `20.67%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 31.69% -20.68% + Complexity 3643 2143 -1500 = Files 959 940 -19 Lines 2369522879 -816 Branches 2325 2197 -128 = - Hits 12408 7251 -5157 - Misses1018915101 +4912 + Partials 1098 527 -571 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `20.96%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 31.40% -20.97% + Complexity 3643 2130 -1513 = Files 959 940 -19 Lines 2369522879 -816 Branches 2325 2197 -128 = - Hits 12408 7185 -5223 - Misses1018915168 +4979 + Partials 1098 526 -572 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `24.28%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 28.08% -24.29% + Complexity 3643 1945 -1698 = Files 959 940 -19 Lines 2369522870 -825 Branches 2325 2197 -128 = - Hits 12408 6422 -5986 - Misses1018915966 +5777 + Partials 1098 482 -616 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `52.36%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #6232 +/- ## - Coverage 52.36% 0.00% -52.37% Files 959 181 -778 Lines 236954303-19392 Branches 2325 495 -1830 - Hits 12408 0-12408 + Misses101894303 -5886 + Partials 1098 0 -1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | ... and [932 more](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree-more) | | -- [Continue to review full report
[GitHub] [skywalking] zifeihan commented on issue #5048: Skywalking and Spring-data-JPA conflict
zifeihan commented on issue #5048: URL: https://github.com/apache/skywalking/issues/5048#issuecomment-764353301 > Did you sloved this problem? @zifeihan I have occred the same proble for 8.3 > > ERROR 2021-01-19 16:29:47:547 main SkyWalkingAgent : Enhance class com.ccb.medium.repository.OrganRepository error. > java.lang.IllegalArgumentException: None of [protected void java.lang.Object.finalize() throws java.lang.Throwable, public final void java.lang.Object.wait() throws java.lang.InterruptedException, public final void java.lang.Object.wait(long,int) throws java.lang.InterruptedException, public final native void java.lang.Object.wait(long) throws java.lang.InterruptedException, public boolean java.lang.Object.equals(java.lang.Object), public java.lang.String java.lang.Object.toString(), public native int java.lang.Object.hashCode(), public final native java.lang.Class java.lang.Object.getClass(), protected native java.lang.Object java.lang.Object.clone() throws java.lang.CloneNotSupportedException, public final native void java.lang.Object.notify(), public final native void java.lang.Object.notifyAll(), public java.lang.Object org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(java.lang.Object,java.lang.Object[],java.util.concurrent.Callable, java.lang.reflect.Method) throws java.lang.Throwable] allows for delegation from public abstract com.ccb.medium.entity.OrganT org.springframework.data.repository.CrudRepository.save(com.ccb.medium.entity.OrganT) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.implementation.bind.MethodDelegationBinder$Processor.bind(MethodDelegationBinder.java:1096) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.implementation.MethodDelegation$Appender.apply(MethodDelegation.java:1346) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$MethodPool$Record$ForDefinedMethod$WithBody.applyCode(TypeWriter.java:708) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$MethodPool$Record$ForDefinedMethod$WithBody.applyBody(TypeWriter.java:693) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$MethodPool$Record$ForDefinedMethod.apply(TypeWriter.java:600) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$MethodPool$Record$AccessBridgeWrapper.apply(TypeWriter.java:1266) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$Default$ForInlining$WithFullProcessing$RedefinitionClassVisitor.onVisitEnd(TypeWriter.java:5110) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.utility.visitor.MetadataAwareClassVisitor.visitEnd(MetadataAwareClassVisitor.java:370) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.jar.asm.ClassReader.accept(ClassReader.java:715) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.jar.asm.ClassReader.accept(ClassReader.java:394) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$Default$ForInlining.create(TypeWriter.java:3892) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.TypeWriter$Default.make(TypeWriter.java:2166) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.dynamic.scaffold.inline.RebaseDynamicTypeBuilder.make(RebaseDynamicTypeBuilder.java:252) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.doTransform(AgentBuilder.java:10366) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.transform(AgentBuilder.java:10302) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.access$1600(AgentBuilder.java:10068) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer$LegacyVmDispatcher.run(AgentBuilder.java:10687) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer$LegacyVmDispatcher.run(AgentBuilder.java:10634) > at java.security.AccessController.doPrivileged(Native Method) > at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.transform(AgentBuilder.java:10225) > at sun.instrument.TransformerManager.transform(TransformerManager.java:188) > at sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:428) > at java.lang.ClassLoader.defineClass1(Native Method) > at java.lang.ClassLoader.defineClass(ClassLoader.java:763) > at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) > at java.net.URLClassLoader.defineClass(URLClassLoader.java:467) > at java.net.URLClassLoader.access$100(URLClassLoader.java:73) > at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `52.36%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #6232 +/- ## - Coverage 52.36% 0.00% -52.37% Files 959 180 -779 Lines 236954298-19397 Branches 2325 495 -1830 - Hits 12408 0-12408 + Misses101894298 -5891 + Partials 1098 0 -1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | ... and [933 more](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree-more) | | -- [Continue to review full report
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `52.36%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #6232 +/- ## - Coverage 52.36% 0.00% -52.37% Files 959 178 -781 Lines 236954286-19409 Branches 2325 495 -1830 - Hits 12408 0-12408 + Misses101894286 -5903 + Partials 1098 0 -1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | ... and [933 more](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree-more) | | -- [Continue to review full report
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] zifeihan commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
zifeihan commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764329003 > Only one problem, it's disabled by default at OAP side, while it's enabled at the agent side's, causing unnecessary error logs like this: > > ``` > ERROR 2021-01-21 12:06:11:199 SkywalkingAgent-12-ConfigurationDiscoveryService-0 ConfigurationDiscoveryService : ConfigurationDiscoveryService execute fail. > org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNIMPLEMENTED: Method not found: skywalking.v3.ConfigurationDiscoveryService/fetchConfigurations > at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262) > at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243) > at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156) > at org.apache.skywalking.apm.network.language.agent.v3.ConfigurationDiscoveryServiceGrpc$ConfigurationDiscoveryServiceBlockingStub.fetchConfigurations(ConfigurationDiscoveryServiceGrpc.java:211) > at org.apache.skywalking.apm.agent.core.conf.dynamic.ConfigurationDiscoveryService.getAgentDynamicConfig(ConfigurationDiscoveryService.java:188) > at org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33) > at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) > at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) > at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) > at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > at java.base/java.lang.Thread.run(Thread.java:834) > > ERROR 2021-01-21 12:06:13:788 SkywalkingAgent-12-ConfigurationDiscoveryService-0 ConfigurationDiscoveryService : ConfigurationDiscoveryService execute fail. > org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNIMPLEMENTED: Method not found: skywalking.v3.ConfigurationDiscoveryService/fetchConfigurations > at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262) > at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243) > at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156) > at org.apache.skywalking.apm.network.language.agent.v3.ConfigurationDiscoveryServiceGrpc$ConfigurationDiscoveryServiceBlockingStub.fetchConfigurations(ConfigurationDiscoveryServiceGrpc.java:211) > at org.apache.skywalking.apm.agent.core.conf.dynamic.ConfigurationDiscoveryService.getAgentDynamicConfig(ConfigurationDiscoveryService.java:188) > at org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33) > at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) > at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) > at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) > at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > at java.base/java.lang.Thread.run(Thread.java:834) > ``` > > You can either enable at OAP side or do some detection at the agent side like this > > https://github.com/apache/skywalking/blob/5bfac1b50f79d544b98bfe4b20f7db165badce52/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskChannelService.java#L100-L108 thanks, it has enabled at the OAP side. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] zifeihan commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
zifeihan commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764325292 > Let's enable at the OAP side. This is a low cost feature. done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.73%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.62% -0.74% - Complexity 3643 3725 +82 Files 959 1747 +788 Lines 2369537025 +13330 Branches 2325 4081+1756 + Hits 1240819116+6708 - Misses1018916947+6758 + Partials 1098 962 -136 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] wu-sheng commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
wu-sheng commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764296381 Let's enable at the OAP side. This is a low cost feature. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
kezhenxu94 commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764292743 After the error log is addressed, LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
kezhenxu94 commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764291617 Only one problem, it's disabled by default at OAP side, while it's enabled at the agent side's, causing unnecessary error logs like this: ``` ERROR 2021-01-21 12:06:11:199 SkywalkingAgent-12-ConfigurationDiscoveryService-0 ConfigurationDiscoveryService : ConfigurationDiscoveryService execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNIMPLEMENTED: Method not found: skywalking.v3.ConfigurationDiscoveryService/fetchConfigurations at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262) at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243) at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156) at org.apache.skywalking.apm.network.language.agent.v3.ConfigurationDiscoveryServiceGrpc$ConfigurationDiscoveryServiceBlockingStub.fetchConfigurations(ConfigurationDiscoveryServiceGrpc.java:211) at org.apache.skywalking.apm.agent.core.conf.dynamic.ConfigurationDiscoveryService.getAgentDynamicConfig(ConfigurationDiscoveryService.java:188) at org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) ERROR 2021-01-21 12:06:13:788 SkywalkingAgent-12-ConfigurationDiscoveryService-0 ConfigurationDiscoveryService : ConfigurationDiscoveryService execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNIMPLEMENTED: Method not found: skywalking.v3.ConfigurationDiscoveryService/fetchConfigurations at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262) at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243) at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156) at org.apache.skywalking.apm.network.language.agent.v3.ConfigurationDiscoveryServiceGrpc$ConfigurationDiscoveryServiceBlockingStub.fetchConfigurations(ConfigurationDiscoveryServiceGrpc.java:211) at org.apache.skywalking.apm.agent.core.conf.dynamic.ConfigurationDiscoveryService.getAgentDynamicConfig(ConfigurationDiscoveryService.java:188) at org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) ``` You can either enable at OAP side or do some detection at the agent side like this https://github.com/apache/skywalking/blob/5bfac1b50f79d544b98bfe4b20f7db165badce52/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskChannelService.java#L100-L108 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] lzeqian opened a new issue #6238: logging.max_history_files does not work
lzeqian opened a new issue #6238: URL: https://github.com/apache/skywalking/issues/6238 This configuration does not work as described. -DSW_LOGGING_LEVEL=DEBUG -Dskywalking.logging.max_history_files=5 -Dskywalking.logging.max_file_size=100 5 additional documents actually generated why??? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-satellite] branch chore/check-diff updated (635399b -> d7da025)
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch chore/check-diff
in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git.
discard 635399b Include go.sum|go.mod in CI consistency
add 18f556c feat: add http logging receiver (#16)
add d7da025 Include go.sum|go.mod in CI consistency
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (635399b)
\
N -- N -- N refs/heads/chore/check-diff (d7da025)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
Makefile | 4 +-
go.sum | 2 +
plugins/queue/mmap/queue.go| 1 -
plugins/receiver/http/receiver.go | 121 +
.../{grpc/nativelog => http}/receiver_test.go | 115 ++--
.../{prometheus/prometheus.go => http/server.go} | 35 ++
6 files changed, 216 insertions(+), 62 deletions(-)
create mode 100644 plugins/receiver/http/receiver.go
copy plugins/receiver/{grpc/nativelog => http}/receiver_test.go (56%)
copy plugins/server/{prometheus/prometheus.go => http/server.go} (55%)
[skywalking-satellite] branch chore/check-diff updated (4c8e673 -> 635399b)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/check-diff in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. discard 4c8e673 Merge branch 'main' into chore/check-diff omit 18f556c feat: add http logging receiver (#16) discard e519805 Include go.sum|go.mod in CI consistency add 635399b Include go.sum|go.mod in CI consistency This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (4c8e673) \ N -- N -- N refs/heads/chore/check-diff (635399b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: Makefile | 2 +- go.sum | 2 - plugins/queue/mmap/queue.go| 1 + plugins/receiver/http/receiver.go | 121 - plugins/receiver/http/receiver_test.go | 185 - plugins/server/http/server.go | 71 - 6 files changed, 2 insertions(+), 380 deletions(-) delete mode 100644 plugins/receiver/http/receiver.go delete mode 100644 plugins/receiver/http/receiver_test.go delete mode 100644 plugins/server/http/server.go
[GitHub] [skywalking] kezhenxu94 commented on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
kezhenxu94 commented on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764195118 > From my understanding, CDS is really hard to be tested through e2e. @kezhenxu94 Any suggestion? It's easy to test the machanism (while unnecessary) but hard to test the agent side's functionalities after receiving the changed configs, I'll run a local manual test for this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-satellite] branch main updated: feat: add http logging receiver (#16)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git
The following commit(s) were added to refs/heads/main by this push:
new 18f556c feat: add http logging receiver (#16)
18f556c is described below
commit 18f556c852800fa722ce17e3073cf328bdccfa38
Author: kv
AuthorDate: Thu Jan 21 08:35:43 2021 +0800
feat: add http logging receiver (#16)
---
go.sum | 2 +
plugins/queue/mmap/queue.go| 1 -
plugins/receiver/http/receiver.go | 121 +
plugins/receiver/http/receiver_test.go | 185 +
plugins/server/http/server.go | 71 +
5 files changed, 379 insertions(+), 1 deletion(-)
diff --git a/go.sum b/go.sum
index b4f00e9..9826328 100644
--- a/go.sum
+++ b/go.sum
@@ -202,6 +202,7 @@ github.com/hashicorp/memberlist v0.1.3/go.mod
h1:ajVTdAv/9Im8oMAAj5G31PhhMCZJV2p
github.com/hashicorp/serf v0.8.2/go.mod
h1:6hOLApaqBFA1NXqRQAsxw9QxuDEvNxSQRwA/JwenrHc=
github.com/hpcloud/tail v1.0.0/go.mod
h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU=
github.com/hudl/fargo v1.3.0/go.mod
h1:y3CKSmjA+wD2gak7sUSXTAoopbhU08POFhmITJgmKTg=
+github.com/inconshreveable/mousetrap v1.0.0
h1:Z8tu5sraLXCXIcARxBp/8cbvlwVa7Z1NHg9XEKhtSvM=
github.com/inconshreveable/mousetrap v1.0.0/go.mod
h1:PxqpIevigyE2G7u3NXJIT2ANytuPF1OarO4DADm73n8=
github.com/influxdata/influxdb1-client
v0.0.0-20191209144304-8bf82d3c094d/go.mod
h1:qj24IKcXYK6Iy9ceXlo3Tc+vtHo9lIhSX5JddghvEPo=
github.com/jcmturner/gofork v1.0.0
h1:J7uCkflzTEhUZ64xqKnkDxq3kzc96ajM1Gli5ktUem8=
@@ -481,6 +482,7 @@ golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod
h1:RxMgew5VJxzue5/jJ
golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4/go.mod
h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20190227155943-e225da77a7e6/go.mod
h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod
h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
+golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
h1:vcxGaoTs7kV8m5Np9uUNQin4BrLOthgV7252N8V+FwY=
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e/go.mod
h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sys v0.0.0-20180823144017-11551d06cbcc/go.mod
h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20180830151530-49385e6e1522/go.mod
h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
diff --git a/plugins/queue/mmap/queue.go b/plugins/queue/mmap/queue.go
index 22b76b0..46aecd6 100644
--- a/plugins/queue/mmap/queue.go
+++ b/plugins/queue/mmap/queue.go
@@ -28,7 +28,6 @@ import (
"time"
"github.com/grandecola/mmap"
-
"google.golang.org/protobuf/proto"
"github.com/apache/skywalking-satellite/internal/pkg/config"
diff --git a/plugins/receiver/http/receiver.go
b/plugins/receiver/http/receiver.go
new file mode 100644
index 000..20fbc22
--- /dev/null
+++ b/plugins/receiver/http/receiver.go
@@ -0,0 +1,121 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package http
+
+import (
+ "fmt"
+ "io/ioutil"
+ "net/http"
+ "time"
+
+ logging "skywalking/network/logging/v3"
+
+ "google.golang.org/protobuf/proto"
+
+ "encoding/json"
+
+ "github.com/apache/skywalking-satellite/internal/pkg/config"
+ "github.com/apache/skywalking-satellite/internal/pkg/log"
+ http_server "github.com/apache/skywalking-satellite/plugins/server/http"
+
"github.com/apache/skywalking-satellite/protocol/gen-codes/satellite/protocol"
+)
+
+const (
+ Name = "http-log-receiver"
+ eventName = "http-log-event"
+ timeout = 5 * time.Second
+ Success = "success"
+ Failing = "failing"
+)
+
+type Receiver struct {
+ config.CommonFields
+ Server*http_server.Server
+ OutputChannel chan *protocol.Event
+ URI string `mapstructure:"uri"`
+}
+
+type Response struct {
+ Status string `json:"status"`
+ Msgstring `json:"msg"`
+}
+
+func (r
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #16: feat: add http logging receiver
wu-sheng commented on pull request #16: URL: https://github.com/apache/skywalking-satellite/pull/16#issuecomment-764081220 Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #16: feat: add http logging receiver
wu-sheng merged pull request #16: URL: https://github.com/apache/skywalking-satellite/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-satellite] branch chore/check-diff updated (e519805 -> 4c8e673)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch chore/check-diff
in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git.
from e519805 Include go.sum|go.mod in CI consistency
add 18f556c feat: add http logging receiver (#16)
add 4c8e673 Merge branch 'main' into chore/check-diff
No new revisions were added by this update.
Summary of changes:
go.sum | 2 +
plugins/queue/mmap/queue.go| 1 -
plugins/receiver/http/receiver.go | 121 +
.../{grpc/nativelog => http}/receiver_test.go | 115 ++--
.../{prometheus/prometheus.go => http/server.go} | 35 ++
5 files changed, 214 insertions(+), 60 deletions(-)
create mode 100644 plugins/receiver/http/receiver.go
copy plugins/receiver/{grpc/nativelog => http}/receiver_test.go (56%)
copy plugins/server/{prometheus/prometheus.go => http/server.go} (55%)
[GitHub] [skywalking] wu-sheng commented on issue #6221: Skywalking Client JS - ES module
wu-sheng commented on issue #6221: URL: https://github.com/apache/skywalking/issues/6221#issuecomment-764072927 If you want to send the data by your self, read the protocol doc. For segments, it is https://github.com/apache/skywalking/blob/v8.3.0/docs/en/protocols/HTTP-API-Protocol.md This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6221: Skywalking Client JS - ES module
wu-sheng closed issue #6221: URL: https://github.com/apache/skywalking/issues/6221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.73%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.62% -0.74% - Complexity 3643 3725 +82 Files 959 1747 +788 Lines 2369537025 +13330 Branches 2325 4081+1756 + Hits 1240819116+6708 - Misses1018916947+6758 + Partials 1098 962 -136 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.74%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.62% -0.75% - Complexity 3643 3724 +81 Files 959 1747 +788 Lines 2369537025 +13330 Branches 2325 4081+1756 + Hits 1240819114+6706 - Misses1018916949+6760 + Partials 1098 962 -136 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] wu-sheng commented on issue #6237: Spring Cloud Gateway support not working on 8.2/8.3/6.6/6.5
wu-sheng commented on issue #6237: URL: https://github.com/apache/skywalking/issues/6237#issuecomment-764026400 Could you be more clear sbout the difference? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] margauxcabrera commented on issue #6221: Skywalking Client JS - ES module
margauxcabrera commented on issue #6221: URL: https://github.com/apache/skywalking/issues/6221#issuecomment-763964167 Can you please tell me if it requires some parameters? 'Cause I've tried it in postman and got this error:  This is the error from the logs: ``` 2021-01-20 21:32:59,905 - org.eclipse.jetty.server.HttpChannel -71700376 [qtp1493883713-77] WARN [] - /v3/segments java.lang.UnsupportedOperationException: null at org.apache.skywalking.oap.server.receiver.trace.provider.handler.v8.rest.TraceSegmentReportBaseServletHandler.doGet(TraceSegmentReportBaseServletHandler.java:64) ~[skywalking-trace-receiver-plugin-8.3.0.jar:8.3.0] at org.apache.skywalking.oap.server.library.server.jetty.JettyJsonHandler.doGet(JettyJsonHandler.java:44) ~[library-server-8.3.0.jar:8.3.0] at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) ~[javax.servlet-api-3.1.0.jar:3.1.0] at org.apache.skywalking.oap.server.library.server.jetty.JettyJsonHandler.service(JettyJsonHandler.java:107) ~[library-server-8.3.0.jar:8.3.0] at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) ~[javax.servlet-api-3.1.0.jar:3.1.0] at org.apache.skywalking.oap.server.library.server.jetty.JettyJsonHandler.service(JettyJsonHandler.java:112) ~[library-server-8.3.0.jar:8.3.0] at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:763) ~[jetty-servlet-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:551) ~[jetty-servlet-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1363) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:489) ~[jetty-servlet-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1278) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.Server.handle(Server.java:500) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547) ~[jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375) [jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273) [jetty-server-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) [jetty-io-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103) [jetty-io-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117) [jetty-io-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806) [jetty-util-9.4.28.v20200408.jar:9.4.28.v20200408] at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.74%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.62% -0.75% - Complexity 3643 3724 +81 Files 959 1747 +788 Lines 2369537025 +13330 Branches 2325 4081+1756 + Hits 1240819113+6705 - Misses1018916950+6761 + Partials 1098 962 -136 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.59%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 45.77% -6.60% + Complexity 3643 3322 -321 Files 959 979 +20 Lines 2369524043 +348 Branches 2325 2363 +38 - Hits 1240811005-1403 - Misses1018912097+1908 + Partials 1098 941 -157 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `1.51%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.88% +1.51% - Complexity 3643 3724 +81 Files 959 958 -1 Lines 2369523667 -28 Branches 2325 2309 -16 + Hits 1240812752 +344 + Misses10189 9811 -378 - Partials 1098 1104 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `1.19%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.55% +1.19% - Complexity 3643 3707 +64 Files 959 958 -1 Lines 2369523667 -28 Branches 2325 2309 -16 + Hits 1240812676 +268 + Misses10189 9897 -292 + Partials 1098 1094 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `1.18%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.54% +1.18% - Complexity 3643 3705 +62 Files 959 957 -2 Lines 2369523663 -32 Branches 2325 2309 -16 + Hits 1240812671 +263 + Misses10189 9897 -292 + Partials 1098 1095 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.40%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.77% +0.40% - Complexity 3643 3658 +15 Files 959 957 -2 Lines 2369523663 -32 Branches 2325 2309 -16 + Hits 1240812488 +80 + Misses1018910102 -87 + Partials 1098 1073 -25 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.08%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.45% +0.08% + Complexity 3643 3639 -4 Files 959 957 -2 Lines 2369523663 -32 Branches 2325 2309 -16 + Hits 1240812412 +4 + Misses1018910175 -14 + Partials 1098 1076 -22 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.14%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 52.22% -0.15% + Complexity 3643 3625 -18 Files 959 957 -2 Lines 2369523663 -32 Branches 2325 2309 -16 - Hits 1240812357 -51 - Misses1018910238 +49 + Partials 1098 1068 -30 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.71%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.64% -0.72% + Complexity 3643 3588 -55 Files 959 957 -2 Lines 2369523635 -60 Branches 2325 2304 -21 - Hits 1240812207 -201 - Misses1018910380 +191 + Partials 1098 1048 -50 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `2.14%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 50.22% -2.15% + Complexity 3643 3470 -173 Files 959 956 -3 Lines 2369523612 -83 Branches 2325 2303 -22 - Hits 1240811859 -549 - Misses1018910751 +562 + Partials 1098 1002 -96 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `2.55%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 49.81% -2.56% + Complexity 3643 3449 -194 Files 959 956 -3 Lines 2369523609 -86 Branches 2325 2303 -22 - Hits 1240811760 -648 - Misses1018910851 +662 + Partials 1098 998 -100 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `11.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.91% -11.46% + Complexity 3643 2731 -912 = Files 959 954-5 Lines 2369523598 -97 Branches 2325 2303 -22 = - Hits 12408 9655 -2753 - Misses1018913204 +3015 + Partials 1098 739 -359 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `11.64%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.72% -11.65% + Complexity 3643 2723 -920 = Files 959 954-5 Lines 2369523598 -97 Branches 2325 2303 -22 = - Hits 12408 9610 -2798 - Misses1018913251 +3062 + Partials 1098 737 -361 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `12.06%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.30% -12.07% + Complexity 3643 2706 -937 = Files 959 954-5 Lines 2369523582 -113 Branches 2325 2288 -37 = - Hits 12408 9504 -2904 - Misses1018913341 +3152 + Partials 1098 737 -361 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `12.24%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.12% -12.25% + Complexity 3643 2697 -946 = Files 959 954-5 Lines 2369523582 -113 Branches 2325 2288 -37 = - Hits 12408 9462 -2946 - Misses1018913392 +3203 + Partials 1098 728 -370 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `13.18%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 39.18% -13.19% + Complexity 3643 2666 -977 = Files 959 954-5 Lines 2369523582 -113 Branches 2325 2288 -37 = - Hits 12408 9240 -3168 - Misses1018913628 +3439 + Partials 1098 714 -384 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
