Re: [I] [Feature] Supporting remote write protocols for Prometheus or VictoriaMetrics [skywalking]
wu-sheng closed issue #11665: [Feature] Supporting remote write protocols for Prometheus or VictoriaMetrics URL: https://github.com/apache/skywalking/issues/11665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] [skywalking]
kalosmark opened a new issue, #11665: URL: https://github.com/apache/skywalking/issues/11665 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description Consider supporting remote write protocols for Prometheus or VictoriaMetrics, This feature can be implemented in the exporter module ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Pulsar configuration to determine the collection of message contents [skywalking-java]
wu-sheng commented on PR #657: URL: https://github.com/apache/skywalking-java/pull/657#issuecomment-1859046030 Any update about this/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] memory has been growing very slowly [skywalking]
wu-sheng closed issue #11664: memory has been growing very slowly URL: https://github.com/apache/skywalking/issues/11664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] memory has been growing very slowly [skywalking]
sanhe-qigai opened a new issue, #11664: URL: https://github.com/apache/skywalking/issues/11664 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description My project is deployed in a k8s container. After using sk, I found that the memory has been growing very slowly. Is this normal? ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]
wu-sheng commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858988624 > It may also be interesting to say in the doc why it is disabled by default in SPAs - for this I have no idea. @Fine0830 Could you confirm this when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]
marcanpilami commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858909055 Thanks. However it may not be needed. If I manually add a call to `ClientMonitor.performance(ClientMonitor.customOptions);` just after `ClientMonitor.register(...)` it works. It seems `autoTracePerf` is willigly ignored when `enableSPA` is `true`. I believe it is worth adding a line to the documentation like "using enableSPA will disable automatic performance monitoring, call manually ClientMonitor.performance is you wish to re-enable it". (it would be a shame for users to miss this, as there is explicit support for SPAs inside ClientMonitor.performance so they should be encouraged to activate it). It may also be interesting to say in the doc why it is disabled by default in SPAs - for this I have no idea. Beside this doc enhancement, I think this issue may be closed. Thanks a lot for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858847351 I did a quick read on `JedisInstrumentationTest`. Generally, you could write mock classes in the agent repository, and redo the UTs, right? It doesn't need to be inside Jedis plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]
wu-sheng commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858846993 If you could provide a reproducible demo, @Fine0830 may be able to have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]
marcanpilami commented on issue #11662:
URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858832202
Just to be sure I have changed my configuratin not to use FMP and with
`autoTracePerf` explictely to true, no changes.
```js
ClientMonitor.register({
collector: window.APP_APIM_URL,
service: window.APP_APIM_PROJECT_NAME,
pagePath: '/app',
serviceVersion: 'v1.0.0',
useFmp: false,
autoTracePerf: true,
enableSPA: true,
noTraceOrigins: [],
customTags: [],
traceTimeInterval: 1000,
});
```
Actually it seems that metrics collection is disabled in SPA mode:
```ts
if (!this.customOptions.enableSPA) {
this.performance(this.customOptions);
}
```
(from monitor.ts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]
marcanpilami commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858828480 The metrics do not seem to be sent. (when i look inside the browser dev tool network pane, there are only calls to `v3/segments`). This may be related to the fact I'm using a React SPA. I have left `autoTracePerf` unset, so default value `true` should apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858827715 > Then how do you prefer to test this? If there isn't a real agent running. I found it does not need to test in real agent, it just need test by re-transform the enhanced class after plugin enhance. Check about `JedisInstrumentationTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]
wu-sheng commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858823406 Besides traces, the metrics should be reported as well, which should be able to create browser layer service. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858822832 > Write a plugin test to test all plugin maybe difficult, it need to load many classes and some of them are conflicted. Then how do you prefer to test this? If there isn't a real agent running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858822255 Write a plugin test to test all plugin maybe difficult, it need to load many classes and some of them are conflicted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]
marcanpilami opened a new issue, #11662:
URL: https://github.com/apache/skywalking/issues/11662
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
NodeJS Client Side Agent (apache/skywalking-client-js)
### What happened
I set up the JS library (inside a React app but this may not be relevant).
Data is pushed correctly to the OAP server by the browser (HTTP 200, and data
is present inside the OpenSearch database).
However, the data cannot be seen inside the browser layer dashboards of the
UI. Trace data can however be seen inside the traces of other components (in my
case a java agent for the application backend), so data is here, and the trace
id is well understood.
### What you expected to happen
I would expect the browser layer dashboard to show my traces and errors.
### How to reproduce
It should work with any default configuration, here given as a React hook
run on startup in the root component:
```js
useEffect(() => {
if (window.APP_APIM_ENABLED) {
ClientMonitor.register({
collector: window.APP_APIM_URL,
service: window.APP_APIM_PROJECT_NAME,
pagePath: '/app',
serviceVersion: 'v1.0.0',
useFmp: true,
enableSPA: true,
noTraceOrigins: [],
customTags: [],
traceTimeInterval: 1000,
});
}
},
[] // on startup only.
);
```
### Anything else
It seems the dashboards look for data in the BROWSER layer, but the JS
library reports its spans as HTTP layer, hence the lack of data. Is this
mismatch voluntary, or does it mean the BROWSER layer is for something else
entirely? I have not found a way to overload the JS layer constant to test this
hypothesis.
If this is simply a matter of changing the constant or making it
configurable, I'm open to submitting a PR.
And.. thanks a lot for all your hard work on Skywalking!
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858819418 Yes, then this is a test scenario, I think you could write a plugin test to verify this. It doesn't matter it is about bytebuddy patch or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858818900 > Does this indicate, you are actually testing agent, rather than patch? Actually, test re-transforming of plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858815070 > I want to create an abstract test class that makes it easy to test re-transform in a plug-in module, such as JedisInstrumentationTest. Because of using `SkyWalkingAgent#installClassTransformer()` method in `apm-agent`, it can not put in `bytebuddy-patch` module, a bit painful, any suggestions? Does this indicate, you are actually testing agent, rather than patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858803936 I want to create an abstract test class that makes it easy to test re-transform in a plug-in module, such as JedisInstrumentationTest. Because of using `SkyWalkingAgent#installClassTransformer()` method in `apm-agent`, it can not put in `bytebuddy-patch` module, a bit painful, any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858803144 > I think this is a general change, rather than fixing Jedis, right? Yes, any class that enhances a method from a parent class will have a similar error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858795267 I think this is a general change, rather than fixing Jedis, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix error in re-transforming the jedis class [skywalking-java]
kylixs opened a new pull request, #659: URL: https://github.com/apache/skywalking-java/pull/659 ### Fix error in re-transforming the jedis classr: https://github.com/apache/skywalking/issues/11651 - [x] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. ### What happened * Run app with Java Agent 9.1.0, watching `redis.clients.jedis.Jedis` with`Arthas` reported: ``` java.lang.UnsupportedOperationException: class redefinition failed: attempted to change the schema (add/remove fields) ``` * The JDK log (Xlog) display an error is: the redefined class redis. Clients. Jedis. Jedis fields change the error ``` [40.198s][info][redefine,class,normalize] redefined class redis.clients.jedis.Jedis fields change error: field Ljava/lang/reflect/Method; cachedValue$$sw$v9vk4i1$rc1vrg3 changed to Ljava/lang/reflect/Method; cachedValue$$sw$v9vk4i1$kq3fl10. ``` * Analyze with `javap -p` and compare the bytecode before and after retransform, it is found that the field name of the proxy method changes. * Found the number of declaration methods returned during retransform is increased and not in the same order. The extra methods comes from the parent class, and the methods are evaluated in a different order each time. ### How to fix it * `SWDescriptionStrategy`: Return original methods in the same order, removing generated methods for delegating superclass calls and others. * `SWMethodGraphCompilerDelegate`: Sort methods of `MethodGraph` compute from the parent classes. - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: 8a5a1768cf55ff8279bd3a90624df03559a47453
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 240071cca1d deploy: 8a5a1768cf55ff8279bd3a90624df03559a47453
240071cca1d is described below
commit 240071cca1d136cb0f4585dd9d8018241fa4022a
Author: wu-sheng
AuthorDate: Sat Dec 16 10:06:55 2023 +
deploy: 8a5a1768cf55ff8279bd3a90624df03559a47453
---
index.json | 2 +-
team/index.html | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/index.json b/index.json
index 5b840a7b169..e87678c6d2d 100644
--- a/index.json
+++ b/index.json
@@ -1 +1 @@
-[{"body":" Dive into the World of Cutting-Edge Technology with
Apache\u0026rsquo;s Finest! Join me today as we embark on an exhilarating
journey with two of Apache\u0026rsquo;s most brilliant minds - Sheng Wu and
Trista Pan. We\u0026rsquo;re exploring the realms of Apache SkyWalking and
Apache ShardingSphere, two groundbreaking initiatives that are reshaping the
landscape of open-source technology. \nIn this exclusive session, we delve
deep into Apache SkyWalking - an innovative obse [...]
\ No newline at end of file
+[{"body":" Dive into the World of Cutting-Edge Technology with
Apache\u0026rsquo;s Finest! Join me today as we embark on an exhilarating
journey with two of Apache\u0026rsquo;s most brilliant minds - Sheng Wu and
Trista Pan. We\u0026rsquo;re exploring the realms of Apache SkyWalking and
Apache ShardingSphere, two groundbreaking initiatives that are reshaping the
landscape of open-source technology. \nIn this exclusive session, we delve
deep into Apache SkyWalking - an innovative obse [...]
\ No newline at end of file
diff --git a/team/index.html b/team/index.html
index a9edd004d53..963d98b2709 100644
--- a/team/index.html
+++ b/team/index.html
@@ -1344,9 +1344,9 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
-https://github.com/LemonPuffLee;
target="_blank">
+https://github.com/Dylan-beicheng;
target="_blank">
- LemonPuffLee
+ Dylan-beicheng
