(skywalking-banyandb) branch v0.3.x deleted (was adbd3e87)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch v0.3.x in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was adbd3e87 Update change log (#256) The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump vite from 3.2.7 to 3.2.8 in /ui [skywalking-banyandb]
hanahmily closed pull request #373: Bump vite from 3.2.7 to 3.2.8 in /ui URL: https://github.com/apache/skywalking-banyandb/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump follow-redirects from 1.15.3 to 1.15.4 in /ui [skywalking-banyandb]
dependabot[bot] commented on PR #368: URL: https://github.com/apache/skywalking-banyandb/pull/368#issuecomment-1902531317 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch dependabot/npm_and_yarn/ui/vite-3.2.8 deleted (was e50a3076)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch dependabot/npm_and_yarn/ui/vite-3.2.8 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was e50a3076 Bump vite from 3.2.7 to 3.2.8 in /ui The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump vite from 3.2.7 to 3.2.8 in /ui [skywalking-banyandb]
dependabot[bot] commented on PR #373: URL: https://github.com/apache/skywalking-banyandb/pull/373#issuecomment-1902531344 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch dependabot/npm_and_yarn/ui/follow-redirects-1.15.4 deleted (was b5b34220)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/ui/follow-redirects-1.15.4 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was b5b34220 Bump follow-redirects from 1.15.3 to 1.15.4 in /ui The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump follow-redirects from 1.15.3 to 1.15.4 in /ui [skywalking-banyandb]
hanahmily closed pull request #368: Bump follow-redirects from 1.15.3 to 1.15.4 in /ui URL: https://github.com/apache/skywalking-banyandb/pull/368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: print log code normalization [skywalking-banyandb]
hanahmily closed pull request #376: chore: print log code normalization URL: https://github.com/apache/skywalking-banyandb/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: print log code normalization [skywalking-banyandb]
hanahmily commented on PR #376: URL: https://github.com/apache/skywalking-banyandb/pull/376#issuecomment-1902531093 I will close it since it violates the linter rules. Please follow the `CONTRIBUTING.md` before submitting PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-java) branch main updated: Convert the Redisson lock span into an async span (#667)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/main by this push:
new eebc4512ec Convert the Redisson lock span into an async span (#667)
eebc4512ec is described below
commit eebc4512ece8a27a67f48191f14f753b1c8477d7
Author: peachisai <96932958+peachi...@users.noreply.github.com>
AuthorDate: Sun Jan 21 12:10:39 2024 +0800
Convert the Redisson lock span into an async span (#667)
---
CHANGES.md | 3 ++-
.../redisson/v3/RedissonHighLevelLockInterceptor.java | 14 ++
.../apm/plugin/redisson/v3/RedissonLockInterceptor.java| 14 ++
3 files changed, 30 insertions(+), 1 deletion(-)
diff --git a/CHANGES.md b/CHANGES.md
index 90ece6d118..bd249be6e3 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -10,8 +10,9 @@ Release Notes.
* Support for tracing spring-cloud-gateway 4.x in gateway-4.x-plugin.
* Fix re-transform bug when plugin enhanced class proxy parent method.
* Fix error HTTP status codes not recording as SLA failures in Vert.x plugins.
-* Support for HttpExchange request tracing
+* Support for HttpExchange request tracing.
* Support tracing for async producing, batch sync consuming, and batch async
consuming in rocketMQ-client-java-5.x-plugin.
+* Convert the Redisson span into an async span.
Documentation
diff --git
a/apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java
b/apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java
index ef0a0585f5..99229d62fb 100644
---
a/apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java
+++
b/apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java
@@ -26,9 +26,11 @@ import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedI
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+import org.redisson.api.RFuture;
import org.redisson.api.RLock;
import java.lang.reflect.Method;
+import java.util.concurrent.CompletableFuture;
import java.util.concurrent.TimeUnit;
public class RedissonHighLevelLockInterceptor implements
InstanceMethodsAroundInterceptor {
@@ -48,7 +50,19 @@ public class RedissonHighLevelLockInterceptor implements
InstanceMethodsAroundIn
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable {
+AbstractSpan span = ContextManager.activeSpan();
+span.prepareForAsync();
ContextManager.stopSpan();
+
+RFuture future = (RFuture) ret;
+CompletableFuture completableFuture =
future.toCompletableFuture();
+completableFuture.whenComplete((res, ex) -> {
+if (ex != null) {
+span.errorOccurred();
+span.log(ex);
+}
+span.asyncFinish();
+});
return ret;
}
diff --git
a/apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonLockInterceptor.java
b/apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonLockInterceptor.java
index 77a31a28a4..b8159d9a00 100644
---
a/apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonLockInterceptor.java
+++
b/apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonLockInterceptor.java
@@ -26,9 +26,11 @@ import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedI
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+import org.redisson.api.RFuture;
import org.redisson.api.RLock;
import java.lang.reflect.Method;
+import java.util.concurrent.CompletableFuture;
import java.util.concurrent.TimeUnit;
public class RedissonLockInterceptor implements
InstanceMethodsAroundInterceptor {
@@ -48,7 +50,19 @@ public class RedissonLockInterceptor implements
InstanceMethodsAroundInterceptor
@Override
public Object
Re: [PR] Convert the Redisson lock span into an async span [skywalking-java]
wu-sheng merged PR #667: URL: https://github.com/apache/skywalking-java/pull/667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update rover and satellite for eBPF Access Log [skywalking-showcase]
wu-sheng commented on code in PR #157:
URL:
https://github.com/apache/skywalking-showcase/pull/157#discussion_r1460713808
##
deploy/platform/kubernetes/templates/feature-rover/resources.yaml:
##
@@ -57,13 +60,21 @@ spec:
- name: ROVER_BACKEND_ADDR
value: {{ template "skywalking.collector.address" . }}
- name:
ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_ENVOY_SERVICE_NAME
- value: mesh-svr::{{"{{"}}.Pod.LabelValue
"service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+ value: mesh-svr::{{"{{"}}.Pod.LabelValue
"service.istio.io/canonical-name,app.kubernetes.io/name,app"
""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
- name:
ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_APPLICATION_SERVICE_NAME
- value: mesh-svr::{{"{{"}}.Pod.LabelValue
"service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+ value: mesh-svr::{{"{{"}}.Pod.LabelValue
"service.istio.io/canonical-name,app.kubernetes.io/name,app"
""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
- name:
ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_K8S_SERVICE_NAME
value:
skywalking-showcase::{{"{{"}}.Pod.ServiceName{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
- name: ROVER_HOST_MAPPING
value: /host
+- name: ROVER_CORE_CLUSTER_NAME
+ value: skywalking-showcase
+- name: ROVER_ACCESS_LOG_ACTIVE
+ value: "true"
+- name: ROVER_ACCESS_LOG_EXCLUDE_NAMESPACES
+ value: gmp-system,kube-system,skywalking-showcase
Review Comment:
@mrproliu Could you follow this env variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-java) branch main updated: Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin (#665)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/main by this push:
new bbb177a893 Support tracing for async producing, batch sync consuming,
and batch async consuming in rocketMQ-client-java-5.x-plugin (#665)
bbb177a893 is described below
commit bbb177a89336267ab13ada252346e26454a6dfc2
Author: Chen Ziyan
AuthorDate: Sun Jan 21 10:29:39 2024 +0800
Support tracing for async producing, batch sync consuming, and batch async
consuming in rocketMQ-client-java-5.x-plugin (#665)
---
CHANGES.md | 1 +
.../client/java/v5/MessageListenerInterceptor.java | 4 +-
...eptor.java => MessageSendAsyncInterceptor.java} | 83 ---
.../client/java/v5/MessageSendInterceptor.java | 22 +-
.../java/v5/RocketMqClientJavaPluginConfig.java| 37
.../v5/SimpleConsumerImplAsyncInterceptor.java | 126 +++
...tor.java => SimpleConsumerImplInterceptor.java} | 71 +++---
.../define/ProducerImplAsyncInstrumentation.java | 68 ++
.../SimpleConsumerImplAsyncInstrumentation.java| 80 +++
.../define/SimpleConsumerImplInstrumentation.java | 80 +++
.../src/main/resources/skywalking-plugin.def | 3 +
apm-sniffer/config/agent.config| 4 +
.../service-agent/java-agent/configurations.md | 2 +
.../rocketmq-5-grpc-scenario/bin/startup.sh| 2 +-
.../config/expectedData.yaml | 152 +++--
.../client/java/controller/CaseController.java | 148 -
.../client/java/controller/MessageService.java | 240 +
.../client/java/controller/ProducerSingleton.java | 61 ++
.../rocketmq-5-grpc-scenario/support-version.list | 1 +
19 files changed, 1001 insertions(+), 184 deletions(-)
diff --git a/CHANGES.md b/CHANGES.md
index 5225574210..90ece6d118 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -11,6 +11,7 @@ Release Notes.
* Fix re-transform bug when plugin enhanced class proxy parent method.
* Fix error HTTP status codes not recording as SLA failures in Vert.x plugins.
* Support for HttpExchange request tracing
+* Support tracing for async producing, batch sync consuming, and batch async
consuming in rocketMQ-client-java-5.x-plugin.
Documentation
diff --git
a/apm-sniffer/apm-sdk-plugin/rocketMQ-client-java-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/client/java/v5/MessageListenerInterceptor.java
b/apm-sniffer/apm-sdk-plugin/rocketMQ-client-java-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/client/java/v5/MessageListenerInterceptor.java
index 513da2581c..17c4a749b1 100644
---
a/apm-sniffer/apm-sdk-plugin/rocketMQ-client-java-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/client/java/v5/MessageListenerInterceptor.java
+++
b/apm-sniffer/apm-sdk-plugin/rocketMQ-client-java-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/client/java/v5/MessageListenerInterceptor.java
@@ -23,6 +23,7 @@ import org.apache.rocketmq.client.apis.message.MessageView;
import org.apache.skywalking.apm.agent.core.context.CarrierItem;
import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.StringTag;
import org.apache.skywalking.apm.agent.core.context.tag.Tags;
import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
@@ -37,6 +38,7 @@ import java.lang.reflect.Method;
public class MessageListenerInterceptor implements
InstanceMethodsAroundInterceptor {
public static final String CONSUMER_OPERATION_NAME_PREFIX = "RocketMQ/";
+public static final StringTag MQ_MESSAGE_ID = new
StringTag("mq.message.id");
@Override
public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments, Class[] argumentsTypes, MethodInterceptResult result) throws
Throwable {
@@ -47,7 +49,7 @@ public class MessageListenerInterceptor implements
InstanceMethodsAroundIntercep
AbstractSpan span =
ContextManager.createEntrySpan(CONSUMER_OPERATION_NAME_PREFIX +
messageView.getTopic()
+ "/Consumer", contextCarrier);
Tags.MQ_TOPIC.set(span, messageView.getTopic());
-
+span.tag(MQ_MESSAGE_ID, messageView.getMessageId().toString());
Object skyWalkingDynamicField = objInst.getSkyWalkingDynamicField();
if (skyWalkingDynamicField != null) {
ConsumerEnhanceInfos consumerEnhanceInfos = (ConsumerEnhanceInfos)
skyWalkingDynamicField;
diff --git
Re: [I] [Feature] add Support for RocketMQ newAPI `rocketmq-client-java` [skywalking]
wu-sheng closed issue #11752: [Feature] add Support for RocketMQ newAPI `rocketmq-client-java` URL: https://github.com/apache/skywalking/issues/11752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin [skywalking-java]
wu-sheng merged PR #665: URL: https://github.com/apache/skywalking-java/pull/665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update rover and satellite for eBPF Access Log [skywalking-showcase]
kezhenxu94 commented on code in PR #157:
URL:
https://github.com/apache/skywalking-showcase/pull/157#discussion_r1460701412
##
deploy/platform/kubernetes/templates/feature-rover/resources.yaml:
##
@@ -57,13 +60,21 @@ spec:
- name: ROVER_BACKEND_ADDR
value: {{ template "skywalking.collector.address" . }}
- name:
ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_ENVOY_SERVICE_NAME
- value: mesh-svr::{{"{{"}}.Pod.LabelValue
"service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+ value: mesh-svr::{{"{{"}}.Pod.LabelValue
"service.istio.io/canonical-name,app.kubernetes.io/name,app"
""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
- name:
ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_ISTIO_APPLICATION_SERVICE_NAME
- value: mesh-svr::{{"{{"}}.Pod.LabelValue
"service.istio.io/canonical-name,app.kubernetes.io/name,app"{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
+ value: mesh-svr::{{"{{"}}.Pod.LabelValue
"service.istio.io/canonical-name,app.kubernetes.io/name,app"
""{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
- name:
ROVER_PROCESS_DISCOVERY_KUBERNETES_ANALYZER_K8S_SERVICE_NAME
value:
skywalking-showcase::{{"{{"}}.Pod.ServiceName{{"}}"}}.{{"{{"}}.Pod.Namespace{{"}}"}}
- name: ROVER_HOST_MAPPING
value: /host
+- name: ROVER_CORE_CLUSTER_NAME
+ value: skywalking-showcase
+- name: ROVER_ACCESS_LOG_ACTIVE
+ value: "true"
+- name: ROVER_ACCESS_LOG_EXCLUDE_NAMESPACES
+ value: gmp-system,kube-system,skywalking-showcase
Review Comment:
It's configurable when installing showcase like `make deploy.kubernetes
NAMESPACE=demo`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Spring cloud gateway project logback cannot print TraceID [skywalking]
BothSavage commented on issue #4983: URL: https://github.com/apache/skywalking/issues/4983#issuecomment-1902225254 https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cannot get the TID using the spring cloud gateway [skywalking]
BothSavage commented on issue #5111: URL: https://github.com/apache/skywalking/issues/5111#issuecomment-1902225168 https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Spring cloud gateway project logback cannot print TraceID [skywalking]
BothSavage commented on issue #5906: URL: https://github.com/apache/skywalking/issues/5906#issuecomment-1902225106 > how to resolve this problem? https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Spring cloud gateway project logback cannot print TraceID [skywalking]
BothSavage commented on issue #5906: URL: https://github.com/apache/skywalking/issues/5906#issuecomment-1902225052 > so, how to resolve this problem? https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] How to get traceid while using Spring Cloud Gateway [skywalking]
BothSavage commented on issue #7188: URL: https://github.com/apache/skywalking/issues/7188#issuecomment-1902224918 https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Spring cloud gateway project logback cannot print TraceID [skywalking]
BothSavage commented on issue #10509: URL: https://github.com/apache/skywalking/issues/10509#issuecomment-1902224840 > 我通过这种方式解决问题。使用 Tomcat 方式运行 spring-cloud-gateway，而不是 netty。 https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Spring cloud gateway project logback cannot print TraceID [skywalking]
BothSavage commented on issue #10509: URL: https://github.com/apache/skywalking/issues/10509#issuecomment-1902224810 > > 这已经讨论过很多次了。请先搜索再打开新的。 > > 如何解决这个问题？ https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [skywalking]
BothSavage commented on issue #11205: URL: https://github.com/apache/skywalking/issues/11205#issuecomment-1902224582 > ### 询问前先搜索 > * [x] [我在问题](https://github.com/apache/skywalking/issues?q=is%3Aissue)中搜索过，没有发现类似的问题。 > > ### Apache SkyWalking 组件 > Java 代理 (apache/skywalking-java) > > ### 发生了什么 > 我使用sky waling 8.16，我想跟踪webflux并获取traceId，但是报告nullpointException。 我的应用程序是webflux应用程序，并且没有使用springmvc，也不是spring cloud gateway应用程序。 1、我使用pom依赖项 1.apm-toolkit-trace 2.apm-toolkit-logback-1.x 3.apm-toolkit-webflux 2、我使用 spring-boot-starter-webflux 3.1.2 、spring-webflux 5.3.18。 比我用的 `String traceId = WebFluxSkyWalkingOperators.continueTracing(exchange, TraceContext::traceId);` 但是traceId是N/A，日志是 `ERROR 2023-08-10 14:28:14.504 reactor-http-nio-2 StaticMethodsInter : class[class org.apache.skywalking.apm.toolkit.webflux.WebFluxSkyWalkingOperators] after static method[continueTracing] intercept failure:null java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan(ContextManager.java:194) at org.apache.skywalking.apm.toolkit.activation.webflux.WebFluxSkyWalkingOperatorsInterceptor.afterMethod(WebFluxSkyWalkingO peratorsInterceptor.java:60) at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsInter.intercept(StaticMethodsInter.java:94) at org.apache.skywalking.apm.toolkit.webflux.WebFluxSkyWalkingOperators.continueTracing(WebFluxSkyWalkingOperators.java) at com.zo.auth.webflux.filter.TraceFilter.filter(TraceFilter.java:79) at org.springframework.web.server.handler.DefaultWebFilterChain.invokeFilter(DefaultWebFilterChain.java:127) at org.springframework.web.server.handler.DefaultWebFilterChain.lambda$filter$0(DefaultWebFilterChain.java:121)` > > ### 您期望发生什么 > 我如何获取webflux中的traceId，我的配置错误。应该说在我的应用程序mybatis中traceid可以跟踪到日志。 > > ### 如何重现 > 你能告诉我我能做什么吗？非常感谢！ > > ### 还要别的吗 > _没有反应_ > > ### 你愿意提交PR吗？ > * [ ] 是的，我愿意提交 PR！ > > ### 行为守则 > * [x] 我同意遵守该项目的[行为准则](https://www.apache.org/foundation/policies/conduct) https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] After integrating Skywalking agent with Springcloud gateway 4, traceid cannot be printed [skywalking]
BothSavage commented on issue #11398: URL: https://github.com/apache/skywalking/issues/11398#issuecomment-1902224450 > > 不支持网关 4.x。没有人支持关于此事的公关。 > > skywalking-java-agent什么时候可以支持gateway 4.x，你们有什么计划吗？ https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] After integrating Skywalking agent with Springcloud gateway 4, traceid cannot be printed [skywalking]
BothSavage commented on issue #11398: URL: https://github.com/apache/skywalking/issues/11398#issuecomment-1902224480 > ### 询问前先搜索 > * [x] [我在问题](https://github.com/apache/skywalking/issues?q=is%3Aissue)中搜索过，没有发现类似的问题。 > > ### Apache SkyWalking 组件 > Java 代理 (apache/skywalking-java) > > ### 发生了什么 >  日志不会从网关生成开始，使用的代理版本9.0.0，服务集成apm-toolkit-logback-1.x也是9.0.0 > > ### 您期望发生什么 > 如何解决 > > ### 如何重现 > 想要的日志从网关开始查起 > > ### 还要别的吗 > _没有反应_ > > ### 您愿意提交拉取请求来自行修复吗？ > * [x] 是的，我愿意自己提交拉取请求！ > > ### 行为守则 > * [x] 我同意遵守该项目的[行为准则](https://www.apache.org/foundation/policies/conduct) https://bothsavage.github.io/article/240121-skywaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Convert the Redisson lock span into an async span [skywalking-java]
peachisai commented on code in PR #667:
URL: https://github.com/apache/skywalking-java/pull/667#discussion_r1460526446
##
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java:
##
@@ -48,7 +50,19 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable {
+AbstractSpan span = ContextManager.activeSpan();
+span.prepareForAsync();
ContextManager.stopSpan();
+
+RFuture future = (RFuture) ret;
+CompletableFuture completableFuture =
future.toCompletableFuture();
+completableFuture.whenCompleteAsync((res, ex) -> {
Review Comment:
> `whenComplete`
Yes,you are right.This is a sync call
Concern that ```Redisson``` also use ```whenComplete ``` frequently, i
think it is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Convert the Redisson lock span into an async span [skywalking-java]
peachisai commented on code in PR #667:
URL: https://github.com/apache/skywalking-java/pull/667#discussion_r1460526446
##
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java:
##
@@ -48,7 +50,19 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable {
+AbstractSpan span = ContextManager.activeSpan();
+span.prepareForAsync();
ContextManager.stopSpan();
+
+RFuture future = (RFuture) ret;
+CompletableFuture completableFuture =
future.toCompletableFuture();
+completableFuture.whenCompleteAsync((res, ex) -> {
Review Comment:
> `whenComplete`
Yes,you are right.This is a sync call
As ```Redisson``` also use ```whenComplete ``` frequently, i think it is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Convert the Redisson lock span into an async span [skywalking-java]
wu-sheng commented on code in PR #667:
URL: https://github.com/apache/skywalking-java/pull/667#discussion_r1460516712
##
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java:
##
@@ -48,7 +50,19 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable {
+AbstractSpan span = ContextManager.activeSpan();
+span.prepareForAsync();
ContextManager.stopSpan();
+
+RFuture future = (RFuture) ret;
+CompletableFuture completableFuture =
future.toCompletableFuture();
+completableFuture.whenCompleteAsync((res, ex) -> {
Review Comment:
`whenComplete` should be a sync call when the future completed. Isn't it? Am
I getting anything wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Convert the Redisson lock span into an async span [skywalking-java]
peachisai commented on code in PR #667:
URL: https://github.com/apache/skywalking-java/pull/667#discussion_r1460514263
##
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java:
##
@@ -48,7 +50,19 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable {
+AbstractSpan span = ContextManager.activeSpan();
+span.prepareForAsync();
ContextManager.stopSpan();
+
+RFuture future = (RFuture) ret;
+CompletableFuture completableFuture =
future.toCompletableFuture();
+completableFuture.whenCompleteAsync((res, ex) -> {
Review Comment:
> Isn't this simpler?
>
> ```java
> completableFuture.whenComplete((result, error) -> { span.asyncFinish(); });
> ```
Okay, I thought you mean the ```whenComplete``` may not notify listener as
soon, consequently, i choose ```join``` method。so the question is the thread
context change could cause another cost time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Convert the Redisson lock span into an async span [skywalking-java]
wu-sheng commented on code in PR #667:
URL: https://github.com/apache/skywalking-java/pull/667#discussion_r1460505670
##
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java:
##
@@ -48,7 +50,19 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable {
+AbstractSpan span = ContextManager.activeSpan();
+span.prepareForAsync();
ContextManager.stopSpan();
+
+RFuture future = (RFuture) ret;
+CompletableFuture completableFuture =
future.toCompletableFuture();
+completableFuture.whenCompleteAsync((res, ex) -> {
Review Comment:
Isn't this simpler?
```java
completableFuture.whenComplete((result, error) -> { span.asyncFinish(); });
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-website) branch master updated: add a anchor for `Contributors` (#674)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new fe0471f578a add a anchor for `Contributors` (#674)
fe0471f578a is described below
commit fe0471f578a9a1fae0f184d69a384e4680aa5aa5
Author: Juntao Zhang <719284...@qq.com>
AuthorDate: Sat Jan 20 23:38:21 2024 +0800
add a anchor for `Contributors` (#674)
---
layouts/shortcodes/contributors.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/layouts/shortcodes/contributors.html
b/layouts/shortcodes/contributors.html
index df4855baa2c..afcf17737c6 100644
--- a/layouts/shortcodes/contributors.html
+++ b/layouts/shortcodes/contributors.html
@@ -1,5 +1,5 @@
-
+
Contributors
{{.Site.Data.team.totalCount }}
Re: [PR] add a anchor for `Contributors` [skywalking-website]
wu-sheng merged PR #674: URL: https://github.com/apache/skywalking-website/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add a anchor for `Contributors` [skywalking-website]
netlify[bot] commented on PR #674: URL: https://github.com/apache/skywalking-website/pull/674#issuecomment-1902131470 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | c53db79923373e9b2ab14a33f030c0110d2298b1 | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/65abe521f8d33900081c0534 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] add a anchor for `Contributors` [skywalking-website]
Jtrust opened a new pull request, #674: URL: https://github.com/apache/skywalking-website/pull/674 hover your mouse over the `Contributors`, and then the anchor is visible： https://github.com/apache/skywalking-website/assets/21056967/77751eb9-058f-4f1b-b0f2-b5be51ff1c98;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Convert the Redisson lock span into an async span [skywalking-java]
peachisai commented on code in PR #667:
URL: https://github.com/apache/skywalking-java/pull/667#discussion_r1460492929
##
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java:
##
@@ -48,7 +50,19 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable {
+AbstractSpan span = ContextManager.activeSpan();
+span.prepareForAsync();
ContextManager.stopSpan();
+
+RFuture future = (RFuture) ret;
+CompletableFuture completableFuture =
future.toCompletableFuture();
+completableFuture.whenCompleteAsync((res, ex) -> {
Review Comment:
> AFAIK, as you picked `#whenCompleteAsync`, you can't guarantee the given
execution(`span#asyncFinish`) called in time. The execution time could be
longer than expected.
How about this
```
RFuture future = (RFuture) ret;
CompletableFuture completableFuture =
future.toCompletableFuture();
CompletableFuture.runAsync(()->{
completableFuture.join();
span.asyncFinish();
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin [skywalking-java]
CzyerChen commented on code in PR #665:
URL: https://github.com/apache/skywalking-java/pull/665#discussion_r1460452194
##
apm-sniffer/apm-sdk-plugin/rocketMQ-client-java-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/client/java/v5/RocketMqClientJavaPluginConfig.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.rocketMQ.client.java.v5;
+
+import org.apache.skywalking.apm.agent.core.boot.PluginConfig;
+
+public class RocketMqClientJavaPluginConfig {
+public static class Plugin {
+@PluginConfig(root = RocketMqClientJavaPluginConfig.class)
+public static class Rocketmqclient {
+/**
+ * This config item controls that whether the RocketMqClientJava
plugin should collect the keys of the message.
+ */
+public static boolean COLLECT_MESSAGE_KEYS = false;
+/**
+ * This config item controls that whether the RocketMqClientJava
plugin should collect the tags of the message.
+ */
+public static boolean COLLECT_MESSAGE_TAGS = false;
+}
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin [skywalking-java]
wu-sheng commented on code in PR #665:
URL: https://github.com/apache/skywalking-java/pull/665#discussion_r1460450613
##
apm-sniffer/apm-sdk-plugin/rocketMQ-client-java-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/client/java/v5/RocketMqClientJavaPluginConfig.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.rocketMQ.client.java.v5;
+
+import org.apache.skywalking.apm.agent.core.boot.PluginConfig;
+
+public class RocketMqClientJavaPluginConfig {
+public static class Plugin {
+@PluginConfig(root = RocketMqClientJavaPluginConfig.class)
+public static class Rocketmqclient {
+/**
+ * This config item controls that whether the RocketMqClientJava
plugin should collect the keys of the message.
+ */
+public static boolean COLLECT_MESSAGE_KEYS = false;
+/**
+ * This config item controls that whether the RocketMqClientJava
plugin should collect the tags of the message.
+ */
+public static boolean COLLECT_MESSAGE_TAGS = false;
+}
Review Comment:
You should activate these two options in the test scenarios, to make sure
they could work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin [skywalking-java]
wu-sheng commented on code in PR #665:
URL: https://github.com/apache/skywalking-java/pull/665#discussion_r1460449709
##
apm-sniffer/config/agent.config:
##
@@ -316,3 +316,7 @@
plugin.nettyhttp.collect_request_body=${SW_PLUGIN_NETTYHTTP_COLLECT_REQUEST_BODY
plugin.nettyhttp.filter_length_limit=${SW_PLUGIN_NETTYHTTP_FILTER_LENGTH_LIMIT:1024}
# When `HTTP_COLLECT_REQUEST_BODY` is enabled and content-type start with
HTTP_SUPPORTED_CONTENT_TYPES_PREFIX, collect the body of the request , multiple
paths should be separated by `,`
plugin.nettyhttp.supported_content_types_prefix=${SW_PLUGIN_NETTYHTTP_SUPPORTED_CONTENT_TYPES_PREFIX:application/json,text/}
+# If set to true, the keys of RocketMQ mesaages would be collected by RocketMQ
client java agent.
Review Comment:
```suggestion
# If set to true, the keys of messages would be collected by the plugin for
RocketMQ Java client.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin [skywalking-java]
wu-sheng commented on code in PR #665:
URL: https://github.com/apache/skywalking-java/pull/665#discussion_r1460449915
##
apm-sniffer/config/agent.config:
##
@@ -316,3 +316,7 @@
plugin.nettyhttp.collect_request_body=${SW_PLUGIN_NETTYHTTP_COLLECT_REQUEST_BODY
plugin.nettyhttp.filter_length_limit=${SW_PLUGIN_NETTYHTTP_FILTER_LENGTH_LIMIT:1024}
# When `HTTP_COLLECT_REQUEST_BODY` is enabled and content-type start with
HTTP_SUPPORTED_CONTENT_TYPES_PREFIX, collect the body of the request , multiple
paths should be separated by `,`
plugin.nettyhttp.supported_content_types_prefix=${SW_PLUGIN_NETTYHTTP_SUPPORTED_CONTENT_TYPES_PREFIX:application/json,text/}
+# If set to true, the keys of RocketMQ mesaages would be collected by RocketMQ
client java agent.
+plugin.rocketmqclient.collect_message_keys=${SW_PLUGIN_ROCKETMQCLIENT_COLLECT_MESSAGE_KEYS:false}
+# If set to true, the tags of RocketMQ mesaages would be collected by RocketMQ
client java agent.
Review Comment:
```suggestion
# If set to true, the tags of messages would be collected by the plugin for
RocketMQ Java client.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin [skywalking-java]
wu-sheng commented on code in PR #665:
URL: https://github.com/apache/skywalking-java/pull/665#discussion_r1460449709
##
apm-sniffer/config/agent.config:
##
@@ -316,3 +316,7 @@
plugin.nettyhttp.collect_request_body=${SW_PLUGIN_NETTYHTTP_COLLECT_REQUEST_BODY
plugin.nettyhttp.filter_length_limit=${SW_PLUGIN_NETTYHTTP_FILTER_LENGTH_LIMIT:1024}
# When `HTTP_COLLECT_REQUEST_BODY` is enabled and content-type start with
HTTP_SUPPORTED_CONTENT_TYPES_PREFIX, collect the body of the request , multiple
paths should be separated by `,`
plugin.nettyhttp.supported_content_types_prefix=${SW_PLUGIN_NETTYHTTP_SUPPORTED_CONTENT_TYPES_PREFIX:application/json,text/}
+# If set to true, the keys of RocketMQ mesaages would be collected by RocketMQ
client java agent.
Review Comment:
```suggestion
# If set to true, the keys of messages would be collected by the plugin for
RocketMQ client Java agent.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin [skywalking-java]
CzyerChen commented on code in PR #665:
URL: https://github.com/apache/skywalking-java/pull/665#discussion_r1460448789
##
apm-sniffer/apm-sdk-plugin/rocketMQ-client-java-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/client/java/v5/MessageListenerInterceptor.java:
##
@@ -72,7 +81,11 @@ public Object afterMethod(EnhancedInstance objInst, Method
method, Object[] allA
}
@Override
-public void handleMethodException(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Throwable t) {
+public void handleMethodException(EnhancedInstance objInst,
+ Method method,
+ Object[] allArguments,
+ Class[] argumentsTypes,
+ Throwable t) {
Review Comment:
revert & resubmitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin [skywalking-java]
CzyerChen commented on code in PR #665:
URL: https://github.com/apache/skywalking-java/pull/665#discussion_r1460448651
##
apm-sniffer/apm-sdk-plugin/rocketMQ-client-java-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/client/java/v5/MessageSendAsyncInterceptor.java:
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.rocketMQ.client.java.v5;
+
+import java.lang.reflect.Method;
+import java.util.Collection;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import org.apache.rocketmq.client.apis.message.Message;
+import org.apache.rocketmq.client.apis.message.MessageBuilder;
+import org.apache.rocketmq.client.apis.producer.SendReceipt;
+import org.apache.rocketmq.client.java.impl.ClientImpl;
+import org.apache.rocketmq.client.java.message.MessageBuilderImpl;
+import org.apache.rocketmq.shaded.com.google.gson.Gson;
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.agent.core.util.CollectionUtil;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+import org.apache.skywalking.apm.util.StringUtil;
+
+/**
+ * {@link MessageSendAsyncInterceptor} create exit span when the method {@link
org.apache.rocketmq.client.java.impl.producer.ProducerImpl#sendAsync(org.apache.rocketmq.client.apis.message.Message)}
+ * execute
+ */
+public class MessageSendAsyncInterceptor implements
InstanceMethodsAroundInterceptor {
+
+public static final String ASYNC_SEND_OPERATION_NAME_PREFIX = "RocketMQ/";
+public static final Gson GSON = new Gson();
+
+@Override
+public void beforeMethod(EnhancedInstance objInst,
+ Method method,
+ Object[] allArguments,
+ Class[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+Message message = (Message) allArguments[0];
+ClientImpl producerImpl = (ClientImpl) objInst;
+
+ContextCarrier contextCarrier = new ContextCarrier();
+String namingServiceAddress =
producerImpl.getClientConfiguration().getEndpoints();
+AbstractSpan span = ContextManager.createExitSpan(
+buildOperationName(message.getTopic()), contextCarrier,
namingServiceAddress);
+span.setComponent(ComponentsDefine.ROCKET_MQ_PRODUCER);
+Tags.MQ_BROKER.set(span, namingServiceAddress);
+Tags.MQ_TOPIC.set(span, message.getTopic());
+Collection keys = message.getKeys();
+if (!CollectionUtil.isEmpty(keys)) {
+span.tag(Tags.ofKey("mq.message.keys"), String.join(",", keys));
Review Comment:
updated & resubmitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support tracing for async producing, batch sync consuming, and batch async consuming in rocketMQ-client-java-5.x-plugin [skywalking-java]
CzyerChen commented on code in PR #665:
URL: https://github.com/apache/skywalking-java/pull/665#discussion_r1460448539
##
apm-sniffer/apm-sdk-plugin/rocketMQ-client-java-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/client/java/v5/MessageSendAsyncInterceptor.java:
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.rocketMQ.client.java.v5;
+
+import java.lang.reflect.Method;
+import java.util.Collection;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import org.apache.rocketmq.client.apis.message.Message;
+import org.apache.rocketmq.client.apis.message.MessageBuilder;
+import org.apache.rocketmq.client.apis.producer.SendReceipt;
+import org.apache.rocketmq.client.java.impl.ClientImpl;
+import org.apache.rocketmq.client.java.message.MessageBuilderImpl;
+import org.apache.rocketmq.shaded.com.google.gson.Gson;
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.agent.core.util.CollectionUtil;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+import org.apache.skywalking.apm.util.StringUtil;
+
+/**
+ * {@link MessageSendAsyncInterceptor} create exit span when the method {@link
org.apache.rocketmq.client.java.impl.producer.ProducerImpl#sendAsync(org.apache.rocketmq.client.apis.message.Message)}
+ * execute
+ */
+public class MessageSendAsyncInterceptor implements
InstanceMethodsAroundInterceptor {
+
+public static final String ASYNC_SEND_OPERATION_NAME_PREFIX = "RocketMQ/";
+public static final Gson GSON = new Gson();
+
+@Override
+public void beforeMethod(EnhancedInstance objInst,
+ Method method,
+ Object[] allArguments,
+ Class[] argumentsTypes,
+ MethodInterceptResult result) throws Throwable {
+Message message = (Message) allArguments[0];
+ClientImpl producerImpl = (ClientImpl) objInst;
+
+ContextCarrier contextCarrier = new ContextCarrier();
+String namingServiceAddress =
producerImpl.getClientConfiguration().getEndpoints();
+AbstractSpan span = ContextManager.createExitSpan(
+buildOperationName(message.getTopic()), contextCarrier,
namingServiceAddress);
+span.setComponent(ComponentsDefine.ROCKET_MQ_PRODUCER);
+Tags.MQ_BROKER.set(span, namingServiceAddress);
+Tags.MQ_TOPIC.set(span, message.getTopic());
+Collection keys = message.getKeys();
+if (!CollectionUtil.isEmpty(keys)) {
+span.tag(Tags.ofKey("mq.message.keys"), String.join(",", keys));
+}
+Optional tag = message.getTag();
+tag.ifPresent(s -> span.tag(Tags.ofKey("mq.message.tags"), s));
Review Comment:
added & resubmitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore: print log code normalization [skywalking-banyandb]
wu-sheng commented on PR #376: URL: https://github.com/apache/skywalking-banyandb/pull/376#issuecomment-1902097421 @hanahmily What does the CI error mean? It seems not related to this PR changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Optimize service conflict error message [skywalking-java]
wu-sheng commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1902097231 @lujiajing1126 Could you recheck the new linked issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: print log code normalization [skywalking-banyandb]
codecov-commenter commented on PR #376: URL: https://github.com/apache/skywalking-banyandb/pull/376#issuecomment-1902097160 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/376?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `6 lines` in your changes are missing coverage. Please review. > Comparison is base [(`08d8dc8`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/08d8dc81f676078bc7776ec69bd99ea8cfc811e4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.75% compared to head [(`20296c9`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/376?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.75%. | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/376?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [pkg/wal/wal.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/376?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL3dhbC93YWwuZ28=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/376?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #376 +/- ## === Coverage 44.75% 44.75% === Files 152 152 Lines 1781717817 === Hits 7974 7974 Misses 9128 9128 Partials 715 715 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/376?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: print log code normalization [skywalking-banyandb]
caicancai commented on PR #376: URL: https://github.com/apache/skywalking-banyandb/pull/376#issuecomment-1902096747 > @hanahmily Do we have such detailed code style check now? Judging from the cli error, it seems that it cannot be changed in this way. Do I need to close this PR? This may be personal obsessive-compulsive disorder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: print log code normalization [skywalking-banyandb]
wu-sheng commented on PR #376: URL: https://github.com/apache/skywalking-banyandb/pull/376#issuecomment-1902096205 @hanahmily Do we have such detailed code style check now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore: print log code normalization [skywalking-banyandb]
caicancai opened a new pull request, #376: URL: https://github.com/apache/skywalking-banyandb/pull/376 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Optimize service conflict error message [skywalking-java]
wongtp commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1902095133 > I am confused why this is related to the [apache/skywalking#10991](https://github.com/apache/skywalking/issues/10991)? > > The linked issue may be caused by version compatibility of the Netty plugin. It must not relevant to the kernel. I checked again the relate issue [intercept failure](https://github.com/apache/skywalking/issues/10991), It should be relate to [issues/11205](https://github.com/apache/skywalking/issues/11205) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: print log code normalization [skywalking-banyandb]
caicancai closed pull request #375: chore: print log code normalization URL: https://github.com/apache/skywalking-banyandb/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore: print log code normalization [skywalking-banyandb]
caicancai opened a new pull request, #375: URL: https://github.com/apache/skywalking-banyandb/pull/375 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Optimize service conflict error message [skywalking-java]
wu-sheng commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1902090139 @wongtp The argument is, that the reason of the changes is not clear. If you just want to enhance logs to make the conflicts more readable, I think it is OK to accept. But the issue you are referring to, it is not clearly related to this change. We need to keep the discussion context clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Convert the Redisson lock span into an async span [skywalking-java]
wu-sheng commented on code in PR #667:
URL: https://github.com/apache/skywalking-java/pull/667#discussion_r1460428670
##
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonHighLevelLockInterceptor.java:
##
@@ -48,7 +50,19 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable {
+AbstractSpan span = ContextManager.activeSpan();
+span.prepareForAsync();
ContextManager.stopSpan();
+
+RFuture future = (RFuture) ret;
+CompletableFuture completableFuture =
future.toCompletableFuture();
+completableFuture.whenCompleteAsync((res, ex) -> {
Review Comment:
AFAIK, as you picked `#whenCompleteAsync`, you can't guarantee the given
execution(`span#asyncFinish`) called in time. The execution time could be
longer than expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Convert the Redisson lock span into an async span [skywalking-java]
peachisai opened a new pull request, #667: URL: https://github.com/apache/skywalking-java/pull/667 - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). Refer https://github.com/apache/skywalking/discussions/11799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: 7da5e4a897c97d88a5bee4ed26e896f851e152df
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new bea3d2df525 deploy: 7da5e4a897c97d88a5bee4ed26e896f851e152df
bea3d2df525 is described below
commit bea3d2df525572aee0640da0d05bce10245435bf
Author: wu-sheng
AuthorDate: Sat Jan 20 10:05:50 2024 +
deploy: 7da5e4a897c97d88a5bee4ed26e896f851e152df
---
contributors/index.html | 20 ++--
index.json | 2 +-
team/index.html | 8
3 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/contributors/index.html b/contributors/index.html
index c01988a49bd..02d545438b9 100644
--- a/contributors/index.html
+++ b/contributors/index.html
@@ -19062,29 +19062,29 @@
-
+
-https://github.com/BFergerson;
target="_blank">
+https://github.com/caicancai;
target="_blank">
- BFergerson
+ caicancai
-1
-16
+2
+16
-
+
-https://github.com/caicancai;
target="_blank">
+https://github.com/BFergerson;
target="_blank">
- caicancai
+ BFergerson
-1
-17
+1
+17
diff --git a/index.json b/index.json
index 7dfad94cb2f..d47d8d89628 100644
--- a/index.json
+++ b/index.json
@@ -1 +1 @@
-[{"body":"","excerpt":"","ref":"/tags/nginx/","title":"Nginx"},{"body":"背景介绍 在
Scala 中，纯函数式中主要使用 Fiber，而不是线程，诸如 Cats-Effect、ZIO 等 Effect 框架。 您可以将 Fiber
视为轻量级线程，它是一种并发模型，由框架本身掌控控制权，从而消除了上下文切换的开销。 基于这些 Effect 框架开发的 HTTP、gRCP、GraphQL
库而开发的应用，我们一般称为 纯函数式应用程序。\n我们以 ZIO 为切入点， 演示 SkyWalking Scala 如何支持 Effect
生态。\nZIO Trace 首先，我们想要实现 Fiber 上下文传递，而不是监控 Fiber 本身。对于一个大型应用来说，可能存在成千上万个
Fiber，监控 Fiber 本身的意义不大。\n虽然 Fiber 的 Span 是在活跃时才会创建，但难免会有目前遗漏的场景，所以提供了一个配置
plugin.ziov2.ignore_fiber_regexes。 它将使用正则去 [...]
\ No newline at end of file
+[{"body":"","excerpt":"","ref":"/tags/nginx/","title":"Nginx"},{"body":"背景介绍 在
Scala 中，纯函数式中主要使用 Fiber，而不是线程，诸如 Cats-Effect、ZIO 等 Effect 框架。 您可以将 Fiber
视为轻量级线程，它是一种并发模型，由框架本身掌控控制权，从而消除了上下文切换的开销。 基于这些 Effect 框架开发的 HTTP、gRCP、GraphQL
库而开发的应用，我们一般称为 纯函数式应用程序。\n我们以 ZIO 为切入点， 演示 SkyWalking Scala 如何支持 Effect
生态。\nZIO Trace 首先，我们想要实现 Fiber 上下文传递，而不是监控 Fiber 本身。对于一个大型应用来说，可能存在成千上万个
Fiber，监控 Fiber 本身的意义不大。\n虽然 Fiber 的 Span 是在活跃时才会创建，但难免会有目前遗漏的场景，所以提供了一个配置
plugin.ziov2.ignore_fiber_regexes。 它将使用正则去 [...]
\ No newline at end of file
diff --git a/team/index.html b/team/index.html
index bd2abf6296f..552b27ef7ff 100644
--- a/team/index.html
+++ b/team/index.html
@@ -15174,9 +15174,9 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
-https://github.com/BFergerson;
target="_blank">
+https://github.com/caicancai;
target="_blank">
- BFergerson
+ caicancai
@@ -15184,9 +15184,9 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
-https://github.com/caicancai;
target="_blank">
+https://github.com/BFergerson;
target="_blank">
- caicancai
+ BFergerson
Re: [PR] feat: Search contributor information [skywalking-website]
wu-sheng commented on PR #673: URL: https://github.com/apache/skywalking-website/pull/673#issuecomment-1902052588 Thanks for adding this, it is great to provide permanent link for every contributor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch master updated: feat: Search contributor information (#673)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new 7da5e4a897c feat: Search contributor information (#673)
7da5e4a897c is described below
commit 7da5e4a897c97d88a5bee4ed26e896f851e152df
Author: Juntao Zhang <719284...@qq.com>
AuthorDate: Sat Jan 20 17:55:13 2024 +0800
feat: Search contributor information (#673)
---
assets/scss/_custom_contributors.scss | 149 +
assets/scss/_custom_team.scss | 26
content/contributors/_index.md | 9 ++
layouts/shortcodes/contributors-search.html| 59
layouts/shortcodes/contributors.html | 14 +-
themes/docsy/assets/scss/_custom_contributors.scss | 0
themes/docsy/assets/scss/_styles_project.scss | 1 +
themes/docsy/layouts/contributors/baseof.html | 25
themes/docsy/layouts/contributors/list.html| 11 ++
themes/docsy/layouts/partials/script-search.html | 23
themes/docsy/layouts/partials/script-team.html | 13 +-
11 files changed, 325 insertions(+), 5 deletions(-)
diff --git a/assets/scss/_custom_contributors.scss
b/assets/scss/_custom_contributors.scss
new file mode 100644
index 000..08ad5a2ef13
--- /dev/null
+++ b/assets/scss/_custom_contributors.scss
@@ -0,0 +1,149 @@
+.td-contributors {
+ .page-title {
+margin-bottom: 0.5em;
+ }
+ .head-wrapper {
+display: flex;
+line-height: 40px;
+font-size: 15px;
+font-weight: bold;
+background-color: #f6f8fa;
+padding: 0 0.4em;
+position: sticky;
+
+.title {
+ flex: 1;
+ padding: 0.6em;
+
+ &:nth-child(1) {
+flex: 1.8;
+ }
+}
+ }
+
+ .contributors-wrapper {
+font-size: 14px;
+display: flex;
+flex-direction: column;
+
+.item-wrapper {
+ min-height: 55px;
+ flex-wrap: wrap;
+ padding: 0 0.4em;
+ display: none;
+
+ &.show {
+display: flex;
+
+&:nth-child(even) {
+ background-color: #f6f8fa;
+}
+ }
+
+ .item {
+flex: 1;
+padding: 0 0.6em;
+display: flex;
+align-items: center;
+
+&:nth-child(1) {
+ flex: 0.9;
+}
+
+.total {
+ font-size: 16px;
+}
+
+.item-text {
+ display: flex;
+ align-items: center;
+
+ img {
+margin-right: 0.3rem;
+ }
+}
+ }
+}
+
+.item-contributors {
+ flex: 1;
+
+ .d-flex {
+align-items: center;
+.dn {
+ display: none!important;
+}
+> div {
+ line-height: 55px;
+ padding: 0 0.6em;
+ display: none;
+ width: 50%;
+}
+ }
+
+ ul, li {
+margin: 0;
+padding: 0;
+ }
+
+ li {
+position: relative;
+border: 1px solid #eaecef;
+border-radius: 4px;
+padding: 4px 7px;
+box-shadow: #f8f9fa 0px 1px 2px 0px;
+
+a {
+ color: #2c3e50;
+}
+
+.contributions-count {
+ color: #999;
+}
+
+&.active {
+ color: #1e80ff;
+ background: linear-gradient(180deg, #479EEB 0%, #3788D0 100%);
+ box-shadow: 0px 2px 6px #ABD1F2;
+
+ .contributions-count {
+color: #666;
+ }
+}
+
+ }
+}
+
+ }
+
+ .search-tips {
+text-align: center;
+padding: 3em;
+font-size: 16px;
+color: #999;
+ }
+
+ @media (max-width: 992px) {
+.contributors-wrapper {
+ .head-wrapper {
+.title {
+ &:nth-child(1) {
+flex: 3.8;
+ }
+}
+ }
+ img {
+display: none;
+ }
+
+ .item-contributors {
+.item {
+ &:nth-child(1) {
+flex: 1.8;
+ }
+}
+ }
+}
+ }
+}
+
diff --git a/assets/scss/_custom_team.scss b/assets/scss/_custom_team.scss
index c93d72f1aac..afa35f1c779 100644
--- a/assets/scss/_custom_team.scss
+++ b/assets/scss/_custom_team.scss
@@ -87,6 +87,32 @@
}
}
+ .team-input-group {
+width: 300px;
+padding-bottom: 1em;
+.form-control {
+ border: solid 1px #dfdfdf;
+ border-radius: 3px;
+ &:focus-visible {
+outline: none;
+box-shadow: none;
+ }
+}
+.btn-outline-success {
+ border: solid 1px #dfdfdf;
+ color: #2c3e50;
+ &:focus,
+ &:active,
+ &:hover {
+z-index: 9;
+background-color: #3788d0d6;
+border-color: #3788d0d6;
+color: #fff;
+box-shadow: none!important;
+ }
+}
+ }
+
.contributors-wrapper {
.item-wrapper {
display: flex;
diff --git a/content/contributors/_index.md
Re: [PR] feat: Search contributor information [skywalking-website]
wu-sheng merged PR #673: URL: https://github.com/apache/skywalking-website/pull/673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: Search contributor information [skywalking-website]
netlify[bot] commented on PR #673: URL: https://github.com/apache/skywalking-website/pull/673#issuecomment-1902044073 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | beb6f4ecde5f1967763a051f7f891f46c0699978 | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/65ab968ec38a6400083e206c | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] feat: Search contributor information [skywalking-website]
Jtrust opened a new pull request, #673: URL: https://github.com/apache/skywalking-website/pull/673 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch main updated: chore: fix error log (#374)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 08d8dc81 chore: fix error log (#374)
08d8dc81 is described below
commit 08d8dc81f676078bc7776ec69bd99ea8cfc811e4
Author: Cancai Cai <77189278+caican...@users.noreply.github.com>
AuthorDate: Sat Jan 20 17:33:37 2024 +0800
chore: fix error log (#374)
---
pkg/wal/wal.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkg/wal/wal.go b/pkg/wal/wal.go
index 0d9fac6c..eb9d0db0 100644
--- a/pkg/wal/wal.go
+++ b/pkg/wal/wal.go
@@ -251,7 +251,7 @@ func New(path string, options *Options) (WAL, error) {
}
log.start()
- log.logger.Info().Str("path", path).Msg("WAL has be initialized")
+ log.logger.Info().Str("path", path).Msg("WAL has been initialized")
return log, nil
}
Re: [PR] chore: fix error log [skywalking-banyandb]
wu-sheng merged PR #374: URL: https://github.com/apache/skywalking-banyandb/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: fix error log [skywalking-banyandb]
caicancai commented on PR #374: URL: https://github.com/apache/skywalking-banyandb/pull/374#issuecomment-1902036960 Thank you for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: fix error log [skywalking-banyandb]
codecov-commenter commented on PR #374: URL: https://github.com/apache/skywalking-banyandb/pull/374#issuecomment-1902034373 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/374?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `1 lines` in your changes are missing coverage. Please review. > Comparison is base [(`e69aaa1`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/e69aaa137ddf317cf850d54bcc50fcc9272d10b6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.75% compared to head [(`b23fc94`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/374?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.71%. > :exclamation: Current head b23fc94 differs from pull request most recent head ae2fad3. Consider uploading reports for the commit ae2fad3 to get more accurate results | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/374?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [pkg/wal/wal.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/374?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL3dhbC93YWwuZ28=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/374?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## main #374 +/- ## == - Coverage 44.75% 44.71% -0.05% == Files 152 152 Lines 1781717817 == - Hits 7974 7966 -8 - Misses 9128 9134 +6 - Partials 715 717 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/374?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: fix error log [skywalking-banyandb]
caicancai commented on PR #374: URL: https://github.com/apache/skywalking-banyandb/pull/374#issuecomment-1902029156 This should be WAL has been initialized, not WAL has be initialized -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore: fix error log [skywalking-banyandb]
caicancai opened a new pull request, #374: URL: https://github.com/apache/skywalking-banyandb/pull/374 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
