Re: [PR] Increase `SW_CORE_GRPC_MAX_MESSAGE_SIZE` to 50MB and e2e bump up the version of the opentelemetry-collector to 0.102.1. [skywalking]
wu-sheng merged PR #12321: URL: https://github.com/apache/skywalking/pull/12321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [BanyanDB] Metrics breaks periodically [skywalking]
wu-sheng closed issue #12312: [Bug] [BanyanDB] Metrics breaks periodically URL: https://github.com/apache/skywalking/issues/12312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Increase `SW_CORE_GRPC_MAX_MESSAGE_SIZE` to 50MB and e2e bump up the version of the opentelemetry-collector to 0.102.1. [skywalking]
wu-sheng commented on code in PR #12321: URL: https://github.com/apache/skywalking/pull/12321#discussion_r1634653708 ## docs/en/setup/backend/configuration-vocabulary.md: ## @@ -38,7 +38,7 @@ The Configuration Vocabulary lists all available configurations provided by `app | - | - | autocompleteTagValuesQueryMaxSize | The max size of tags values for autocomplete select. | SW_AUTOCOMPLETE_TAG_VALUES_QUERY_MAX_SIZE | 100 | | - | - | gRPCThreadPoolSize | Pool size of gRPC server. | SW_CORE_GRPC_THREAD_POOL_SIZE | Default to gRPC's implementation, which is a cached thread pool that can grow infinitely.| | - | - | maxConcurrentCallsPerConnection | The maximum number of concurrent calls permitted for each incoming connection. Defaults to no limit. | SW_CORE_GRPC_MAX_CONCURRENT_CALL | - | -| - | - | maxMessageSize | Sets the maximum message size allowed to be received on the server. Empty means 4 MiB. | SW_CORE_GRPC_MAX_MESSAGE_SIZE | 4M(based on Netty) | +| - | - | maxMessageSize | Sets the maximum message size allowed to be received on the server. Empty means 4 MiB. | SW_CORE_GRPC_MAX_MESSAGE_SIZE | 52428800 (50MB) | Review Comment: Yes, we noticed this on demo deployment. We increased application.yml values, so yes, default values changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Increase `SW_CORE_GRPC_MAX_MESSAGE_SIZE` to 50MB and e2e bump up the version of the opentelemetry-collector to 0.102.1. [skywalking]
Superskyyy commented on code in PR #12321: URL: https://github.com/apache/skywalking/pull/12321#discussion_r1634647351 ## docs/en/setup/backend/configuration-vocabulary.md: ## @@ -38,7 +38,7 @@ The Configuration Vocabulary lists all available configurations provided by `app | - | - | autocompleteTagValuesQueryMaxSize | The max size of tags values for autocomplete select. | SW_AUTOCOMPLETE_TAG_VALUES_QUERY_MAX_SIZE | 100 | | - | - | gRPCThreadPoolSize | Pool size of gRPC server. | SW_CORE_GRPC_THREAD_POOL_SIZE | Default to gRPC's implementation, which is a cached thread pool that can grow infinitely.| | - | - | maxConcurrentCallsPerConnection | The maximum number of concurrent calls permitted for each incoming connection. Defaults to no limit. | SW_CORE_GRPC_MAX_CONCURRENT_CALL | - | -| - | - | maxMessageSize | Sets the maximum message size allowed to be received on the server. Empty means 4 MiB. | SW_CORE_GRPC_MAX_MESSAGE_SIZE | 4M(based on Netty) | +| - | - | maxMessageSize | Sets the maximum message size allowed to be received on the server. Empty means 4 MiB. | SW_CORE_GRPC_MAX_MESSAGE_SIZE | 52428800 (50MB) | Review Comment: Default means 50MB? ## docs/en/setup/backend/configuration-vocabulary.md: ## @@ -171,6 +171,7 @@ The Configuration Vocabulary lists all available configurations provided by `app | - | - | gRPCSslKeyPath | File path of gRPC SSL key.
Re: [PR] Increase `SW_CORE_GRPC_MAX_MESSAGE_SIZE` to 50MB and e2e bump up the version of the opentelemetry-collector to 0.102.1. [skywalking]
wankai123 commented on code in PR #12321:
URL: https://github.com/apache/skywalking/pull/12321#discussion_r1634635040
##
oap-server/server-starter/src/main/resources/application.yml:
##
@@ -81,7 +81,7 @@ core:
gRPCHost: ${SW_CORE_GRPC_HOST:0.0.0.0}
gRPCPort: ${SW_CORE_GRPC_PORT:11800}
maxConcurrentCallsPerConnection: ${SW_CORE_GRPC_MAX_CONCURRENT_CALL:0}
-maxMessageSize: ${SW_CORE_GRPC_MAX_MESSAGE_SIZE:0}
+maxMessageSize: ${SW_CORE_GRPC_MAX_MESSAGE_SIZE:52428800} #50MB
Review Comment:
increased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Increase `SW_CORE_GRPC_MAX_MESSAGE_SIZE` to 50MB and e2e bump up the version of the opentelemetry-collector to 0.102.1. [skywalking]
wu-sheng commented on code in PR #12321:
URL: https://github.com/apache/skywalking/pull/12321#discussion_r1634620498
##
oap-server/server-starter/src/main/resources/application.yml:
##
@@ -81,7 +81,7 @@ core:
gRPCHost: ${SW_CORE_GRPC_HOST:0.0.0.0}
gRPCPort: ${SW_CORE_GRPC_PORT:11800}
maxConcurrentCallsPerConnection: ${SW_CORE_GRPC_MAX_CONCURRENT_CALL:0}
-maxMessageSize: ${SW_CORE_GRPC_MAX_MESSAGE_SIZE:0}
+maxMessageSize: ${SW_CORE_GRPC_MAX_MESSAGE_SIZE:52428800} #50MB
Review Comment:
Could you check sharing server config too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Increase `SW_CORE_GRPC_MAX_MESSAGE_SIZE` to 50MB and e2e bump up the version of the opentelemetry-collector to 0.102.1. [skywalking]
wankai123 opened a new pull request, #12321: URL: https://github.com/apache/skywalking/pull/12321 - [X] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #12312. - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wu-sheng commented on PR #12316: URL: https://github.com/apache/skywalking/pull/12316#issuecomment-2160129111 I think once you fix another suggestion, and add dashboards for these relations, we're good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
yswdqz commented on PR #12316: URL: https://github.com/apache/skywalking/pull/12316#issuecomment-2160024957 > What do you mean other codes? I mean your new added codes. The previous ones are for other cases, aren't they? Whatever the type,Layer has added at here. https://github.com/apache/skywalking/blob/caeaec6387cf43bb8659238c18cc0c56b9226cc8/oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/rt/PromQLExprQueryVisitor.java#L217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wu-sheng commented on PR #12316: URL: https://github.com/apache/skywalking/pull/12316#issuecomment-2159966549 > > You don't add source layer, I think? > > Source Layer has added at another code. What do you mean other codes? I mean your new added codes. The previous ones are for other cases, aren't they? > > > Please order them in a certain order to avoid confusion. > > Is the checklabel part? Yes. It helps for code reading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
yswdqz commented on PR #12316: URL: https://github.com/apache/skywalking/pull/12316#issuecomment-2159961236 > You don't add source layer, I think? Source Layer has added at another code. > Please order them in a certain order to avoid confusion. Is the checklabel part? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wu-sheng commented on PR #12316: URL: https://github.com/apache/skywalking/pull/12316#issuecomment-2159819771 You don't add source layer, I think? Please order them in a certain order to avoid confusion. Service + instance/endpoint + layer at both sides. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove unnecessary BanyanDB flushing logs(info). [skywalking]
wu-sheng merged PR #12319: URL: https://github.com/apache/skywalking/pull/12319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Check Unregistered Nodes in Background [skywalking-banyandb]
ButterBright commented on PR #466: URL: https://github.com/apache/skywalking-banyandb/pull/466#issuecomment-2159696593 Okay, I understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove unnecessary BanyanDB flushing logs(info). [skywalking]
wu-sheng opened a new pull request, #12319: URL: https://github.com/apache/skywalking/pull/12319 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wankai123 commented on code in PR #12316: URL: https://github.com/apache/skywalking/pull/12316#discussion_r1634009813 ## oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/rt/PromQLExprQueryVisitor.java: ## @@ -440,6 +440,32 @@ private Entity buildEntity(Layer layer, checkLabels(labelMap, LabelName.ENDPOINT); entity.setEndpointName(labelMap.get(LabelName.ENDPOINT)); break; +case ServiceRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_LAYER); + entity.setDestServiceName(labelMap.get(LabelName.DEST_SERVICE)); + entity.setDestNormal(Layer.nameOf(labelMap.get(LabelName.DEST_LAYER)).isNormal()); +break; +case ServiceInstanceRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_SERVICE_INSTANCE); +checkLabels(labelMap, LabelName.SERVICE_INSTANCE); +checkLabels(labelMap, LabelName.DEST_LAYER); + entity.setServiceInstanceName(labelMap.get(LabelName.SERVICE_INSTANCE)); + entity.setDestServiceInstanceName(labelMap.get(LabelName.DEST_SERVICE_INSTANCE)); + entity.setDestServiceName(labelMap.get(LabelName.DEST_SERVICE)); + entity.setDestNormal(Layer.nameOf(labelMap.get(LabelName.DEST_LAYER)).isNormal()); +break; +case EndpointRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_ENDPOINT); +checkLabels(labelMap, LabelName.ENDPOINT); +checkLabels(labelMap, LabelName.DEST_LAYER); Review Comment: ```suggestion checkLabels(labelMap, LabelName.ENDPOINT, LabelName.DEST_SERVICE, LabelName.DEST_ENDPOINT, LabelName.ENDPOINT, LabelName.DEST_LAYER); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wankai123 commented on code in PR #12316: URL: https://github.com/apache/skywalking/pull/12316#discussion_r1634009482 ## oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/rt/PromQLExprQueryVisitor.java: ## @@ -440,6 +440,32 @@ private Entity buildEntity(Layer layer, checkLabels(labelMap, LabelName.ENDPOINT); entity.setEndpointName(labelMap.get(LabelName.ENDPOINT)); break; +case ServiceRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_LAYER); + entity.setDestServiceName(labelMap.get(LabelName.DEST_SERVICE)); + entity.setDestNormal(Layer.nameOf(labelMap.get(LabelName.DEST_LAYER)).isNormal()); +break; +case ServiceInstanceRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_SERVICE_INSTANCE); +checkLabels(labelMap, LabelName.SERVICE_INSTANCE); +checkLabels(labelMap, LabelName.DEST_LAYER); Review Comment: ```suggestion checkLabels(labelMap, , LabelName.SERVICE_INSTANCE, LabelName.DEST_SERVICE, LabelName.DEST_SERVICE_INSTANCE, LabelName.SERVICE_INSTANCE, LabelName.DEST_LAYER); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Check Unregistered Nodes in Background [skywalking-banyandb]
wu-sheng commented on PR #466: URL: https://github.com/apache/skywalking-banyandb/pull/466#issuecomment-2159612621 @ButterBright When you do merging, please keep the meaningful change logs rather than every commits. https://github.com/apache/skywalking-banyandb/assets/5441976/4be1284b-ffc2-4226-a49a-f545ea9bd38a;> That is why we setup squash merge. The commit logs in the main stream should be clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Check Unregistered Nodes in Background [skywalking-banyandb]
ButterBright merged PR #466: URL: https://github.com/apache/skywalking-banyandb/pull/466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Check Unregistered Nodes in Background [skywalking-banyandb]
hanahmily opened a new pull request, #466: URL: https://github.com/apache/skywalking-banyandb/pull/466 - [x] Tests(including UT, IT, E2E) are added to verify the new feature. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update marketplace.md [skywalking]
wu-sheng merged PR #12318: URL: https://github.com/apache/skywalking/pull/12318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update marketplace.md [skywalking]
wu-sheng opened a new pull request, #12318: URL: https://github.com/apache/skywalking/pull/12318 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wankai123 commented on code in PR #12316: URL: https://github.com/apache/skywalking/pull/12316#discussion_r1634009813 ## oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/rt/PromQLExprQueryVisitor.java: ## @@ -440,6 +440,32 @@ private Entity buildEntity(Layer layer, checkLabels(labelMap, LabelName.ENDPOINT); entity.setEndpointName(labelMap.get(LabelName.ENDPOINT)); break; +case ServiceRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_LAYER); + entity.setDestServiceName(labelMap.get(LabelName.DEST_SERVICE)); + entity.setDestNormal(Layer.nameOf(labelMap.get(LabelName.DEST_LAYER)).isNormal()); +break; +case ServiceInstanceRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_SERVICE_INSTANCE); +checkLabels(labelMap, LabelName.SERVICE_INSTANCE); +checkLabels(labelMap, LabelName.DEST_LAYER); + entity.setServiceInstanceName(labelMap.get(LabelName.SERVICE_INSTANCE)); + entity.setDestServiceInstanceName(labelMap.get(LabelName.DEST_SERVICE_INSTANCE)); + entity.setDestServiceName(labelMap.get(LabelName.DEST_SERVICE)); + entity.setDestNormal(Layer.nameOf(labelMap.get(LabelName.DEST_LAYER)).isNormal()); +break; +case EndpointRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_ENDPOINT); +checkLabels(labelMap, LabelName.ENDPOINT); +checkLabels(labelMap, LabelName.DEST_LAYER); Review Comment: ```suggestion checkLabels(labelMap, LabelName.DEST_SERVICE, LabelName.DEST_ENDPOINT, LabelName.ENDPOINT, LabelName.DEST_LAYER); ``` ## oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/rt/PromQLExprQueryVisitor.java: ## @@ -440,6 +440,32 @@ private Entity buildEntity(Layer layer, checkLabels(labelMap, LabelName.ENDPOINT); entity.setEndpointName(labelMap.get(LabelName.ENDPOINT)); break; +case ServiceRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_LAYER); Review Comment: ```suggestion checkLabels(labelMap, LabelName.DEST_SERVICE, LabelName.DEST_LAYER); ``` We can check the labels at the same time. ## oap-server/server-query-plugin/promql-plugin/src/main/java/org/apache/skywalking/oap/query/promql/rt/PromQLExprQueryVisitor.java: ## @@ -440,6 +440,32 @@ private Entity buildEntity(Layer layer, checkLabels(labelMap, LabelName.ENDPOINT); entity.setEndpointName(labelMap.get(LabelName.ENDPOINT)); break; +case ServiceRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_LAYER); + entity.setDestServiceName(labelMap.get(LabelName.DEST_SERVICE)); + entity.setDestNormal(Layer.nameOf(labelMap.get(LabelName.DEST_LAYER)).isNormal()); +break; +case ServiceInstanceRelation: +checkLabels(labelMap, LabelName.DEST_SERVICE); +checkLabels(labelMap, LabelName.DEST_SERVICE_INSTANCE); +checkLabels(labelMap, LabelName.SERVICE_INSTANCE); +checkLabels(labelMap, LabelName.DEST_LAYER); Review Comment: ```suggestion checkLabels(labelMap, LabelName.DEST_SERVICE, LabelName.DEST_SERVICE_INSTANCE, LabelName.SERVICE_INSTANCE, LabelName.DEST_LAYER); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Golang as a supported language for Elasticsearch [skywalking]
wu-sheng merged PR #12315: URL: https://github.com/apache/skywalking/pull/12315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add marketplace docs. [skywalking]
wu-sheng merged PR #12317: URL: https://github.com/apache/skywalking/pull/12317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add marketplace docs. [skywalking]
wu-sheng opened a new pull request, #12317: URL: https://github.com/apache/skywalking/pull/12317 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wu-sheng commented on PR #12316: URL: https://github.com/apache/skywalking/pull/12316#issuecomment-2158600050 > > We should have 3 new dashboard setups for service, instance and endpoint relationship for `general layer`. > > @wankai123 We host service, instance and endpoint dashboards, right? > > Yes, but they are all on one dashboard with different `Rows` widget. Relation could be in that case. But maybe a little confused. It is better we have three. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wankai123 commented on PR #12316: URL: https://github.com/apache/skywalking/pull/12316#issuecomment-2158590176 > We should have 3 new dashboard setups for service, instance and endpoint relationship for `general layer`. > > @wankai123 We host service, instance and endpoint dashboards, right? Yes, but they are all on one dashboard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wu-sheng commented on PR #12316: URL: https://github.com/apache/skywalking/pull/12316#issuecomment-2158570791 We should have 3 new dashboard setups for service, instance and endpoint relationship for `general layer`. @wankai123 We host service, instance and endpoint dashboards, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for go-elasticsearch [skywalking-go]
mrproliu commented on code in PR #186:
URL: https://github.com/apache/skywalking-go/pull/186#discussion_r1633370629
##
CHANGES.md:
##
@@ -12,9 +12,7 @@ Release Notes.
* Support [Segmentio-Kafka](https://github.com/segmentio/kafka-go) MQ.
* Support http headers collection for Gin
* Support higher versions of grpc.
-
- Chore
Review Comment:
Why remove this Chore selection?
##
plugins/go-elasticsearchv8/intercepter.go:
##
@@ -0,0 +1,72 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package goelasticsearchv8
+
+import (
+ "fmt"
+ "net/http"
+ "strings"
+
+ "github.com/apache/skywalking-go/plugins/core/operator"
+ "github.com/apache/skywalking-go/plugins/core/tracing"
+
+ "github.com/elastic/elastic-transport-go/v8/elastictransport"
+ "github.com/elastic/go-elasticsearch/v8"
+)
+
+type ESV8Interceptor struct {
+}
+
+func (es *ESV8Interceptor) BeforeInvoke(invocation operator.Invocation) error {
+ client := invocation.CallerInstance().(*elasticsearch.BaseClient)
+ var addresses []string
+ for _, u := range client.Transport.(*elastictransport.Client).URLs() {
+ addresses = append(addresses, u.String())
+ }
+ url := strings.Join(addresses, ",")
+ req := invocation.Args()[0].(*http.Request)
+ span, err := tracing.CreateExitSpan("Elasticsearch/"+req.Method, url,
func(headerKey, headerValue string) error {
+ req.Header.Add(headerKey, headerValue)
Review Comment:
I think we haven't ability to monitoring the elastic-search or open-search,
so the header it's not necessary.
##
plugins/go-elasticsearchv8/intercepter.go:
##
@@ -0,0 +1,72 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package goelasticsearchv8
+
+import (
+ "fmt"
+ "net/http"
+ "strings"
+
+ "github.com/apache/skywalking-go/plugins/core/operator"
+ "github.com/apache/skywalking-go/plugins/core/tracing"
+
+ "github.com/elastic/elastic-transport-go/v8/elastictransport"
+ "github.com/elastic/go-elasticsearch/v8"
+)
+
+type ESV8Interceptor struct {
+}
+
+func (es *ESV8Interceptor) BeforeInvoke(invocation operator.Invocation) error {
+ client := invocation.CallerInstance().(*elasticsearch.BaseClient)
Review Comment:
Is possible we can move the address parsing to the constructor the client?
##
test/plugins/scenarios/go-elasticsearchv8/config/excepted.yml:
##
@@ -0,0 +1,99 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+segmentItems:
+ - serviceName: go-elasticsearchv8
+segmentSize: ge 1
+
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
wu-sheng commented on code in PR #12316: URL: https://github.com/apache/skywalking/pull/12316#discussion_r1633382519 ## docs/en/api/promql-service.md: ## @@ -389,20 +389,23 @@ Not all scopes are supported for now, please check the following table: | Service | yes | | ServiceInstance | yes | | Endpoint| yes | -| ServiceRelation | no | -| ServiceInstanceRelation | no | +| ServiceRelation | yes | +| ServiceInstanceRelation | yes | Review Comment: We have EndpointRelation too, I think the doc missed that before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
yswdqz commented on PR #12316: URL: https://github.com/apache/skywalking/pull/12316#issuecomment-2158564234  I have wrote a unit test, and I tested service_relation part on local grafana dashboard. It seems work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [Feature] Support to query relation metrics through PromQL. [skywalking]
yswdqz opened a new pull request, #12316: URL: https://github.com/apache/skywalking/pull/12316 - [ ] If this is non-trivial feature, paste the links/URLs to the design doc. - [x] Update the documentation to include this new feature. - [x] Tests(including UT, IT, E2E) are added to verify the new feature. - [ ] If it's UI related, attach the screenshots below. Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist --> - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #12245. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add Golang as a supported language for Elasticsearch [skywalking]
CodePrometheus opened a new pull request, #12315: URL: https://github.com/apache/skywalking/pull/12315 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add support for go-elasticsearch [skywalking-go]
CodePrometheus opened a new pull request, #186: URL: https://github.com/apache/skywalking-go/pull/186 ### Summary [go-elasticsearch](https://github.com/elastic/go-elasticsearch) is the official Go client for Elasticsearch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [BanyanDB] Metrics breaks periodically [skywalking]
wu-sheng commented on issue #12312: URL: https://github.com/apache/skywalking/issues/12312#issuecomment-2156906979 @wankai123 Let us bump up otel collectoe first. This seems irrelevant with DB. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [BanyanDB] Metrics breaks periodically [skywalking]
hanahmily commented on issue #12312: URL: https://github.com/apache/skywalking/issues/12312#issuecomment-2156792504 I checked the client, and it seems that the error cannot be from the BanyanDB client. https://github.com/apache/skywalking/assets/1960537/783c4ab5-30e7-4ce8-a9d5-2f5339cbbddd;> The error is related to the 'getCompressedBody' function, but the client should always use the 'getUncompressedBody' instead. BTW, `maxInboundMessageSize` is 50MB even though the client doesn't use it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [BanyanDB] Metrics breaks periodically [skywalking]
wu-sheng commented on issue #12312: URL: https://github.com/apache/skywalking/issues/12312#issuecomment-2156687589 I didn't check that deeply. But it seems existing in the default constructor. Doesn't it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [BanyanDB] Metrics breaks periodically [skywalking]
Superskyyy commented on issue #12312: URL: https://github.com/apache/skywalking/issues/12312#issuecomment-2156674300 Seems like a client side problem, the 50MB didn't take effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] [BanyanDB] Metrics breaks periodically [skywalking]
wu-sheng opened a new issue, #12312: URL: https://github.com/apache/skywalking/issues/12312 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component BanyanDB (apache/skywalking-banyandb) ### What happened Since we switched demo database to BanyanDB, most things work well, but I noticed this kind of metric breaking. https://github.com/apache/skywalking/assets/5441976/3c144b33-6cf7-4afa-ae56-eb470604ff54;> Meanwhile, this only happens on minute level, https://github.com/apache/skywalking/assets/5441976/b32ebab5-0fbf-44c7-93a9-54b8c2500de1;> All services/pods of demo env seem normal  But we noticed this error happens periodically too in the OAP pod logs. https://github.com/apache/skywalking/assets/5441976/e0a9bcfa-fea7-452d-8e9d-c9d638470dcb;> I also checked the BanyanDB client codes, although we don't expose the configuration to BanyanDB provider(@lujiajing1126 we should expose), but the default value is 50m. But this error log says, ~5m. So, @hanahmily @lujiajing1126 @ButterBright Is the server missing the configurations? And could you check whether there is other reason to make metrics breaking. ### What you expected to happen Make metrics continuously flush into the storage. ### How to reproduce I didn't reproduce this, but observe this on demo env. ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Fix next SWIP ID (#12217)" [skywalking]
wu-sheng closed pull request #12311: Revert "Fix next SWIP ID (#12217)" URL: https://github.com/apache/skywalking/pull/12311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Fix next SWIP ID (#12217)" [skywalking]
CodePrometheus commented on PR #12311: URL: https://github.com/apache/skywalking/pull/12311#issuecomment-2156389456 @ffaa3dd The latest SWIP ID is 8, why revert it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Revert "Fix next SWIP ID (#12217)" [skywalking]
ffaa3dd opened a new pull request, #12311: URL: https://github.com/apache/skywalking/pull/12311 This reverts commit 7f20b99b4f7574bc5f2ed9c13a5e52f1995f6e07. - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix errors when compiling C source files into eBPF bytecode. [skywalking-rover]
wu-sheng merged PR #129: URL: https://github.com/apache/skywalking-rover/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix errors when compiling C source files into eBPF bytecode. [skywalking-rover]
weixiang1862 opened a new pull request, #129:
URL: https://github.com/apache/skywalking-rover/pull/129
When I execute `make generate` on my system with Linux headers version 6.2
or higher, I got the following error:
```
skywalking-rover/bpf/include/list.h:65:8: error: redefinition of
'bpf_list_head'
65 | struct bpf_list_head {
|^
/usr/include/linux/bpf.h:7136:8: note: previous definition is here
7136 | struct bpf_list_head {
|^
```
I followed @mrproliu advice to add a prefix for bpf_list_head struct, it
generate go file successfuly, I tested it in my local, it works well, Thanks
for your help @mrproliu .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] [SkyWalking UI] Introduce Fame Graph to the Trace Profiling [skywalking]
mrproliu opened a new issue, #12309: URL: https://github.com/apache/skywalking/issues/12309 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description Currently, SkyWalking's Trace Profiling feature allows users to understand where the performance bottlenecks of the current program are. However, sometimes using a tree structure to display stacks is not very intuitive, so I recommend that we introduce flame graphs for this purpose(as a new tab). Additionally, On/CPU Profiling based on eBPF has already proven this point well; using flame graphs can also effectively help users understand the call process. ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [GsoC][BanyanDB] Self-Observability: Create Measure Schema [skywalking-banyandb]
wu-sheng merged PR #462: URL: https://github.com/apache/skywalking-banyandb/pull/462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Return the tagValue of sorted tag [skywalking-banyandb]
wu-sheng commented on PR #465: URL: https://github.com/apache/skywalking-banyandb/pull/465#issuecomment-2153774902 BTW @hanahmily @ButterBright As we are adding more features into server side, and we plan to keep the compatibility as much as possible with OAP, we should run a matrix e2e testing. OAP should be set for a version matrix. Such as in this case, we should support the version is 10.0.1 and latest(not latest commit, just another commit ID with `latest`name). Then we will know the version compatible list for the latest BanyanDB server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Return the tagValue of sorted tag [skywalking-banyandb]
hanahmily commented on code in PR #465:
URL:
https://github.com/apache/skywalking-banyandb/pull/465#discussion_r1630561824
##
api/proto/banyandb/database/v1/schema.proto:
##
@@ -156,8 +156,10 @@ message IndexRule {
}
// type is the IndexType of this IndexObject.
Type type = 3 [(validate.rules).enum.defined_only = true];
+ // sorted indicates whether the index is for sorting.
+ bool sorted = 4;
Review Comment:
Please set the default value to 'true' for compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Return the tagValue of sorted tag [skywalking-banyandb]
ButterBright commented on PR #465: URL: https://github.com/apache/skywalking-banyandb/pull/465#issuecomment-2153752202 When performing stream sorting, the tagValue will be used for merge sort, ensuring that not too many elements are read out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the filtering of stream in descending order by timestamp [skywalking-banyandb]
hanahmily merged PR #464: URL: https://github.com/apache/skywalking-banyandb/pull/464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Return the tagValue of sorted tag [skywalking-banyandb]
wu-sheng commented on PR #465: URL: https://github.com/apache/skywalking-banyandb/pull/465#issuecomment-2153746358 Which scenario and how would the client uses this new return time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Return the tagValue of sorted tag [skywalking-banyandb]
wu-sheng commented on code in PR #465:
URL:
https://github.com/apache/skywalking-banyandb/pull/465#discussion_r1630554730
##
api/proto/banyandb/database/v1/schema.proto:
##
@@ -156,8 +156,10 @@ message IndexRule {
}
// type is the IndexType of this IndexObject.
Type type = 3 [(validate.rules).enum.defined_only = true];
+ // sorted indicates whether the index is for sorting.
+ bool sorted = 4;
Review Comment:
You should move `sorted` to 7, and accept the value absent with a default
value, which could keep the compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] [Feature] Support ARM64 build binary and images [skywalking]
wu-sheng opened a new issue, #12308: URL: https://github.com/apache/skywalking/issues/12308 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description _No response_ ### Use case We should deliver binary build and run on ARM64 and AARM(Applice Sillicon) to help the ARM server and Apple developer. ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the filtering of stream in descending order by timestamp [skywalking-banyandb]
ButterBright commented on PR #464: URL: https://github.com/apache/skywalking-banyandb/pull/464#issuecomment-2153696399 When sorting in descending order by timestamp, the previous method always filtered out the elements with the smallest timestamps, rather than the largest ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add CN online session s01e06 [skywalking-website]
wu-sheng merged PR #719: URL: https://github.com/apache/skywalking-website/pull/719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the filtering of stream in descending order by timestamp [skywalking-banyandb]
Superskyyy commented on PR #464: URL: https://github.com/apache/skywalking-banyandb/pull/464#issuecomment-2153623633 類 By incorrect you mean how incorrect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add CN online session s01e06 [skywalking-website]
netlify[bot] commented on PR #719: URL: https://github.com/apache/skywalking-website/pull/719#issuecomment-2153620794 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | adc102031a7ff8196fb0ce96c2636c71897d796c | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/666251a1093f6e00084e3e5f | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add CN online session s01e06 [skywalking-website]
mrproliu opened a new pull request, #719: URL: https://github.com/apache/skywalking-website/pull/719 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Return the tagValue of sorted tag [skywalking-banyandb]
wu-sheng commented on code in PR #465:
URL:
https://github.com/apache/skywalking-banyandb/pull/465#discussion_r1629828301
##
api/proto/banyandb/database/v1/schema.proto:
##
@@ -156,8 +156,10 @@ message IndexRule {
}
// type is the IndexType of this IndexObject.
Type type = 3 [(validate.rules).enum.defined_only = true];
+ // sorted indicates whether the index is for sorting.
+ bool sorted = 4;
Review Comment:
Adding the flag(4) would make incompatible change.
The good practice should be the largest index for a new field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Return the tagValue of sorted tag [skywalking-banyandb]
ButterBright opened a new pull request, #465: URL: https://github.com/apache/skywalking-banyandb/pull/465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the filtering of stream in descending order by timestamp [skywalking-banyandb]
codecov-commenter commented on PR #464: URL: https://github.com/apache/skywalking-banyandb/pull/464#issuecomment-2152262940 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/464?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `26.7%` with `11 lines` in your changes missing coverage. Please review. > Project coverage is 51.61%. Comparing base [(`18a138f`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/18a138f959162282b8eb0c0f6635a6085f9207e2?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`b8281a3`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/b8281a34063a413e7f192fa4d9b5c67629907c2d?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 3 commits behind head on main. | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/464?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [banyand/stream/index.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/464?src=pr=tree=banyand%2Fstream%2Findex.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vaW5kZXguZ28=) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/464?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/stream/query.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/464?src=pr=tree=banyand%2Fstream%2Fquery.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vcXVlcnkuZ28=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/464?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [pkg/timestamp/range.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/464?src=pr=tree=pkg%2Ftimestamp%2Frange.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL3RpbWVzdGFtcC9yYW5nZS5nbw==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/464?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #464 +/- ## === + Coverage 40.53% 51.61% +11.08% === Files 156 156 Lines 1890918915+6 === + Hits 7664 9763 +2099 + Misses 10613 8346 -2267 - Partials 632 806 +174 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/464?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [GsoC][BanyanDB] Self-Observability: Create Measure Schema [skywalking-banyandb]
hanahmily commented on code in PR #462:
URL:
https://github.com/apache/skywalking-banyandb/pull/462#discussion_r1629348957
##
pkg/meter/native/instruments.go:
##
@@ -0,0 +1,27 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+// Package native provides a simple meter system for metrics. The metrics are
aggregated by the meter provider.
+package native
+
+type noopInstrument struct{}
Review Comment:
```suggestion
type nativeInstrument struct{}
```
##
banyand/observability/service.go:
##
@@ -109,7 +110,7 @@ func (p *metricService) PreRun(ctx context.Context) error {
if err != nil {
p.l.Warn().Err(err).Msg("Failed to create
native observability group")
}
- providers = append(providers,
newNativeMeterProvider(SystemScope))
+ providers = append(providers,
newNativeMeterProvider(SystemScope, p.metadata))
Review Comment:
You don't need to pass a global variable like SystemScope through a
parameter; it can be referred to anywhere.
##
pkg/meter/native/provider.go:
##
@@ -0,0 +1,124 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+// Package native provides a simple meter system for metrics. The metrics are
aggregated by the meter provider.
+package native
+
+import (
+ "context"
+
+ commonv1
"github.com/apache/skywalking-banyandb/api/proto/banyandb/common/v1"
+ databasev1
"github.com/apache/skywalking-banyandb/api/proto/banyandb/database/v1"
+ "github.com/apache/skywalking-banyandb/banyand/metadata"
+ "github.com/apache/skywalking-banyandb/pkg/logger"
+ "github.com/apache/skywalking-banyandb/pkg/meter"
+)
+
+const (
+ // NativeObservabilityGroupName is the native observability group name.
+ NativeObservabilityGroupName = "_monitoring"
+ defaultTagFamily = "default"
+ defaultFieldName = "value"
+ nodeNameTag = "node_name"
+)
+
+var log = logger.GetLogger("observability", "metrics", "system")
+
+type provider struct {
+ metadata metadata.Repo
+ scopemeter.Scope
+}
+
+// NewProvider returns a native metrics Provider.
+func NewProvider(scope meter.Scope, metadata metadata.Repo) meter.Provider {
+ return {
+ scope:scope,
+ metadata: metadata,
+ }
+}
+
+// Counter returns a no-op implementation of the Counter interface.
+func (p *provider) Counter(name string, labelNames ...string) meter.Counter {
+ err := p.createMeasure(name, labelNames...)
+ if err != nil {
+ log.Error().Err(err).Msgf("Failure to createMeasure for Counter
%s, labels: %v", name, labelNames)
+ }
+ return noopInstrument{}
+}
+
+// Gauge returns a no-op implementation of the Gauge interface.
+func (p *provider) Gauge(name string, labelNames ...string) meter.Gauge {
+ err := p.createMeasure(name, labelNames...)
+ if err != nil {
+ log.Error().Err(err).Msgf("Failure to createMeasure for Gauge
%s, labels: %v", name, labelNames)
+ }
+ return noopInstrument{}
+}
+
+// Histogram returns a no-op implementation of the Histogram interface.
+func (p *provider) Histogram(_ string, _ meter.Buckets, _ ...string)
meter.Histogram {
+ return noopInstrument{}
+}
+
Re: [I] [BanyanDB-UI] Missing Criteria Part in Measure Query [skywalking]
hanahmily closed issue #12301: [BanyanDB-UI] Missing Criteria Part in Measure Query URL: https://github.com/apache/skywalking/issues/12301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [UI] Fix yaml code mirror to http read request [skywalking-banyandb]
hanahmily merged PR #463: URL: https://github.com/apache/skywalking-banyandb/pull/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the filtering of stream in descending order by timestamp [skywalking-banyandb]
hanahmily commented on code in PR #464: URL: https://github.com/apache/skywalking-banyandb/pull/464#discussion_r1629335977 ## CHANGES.md: ## @@ -19,6 +19,7 @@ Release Notes. - Fix duplicated items in the query aggregation top-n list. - Fix non-"value" field in topN pre-calculation result measure is lack of data. - Encode escaped characters to int64 bytes to fix the malformed data. +- Fix the filtering of stream in descending order by timestamp. Review Comment: Move it to 0.7.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the opentracing toolkit SPI config [skywalking-java]
wu-sheng merged PR #696: URL: https://github.com/apache/skywalking-java/pull/696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [GsoC][BanyanDB] Self-Observability: Create Measure Schema [skywalking-banyandb]
codecov-commenter commented on PR #462: URL: https://github.com/apache/skywalking-banyandb/pull/462#issuecomment-2151567375 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/462?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 51.65%. Comparing base [(`18a138f`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/18a138f959162282b8eb0c0f6635a6085f9207e2?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`622da33`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/622da336221393d2b3bc7672f72c7ff24e49e9e0?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 2 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #462 +/- ## === + Coverage 40.53% 51.65% +11.12% === Files 156 156 Lines 1890918898 -11 === + Hits 7664 9761 +2097 + Misses 10613 8332 -2281 - Partials 632 805 +173 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/462?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the filtering of stream in descending order by timestamp [skywalking-banyandb]
ButterBright commented on PR #464: URL: https://github.com/apache/skywalking-banyandb/pull/464#issuecomment-2151560936 Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the filtering of stream in descending order by timestamp [skywalking-banyandb]
wu-sheng commented on PR #464: URL: https://github.com/apache/skywalking-banyandb/pull/464#issuecomment-2151559741 Could you describe what is the effect of this bug? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix the filtering of stream in descending order by timestamp [skywalking-banyandb]
ButterBright opened a new pull request, #464: URL: https://github.com/apache/skywalking-banyandb/pull/464 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#. - [] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix the opentracing toolkit SPI config [skywalking-java]
xiaqi1210 opened a new pull request, #696: URL: https://github.com/apache/skywalking-java/pull/696 ### Fix - [ ] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. 1. The directory for SPI should be `/META-INF/services`, not `/META-INF.services`. 2. There is an issue with the letter casing in the class name. It should be `SkywalkingTracer`, not `SkyWalkingTracer`. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump Backend and Rover for Access Log Service [skywalking-showcase]
mrproliu merged PR #173: URL: https://github.com/apache/skywalking-showcase/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump Backend and Rover for Access Log Service [skywalking-showcase]
mrproliu opened a new pull request, #173: URL: https://github.com/apache/skywalking-showcase/pull/173 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [UI] Fix yaml code mirror to http read request [skywalking-banyandb]
codecov-commenter commented on PR #463: URL: https://github.com/apache/skywalking-banyandb/pull/463#issuecomment-2151485929 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/463?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 51.59%. Comparing base [(`18a138f`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/18a138f959162282b8eb0c0f6635a6085f9207e2?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`86e4f5d`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/86e4f5d017a22e8ea0a4203225c72c8e7f851e3f?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 2 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #463 +/- ## === + Coverage 40.53% 51.59% +11.06% === Files 156 156 Lines 1890918909 === + Hits 7664 9756 +2092 + Misses 10613 8345 -2268 - Partials 632 808 +176 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/463?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [UI] Fix yaml code mirror to http read request [skywalking-banyandb]
Sylvie-Wxr opened a new pull request, #463: URL: https://github.com/apache/skywalking-banyandb/pull/463 ### Fix - [ ] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#12301 - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). https://github.com/apache/skywalking-banyandb/assets/129717259/33620747-e701-4d9d-a9c0-3b2689c8ac4b;> ### Fix detail Carry over all non-fixed fields from yamlJson to params. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adding eBPF Access Log Feature E2E and support exclude specific namespaces traffic [skywalking]
wu-sheng merged PR #12304: URL: https://github.com/apache/skywalking/pull/12304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Adding eBPF Access Log Feature E2E and support exclude specific namespaces traffic [skywalking]
mrproliu opened a new pull request, #12304: URL: https://github.com/apache/skywalking/pull/12304 1. Support excluding specific namespace traffic in the eBPF Access Log Receiver. 2. Adding eBPF Access Log E2E Test between ES and BanyanDB. - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Self observability/create measure schema [skywalking-banyandb]
Sylvie-Wxr opened a new pull request, #462: URL: https://github.com/apache/skywalking-banyandb/pull/462 ### - [ ] If this is non-trivial feature, paste the links/URLs to the design doc. - [ ] Update the documentation to include this new feature. - [ ] Tests(including UT, IT, E2E) are added to verify the new feature. - [x] If it's UI related, attach the screenshots below. - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#10634. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). Create measures for metrics in when running in native observability mode  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support propagation the excluding namespaces in the access log feature to the backend. [skywalking-rover]
wu-sheng merged PR #128: URL: https://github.com/apache/skywalking-rover/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Support excluding namespaces in the access log propagation feature to the backend [skywalking-rover]
mrproliu opened a new pull request, #128: URL: https://github.com/apache/skywalking-rover/pull/128 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [BanyanDB] Data Mismatch with OAL Metrics Using BanyanDB [skywalking]
wu-sheng commented on issue #12302: URL: https://github.com/apache/skywalking/issues/12302#issuecomment-2151214657 With today's discussion, we determine that we will introduce a new column for this version. And version column value would be assigned by the liaison node with a nanosecond precision timestamp. This means all nodes of BanyanDB should deploy on VM or K8s nodes with NTP, Chrony, or `Amazon Time Sync Service` enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [BanyanDB] Data Mismatch with OAL Metrics Using BanyanDB [skywalking]
wu-sheng commented on issue #12302: URL: https://github.com/apache/skywalking/issues/12302#issuecomment-2149480572 This should be caused by as same as https://github.com/apache/skywalking/issues/12255. The version number of row is not consistent increasing with new data. The merging logic is the root cause, AFAIK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [BanyanDB] Data Mismatch with OAL Metrics Using BanyanDB [skywalking]
mrproliu opened a new issue, #12302: URL: https://github.com/apache/skywalking/issues/12302 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component BanyanDB (apache/skywalking-banyandb) ### What happened I am currently using BanyanDB as the storage backend for my metrics. When writing metrics data using OAL, I have encountered a data mismatch issue. Here are the two OAL statements: ``` kubernetes_service_http_call_cpm = from(K8SService.*).filter(detectPoint == DetectPoint.SERVER).filter(type == "protocol").filter(protocol.type == "http").cpm(); kubernetes_service_http_call_success_count = from(K8SService.*).filter(detectPoint == DetectPoint.SERVER).filter(type == "protocol").filter(protocol.type == "http").filter(protocol.success == true).cpm(); ``` Logically, `kubernetes_service_http_call_cpm` should be greater than or equal to `kubernetes_service_http_call_success_count`. However, after running BanyanDB for some time, I noticed that sometimes `call_success_count` exceeds `call_cpm`. ### Call CPM Query with Result ``` groups: - "measure-minute" name: kubernetes_service_http_call_cpm_minute timeRange: begin: '2024-06-05T06:30:00.000Z' end: '2024-06-05T09:30:00.000Z' offset: 1 limit: 200 criteria: condition: name: entity_id op: BINARY_OP_EQ value: str: value: c2t5d2Fsa2luZy1zaG93Y2FzZTo6Z2F0ZXdheS5zYW1wbGUtc2VydmljZXM=.1 orderBy: indexRuleName: '' sort: SORT_UNSPECIFIED tagProjection: tagFamilies: - name: "storage-only" tags: - "entity_id" fieldProjection: names: - "value" ``` [query-cpm-result.txt](https://github.com/user-attachments/files/15584944/query-cpm-result.txt) ### Success Count Query with Result ```yaml groups: - "measure-minute" name: kubernetes_service_http_call_success_count_minute timeRange: begin: '2024-06-05T06:30:00.000Z' end: '2024-06-05T09:30:00.000Z' offset: 1 limit: 200 criteria: condition: name: entity_id op: BINARY_OP_EQ value: str: value: c2t5d2Fsa2luZy1zaG93Y2FzZTo6Z2F0ZXdheS5zYW1wbGUtc2VydmljZXM=.1 orderBy: indexRuleName: '' sort: SORT_UNSPECIFIED tagProjection: tagFamilies: - name: "storage-only" tags: - "entity_id" fieldProjection: names: - "value" ``` [query-success-rsult.txt](https://github.com/user-attachments/files/15584948/query-success-rsult.txt) ### What you expected to happen `kubernetes_service_http_call_cpm` should always be greater than or equal to `kubernetes_service_http_call_success_count`. ### How to reproduce 1. Deploy the showcase as the following command: `FEATURE_FLAGS = banyandb,mesh-with-agent,cluster,kubernetes-monitor,satellite,rover make deploy.kubernetes` 2. Forward the UI: `kubectl port-forward svc/demo-ui 8080:80 --namespace skywalking-showcase` 3. Visit the Kubernetes Service Topology, and see the each node `success rate`: `http://localhost:8080/Kubernetes/Service/tab/1` ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [BanyanDB-UI] Missing Criteria Part in Measure Query [skywalking]
hanahmily opened a new issue, #12301:
URL: https://github.com/apache/skywalking/issues/12301
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
BanyanDB (apache/skywalking-banyandb)
### What happened
The measure read page failed to send "criteria" to the server.
### What you expected to happen
The "criteria" should be passed to the server.
### How to reproduce
The input yaml is
```yaml
timeRange:
begin: '2024-06-05T08:02:22.643Z'
end: '2024-06-05T08:17:22.643Z'
offset: 1
limit: 10
criteria:
condition:
name: entity_id
op: BINARY_OP_EQ
value:
str:
value: c2t5d2Fsa2luZy1zaG93Y2FzZTo6Z2F0ZXdheS5zYW1wbGUtc2VydmljZXM=.1
orderBy:
indexRuleName: ''
sort: SORT_UNSPECIFIED
```
But the HTTP request is
```json
{"groups":["measure-minute"],"name":"kubernetes_service_http_call_success_count_minute","offset":1,"limit":10,"orderBy":{"indexRuleName":"","sort":"SORT_UNSPECIFIED"},"timeRange":{"begin":"2024-06-05T08:06:01.812Z","end":"2024-06-05T08:21:01.812Z"},"tagProjection":{"tagFamilies":[{"name":"storage-only","tags":["entity_id"]}]},"fieldProjection":{"names":["value"]}}
```
### Anything else
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix wrong indices in the eBPF Profiling related models [skywalking]
wu-sheng merged PR #12297: URL: https://github.com/apache/skywalking/pull/12297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] the thrift plugin in javaagent doesn't handle exceptions. [skywalking]
wu-sheng closed issue #12299: [Bug] the thrift plugin in javaagent doesn't handle exceptions. URL: https://github.com/apache/skywalking/issues/12299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] the thrift plugin in javaagent doesn't handle exceptions. [skywalking]
h0cheung opened a new issue, #12299: URL: https://github.com/apache/skywalking/issues/12299 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened The thrift plugin can't handle exceptions. [The `ProcessFunction` has caught all exceptions except `TTransportException` for many years.](https://github.com/apache/thrift/commit/026c9d032c4a298ecb9edbcdfb52590facb442f3) So the plugin, which enhances `TBaseProcessor` cannot catch the exceptions. Then thrift server spans will never have errors unless a transport exception happens. On the client side, the plugin works well. The thrift client spans will have errors when an exception happens. ### What you expected to happen If an exception happens, both server and client should have errors. ### How to reproduce Run a thrift server, which throw an custom Exception that will be returned to thrift client. Then send requests to this server. ### Anything else [For gRPC, the status code in response will be used to find errors.](https://github.com/apache/skywalking-java/blob/313d7d5c8e171df0a24b273c4949738133586922/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/server/TracingServerCall.java) Maybe we should try to handle the response sent by thrift server. ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix wrong indices in the eBPF Profiling related models [skywalking]
wu-sheng commented on code in PR #12297:
URL: https://github.com/apache/skywalking/pull/12297#discussion_r1626997154
##
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/ProcessTopologyBuilder.java:
##
@@ -69,6 +69,8 @@ public ProcessTopologyBuilder(ModuleManager moduleManager,
StorageModels storage
ProcessTopology build(List clientCalls,
List serverCalls) throws Exception {
+log.info("building process topology, total found client calls: {},
total found server calls: {}",
Review Comment:
```suggestion
log.debug("building process topology, total found client calls: {},
total found server calls: {}",
```
I think this should be `debug`, rather than `infor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix wrong indices in the eBPF Profiling related models [skywalking]
wu-sheng commented on code in PR #12297:
URL: https://github.com/apache/skywalking/pull/12297#discussion_r1626995591
##
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/ProcessTopologyBuilder.java:
##
@@ -121,6 +126,7 @@ ProcessTopology build(List clientCalls,
ProcessTopology topology = new ProcessTopology();
topology.getCalls().addAll(calls);
topology.getNodes().addAll(nodes.values());
+log.info("process topology built, total calls: {}, total nodes: {}",
appendCallCount, nodes.size());
Review Comment:
```suggestion
log.debug("process topology built, total calls: {}, total nodes:
{}", appendCallCount, nodes.size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Fix wrong indexes in the eBPF Profiling related models [skywalking]
mrproliu opened a new pull request, #12297: URL: https://github.com/apache/skywalking/pull/12297 When using BanyanDB to query eBPF CPU Profiling, there can be slow queries and timeouts. This PR fixes the incorrect index in the model. - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Helm] Modernize Labels [skywalking]
hanahmily opened a new issue, #12296: URL: https://github.com/apache/skywalking/issues/12296 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description SkyWalking and BanyanDB Helm Chart adhere to a legacy label style from Helm 2. We should update them by referencing https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/. ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [BanyanDB-Test] Add More E2E Cases [skywalking]
hanahmily opened a new issue, #12295: URL: https://github.com/apache/skywalking/issues/12295 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description We suffered several severe bugs while onboarding BanyanDB to the showcase environment. Most of them are due to the lack of appropriate E2E cases. I propose several cases here: * Instance level Top-N list: * more than 0 * no duplicated items * Endpoint level Top-N list: * more than 0 * no duplicated items * Instance list: * more than 0 * no duplicated items * Endpoint list: * more than 0 * no duplicated items ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [GsoC][BanyanDB] Self Observability: Fix Metrics Creation [skywalking-banyandb]
hanahmily merged PR #460: URL: https://github.com/apache/skywalking-banyandb/pull/460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Incorrect Deployment Controls for StatefulSet Pods [skywalking-banyandb-helm]
wu-sheng merged PR #18: URL: https://github.com/apache/skywalking-banyandb-helm/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove redundant "name" and "role" [skywalking-banyandb-helm]
hanahmily opened a new pull request, #18: URL: https://github.com/apache/skywalking-banyandb-helm/pull/18 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Publish blog banyandb v0.6 release [skywalking-website]
netlify[bot] commented on PR #718: URL: https://github.com/apache/skywalking-website/pull/718#issuecomment-2148514361 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | 466dcf2e318e56e3cb85ecfa3cd05ab08eeed2bd | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/665f9515030a2f00094858aa | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Publish blog banyandb v0.6 release [skywalking-website]
hanahmily merged PR #718: URL: https://github.com/apache/skywalking-website/pull/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Publish blog banyandb v0.6 release [skywalking-website]
hanahmily opened a new pull request, #718: URL: https://github.com/apache/skywalking-website/pull/718 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update data collect protocol for eBPF Access Log Protocol [skywalking-goapi]
mrproliu merged PR #79: URL: https://github.com/apache/skywalking-goapi/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
