[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub 


kezhenxu94 commented on PR #127:
URL: 
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649552633

   > @innerpeacez 
   > 
   > I'm ok with this. But I'm concerned that using `zk` instead of `zipkin` 
might be confusing. Using 'index' would ensure the readability of these ports.
   
   We can use zipkinreceiver or zipkinquery?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub 


kezhenxu94 commented on PR #127:
URL: 
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649551697

   I vote for not to use `index` function, using `.` is also friendly for 
completion in IDEs。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI

2023-07-25 Thread via GitHub 


kezhenxu94 commented on PR #127:
URL: 
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649213683

   > values.yaml
   > 
   > ```
   > oap:
   >   ports:
   > # add more ports here if you need, for example
   > # zabbix: 10051
   > grpc: 11800
   > rest: 12800
   > # zipkinReceiver: 9411
   > # zipkinQuery: 9412
   > ```
   > 
   > oap-deployment.yaml
   > 
   > ```
   > env:
   > {{- if .Values.oap.ports.zipkinReceiver }}
   > - name: SW_RECEIVER_ZIPKIN
   >   value: "default"
   > {{- end }}
   > {{- if .Values.oap.ports.zipkinQuery }}
   > - name: SW_QUERY_ZIPKIN
   >   value: "default"
   > {{- end }}
   > ```
   > 
   > ui-deployment.yaml
   > 
   > ```
   > env:
   > {{- if .Values.oap.ports.zipkinQuery }}
   > - name: SW_ZIPKIN_ADDRESS
   >   value: "http://{{ template "skywalking.oap.fullname" . }}:{{ 
.Values.oap.ports.zipkinQuery }}"
   > {{- end }}
   > ```
   > 
   > I think it might be more convenient. What do you think? @kezhenxu94 
@Yangfisher1
   
   This works for me too, another good point is that we can also set 
`SW_QUERY_ZIPKIN_REST_PORT` to `.Values.ports.zipkinQuery`, @Yangfisher1 in 
that case users can set Zipin port to arbitrary port, I think


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI

2023-07-24 Thread via GitHub 


kezhenxu94 commented on PR #127:
URL: 
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649133355

   > @kezhenxu94
   > 
   > It works well now. But I think directly hardcoding the port number(like 
`9141` and `9142`) in the file is not very graceful.
   
   I agree, but I don't thin we have a more graceful way to do this, do you 
have any better idea, I'm open to discuss?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #127: Adding support for zipkin UI

2023-07-24 Thread via GitHub 


kezhenxu94 commented on PR #127:
URL: 
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1647872152

   > However, there's one side effect for this env var to be set without 
setting the port. The UI pod will throw an error complaining about the missing 
port when initializing. I think we should use the env var `SW_QUERY_ZIPKIN` to 
control whether the `SW_ZIPKIN_ADDRESS` is set or not. Is it a good idea?
   
   Right I missed that, that's better!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org