[GitHub] [superset] tvorogme commented on issue #15291: Dashboard Native Filter: cannot filter null values
tvorogme commented on issue #15291: URL: https://github.com/apache/superset/issues/15291#issuecomment-869120277 Hi! I see @mironovmeow created pull request with fixing this issue. @zhaoyongjie @junlincc will you review it? Or we wait for realization from superset team? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] syazwan0913 opened a new issue #15406: Gunicorn gevent worker keep timeout
syazwan0913 opened a new issue #15406:
URL: https://github.com/apache/superset/issues/15406
A clear and concise description of what the bug is.
### Expected results
Gunicorn worker shouldn't be timeout since timeout is 10mins (600s)
### Actual results
Gunicorn worker keep timeout
Screenshots
Configuration
```
gunicorn \
--bind "0.0.0.0:${SUPERSET_PORT}" \
--access-logfile '-' \
--error-logfile '-' \
--workers 17 \
--keep-alive 60 \
--worker-class gevent\
--timeout 600 \
--limit-request-line 0 \
--limit-request-field_size 0 \
"${FLASK_APP}"
```
error.log stacktrace
```
[2021-06-27 06:00:17 +0800] [7] [INFO] Starting gunicorn 20.0.4
[2021-06-27 06:00:17 +0800] [7] [INFO] Listening at: http://0.0.0.0:8088 (7)
[2021-06-27 06:00:17 +0800] [7] [INFO] Using worker: gevent
[2021-06-27 06:00:17 +0800] [10] [INFO] Booting worker with pid: 10
[2021-06-27 06:00:17 +0800] [11] [INFO] Booting worker with pid: 11
[2021-06-27 06:00:17 +0800] [12] [INFO] Booting worker with pid: 12
[2021-06-27 06:00:18 +0800] [13] [INFO] Booting worker with pid: 13
[2021-06-27 06:00:18 +0800] [14] [INFO] Booting worker with pid: 14
[2021-06-27 06:00:18 +0800] [15] [INFO] Booting worker with pid: 15
[2021-06-27 06:00:18 +0800] [16] [INFO] Booting worker with pid: 16
[2021-06-27 06:00:18 +0800] [17] [INFO] Booting worker with pid: 17
[2021-06-27 06:00:18 +0800] [18] [INFO] Booting worker with pid: 18
[2021-06-27 06:00:18 +0800] [19] [INFO] Booting worker with pid: 19
[2021-06-27 06:00:18 +0800] [20] [INFO] Booting worker with pid: 20
[2021-06-27 06:00:18 +0800] [21] [INFO] Booting worker with pid: 21
[2021-06-27 06:00:18 +0800] [22] [INFO] Booting worker with pid: 22
[2021-06-27 06:00:18 +0800] [23] [INFO] Booting worker with pid: 23
[2021-06-27 06:00:18 +0800] [24] [INFO] Booting worker with pid: 24
[2021-06-27 06:00:18 +0800] [25] [INFO] Booting worker with pid: 25
[2021-06-27 06:00:18 +0800] [26] [INFO] Booting worker with pid: 26
[2021-06-27 06:35:30 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:25)
[2021-06-27 06:35:31 +0800] [330] [INFO] Booting worker with pid: 330
[2021-06-27 06:35:53 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:17)
[2021-06-27 06:35:54 +0800] [339] [INFO] Booting worker with pid: 339
[2021-06-27 07:29:16 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:339)
[2021-06-27 07:29:17 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:11)
[2021-06-27 07:29:17 +0800] [348] [INFO] Booting worker with pid: 348
[2021-06-27 07:29:17 +0800] [349] [INFO] Booting worker with pid: 349
[2021-06-27 07:29:19 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:10)
[2021-06-27 07:29:19 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:14)
[2021-06-27 07:29:19 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:19)
[2021-06-27 07:29:19 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:21)
[2021-06-27 07:29:19 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:22)
[2021-06-27 07:29:19 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:330)
[2021-06-27 07:29:20 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:15)
[2021-06-27 07:29:20 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:18)
[2021-06-27 07:29:20 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:24)
[2021-06-27 07:29:20 +0800] [7] [CRITICAL] WORKER TIMEOUT (pid:13)
[2021-06-27 07:29:20 +0800] [366] [INFO] Booting worker with pid: 366
[2021-06-27 07:29:20 +0800] [367] [INFO] Booting worker with pid: 367
[2021-06-27 07:29:20 +0800] [368] [INFO] Booting worker with pid: 368
[2021-06-27 07:29:20 +0800] [369] [INFO] Booting worker with pid: 369
[2021-06-27 07:29:20 +0800] [370] [INFO] Booting worker with pid: 370
[2021-06-27 07:29:20 +0800] [371] [INFO] Booting worker with pid: 371
[2021-06-27 07:29:20 +0800] [372] [INFO] Booting worker with pid: 372
[2021-06-27 07:29:20 +0800] [373] [INFO] Booting worker with pid: 373
[2021-06-27 07:29:20 +0800] [374] [INFO] Booting worker with pid: 374
[2021-06-27 07:29:21 +0800] [375] [INFO] Booting worker with pid: 375
```
How to reproduce the bug
1. Set configuration as per above
2. Run superset
3. See error
### Environment
(please complete the following information):
- superset version: `1.0.1`
- python version: `based on superset 1.0.1`
- node.js version: `based on superset 1.0.1`
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version
of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
I run Nginx in front of Gunicorn with gevent
[GitHub] [superset] ofekisr opened a new pull request #15407: fix removed flask_app property can break derived class
ofekisr opened a new pull request #15407: URL: https://github.com/apache/superset/pull/15407 After renaming "flask_app" property to "superset_app", we understand that it can brack derived classes so I added "flask_app" as deprecated property -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] tvorogme removed a comment on issue #15291: Dashboard Native Filter: cannot filter null values
tvorogme removed a comment on issue #15291: URL: https://github.com/apache/superset/issues/15291#issuecomment-869120277 Hi! I see @mironovmeow created pull request with fixing this issue. @zhaoyongjie @junlincc will you review it? Or we wait for realization from superset team? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 commented on a change in pull request #15407: fix(regression): removed flask_app property can break derived class
amitmiran137 commented on a change in pull request #15407:
URL: https://github.com/apache/superset/pull/15407#discussion_r659323911
##
File path: superset/initialization/__init__.py
##
@@ -64,6 +65,11 @@ def __init__(self, app: SupersetApp) -> None:
self.config = app.config
self.manifest: Dict[Any, Any] = {}
+@deprecated(details="use self.superset_app instead of self.flask_app") #
type: ignore # pylint: disable=line-too-long
Review comment:
Why use that decorator comparing to a comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 # [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15407](https://codecov.io/gh/apache/superset/pull/15407?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8fe2466) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.22%`. > The diff coverage is `80.00%`. [](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15407 +/- ## == - Coverage 77.23% 77.00% -0.23% == Files 975 975 Lines 5061050615 +5 Branches 6212 6212 == - Hits3909038978 -112 - Misses 1131311430 +117 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.71% <75.00%> (-0.01%)` | :arrow_down: | | postgres | `81.73% <80.00%> (-0.01%)` | :arrow_down: | | presto | `?` | | | python | `81.81% <80.00%> (-0.44%)` | :arrow_down: | | sqlite | `81.35% <75.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.65%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 # [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15407](https://codecov.io/gh/apache/superset/pull/15407?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8fe2466) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.07%`. > The diff coverage is `80.00%`. [](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15407 +/- ## == - Coverage 77.23% 77.16% -0.08% == Files 975 975 Lines 5061050615 +5 Branches 6212 6212 == - Hits3909039055 -35 - Misses 1131311353 +40 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.44% <80.00%> (-0.01%)` | :arrow_down: | | mysql | `81.71% <75.00%> (-0.01%)` | :arrow_down: | | postgres | `81.73% <80.00%> (-0.01%)` | :arrow_down: | | presto | `?` | | | python | `82.10% <80.00%> (-0.15%)` | :arrow_down: | | sqlite | `81.35% <75.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.42% <0.00%> (-5.48%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.45% <0.00%> (-1.42%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.76% <0.00%> (-0.27%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [09c44d0...8fe2466](https://codecov.io/gh/apache/superset/pull/15407?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
[GitHub] [superset] codecov[bot] commented on pull request #15405: chore(refactor): load configuration and merge recursively
codecov[bot] commented on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 # [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15405](https://codecov.io/gh/apache/superset/pull/15405?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (94ee62b) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.15%`. > The diff coverage is `58.33%`. [](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15405 +/- ## == - Coverage 77.16% 77.00% -0.16% == Files 975 975 Lines 5061050594 -16 Branches 6212 6212 == - Hits3905138962 -89 - Misses 1135211425 +73 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.73% <58.33%> (+0.02%)` | :arrow_up: | | postgres | `81.73% <58.33%> (+<0.01%)` | :arrow_up: | | python | `81.82% <58.33%> (-0.29%)` | :arrow_down: | | sqlite | `81.37% <58.33%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `97.06% <ø> (+5.91%)` | :arrow_up: | | [superset/app.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `65.38% <58.33%> (-17.95%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `73.42% <0.00%> (-2.45%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 # [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15405](https://codecov.io/gh/apache/superset/pull/15405?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (94ee62b) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.14%`. > The diff coverage is `58.33%`. [](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15405 +/- ## == - Coverage 77.16% 77.02% -0.15% == Files 975 975 Lines 5061050623 +13 Branches 6212 6212 == - Hits3905138990 -61 - Misses 1135211426 +74 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.73% <58.33%> (+0.02%)` | :arrow_up: | | postgres | `81.75% <58.33%> (+0.02%)` | :arrow_up: | | python | `81.83% <58.33%> (-0.28%)` | :arrow_down: | | sqlite | `81.37% <58.33%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `97.06% <ø> (+5.91%)` | :arrow_up: | | [superset/app.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `65.38% <58.33%> (-17.95%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-0.24%)` | :arrow_down: | |
[GitHub] [superset] zufolo441 commented on issue #15331: Nginx Configuration
zufolo441 commented on issue #15331:
URL: https://github.com/apache/superset/issues/15331#issuecomment-869129955
our configuration:
superset server is 192.168.1.80
server {
listen 159.213.63.16:80;
server_name dwh.istitutodegliinnocenti.it;
include /etc/nginx/acmechallenge.conf;
}
server {
listen 159.213.63.16:443 ssl;
server_name dwh.istitutodegliinnocenti.it;
root /var/www/html;
index index.html index.htm index.nginx-debian.html;
ssl_certificate /etc/ssl/dwh.istitutodegliinnocenti.it/domain.crt;
ssl_certificate_key /etc/ssl/dwh.istitutodegliinnocenti.it/domain.key;
ssl_protocols TLSv1.2 TLSv1.3;
ssl_prefer_server_ciphers on;
ssl_dhparam /etc/nginx/dhparam.pem;
ssl_ciphers
ECDHE-RSA-AES256-GCM-SHA512:DHE-RSA-AES256-GCM-SHA512:ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-SHA384;
ssl_ecdh_curve secp384r1;
ssl_session_timeout 10m;
ssl_session_cache shared:SSL:10m;
resolver localhost valid=300s;
resolver_timeout 5s;
if ($request_uri ~ ^(.*)\?$) { return 301 $1; }
access_log /var/log/nginx/dwh_access.log;
error_log /var/log/nginx/dwh_error.log;
location / {
proxy_pass http://192.168.1.80:8089;
proxy_set_header Host $host;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_redirect off;
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 # [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15405](https://codecov.io/gh/apache/superset/pull/15405?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (94ee62b) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **increase** coverage by `0.01%`. > The diff coverage is `58.33%`. [](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15405 +/- ## == + Coverage 77.23% 77.24% +0.01% == Files 975 975 Lines 5061050623 +13 Branches 6212 6212 == + Hits3909039106 +16 + Misses 1131311310 -3 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.46% <58.33%> (+0.02%)` | :arrow_up: | | mysql | `81.73% <58.33%> (+0.02%)` | :arrow_up: | | postgres | `81.75% <58.33%> (+0.02%)` | :arrow_up: | | presto | `81.45% <58.33%> (+0.02%)` | :arrow_up: | | python | `82.27% <58.33%> (+0.02%)` | :arrow_up: | | sqlite | `81.37% <58.33%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `97.06% <ø> (+5.91%)` | :arrow_up: | | [superset/app.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `65.38% <58.33%> (-17.95%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [09c44d0...94ee62b](https://codecov.io/gh/apache/superset/pull/15405?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 # [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15407](https://codecov.io/gh/apache/superset/pull/15407?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b760ee8) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.22%`. > The diff coverage is `80.00%`. > :exclamation: Current head b760ee8 differs from pull request most recent head 8fe2466. Consider uploading reports for the commit 8fe2466 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15407 +/- ## == - Coverage 77.23% 77.00% -0.23% == Files 975 975 Lines 5061050615 +5 Branches 6212 6212 == - Hits3909038978 -112 - Misses 1131311430 +117 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.71% <75.00%> (-0.01%)` | :arrow_down: | | postgres | `81.73% <80.00%> (-0.01%)` | :arrow_down: | | presto | `?` | | | python | `81.81% <80.00%> (-0.44%)` | :arrow_down: | | sqlite | `81.35% <75.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.65%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | |
[GitHub] [superset] mironovmeow closed pull request #15387: fix: Add null var to native filter (#15291)
mironovmeow closed pull request #15387: URL: https://github.com/apache/superset/pull/15387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] MatanBobi commented on issue #13013: [SIP-58] Proposal to move superset-ui to this repo
MatanBobi commented on issue #13013: URL: https://github.com/apache/superset/issues/13013#issuecomment-869109109 Just updating here as I'll probably start working on it this week. After consulting with @amitmiran137 and @rusackas, we'll probably start with building the monorepo approach and only move the `core` package. Then, we'll start moving the plugins one by one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] ofekisr opened a new pull request #15405: refactor load configuration
ofekisr opened a new pull request #15405: URL: https://github.com/apache/superset/pull/15405 ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 # [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15405](https://codecov.io/gh/apache/superset/pull/15405?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (94ee62b) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **increase** coverage by `0.01%`. > The diff coverage is `58.33%`. [](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15405 +/- ## == + Coverage 77.16% 77.17% +0.01% == Files 975 975 Lines 5061050623 +13 Branches 6212 6212 == + Hits3905139067 +16 + Misses 1135211349 -3 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.46% <58.33%> (+0.02%)` | :arrow_up: | | mysql | `81.73% <58.33%> (+0.02%)` | :arrow_up: | | postgres | `81.75% <58.33%> (+0.02%)` | :arrow_up: | | python | `82.13% <58.33%> (+0.02%)` | :arrow_up: | | sqlite | `81.37% <58.33%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `97.06% <ø> (+5.91%)` | :arrow_up: | | [superset/app.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `65.38% <58.33%> (-17.95%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [09c44d0...94ee62b](https://codecov.io/gh/apache/superset/pull/15405?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15407: fix(regression): removed flask_app property can break derived class
codecov[bot] commented on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 # [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15407](https://codecov.io/gh/apache/superset/pull/15407?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b760ee8) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.25%`. > The diff coverage is `80.00%`. > :exclamation: Current head b760ee8 differs from pull request most recent head 8fe2466. Consider uploading reports for the commit 8fe2466 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15407 +/- ## == - Coverage 77.23% 76.98% -0.26% == Files 975 975 Lines 5061050615 +5 Branches 6212 6212 == - Hits3909038966 -124 - Misses 1131311442 +129 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.73% <80.00%> (+<0.01%)` | :arrow_up: | | presto | `?` | | | python | `81.77% <80.00%> (-0.49%)` | :arrow_down: | | sqlite | `81.35% <75.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.85% <0.00%> (-4.29%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.65%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 # [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15407](https://codecov.io/gh/apache/superset/pull/15407?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b760ee8) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.22%`. > The diff coverage is `80.00%`. > :exclamation: Current head b760ee8 differs from pull request most recent head 8fe2466. Consider uploading reports for the commit 8fe2466 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15407 +/- ## == - Coverage 77.23% 77.00% -0.23% == Files 975 975 Lines 5061050615 +5 Branches 6212 6212 == - Hits3909038978 -112 - Misses 1131311430 +117 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.71% <75.00%> (-0.01%)` | :arrow_down: | | postgres | `81.73% <80.00%> (+<0.01%)` | :arrow_up: | | presto | `?` | | | python | `81.81% <80.00%> (-0.44%)` | :arrow_down: | | sqlite | `81.35% <75.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.65%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 # [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15407](https://codecov.io/gh/apache/superset/pull/15407?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8fe2466) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.25%`. > The diff coverage is `80.00%`. [](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15407 +/- ## == - Coverage 77.23% 76.98% -0.26% == Files 975 975 Lines 5061050615 +5 Branches 6212 6212 == - Hits3909038966 -124 - Misses 1131311442 +129 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.73% <80.00%> (+<0.01%)` | :arrow_up: | | presto | `?` | | | python | `81.77% <80.00%> (-0.49%)` | :arrow_down: | | sqlite | `81.35% <75.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.85% <0.00%> (-4.29%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.65%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 # [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15407](https://codecov.io/gh/apache/superset/pull/15407?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8fe2466) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.22%`. > The diff coverage is `80.00%`. [](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15407 +/- ## == - Coverage 77.23% 77.00% -0.23% == Files 975 975 Lines 5061050615 +5 Branches 6212 6212 == - Hits3909038978 -112 - Misses 1131311430 +117 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.71% <75.00%> (-0.01%)` | :arrow_down: | | postgres | `81.73% <80.00%> (+<0.01%)` | :arrow_up: | | presto | `?` | | | python | `81.81% <80.00%> (-0.44%)` | :arrow_down: | | sqlite | `81.35% <75.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.65%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] commented on pull request #15408: refactor: icon to icons for listviewcomponent
codecov[bot] commented on pull request #15408: URL: https://github.com/apache/superset/pull/15408#issuecomment-869164859 # [Codecov](https://codecov.io/gh/apache/superset/pull/15408?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15408](https://codecov.io/gh/apache/superset/pull/15408?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4f3186e) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **not change** coverage. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15408?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #15408 +/- ## === Coverage 77.23% 77.23% === Files 975 975 Lines 5061050610 Branches 6212 6212 === Hits3909039090 Misses 1131311313 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.76% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15408?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/superset/pull/15408/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `96.15% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15408?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15408?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [09c44d0...4f3186e](https://codecov.io/gh/apache/superset/pull/15408?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] mvoitko commented on pull request #15297: fix: bootstrapScript in values.yaml of the helm chart
mvoitko commented on pull request #15297: URL: https://github.com/apache/superset/pull/15297#issuecomment-869139185 @craig-rueda Could you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] pkdotson opened a new pull request #15408: refactor: icon to icons for listviewcomponent
pkdotson opened a new pull request #15408: URL: https://github.com/apache/superset/pull/15408 ### SUMMARY this pr refactors the listview icon and and cardview icon to the new icons component ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF before https://user-images.githubusercontent.com/17326228/123545875-347caf80-d70f-11eb-83af-d127e3a76a8a.png;> after https://user-images.githubusercontent.com/17326228/123545879-3ba3bd80-d70f-11eb-8db6-ff6cda10cc0a.png;> ### TESTING INSTRUCTIONS got to any of the listviews to view card and list icons ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] ofekisr commented on a change in pull request #15407: fix(regression): removed flask_app property can break derived class
ofekisr commented on a change in pull request #15407:
URL: https://github.com/apache/superset/pull/15407#discussion_r659324643
##
File path: superset/initialization/__init__.py
##
@@ -64,6 +65,11 @@ def __init__(self, app: SupersetApp) -> None:
self.config = app.config
self.manifest: Dict[Any, Any] = {}
+@deprecated(details="use self.superset_app instead of self.flask_app") #
type: ignore # pylint: disable=line-too-long
Review comment:
it providing proper warnings both in documentation and via Python’s
warnings system,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15409: feat: more SIP-40 error messages for SQL Lab
codecov[bot] edited a comment on pull request #15409: URL: https://github.com/apache/superset/pull/15409#issuecomment-869202759 # [Codecov](https://codecov.io/gh/apache/superset/pull/15409?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15409](https://codecov.io/gh/apache/superset/pull/15409?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fd6eded) into [master](https://codecov.io/gh/apache/superset/commit/22d23fcfb962146c4706ff0618d1e391554ef0be?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (22d23fc) will **decrease** coverage by `0.22%`. > The diff coverage is `81.25%`. > :exclamation: Current head fd6eded differs from pull request most recent head 1fa6db1. Consider uploading reports for the commit 1fa6db1 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15409?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15409 +/- ## == - Coverage 77.23% 77.00% -0.23% == Files 975 975 Lines 5059250620 +28 Branches 6204 6212 +8 == - Hits3907538981 -94 - Misses 1131011432 +122 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | javascript | `71.76% <88.23%> (+<0.01%)` | :arrow_up: | | mysql | `81.71% <61.53%> (-0.01%)` | :arrow_down: | | postgres | `81.73% <64.28%> (-0.01%)` | :arrow_down: | | presto | `?` | | | python | `81.81% <64.28%> (-0.45%)` | :arrow_down: | | sqlite | `81.35% <61.53%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15409?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | | | [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `0.00% <0.00%> (ø)` | | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.54% <0.00%> (ø)` | | | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.52% <66.66%> (-0.65%)` | :arrow_down: | | [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `92.50% <66.66%> (-1.01%)` | :arrow_down: | | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | |
[GitHub] [superset] nytai edited a comment on issue #15406: Gunicorn gevent worker keep timeout
nytai edited a comment on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215911 Also, this issue is really with gunicorn and not superset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] nytai commented on issue #15406: Gunicorn gevent worker keep timeout
nytai commented on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215911 Also this issue is really with gunicorn and not superset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 merged pull request #15407: fix(regression): removed flask_app property can break derived class
amitmiran137 merged pull request #15407: URL: https://github.com/apache/superset/pull/15407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #15297: fix: bootstrapScript in values.yaml of the helm chart
craig-rueda merged pull request #15297: URL: https://github.com/apache/superset/pull/15297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] betodealmeida opened a new pull request #15409: feat: more SIP-40 error messages for SQL Lab
betodealmeida opened a new pull request #15409: URL: https://github.com/apache/superset/pull/15409 ### SUMMARY Add more SIP-40 compliant error messages to SQL Lab. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF  ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] nytai removed a comment on issue #15406: Gunicorn gevent worker keep timeout
nytai removed a comment on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215294 It’s probably the `keepalive` setting you have at 60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15407: fix(regression): removed flask_app property can break derived class
codecov[bot] edited a comment on pull request #15407: URL: https://github.com/apache/superset/pull/15407#issuecomment-869161813 # [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15407](https://codecov.io/gh/apache/superset/pull/15407?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8fe2466) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **increase** coverage by `0.00%`. > The diff coverage is `80.00%`. [](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #15407 +/- ## === Coverage 77.23% 77.23% === Files 975 975 Lines 5061050615+5 Branches 6212 6212 === + Hits3909039094+4 - Misses 1131311314+1 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.44% <80.00%> (-0.01%)` | :arrow_down: | | mysql | `81.71% <75.00%> (-0.01%)` | :arrow_down: | | postgres | `81.73% <80.00%> (-0.01%)` | :arrow_down: | | presto | `81.43% <80.00%> (-0.01%)` | :arrow_down: | | python | `82.25% <80.00%> (-0.01%)` | :arrow_down: | | sqlite | `81.35% <75.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15407?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15407/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15407?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [09c44d0...8fe2466](https://codecov.io/gh/apache/superset/pull/15407?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #15153: feat: Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)
zhaoyongjie commented on a change in pull request #15153:
URL: https://github.com/apache/superset/pull/15153#discussion_r659343457
##
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##
@@ -113,6 +125,11 @@ export default function DataSourcePanel({
columns,
metrics,
});
+ const [showAllMetrics, setShowAllMetrics] = useState(false);
+ const [showAllColumns, setShowAllColumns] = useState(false);
+
+ const DEFAULT_MAX_COLUMNS_LENGTH = 50;
Review comment:
Should we put these constants in the superset config, then access these
values from store of redux `explore.common.conf.DEFAULT_MAX_COLUMNS_LENGTH` and
`explore.common.conf.DEFAULT_MAX_METRICS_LENGTH`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15409: feat: more SIP-40 error messages for SQL Lab
codecov[bot] edited a comment on pull request #15409: URL: https://github.com/apache/superset/pull/15409#issuecomment-869202759 # [Codecov](https://codecov.io/gh/apache/superset/pull/15409?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15409](https://codecov.io/gh/apache/superset/pull/15409?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fd6eded) into [master](https://codecov.io/gh/apache/superset/commit/22d23fcfb962146c4706ff0618d1e391554ef0be?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (22d23fc) will **decrease** coverage by `0.22%`. > The diff coverage is `81.25%`. > :exclamation: Current head fd6eded differs from pull request most recent head 1fa6db1. Consider uploading reports for the commit 1fa6db1 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15409?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15409 +/- ## == - Coverage 77.23% 77.00% -0.23% == Files 975 975 Lines 5059250619 +27 Branches 6204 6212 +8 == - Hits3907538981 -94 - Misses 1131011431 +121 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.71% <61.53%> (-0.01%)` | :arrow_down: | | postgres | `81.73% <64.28%> (-0.01%)` | :arrow_down: | | presto | `?` | | | python | `81.81% <64.28%> (-0.45%)` | :arrow_down: | | sqlite | `81.35% <61.53%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15409?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | | | [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `0.00% <0.00%> (ø)` | | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.54% <0.00%> (ø)` | | | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.52% <66.66%> (-0.65%)` | :arrow_down: | | [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `92.50% <66.66%> (-1.01%)` | :arrow_down: | | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <80.00%> (-0.15%)` | :arrow_down: | |
[GitHub] [superset] JavierLopezT opened a new pull request #15410: docs: Small addition in add new databases with docker
JavierLopezT opened a new pull request #15410: URL: https://github.com/apache/superset/pull/15410 Based on my own noob experience Since it is a small doc change, I think it doesn't need an Issue first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #15153: feat: Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)
zhaoyongjie commented on a change in pull request #15153:
URL: https://github.com/apache/superset/pull/15153#discussion_r659343457
##
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##
@@ -113,6 +125,11 @@ export default function DataSourcePanel({
columns,
metrics,
});
+ const [showAllMetrics, setShowAllMetrics] = useState(false);
+ const [showAllColumns, setShowAllColumns] = useState(false);
+
+ const DEFAULT_MAX_COLUMNS_LENGTH = 50;
Review comment:
Should we put these constants in the superset config, then access these
values from store of redux `explore.common.conf.DEFAULT_MAX_COLUMNS_LENGTH` and
`explore.common.conf.DEFAULT_MAX_METRICS_LENGTH`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 # [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15405](https://codecov.io/gh/apache/superset/pull/15405?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (94ee62b) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **increase** coverage by `0.01%`. > The diff coverage is `58.33%`. > :exclamation: Current head 94ee62b differs from pull request most recent head 5cedd56. Consider uploading reports for the commit 5cedd56 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15405 +/- ## == + Coverage 77.23% 77.24% +0.01% == Files 975 975 Lines 5061050623 +13 Branches 6212 6212 == + Hits3909039106 +16 + Misses 1131311310 -3 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.46% <58.33%> (+0.02%)` | :arrow_up: | | mysql | `81.73% <58.33%> (+0.02%)` | :arrow_up: | | postgres | `81.75% <58.33%> (+0.02%)` | :arrow_up: | | presto | `81.45% <58.33%> (+0.02%)` | :arrow_up: | | python | `82.27% <58.33%> (+0.02%)` | :arrow_up: | | sqlite | `81.37% <58.33%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `97.06% <ø> (+5.91%)` | :arrow_up: | | [superset/app.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `65.38% <58.33%> (-17.95%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [09c44d0...5cedd56](https://codecov.io/gh/apache/superset/pull/15405?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands,
[GitHub] [superset] codecov[bot] edited a comment on pull request #15405: chore(refactor): load configuration and merge recursively
codecov[bot] edited a comment on pull request #15405: URL: https://github.com/apache/superset/pull/15405#issuecomment-869124850 # [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15405](https://codecov.io/gh/apache/superset/pull/15405?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (94ee62b) into [master](https://codecov.io/gh/apache/superset/commit/a3d91aee28a5e1bffc79ff27de6feaa2edb611fc?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a3d91ae) will **increase** coverage by `0.01%`. > The diff coverage is `58.33%`. > :exclamation: Current head 94ee62b differs from pull request most recent head 3079f0e. Consider uploading reports for the commit 3079f0e to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15405 +/- ## == + Coverage 77.23% 77.24% +0.01% == Files 975 975 Lines 5061550623 +8 Branches 6212 6212 == + Hits3909439106 +12 + Misses 1131411310 -4 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.46% <58.33%> (+0.02%)` | :arrow_up: | | mysql | `81.73% <58.33%> (+0.02%)` | :arrow_up: | | postgres | `81.75% <58.33%> (+0.02%)` | :arrow_up: | | presto | `81.45% <58.33%> (+0.02%)` | :arrow_up: | | python | `82.27% <58.33%> (+0.02%)` | :arrow_up: | | sqlite | `81.37% <58.33%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15405?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `97.06% <ø> (+5.91%)` | :arrow_up: | | [superset/app.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `65.38% <58.33%> (-17.95%)` | :arrow_down: | | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15405/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `88.05% <0.00%> (+0.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15405?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [a3d91ae...3079f0e](https://codecov.io/gh/apache/superset/pull/15405?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To
[GitHub] [superset] codecov[bot] commented on pull request #15409: feat: more SIP-40 error messages for SQL Lab
codecov[bot] commented on pull request #15409: URL: https://github.com/apache/superset/pull/15409#issuecomment-869202759 # [Codecov](https://codecov.io/gh/apache/superset/pull/15409?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15409](https://codecov.io/gh/apache/superset/pull/15409?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fd6eded) into [master](https://codecov.io/gh/apache/superset/commit/22d23fcfb962146c4706ff0618d1e391554ef0be?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (22d23fc) will **decrease** coverage by `0.23%`. > The diff coverage is `80.85%`. > :exclamation: Current head fd6eded differs from pull request most recent head 1fa6db1. Consider uploading reports for the commit 1fa6db1 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15409?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15409 +/- ## == - Coverage 77.23% 76.99% -0.24% == Files 975 975 Lines 5059250589 -3 Branches 6204 6212 +8 == - Hits3907538952 -123 - Misses 1131011430 +120 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.71% <61.53%> (-0.01%)` | :arrow_down: | | postgres | `81.71% <61.53%> (-0.02%)` | :arrow_down: | | presto | `?` | | | python | `81.80% <61.53%> (-0.46%)` | :arrow_down: | | sqlite | `81.35% <61.53%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15409?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | | | [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `0.00% <0.00%> (ø)` | | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.54% <0.00%> (ø)` | | | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.52% <66.66%> (-0.65%)` | :arrow_down: | | [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `92.50% <66.66%> (-1.01%)` | :arrow_down: | | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15409/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.82% <75.00%> (-0.24%)` | :arrow_down: | |
[GitHub] [superset] nytai commented on issue #15406: Gunicorn gevent worker keep timeout
nytai commented on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215102 Are you it’s not something else in the stack like nginx timing out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] nytai commented on issue #15406: Gunicorn gevent worker keep timeout
nytai commented on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215294 It’s probably the `keepalive` setting you have at 60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] nytai removed a comment on issue #15406: Gunicorn gevent worker keep timeout
nytai removed a comment on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215102 Are you it’s not something else in the stack like nginx timing out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] nytai commented on issue #15406: Gunicorn gevent worker keep timeout
nytai commented on issue #15406: URL: https://github.com/apache/superset/issues/15406#issuecomment-869215733 Have you tried setting it to 0 to disable all timeouts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 merged pull request #15153: feat: Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)
amitmiran137 merged pull request #15153: URL: https://github.com/apache/superset/pull/15153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 commented on pull request #14508: potential fix for issue 11988
amitmiran137 commented on pull request #14508: URL: https://github.com/apache/superset/pull/14508#issuecomment-869220529 closing due to inactivity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 # [Codecov](https://codecov.io/gh/apache/superset/pull/14278?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#14278](https://codecov.io/gh/apache/superset/pull/14278?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (792929f) into [master](https://codecov.io/gh/apache/superset/commit/70cfb7752c92d88a134466b705f8c4508b225126?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (70cfb77) will **decrease** coverage by `0.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #14278 +/- ## == - Coverage 77.01% 76.74% -0.27% == Files 954 954 Lines 4806648066 Branches 5973 5973 == - Hits3701636890 -126 - Misses 1084810974 +126 Partials 202 202 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `80.76% <ø> (+0.01%)` | :arrow_up: | | presto | `?` | | | python | `80.80% <ø> (-0.50%)` | :arrow_down: | | sqlite | `80.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.37% <0.00%> (-1.70%)` | :arrow_down: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.53% <0.00%> (-1.50%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-1.09%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.26% <0.00%> (-0.45%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 # [Codecov](https://codecov.io/gh/apache/superset/pull/14278?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#14278](https://codecov.io/gh/apache/superset/pull/14278?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (792929f) into [master](https://codecov.io/gh/apache/superset/commit/70cfb7752c92d88a134466b705f8c4508b225126?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (70cfb77) will **decrease** coverage by `0.24%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #14278 +/- ## == - Coverage 77.01% 76.76% -0.25% == Files 954 954 Lines 4806648066 Branches 5973 5973 == - Hits3701636900 -116 - Misses 1084810964 +116 Partials 202 202 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `80.72% <ø> (ø)` | | | postgres | `80.76% <ø> (+0.01%)` | :arrow_up: | | presto | `?` | | | python | `80.84% <ø> (-0.46%)` | :arrow_down: | | sqlite | `80.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.37% <0.00%> (-1.70%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.05% <0.00%> (-0.45%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.65% <0.00%> (-0.13%)` | :arrow_down: |
[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 # [Codecov](https://codecov.io/gh/apache/superset/pull/14278?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#14278](https://codecov.io/gh/apache/superset/pull/14278?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (792929f) into [master](https://codecov.io/gh/apache/superset/commit/70cfb7752c92d88a134466b705f8c4508b225126?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (70cfb77) will **decrease** coverage by `0.24%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #14278 +/- ## == - Coverage 77.01% 76.76% -0.25% == Files 954 954 Lines 4806648066 Branches 5973 5547 -426 == - Hits3701636900 -116 - Misses 1084810969 +121 + Partials 202 197 -5 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | javascript | `72.10% <ø> (ø)` | | | mysql | `80.72% <ø> (ø)` | | | postgres | `80.76% <ø> (+0.01%)` | :arrow_up: | | presto | `?` | | | python | `80.84% <ø> (-0.46%)` | :arrow_down: | | sqlite | `80.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.37% <0.00%> (-1.70%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.05% <0.00%> (-0.45%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) |
[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 # [Codecov](https://codecov.io/gh/apache/superset/pull/14278?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#14278](https://codecov.io/gh/apache/superset/pull/14278?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (792929f) into [master](https://codecov.io/gh/apache/superset/commit/70cfb7752c92d88a134466b705f8c4508b225126?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (70cfb77) will **decrease** coverage by `0.08%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #14278 +/- ## == - Coverage 77.01% 76.92% -0.09% == Files 954 954 Lines 4806648066 Branches 5973 5547 -426 == - Hits3701636977 -39 - Misses 1084810892 +44 + Partials 202 197 -5 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `80.44% <ø> (ø)` | | | javascript | `72.10% <ø> (ø)` | | | mysql | `80.72% <ø> (ø)` | | | postgres | `80.76% <ø> (+0.01%)` | :arrow_up: | | presto | `?` | | | python | `81.14% <ø> (-0.16%)` | :arrow_down: | | sqlite | `80.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.42% <0.00%> (-5.48%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.61% <0.00%> (-1.46%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: | | [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `64.28% <0.00%> (ø)` | | | [...d/src/filters/components/GroupBy/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3RyYW5zZm9ybVByb3BzLnRz) | `33.33% <0.00%> (ø)` | | | [...src/filters/components/TimeGrain/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vdHJhbnNmb3JtUHJvcHMudHM=) | `33.33% <0.00%> (ø)` | | | [...rc/filters/components/TimeColumn/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3RyYW5zZm9ybVByb3BzLnRz) | `33.33% <0.00%> (ø)` | | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 # [Codecov](https://codecov.io/gh/apache/superset/pull/14278?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#14278](https://codecov.io/gh/apache/superset/pull/14278?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (792929f) into [master](https://codecov.io/gh/apache/superset/commit/70cfb7752c92d88a134466b705f8c4508b225126?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (70cfb77) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff@@ ## master #14278+/- ## Coverage 77.01% 77.01% Files 954 954 Lines 4806648066 Branches 5973 5547 -426 Hits3701637016 - Misses 1084810853 +5 + Partials 202 197 -5 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `80.44% <ø> (ø)` | | | javascript | `72.10% <ø> (ø)` | | | mysql | `80.72% <ø> (ø)` | | | postgres | `80.76% <ø> (+0.01%)` | :arrow_up: | | presto | `80.45% <ø> (ø)` | | | python | `81.29% <ø> (ø)` | | | sqlite | `80.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `64.28% <0.00%> (ø)` | | | [...d/src/filters/components/GroupBy/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3RyYW5zZm9ybVByb3BzLnRz) | `33.33% <0.00%> (ø)` | | | [...src/filters/components/TimeGrain/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vdHJhbnNmb3JtUHJvcHMudHM=) | `33.33% <0.00%> (ø)` | | | [...rc/filters/components/TimeColumn/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3RyYW5zZm9ybVByb3BzLnRz) | `33.33% <0.00%> (ø)` | | | [...ts/nativeFilters/FilterBar/FilterControls/state.ts](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL3N0YXRlLnRz) | `80.00% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14278?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] [superset] amitmiran137 merged pull request #14908: chore: Add Slovenian (sl_SI) translation
amitmiran137 merged pull request #14908: URL: https://github.com/apache/superset/pull/14908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15408: refactor: icon to icons for listviewcomponent
codecov[bot] edited a comment on pull request #15408: URL: https://github.com/apache/superset/pull/15408#issuecomment-869164859 # [Codecov](https://codecov.io/gh/apache/superset/pull/15408?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15408](https://codecov.io/gh/apache/superset/pull/15408?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4f3186e) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **not change** coverage. > The diff coverage is `100.00%`. > :exclamation: Current head 4f3186e differs from pull request most recent head b58ef98. Consider uploading reports for the commit b58ef98 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15408?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #15408 +/- ## === Coverage 77.23% 77.23% === Files 975 975 Lines 5061050610 Branches 6212 6212 === Hits3909039090 Misses 1131311313 Partials 207 207 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.76% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15408?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/superset/pull/15408/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `96.15% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15408?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15408?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [09c44d0...b58ef98](https://codecov.io/gh/apache/superset/pull/15408?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #14751: [Explore]Search data panel column by key words
zhaoyongjie commented on issue #14751: URL: https://github.com/apache/superset/issues/14751#issuecomment-869258874 closed by https://github.com/apache/superset/pull/15153#event-4944281888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] zhaoyongjie closed issue #14751: [Explore]Search data panel column by key words
zhaoyongjie closed issue #14751: URL: https://github.com/apache/superset/issues/14751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 merged pull request #14572: docs: release documentation for 1.2
amitmiran137 merged pull request #14572: URL: https://github.com/apache/superset/pull/14572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 commented on pull request #14464: chore(dashboard): add new e2e tests
amitmiran137 commented on pull request #14464: URL: https://github.com/apache/superset/pull/14464#issuecomment-869220033 Lets close and re-open if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #14464: chore(dashboard): add new e2e tests
amitmiran137 closed pull request #14464: URL: https://github.com/apache/superset/pull/14464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #14508: potential fix for issue 11988
amitmiran137 closed pull request #14508: URL: https://github.com/apache/superset/pull/14508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #14499: fix: OrderDate is a bad reference
amitmiran137 closed pull request #14499: URL: https://github.com/apache/superset/pull/14499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14278: docs: Update SIP template
codecov[bot] edited a comment on pull request #14278: URL: https://github.com/apache/superset/pull/14278#issuecomment-824365814 # [Codecov](https://codecov.io/gh/apache/superset/pull/14278?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#14278](https://codecov.io/gh/apache/superset/pull/14278?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9733c5c) into [master](https://codecov.io/gh/apache/superset/commit/70cfb7752c92d88a134466b705f8c4508b225126?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (70cfb77) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. > :exclamation: Current head 9733c5c differs from pull request most recent head 792929f. Consider uploading reports for the commit 792929f to get more accurate results [](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #14278 +/- ## === Coverage 77.01% 77.01% === Files 954 954 Lines 4806648066 Branches 5973 5973 === + Hits3701637018+2 + Misses 1084810846-2 Partials 202 202 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `80.44% <ø> (ø)` | | | javascript | `72.10% <ø> (ø)` | | | mysql | `80.72% <ø> (ø)` | | | postgres | `80.76% <ø> (+0.01%)` | :arrow_up: | | presto | `80.46% <ø> (+<0.01%)` | :arrow_up: | | python | `81.30% <ø> (+<0.01%)` | :arrow_up: | | sqlite | `80.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14278?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14278/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `90.31% <0.00%> (+0.42%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14278?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14278?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [70cfb77...792929f](https://codecov.io/gh/apache/superset/pull/14278?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] mistercrunch opened a new pull request #14499: fix: OrderDate is a bad reference
mistercrunch opened a new pull request #14499: URL: https://github.com/apache/superset/pull/14499 Creating this as pointer to an issue. To reproduce: https://user-images.githubusercontent.com/487433/117216211-421f5400-adb4-11eb-8005-800895c378ea.png;> Bug: https://user-images.githubusercontent.com/487433/117216230-49466200-adb4-11eb-99b6-851cc9b2bc60.png;> I think somewhere we need to make sure that the column exists if we're going to use it. This field is a big of a legacy field in the sense that I don't think it can be set in the dataset editor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15408: refactor: icon to icons for listviewcomponent
codecov[bot] edited a comment on pull request #15408: URL: https://github.com/apache/superset/pull/15408#issuecomment-869164859 # [Codecov](https://codecov.io/gh/apache/superset/pull/15408?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15408](https://codecov.io/gh/apache/superset/pull/15408?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b58ef98) into [master](https://codecov.io/gh/apache/superset/commit/09c44d05fd57db48c4af02500c745d2900fa463b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (09c44d0) will **decrease** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15408?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15408 +/- ## == - Coverage 77.23% 77.22% -0.01% == Files 975 975 Lines 5061050629 +19 Branches 6212 6222 +10 == + Hits3909039100 +10 - Misses 1131311318 +5 - Partials 207 211 +4 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.75% <100.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15408?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/superset/pull/15408/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `96.15% <100.00%> (ø)` | | | [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/15408/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `81.33% <0.00%> (-9.74%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15408?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15408?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [09c44d0...b58ef98](https://codecov.io/gh/apache/superset/pull/15408?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] zhaoyongjie closed issue #15258: documented data cache config doesn't work with flask-caching v1.9.0
zhaoyongjie closed issue #15258: URL: https://github.com/apache/superset/issues/15258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #15259: fix: upgrade Flask-Caching>=1.10.0
zhaoyongjie merged pull request #15259: URL: https://github.com/apache/superset/pull/15259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] jgibson2 closed pull request #14149: feat: Add loadBalancerSourceRanges to helm configuration
jgibson2 closed pull request #14149: URL: https://github.com/apache/superset/pull/14149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 # [Codecov](https://codecov.io/gh/apache/superset/pull/15279?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15279](https://codecov.io/gh/apache/superset/pull/15279?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (92e725b) into [master](https://codecov.io/gh/apache/superset/commit/2ebc0a078a5d402bd390626d33cd76cc707521d6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2ebc0a0) will **decrease** coverage by `0.20%`. > The diff coverage is `83.16%`. [](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15279 +/- ## == - Coverage 77.23% 77.03% -0.21% == Files 975 976 +1 Lines 5063450770 +136 Branches 6222 6222 == + Hits3910639109 +3 - Misses 1131711450 +133 Partials 211 211 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.75% <83.16%> (+0.03%)` | :arrow_up: | | postgres | `81.77% <83.16%> (+0.03%)` | :arrow_up: | | presto | `?` | | | python | `81.85% <83.16%> (-0.42%)` | :arrow_down: | | sqlite | `81.39% <83.16%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ø> (ø)` | | | [superset/common/utils.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3V0aWxzLnB5) | `73.75% <73.75%> (ø)` | | | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `84.24% <84.61%> (-0.22%)` | :arrow_down: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `88.20% <87.30%> (+6.04%)` | :arrow_up: | | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | | | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.66% <100.00%> (+0.52%)` | :arrow_up: | | [superset/constants.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.98% <100.00%> (-0.12%)` | :arrow_down: | |
[GitHub] [superset] villebro opened a new pull request #15411: fix(native-filters): show human readable time grain label in indicator
villebro opened a new pull request #15411: URL: https://github.com/apache/superset/pull/15411 ### SUMMARY Currently when using a time grain native filter, the ISO-8601 time duration is shown in the filter indicator. Instead of showing the technical duration in the indicator (e.g. `PT1H`), it is preferable to show the human readable filter value (e.g. "Hour"). ### AFTER Now the human readable label is displayed in the filter indicator:  ### BEFORE Previously the ISO-8601 time duration was shown in the filter indicator  ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [x] Has associated issue: closes #15361 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 # [Codecov](https://codecov.io/gh/apache/superset/pull/15279?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15279](https://codecov.io/gh/apache/superset/pull/15279?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (92e725b) into [master](https://codecov.io/gh/apache/superset/commit/2ebc0a078a5d402bd390626d33cd76cc707521d6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2ebc0a0) will **increase** coverage by `0.02%`. > The diff coverage is `83.16%`. [](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15279 +/- ## == + Coverage 77.23% 77.26% +0.02% == Files 975 976 +1 Lines 5063450770 +136 Branches 6222 6222 == + Hits3910639225 +119 - Misses 1131711334 +17 Partials 211 211 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.48% <83.16%> (+0.03%)` | :arrow_up: | | mysql | `81.75% <83.16%> (+0.03%)` | :arrow_up: | | postgres | `81.76% <83.16%> (+0.03%)` | :arrow_up: | | presto | `81.56% <83.16%> (+0.12%)` | :arrow_up: | | python | `82.29% <83.16%> (+0.02%)` | :arrow_up: | | sqlite | `81.39% <83.16%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ø> (ø)` | | | [superset/common/utils.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3V0aWxzLnB5) | `73.75% <73.75%> (ø)` | | | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `84.24% <84.61%> (-0.22%)` | :arrow_down: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `88.20% <87.30%> (+6.04%)` | :arrow_up: | | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | | | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.66% <100.00%> (+0.52%)` | :arrow_up: | | [superset/constants.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.10% <100.00%>
[GitHub] [superset] blackhawk28 commented on issue #5650: Not able to add a table from external Redshift Spectrum schema
blackhawk28 commented on issue #5650: URL: https://github.com/apache/superset/issues/5650#issuecomment-869379641 hi @RodBart and @robert-yxin05 I need some clarification, where did you create the table in redshift? and in local schema? and then import that table with the local schema in superset then change its schema to external? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] srikark16 commented on issue #15214: Creating and Update Superset Users in Bulk through API, apache superset version 1.1.0
srikark16 commented on issue #15214: URL: https://github.com/apache/superset/issues/15214#issuecomment-869379979 @zhaoyongjie can you please let me know how to create user with multiple roles using the below command. superset fab create-user -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 # [Codecov](https://codecov.io/gh/apache/superset/pull/15279?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15279](https://codecov.io/gh/apache/superset/pull/15279?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8c44861) into [master](https://codecov.io/gh/apache/superset/commit/2ebc0a078a5d402bd390626d33cd76cc707521d6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2ebc0a0) will **increase** coverage by `0.05%`. > The diff coverage is `84.18%`. > :exclamation: Current head 8c44861 differs from pull request most recent head 92e725b. Consider uploading reports for the commit 92e725b to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15279 +/- ## == + Coverage 77.23% 77.29% +0.05% == Files 975 976 +1 Lines 5063450718 +84 Branches 6222 6202 -20 == + Hits3910639201 +95 + Misses 1131711310 -7 + Partials 211 207 -4 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.49% <84.18%> (+0.04%)` | :arrow_up: | | mysql | `81.75% <83.16%> (+0.03%)` | :arrow_up: | | postgres | `81.77% <84.18%> (+0.04%)` | :arrow_up: | | presto | `81.58% <84.18%> (+0.14%)` | :arrow_up: | | python | `82.30% <84.18%> (+0.04%)` | :arrow_up: | | sqlite | `81.40% <84.18%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ø> (ø)` | | | [superset/common/utils.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3V0aWxzLnB5) | `73.75% <73.75%> (ø)` | | | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `84.24% <84.61%> (-0.22%)` | :arrow_down: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `89.23% <90.47%> (+7.06%)` | :arrow_up: | | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | | | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.66% <100.00%> (+0.52%)` | :arrow_up: | | [superset/constants.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | |
[GitHub] [superset] amitmiran137 merged pull request #14278: docs: Update SIP template
amitmiran137 merged pull request #14278: URL: https://github.com/apache/superset/pull/14278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] amitmiran137 commented on pull request #15384: refactor(dashboard): [chart-maximize-mode]put chart full-size state in redux
amitmiran137 commented on pull request #15384: URL: https://github.com/apache/superset/pull/15384#issuecomment-869345696 could you fix test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 # [Codecov](https://codecov.io/gh/apache/superset/pull/15279?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15279](https://codecov.io/gh/apache/superset/pull/15279?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (92e725b) into [master](https://codecov.io/gh/apache/superset/commit/2ebc0a078a5d402bd390626d33cd76cc707521d6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2ebc0a0) will **decrease** coverage by `0.20%`. > The diff coverage is `83.16%`. [](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15279 +/- ## == - Coverage 77.23% 77.03% -0.21% == Files 975 976 +1 Lines 5063450770 +136 Branches 6222 6222 == + Hits3910639109 +3 - Misses 1131711450 +133 Partials 211 211 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.75% <83.16%> (+0.03%)` | :arrow_up: | | postgres | `81.76% <83.16%> (+0.03%)` | :arrow_up: | | presto | `?` | | | python | `81.85% <83.16%> (-0.42%)` | :arrow_down: | | sqlite | `81.39% <83.16%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ø> (ø)` | | | [superset/common/utils.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3V0aWxzLnB5) | `73.75% <73.75%> (ø)` | | | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `84.24% <84.61%> (-0.22%)` | :arrow_down: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `88.20% <87.30%> (+6.04%)` | :arrow_up: | | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | | | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.66% <100.00%> (+0.52%)` | :arrow_up: | | [superset/constants.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.98% <100.00%> (-0.12%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing
codecov[bot] edited a comment on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-865701614 # [Codecov](https://codecov.io/gh/apache/superset/pull/15279?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15279](https://codecov.io/gh/apache/superset/pull/15279?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (92e725b) into [master](https://codecov.io/gh/apache/superset/commit/2ebc0a078a5d402bd390626d33cd76cc707521d6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2ebc0a0) will **decrease** coverage by `0.04%`. > The diff coverage is `83.16%`. [](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15279 +/- ## == - Coverage 77.23% 77.18% -0.05% == Files 975 976 +1 Lines 5063450770 +136 Branches 6222 6222 == + Hits3910639186 +80 - Misses 1131711373 +56 Partials 211 211 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.48% <83.16%> (+0.03%)` | :arrow_up: | | mysql | `81.75% <83.16%> (+0.03%)` | :arrow_up: | | postgres | `81.76% <83.16%> (+0.03%)` | :arrow_up: | | presto | `?` | | | python | `82.14% <83.16%> (-0.13%)` | :arrow_down: | | sqlite | `81.39% <83.16%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15279?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ø> (ø)` | | | [superset/common/utils.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3V0aWxzLnB5) | `73.75% <73.75%> (ø)` | | | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `84.24% <84.61%> (-0.22%)` | :arrow_down: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `88.20% <87.30%> (+6.04%)` | :arrow_up: | | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | | | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.66% <100.00%> (+0.52%)` | :arrow_up: | | [superset/constants.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15279/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.10% <100.00%> (+0.01%)` | :arrow_up: | |
[GitHub] [superset] villebro commented on a change in pull request #15390: fix: Cascading filter popover widens automatically
villebro commented on a change in pull request #15390:
URL: https://github.com/apache/superset/pull/15390#discussion_r659489653
##
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx
##
@@ -53,28 +49,26 @@ const CascadeFilterControl:
React.FC = ({
onFilterSelectionChange,
}) => (
<>
-
-
-
-
-
-
+
+
{filter.cascadeChildren?.map(childFilter => (
-
+<>
+
Review comment:
I personally think the caret is not needed here, as it is just a static
component that occupies a fair amount of vertical space and doesn't really add
a lot of information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] lyndsiWilliams opened a new pull request #15412: style: Database Connection Modal UI Polish R5
lyndsiWilliams opened a new pull request #15412: URL: https://github.com/apache/superset/pull/15412 ### SUMMARY Implemented UI polish tasks in [Clubhouse ticket](https://app.clubhouse.io/preset/story/17847/ui-polish-r5) - Centered modal in window - Fixed inconsistent header spacing - Touched up tooltips - Added red *s to BigQuery form Extra: - Styled placeholder text in BigQuery > Service Account ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF - Centered modal, Consistent header spacing, Styled placeholder text in BigQuery > Service Account  - Red *s in BigQuery form https://user-images.githubusercontent.com/55605634/123584969-f089b900-d7a7-11eb-9cf9-a37bf33a4093.png;> https://user-images.githubusercontent.com/55605634/123584974-f2ec1300-d7a7-11eb-83ac-cf2c4ededd9b.png;> - Tooltips https://user-images.githubusercontent.com/55605634/123584618-50cc2b00-d7a7-11eb-9e0d-24b2620065bc.png;> https://user-images.githubusercontent.com/55605634/123584624-53c71b80-d7a7-11eb-9510-a5074de465aa.png;> https://user-images.githubusercontent.com/55605634/123584631-5590df00-d7a7-11eb-85d8-ea8fec223296.png;> ### TESTING INSTRUCTIONS From the Superset home page: - Hover over "Data" in the upper navigation bar - Click "Database" - Click the "+ Database" button below the navigation bar and to the right - Navigation through the database modal and observe the styling described above ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] rumbin commented on pull request #15403: feat: cancel db query on stop
rumbin commented on pull request #15403: URL: https://github.com/apache/superset/pull/15403#issuecomment-869375535 Slightly off-topic: How does the Stop button in Explore handle this situation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15412: style: Database Connection Modal UI Polish R5
codecov[bot] commented on pull request #15412: URL: https://github.com/apache/superset/pull/15412#issuecomment-869379037 # [Codecov](https://codecov.io/gh/apache/superset/pull/15412?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15412](https://codecov.io/gh/apache/superset/pull/15412?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cb4c800) into [pexdax/db-connection-ui](https://codecov.io/gh/apache/superset/commit/4db07e2fb972cf2eabfa7a77fe49626bc20a9b12?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4db07e2) will **decrease** coverage by `0.00%`. > The diff coverage is `28.57%`. [](https://codecov.io/gh/apache/superset/pull/15412?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## pexdax/db-connection-ui #15412 +/- ## === - Coverage76.73% 76.72% -0.01% === Files 972 972 Lines5063750643 +6 Branches 6275 6275 === + Hits 3885438855 +1 - Misses 1157711582 +5 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `70.75% <28.57%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15412?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/15412/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `33.64% <ø> (ø)` | | | [...c/views/CRUD/data/database/DatabaseModal/styles.ts](https://codecov.io/gh/apache/superset/pull/15412/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL3N0eWxlcy50cw==) | `43.51% <16.66%> (-2.12%)` | :arrow_down: | | [.../database/DatabaseModal/DatabaseConnectionForm.tsx](https://codecov.io/gh/apache/superset/pull/15412/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL0RhdGFiYXNlQ29ubmVjdGlvbkZvcm0udHN4) | `32.14% <100.00%> (+0.81%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15412?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15412?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [4db07e2...cb4c800](https://codecov.io/gh/apache/superset/pull/15412?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the
