"bouncing" messages
micah anderson wrote: > It would be great if this became a key to make this easier. In mutt, > that key is 'b', which prompts you who you should send the message > to. That key is already bound to showing the body in notmuch, but I'm > sure there are other options. Carl just dropped that binding, so now we can reuse 'b' to message bouncing. > > m
[notmuch] JSON based emacs UI
David Edmondson wrote: > On Sun, 28 Mar 2010 14:03:44 -0300, Fernando Carrijo yahoo.com.br> wrote: > > David Edmondson wrote: > > > 'RET' anywhere in the message is supposed to toggle visibility of the > > > message. That was not working perfectly - a little forced redisplay > > > helped (just pushed). > > > > > > Toggling the visibility of headers is done with 'h'. There's currently > > > no way to do that by pressing 'RET' somewhere. (You can also toggle the > > > body with 'b'.) > > > > I fear this is not correct. I cloned notmuch from Carl's git repository, > > and whenever I press 'RET' while the point is over the subject line, the > > result is the same as pressing 'h': the subject information gets toggled. > > Is this considered a feature that blocks people from switching to the > JSON based UI? As long as I'm concerned, no. Not at all! > > dme. > -- > David Edmondson, http://dme.org
[notmuch] JSON based emacs UI
Fernando Carrijo wrote: > David Edmondson wrote: > > 'RET' anywhere in the message is supposed to toggle visibility of the > > message. That was not working perfectly - a little forced redisplay > > helped (just pushed). > > > > Toggling the visibility of headers is done with 'h'. There's currently > > no way to do that by pressing 'RET' somewhere. (You can also toggle the > > body with 'b'.) > > I fear this is not correct. I cloned notmuch from Carl's git repository, > and whenever I press 'RET' while the point is over the subject line, the > result is the same as pressing 'h': the subject information gets toggled. > > I didn't read this whole thread, though. > Maybe you're talking about some JSON powered feature-branch? Oh, now I see that you really are. > > > > > dme. > > -- > > David Edmondson, http://dme.org >
[notmuch] JSON based emacs UI
David Edmondson wrote: > 'RET' anywhere in the message is supposed to toggle visibility of the > message. That was not working perfectly - a little forced redisplay > helped (just pushed). > > Toggling the visibility of headers is done with 'h'. There's currently > no way to do that by pressing 'RET' somewhere. (You can also toggle the > body with 'b'.) I fear this is not correct. I cloned notmuch from Carl's git repository, and whenever I press 'RET' while the point is over the subject line, the result is the same as pressing 'h': the subject information gets toggled. I didn't read this whole thread, though. Maybe you're talking about some JSON powered feature-branch? > > dme. > -- > David Edmondson, http://dme.org
Re: [notmuch] JSON based emacs UI
David Edmondson d...@dme.org wrote: 'RET' anywhere in the message is supposed to toggle visibility of the message. That was not working perfectly - a little forced redisplay helped (just pushed). Toggling the visibility of headers is done with 'h'. There's currently no way to do that by pressing 'RET' somewhere. (You can also toggle the body with 'b'.) I fear this is not correct. I cloned notmuch from Carl's git repository, and whenever I press 'RET' while the point is over the subject line, the result is the same as pressing 'h': the subject information gets toggled. I didn't read this whole thread, though. Maybe you're talking about some JSON powered feature-branch? dme. -- David Edmondson, http://dme.org ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [notmuch] JSON based emacs UI
Fernando Carrijo fcarr...@yahoo.com.br wrote: David Edmondson d...@dme.org wrote: 'RET' anywhere in the message is supposed to toggle visibility of the message. That was not working perfectly - a little forced redisplay helped (just pushed). Toggling the visibility of headers is done with 'h'. There's currently no way to do that by pressing 'RET' somewhere. (You can also toggle the body with 'b'.) I fear this is not correct. I cloned notmuch from Carl's git repository, and whenever I press 'RET' while the point is over the subject line, the result is the same as pressing 'h': the subject information gets toggled. I didn't read this whole thread, though. Maybe you're talking about some JSON powered feature-branch? Oh, now I see that you really are. dme. -- David Edmondson, http://dme.org ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[notmuch] [PATCH] Update documentation of notmuch_query_create
Carl Worth wrote: > On Sat, 05 Dec 2009 12:22:05 -0200, Fernando Carrijo yahoo.com.br> wrote: > > Commit cd467caf renamed notmuch_query_search to > > notmuch_query_search_messages. > > > > Commit 1ba3d46f created notmuch_query_search_threads. We better keep the > > docs > > of notmuch_query_create consistent with those changes. > > > > Thanks! > > I had trouble applying the patch, (perhaps you performed a copy/paste > operation into your email program that added a bunch of trailing > whitespace?). Sorry for that. At the time I sent the patch I was using, for the lack of a better euphemism, a memory unconscious mail client which used to get me distracted from those caracter conversion issues whenever I saw some other applications being shot by the OOM killer. Seriously. I won't let it happen again. > But I fixed that and while at it, edited the comment so > that the full name of each referenced function appears. (The idea being > that I want grep to find these occurrences if they need to be updated > again in the future). Yes, it makes sense. > -Carl Thank you.
[notmuch] [PATCH] Fix a few documentation typos in notmuch.h
Carl Worth wrote: > On Sat, 05 Dec 2009 17:32:34 -0200, Fernando Carrijo yahoo.com.br> wrote: > > Fix a few documentation typos in notmuch.h > > Thanks, Fernando! > > It's quite embarrassing that such a simple change could sit in my patch > queue for so long. But at least notmuch never forgot about it for me... > > -Carl (hoping to be better in the future) No worries, Carl. The good thing of being busy among busy people is that, unless you state that explicitly, they won't generally notice. :) But seriously, I'm glad you found some time to process your patch queue, and I certainly wouln't feel offended if you had chosen any other patch instead of those trivial ones of mine. Did I mention that since then notmuch became my only mail client? :)
[notmuch] [PATCH] Import CODING_STYLE from cairo
Hi Ali,
On Wed, 13 Jan 2010 15:40:42 +0200, Ali Polatel wrote:
> A good way to let new contributors know how to contribute :)
> ---
> CODING_STYLE | 291
> ++
> 1 files changed, 291 insertions(+), 0 deletions(-)
> create mode 100644 CODING_STYLE
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> new file mode 100644
> index 000..95ceac0
> --- /dev/null
> +++ b/CODING_STYLE
> @@ -0,0 +1,291 @@
> +Cairo coding style.
> +
> +This document is intended to be a short description of the preferred
> +coding style for the cairo source code. Good style requires good
> +taste, which means this can't all be reduced to automated rules, and
> +there are exceptions.
Maybe s/cairo/notmuch/ ?
> +
> +We want the code to be easy to understand and maintain, and consistent
> +style plays an important part in that, even if some of the specific
> +details seem trivial. If nothing else, this document gives a place to
> +put consistent answers for issues that would otherwise be arbitrary.
> +
> +Most of the guidelines here are demonstrated by examples, (which means
> +this document is quicker to read than it might appear given its
> +length). Most of the examples are positive examples that you should
> +imitate. The few negative examples are clearly marked with a comment
> +of /* Yuck! */. Please don't submit code to cairo that looks like any
> +of these.
> +
> +Indentation
> +---
> +Each new level is indented 4 more spaces than the previous level:
> +
> + if (condition)
> + do_something ();
> +
> +This may be achieved with space characters or a combination of tab
> +characters and space characters. It may not be achieved with tab
> +characters exclusively (see below).
> +
> +Tab characters
> +--
> +The tab character must always be interpreted according to its
> +traditional meaning:
> +
> + Advance to the next column which is a multiple of 8.
> +
> +With this definition, even levels of indentation can be achieved with
> +a sequence of tab characters, while odd levels of indentation may
> +begin with a sequence of tab character but must end with 4 space
> +characters.
> +
> +Some programmers have been misled by certain text editors into
> +thinking that 4-space indentation can be achieved with tab characters
> +exclusively by changing the meaning of tab character to be "advance to
> +the next column which is a multiple of 4". Code formatted in this way,
> +making an assumption of a fictitious 4-character-tab will not be
> +accepted into cairo.
> +
> +The rationale here is that tabs are used in the code for lining things
> +up other than indentation, (see the Whitespace section below), and
> +changing the interpretation of tab from its traditional meaning will
> +break this alignment.
> +
> +Braces
> +--
> +Most of the code in cairo uses bracing in the style of K:
> +
> + if (condition) {
> + do_this ();
> + do_that ();
> + } else {
> + do_the_other ();
> + }
> +
> +but some of the code uses an alternate style:
> +
> + if (condition)
> + {
> + do_this ();
> + do_that ();
> + }
> + else
> + {
> + do_the_other ();
> + }
> +
> +and that seems just fine. We won't lay down any strict rule on this
> +point, (though there should be some local consistency). If you came
> +here hoping to find some guidance, then use the first form above.
> +
> +If all of the substatements of an if statement are single statements,
> +the optional braces should not usually appear:
> +
> + if (condition)
> + do_this ();
> + else
> + do_that ();
> +
> +But the braces are mandatory when mixing single statement and compound
> +statements in the various clauses. For example, do not do this:
> +
> + if (condition) {
> + do_this ();
> + do_that ();
> + } else /* Yuck! */
> + do_the_other ();
> +
> +And of course, there are exceptions for when the code just looks
> +better with the braces:
> +
> + if (condition) {
> + /* Note that we have to be careful here. */
> + do_something_dangerous (with_care);
> + }
> +
> + if (condition &&
> + other_condition &&
> + yet_another)
> + {
> + do_something ();
> + }
> +
> +And note that this last example also shows a situation in which the
> +opening brace really needs to be on its own line. The following looks awful:
> +
> + if (condition &&
> + other_condition &&
> + yet_another) { /* Yuck! */
> + do_something ();
> + }
> +
> +As we said above, legible code that is easy to understand and maintain
> +is the goal, not adherence to strict rules.
> +
> +Whitespace
> +--
> +Separate logically distinct chunks with a single newline. This
> +obviously applies between functions, but also applies within a
> +function or block and can even be used to good effect within a
>
[notmuch] [RFC/PATCH] Add search-files command
i;
> +argv += i;
> +
> +config = notmuch_config_open (ctx, NULL, NULL);
> +if (config == NULL)
> + return 1;
> +
> +notmuch = notmuch_database_open (notmuch_config_get_database_path
> (config),
> + NOTMUCH_DATABASE_MODE_READ_ONLY);
> +if (notmuch == NULL)
> + return 1;
> +
> +query_str = query_string_from_args (ctx, argc, argv);
> +if (query_str == NULL) {
> + fprintf (stderr, "Out of memory.\n");
> + return 1;
> +}
> +if (*query_str == '\0') {
> + fprintf (stderr, "Error: notmuch search-files requires at least one
> search term.\n");
Could we break this line so that it did not go beyond the column limit
set by the coding conventions? Maybe we should go one step further and
import the file CODING_STYLE from cairo into notmuch's repository.
> + return 1;
> +}
> +
> +query = notmuch_query_create (notmuch, query_str);
> +if (query == NULL) {
> + fprintf (stderr, "Out of memory\n");
> + return 1;
> +}
> +
> +notmuch_query_set_sort (query, sort);
> +
> +do_search_files (query);
> +
> +notmuch_query_destroy (query);
> +notmuch_database_close (notmuch);
It is not something of major importance, but I realized that the
function notmuch_config_close is only being called when notmuch is
executed with no arguments. As we know, the kernel shall close all
open file descriptors upon program termination, but wouldn't it be
better if we did it explicitly? Or did I overlook something?
Kind regards,
Fernando Carrijo.
> +
> +return 0;
> +}
> diff --git a/notmuch.c b/notmuch.c
> index 87479f8..4907339 100644
> --- a/notmuch.c
> +++ b/notmuch.c
> @@ -165,6 +165,19 @@ command_t commands[] = {
>"\n"
>"\t\tSee \"notmuch help search-terms\" for details of the search\n"
>"\t\tterms syntax." },
> +{ "search-files", notmuch_search_files_command,
> + "[options...] [...]",
> + "\t\tSearch for filenames matching the given search terms.",
> + "\t\tSupported options for search-files include:\n"
> + "\n"
> + "\t\t--sort=(newest-first|oldest-first)\n"
> + "\n"
> + "\t\t\tPresent results in either chronological order\n"
> + "\t\t\t(oldest-first) or reverse chronological order\n"
> + "\t\t\t(newest-first), which is the default.\n"
> + "\n"
> + "\t\tSee \"notmuch help search-terms\" for details of the search\n"
> + "\t\tterms syntax." },
> { "show", notmuch_show_command,
>" [...]",
>"\t\tShow all messages matching the search terms.",
> --
> 1.6.6
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
Re: [notmuch] [RFC/PATCH] Add search-files command
term.\n);
Could we break this line so that it did not go beyond the column limit
set by the coding conventions? Maybe we should go one step further and
import the file CODING_STYLE from cairo into notmuch's repository.
+ return 1;
+}
+
+query = notmuch_query_create (notmuch, query_str);
+if (query == NULL) {
+ fprintf (stderr, Out of memory\n);
+ return 1;
+}
+
+notmuch_query_set_sort (query, sort);
+
+do_search_files (query);
+
+notmuch_query_destroy (query);
+notmuch_database_close (notmuch);
It is not something of major importance, but I realized that the
function notmuch_config_close is only being called when notmuch is
executed with no arguments. As we know, the kernel shall close all
open file descriptors upon program termination, but wouldn't it be
better if we did it explicitly? Or did I overlook something?
Kind regards,
Fernando Carrijo.
+
+return 0;
+}
diff --git a/notmuch.c b/notmuch.c
index 87479f8..4907339 100644
--- a/notmuch.c
+++ b/notmuch.c
@@ -165,6 +165,19 @@ command_t commands[] = {
\n
\t\tSee \notmuch help search-terms\ for details of the search\n
\t\tterms syntax. },
+{ search-files, notmuch_search_files_command,
+ [options...] search-terms [...],
+ \t\tSearch for filenames matching the given search terms.,
+ \t\tSupported options for search-files include:\n
+ \n
+ \t\t--sort=(newest-first|oldest-first)\n
+ \n
+ \t\t\tPresent results in either chronological order\n
+ \t\t\t(oldest-first) or reverse chronological order\n
+ \t\t\t(newest-first), which is the default.\n
+ \n
+ \t\tSee \notmuch help search-terms\ for details of the search\n
+ \t\tterms syntax. },
{ show, notmuch_show_command,
search-terms [...],
\t\tShow all messages matching the search terms.,
--
1.6.6
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
[notmuch] [PATCH] Nuke the remainings of _notmuch_message_add_thread_id.
The function _notmuch_message_add_thread_id has been removed from the private interface of notmuch. There's no reason for one to keep a declaration of its prototype in the code base. Also, lets update a commentary that referenced that function and escaped from previous scrutiny. Signed-off-by: Fernando Carrijo --- lib/database.cc |9 - lib/notmuch-private.h |4 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 23ddd4a..b6c4d07 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -855,12 +855,11 @@ _notmuch_database_link_message_to_children (notmuch_database_t *notmuch, * * We first look at 'message_file' and its link-relevant headers * (References and In-Reply-To) for message IDs. We also look in the - * database for existing message that reference 'message'.p + * database for existing message that reference 'message'. * - * The end result is to call _notmuch_message_add_thread_id with one - * or more thread IDs to which this message belongs, (including - * generating a new thread ID if necessary if the message doesn't - * connect to any existing threads). + * The end result is to call _notmuch_message_ensure_thread_id which + * generates a new thread ID if the message doesn't connect to any + * existing threads. */ static notmuch_status_t _notmuch_database_link_message (notmuch_database_t *notmuch, diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h index 0c340a7..116f63d 100644 --- a/lib/notmuch-private.h +++ b/lib/notmuch-private.h @@ -194,10 +194,6 @@ _notmuch_message_set_filename (notmuch_message_t *message, const char *filename); void -_notmuch_message_add_thread_id (notmuch_message_t *message, - const char *thread_id); - -void _notmuch_message_ensure_thread_id (notmuch_message_t *message); void -- 1.5.6.3
[notmuch] [PATCH] Nuke the remainings of _notmuch_message_add_thread_id.
The function _notmuch_message_add_thread_id has been removed from the private interface of notmuch. There's no reason for one to keep a declaration of its prototype in the code base. Also, lets update a commentary that referenced that function and escaped from previous scrutiny. Signed-off-by: Fernando Carrijo fcarr...@yahoo.com.br --- lib/database.cc |9 - lib/notmuch-private.h |4 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 23ddd4a..b6c4d07 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -855,12 +855,11 @@ _notmuch_database_link_message_to_children (notmuch_database_t *notmuch, * * We first look at 'message_file' and its link-relevant headers * (References and In-Reply-To) for message IDs. We also look in the - * database for existing message that reference 'message'.p + * database for existing message that reference 'message'. * - * The end result is to call _notmuch_message_add_thread_id with one - * or more thread IDs to which this message belongs, (including - * generating a new thread ID if necessary if the message doesn't - * connect to any existing threads). + * The end result is to call _notmuch_message_ensure_thread_id which + * generates a new thread ID if the message doesn't connect to any + * existing threads. */ static notmuch_status_t _notmuch_database_link_message (notmuch_database_t *notmuch, diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h index 0c340a7..116f63d 100644 --- a/lib/notmuch-private.h +++ b/lib/notmuch-private.h @@ -194,10 +194,6 @@ _notmuch_message_set_filename (notmuch_message_t *message, const char *filename); void -_notmuch_message_add_thread_id (notmuch_message_t *message, - const char *thread_id); - -void _notmuch_message_ensure_thread_id (notmuch_message_t *message); void -- 1.5.6.3 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[notmuch] [PATCH] Fix a few documentation typos in notmuch.h
Fix a few documentation typos in notmuch.h Signed-off-by: Fernando Carrijo --- lib/notmuch.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/notmuch.h b/lib/notmuch.h index 32ab199..873ec09 100644 --- a/lib/notmuch.h +++ b/lib/notmuch.h @@ -410,7 +410,7 @@ notmuch_query_search_messages (notmuch_query_t *query); * * This will in turn destroy any notmuch_threads_t and * notmuch_messages_t objects generated by this query, (and in - * turn any notmuch_thrad_t and notmuch_message_t objects generated + * turn any notmuch_thread_t and notmuch_message_t objects generated * from those results, etc.), if such objects haven't already been * destroyed. */ @@ -544,7 +544,7 @@ notmuch_thread_get_subject (notmuch_thread_t *thread); time_t notmuch_thread_get_oldest_date (notmuch_thread_t *thread); -/* Get the date of the oldest message in 'thread' as a time_t value. +/* Get the date of the newest message in 'thread' as a time_t value. */ time_t notmuch_thread_get_newest_date (notmuch_thread_t *thread); @@ -871,7 +871,7 @@ notmuch_message_freeze (notmuch_message_t *message); * NOTMUCH_STATUS_SUCCESS: Message successfully thawed, (or at least * its frozen count has successfully been reduced by 1). * - * NOTMUCH_STATUS_UNBALANCE_FREEZE_THAW: An attempt was made to thaw + * NOTMUCH_STATUS_UNBALANCED_FREEZE_THAW: An attempt was made to thaw * an unfrozen message. That is, there have been an unbalanced * number of calls to notmuch_message_freeze and * notmuch_message_thaw. -- 1.5.6.3
[notmuch] [PATCH] Update documentation of notmuch_query_create
Commit cd467caf renamed notmuch_query_search to notmuch_query_search_messages.
Commit 1ba3d46f created notmuch_query_search_threads. We better keep the docs
of notmuch_query_create consistent with those changes.
Signed-off-by: Fernando Carrijo
---
lib/notmuch.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/lib/notmuch.h b/lib/notmuch.h
index 60834fb..32ab199 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -305,7 +305,8 @@ notmuch_database_get_all_tags (notmuch_database_t *db);
* result in a query that returns all messages in the database.
*
* See notmuch_query_set_sort for controlling the order of results and
- * notmuch_query_search to actually execute the query.
+ * notmuch_query_search_{messages,threads} to actually execute the
+ * query.
*
* User should call notmuch_query_destroy when finished with this
* query.
--
1.5.6.3
[notmuch] [PATCH] Fix typos in documentation strings
Let's keep the line wrapping out of the party! Signed-off-by: Fernando Carrijo --- notmuch.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/notmuch.el b/notmuch.el index 65473ba..fe09d81 100644 --- a/notmuch.el +++ b/notmuch.el @@ -360,7 +360,7 @@ buffer." (notmuch-reply message-id))) (defun notmuch-show-forward-current () - "Forward a the current message." + "Forward the current message." (interactive) (with-current-notmuch-show-message (message-forward))) @@ -402,7 +402,7 @@ by searching backward)." (not (re-search-forward notmuch-show-message-begin-regexp nil t) (defun notmuch-show-message-unread-p () - "Preficate testing whether current message is unread." + "Predicate testing whether current message is unread." (member "unread" (notmuch-show-get-tags))) (defun notmuch-show-next-message () -- 1.5.6.3
[notmuch] [PATCH] Fix typos in documentation strings
One more party, one more joiner, one more patch! :) Signed-off-by: Fernando Carrijo --- notmuch.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/notmuch.el b/notmuch.el index 65473ba..fe09d81 100644 --- a/notmuch.el +++ b/notmuch.el @@ -360,7 +360,7 @@ buffer." (notmuch-reply message-id))) (defun notmuch-show-forward-current () - "Forward a the current message." + "Forward the current message." (interactive) (with-current-notmuch-show-message (message-forward))) @@ -402,7 +402,7 @@ by searching backward)." (not (re-search-forward notmuch-show-message-begin-regexp nil t) (defun notmuch-show-message-unread-p () - "Preficate testing whether current message is unread." + "Predicate testing whether current message is unread." (member "unread" (notmuch-show-get-tags))) (defun notmuch-show-next-message () -- 1.5.6.3
