[PATCH] emacs: jump: sort-order bugfix
default-value needs its argument to be quoted. --- Slightly strangely default-value of 't or nil is 't or nil respectively so the code didn't give an error but just did the wrong thing. Thanks to Jani for finding the bug. Best wishes Mark emacs/notmuch-jump.el |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index 5eb0949..0193f8c 100644 --- a/emacs/notmuch-jump.el +++ b/emacs/notmuch-jump.el @@ -51,7 +51,7 @@ (defun notmuch-jump-search () (case (plist-get saved-search :sort-order) (newest-first nil) (oldest-first t) - (otherwise (default-value notmuch-search-oldest-first) + (otherwise (default-value 'notmuch-search-oldest-first) (push (list key name `(lambda () (notmuch-search ',query ',oldest-first))) action-map) -- 1.7.10.4
Re: [PATCH] emacs: jump: sort-order bugfix
Mark Walters writes: > default-value needs its argument to be quoted. > --- Hi Mark, I really appreciate you sending in a bug fix. Thanks! I'd prefer to see the commit message describing the bug and the fix a bit. You do have some text here that would be a great addition to the commit message: > Slightly strangely default-value of 't or nil is 't or nil > respectively so the code didn't give an error but just did the wrong > thing. But even beyond that. What is the "wrong thing" that the code did here? Imagine someone (me!) trying to read and review the patch without ever encountering the bug before. How can I test the bug both before and after applying the patch? I'd really like to see that information in the commit message. Thanks, -Carl pgpkfzqsTF18i.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] emacs: jump: sort-order bugfix
default-value needs its argument to be quoted. --- Slightly strangely default-value of 't or nil is 't or nil respectively so the code didn't give an error but just did the wrong thing. Thanks to Jani for finding the bug. Best wishes Mark emacs/notmuch-jump.el |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index 5eb0949..0193f8c 100644 --- a/emacs/notmuch-jump.el +++ b/emacs/notmuch-jump.el @@ -51,7 +51,7 @@ (defun notmuch-jump-search () (case (plist-get saved-search :sort-order) (newest-first nil) (oldest-first t) - (otherwise (default-value notmuch-search-oldest-first) + (otherwise (default-value 'notmuch-search-oldest-first) (push (list key name `(lambda () (notmuch-search ',query ',oldest-first))) action-map) -- 1.7.10.4 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
