Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices
On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > > > playing around a little bit with this, I think the original "select > > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > > > drivers selecting and others depending on it. We could of course convert > > > > everything over to depend, and break those cycling dependency issues > > > > with > > > > this. > > > > > > > > Anyway this change on top of my initial patch is enough to make Kconfig > > > > happy and has the advantage of not having to mess with the deps of > > > > nouveau > > > > too much. > > > > > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > > > option itself 'default FB || DRM' though, to ensure that defconfigs > > > keep working. > > > > > > > okay cool. Will send out a proper updated patch series soonish. > > > > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now > BACKLIGHT_CLASS_DEVICE might be disabled :( Are you sure? It should already be the case that any driver that selects FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' or 'select BACKLIGHT_CLASS_DEVICE'. If you change all the 'select BACKLIGHT_CLASS_DEVICE' to 'depends on', I don't see a problem with doing 'select FB_BACKLIGHT' from those. I have applied your patch to my randconfig tree and built a few dozen kernels, don't see any regressions so far, but will let it run over night. Arnd
Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices
On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > playing around a little bit with this, I think the original "select > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > drivers selecting and others depending on it. We could of course convert > everything over to depend, and break those cycling dependency issues with > this. > > Anyway this change on top of my initial patch is enough to make Kconfig > happy and has the advantage of not having to mess with the deps of nouveau > too much. Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE option itself 'default FB || DRM' though, to ensure that defconfigs keep working. Arnd
Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices
On Thu, Aug 5, 2021 at 12:01 AM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > > > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst > > > > > wrote: > > > > > > > > > > > > playing around a little bit with this, I think the original "select > > > > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix > > > > > > of > > > > > > drivers selecting and others depending on it. We could of course > > > > > > convert > > > > > > everything over to depend, and break those cycling dependency > > > > > > issues with > > > > > > this. > > > > > > > > > > > > Anyway this change on top of my initial patch is enough to make > > > > > > Kconfig > > > > > > happy and has the advantage of not having to mess with the deps of > > > > > > nouveau > > > > > > too much. > > > > > > > > > > Looks good to me. We'd probably want to make the > > > > > BACKLIGHT_CLASS_DEVICE > > > > > option itself 'default FB || DRM' though, to ensure that defconfigs > > > > > keep working. > > > > > > > > > > > > > okay cool. Will send out a proper updated patch series soonish. > > > > > > > > > > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now > > > BACKLIGHT_CLASS_DEVICE might be disabled :( > > > > Are you sure? It should already be the case that any driver that selects > > FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' > > or 'select BACKLIGHT_CLASS_DEVICE'. > > > none of the fb drivers seem to do that. Ah, right, I see now that my randconfig series has a couple of patches applied that deal with other random failures, including this one: https://patchwork.kernel.org/project/linux-fbdev/patch/2020041713.675905-8-a...@arndb.de/ Part of the series went in (through different ways) now, but this one never did. Arnd
Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices
On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > > > > > playing around a little bit with this, I think the original "select > > > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > > > > drivers selecting and others depending on it. We could of course > > > > > convert > > > > > everything over to depend, and break those cycling dependency issues > > > > > with > > > > > this. > > > > > > > > > > Anyway this change on top of my initial patch is enough to make > > > > > Kconfig > > > > > happy and has the advantage of not having to mess with the deps of > > > > > nouveau > > > > > too much. > > > > > > > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > > > > option itself 'default FB || DRM' though, to ensure that defconfigs > > > > keep working. > > > > > > > > > > okay cool. Will send out a proper updated patch series soonish. > > > > > > > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now > > BACKLIGHT_CLASS_DEVICE might be disabled :( > > Are you sure? It should already be the case that any driver that selects > FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' > or 'select BACKLIGHT_CLASS_DEVICE'. > none of the fb drivers seem to do that. > If you change all the 'select BACKLIGHT_CLASS_DEVICE' to 'depends > on', I don't see a problem with doing 'select FB_BACKLIGHT' from > those. > > I have applied your patch to my randconfig tree and built a few dozen > kernels, don't see any regressions so far, but will let it run over night. > > Arnd >
Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices
On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > playing around a little bit with this, I think the original "select > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > > drivers selecting and others depending on it. We could of course convert > > > everything over to depend, and break those cycling dependency issues with > > > this. > > > > > > Anyway this change on top of my initial patch is enough to make Kconfig > > > happy and has the advantage of not having to mess with the deps of nouveau > > > too much. > > > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > > option itself 'default FB || DRM' though, to ensure that defconfigs > > keep working. > > > > okay cool. Will send out a proper updated patch series soonish. > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now BACKLIGHT_CLASS_DEVICE might be disabled :( somehow it doesn't feel like worth the effort converting it all over to depend.. dunno. Atm I would just use "select" in nouveau and deal with the conversion later once somebody gets annoyed enough or so... > > Arnd > >
Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices
On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > playing around a little bit with this, I think the original "select > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > drivers selecting and others depending on it. We could of course convert > > everything over to depend, and break those cycling dependency issues with > > this. > > > > Anyway this change on top of my initial patch is enough to make Kconfig > > happy and has the advantage of not having to mess with the deps of nouveau > > too much. > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > option itself 'default FB || DRM' though, to ensure that defconfigs > keep working. > okay cool. Will send out a proper updated patch series soonish. > Arnd >
[Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices
playing around a little bit with this, I think the original "select BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of drivers selecting and others depending on it. We could of course convert everything over to depend, and break those cycling dependency issues with this. Anyway this change on top of my initial patch is enough to make Kconfig happy and has the advantage of not having to mess with the deps of nouveau too much. Cc: Arnd Bergmann Cc: Lyude Paul Cc: Ben Skeggs Cc: Randy Dunlap Cc: Daniel Vetter Cc: nouveau@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/bridge/Kconfig| 2 +- drivers/gpu/drm/fsl-dcu/Kconfig | 2 +- drivers/gpu/drm/gud/Kconfig | 2 +- drivers/gpu/drm/nouveau/Kconfig | 2 +- drivers/platform/x86/Kconfig | 4 ++-- drivers/staging/olpc_dcon/Kconfig | 2 +- drivers/usb/misc/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 431b6e12a81f..dc68532ede38 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -173,9 +173,9 @@ config DRM_NXP_PTN3460 config DRM_PARADE_PS8622 tristate "Parade eDP/LVDS bridge" depends on OF + depends on BACKLIGHT_CLASS_DEVICE select DRM_PANEL select DRM_KMS_HELPER - select BACKLIGHT_CLASS_DEVICE help Parade eDP-LVDS bridge chip driver. diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig index d7dd8ba90e3a..79bfd7e6f6dc 100644 --- a/drivers/gpu/drm/fsl-dcu/Kconfig +++ b/drivers/gpu/drm/fsl-dcu/Kconfig @@ -2,7 +2,7 @@ config DRM_FSL_DCU tristate "DRM Support for Freescale DCU" depends on DRM && OF && ARM && COMMON_CLK - select BACKLIGHT_CLASS_DEVICE + depends on BACKLIGHT_CLASS_DEVICE select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER select DRM_PANEL diff --git a/drivers/gpu/drm/gud/Kconfig b/drivers/gpu/drm/gud/Kconfig index 1c8601bf4d91..91a118928af7 100644 --- a/drivers/gpu/drm/gud/Kconfig +++ b/drivers/gpu/drm/gud/Kconfig @@ -3,10 +3,10 @@ config DRM_GUD tristate "GUD USB Display" depends on DRM && USB + depends on BACKLIGHT_CLASS_DEVICE select LZ4_COMPRESS select DRM_KMS_HELPER select DRM_GEM_SHMEM_HELPER - select BACKLIGHT_CLASS_DEVICE help This is a DRM display driver for GUD USB Displays or display adapters. diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig index 2e159b0ea7fb..afb3eede8e2b 100644 --- a/drivers/gpu/drm/nouveau/Kconfig +++ b/drivers/gpu/drm/nouveau/Kconfig @@ -2,12 +2,12 @@ config DRM_NOUVEAU tristate "Nouveau (NVIDIA) cards" depends on DRM && PCI && MMU + depends on BACKLIGHT_CLASS_DEVICE select IOMMU_API select FW_LOADER select DRM_KMS_HELPER select DRM_TTM select DRM_TTM_HELPER - select BACKLIGHT_CLASS_DEVICE select ACPI_VIDEO if ACPI && X86 && INPUT select X86_PLATFORM_DEVICES if ACPI && X86 select ACPI_WMI if ACPI && X86 diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 7d385c3b2239..278368985fb2 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -838,7 +838,7 @@ config SAMSUNG_LAPTOP config SAMSUNG_Q10 tristate "Samsung Q10 Extras" depends on ACPI - select BACKLIGHT_CLASS_DEVICE + depends on BACKLIGHT_CLASS_DEVICE help This driver provides support for backlight control on Samsung Q10 and related laptops, including Dell Latitude X200. @@ -935,7 +935,7 @@ config ACPI_CMPC tristate "CMPC Laptop Extras" depends on ACPI && INPUT depends on RFKILL || RFKILL=n - select BACKLIGHT_CLASS_DEVICE + depends on BACKLIGHT_CLASS_DEVICE help Support for Intel Classmate PC ACPI devices, including some keys as input device, backlight device, tablet and accelerometer diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig index d1a0dea09ef0..a9f36538d7ab 100644 --- a/drivers/staging/olpc_dcon/Kconfig +++ b/drivers/staging/olpc_dcon/Kconfig @@ -4,7 +4,7 @@ config FB_OLPC_DCON depends on OLPC && FB depends on I2C depends on GPIO_CS5535 && ACPI - select BACKLIGHT_CLASS_DEVICE + depends on BACKLIGHT_CLASS_DEVICE help In order to support very low power operation, the XO laptop uses a secondary Display CONtroller, or DCON. This secondary controller diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig index 8f1144359012..6f769a1616f0 100644 --- a/drivers/usb/misc/Kconfig +++ b/drivers/usb/misc/Kconfig @@ -132,7 +132,7 @@ config USB_FTDI_ELAN config USB_APPLEDISPLAY tristate
