Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-24 Thread Emil Velikov 
On 24 August 2016 at 13:11, Martin Peres  wrote:
> On 23/08/16 17:43, Emil Velikov wrote:
>>
>> On 23 August 2016 at 00:42, Martin Peres  wrote:
>>>
>>> v2:
>>>   - guard LED framework calls with ifdef CONFIG_LEDS_CLASS
>>>
>> IIRC kernel has the tendency of using static inlines in the headers
>> when CONFIG_foo is not set. Worth using that and removing the ifdef
>> from the source file ?
>
>
> Oh, you mean, re-defining the functions I use but make them do nothing.
>
> However, I should do it in the source file and not in the header since I do
> not want to export these symbols outside of the object.
>
Afaics they're used in nouveau_drm.c outside the object, which is why
I suggested it.

> Do you have an example to share? Anyway, this seems like a good
> candidate to reduce the number of ifdefs. Thanks!
>
Others have provided with a link, but here is an inline example:

cat nouveau_led.h
...

#ifdef CONFIG_LEDS_CLASS
int  nouveau_led_init(struct drm_device *dev);
void nouveau_led_suspend(struct drm_device *dev);
void nouveau_led_resume(struct drm_device *dev);
void nouveau_led_fini(struct drm_device *dev);
#else
static inline int  nouveau_led_init(struct drm_device *dev) { return 0; };
static inline ...
...
#endif /* CONFIG_LEDS_CLASS */


-Emil
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-24 Thread Karol Herbst 
https://www.kernel.org/doc/Documentation/CodingStyle

"Chapter 20: Conditional Compilation" ;)

2016-08-24 14:11 GMT+02:00 Martin Peres :
> On 23/08/16 17:43, Emil Velikov wrote:
>>
>> On 23 August 2016 at 00:42, Martin Peres  wrote:
>>>
>>> v2:
>>>   - guard LED framework calls with ifdef CONFIG_LEDS_CLASS
>>>
>> IIRC kernel has the tendency of using static inlines in the headers
>> when CONFIG_foo is not set. Worth using that and removing the ifdef
>> from the source file ?
>
>
> Oh, you mean, re-defining the functions I use but make them do nothing.
>
> However, I should do it in the source file and not in the header since I do
> not want to export these symbols outside of the object.
>
> Do you have an example to share? Anyway, this seems like a good
> candidate to reduce the number of ifdefs. Thanks!
>
> Martin
> ___
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-24 Thread Lukas Wunner 
On Wed, Aug 24, 2016 at 03:11:12PM +0300, Martin Peres wrote:
> On 23/08/16 17:43, Emil Velikov wrote:
> > On 23 August 2016 at 00:42, Martin Peres  wrote:
> > > v2:
> > >   - guard LED framework calls with ifdef CONFIG_LEDS_CLASS
> > > 
> > IIRC kernel has the tendency of using static inlines in the headers
> > when CONFIG_foo is not set. Worth using that and removing the ifdef
> > from the source file ?
> 
> Oh, you mean, re-defining the functions I use but make them do nothing.
> 
> However, I should do it in the source file and not in the header since I do
> not want to export these symbols outside of the object.
> 
> Do you have an example to share? Anyway, this seems like a good
> candidate to reduce the number of ifdefs. Thanks!

See Documentation/CodingStyle, "Chapter 20: Conditional Compilation".
Plenty examples are in include/linux/.

Best regards,

Lukas
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-24 Thread Martin Peres 

On 23/08/16 17:43, Emil Velikov wrote:

On 23 August 2016 at 00:42, Martin Peres  wrote:

v2:
  - guard LED framework calls with ifdef CONFIG_LEDS_CLASS


IIRC kernel has the tendency of using static inlines in the headers
when CONFIG_foo is not set. Worth using that and removing the ifdef
from the source file ?


Oh, you mean, re-defining the functions I use but make them do nothing.

However, I should do it in the source file and not in the header since I do
not want to export these symbols outside of the object.

Do you have an example to share? Anyway, this seems like a good
candidate to reduce the number of ifdefs. Thanks!

Martin
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Emil Velikov 
On 23 August 2016 at 00:42, Martin Peres  wrote:
> v2:
>  - guard LED framework calls with ifdef CONFIG_LEDS_CLASS
>
IIRC kernel has the tendency of using static inlines in the headers
when CONFIG_foo is not set. Worth using that and removing the ifdef
from the source file ?

-Emil
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Karol Herbst 
2016-08-23 16:06 GMT+02:00 Martin Peres :
> On 23/08/16 11:31, Karol Herbst wrote:
>>
>> maybe it makes sense to expose the SLI LED, too.
>>
>> Regardless of my comments this patch is reviewed-by me.
>
>
> You reviewed the wrong patch, I should have named the re-send v3.
>
> I accidentally sent the v1 patch as a v2 :s
>

yeah, mailman was stupid today. I got your new version way too late.
rby still valid though.

>>
>> 2016-08-23 1:39 GMT+02:00 Martin Peres :
>>>
>>> We received a donation of a Titan which has this useless feature
>>> allowing users to control the brightness of the LED behind the
>>> logo of NVIDIA. In the true spirit of open source, let's expose
>>> that to the users of very expensive cards!
>>>
>>> This patch hooks up this LED/PWM to the LED subsystem which allows
>>> blinking it in sync with cpu/disk/network/whatever activity (heartbeat
>>> is quite nice!). Users may also implement some breathing effect or
>>> morse code support in the userspace if they feel like it.
>>>
>>> Signed-off-by: Martin Peres 
>>> ---
>>>   drm/nouveau/Kbuild  |   1 +
>>>   drm/nouveau/include/nvkm/subdev/bios/gpio.h |   1 +
>>>   drm/nouveau/nouveau_drm.c   |   7 ++
>>>   drm/nouveau/nouveau_drm.h   |   3 +
>>>   drm/nouveau/nouveau_led.c   | 131
>>> 
>>>   drm/nouveau/nouveau_led.h   |  48 ++
>>>   6 files changed, 191 insertions(+)
>>>   create mode 100644 drm/nouveau/nouveau_led.c
>>>   create mode 100644 drm/nouveau/nouveau_led.h
>>>
>>> diff --git a/drm/nouveau/Kbuild b/drm/nouveau/Kbuild
>>> index 2527bf4..312bca9 100644
>>> --- a/drm/nouveau/Kbuild
>>> +++ b/drm/nouveau/Kbuild
>>> @@ -22,6 +22,7 @@ nouveau-$(CONFIG_DEBUG_FS) += nouveau_debugfs.o
>>>   nouveau-y += nouveau_drm.o
>>>   nouveau-y += nouveau_hwmon.o
>>>   nouveau-$(CONFIG_COMPAT) += nouveau_ioc32.o
>>> +nouveau-y += nouveau_led.o
>>>   nouveau-y += nouveau_nvif.o
>>>   nouveau-$(CONFIG_NOUVEAU_PLATFORM_DRIVER) += nouveau_platform.o
>>>   nouveau-y += nouveau_usif.o # userspace <-> nvif
>>> diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h
>>> b/drm/nouveau/include/nvkm/subdev/bios/gpio.h
>>> index a47d46d..b7a54e6 100644
>>> --- a/drm/nouveau/include/nvkm/subdev/bios/gpio.h
>>> +++ b/drm/nouveau/include/nvkm/subdev/bios/gpio.h
>>> @@ -6,6 +6,7 @@ enum dcb_gpio_func_name {
>>>  DCB_GPIO_TVDAC1 = 0x2d,
>>>  DCB_GPIO_FAN = 0x09,
>>>  DCB_GPIO_FAN_SENSE = 0x3d,
>>> +   DCB_GPIO_LOGO_LED_PWM = 0x84,
>>>  DCB_GPIO_UNUSED = 0xff,
>>>  DCB_GPIO_VID0 = 0x04,
>>>  DCB_GPIO_VID1 = 0x05,
>>> diff --git a/drm/nouveau/nouveau_drm.c b/drm/nouveau/nouveau_drm.c
>>> index d06877d..dc97401 100644
>>> --- a/drm/nouveau/nouveau_drm.c
>>> +++ b/drm/nouveau/nouveau_drm.c
>>> @@ -49,6 +49,7 @@
>>>   #include "nouveau_ttm.h"
>>>   #include "nouveau_gem.h"
>>>   #include "nouveau_vga.h"
>>> +#include "nouveau_led.h"
>>>   #include "nouveau_hwmon.h"
>>>   #include "nouveau_acpi.h"
>>>   #include "nouveau_bios.h"
>>> @@ -468,6 +469,7 @@ nouveau_drm_load(struct drm_device *dev, unsigned
>>> long flags)
>>>  nouveau_hwmon_init(dev);
>>>  nouveau_accel_init(drm);
>>>  nouveau_fbcon_init(dev);
>>> +   nouveau_led_init(dev);
>>>
>>>  if (nouveau_runtime_pm != 0) {
>>>  pm_runtime_use_autosuspend(dev->dev);
>>> @@ -499,6 +501,7 @@ nouveau_drm_unload(struct drm_device *dev)
>>>  struct nouveau_drm *drm = nouveau_drm(dev);
>>>
>>>  pm_runtime_get_sync(dev->dev);
>>> +   nouveau_led_fini(dev);
>>>  nouveau_fbcon_fini(dev);
>>>  nouveau_accel_fini(drm);
>>>  nouveau_hwmon_fini(dev);
>>> @@ -550,6 +553,8 @@ nouveau_do_suspend(struct drm_device *dev, bool
>>> runtime)
>>>  struct nouveau_cli *cli;
>>>  int ret;
>>>
>>> +   nouveau_led_suspend(dev);
>>> +
>>>  if (dev->mode_config.num_crtc) {
>>>  NV_INFO(drm, "suspending console...\n");
>>>  nouveau_fbcon_set_suspend(dev, 1);
>>> @@ -638,6 +643,8 @@ nouveau_do_resume(struct drm_device *dev, bool
>>> runtime)
>>>  nouveau_fbcon_set_suspend(dev, 0);
>>>  }
>>>
>>> +   nouveau_led_resume(dev);
>>> +
>>>  return 0;
>>>   }
>>>
>>> diff --git a/drm/nouveau/nouveau_drm.h b/drm/nouveau/nouveau_drm.h
>>> index 5c363ed..b148dcb 100644
>>> --- a/drm/nouveau/nouveau_drm.h
>>> +++ b/drm/nouveau/nouveau_drm.h
>>> @@ -166,6 +166,9 @@ struct nouveau_drm {
>>>  struct nouveau_hwmon *hwmon;
>>>  struct nouveau_debugfs *debugfs;
>>>
>>> +   /* led management */
>>> +   struct nouveau_led *led;
>>> +
>>>  /* display power reference */
>>>  bool have_disp_power_ref;
>>>
>>> diff --git a/drm/nouveau/nouveau_led.c b/drm/nouveau/nouveau_led.c
>>> new file mode 100644
>>> index

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Martin Peres 

On 23/08/16 11:31, Karol Herbst wrote:

maybe it makes sense to expose the SLI LED, too.

Regardless of my comments this patch is reviewed-by me.


You reviewed the wrong patch, I should have named the re-send v3.

I accidentally sent the v1 patch as a v2 :s



2016-08-23 1:39 GMT+02:00 Martin Peres :

We received a donation of a Titan which has this useless feature
allowing users to control the brightness of the LED behind the
logo of NVIDIA. In the true spirit of open source, let's expose
that to the users of very expensive cards!

This patch hooks up this LED/PWM to the LED subsystem which allows
blinking it in sync with cpu/disk/network/whatever activity (heartbeat
is quite nice!). Users may also implement some breathing effect or
morse code support in the userspace if they feel like it.

Signed-off-by: Martin Peres 
---
  drm/nouveau/Kbuild  |   1 +
  drm/nouveau/include/nvkm/subdev/bios/gpio.h |   1 +
  drm/nouveau/nouveau_drm.c   |   7 ++
  drm/nouveau/nouveau_drm.h   |   3 +
  drm/nouveau/nouveau_led.c   | 131 
  drm/nouveau/nouveau_led.h   |  48 ++
  6 files changed, 191 insertions(+)
  create mode 100644 drm/nouveau/nouveau_led.c
  create mode 100644 drm/nouveau/nouveau_led.h

diff --git a/drm/nouveau/Kbuild b/drm/nouveau/Kbuild
index 2527bf4..312bca9 100644
--- a/drm/nouveau/Kbuild
+++ b/drm/nouveau/Kbuild
@@ -22,6 +22,7 @@ nouveau-$(CONFIG_DEBUG_FS) += nouveau_debugfs.o
  nouveau-y += nouveau_drm.o
  nouveau-y += nouveau_hwmon.o
  nouveau-$(CONFIG_COMPAT) += nouveau_ioc32.o
+nouveau-y += nouveau_led.o
  nouveau-y += nouveau_nvif.o
  nouveau-$(CONFIG_NOUVEAU_PLATFORM_DRIVER) += nouveau_platform.o
  nouveau-y += nouveau_usif.o # userspace <-> nvif
diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h 
b/drm/nouveau/include/nvkm/subdev/bios/gpio.h
index a47d46d..b7a54e6 100644
--- a/drm/nouveau/include/nvkm/subdev/bios/gpio.h
+++ b/drm/nouveau/include/nvkm/subdev/bios/gpio.h
@@ -6,6 +6,7 @@ enum dcb_gpio_func_name {
 DCB_GPIO_TVDAC1 = 0x2d,
 DCB_GPIO_FAN = 0x09,
 DCB_GPIO_FAN_SENSE = 0x3d,
+   DCB_GPIO_LOGO_LED_PWM = 0x84,
 DCB_GPIO_UNUSED = 0xff,
 DCB_GPIO_VID0 = 0x04,
 DCB_GPIO_VID1 = 0x05,
diff --git a/drm/nouveau/nouveau_drm.c b/drm/nouveau/nouveau_drm.c
index d06877d..dc97401 100644
--- a/drm/nouveau/nouveau_drm.c
+++ b/drm/nouveau/nouveau_drm.c
@@ -49,6 +49,7 @@
  #include "nouveau_ttm.h"
  #include "nouveau_gem.h"
  #include "nouveau_vga.h"
+#include "nouveau_led.h"
  #include "nouveau_hwmon.h"
  #include "nouveau_acpi.h"
  #include "nouveau_bios.h"
@@ -468,6 +469,7 @@ nouveau_drm_load(struct drm_device *dev, unsigned long 
flags)
 nouveau_hwmon_init(dev);
 nouveau_accel_init(drm);
 nouveau_fbcon_init(dev);
+   nouveau_led_init(dev);

 if (nouveau_runtime_pm != 0) {
 pm_runtime_use_autosuspend(dev->dev);
@@ -499,6 +501,7 @@ nouveau_drm_unload(struct drm_device *dev)
 struct nouveau_drm *drm = nouveau_drm(dev);

 pm_runtime_get_sync(dev->dev);
+   nouveau_led_fini(dev);
 nouveau_fbcon_fini(dev);
 nouveau_accel_fini(drm);
 nouveau_hwmon_fini(dev);
@@ -550,6 +553,8 @@ nouveau_do_suspend(struct drm_device *dev, bool runtime)
 struct nouveau_cli *cli;
 int ret;

+   nouveau_led_suspend(dev);
+
 if (dev->mode_config.num_crtc) {
 NV_INFO(drm, "suspending console...\n");
 nouveau_fbcon_set_suspend(dev, 1);
@@ -638,6 +643,8 @@ nouveau_do_resume(struct drm_device *dev, bool runtime)
 nouveau_fbcon_set_suspend(dev, 0);
 }

+   nouveau_led_resume(dev);
+
 return 0;
  }

diff --git a/drm/nouveau/nouveau_drm.h b/drm/nouveau/nouveau_drm.h
index 5c363ed..b148dcb 100644
--- a/drm/nouveau/nouveau_drm.h
+++ b/drm/nouveau/nouveau_drm.h
@@ -166,6 +166,9 @@ struct nouveau_drm {
 struct nouveau_hwmon *hwmon;
 struct nouveau_debugfs *debugfs;

+   /* led management */
+   struct nouveau_led *led;
+
 /* display power reference */
 bool have_disp_power_ref;

diff --git a/drm/nouveau/nouveau_led.c b/drm/nouveau/nouveau_led.c
new file mode 100644
index 000..3f23ff6
--- /dev/null
+++ b/drm/nouveau/nouveau_led.c
@@ -0,0 +1,131 @@
+/*
+ * Copyright (C) 2016 Martin Peres
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * "Software"), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ *
+ * The above copyright notice and this

[Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Martin Peres 
v2:
 - guard LED framework calls with ifdef CONFIG_LEDS_CLASS

Signed-off-by: Martin Peres 
---

For real this time! Sorry for the noise

 drm/nouveau/Kbuild  |   1 +
 drm/nouveau/include/nvkm/subdev/bios/gpio.h |   1 +
 drm/nouveau/nouveau_drm.c   |   7 ++
 drm/nouveau/nouveau_drv.h   |   3 +
 drm/nouveau/nouveau_led.c   | 140 
 drm/nouveau/nouveau_led.h   |  48 ++
 6 files changed, 200 insertions(+)
 create mode 100644 drm/nouveau/nouveau_led.c
 create mode 100644 drm/nouveau/nouveau_led.h

diff --git a/drm/nouveau/Kbuild b/drm/nouveau/Kbuild
index 2527bf4..312bca9 100644
--- a/drm/nouveau/Kbuild
+++ b/drm/nouveau/Kbuild
@@ -22,6 +22,7 @@ nouveau-$(CONFIG_DEBUG_FS) += nouveau_debugfs.o
 nouveau-y += nouveau_drm.o
 nouveau-y += nouveau_hwmon.o
 nouveau-$(CONFIG_COMPAT) += nouveau_ioc32.o
+nouveau-y += nouveau_led.o
 nouveau-y += nouveau_nvif.o
 nouveau-$(CONFIG_NOUVEAU_PLATFORM_DRIVER) += nouveau_platform.o
 nouveau-y += nouveau_usif.o # userspace <-> nvif
diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h 
b/drm/nouveau/include/nvkm/subdev/bios/gpio.h
index a47d46d..b7a54e6 100644
--- a/drm/nouveau/include/nvkm/subdev/bios/gpio.h
+++ b/drm/nouveau/include/nvkm/subdev/bios/gpio.h
@@ -6,6 +6,7 @@ enum dcb_gpio_func_name {
DCB_GPIO_TVDAC1 = 0x2d,
DCB_GPIO_FAN = 0x09,
DCB_GPIO_FAN_SENSE = 0x3d,
+   DCB_GPIO_LOGO_LED_PWM = 0x84,
DCB_GPIO_UNUSED = 0xff,
DCB_GPIO_VID0 = 0x04,
DCB_GPIO_VID1 = 0x05,
diff --git a/drm/nouveau/nouveau_drm.c b/drm/nouveau/nouveau_drm.c
index 66c1280..0f16652 100644
--- a/drm/nouveau/nouveau_drm.c
+++ b/drm/nouveau/nouveau_drm.c
@@ -47,6 +47,7 @@
 #include "nouveau_ttm.h"
 #include "nouveau_gem.h"
 #include "nouveau_vga.h"
+#include "nouveau_led.h"
 #include "nouveau_hwmon.h"
 #include "nouveau_acpi.h"
 #include "nouveau_bios.h"
@@ -475,6 +476,7 @@ nouveau_drm_load(struct drm_device *dev, unsigned long 
flags)
nouveau_hwmon_init(dev);
nouveau_accel_init(drm);
nouveau_fbcon_init(dev);
+   nouveau_led_init(dev);
 
if (nouveau_runtime_pm != 0) {
pm_runtime_use_autosuspend(dev->dev);
@@ -510,6 +512,7 @@ nouveau_drm_unload(struct drm_device *dev)
pm_runtime_forbid(dev->dev);
}
 
+   nouveau_led_fini(dev);
nouveau_fbcon_fini(dev);
nouveau_accel_fini(drm);
nouveau_hwmon_fini(dev);
@@ -561,6 +564,8 @@ nouveau_do_suspend(struct drm_device *dev, bool runtime)
struct nouveau_cli *cli;
int ret;
 
+   nouveau_led_suspend(dev);
+
if (dev->mode_config.num_crtc) {
NV_INFO(drm, "suspending console...\n");
nouveau_fbcon_set_suspend(dev, 1);
@@ -649,6 +654,8 @@ nouveau_do_resume(struct drm_device *dev, bool runtime)
nouveau_fbcon_set_suspend(dev, 0);
}
 
+   nouveau_led_resume(dev);
+
return 0;
 }
 
diff --git a/drm/nouveau/nouveau_drv.h b/drm/nouveau/nouveau_drv.h
index 822a021..c0e2b32 100644
--- a/drm/nouveau/nouveau_drv.h
+++ b/drm/nouveau/nouveau_drv.h
@@ -166,6 +166,9 @@ struct nouveau_drm {
struct nouveau_hwmon *hwmon;
struct nouveau_debugfs *debugfs;
 
+   /* led management */
+   struct nouveau_led *led;
+
/* display power reference */
bool have_disp_power_ref;
 
diff --git a/drm/nouveau/nouveau_led.c b/drm/nouveau/nouveau_led.c
new file mode 100644
index 000..5c19efe
--- /dev/null
+++ b/drm/nouveau/nouveau_led.c
@@ -0,0 +1,140 @@
+/*
+ * Copyright (C) 2016 Martin Peres
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * "Software"), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the
+ * next paragraph) shall be included in all copies or substantial
+ * portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+ * IN NO EVENT SHALL THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE
+ * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+ * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+ * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ *
+ */
+
+/*
+ * Authors:
+ *  Martin Peres 
+ */
+
+#include 
+
+#include "nouveau_led.h"
+#include 
+
+#ifdef CONFIG_LEDS_CLASS
+static enum

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Karol Herbst 
maybe it makes sense to expose the SLI LED, too.

Regardless of my comments this patch is reviewed-by me.

2016-08-23 1:39 GMT+02:00 Martin Peres :
> We received a donation of a Titan which has this useless feature
> allowing users to control the brightness of the LED behind the
> logo of NVIDIA. In the true spirit of open source, let's expose
> that to the users of very expensive cards!
>
> This patch hooks up this LED/PWM to the LED subsystem which allows
> blinking it in sync with cpu/disk/network/whatever activity (heartbeat
> is quite nice!). Users may also implement some breathing effect or
> morse code support in the userspace if they feel like it.
>
> Signed-off-by: Martin Peres 
> ---
>  drm/nouveau/Kbuild  |   1 +
>  drm/nouveau/include/nvkm/subdev/bios/gpio.h |   1 +
>  drm/nouveau/nouveau_drm.c   |   7 ++
>  drm/nouveau/nouveau_drm.h   |   3 +
>  drm/nouveau/nouveau_led.c   | 131 
> 
>  drm/nouveau/nouveau_led.h   |  48 ++
>  6 files changed, 191 insertions(+)
>  create mode 100644 drm/nouveau/nouveau_led.c
>  create mode 100644 drm/nouveau/nouveau_led.h
>
> diff --git a/drm/nouveau/Kbuild b/drm/nouveau/Kbuild
> index 2527bf4..312bca9 100644
> --- a/drm/nouveau/Kbuild
> +++ b/drm/nouveau/Kbuild
> @@ -22,6 +22,7 @@ nouveau-$(CONFIG_DEBUG_FS) += nouveau_debugfs.o
>  nouveau-y += nouveau_drm.o
>  nouveau-y += nouveau_hwmon.o
>  nouveau-$(CONFIG_COMPAT) += nouveau_ioc32.o
> +nouveau-y += nouveau_led.o
>  nouveau-y += nouveau_nvif.o
>  nouveau-$(CONFIG_NOUVEAU_PLATFORM_DRIVER) += nouveau_platform.o
>  nouveau-y += nouveau_usif.o # userspace <-> nvif
> diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h 
> b/drm/nouveau/include/nvkm/subdev/bios/gpio.h
> index a47d46d..b7a54e6 100644
> --- a/drm/nouveau/include/nvkm/subdev/bios/gpio.h
> +++ b/drm/nouveau/include/nvkm/subdev/bios/gpio.h
> @@ -6,6 +6,7 @@ enum dcb_gpio_func_name {
> DCB_GPIO_TVDAC1 = 0x2d,
> DCB_GPIO_FAN = 0x09,
> DCB_GPIO_FAN_SENSE = 0x3d,
> +   DCB_GPIO_LOGO_LED_PWM = 0x84,
> DCB_GPIO_UNUSED = 0xff,
> DCB_GPIO_VID0 = 0x04,
> DCB_GPIO_VID1 = 0x05,
> diff --git a/drm/nouveau/nouveau_drm.c b/drm/nouveau/nouveau_drm.c
> index d06877d..dc97401 100644
> --- a/drm/nouveau/nouveau_drm.c
> +++ b/drm/nouveau/nouveau_drm.c
> @@ -49,6 +49,7 @@
>  #include "nouveau_ttm.h"
>  #include "nouveau_gem.h"
>  #include "nouveau_vga.h"
> +#include "nouveau_led.h"
>  #include "nouveau_hwmon.h"
>  #include "nouveau_acpi.h"
>  #include "nouveau_bios.h"
> @@ -468,6 +469,7 @@ nouveau_drm_load(struct drm_device *dev, unsigned long 
> flags)
> nouveau_hwmon_init(dev);
> nouveau_accel_init(drm);
> nouveau_fbcon_init(dev);
> +   nouveau_led_init(dev);
>
> if (nouveau_runtime_pm != 0) {
> pm_runtime_use_autosuspend(dev->dev);
> @@ -499,6 +501,7 @@ nouveau_drm_unload(struct drm_device *dev)
> struct nouveau_drm *drm = nouveau_drm(dev);
>
> pm_runtime_get_sync(dev->dev);
> +   nouveau_led_fini(dev);
> nouveau_fbcon_fini(dev);
> nouveau_accel_fini(drm);
> nouveau_hwmon_fini(dev);
> @@ -550,6 +553,8 @@ nouveau_do_suspend(struct drm_device *dev, bool runtime)
> struct nouveau_cli *cli;
> int ret;
>
> +   nouveau_led_suspend(dev);
> +
> if (dev->mode_config.num_crtc) {
> NV_INFO(drm, "suspending console...\n");
> nouveau_fbcon_set_suspend(dev, 1);
> @@ -638,6 +643,8 @@ nouveau_do_resume(struct drm_device *dev, bool runtime)
> nouveau_fbcon_set_suspend(dev, 0);
> }
>
> +   nouveau_led_resume(dev);
> +
> return 0;
>  }
>
> diff --git a/drm/nouveau/nouveau_drm.h b/drm/nouveau/nouveau_drm.h
> index 5c363ed..b148dcb 100644
> --- a/drm/nouveau/nouveau_drm.h
> +++ b/drm/nouveau/nouveau_drm.h
> @@ -166,6 +166,9 @@ struct nouveau_drm {
> struct nouveau_hwmon *hwmon;
> struct nouveau_debugfs *debugfs;
>
> +   /* led management */
> +   struct nouveau_led *led;
> +
> /* display power reference */
> bool have_disp_power_ref;
>
> diff --git a/drm/nouveau/nouveau_led.c b/drm/nouveau/nouveau_led.c
> new file mode 100644
> index 000..3f23ff6
> --- /dev/null
> +++ b/drm/nouveau/nouveau_led.c
> @@ -0,0 +1,131 @@
> +/*
> + * Copyright (C) 2016 Martin Peres
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining
> + * a copy of this software and associated documentation files (the
> + * "Software"), to deal in the Software without restriction, including
> + * without limitation the rights to use, copy, modify, merge, publish,
> + * distribute, sublicense, and/or sell copies of the Software, and to
> + * permit persons to whom the Software is furnished to do so, subject to
> + * the following conditions:
> + *
> +