Re: [nox-dev] Nox destiny aborts when printing stats
Hi KK,
Thanks for getting back to me. The problem only appears in the destiny
branch, I tried it again in the 0.6 version and the log message is
printed normally, is this the expected behavior for the destiny branch?
--niky
kk yap wrote:
Hi Niky,
I believe this is because vlog does not support very long string. The
correct patch (IMHO) is to truncate messages that are too long.
Unfortunately, I cannot get to a patch until later. If anyone send us
a patch, one of us can push it. Else, we will try to get to it.
Thanks.
Regards
KK
2010/8/30 Niky Riga nr...@bbn.com:
Hi,
I have recently ported my code from nox version 0.6 to nox destiny. I have
checked out the head of the destiny branch some time last week.
When a new datapath joins, I log the stats for debugging reasons. In nox
destiny this causes a crash.
The last command that is executed in my python module is :
logger.info('stats for switch : %s' % str(stats))
The abort message is attached.
Thanks,
niky
___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
Re: [nox-dev] Nox destiny aborts when printing stats
This is a destiny-specific bug and was introduced in commit
58547d74330eb0511cdddbbeb4f3017278a50d53.
I am not set up for commits here, but I've attached a patch. I think there are
actually a number of improvements that could be made to the socket-based
logging, but that's a project for another day. At least this stops it from
crashing.
KK, if you commit it, I suggest the log message:
Truncate long log messages when writing to logging socket.
(If you don't, I'll commit it when I get back to California.)
-- Murphy
fix_log.patch
Description: Binary data
On Aug 31, 2010, at 1:51 AM, kk yap wrote:
Hi Niky,
This is not an expected behavior. What str(stats) JSON or XML in NOX
0.6? I had problem with long log messages a while ago, but did not
check if the previous version of NOX is okay with it.
In this case, you would need to provide a more precise and simple way
for us to replicate the bug before we can go ahead to hack it out of
NOX. Could you do that? Many thanks.
Regards
KK
On 31 August 2010 00:44, Niky Riga nr...@bbn.com wrote:
Hi KK,
Thanks for getting back to me. The problem only appears in the destiny
branch, I tried it again in the 0.6 version and the log message is printed
normally, is this the expected behavior for the destiny branch?
--niky
kk yap wrote:
Hi Niky,
I believe this is because vlog does not support very long string. The
correct patch (IMHO) is to truncate messages that are too long.
Unfortunately, I cannot get to a patch until later. If anyone send us
a patch, one of us can push it. Else, we will try to get to it.
Thanks.
Regards
KK
2010/8/30 Niky Riga nr...@bbn.com:
Hi,
I have recently ported my code from nox version 0.6 to nox destiny. I
have
checked out the head of the destiny branch some time last week.
When a new datapath joins, I log the stats for debugging reasons. In nox
destiny this causes a crash.
The last command that is executed in my python module is :
logger.info('stats for switch : %s' % str(stats))
The abort message is attached.
Thanks,
niky
___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
Re: [nox-dev] Nox destiny aborts when printing stats
That's right - this sends log messages to the gui, but since there's no gui
in destiny yet anyway I just commented it out for now
Should be ok now
On Tue, Aug 31, 2010 at 8:15 PM, James Murphy McCauley jam...@nau.eduwrote:
This is a destiny-specific bug and was introduced in commit
58547d74330eb0511cdddbbeb4f3017278a50d53.
I am not set up for commits here, but I've attached a patch. I think there
are actually a number of improvements that could be made to the socket-based
logging, but that's a project for another day. At least this stops it from
crashing.
KK, if you commit it, I suggest the log message:
Truncate long log messages when writing to logging socket.
(If you don't, I'll commit it when I get back to California.)
-- Murphy
On Aug 31, 2010, at 1:51 AM, kk yap wrote:
Hi Niky,
This is not an expected behavior. What str(stats) JSON or XML in NOX
0.6? I had problem with long log messages a while ago, but did not
check if the previous version of NOX is okay with it.
In this case, you would need to provide a more precise and simple way
for us to replicate the bug before we can go ahead to hack it out of
NOX. Could you do that? Many thanks.
Regards
KK
On 31 August 2010 00:44, Niky Riga nr...@bbn.com wrote:
Hi KK,
Thanks for getting back to me. The problem only appears in the destiny
branch, I tried it again in the 0.6 version and the log message is
printed
normally, is this the expected behavior for the destiny branch?
--niky
kk yap wrote:
Hi Niky,
I believe this is because vlog does not support very long string. The
correct patch (IMHO) is to truncate messages that are too long.
Unfortunately, I cannot get to a patch until later. If anyone send us
a patch, one of us can push it. Else, we will try to get to it.
Thanks.
Regards
KK
2010/8/30 Niky Riga nr...@bbn.com:
Hi,
I have recently ported my code from nox version 0.6 to nox destiny. I
have
checked out the head of the destiny branch some time last week.
When a new datapath joins, I log the stats for debugging reasons. In
nox
destiny this causes a crash.
The last command that is executed in my python module is :
logger.info('stats for switch : %s' % str(stats))
The abort message is attached.
Thanks,
niky
___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
Re: [nox-dev] Nox destiny aborts when printing stats
JM == James McCauley James JM Date: Tue, 31 Aug 2010 05:15:41 -0700 JM This is a destiny-specific bug and was introduced in commit 58547d74330eb0511cdddbbeb4f3017278a50d53. JM JM I am not set up for commits here, but I've attached a patch. I think JM there are actually a number of improvements that could be made to the JM socket-based logging, but that's a project for another day. At least JM this stops it from crashing. Not crashing seems good, but truncating the log message seems clearly wrong. Would splitting it into multiple log messages make more sense? -Josh (j...@bbn.com) ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
Re: [nox-dev] Nox destiny aborts when printing stats
Correct, the log messages are indeed split. (This trunc was happening to the copies of the messages that would be pushed to the gui, which are now removed altogether. It will be revisited once the gui is up) On Tue, Aug 31, 2010 at 9:05 PM, Josh Smift j...@bbn.com wrote: JM == James McCauley James JM Date: Tue, 31 Aug 2010 05:15:41 -0700 JM This is a destiny-specific bug and was introduced in commit 58547d74330eb0511cdddbbeb4f3017278a50d53. JM JM I am not set up for commits here, but I've attached a patch. I think JM there are actually a number of improvements that could be made to the JM socket-based logging, but that's a project for another day. At least JM this stops it from crashing. Not crashing seems good, but truncating the log message seems clearly wrong. Would splitting it into multiple log messages make more sense? -Josh (j...@bbn.com) ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
