Re: Property "rep:fullname" on rep:User nodes
Thanks Angela for the quick answer. That was what I assumed. Konrad > On 19. Jan 2022, at 16:08, Angela Schreiber wrote: > > Hi Konrad > > The default value doesn't make sense IMHO and should not have been added in > the first place. > It is however covered by the node type of users/groups as they allow for > arbitrary properties being written below the user node (or some subtree for > that matter). > > I would be a bit reluctant though to drop it without a compelling reason. > If we conclude in the oak team that is likely not used anywhere and the > default value really bothers us, we can obviously drop it. > > Kind regards > Angela > > From: Konrad Windszus > Sent: Wednesday, January 19, 2022 3:46 PM > To: oak-dev@jackrabbit.apache.org > Subject: Property "rep:fullname" on rep:User nodes > > Hi, > In the default sync handler I found a mapping from "cn" to "rep:fullname" > (https://github.com/apache/jackrabbit-oak/blob/91a2b5aa48432ea5349499e8287ea05bcb02fada/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncConfigImpl.java#L91). > > The property "rep:fullname" seems to be an arbitrary property name though, as > it is not part of the node type definition outlined at > https://jackrabbit.apache.org/oak/docs/security/user/default.html#Representation_in_the_Repository. > Also I couldn't find this property name in the Oak codebase except for in the > default sync handler > (https://github.com/apache/jackrabbit-oak/search?q=rep%3Afullname). > > Is there any reason why I should set this property in User nodes or does that > only exist for legacy reasons? > Who is expected to read from this property? > > Thanks, > Konrad >
Re: Property "rep:fullname" on rep:User nodes
Hi Konrad The default value doesn't make sense IMHO and should not have been added in the first place. It is however covered by the node type of users/groups as they allow for arbitrary properties being written below the user node (or some subtree for that matter). I would be a bit reluctant though to drop it without a compelling reason. If we conclude in the oak team that is likely not used anywhere and the default value really bothers us, we can obviously drop it. Kind regards Angela From: Konrad Windszus Sent: Wednesday, January 19, 2022 3:46 PM To: oak-dev@jackrabbit.apache.org Subject: Property "rep:fullname" on rep:User nodes Hi, In the default sync handler I found a mapping from "cn" to "rep:fullname" (https://github.com/apache/jackrabbit-oak/blob/91a2b5aa48432ea5349499e8287ea05bcb02fada/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncConfigImpl.java#L91). The property "rep:fullname" seems to be an arbitrary property name though, as it is not part of the node type definition outlined at https://jackrabbit.apache.org/oak/docs/security/user/default.html#Representation_in_the_Repository. Also I couldn't find this property name in the Oak codebase except for in the default sync handler (https://github.com/apache/jackrabbit-oak/search?q=rep%3Afullname). Is there any reason why I should set this property in User nodes or does that only exist for legacy reasons? Who is expected to read from this property? Thanks, Konrad
Property "rep:fullname" on rep:User nodes
Hi, In the default sync handler I found a mapping from "cn" to "rep:fullname" (https://github.com/apache/jackrabbit-oak/blob/91a2b5aa48432ea5349499e8287ea05bcb02fada/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncConfigImpl.java#L91). The property "rep:fullname" seems to be an arbitrary property name though, as it is not part of the node type definition outlined at https://jackrabbit.apache.org/oak/docs/security/user/default.html#Representation_in_the_Repository. Also I couldn't find this property name in the Oak codebase except for in the default sync handler (https://github.com/apache/jackrabbit-oak/search?q=rep%3Afullname). Is there any reason why I should set this property in User nodes or does that only exist for legacy reasons? Who is expected to read from this property? Thanks, Konrad
Re: Oak-it-osgi module
Hi Robert, > Well, it's probably much quicker if you use the Sling Starter. Thanks to the pointer to Sling Starter. Looks interesting. I’ll definitively try to use it for manual tests instead of Quickstart. While exploring the Sling documentation, I have found that Sling already provides support for PaxExam [0] with the org.apache.sling.testing.paxexam library [1]. Are there any objections if I import this library in an Oak module to implement my Integration Tests? > On that note, maybe Oak itself can be packaged as an OSGi application > using the feature model and that can then be used as a basis for > integration tests. I’m not familiar yet with the feature model and I’m not sure I understand what packaging Oak as an OSGi application entails in this context? Thanks, Carlo [0]: https://sling.apache.org/documentation/development/testing-paxexam.html [1]: https://github.com/apache/sling-org-apache-sling-testing-paxexam From: Robert Munteanu Date: Tuesday, 18 January 2022 at 17:44 To: oak-dev@jackrabbit.apache.org Subject: Re: Oak-it-osgi module On Tue, 2022-01-18 at 16:38 +, Carlo Jelmini wrote: > Up until now, I have used AEM Quickstart to manually test Oak > changes, but the roundtrip is very slow, cumbersome, and > frustrating... Well, it's probably much quicker if you use the Sling Starter. On that note, maybe Oak itself can be packaged as an OSGi application using the feature model and that can then be used as a basis for integration tests. That, of course, means that ITs will need to run from outside the application, but on the other hand a proper project setup will eliminate many runtime errors, like unsatisfied imports or missing components. Thanks, Robert [1]: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-org-apache-sling-starterdata=04%7C01%7Cjelmini%40adobe.com%7C30f2c130a7e04035576708d9daa1bded%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637781210483210866%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000sdata=KamBGKCeJxbK9uVloOxoFIwqp3WynYn5TzdkrPfm5jI%3Dreserved=0
