Re: Backport of OAK-4933 to 1.6

[Raul-Nicolae Hudea]

Hi,

I wasn’t aware that “releasing independently” is an option, and maybe even 
desired for future modules. This is currently proposed on 
https://issues.apache.org/jira/browse/OAK-4933.

If you have input on how to make it successful, please add your input there 
(I’d be interested in the lessons learned from the previous attempt, which I 
understand it was related to segment-tar).

Thanks,
Raul

On 28/03/2017, 11:54, "Angela Schreiber" <anch...@adobe.com> wrote:

i was about to write pretty much the same thing :-)

regards
angela

On 28/03/17 09:09, "Michael Dürig" <mdue...@apache.org> wrote:

>
>As this is a new feature I would be interested in the motivation for
>having to backport this. Generally we should only backport fixes for
>defects.
>
>As Marcel mentions on the issue a better approach would be to release
>this independently. If this is blocked by dependencies we should make an
>effort to sort this out, as now is the time in the release cycle for
>doing so.
>
>So for now -1 from my side to back porting this until
>
>a) we have a clear picture of the alternatives and
>b) in the case of backporting, understand how we would ensure quality.
>This is new code that was so far never exposed to the level of testing
>people would expect from 1.6 code.
>
>Michael
>
>On 27.03.17 11:21, Raul-Nicolae Hudea wrote:
>> Hi,
>>
>> I would like to backport OAK-4933 to 1.6. The impact should be minimal
>>since the changes are about bringing the AzureBlobStore connector to 1.6.
>>
>> Changes are:
>> - new module
>> - changes in oak-run to support the azure data store
>>
>> Thanks,
>> Raul
>>
>>

Backport of OAK-4933 to 1.6

[Raul-Nicolae Hudea]

Hi,

I would like to backport OAK-4933 to 1.6. The impact should be minimal since 
the changes are about bringing the AzureBlobStore connector to 1.6.

Changes are:
- new module
- changes in oak-run to support the azure data store

Thanks,
Raul

Usage of lastModified from BlobStore record ?

[Raul-Nicolae Hudea]

Hi,

In OAK 1.6, is lastModified of a DataRecord coming a BlobStore (S3, for 
example) still used for timestamp comparison? (ex: to detect whether a certain 
object needs to be GC-ed). Or updating it can be ignored in backends (like 
S3Backend)?

Looking through the code for usage of getLastModified seems to point in that 
direction, but maybe someone has a more definitive answer.

This is related to a question for the AzureDataStore PR ([1]) to which I don’t 
have a definitive answer.

Thanks,
Raul

[1] https://github.com/apache/jackrabbit-oak/pull/58

Review OAK-4933 (AzureBlobStore)

[Raul-Nicolae Hudea]

Hi,

Please review OAK-4933 ([1]) which adds support for an AzureBlobStore using 
Microsoft Azure Blob Storage as underlying storage. Its implementation is 
similar to how S3DataStore is implemented.
There is also a PR on GitHub ( [2] ) where the code is split into several 
commits to ease reviewing.

Locally, oak builds passed, including integration tests.

Thanks,
Raul

[1] https://issues.apache.org/jira/browse/OAK-4933
[2] https://github.com/apache/jackrabbit-oak/pull/58