[RESULT][VOTE] Release Apache Jackrabbit Oak 1.2.19 (Take 2)

2016-09-16 Thread Amit Jain 
Hi,

The vote passes as follows:

+1 Dominique Jaeggi
+1 Marcel Reutegger
+1 Julian Reschke
+1 Amit Jain

Thanks for voting. I'll push the release out.

Regards
Amit

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19 (Take 2)

2016-09-13 Thread Julian Reschke 

On 2016-09-13 08:39, Amit Jain wrote:

...


[X] +1 Release this package as Apache Jackrabbit Oak 1.2.19

Best regards, Julian

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19 (Take 2)

2016-09-13 Thread Marcel Reutegger 

On 13/09/16 08:39, Amit Jain wrote:

Please vote on releasing this package as Apache Jackrabbit Oak 1.2.19.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 Jackrabbit PMC votes are cast.


All checks OK.

+1 Release this package as Apache Jackrabbit Oak 1.2.19

Regards
 Marcel

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19 (Take 2)

2016-09-13 Thread Dominique Jaeggi 
[X] +1 Release this package as Apache Jackrabbit Oak 1.2.19

[VOTE] Release Apache Jackrabbit Oak 1.2.19 (Take 2)

2016-09-13 Thread Amit Jain 
A candidate for the Jackrabbit Oak 1.2.19 release is available at:

https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.2.19/

The release candidate is a zip archive of the sources in:


https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.2.19/

The SHA1 checksum of the archive is
1fd77f652fed9959e40fd1a2ac4f58439df7c51b.

A staged Maven repository is available for review at:

https://repository.apache.org/

The command for running automated checks against this release candidate is:

$ sh check-release.sh oak 1.2.19
1fd77f652fed9959e40fd1a2ac4f58439df7c51b

Please vote on releasing this package as Apache Jackrabbit Oak 1.2.19.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 Jackrabbit PMC votes are cast.

[ ] +1 Release this package as Apache Jackrabbit Oak 1.2.19
[ ] -1 Do not release this package because...

My vote is +1.

Thanks
Amit

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19

2016-09-12 Thread Julian Reschke 

On 2016-09-12 10:09, Marcel Reutegger wrote:

On 12/09/16 08:36, Amit Jain wrote:

Please vote on releasing this package as Apache Jackrabbit Oak 1.2.19.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 Jackrabbit PMC votes are cast.


-1 Do not release this package because...

...sources cannot be built with Java 6.

In my view the dependency to a newer Java version was introduced
accidentally and not on purpose. We increased it to Java 7 only
on trunk. See OAK-4189.

Regards
 Marcel


Unfortunately, the 1.4 branch (just released) has the same problem.

Best regards, Julian

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19

2016-09-12 Thread Amit Jain 
Hi,

Due to the compile errors with JDK 6 cancelling the release.

Thanks
Amit

On Mon, Sep 12, 2016 at 1:40 PM, Marcel Reutegger 
wrote:

> On 12/09/16 10:03, Amit Jain wrote:
>
>> On Mon, Sep 12, 2016 at 12:23 PM, Julian Reschke 
>> wrote:
>>
>> Isn't this still supposed to compile with JDK6?
>>>
>>
>> Probably yes. This was introduced with OAK-4454 in 1.2.18. So, what are
>> the
>> options now?
>>
>
> I'd say, cancel the release, fix the code and prepare a new 1.2.19 release.
>
> Regards
>  Marcel
>

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19

2016-09-12 Thread Marcel Reutegger 

On 12/09/16 10:03, Amit Jain wrote:

On Mon, Sep 12, 2016 at 12:23 PM, Julian Reschke 
wrote:


Isn't this still supposed to compile with JDK6?


Probably yes. This was introduced with OAK-4454 in 1.2.18. So, what are the
options now?


I'd say, cancel the release, fix the code and prepare a new 1.2.19 release.

Regards
 Marcel

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19

2016-09-12 Thread Marcel Reutegger 

On 12/09/16 08:36, Amit Jain wrote:

Please vote on releasing this package as Apache Jackrabbit Oak 1.2.19.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 Jackrabbit PMC votes are cast.


-1 Do not release this package because...

...sources cannot be built with Java 6.

In my view the dependency to a newer Java version was introduced
accidentally and not on purpose. We increased it to Java 7 only
on trunk. See OAK-4189.

Regards
 Marcel

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19

2016-09-12 Thread Amit Jain 
On Mon, Sep 12, 2016 at 12:23 PM, Julian Reschke 
wrote:

> Isn't this still supposed to compile with JDK6?


Probably yes. This was introduced with OAK-4454 in 1.2.18. So, what are the
options now?

Thanks
Amit

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19

2016-09-12 Thread Dominique Jaeggi 
[X] +1 Release this package as Apache Jackrabbit Oak 1.2.19

Re: [VOTE] Release Apache Jackrabbit Oak 1.2.19

2016-09-12 Thread Julian Reschke 

On 2016-09-12 08:36, Amit Jain wrote:

...


Isn't this still supposed to compile with JDK6?

Asking because:


[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project oak-commons: Compilation failure: Compilation failure:
[ERROR] 
C:\projects\apache\jackrabbit\jackrabbit-dev\target\jackrabbit-oak-1.2.19\zip\jackrabbit-oak-1.2.19\oak-commons\src\main\java\org\apache\jackrabbit\oak\commons\FileIOUtils.java:[37,30]
 cannot find symbol
[ERROR] symbol  : class StandardCharsets
[ERROR] location: package java.nio.charset
[ERROR] 
C:\projects\apache\jackrabbit\jackrabbit-dev\target\jackrabbit-oak-1.2.19\zip\jackrabbit-oak-1.2.19\oak-commons\src\main\java\org\apache\jackrabbit\oak\commons\FileIOUtils.java:[37,0]
 static import only from classes and interfaces
[ERROR] 
C:\projects\apache\jackrabbit\jackrabbit-dev\target\jackrabbit-oak-1.2.19\zip\jackrabbit-oak-1.2.19\oak-commons\src\main\java\org\apache\jackrabbit\oak\commons\FileIOUtils.java:[79,46]
 cannot find symbol
[ERROR] symbol  : variable UTF_8
[ERROR] location: class org.apache.jackrabbit.oak.commons.FileIOUtils
[ERROR] -> [Help 1]


Best regards, Julian

[VOTE] Release Apache Jackrabbit Oak 1.2.19

2016-09-12 Thread Amit Jain 
A candidate for the Jackrabbit Oak 1.2.19 release is available at:

https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.2.19/

The release candidate is a zip archive of the sources in:


https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.2.19/

The SHA1 checksum of the archive is
b65a77717bef5163e9c0fbbce78c9e1108c02f83.

A staged Maven repository is available for review at:

https://repository.apache.org/

The command for running automated checks against this release candidate is:

$ sh check-release.sh oak 1.2.19
b65a77717bef5163e9c0fbbce78c9e1108c02f83

Please vote on releasing this package as Apache Jackrabbit Oak 1.2.19.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 Jackrabbit PMC votes are cast.

[ ] +1 Release this package as Apache Jackrabbit Oak 1.2.19
[ ] -1 Do not release this package because...

My vote is +1.

Thanks
Amit