Re: Does Oak core check the repository version ?

[Michael Dürig]

On 30.6.16 10:53 , Ian Boston wrote:

Hi,
Does Oak core check the persisted repository version to make certain it
fits in a range that is compatible with the code being run ?


SegmentMK does check the repository version since 1.0.12 and 1.1.8. The 
format was retrofitted in a way that older oak versions would fail fast 
on newer repositories. See 
https://issues.apache.org/jira/browse/OAK-2527 for details.


Using oak-run of any version on any repository was always safe in the 
sense that it would not corrupt the repository. However using post 
1.0.12 oak-run on an older repository might lead to an in-place upgrade 
rendering the repository unusable with pre 1.0.12 versions. This 
situation was remedied with 
https://issues.apache.org/jira/browse/OAK-3855, which fails oak-run when 
running against an older repository version unless --force is specified.


All this also applies to the new oak-segment-tar module. As this new 
module introduces further backward incompatible changes, there is plans 
to extend these version checks further here. See 
https://issues.apache.org/jira/browse/OAK-4295


Michael




If it doesn't already, I think it should to avoid something like the wrong
version of oak-run being used potentially damaging the repository.
Best Regards
Ian

Re: Does Oak core check the repository version ?

[Ian Boston]

Hi,

On 4 July 2016 at 09:53, Marcel Reutegger  wrote:

> Hi,
>
> On 30/06/16 13:10, "ianbos...@gmail.com on behalf of Ian Boston" wrote:
> >I have heard reports of a case of the wrong version of oak-run causing
> >problems in a repository. I dont have the details, but it sounds like the
> >core not starting on a repo unless it was in a safe known range might be a
> >usefull safety check. Could be good to enable it to force starting via a
> >system property.
> >
> >Should I open an OAK issue to track this requirement ?
>
> Yes, please open an issue. The DocumentNodeStore does not
> have such a check right now.
>

https://issues.apache.org/jira/browse/OAK-4529

Best Regards
Ian



>
> Regards
>  Marcel
>
>

Re: Does Oak core check the repository version ?

[Marcel Reutegger]

Hi,

On 30/06/16 13:10, "ianbos...@gmail.com on behalf of Ian Boston" wrote:
>I have heard reports of a case of the wrong version of oak-run causing
>problems in a repository. I dont have the details, but it sounds like the
>core not starting on a repo unless it was in a safe known range might be a
>usefull safety check. Could be good to enable it to force starting via a
>system property.
>
>Should I open an OAK issue to track this requirement ?

Yes, please open an issue. The DocumentNodeStore does not
have such a check right now.

Regards
 Marcel

Does Oak core check the repository version ?

[Ian Boston]

Hi,
Does Oak core check the persisted repository version to make certain it
fits in a range that is compatible with the code being run ?
If it doesn't already, I think it should to avoid something like the wrong
version of oak-run being used potentially damaging the repository.
Best Regards
Ian