Re: Remove oak-remote from reactor to get rid of JSON dependency

2016-11-28 Thread Francesco Mari
I will revisit RemoteServletIT to isolate and remove every usage of the
JSON library. The test will have to be @Ignore'd, but oak-remote can be
kept in the build without further modifications.

I will rework the test in a second iteration to remove Unirest once and for
all and restore RemoteServletIT.

On Nov 28, 2016 3:53 PM, "Julian Reschke"  wrote:

> On 2016-11-28 15:33, Michael Dürig wrote:
>
>>
>> Hi,
>>
>> As announced earlier today we need to get rid of all dependencies to
>> org.json:json. In Oak only oak-remote in trunk and 1.4 is affected via a
>> test dependency [1]. As I currently don't see any activity on oak-remote
>> I would suggest to remove that module from the reactor, open an issue to
>> add it back and block the latter on an issue to remove the JSON
>> dependency. This would allow us to go forward with our release plan for
>> the rest of Oak and pick up oak-remote at any time without forgetting
>> the JSON dependency issue.
>>
>> Please raise your concerns here otherwise I will go forward as proposed
>> later this week.
>>
>> Michael
>>
>> [1] https://issues.apache.org/jira/browse/OAK-5171
>>
>
> Unless it's trivial to fix (which is unlikely given the fact it's a
> transitive dependency), I agree that removing it from the build seems to be
> the best approach for now.
>
> Best regards, Julian
>
>


Re: Remove oak-remote from reactor to get rid of JSON dependency

2016-11-28 Thread Julian Reschke

On 2016-11-28 15:33, Michael Dürig wrote:


Hi,

As announced earlier today we need to get rid of all dependencies to
org.json:json. In Oak only oak-remote in trunk and 1.4 is affected via a
test dependency [1]. As I currently don't see any activity on oak-remote
I would suggest to remove that module from the reactor, open an issue to
add it back and block the latter on an issue to remove the JSON
dependency. This would allow us to go forward with our release plan for
the rest of Oak and pick up oak-remote at any time without forgetting
the JSON dependency issue.

Please raise your concerns here otherwise I will go forward as proposed
later this week.

Michael

[1] https://issues.apache.org/jira/browse/OAK-5171


Unless it's trivial to fix (which is unlikely given the fact it's a 
transitive dependency), I agree that removing it from the build seems to 
be the best approach for now.


Best regards, Julian