[jira] [Commented] (OAK-1973) IndexUpdate traverses the data nodes under index nodes
[
https://issues.apache.org/jira/browse/OAK-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076169#comment-14076169
]
Alex Parvulescu commented on OAK-1973:
--
http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/commit/VisibleEditor.java?r1=1611585r2=1611584pathrev=1611585
{code}
if (editor != null !(editor instanceof VisibleEditor)) {
return new VisibleEditor(editor);
} else {
return null;
{code}
shouldn't this be _return editor_ instead? It looks like if you wrap a
VisibleEditor you get a null, but a better option would be to simply return the
original one.
IndexUpdate traverses the data nodes under index nodes
--
Key: OAK-1973
URL: https://issues.apache.org/jira/browse/OAK-1973
Project: Jackrabbit Oak
Issue Type: Bug
Components: core
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Fix For: 1.1, 1.0.3
Attachments: OAK-1973.patch
AsyncIndexUpdate uses IndexUpdate class as Editor and passes it to
EditorDiff. IndexUpdate insternally wraps all the IndexEditors with
VisibileEditor such that they do not traverse the invisible nodes (like
:data). However IndexUpdate itself is not wrapped with VisibileEditor due to
which it has to traverse all the Index data also for diff.
Ideally IndexUpdate itself should be wrapped with VisibileEditor
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (OAK-1995) Improved SegmentNodeStore documentation
Thomas Mueller created OAK-1995: --- Summary: Improved SegmentNodeStore documentation Key: OAK-1995 URL: https://issues.apache.org/jira/browse/OAK-1995 Project: Jackrabbit Oak Issue Type: New Feature Reporter: Thomas Mueller Assignee: Thomas Mueller I'd like to have more documentation to understand the inner workings of the SegmentNodeStore implementation. * Architecture level docs * Class level javadocs * Field javadocs * Method level javadocs * More complete file format docs Maybe it's possible to make a few things more private. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (OAK-1985) TokenLoginModule can't handle case insensitive userids
[ https://issues.apache.org/jira/browse/OAK-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-1985. - Resolution: Fixed rev. 1614032 TokenLoginModule can't handle case insensitive userids -- Key: OAK-1985 URL: https://issues.apache.org/jira/browse/OAK-1985 Project: Jackrabbit Oak Issue Type: Bug Reporter: Tobias Bocanegra Assignee: angela Fix For: 1.1 Login against TokenLoginModule with an userid different in case throws: javax.security.auth.login.LoginException: Invalid token credentials. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-1985) TokenLoginModule can't handle case insensitive userids
[
https://issues.apache.org/jira/browse/OAK-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076545#comment-14076545
]
Tobias Bocanegra commented on OAK-1985:
---
thanks, but why did you remove the
{{TokenLoginModuleTest#testValidTokenCredentialsCaseInsensitive()}} test ?
TokenLoginModule can't handle case insensitive userids
--
Key: OAK-1985
URL: https://issues.apache.org/jira/browse/OAK-1985
Project: Jackrabbit Oak
Issue Type: Bug
Reporter: Tobias Bocanegra
Assignee: angela
Fix For: 1.1
Login against TokenLoginModule with an userid different in case throws:
javax.security.auth.login.LoginException: Invalid token credentials.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (OAK-1985) TokenLoginModule can't handle case insensitive userids
[ https://issues.apache.org/jira/browse/OAK-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076821#comment-14076821 ] angela commented on OAK-1985: - because the bug was in tokenprovider and i prefer to have tests where they actually belong. TokenLoginModule can't handle case insensitive userids -- Key: OAK-1985 URL: https://issues.apache.org/jira/browse/OAK-1985 Project: Jackrabbit Oak Issue Type: Bug Reporter: Tobias Bocanegra Assignee: angela Fix For: 1.1 Login against TokenLoginModule with an userid different in case throws: javax.security.auth.login.LoginException: Invalid token credentials. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-1985) TokenLoginModule can't handle case insensitive userids
[ https://issues.apache.org/jira/browse/OAK-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077058#comment-14077058 ] Tobias Bocanegra commented on OAK-1985: --- ...but we should test the entire login-chain, not only the underlying bits. TokenLoginModule can't handle case insensitive userids -- Key: OAK-1985 URL: https://issues.apache.org/jira/browse/OAK-1985 Project: Jackrabbit Oak Issue Type: Bug Reporter: Tobias Bocanegra Assignee: angela Fix For: 1.1 Login against TokenLoginModule with an userid different in case throws: javax.security.auth.login.LoginException: Invalid token credentials. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (OAK-1996) let 'order by @jcr:score' trigger automatic result set size calculation
Torgeir Veimo created OAK-1996: -- Summary: let 'order by @jcr:score' trigger automatic result set size calculation Key: OAK-1996 URL: https://issues.apache.org/jira/browse/OAK-1996 Project: Jackrabbit Oak Issue Type: Improvement Components: query Affects Versions: 1.0.3 Reporter: Torgeir Veimo It would probably be a good idea to make the order by @jcr:score suffix trigger automatic result set size calculation in getSize() for better backwards compatibility. This would make oak more compatible with applications relying on this behaviour from jackrabbit 2.8 and earlier. -- This message was sent by Atlassian JIRA (v6.2#6252)
