[jira] [Comment Edited] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-05-23 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846693#comment-16846693
 ] 

Julian Reschke edited comment on OAK-8111 at 5/23/19 1:01 PM:
--

trunk: [r1859780|http://svn.apache.org/r1859780] (1.12.0) 
[r1857010|http://svn.apache.org/r1857010] 
[r1855776|http://svn.apache.org/r1855776]
1.10: [r1859783|http://svn.apache.org/r1859783] 
[r1857013|http://svn.apache.org/r1857013] 
[r1857009|http://svn.apache.org/r1857009]
1.8: [r1859784|http://svn.apache.org/r1859784] (1.8.13) 
[r1857017|http://svn.apache.org/r1857017]


was (Author: reschke):
trunk: [r1859780|http://svn.apache.org/r1859780] (1.12.0) 
[r1857010|http://svn.apache.org/r1857010] 
[r1855776|http://svn.apache.org/r1855776]
1.10: [r1857013|http://svn.apache.org/r1857013] 
[r1857009|http://svn.apache.org/r1857009]
1.8: (1.8.13) [r1857017|http://svn.apache.org/r1857017]


> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_6
> Fix For: 1.12.0, 1.8.13, 1.10.3
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-04-05 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795135#comment-16795135
 ] 

Julian Reschke edited comment on OAK-8111 at 4/5/19 3:36 PM:
-

trunk: [r1857010|http://svn.apache.org/r1857010] 
[r1855776|http://svn.apache.org/r1855776]
1.10: [r1857013|http://svn.apache.org/r1857013] 
[r1857009|http://svn.apache.org/r1857009]
1.8: [r1857017|http://svn.apache.org/r1857017]



was (Author: reschke):
trunk: [r1857010|http://svn.apache.org/r1857010] 
[r1855776|http://svn.apache.org/r1855776]
1.10: [r1857013|http://svn.apache.org/r1857013] 
[r1857009|http://svn.apache.org/r1857009]


> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_6
> Fix For: 1.12.0, 1.8.13, 1.10.3
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-04-05 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795135#comment-16795135
 ] 

Julian Reschke edited comment on OAK-8111 at 4/5/19 3:01 PM:
-

trunk: [r1857010|http://svn.apache.org/r1857010] 
[r1855776|http://svn.apache.org/r1855776]
1.10: [r1857013|http://svn.apache.org/r1857013] 
[r1857009|http://svn.apache.org/r1857009]



was (Author: reschke):
trunk: [r1857010|http://svn.apache.org/r1857010] 
[r1855776|http://svn.apache.org/r1855776]
1.10: [r1857009|http://svn.apache.org/r1857009]


> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.12.0, 1.10.3
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-04-05 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795135#comment-16795135
 ] 

Julian Reschke edited comment on OAK-8111 at 4/5/19 2:47 PM:
-

trunk: [r1857010|http://svn.apache.org/r1857010] 
[r1855776|http://svn.apache.org/r1855776]
1.10: [r1857009|http://svn.apache.org/r1857009]



was (Author: reschke):
trunk: [r1855776|http://svn.apache.org/r1855776]
1.10: [r1857009|http://svn.apache.org/r1857009]

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.12.0, 1.10.3
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-04-05 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795135#comment-16795135
 ] 

Julian Reschke edited comment on OAK-8111 at 4/5/19 2:02 PM:
-

trunk: [r1855776|http://svn.apache.org/r1855776]
1.10: [r1857009|http://svn.apache.org/r1857009]


was (Author: reschke):
trunk: [r1855776|http://svn.apache.org/r1855776]

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.12.0, 1.10.3
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-18 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795073#comment-16795073
 ] 

Julian Reschke edited comment on OAK-8111 at 3/18/19 3:57 PM:
--

[~mreutegg] - LGTM - should I commit the patch?


was (Author: reschke):
[~mreutegg] - LGTM - should I commit the oatch?

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12, 1.11.0
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff, 
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-07 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786539#comment-16786539
 ] 

Julian Reschke edited comment on OAK-8111 at 3/7/19 12:10 PM:
--

{quote}The clusterId will be arbitrary when started without --clusterId and in 
read-write mode. When all clusterIds are active, this won't do anything useful 
but only create a new clusterId and run recovery for it.
{quote}
Well, it's not entirely arbitrary, but I see what you mean.

So let's make {{--clusterId}} required for this command. Will update that patch.


was (Author: reschke):
bq. The clusterId will be arbitrary when started without --clusterId and in 
read-write mode. When all clusterIds are active, this won't do anything useful 
but only create a new clusterId and run recovery for it.

Well, it's not entirely arbitrary, but I see what you mean.

So let's make --clusterId required for this command. Will update that patch.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Vikas Saurabh (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786128#comment-16786128
 ] 

Vikas Saurabh edited comment on OAK-8111 at 3/6/19 8:58 PM:


Talked to [~reschke] (jira doesn't seem to be working for him) and it seems I 
created some confusion as I was looking at the patch in context of this issue.

What I was arguing was that for this issue, readOnly/read-write should be 
"implied" like dryRun.
[~reschke] pointed me to the fact that I was trying to touch on arg parsing in 
the patch is common change to node store builder and hence isn't bound to this 
particular issue.

So, here's another go at a proposal:
* I feel that option parsing should default to read-only and go read-write only 
if defined explicitly. This would be a breaking change but if we log sufficient 
information about how to enable read-write mode (as we do for oak-run console) 
I think we should be ok. My reasoning to tend towards default read-only is that 
we won't accidentally write to a repo
* in context of this issue - I think dryRun should define whether node store is 
initialized as read-only as ead-write. Explicitly requiring another flag isn't 
useful in either case (dryRun should be read-only... non-dryRun needs to write 
anyway in almost all cases)


was (Author: catholicon):
Talked to [~reschke] (jira doesn't seem to be working for me) and it seems I 
created some confusion as I was looking at the patch in context of this issue.

What I was arguing was that for this issue, readOnly/read-write should be 
"implied" like dryRun.
[~reschke] pointed me to the fact that I was trying to touch on arg parsing in 
the patch is common change to node store builder and hence isn't bound to this 
particular issue.

So, here's another go at a proposal:
* I feel that option parsing should default to read-only and go read-write only 
if defined explicitly. This would be a breaking change but if we log sufficient 
information about how to enable read-write mode (as we do for oak-run console) 
I think we should be ok. My reasoning to tend towards default read-only is that 
we won't accidentally write to a repo
* in context of this issue - I think dryRun should define whether node store is 
initialized as read-only as ead-write. Explicitly requiring another flag isn't 
useful in either case (dryRun should be read-only... non-dryRun needs to write 
anyway in almost all cases)

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-8111) Create read-only DocumentNodeStore for oak-run recovery dry run

2019-03-06 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785634#comment-16785634
 ] 

Julian Reschke edited comment on OAK-8111 at 3/6/19 2:10 PM:
-

Proposal: add readOnly spec to {{Utils.NodeStoreOptions}}.

CATCH22: if we do that, the {{DocumentStore}} returned by {{DocumentNodeStore}} 
is the read-only wrapper, which breaks the code that would instantiate the 
{{MissingLastRevSeeker}}.


was (Author: reschke):
Proposal: add readOnly spec to {{Utils.NodeStoreOptions}}.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: oak-run
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.12
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)