[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745533#comment-17745533
 ] 

Julian Reschke commented on OAK-7182:
-

h2. Roadmap (as of July 2023)

h3. OAK 1.52.0 (May 2023)
 - introduce shaded Guava project for Oak-internal use (OAK-9989)
 - Guava deprecations: set minimal logging level to 'warn' (OAK-10106)
 - start converting subprojects to use shaded Guava

h3. OAK 1.54.0 (July 2023)
 - remove deprecated APIs exposing Guava in oak-commons
 - all subprojects converted to use shaded Guava

h3. OAK 1.56.0
 - remove deprecated APIs exposing Guava in oak-core-spi and oak-core



> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704191#comment-17704191
 ] 

Julian Reschke commented on OAK-7182:
-

h2. Roadmap (as of March 2023)

h3. OAK 1.50.0 (March 2023)
 - switch to Java 11 und use "forRemoval" deprecations for APIs exposing Guava 
(OAK-10007)
 - bump up default logging levels for deprecated APIs to "error" (OAK-10086)
 - Guava deprecations: set minimal logging level to 'info' (OAK-10105)
 - deprecate FileIOUtils.TransformingComparator with Guava Function parameter 
(OAK-10109) - unfortunately found just now

h3. OAK 1.52.0 (May 2023)
 - introduce wrapped Guava project for Oak-internal use (OAK-9989)
 - Guava deprecations: set minimal logging level to 'warn' (OAK-10106)

h3. OAK 1.54.0
 - remove deprecated APIs exposing Guava

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685308#comment-17685308
 ] 

Julian Reschke commented on OAK-7182:
-

note to myself:
{noformat}
for i in $(find . -name "*.java" -exec grep -q com.google.common {} ";" 
-print); do  cat $i | sed "s/import com.google.common/import 
org.apache.jackrabbit.oak.guava.common/g" > replaced && mv replaced $i -v; done
{noformat}

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684580#comment-17684580
 ] 

Julian Reschke commented on OAK-7182:
-

h2. Plan (as of February 2023)

h3. OAK 1.48.0

- bump up default logging levels for deprecated APIs to "warn" (OAK-10047)

h3. OAK 1.50.0 (March 2023)

- switch to Java 11 und use "forRemoval" deprecations for APIs exposing Guava 
(OAK-10007)
- bump up default logging levels for deprecated APIs to "error" (OAK-10086)




> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630269#comment-17630269
 ] 

Julian Reschke commented on OAK-7182:
-

I'm not sure yet that it is a new leakage (will have to check).

We could add a verification step in the release process document - but if it 
relies on people actually doing manual checks, it might not be good enough.



> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630254#comment-17630254
 ] 

Angela Schreiber commented on OAK-7182:
---

[~reschke], sounds like a reasonable plan to me.

one more thing: is there anything we can do to prevent introducing new leakages 
as it happened again in the segment-tar code?
also: is the segment team aware of this ([~miroslav])?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629845#comment-17629845
 ] 

Julian Reschke commented on OAK-7182:
-

Well; progress is on this issue proves to be hard.

We sort-of had settled to first deprecating and then removing APIs that expose 
Guava objects. We were done with the deprecations, but a certain downstream 
project hasn't been updated yet, and doing so will take time.

OTOH, we planned to revise Oak's code to use newer versions of Gauva in any 
case (be it directly or shadowed - both will require code changes).

So my proposal is to - while we're waiting on progress on the 
deprecation/removal front - we actually start upgrading Guava step by step. For 
now that would mean moving to 19.0, which would allow us to update our code not 
to use those APIs that have been removed ib Guava >= 20.0.

Feedback appreciated.


> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628314#comment-17628314
 ] 

Julian Reschke commented on OAK-7182:
-

It appears there is new leakage:

{noformat}
oak-segment-tar/target/baseline.xml-  
oak-segment-tar/target/baseline.xml-false
oak-segment-tar/target/baseline.xml-3.0.0
oak-segment-tar/target/baseline.xml-3.0.0
oak-segment-tar/target/baseline.xml-
3.0.0
oak-segment-tar/target/baseline.xml-
oak-segment-tar/target/baseline.xml-  3.0.0
oak-segment-tar/target/baseline.xml:  
com.google.common.cache,org.apache.jackrabbit.oak.cache,org.apache.jackrabbit.oak.commons,org.apache.jackrabbit.oak.segment.spi.monitor,org.aes>

{noformat}

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558439#comment-17558439
 ] 

Julian Reschke commented on OAK-7182:
-

As far as I recall, we have all Guava-tainted APIs deprecated and replacements 
in place (unless somebody introduced new ones since). Before we can *remove* 
the deprecated APIs, we'll need to figure out the consequences of that in the 
projects that use Oak. Onfortunately, that doesn't get the attention it should.

Once we have removedthe deprecated APIs in Oak, we are free to decide on the 
next steps.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Dawid Iwo Cokan (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558438#comment-17558438
 ] 

Dawid Iwo Cokan commented on OAK-7182:
--

I am available to support decoupling task. As I understand next task would be 
to replace guava references for other bundles (OAK-8857). But from this thread 
I understood there are public APIs that depends on Guava. What is a plan for 
those? We still have to depend on Guava to avoid major upgrade, correct? 

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558430#comment-17558430
 ] 

Julian Reschke commented on OAK-7182:
-

The issue is that there are *users* of Oak who currently assume Guava 15 is 
present; we need to decouple our own use from everybody else's use to make 
progress,

I understand the update issue. If there is a new Guava issue, that means we'll 
have to update and release Guava; but that's not that different from any other 
security issue.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Dawid Iwo Cokan (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558428#comment-17558428
 ] 

Dawid Iwo Cokan commented on OAK-7182:
--

{quote}the question whether we use Guava, and if so how (directly, or by 
shading it) becomes secondary.
{quote}
Yes. But it has serious implication. Personally I am not fan of shading for 
following reason. Consider you shade Guava and noone has to care about version 
used. At the same time noone can change it. What if tomorrow new security 
vulnerability is detected? In such case anyone who uses OAK with given version 
cannot get rid of it until we release new OAK that will embed fixed Guava. 
Saying this I feel shading stands in a contrary with idea of maven and other 
packages management tool. 

If you feel upgrade to Guava 22 makes sense I can prepare patch. I tried 
locally seems to be easy adoption

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558382#comment-17558382
 ] 

Julian Reschke commented on OAK-7182:
-

bq. Depend on 22.0 Guava

It sounds plausible, but my recollection is that we decided to erase Guava from 
our exported APIs. When we have done that, the question whether we use Guava, 
and if so how (directly, or by shading it) becomes secondary.

Of course more discussion is good; in essence it's about how much we want to 
trust Guava's evolution (and whether it's even needed given evolution of JDKs).

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558379#comment-17558379
 ] 

Julian Reschke commented on OAK-7182:
-

bq. Include Guava Beta Checker in build chain to ensure no code depends on code 
that potentially does not exist in future releases

We already have that configured; try "mvn clean install -Pguavabetachecks 
-DskipTests"

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Dawid Iwo Cokan (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557617#comment-17557617
 ] 

Dawid Iwo Cokan commented on OAK-7182:
--

Hi [~reschke] 

 

We use Guava 15 as mentioned but problem with using different version by 
clients is not because of used version (nor the fact of exposed Guava code in 
OAK APIs) but because Guava makes incompatible changes, right? 

Based on Guava [statement|https://github.com/google/guava] starting from 22.0 
all their APIs will remain compatible unless they are _@Beta:_
{quote}APIs without {{@Beta}} will remain binary-compatible for the indefinite 
future. (Previously, we sometimes removed such APIs after a deprecation period. 
The last release to remove non-{{{}@Beta{}}} APIs was Guava 21.0.) Even 
{{@Deprecated}} APIs will remain (again, unless they are {{{}@Beta{}}}). We 
have no plans to start removing things again, but officially, we're leaving our 
options open in case of surprises (like, say, a serious security problem).
{quote}
 

So correct me if I am wrong but clients would be free to chose the Guava 
version (whichever higher than 22.0) if we:
 * Depend on 22.0 Guava
 * Declare Import-Package as [22.0,)
 * Include [Guava Beta Checker|https://github.com/google/guava-beta-checker] in 
build chain to ensure no code depends on code that potentially does not exist 
in future releases

 

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433431#comment-17433431
 ] 

Julian Reschke commented on OAK-7182:
-

bq. Julian Reschke I was trying to understand what needs to be done for 
OAK-8717. I've seen that it does already contain a patch, it hasn't been merged 
because it was only part of the required work? Or should I completely ignore 
its content? 

It wasn't merged back then because downstream users of Oak were not ready for 
the binary incompatibilty.

The patch itself probably is still good, but we'll have to check that in the 
meantime no new Guava dependencies have been added to the API.

bq. One more thing, if I may: some changes were made to the modules pom.xml. 
Most of the time was about the Embed-Dependency of the maven-bundle-plugin. 
That I find it hard to understand, and I feel it goes beyond my current 
knowledge of the code.

AFAIR, this was so we could inline the code that extends Guava's cache, so we 
don't need to export it.



> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Marco Piovesana (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432552#comment-17432552
 ] 

Marco Piovesana commented on OAK-7182:
--

[~reschke] I was trying to understand what needs to be done for OAK-8717. I've 
seen that it does already contain a patch, it hasn't been merged because it was 
only part of the required work? Or should I completely ignore its content? 
 One more thing, if I may: some changes were made to the modules _pom.xml_. 
Most of the time was about the _Embed-Dependency_ of the _maven-bundle-plugin_. 
That I find it hard to understand, and I feel it goes beyond my current 
knowledge of the code.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Marco Piovesana (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431277#comment-17431277
 ] 

Marco Piovesana commented on OAK-7182:
--

I'll do that then, thanks [~reschke]

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431186#comment-17431186
 ] 

Julian Reschke commented on OAK-7182:
-

I believe the next thing that needs to be done is 
https://issues.apache.org/jira/browse/OAK-8717 - removing all Guava signatures 
from APIs. Last activity on this was exactly two years ago; hopefully no new 
cases have been introduced since.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Marco Piovesana (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431184#comment-17431184
 ] 

Marco Piovesana commented on OAK-7182:
--

Hi [~angela], that will definitely work for me. Since I have little experience 
with the code, do you think there's something I should start from to get 
familiar with the architecture? Is there anything that conflicts with the issue 
in progress?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431149#comment-17431149
 ] 

Angela Schreiber commented on OAK-7182:
---

hi [~iosonomarco], sure you can help i would suggest you pick up any 
remaining issue you would like to contribute and create a PR (oak has been 
migrated from svn to git in the mean time and collaborating on patches is 
probably easier now). would that work for you?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Marco Piovesana (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431117#comment-17431117
 ] 

Marco Piovesana commented on OAK-7182:
--

Hi guys,
is it possible to help in any way with the remaining work required to complete 
this issue? It's getting really hard for us to work around this in our 
application.

Marco.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Aaron Anderson (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364619#comment-17364619
 ] 

Aaron Anderson commented on OAK-7182:
-

Thanks for all of the excellent work on this issue. I am able to run the AWS 
SegmentNodeStore with the latest version of Oak (1.40) and Guava without any 
problem. 

I have encountered a few incompatibilities when using the RDMDocumentStore 
though. 

org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder -> needs a 
method update from 
com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor to 
com.google.common.util.concurrent.MoreExecutors.newDirectExecutorService

org.apache.jackrabbit.oak.cache.AbstractCacheStats and 
org.apache.jackrabbit.oak.plugins.blob.StagingCacheStats -> needs a class 
update from com.google.common.base.Objects.toStringHelper to  
com.google.common.base.MoreObjects.toStringHelper

 

In my application I am using ASM to correct these minor incompatibilities in 
the bytecode. Since "36. Remove (Guava) 
com.google.common.base.Objects.ToStringHelper" has been done elsewhere perhaps 
a quick change can be made to the CacheStats classes and the sameThreadExecutor 
utility could possibly be replaced with something simple like [this 
Camel|https://github.com/apache/camel/blob/main/core/camel-util/src/main/java/org/apache/camel/util/concurrent/SynchronousExecutorService.java]
 class.

 

 

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246735#comment-17246735
 ] 

Julian Reschke commented on OAK-7182:
-

AFAIU:

- all of the APIs that leak Guava API are now deprecated and have replacements 
without that problem (I haven't looked for quite some time so I might be wrong)
- if we use a shaded version of Guava inside Oak, applications on top of Oak 
could actually use whatever Guava version they like



> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Cris Rockwell (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246733#comment-17246733
 ] 

Cris Rockwell commented on OAK-7182:


Was looking to update some deps in my oak-based app, and Guava 15 in 
particular. Based on my reading of this comment thread, seems there is 
consideration for breaking downstream apps which may have taken advantage of 
the Guava API's leaked by Oak. Updating Oak to use a later version of Guava 
could possibly break downstream apps, which used old Guava parts that have 
changed or been removed. The alternatives of removing Guava API or shading 
Guava for internal use, would be akin to putting the Guava 'back in the 
bottle,' and having a bigger potential for breaking apps as opposed to just 
updating Oak to use a later version of Guava. Could be mistaken about that or 
oversimplifying.

My concern relates to Guava 15 which has the vulnerability below, so would like 
to see a version > 24.1.1

https://www.cvedetails.com/vulnerability-list/vendor_id-1224/product_id-52274/version_id-272463/Google-Guava-15.0.html

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Marcel Wagner (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147319#comment-17147319
 ] 

Marcel Wagner commented on OAK-7182:


Well, breaking  APIs is not good, but I think they are already broken, nobody 
is using such an old guava library in its application. So embedding is 
impossible, thats a clear sign for me the API is already broken. You can use it 
only in a standalone case, so all APIs are internal, you can change them always.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146812#comment-17146812
 ] 

Julian Reschke commented on OAK-7182:
-

[~wagnermahd] - the main problem is that upgrading Guava will break API 
compatibility due to the leak of Guava interfaces into Oak APIs. There's a plan 
for this, but it hasn't been executed that.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Nelson Mei (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146808#comment-17146808
 ] 

Nelson Mei commented on OAK-7182:
-

FYI: We too ran into this issue but were able to circumvent it by shading
guava. May not be an ideal solution but it will work.

On Fri, Jun 26, 2020 at 10:00 PM Marcel Wagner (Jira) 



-- 
-Nelson


> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Marcel Wagner (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146780#comment-17146780
 ] 

Marcel Wagner commented on OAK-7182:


Any progress on this? Our application embeds the oak repository and other 
libraries also use guava but newer versions. We now get always :

java.lang.NoSuchMethodError: 
com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor()Lcom/google/common/util/concurrent/ListeningExecutorService;

This method was changed in guava 21 from the year 2017. You are using 15 from 
the year 2013. Any chance to get your guava library updated to a newer version?

 

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078041#comment-17078041
 ] 

Julian Reschke commented on OAK-7182:
-

After resolving OAK-8657:

{noformat}
oak-commons/target/baseline.xml-  
oak-commons/target/baseline.xml-false
oak-commons/target/baseline.xml-1.6.0
oak-commons/target/baseline.xml-1.6.0
oak-commons/target/baseline.xml-1.6.0
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml-  1.6.0
oak-commons/target/baseline.xml:  
com.google.common.base,com.google.common.collect,org.apache.commons.io,org.slf4j
--
oak-commons/target/baseline.xml-  
oak-commons/target/baseline.xml-false
oak-commons/target/baseline.xml-1.1.0
oak-commons/target/baseline.xml-1.1.0
oak-commons/target/baseline.xml-1.1.0
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml-  1.1.0
oak-commons/target/baseline.xml:  
com.google.common.io,org.apache.commons.io
--
oak-core-spi/target/baseline.xml-  
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.1.1
oak-core-spi/target/baseline.xml-1.1.1
oak-core-spi/target/baseline.xml-1.1.1
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-  1.1.1
oak-core-spi/target/baseline.xml:  
com.google.common.cache,com.google.common.collect,org.apache.jackrabbit.oak.api.jmx,org.apache.jackrabbit.oak.commons.jmx
--
oak-core-spi/target/baseline.xml-  
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-  1.1.0
oak-core-spi/target/baseline.xml:  
com.google.common.base,javax.management,javax.management.openmbean,org.apache.jackrabbit.oak.api.jmx
--
oak-core-spi/target/baseline.xml-  
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-  1.1.0
oak-core-spi/target/baseline.xml:  com.google.common.base
--
oak-security-spi/target/baseline.xml-
3.0.0
oak-security-spi/target/baseline.xml-
oak-security-spi/target/baseline.xml-  3.0.0
oak-security-spi/target/baseline.xml-  javax.jcr
oak-security-spi/target/baseline.xml-
oak-security-spi/target/baseline.xml-
oak-security-spi/target/baseline.xml-  
oak-security-spi/target/baseline.xml:
{noformat}

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014427#comment-17014427
 ] 

Julian Reschke commented on OAK-7182:
-

bq. Once this is done, Oak modules could start using newer Guava versions by 
shading them (potentially in a new Oak project that just repackages the shaded 
Guava).

I looked a bit into the shading proposal today and found 
. So this seems to be 
feasible, but unless I'm missing something, we'll lose Javadocs for Guava. This 
may not be a problem for our published API, but it would affect us internally...

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958954#comment-16958954
 ] 

Julian Reschke commented on OAK-7182:
-

Good point. I will provide a patch that removes the APIs and thus will show the 
version changes.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958950#comment-16958950
 ] 

Robert Munteanu commented on OAK-7182:
--

It would be good to know which exported package versions are going to be 
increased to consider this "done". Then we can communicate a plan to remove 
such usages and make consumers compatible before the release, not after it.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958866#comment-16958866
 ] 

Julian Reschke commented on OAK-7182:
-

Current status:

- used baseline's (XML) output to identify exported APIs that reference Guava
- for these APIs (with one exception): (a) implemented Guava-free alternatives, 
(b) deprecated the existing API, (c) added logging for all uses of the 
deprecated API (currently at DEBUG, to be INFO in Oak 1.20.0)
- the exception are the cache API in oak-core-spi - this is way too dependant 
on associated Guava APIs; for this: added DEBUG logging for all callers except 
those currently in Oak; this logging to be bumped up to INFO 1.20.0 as well; 
furthermore prepared for remoing it from the exported API in the future (which 
IMHO will require embedding the classes in the three Oak consumers of the API)

The actual removal of the deprecated API would be an incompatible API change. 
We might want to do it in sync with the API changes for Java 14 (see OAK-8561).

Once this is done, Oak modules could start using newer Guava versions by 
shading them (potentially in a new Oak project that just repackages the shaded 
Guava). Getting rid of Guava completely might even be better, but not realistic 
right now.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941610#comment-16941610
 ] 

Julian Reschke commented on OAK-7182:
-

We may not have a plan how to remove Guava or update it yet.

What's sure is that we need to get rid of Guava objects in our exported APIs 
(either because otherwise we'll never be able to remove them, or because Guava 
updates - when applied - might break our APIs).

I'll thus file individual tickets for the affected APIs to deprecate those 
methods (which in most cases will require us to provide an alternative).

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941017#comment-16941017
 ] 

Julian Reschke commented on OAK-7182:
-

FWIW, I just realized that the baseline plugin can be used for checking. For 
instance:

{noformat}
fgrep -B7 google */target/baseline.xml
{noformat}
yields:
{noformat}
oak-commons/target/baseline.xml-  
oak-commons/target/baseline.xml-false
oak-commons/target/baseline.xml-1.5.0
oak-commons/target/baseline.xml-1.5.0
oak-commons/target/baseline.xml-1.5.0
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml-  1.5.0
oak-commons/target/baseline.xml:  
com.google.common.base,com.google.common.collect,org.apache.commons.io,org.slf4j
--
oak-commons/target/baseline.xml-  
oak-commons/target/baseline.xml-false
oak-commons/target/baseline.xml-1.0.0
oak-commons/target/baseline.xml-1.0.0
oak-commons/target/baseline.xml-1.0.0
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml-  1.0.0
oak-commons/target/baseline.xml:  com.google.common.io
--
oak-core-spi/target/baseline.xml-  
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-  1.1.0
oak-core-spi/target/baseline.xml:  
com.google.common.cache,com.google.common.collect,org.apache.jackrabbit.oak.api.jmx,org.apache.jackrabbit.oak.commons.jmx
--
oak-core-spi/target/baseline.xml-  
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-  1.0.1
oak-core-spi/target/baseline.xml:  
com.google.common.base,javax.management,javax.management.openmbean,org.apache.jackrabbit.oak.api.jmx
--
oak-core-spi/target/baseline.xml-  
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-  1.0.1
oak-core-spi/target/baseline.xml:  com.google.common.base
--
oak-security-spi/target/baseline.xml-  
oak-security-spi/target/baseline.xml-false
oak-security-spi/target/baseline.xml-2.1.1
oak-security-spi/target/baseline.xml-2.1.1
oak-security-spi/target/baseline.xml-
2.1.1
oak-security-spi/target/baseline.xml-
oak-security-spi/target/baseline.xml-  2.1.1
oak-security-spi/target/baseline.xml:  
com.google.common.collect,javax.jcr
{noformat}

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Sedding (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779194#comment-16779194
 ] 

Julian Sedding commented on OAK-7182:
-

bq. That would be similar to having an oak bundle that just wraps & shades 
Guava, right?

Yes, except you wouldn't shade Guava but deploy it instead. Thus Oak could stay 
slim. Furthermore, embedding (and not exporting) Guava may lead to class loader 
issues for cases where Guava classes are used in API signatures. I.e. class 
GuavaA inside Oak would be loaded from embedded/shaded classes, whereas client 
bundles may load it from another buzndle. Thus GuavaA != GuavaA as far as Java 
is concerned, because their class loaders mismatch.

bq. ... biggest roadblock ...

Agreed. That's were the most urgent action is needed and probably the biggest 
effort.



> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779137#comment-16779137
 ] 

Julian Reschke commented on OAK-7182:
-

That would be similar to having an oak bundle that just wraps & shades Guava, 
right?

Right now the biggest roadblock is to identify the cases where we have exposed 
Guava interfaces in Oak APIs - because we will have to break those.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Sedding (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779127#comment-16779127
 ] 

Julian Sedding commented on OAK-7182:
-

It might be an option to create a custom API (owned by Oak) in a separate 
bundle. This bundle would be the only one alloed to import Guava. Furthermore, 
there may be multiple implementations of the API. E.g. one using Guava 15, 
another using Guava 25 and possibly later an implementation owned entirely by 
Oak.

In order to be able to update Guava in an OSGi container only the matching 
implementation of this Oak API would need to be deployed.

This solution would allow for a gradual transition away from Guava while easing 
the pain immediately.

WDYT?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Davide Giannella (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773981#comment-16773981
 ] 

Davide Giannella commented on OAK-7182:
---

[~rombert]
bq. And, in practice, we will only need this for Guava, right?

Right now yes. That I'm aware. However it will set a "sustainable" model. If in 
the feature we found another dependency causing problems integrating in 3rd 
party products we may add to the shading.

I think the most important aspect will be that it will free Oak from 
intra-dependencies lock-down and in case of security issues here and there 
we'll be more free to update and keep Oak secure.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772964#comment-16772964
 ] 

Robert Munteanu commented on OAK-7182:
--

That is an option indeed [~edivad]. I view it somehow as the "nuclear" option, 
as it is a big departure from "traditional" dependency management. And, in 
practice, we will only need this for Guava, right?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Davide Giannella (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772930#comment-16772930
 ] 

Davide Giannella commented on OAK-7182:
---

Shading may be actually the only solution to ease integration in 3rd party 
products that may need to keep a different guava version. I would go down the 
route of creating a separate bundle, let's say {{oak-dependencies}} in which 
we'll shade what we need. I think we may make it somewhat {{provided}} or 
{{runtime}} so that such producs may decide whether to ship the oak-dep bundle 
or provide the required dependencies on their term. Such bundle will follow 
it's own release cycle and won't be released along with any oak release.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772838#comment-16772838
 ] 

Robert Munteanu commented on OAK-7182:
--

{quote}Not that I disagree, but could you clarify why it's a problem for 
non-exported APIs?{quote}

I consider it a problem because we have seem multiple times that Guava APIs 
change in backwards incompatible ways. The smaller the exposure we have to 
Guava APIs, the easier it is for us to support multiple Guava versions.

{quote}Shading is a problem because of the size, unless we create a separate 
Oak module which does nothing except shading all of Guava.{quote}

I would hope that we don't need all of Guava. But yes, size is an issue, 
together with the issue of customers depending on updating Oak to get newer 
Guava versions - but I guess this is the current situation anyway.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772778#comment-16772778
 ] 

Julian Reschke commented on OAK-7182:
-

bq. I have come to strongly believe that any leak of Guava APIs in the Oak 
codebase - whether it's in exported API or not - is a risk.

Not that I disagree, but could you clarify why it's a problem for non-exported 
APIs?

bq. ... or by importing it statically and shading it (optional rant below).

Shading is a problem because of the size, unless we create a separate Oak 
module which does nothing except shading all of Guava.

...at the end of the day, we'll have to figure out what to do with the exported 
APIs that currently *do* leak Guava APIs.


> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771136#comment-16771136
 ] 

Robert Munteanu commented on OAK-7182:
--

[~stillalex] - I eventually managed to take a look at your diff. The fact that 
you had to basically replicate the Guava API in a compat layer is indeed a bad 
smell.

I would suggest that - if needed - we simply do away with the Guava APIs and 
implement our own, e.g. instead of having 
{{org.apache.jackrabbit.oak.commons.guava.MoreExecutorsCompat}} we have a 
{{org.apache.jackrabbit.oak.commons.concurrent.OakExecutors}} where we supply 
whatever is needed by Oak under our own APIs. I have come to strongly believe 
that any leak of Guava APIs in the Oak codebase - whether it's in exported API 
or not - is a risk. Therefore I would favour only accessing it from a limited 
amount of classes so migration to newer version (or even away from Guava) is 
possible.

I think that the only way this can eventually work is to no longer import Guava 
at runtime, either by replacing it completely or by importing it statically and 
shading it (optional rant below).



For more context, I believe that it's important that we understand where Guava 
is coming from. Google famously stores all it's code in a monorepo ( 
https://cacm.acm.org/magazines/2016/7/204032-why-google-stores-billions-of-lines-of-code-in-a-single-repository/fulltext
 ). Not only is all the code stored in a single repository - including shared 
libraries like Guava and external dependencies like JUnit, but also all 
dependencies are upgraded _at the same time_. This means that all projects in 
trunk depend on a single version of Guava at a single point in time.

For this kind of setup the way Guava does versioning and backwards 
compatibility is perfectly fine - you give everyone time to adapt to new 
releases and then stop supporting the old code. However, it is fundamentally at 
odds with being used in projects with a large number of dependencies, each one 
having its own Guava version. This is precisely why we must minimise our 
exposure to Guava and keep it behind adapter classes or even remove it outright.

The sooner we do this the better.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Alex Deparvu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767017#comment-16767017
 ] 

Alex Deparvu commented on OAK-7182:
---

bq. or to use reflection to support old and new Guava?
I went ahead and added a prototype of this based on the latest patch [0], just 
to see how crazy it would look.
I ended up with 2 classes wrapping the guava apis. The executor stuff is still 
ok [1], but the toStringHelper is pretty weird [2], we have to remap the entire 
api footprint, it would be easier to rewrite it (or just copy the code over).

I hope this gets the discussion moving again, I would love to see this resolved 
in some way.


[0] 
https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:x-guava-test
[1] 
https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:x-guava-test#diff-f1efb305e741d16201cdc8de18d22569
[2] 
https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:x-guava-test#diff-fd33259bcb6c3e9c1afd3ab17aca2f1d


> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Davide Giannella (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689523#comment-16689523
 ] 

Davide Giannella commented on OAK-7182:
---

I'm in favour of reducing our exposure to Guava as much as possible. As it will 
make it easier to deal with breaking upgrade.

Backport speaking we currently have 5 branches. 1.0 and 1.2 we should seriously 
discuss if we want to actively maintain those. Then we have 1.4, 1.6 and 
trunk/1.8.

The question would be. What is the effort of having 1.4 and 1.6 java8 
compatible? I know we have upstream projects to consider but given the support 
policy from Oracle we may have room to negotiate there.

Otherwise wrapping guava's stuff in oak-common may easy any future upgrade.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689296#comment-16689296
 ] 

Julian Reschke commented on OAK-7182:
-

The downside is that it requires Java 8, so we wouldn't be able to backport.

Maybe stick with Guava, but move it into oak-commons, where there'd be a single 
place to change? (or to use reflection to support old and new Guava?)

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Alex Deparvu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689284#comment-16689284
 ] 

Alex Deparvu commented on OAK-7182:
---

In the spirit of replacing guava apis with jdk alternatives I found this idea 
to replace {{MoreObjects.toStringHelper}} with {{StringJoiner}} from jdk8 [0]. 
It seems pretty painful to rewrite all those toString methods but on the upside 
it would greatly reduce the patches for the upgrade. 
I'm curious to see what other think.

[0] 
https://stackoverflow.com/questions/32691387/alternative-to-moreobjects-in-java-8

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Yogesh Upadhyay (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688492#comment-16688492
 ] 

Yogesh Upadhyay commented on OAK-7182:
--

Thank you [~reschke] we are blocked on this as well. Our new play plugin the 
uses latest Guava version (maybe because of security issue) and our build is 
failing with latest version of jcr-oak. Let us know if we can help.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687489#comment-16687489
 ] 

Julian Reschke commented on OAK-7182:
-

My understanding is that this is blocked by:

- OAK-7545
- a general fear that upstream projects can't update their Guava version either

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Nelson Mei (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687285#comment-16687285
 ] 

Nelson Mei commented on OAK-7182:
-

What is the current state of this? Are the subtasks a good indication of where 
this currently is / needs to be done? Very interested in helping where I can.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512473#comment-16512473
 ] 

Julian Reschke commented on OAK-7182:
-

https://issues.apache.org/jira/secure/attachment/12927821/GuavaTests.java 
demonstrates the DOS attack against Guava's AtomicDoubleArray.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511209#comment-16511209
 ] 

Julian Reschke commented on OAK-7182:
-

With this patch 
(https://issues.apache.org/jira/secure/attachment/12927666/OAK-7182-guava-23.6.1.diff)
 we can *compile* with 23.6.1

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21-3.diff, OAK-7182-guava-21-4.diff, 
> OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452307#comment-16452307
 ] 

Julian Reschke commented on OAK-7182:
-

Gotcha. Yes, it's only work in progress, trying to identify what needs to 
change.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21-2.diff, OAK-7182-guava-21.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452266#comment-16452266
 ] 

Robert Munteanu commented on OAK-7182:
--

Sorry, missed that. I was looking mostly at changes like

{noformat}-import static 
com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor;
+import static 
com.google.common.util.concurrent.MoreExecutors.directExecutor;{noformat}

So is the expected result to be able to run on all Guava version between 15 and 
21?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21-2.diff, OAK-7182-guava-21.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452262#comment-16452262
 ] 

Julian Reschke commented on OAK-7182:
-

That's what at least one of the changes does (and what others do as well).

Of course if it's done more than once we should move that into some reusable 
(but private :-) component.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21-2.diff, OAK-7182-guava-21.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452257#comment-16452257
 ] 

Robert Munteanu commented on OAK-7182:
--

Have you considered using reflection to access the 'right' methods? It's ugly 
but if properly encapsulated we could get away with running on all available 
Guava versions.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21-2.diff, OAK-7182-guava-21.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452252#comment-16452252
 ] 

Julian Reschke commented on OAK-7182:
-

Updated patch to make it work with Guava 21: 
https://issues.apache.org/jira/secure/attachment/12920618/OAK-7182-guava-21-2.diff

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21-2.diff, OAK-7182-guava-21.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443757#comment-16443757
 ] 

Robert Munteanu commented on OAK-7182:
--

With {{Conditional-Package}} external callers would no longer be able to access 
those APIs. And I guess it's bundling most of Guava, so that explains the size 
increase.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442475#comment-16442475
 ] 

Julian Reschke commented on OAK-7182:
-

[~rombert] - I had a look at your suggestions wrt "".

I tried this with oak-core-spi:
{noformat}
Index: pom.xml
===
--- pom.xml (revision 1829432)
+++ pom.xml (working copy)
@@ -35,10 +35,7 @@
 maven-bundle-plugin
 
   
-
-  ${guava.osgi.import},
-  *
-
+com.google.*
 
   org.apache.jackrabbit.oak.cache,
   org.apache.jackrabbit.oak.commons.jmx,
{noformat}

As predicted in 
,
 I'm getting warnings as we use Guava APIs in exported method signatures: 
{noformat}
[WARNING] Bundle org.apache.jackrabbit:oak-core-spi:bundle:1.10-SNAPSHOT : 
Export org.apache.jackrabbit.oak.cache,  has 2,  private references 
[com.google.common.cache, com.google.common.collect],
[WARNING] Bundle org.apache.jackrabbit:oak-core-spi:bundle:1.10-SNAPSHOT : 
Export org.apache.jackrabbit.oak.commons.jmx,  has 1,  private references 
[com.google.common.base],
[WARNING] Bundle org.apache.jackrabbit:oak-core-spi:bundle:1.10-SNAPSHOT : 
Export org.apache.jackrabbit.oak.spi.whiteboard,  has 1,  private references 
[com.google.common.base],
{noformat}

Also, JAR file size for oak-core-spi goes up from 152087 to 1950807 (with Guava 
15).

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382209#comment-16382209
 ] 

Julian Reschke commented on OAK-7182:
-

[~mduerig] - is the question: "how do we make sure we *stay* compatible with 
20.0?" (or whatever we plan to support)?

I guess we'd need an build profile for that, and a build server testing that 
consistently...

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[JIRA]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382161#comment-16382161
 ] 

Michael Dürig commented on OAK-7182:


[~reschke], how do we ensure we don't re-introduce references to entities that 
were removed in some of the Guava versions we plan to support?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382137#comment-16382137
 ] 

Julian Reschke commented on OAK-7182:
-

FWIW, the latest changes for OAK-7188 would already allow us to switch to Guava 
20.0.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Shawn Heisey (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357493#comment-16357493
 ] 

Shawn Heisey commented on OAK-7182:
---

I've submitted a patch for SOLR-10308.  The patch upgrades both Guava and 
hadoop to the newest versions.  All test failures point to things other than 
HDFS, but I don't know if HDFS test coverage in Solr is good enough.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356916#comment-16356916
 ] 

Julian Reschke commented on OAK-7182:
-

FWIW, 
https://issues.apache.org/jira/secure/attachment/12909788/OAK-7182-guava-21.diff
 works with Guava up to 24.0-jre

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355645#comment-16355645
 ] 

Julian Reschke commented on OAK-7182:
-

Looking at classes in {{org.apache.jackrabbit.oak.plugins.index.solr.server}} 
it seems that we're indeed running an embedded server.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Shawn Heisey (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354150#comment-16354150
 ] 

Shawn Heisey commented on OAK-7182:
---

Solr (the server) is designed to run isolated from all other software, 
listening for HTTP requests.  Solr is a webapp, but other applications should 
not be running in the servlet container with Solr.  SolrJ (the java client) 
does not depend on Guava.

I have also updated SOLR-10308.


> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354061#comment-16354061
 ] 

Julian Reschke commented on OAK-7182:
-

https://issues.apache.org/jira/secure/attachment/12909461/OAK-7182-guava-21.diff
 contains changes that would be needed to run with Guava 21 (but doesn't have 
compat with older versions yet). Trouble is that solr doesn't work with > 20, 
see https://issues.apache.org/jira/browse/SOLR-10308

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346685#comment-16346685
 ] 

Robert Munteanu commented on OAK-7182:
--

Here's the list of APIs I (semi-manually) extracted from oak as of r1822291

{noformat}
org.apache.jackrabbit.oak.plugins.blob;uses:="com.google.common.base,com.google.common.cache,com.google.common.util.concrrent
org.apache.jackrabbit.oak.commons.io;version="1.0.0";uses:="com.google.common.io",
org.apache.jackrabbit.oak.commons;version="1.0.0";uses:="com.google.common.base,com.google.common.collect,
org.apache.jackrabbit.oak.spi.whiteboard;version="1.0.0";uses:="com.google.common.base,
org.apache.jackrabbit.oak.cache;version="1.0.0";uses:="com.google.common.cache,com.google.common.collect,
org.apache.jackrabbit.oak.plugins.index.property.strategy;uses:="com.google.common.base
org.apache.jackrabbit.oak.plugins.nodetype;uses:="com.google.common.base,
org.apache.jackrabbit.oak.plugins.observation.filter;uses:="com.google.common.base
org.apache.jackrabbit.oak.spi.security.authentication.credentials;version="2.1.0";uses:="com.google.common.collect
org.apache.jackrabbit.oak.spi.state;uses:="com.google.common.base,
org.apache.jackrabbit.oak.plugins.memory;uses:="com.google.common.hash,
{noformat}

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346672#comment-16346672
 ] 

Robert Munteanu commented on OAK-7182:
--

I am looking into the Guava packaging and release policy, and it seems that 
they have started following semantic versioning - 
https://github.com/google/guava/wiki/ReleasePolicy . In particular, they will 
only upgrade the major version "
If there are API removals or other incompatible API changes", and that includes 
APIs annotated with {{\@Beta}} . Which in turn for us this means that once we 
incorporate a new version of Guava we should be safe for a longer time. They do 
have breaking changes, for instance this year they had 3 major releases ( and 6 
minor ones ) but version 23 is now 23.6, which may mark a turn in how they 
approach backwards compatibility.

What we can do is either "vet" certain versions, e.g. test with Guava 15 and 
latest ( 23.6 ) and adjust the import versions to be [15,24). Or alternatively 
hope for the test and import [15,).

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Davide Giannella (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346628#comment-16346628
 ] 

Davide Giannella commented on OAK-7182:
---

I've added a subtask about the AtomicCounter aspect and guava. While it's not 
strictly an API it's used during repository construction and I'm in favour to 
try to remove the guava dependency completely in such case. That does not 
exclude that Guava is not used in other places of the functionality.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Marcel Reutegger (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344905#comment-16344905
 ] 

Marcel Reutegger commented on OAK-7182:
---

I'm also in favour of Robert's proposal. The fewer usages of Guava we have the 
easier it will be to run Oak with a different version. 

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344786#comment-16344786
 ] 

Robert Munteanu commented on OAK-7182:
--

Thinking about how to best 'break away' from a specific Guava version, here's 
my proposal (not tested):

# minimize API exposure from Guava
# replace all Guava usages where alternatives from the JDK exist
# inline Guava in the bundles that import it using {{Conditional-Package}}
# import the Guava packages that we use in the API with a wide, open-ended 
range, e.g. {{[15,)}}

This might work since it allows us to depend on a 'private' version of Guava 
but the APIs will work with other version as well. I am not sure whether we'll 
run into uses constraints due to the Oak bundle importing different versions of 
Guava at some point.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340771#comment-16340771
 ] 

Julian Reschke commented on OAK-7182:
-

Ack.

And no, we don't necessarily have to *remove* those. On the other hand, we 
should avoid these in the future.

The above usage should be safe, see 
https://google.github.io/guava/releases/20.0/api/docs/com/google/common/base/Predicate.html

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340753#comment-16340753
 ] 

Robert Munteanu commented on OAK-7182:
--

There's at least 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeState.java#L388-L393

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340719#comment-16340719
 ] 

Julian Reschke commented on OAK-7182:
-

bq.  the fact that we have Oak APIs exposing Guava APIs

Do we?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340705#comment-16340705
 ] 

Robert Munteanu commented on OAK-7182:
--

These changes seem to be compile-time only, we would also need to adjust the 
OSGi manifests I assume.

Also, regading [~frm]'s comment, the fact that we have Oak APIs exposing Guava 
APIs is going to make it hard to remove those usages.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334299#comment-16334299
 ] 

Julian Reschke commented on OAK-7182:
-

FWIW, jclouds is doing testing with various Guava versions: 
[https://jclouds.ci.cloudbees.com/job/jclouds-compat/] - so could we.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334298#comment-16334298
 ] 

Julian Reschke commented on OAK-7182:
-

So, at least for the update to Guava 20, we need five changes. One is already 
applied, one is trivial (patch attached), one is likely trivial (jclouds 
dependency, patch attached), one is in progress (JCR-4250).

 

What's left is OAK-7188, which would need work if we want to support Guava 
versions before 19.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334155#comment-16334155
 ] 

Julian Reschke commented on OAK-7182:
-

The attached diff would enable us to use Guava 20; most of the changes are 
trivial, but some will require dependency updates, and some require changes 
which would *require* a new Guava.

I'll break this down into individual independent sub tasks.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334141#comment-16334141
 ] 

Julian Reschke commented on OAK-7182:
-

I have Oak running with Guava 20, and will summarize the necessary changes 
soonish. (And yes, I realize that's not even the latest and greatest)

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

[Francesco Mari (JIRA)]

[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334120#comment-16334120
 ] 

Francesco Mari commented on OAK-7182:
-

One step in this direction would be to start using native interfaces provided 
by Java 8+ instead of relying on equivalent Guava interfaces, when possible. 
This might reduce the pain of the upgrade.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)