Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
- Op 27 mar 2021 om 21:56 schreef Andreas Wacknitz a.wackn...@gmx.de: > As I stated in another message: We take every change that is > incorporated into illumos-gate by a jenkins job that runs during the nights. > There is no manual intervention in this process. OI does only little > patches on illumos-gate sources. You can check it as it is inside our > oi-userland repository under components/openindiana/illumos-gate. What > is inside there will be build nightly by a jenkins job. > That is a major difference from other illumos distributions like OmniOS > or SmartOS. Thanks for explaining this almost-weekly process. It seems an important process - if not the most important one, which seems top priority for OpenIndiana, and I appreciate the effort (or your efforts) on this and hopefully the ksh93 changes can be merged into OI. My guess is that the shell/ksh93 and SUNWcs (cs=core solaris) are important ones to have - VERY important ones to have. Unless some longtime OI developers seriously object, I'd say that your plan to gradually run "gmake REQUIRED_PACKAGES" again as you go along and work on packages seems a good plan. By the way, in Smalltalk the package squeak-5 that is now built using epoll(5) support. https://illumos.org/man/5/epoll epoll(5) is in Illumos and I think OpenIndiana gets this "thanks to Illumos", and thanks to your weekly updates of almost automatically integrating Illumos changes into OI. So I'm independently working now on a new update for squeak-5 which uses Illumos epoll(5) support, and I'll run gmake REQUIRED_PACKAGES on the squeak-5 Makefile, which is very likely to find now shell/ksh93 as required. I would tend to say that running an automatic update on all packages to run gmake REQUIRED_PACKAGES seems to me a risky idea, the idea to do it only gradually seems a better idea to me. In fact I could submit a pull request or PR next week for example an update of squeak-5 with new changes from Smalltalk on the one hand, and on the other hand an updated REQUIRED_PACKAGES. Regards, David Stes ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
Am 27.03.21 um 20:04 schrieb s...@pandora.be: It would help if Andreas clarified which "latest ksh93 changes in illumos-gate" are of interest. Is there something in the latest ksh93 changes that is of interest to OpenIndiana ? For example, security fixes in ksh93 (/bin/sh) could be very important. As I stated in another message: We take every change that is incorporated into illumos-gate by a jenkins job that runs during the nights. There is no manual intervention in this process. OI does only little patches on illumos-gate sources. You can check it as it is inside our oi-userland repository under components/openindiana/illumos-gate. What is inside there will be build nightly by a jenkins job. That is a major difference from other illumos distributions like OmniOS or SmartOS. ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
Am 27.03.21 um 19:51 schrieb Tim Mooney via oi-dev: In regard to: Re: [oi-dev] Latest ksh93 changes in illumos-gate have...: On Sat, Mar 27, 2021 at 09:41:12AM +0100, Andreas Wacknitz wrote: illumos-gate has recently merged the following changes 2755 split ksh93 from core package 13460 ksh93 tests should be moved out of usr/demo 518 ksh documentation should be moved out of SUNWcsr This has impacts on our REQUIRED_PACKAGES settings for many packages. Most, if not all occurrences of REQUIRED_PACKAGES += SUNWcs need to be replaced by REQUIRED_PACKAGES += shell/ksh93 Is that really true? I would have thought that all products would require SUNWcs, but only ones that included ksh scripts would require shell/ksh93 . +1, I was trying to make the same point in the email I just sent. I don't think *any* SUNWcs should be replaced. I think shell/ksh93 should be *added* in some places. gmake REQUIRED_PACKAGES automatically detects most of the dependencies automatically. If we update the build server to an osnet version with split ksh93 publishing packages with missing ksh93 dependency will fail. You can check this on your own system (if updated recently): try to publish network/bind ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
Am 27.03.21 um 19:48 schrieb s...@pandora.be: The reason why I wrote "top priority" is because in my understanding osnet-incorporation basically is kernel, network stack, filesystems, and device drivers, and basic userland libraries and applications such as Bourne / Korn shell. osnet-incorporation is intentionally frozen on the build server. After every successfull jenkins run (either oi-userland or illumos-gate) the build server will be automatically update packages on it if necessary. In order to prohibit automatic updates of osnet (and automatic reboots) it is frozen. Of course from time to time it also needs to be updated but I do that only if the actual version is tested on other systems by me. Typically I do that once a week. So more than any programming language or application or user level library, I would think the above needs updating. However I do not have experience with the implications and overall OpenIndiana release engineering. I learned it the hard way when nobody else was left who was able and willing to do it. So I must add that if an update would somehow break OpenIndiana features such as the MATE desktop, the OpenIndiana desktop, then osnet-incorporation cannot be updated, and then in that case OpenIndiana is stuck with the 'frozen' osnet-incorporation. We build illumos-gate nightly. If any changes have been merged into illumos-gate you will get it the next day when you run "pkg update" on your systems. Only the build server is protected by freezing osnet-incorporation. Of course, you can do the same but you should know the implications... Andreas ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
It would help if Andreas clarified which "latest ksh93 changes in illumos-gate" are of interest. Is there something in the latest ksh93 changes that is of interest to OpenIndiana ? For example, security fixes in ksh93 (/bin/sh) could be very important. - Op 27 mar 2021 om 19:51 schreef oi-dev oi-dev@openindiana.org: > In regard to: Re: [oi-dev] Latest ksh93 changes in illumos-gate have...: > >> On Sat, Mar 27, 2021 at 09:41:12AM +0100, Andreas Wacknitz wrote: >> >>> illumos-gate has recently merged the following changes >>> 2755 split ksh93 from core package >>> 13460 ksh93 tests should be moved out of usr/demo >>> 518 ksh documentation should be moved out of SUNWcsr >>> >>> This has impacts on our REQUIRED_PACKAGES settings for many packages. >>> Most, if not all occurrences of >>> REQUIRED_PACKAGES += SUNWcs >>> need to be replaced by >>> REQUIRED_PACKAGES += shell/ksh93 >> >> Is that really true? I would have thought that all products would >> require SUNWcs, but only ones that included ksh scripts would require >> shell/ksh93 . > > +1, I was trying to make the same point in the email I just sent. > > I don't think *any* SUNWcs should be replaced. I think shell/ksh93 > should be *added* in some places. > > Tim > -- > Tim Mooney tim.moo...@ndsu.edu > Enterprise Computing & Infrastructure / > Division of Information Technology/701-231-1076 (Voice) > North Dakota State University, Fargo, ND 58105-5164 > ___ > oi-dev mailing list > oi-dev@openindiana.org > https://openindiana.org/mailman/listinfo/oi-dev ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
In regard to: Re: [oi-dev] Latest ksh93 changes in illumos-gate have...: On Sat, Mar 27, 2021 at 09:41:12AM +0100, Andreas Wacknitz wrote: illumos-gate has recently merged the following changes 2755 split ksh93 from core package 13460 ksh93 tests should be moved out of usr/demo 518 ksh documentation should be moved out of SUNWcsr This has impacts on our REQUIRED_PACKAGES settings for many packages. Most, if not all occurrences of REQUIRED_PACKAGES += SUNWcs need to be replaced by REQUIRED_PACKAGES += shell/ksh93 Is that really true? I would have thought that all products would require SUNWcs, but only ones that included ksh scripts would require shell/ksh93 . +1, I was trying to make the same point in the email I just sent. I don't think *any* SUNWcs should be replaced. I think shell/ksh93 should be *added* in some places. Tim -- Tim Mooney tim.moo...@ndsu.edu Enterprise Computing & Infrastructure / Division of Information Technology/701-231-1076 (Voice) North Dakota State University, Fargo, ND 58105-5164___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
The reason why I wrote "top priority" is because in my understanding osnet-incorporation basically is kernel, network stack, filesystems, and device drivers, and basic userland libraries and applications such as Bourne / Korn shell. So more than any programming language or application or user level library, I would think the above needs updating. However I do not have experience with the implications and overall OpenIndiana release engineering. So I must add that if an update would somehow break OpenIndiana features such as the MATE desktop, the OpenIndiana desktop, then osnet-incorporation cannot be updated, and then in that case OpenIndiana is stuck with the 'frozen' osnet-incorporation. David Stes ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
Sorry I don't have experience with OpenIndiana release engineering to judge this. I think the plan "update the build server to the latest osnet-incorporation now and change package dependencies when needed, eg. when we touch a package anyways." sound logical. I would guess that the change for shell/ksh93 and updating osnet-incorporation is pretty important, because top priority. David Stes - Op 27 mar 2021 om 17:59 schreef Andreas Wacknitz a.wackn...@gmx.de: > Am 27.03.21 um 16:59 schrieb s...@pandora.be: >> The shared-macros.mk in oi-userland/make-rules could do: >> >> shared-macros.mk:REQUIRED_PACKAGES += shell/ksh93 >> >> where it is currently doing >> >> shared-macros.mk:REQUIRED_PACKAGES += SUNWcs >> >> Currently on an older OpenIndiana system I have: >> >> $ pkg search /usr/bin/sh >> INDEX ACTION VALUE PACKAGE >> path link usr/bin/sh pkg:/SUNWcs@0.5.11-2020.0.1.20038 >> path link usr/bin/sh pkg:/shell/ksh93@93.21.1.20120801-2020.0.1.20424 >> >> $ ls -l /bin/sh >> lrwxrwxrwx 1 root root 9 Sep 16 2020 /bin/sh -> i86/ksh93 >> >> So if a component provides a script with /bin/sh it requires either SUNWcs or >> shell/ksh93. >> >> But the oi-userland/make-rules/shared-macros.mk modification could perhaps >> deal >> with most cases. > You are right. But probobly I wasn't explicit enough: The main question > is how to deal with > the situation. Changing so many packages would take some time and occupy > the build server for a while. > So maybe it would be better to update the build server to the latest > osnet-incorporation now > and change package dependencies when needed, eg. when we touch a package > anyways. > But that would also render some (all?) actual PR's buggy and they have > to be redone. > >> >> - Op 27 mar 2021 om 16:13 schreef gary mills gary_mi...@fastmail.fm: >> >>> On Sat, Mar 27, 2021 at 09:41:12AM +0100, Andreas Wacknitz wrote: >>> illumos-gate has recently merged the following changes 2755 split ksh93 from core package 13460 ksh93 tests should be moved out of usr/demo 518 ksh documentation should be moved out of SUNWcsr This has impacts on our REQUIRED_PACKAGES settings for many packages. Most, if not all occurrences of REQUIRED_PACKAGES += SUNWcs need to be replaced by REQUIRED_PACKAGES += shell/ksh93 >>> Is that really true? I would have thought that all products would >>> require SUNWcs, but only ones that included ksh scripts would require >>> shell/ksh93 . The problem is that you can't tell which to change from >>> the REQUIRED_PACKAGES make variable. Is there not a default for that >>> variable? Maybe adding both packages would be a quick fix, although >>> it's incorrect in many cases. Is there a way to determine which >>> products actually require the shell/ksh93 package? >>> >>> >>> -- >>> -Gary Mills--refurb--Winnipeg, Manitoba, >>> Canada- >>> >>> ___ >>> oi-dev mailing list >>> oi-dev@openindiana.org >>> https://openindiana.org/mailman/listinfo/oi-dev >> ___ >> oi-dev mailing list >> oi-dev@openindiana.org >> https://openindiana.org/mailman/listinfo/oi-dev > > > ___ > oi-dev mailing list > oi-dev@openindiana.org > https://openindiana.org/mailman/listinfo/oi-dev ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
Am 27.03.21 um 16:59 schrieb s...@pandora.be: The shared-macros.mk in oi-userland/make-rules could do: shared-macros.mk:REQUIRED_PACKAGES += shell/ksh93 where it is currently doing shared-macros.mk:REQUIRED_PACKAGES += SUNWcs Currently on an older OpenIndiana system I have: $ pkg search /usr/bin/sh INDEX ACTION VALUE PACKAGE path link usr/bin/sh pkg:/SUNWcs@0.5.11-2020.0.1.20038 path link usr/bin/sh pkg:/shell/ksh93@93.21.1.20120801-2020.0.1.20424 $ ls -l /bin/sh lrwxrwxrwx 1 root root 9 Sep 16 2020 /bin/sh -> i86/ksh93 So if a component provides a script with /bin/sh it requires either SUNWcs or shell/ksh93. But the oi-userland/make-rules/shared-macros.mk modification could perhaps deal with most cases. You are right. But probobly I wasn't explicit enough: The main question is how to deal with the situation. Changing so many packages would take some time and occupy the build server for a while. So maybe it would be better to update the build server to the latest osnet-incorporation now and change package dependencies when needed, eg. when we touch a package anyways. But that would also render some (all?) actual PR's buggy and they have to be redone. - Op 27 mar 2021 om 16:13 schreef gary mills gary_mi...@fastmail.fm: On Sat, Mar 27, 2021 at 09:41:12AM +0100, Andreas Wacknitz wrote: illumos-gate has recently merged the following changes 2755 split ksh93 from core package 13460 ksh93 tests should be moved out of usr/demo 518 ksh documentation should be moved out of SUNWcsr This has impacts on our REQUIRED_PACKAGES settings for many packages. Most, if not all occurrences of REQUIRED_PACKAGES += SUNWcs need to be replaced by REQUIRED_PACKAGES += shell/ksh93 Is that really true? I would have thought that all products would require SUNWcs, but only ones that included ksh scripts would require shell/ksh93 . The problem is that you can't tell which to change from the REQUIRED_PACKAGES make variable. Is there not a default for that variable? Maybe adding both packages would be a quick fix, although it's incorrect in many cases. Is there a way to determine which products actually require the shell/ksh93 package? -- -Gary Mills--refurb--Winnipeg, Manitoba, Canada- ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
The shared-macros.mk in oi-userland/make-rules could do: shared-macros.mk:REQUIRED_PACKAGES += shell/ksh93 where it is currently doing shared-macros.mk:REQUIRED_PACKAGES += SUNWcs Currently on an older OpenIndiana system I have: $ pkg search /usr/bin/sh INDEX ACTION VALUE PACKAGE path link usr/bin/sh pkg:/SUNWcs@0.5.11-2020.0.1.20038 path link usr/bin/sh pkg:/shell/ksh93@93.21.1.20120801-2020.0.1.20424 $ ls -l /bin/sh lrwxrwxrwx 1 root root 9 Sep 16 2020 /bin/sh -> i86/ksh93 So if a component provides a script with /bin/sh it requires either SUNWcs or shell/ksh93. But the oi-userland/make-rules/shared-macros.mk modification could perhaps deal with most cases. - Op 27 mar 2021 om 16:13 schreef gary mills gary_mi...@fastmail.fm: > On Sat, Mar 27, 2021 at 09:41:12AM +0100, Andreas Wacknitz wrote: > >> illumos-gate has recently merged the following changes >> 2755 split ksh93 from core package >> 13460 ksh93 tests should be moved out of usr/demo >> 518 ksh documentation should be moved out of SUNWcsr >> >> This has impacts on our REQUIRED_PACKAGES settings for many packages. >> Most, if not all occurrences of >> REQUIRED_PACKAGES += SUNWcs >> need to be replaced by >> REQUIRED_PACKAGES += shell/ksh93 > > Is that really true? I would have thought that all products would > require SUNWcs, but only ones that included ksh scripts would require > shell/ksh93 . The problem is that you can't tell which to change from > the REQUIRED_PACKAGES make variable. Is there not a default for that > variable? Maybe adding both packages would be a quick fix, although > it's incorrect in many cases. Is there a way to determine which > products actually require the shell/ksh93 package? > > > -- > -Gary Mills- -refurb--Winnipeg, Manitoba, Canada- > > ___ > oi-dev mailing list > oi-dev@openindiana.org > https://openindiana.org/mailman/listinfo/oi-dev ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
On Sat, Mar 27, 2021 at 09:41:12AM +0100, Andreas Wacknitz wrote: > illumos-gate has recently merged the following changes > 2755 split ksh93 from core package > 13460 ksh93 tests should be moved out of usr/demo > 518 ksh documentation should be moved out of SUNWcsr > > This has impacts on our REQUIRED_PACKAGES settings for many packages. > Most, if not all occurrences of > REQUIRED_PACKAGES += SUNWcs > need to be replaced by > REQUIRED_PACKAGES += shell/ksh93 Is that really true? I would have thought that all products would require SUNWcs, but only ones that included ksh scripts would require shell/ksh93 . The problem is that you can't tell which to change from the REQUIRED_PACKAGES make variable. Is there not a default for that variable? Maybe adding both packages would be a quick fix, although it's incorrect in many cases. Is there a way to determine which products actually require the shell/ksh93 package? -- -Gary Mills--refurb--Winnipeg, Manitoba, Canada- ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
Hi Andreas, The Makefile is one thing, but the manifest of a package also contains a depend fmri=pkg:/SUNWcs@0.5.11-2020.0.1.20416 type=require dependency on SUNWcs. The above is for example from the manifest of squeak-4-nodisplay. http://pkg.openindiana.org/hipster/manifest/0/runtime%2Fsqueak-4-nodisplay%404.19.6%2C5.11-2020.0.1.0%3A20210320T200944Z Actually I suppose the manifest dependency is the most important issue - more so than the Makefile, which is the tool to produce the manifest by the 'gmake publish'. Is "pkglint" somehow capable of making a check to check for this dependency ? If yes, then pkglint could perhaps be configured to catch packages that have not updated their Makefile yet. I'm not sufficiently well familiar with pkglint to answer, but I suspect pkglint may have capabilities to check actions, such as the depend action on SUNWcs. David Stes - Op 27 mar 2021 om 10:10 schreef Andreas Wacknitz a.wackn...@gmx.de: > Am 27.03.21 um 10:00 schrieb [ mailto:stephan.alth...@duedinghausen.eu | > stephan.alth...@duedinghausen.eu ] : > > > > Hello! > what about a script that recurses the tree and does sinlge small PRs per > package > magically? > it is not that simple no? > Probably as I don't know if all occurrences of SUNWcs should/can be replaced > by > shell/ksh93. > Still, one could imagine such a script but it would probably need to run > "gmake > REQUIRED_PACKAGES" on every package that has SUNWcs as a requirement. > And then it has to make sure that other possible changes are correct (some > more > changes might occur as some packages seem to have been updated without > updating the REQUIRED_PACKAGE settings). > > Andreas > > ___ > oi-dev mailing list > oi-dev@openindiana.org > https://openindiana.org/mailman/listinfo/oi-dev ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] Latest ksh93 changes in illumos-gate have impacts on REQUIRED_PACKAGES
Am 27.03.21 um 10:00 schrieb stephan.alth...@duedinghausen.eu: Hello! what about a script that recurses the tree and does sinlge small PRs per package magically? it is not that simple no? Probably as I don't know if all occurrences of SUNWcs should/can be replaced by shell/ksh93. Still, one could imagine such a script but it would probably need to run "gmake REQUIRED_PACKAGES" on every package that has SUNWcs as a requirement. And then it has to make sure that other possible changes are correct (some more changes might occur as some packages seem to have been updated without updating the REQUIRED_PACKAGE settings). Andreas ___ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev
