Re: [ol-discuss] Edit/author issue

[Andy Carter]

On Thursday 12 Sep 2013 13:18:43 Ben Companjen wrote:
> Andy, the key of the author in the Edition is different from the key of
> Work's author, as you can see in the JSON.

First time I've tried the JSON link - noted for future use.

> The problem in these items is that the author shown on the web is the
> work's author, but that the edition record contains a reference to an
> author that is deleted (type=/type/delete) or merged
> (type=/type/redirect)​. The server does not accept deleted records or
> redirects as references. 

OK, I can understand that

> You need to update the reference(s) in the Edition
> record

Can I do that from the web interface? 

I assume not as I've tried resetting author, only a single choice came up, but 
I still get the same result.

> or delete the bad reference(s) altogether (which you can't using the
> web interface).

Running scripts seems far beyond me at the moment. I'm just finding my way 
around the web edits.

> VacuumBot

Thanks for the detailed expatiation.

Think I'll sleep on your post - and read it a few more times ;)

Andy
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Edit/author issue

[Ben Companjen]

Andy, the key of the author in the Edition is different from the key of
Work's author, as you can see in the JSON.

The problem in these items is that the author shown on the web is the
work's author, but that the edition record contains a reference to an
author that is deleted (type=/type/delete) or merged
(type=/type/redirect)​. The server does not accept deleted records or
redirects as references. You need to update the reference(s) in the Edition
record or delete the bad reference(s) altogether (which you can't using the
web interface). VacuumBot encountered these same errors and now uses the
following strategy:
1. check whether the edition has a reference to a work.
1-yes: check whether the work has at least one author
1-yes-yes: delete the authors from the edition
1-yes-no: throw error
1-no: 2a

2a. download the author record
2b. follow the 'location' field value that points to the replacing record
2c. see if the new record is an author
2c-yes: put this key as author in the edition
2c-no: 3a

3a: is the new record again a redirect?
3a-yes: 2a
3a-no: is the new record deleted?
3a-no-yes: undelete the author (set type=/type/author)

See https://github.com/bencomp/VacuumBot/blob/master/vacuumbot.py#L241 for
code (it works for me, but I should use real loggers and refactor into OOP
(just created issue #1 for that). pull requests welcome).

Regards,

Ben
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Edit/author issue

[Andy Carter]

I've just found another with a similar error that I can't edit

http://openlibrary.org/books/OL20232579M

though author seems to be pointing to what's expected this time!

Andy
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Edit/author issue

[Karen Coyle]

Thanks, Jessamyn -

On 9/11/13 1:40 PM, jessamyn c. west wrote:
>> I think one of the things we need to get from Anand is an
>> idea of what maintenance functions are active on OL,
>> and if there is a way that we can monitor them.
>
> I have a loose idea about some of that. Author merge (and unmerge
> which I can do I'm not sure if other people can) is active though it
> can time out. Edition merge is non-functional and always has been to
> the best of my knowledge.

Here are some others I am wondering about:

- If you add a new edition, does it go through the edition merge 
algorithm? And does it get added to a work, if one is appropriate?

- Is there a search index update process that runs always or regularly?

Any idea about these?

kc


There is theoretically a back-end way to
> sort of sent a quick re-index request to the internal search/index on
> a per-page basis but I have not had a lot of luck getting it to work
> myself. There are a lot of out of date things appearing as a result of
> searches and on some static (e.g. author) pages. I'd be really happy
> to be part of an email or even IRC discussion about this. I've added
> some things to the wiki's "Ideas" page based on some non-functional
> things that affect users and my ability to support users.
>
> http://openlibrary.org/community/ideas
>
> Jessamyn
> ___
> Ol-discuss mailing list - Ol-discuss@archive.org
> http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
> Archives: http://www.mail-archive.com/ol-discuss@archive.org/
> To unsubscribe from this mailing list, send email to 
> ol-discuss-unsubscr...@archive.org
>

-- 
Karen Coyle
kco...@kcoyle.net http://kcoyle.net
ph: 1-510-540-7596
m: 1-510-435-8234
skype: kcoylenet
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Edit/author issue

[jessamyn c. west]

> I think one of the things we need to get from Anand is an
> idea of what maintenance functions are active on OL,
> and if there is a way that we can monitor them.

I have a loose idea about some of that. Author merge (and unmerge
which I can do I'm not sure if other people can) is active though it
can time out. Edition merge is non-functional and always has been to
the best of my knowledge. There is theoretically a back-end way to
sort of sent a quick re-index request to the internal search/index on
a per-page basis but I have not had a lot of luck getting it to work
myself. There are a lot of out of date things appearing as a result of
searches and on some static (e.g. author) pages. I'd be really happy
to be part of an email or even IRC discussion about this. I've added
some things to the wiki's "Ideas" page based on some non-functional
things that affect users and my ability to support users.

http://openlibrary.org/community/ideas

Jessamyn
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Edit/author issue

[Andy Carter]

On Wednesday 11 Sep 2013 15:43:29 Tom Morris wrote:
> It looks like there was a bad merge back in July.

Thanks all for the comments.

I'll leave that book aside for a while and hope this gets fixed.

Andy
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Edit/author issue

[Karen Coyle]

Thanks, Tom. I think one of the things we need to get from Anand is an 
idea of what maintenance functions are active on OL, and if there is a 
way that we can monitor them. I have no idea if merges between editions 
or from editions into works are taking place, and here is another 
function (merging/unmerging authors) that is mysterious. I would assume 
that updates would trigger certain actions... but do not know if that is 
the case.

kc

On 9/11/13 7:43 AM, Tom Morris wrote:
> On Wed, Sep 11, 2013 at 8:45 AM, Karen Coyle  > wrote:
>
> Yes, something is broken. Actually, it may be more than one thing. I
> went to the author search and saw two authors:
> http://openlibrary.org/search/authors?q=barbara+delinsky
>
> When I click on the top one, it takes me to the Clive Cussler page. So
> this author is re-directing to Clive Cussler for some reason.
>
>
> It looks like there was a bad merge back in July.
>
> I do not know how to fix this. Anyone?
>
>
> I reverted to the previous version of the two author records (Barbara
> Delinsky & Clive Cussler) which fixed the author records, but all of
> here books are still linked to him (e.g.
> http://openlibrary.org/works/OL166398W/Lake_News).  According to the
> (stale) search index, there are 212 of them, so I think it's time to get
> Anand involved to reverse the merge unless someone has a lot of energy.
>
> We should probably add some type of "Undo merge" tool to the ToDo list.
>   The id of the merge is 47605678
> from 2013-07-12 by /people/bboretsky.  The other author merge is the
> same merge has a completely different name
> http://openlibrary.org/authors/OL581593A?v=1 and the merge was the first
> and only action by this account, so seems like malicious behavior to me.
>
> Tom
>
>
> kc
>
> On 9/11/13 2:26 AM, Andy Carter wrote:
>  > I am trying to add a new edition. It seems to have appeared as
> OL25430731M
>  > however the author is Barbara Delinsky not Clive Cussler. I am
> unable to edit
>  > anything more on that page.
>  >
>  > I see
>  > expected /type/author, found /type/redirect
>  > at the head of the save response page.
>  >
>  > All other edits today have been successful.
>  >
>  > Is something broken?
>  >
>  > Andy
>
>

-- 
Karen Coyle
kco...@kcoyle.net http://kcoyle.net
ph: 1-510-540-7596
m: 1-510-435-8234
skype: kcoylenet
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Edit/author issue

[Tom Morris]

On Wed, Sep 11, 2013 at 8:45 AM, Karen Coyle  wrote:

> Yes, something is broken. Actually, it may be more than one thing. I
> went to the author search and saw two authors:
>http://openlibrary.org/search/authors?q=barbara+delinsky
>
> When I click on the top one, it takes me to the Clive Cussler page. So
> this author is re-directing to Clive Cussler for some reason.
>

It looks like there was a bad merge back in July.


> I do not know how to fix this. Anyone?
>

I reverted to the previous version of the two author records (Barbara
Delinsky & Clive Cussler) which fixed the author records, but all of here
books are still linked to him (e.g.
http://openlibrary.org/works/OL166398W/Lake_News).  According to the
(stale) search index, there are 212 of them, so I think it's time to get
Anand involved to reverse the merge unless someone has a lot of energy.

We should probably add some type of "Undo merge" tool to the ToDo list.
 The id of the merge is 47605678
from 2013-07-12 by /people/bboretsky.  The other author merge is the same
merge has a completely different name
http://openlibrary.org/authors/OL581593A?v=1 and the merge was the first
and only action by this account, so seems like malicious behavior to me.

Tom


>
> kc
>
> On 9/11/13 2:26 AM, Andy Carter wrote:
> > I am trying to add a new edition. It seems to have appeared as
> OL25430731M
> > however the author is Barbara Delinsky not Clive Cussler. I am unable to
> edit
> > anything more on that page.
> >
> > I see
> > expected /type/author, found /type/redirect
> > at the head of the save response page.
> >
> > All other edits today have been successful.
> >
> > Is something broken?
> >
> > Andy
>
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Edit/author issue

[Karen Coyle]

Yes, something is broken. Actually, it may be more than one thing. I 
went to the author search and saw two authors:
   http://openlibrary.org/search/authors?q=barbara+delinsky

When I click on the top one, it takes me to the Clive Cussler page. So 
this author is re-directing to Clive Cussler for some reason.

I do not know how to fix this. Anyone?

kc

On 9/11/13 2:26 AM, Andy Carter wrote:
> I am trying to add a new edition. It seems to have appeared as OL25430731M
> however the author is Barbara Delinsky not Clive Cussler. I am unable to edit
> anything more on that page.
>
> I see
> expected /type/author, found /type/redirect
> at the head of the save response page.
>
> All other edits today have been successful.
>
> Is something broken?
>
> Andy
> ___
> Ol-discuss mailing list - Ol-discuss@archive.org
> http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
> Archives: http://www.mail-archive.com/ol-discuss@archive.org/
> To unsubscribe from this mailing list, send email to 
> ol-discuss-unsubscr...@archive.org
>

-- 
Karen Coyle
kco...@kcoyle.net http://kcoyle.net
ph: 1-510-540-7596
m: 1-510-435-8234
skype: kcoylenet
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org