Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-08-24 Thread Tom Morris
Karen / Jessamyn - this thread has drifted a long way from its original
topic (and the subject doesn't represent any of the things talked about),
so I'm going to spin up a new thread or two to cover the topics being
recently discussed.  Some of them are probably more appropriate to ol-tech
than ol-discuss, although community development priorities is certainly a
candidate for this list.

Tom

On Fri, Aug 21, 2015 at 3:36 PM, Karen Coyle kco...@kcoyle.net wrote:

 Tom, et al.,

 Giovanni is the current developer, although he is working on other
 projects as well as OL so has limited time. He's also working to catch up
 since he's new.

 AFAIK, one of the things holding back outsourcing/crowdsourcing of OL code
 is the lack of a test instance and unit tests. I feel like we discussed
 this recently on this or another list... would that be a good place to
 start?

 kc

 On 8/21/15 12:23 PM, Tom Morris wrote:

 On Thu, Jul 2, 2015 at 8:44 PM, jessamyn c. west jessa...@gmail.com
 mailto:jessa...@gmail.com wrote:

 I'll be in touch with some of the IA folks after the holiday weekend
 in the US and I will raise this question.


 Jessamyn / Sam - did anything ever come of the discussions with the IA
 folks?

 I noticed Giovanni (@gdamdam https://github.com/gdamdam) made a few
 changes recently.  Is he the IA developer in charge of OpenLibrary now?

 Tom

 On Thu, Jul 2, 2015 at 8:42 PM, Charles Horn charles.h...@gmail.com
 mailto:charles.h...@gmail.com wrote:
  
  
   On 30 June 2015 at 04:29, Samuel Klein meta...@gmail.com
 mailto:meta...@gmail.com wrote:
  
  
   On Jun 29, 2015 2:15 PM, Tom Morris tfmor...@gmail.com
 mailto:tfmor...@gmail.com wrote:
   
   
There's a bunch of stuff that could be done to streamline the
 spam
flagging and processing, do more automated spam detection,
 etc.  The current
web form reporting and lone pioneer cleaning up doesn't scale...
   
It's sad to see because it wouldn't really take that much
 effort to make
it a thriving and vibrant site, but IA just doesn't care.
  
   I was just in SF running a CODEX hackathon, and met some IA folk
 who
   talked about how to make OL awesome again + better integrated 
 supported.
  
   So at least some people are discussing caring. And I believe
 they're
   looking to hire ~5 developers across the Archive.
  
   A list of priorities — from the community of OL users and would-be
   contributors — as a subset of the many many open bugs and
 requests — could
   be helpful to any new push.
  
   This sounds like great news. Is there a way to connect with these
 IA folk,
   or just let them know we are interested in supporting a revival
 of the
   project?
  
   Charles.
  
   ___
   Ol-discuss mailing list - Ol-discuss@archive.org
 mailto:Ol-discuss@archive.org
   http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
   Archives: http://www.mail-archive.com/ol-discuss@archive.org/
   To unsubscribe from this mailing list, send email to
   ol-discuss-unsubscr...@archive.org
 mailto:ol-discuss-unsubscr...@archive.org
 ___
 Ol-discuss mailing list - Ol-discuss@archive.org
 mailto:Ol-discuss@archive.org
 http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
 Archives: http://www.mail-archive.com/ol-discuss@archive.org/
 To unsubscribe from this mailing list, send email to
 ol-discuss-unsubscr...@archive.org
 mailto:ol-discuss-unsubscr...@archive.org




 ___
 Ol-discuss mailing list - Ol-discuss@archive.org
 http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
 Archives: http://www.mail-archive.com/ol-discuss@archive.org/
 To unsubscribe from this mailing list, send email to
 ol-discuss-unsubscr...@archive.org


 --
 Karen Coyle
 kco...@kcoyle.net http://kcoyle.net
 m: 1-510-435-8234
 skype: kcoylenet/+1-510-984-3600
 ___
 Ol-discuss mailing list - Ol-discuss@archive.org
 http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
 Archives: http://www.mail-archive.com/ol-discuss@archive.org/
 To unsubscribe from this mailing list, send email to
 ol-discuss-unsubscr...@archive.org

___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-08-21 Thread Tom Morris
On Thu, Jul 2, 2015 at 8:44 PM, jessamyn c. west jessa...@gmail.com wrote:

 I'll be in touch with some of the IA folks after the holiday weekend
 in the US and I will raise this question.


Jessamyn / Sam - did anything ever come of the discussions with the IA
folks?

I noticed Giovanni (@gdamdam https://github.com/gdamdam) made a few
changes recently.  Is he the IA developer in charge of OpenLibrary now?

Tom


 On Thu, Jul 2, 2015 at 8:42 PM, Charles Horn charles.h...@gmail.com
 wrote:
 
 
  On 30 June 2015 at 04:29, Samuel Klein meta...@gmail.com wrote:
 
 
  On Jun 29, 2015 2:15 PM, Tom Morris tfmor...@gmail.com wrote:
  
  
   There's a bunch of stuff that could be done to streamline the spam
   flagging and processing, do more automated spam detection, etc.  The
 current
   web form reporting and lone pioneer cleaning up doesn't scale...
  
   It's sad to see because it wouldn't really take that much effort to
 make
   it a thriving and vibrant site, but IA just doesn't care.
 
  I was just in SF running a CODEX hackathon, and met some IA folk who
  talked about how to make OL awesome again + better integrated 
 supported.
 
  So at least some people are discussing caring. And I believe they're
  looking to hire ~5 developers across the Archive.
 
  A list of priorities — from the community of OL users and would-be
  contributors — as a subset of the many many open bugs and requests —
 could
  be helpful to any new push.
 
  This sounds like great news. Is there a way to connect with these IA
 folk,
  or just let them know we are interested in supporting a revival of the
  project?
 
  Charles.
 
  ___
  Ol-discuss mailing list - Ol-discuss@archive.org
  http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
  Archives: http://www.mail-archive.com/ol-discuss@archive.org/
  To unsubscribe from this mailing list, send email to
  ol-discuss-unsubscr...@archive.org
 ___
 Ol-discuss mailing list - Ol-discuss@archive.org
 http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
 Archives: http://www.mail-archive.com/ol-discuss@archive.org/
 To unsubscribe from this mailing list, send email to
 ol-discuss-unsubscr...@archive.org

___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-08-21 Thread jessamyn c. west
 Jessamyn / Sam - did anything ever come of the discussions with the IA folks?

We had a very fruitful discussion about where we'd like to see things
going, but ultimately we have a fractional dev (Giovanni, who is
wonderful) which makes progress staggered at best as he moves between
projects. Having a list of priorities set by the OL community would be
helpful. Figuring out how to realistically manifest those into
priorities about where Gio's time is directed is a complex question
and one I do not have the answer to. Figuring out what non-OL/IA devs
could reasonably get accomplished would also be a good thing to pay
attention to.

 I noticed Giovanni (@gdamdam) made a few changes recently.  Is he the IA
 developer in charge of OpenLibrary now?

Yes, he does OL codebase changes as well as a few other things.

J
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-07-02 Thread Charles Horn
On 30 June 2015 at 03:00, jessamyn c. west jessa...@gmail.com wrote:

 Apologies for a late reply, it seems like you've done some great work.
 We can work to update the documentation.


Thanks, I'm happy to be able to help out!



  What should people like me who want to contribute to the codebase be
 working
  on, and who should we liaise with at OL/IA to make sure we are making
 useful
  contributions?

 I'm probably the right liasing person. Right now there is no active OL
 development, the main developer left in December and the backup
 developer is on his way out if he hasn't left already (not really
 project related afaict) and it's unclear whether even maintenance
 requests/tickets are being worked on, so I've been doing triage on
 bugs in addition to mostly just answering the support email that
 continues to come,.


An IA dev, Giovanni, merged my test fixes, and an old pull request of
Ben's, which fixed some reported rdf issues. That made me realise that
getting code merged is only the first step. The rdf changes have not been
deployed as far as I can tell, so knowing what is required for a production
release is the next piece to get any new fixes or features out there and
usable.



 The biggest challenge I have facing me now is the spam issue. We have
 a bunch of people adding spammy entries in Korean and no good way to
 either keep them out or even go back and bulk delete pattern-matched
 spam. I'd love to have a tool that does this. I'm not sure if a person
 working on the code would also need admin privs in terms of their
 account so please let me know if that's a stumbling block.


I noticed the spamming, which seems to be ongoing, and spent a bit of time
looking into how that was possible, it seems like there is  some level of
human intervention required to beat the re-captchas, but it's something
that spammers frequently do. The re-captchas on Openlibrary may not be
using the latest tricks available from Google, so there might be a way to
improve the spam protection to some extent, but from what I've read so far
nothing seems bullet proof, unfortunately.

For getting a list of the spam entries I found an undocumented(?) api call
to filter recent changes by the author which shows the adds and edits. Some
recent example from spam accounts:

https://openlibrary.org/recentchanges.json?author=/people/aesdfaff
https://openlibrary.org/recentchanges.json?author=/people/dxcvxvcv
https://openlibrary.org/recentchanges.json?author=/people/cutecutie498

Starting with a list of spam users and then collecting all their added
works shouldn't be too difficult. What is the current method of removing
unwanted entries? I could have a go at something that produces lists of OL
ids of spam based on user ids and send them through if you don't already
have a way to filter them.


 Just getting a group of developers looking at the code would be
 incredibly helpful on my end, to have someone to bounce minor issues
 off of. Let me know how I can help.


You mentioned an issue with the waiting lists as a priority, I couldn't
find a github issue with the details though. I had to fix up the waiting
list tests, so I could keep digging around there to see what I can improve.

 I'm worried now that getting updates released might be a much harder goal
that getting code merged if there aren't any IA devs to oversee the release
process, or support if something should go wrong. Merging code on github is
one thing, getting it released sounds like it could be close to impossible
if there isn't a currently functioning pipeline. There's a `production`
branch in github that is very far behind the current master (last update
2011!), I'm not sure exactly what code is in production as of now, but I
thought it had been updated since 2011?

Charles.
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-07-02 Thread Karen Coyle



On 7/2/15 4:35 AM, Charles Horn wrote:

  I'm worried now that getting updates released might be a much harder
goal that getting code merged if there aren't any IA devs to oversee the
release process, or support if something should go wrong. Merging code
on github is one thing, getting it released sounds like it could be
close to impossible if there isn't a currently functioning pipeline.
There's a `production` branch in github that is very far behind the
current master (last update 2011!), I'm not sure exactly what code is in
production as of now, but I thought it had been updated since 2011?


One of the barriers that I'm aware of is that Anand had the only test 
version of OL, and possibly the only test suite. I haven't looked at the 
github repo, but if there isn't a test suite, moving anything into 
production is pretty risky.


that said, I have no idea what the IA culture is for testing.

kc

--
Karen Coyle
kco...@kcoyle.net http://kcoyle.net
m: 1-510-435-8234
skype: kcoylenet/+1-510-984-3600
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-07-02 Thread Anand

On 02-Jul-2015, at 8:47 pm, jessamyn c. west jessa...@gmail.com wrote:

 Anand no longer works for OL/IA but it's true I think it's true that
 he had the test version. I'm a little new to OS development, what is
 the difference between getting the code merged and deploying it?

While I’m not officially part of IA anymore, I’ll be very happy to help to 
answer questions about the codebase. 

Anand
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-07-02 Thread Anand

On 02-Jul-2015, at 5:53 pm, Karen Coyle kco...@kcoyle.net wrote:

 
 
 On 7/2/15 4:35 AM, Charles Horn wrote:
  I'm worried now that getting updates released might be a much harder
 goal that getting code merged if there aren't any IA devs to oversee the
 release process, or support if something should go wrong. Merging code
 on github is one thing, getting it released sounds like it could be
 close to impossible if there isn't a currently functioning pipeline.
 There's a `production` branch in github that is very far behind the
 current master (last update 2011!), I'm not sure exactly what code is in
 production as of now, but I thought it had been updated since 2011?
 
 One of the barriers that I'm aware of is that Anand had the only test version 
 of OL, and possibly the only test suite. I haven't looked at the github repo, 
 but if there isn't a test suite, moving anything into production is pretty 
 risky.
 
 that said, I have no idea what the IA culture is for testing.

(facepalm)

Sadly, we don’t have very good test coverage.

What we have is a vagrant based dev setup, which mimics the production env. It 
is possible to test it manually before submitting a pull request.

Anand
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-07-02 Thread jessamyn c. west
I'll be in touch with some of the IA folks after the holiday weekend
in the US and I will raise this question.

That list of spammers is HUGELY helpful because at least it's a few
clicks to undoing thousands of edits until we can script the process.


Jessamyn

librarian.net ::: jessamyn.com ::: jessamyn.info ::: box 345, randolph vt 05060


On Thu, Jul 2, 2015 at 8:42 PM, Charles Horn charles.h...@gmail.com wrote:


 On 30 June 2015 at 04:29, Samuel Klein meta...@gmail.com wrote:


 On Jun 29, 2015 2:15 PM, Tom Morris tfmor...@gmail.com wrote:
 
 
  There's a bunch of stuff that could be done to streamline the spam
  flagging and processing, do more automated spam detection, etc.  The 
  current
  web form reporting and lone pioneer cleaning up doesn't scale...
 
  It's sad to see because it wouldn't really take that much effort to make
  it a thriving and vibrant site, but IA just doesn't care.

 I was just in SF running a CODEX hackathon, and met some IA folk who
 talked about how to make OL awesome again + better integrated  supported.

 So at least some people are discussing caring. And I believe they're
 looking to hire ~5 developers across the Archive.

 A list of priorities — from the community of OL users and would-be
 contributors — as a subset of the many many open bugs and requests — could
 be helpful to any new push.

 This sounds like great news. Is there a way to connect with these IA folk,
 or just let them know we are interested in supporting a revival of the
 project?

 Charles.

 ___
 Ol-discuss mailing list - Ol-discuss@archive.org
 http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
 Archives: http://www.mail-archive.com/ol-discuss@archive.org/
 To unsubscribe from this mailing list, send email to
 ol-discuss-unsubscr...@archive.org
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-07-02 Thread Charles Horn
On 30 June 2015 at 04:29, Samuel Klein meta...@gmail.com wrote:


 On Jun 29, 2015 2:15 PM, Tom Morris tfmor...@gmail.com wrote:
 
 
  There's a bunch of stuff that could be done to streamline the spam
 flagging and processing, do more automated spam detection, etc.  The
 current web form reporting and lone pioneer cleaning up doesn't scale...
 
  It's sad to see because it wouldn't really take that much effort to make
 it a thriving and vibrant site, but IA just doesn't care.

 I was just in SF running a CODEX hackathon, and met some IA folk who
 talked about how to make OL awesome again + better integrated  supported.

 So at least some people are discussing caring. And I believe they're
 looking to hire ~5 developers across the Archive.

 A list of priorities — from the community of OL users and would-be
 contributors — as a subset of the many many open bugs and requests — could
 be helpful to any new push.

This sounds like great news. Is there a way to connect with these IA folk,
or just let them know we are interested in supporting a revival of the
project?

Charles.
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-06-29 Thread Samuel Klein
On Jun 29, 2015 2:15 PM, Tom Morris tfmor...@gmail.com wrote:


 There's a bunch of stuff that could be done to streamline the spam
flagging and processing, do more automated spam detection, etc.  The
current web form reporting and lone pioneer cleaning up doesn't scale...

 It's sad to see because it wouldn't really take that much effort to make
it a thriving and vibrant site, but IA just doesn't care.

I was just in SF running a CODEX hackathon, and met some IA folk who talked
about how to make OL awesome again + better integrated  supported.

So at least some people are discussing caring. And I believe they're
looking to hire ~5 developers across the Archive.

A list of priorities — from the community of OL users and would-be
contributors — as a subset of the many many open bugs and requests — could
be helpful to any new push.

Sam
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-06-29 Thread Tom Morris
The ol-tech list is probably the right place to engage with potential
developers.  We had a brief period of re-invigoration a couple of years ago
where a group of developers were granted commit privileges to the developer
pages on the wiki and started getting things cleaned up.

Forking the code isn't a big deal.  Forking the website is a huge deal.  If
there's no path to get bug fixes and enhancements (in the form of pull
requests) reviewed and integrated into the deployed web site, it doesn't
make any sense to invest in doing the work.

The reason I, and I suspect some others, stopped being interested was that
there wasn't even any way to have a conversation with the IA folks, let
alone get any decisions made.  There's a bunch of stuff that could be done
to streamline the spam flagging and processing, do more automated spam
detection, etc.  The current web form reporting and lone pioneer cleaning
up doesn't scale and OpenLibrary will either continue to be more and more a
victim of broken window syndrome or more and more parts of the web site
will get locked down until it becomes a read-only wasteland.

It's sad to see because it wouldn't really take that much effort to make it
a thriving and vibrant site, but IA just doesn't care.

Tom

On Mon, Jun 29, 2015 at 1:00 PM, jessamyn c. west jessa...@gmail.com
wrote:

 Apologies for a late reply, it seems like you've done some great work.
 We can work to update the documentation.

  What should people like me who want to contribute to the codebase be
 working
  on, and who should we liaise with at OL/IA to make sure we are making
 useful
  contributions?

 I'm probably the right liasing person. Right now there is no active OL
 development, the main developer left in December and the backup
 developer is on his way out if he hasn't left already (not really
 project related afaict) and it's unclear whether even maintenance
 requests/tickets are being worked on, so I've been doing triage on
 bugs in addition to mostly just answering the support email that
 continues to come,.

 The biggest challenge I have facing me now is the spam issue. We have
 a bunch of people adding spammy entries in Korean and no good way to
 either keep them out or even go back and bulk delete pattern-matched
 spam. I'd love to have a tool that does this. I'm not sure if a person
 working on the code would also need admin privs in terms of their
 account so please let me know if that's a stumbling block.

 Just getting a group of developers looking at the code would be
 incredibly helpful on my end, to have someone to bounce minor issues
 off of. Let me know how I can help.

 Jessamyn
 ___
 Ol-discuss mailing list - Ol-discuss@archive.org
 http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
 Archives: http://www.mail-archive.com/ol-discuss@archive.org/
 To unsubscribe from this mailing list, send email to
 ol-discuss-unsubscr...@archive.org

___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-06-11 Thread Charles Horn
On 9 June 2015 at 04:18, Karen Coyle kco...@kcoyle.net wrote:


 My gut feeling is that the instructions at
 http://code.openlibrary.org/en/latest/ may not be up to date, but if
 folks are interesting in creating a version of OL we could ping the most
 recent committer and find out exactly what state it is in.


This thread inspired me dust off my attempts to get the development
environment running again and try to make some useful contributions. The
dev instance instructions at that link seem accurate, it did take me two
goes, but the issues I had were because I wasn't starting with a clean
codebase (my fault). I reset everything and by following the instructions
got the vagrant dev instance running under OSX easily.

The problem with the guide is that the subsequent sections aren't complete.
Getting Started with Development only talks about javascript, which is
possibly all accurate, but I haven't needed to do anything with that yet,
so it hasn't helped me 'get started' in any way. The helpful section to
have more detail would be the Architecture of the dev instance. Currently
it is just a to-do list of headings. I found that the instance would not
reliably restart after working immediately after install, so I had to go
searching in the scripts to work out what components existed and how they
should be restarted and so on. I seem to have figured it out so I can start
and stop things and check logs now, but it took a while, and there is a
possibility I have missed a more convenient way to do all this. There were
a couple of other minor issues which made me think that not all of the
setup and configuration has been done, but since this isn't the tech list I
won't go into details. The point is I am up and running from following the
instructions, with only a few minor issues.

The 'Known Issues' sections mentions that /admin is failing, but it
seemed to work fine for me.



 On 6/8/15 10:41 AM, jessamyn c. west wrote:


 Because I think what we want ideally is not just the functionality of
 Open Library code but having the existing infrastructure be supported
 and maintained better, but I'm willing to try to have a conversation
 about that with IA first if we think we can get some developers on
 board to really dig into the code. I have a few wishlist things I'd
 like to see happening that are mostly design-y in nature that would be
 some good first steps, but some of the existing code base interacts
 with code that is not open source on the Archive's servers (I think)
 so just forking it won't give you a functional version of Open
 Library. I'm not even sure from a structural perspective who can
 commit code from within the current github repo (or if I'm even using
 those words correctly)


I'd prefer to see the project continue to improve without forking, the code
isn't much use without the infrastructure and large datasets, and hopefully
that's what the IA can continue to provide.

To try and be helpful and improve the most obvious issue with the codebase,
I tried to get the tests passing on Travis, which I did. The pull request
is here: https://github.com/internetarchive/openlibrary/pull/250

There were two issues:
1: The waitinglists feature was moved from the local db to an external IA
API some time ago, but the tests were not updated to reflect this. The
argument names have changed too, and the tests have all sorts of database
setup that is no longer appropriate. I skipped these four tests, but they
probably should be re-written to test the changed behaviour. I could have a
go at doing that, but I want to see what the policy / likelihood of having
requests merged is before I spend more time on it.

2: The sign-up form test was failing because the spam domain lookup
validation wasn't stubbed in the test. I added that and it passes now.

These two changes will make the tests pass and change the Travis test
status badge on the main github page from red to green, which fixes the
most obvious broken window for an open source project.

I'd like someone who knows the code better to review my PR and provide
guidance on whether I should try to rewrite the waitinglists tests now. I'm
happy to spend time contributing to this project, but failing tests and
stale PRs don't send out strong messages of encouragement :) I'm trying to
get a ball rolling here to get that community of developers happening. I'm
not sure who I should be approaching though, are the github repo owners
active?

I realise this isn't the tech list, initially I thought it was, as the
discussion started getting techy, but lately ol-tech has just been about
integrating with the OL APIs, not active development _on_ OL itself. This
thread is the one that inspired me to dig into the code properly.

What should people like me who want to contribute to the codebase be
working on, and who should we liaise with at OL/IA to make sure we are
making useful contributions?

My background is strongly in testing, mostly in Ruby, lots of API work,
I've 

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-06-08 Thread todd.d.robb...@gmail.com
Colby,

Let's jumpstart that movement by forking
https://github.com/internetarchive/openlibrary


On Sunday, June 7, 2015, Karen Coyle kco...@kcoyle.net wrote:

 +1

 On 6/7/15 8:25 AM, Colby Russell wrote:

 On 06/06/2015 09:32 AM, jessamyn c. west wrote:

 It's a thing that isn't built into the back end so they've been
 reluctant to do it' but it's never a bad idea to ask again.


 The Internet Archive/Open Library isn't pushing OL as an open source
 project hard enough.

 The Open Library should be at least as useful as IMDB is for films, but
 it's not.  Not having enough content is one thing.  I can help fix that,
 and would, but every time I have a go at editing, I run into not just
 hurdles but full-on roadblocks of the sort we're already discussing
 here.  And that's been the case for years (both the existence of the
 roadblocks and the ineffectual discussions around them).

 It comes down to inadequacy of the code and the lack of direction in OL
 as a project, every time.

 The Internet Archive could put out a call that says, Hey, we're really
 looking for some help here, and it would reach the front page of HN
 /tomorrow/ and the codebase would be teeming with attention.  That
 interest might wane.  It almost definitely will. But OL should be able
 to come out of it with at least half a dozen or so serious contributors
 in the end, which in turn would allow an actual community of content
 editors to form.  It requires, though, that IA/OL position itself as
 appearing interested in help, and that's not the case right now.

 --
 Colby Russell


 ___
 Ol-discuss mailing list - Ol-discuss@archive.org
 http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
 Archives: http://www.mail-archive.com/ol-discuss@archive.org/
 To unsubscribe from this mailing list, send email to
 ol-discuss-unsubscr...@archive.org


 --
 Karen Coyle
 kco...@kcoyle.net http://kcoyle.net
 m: 1-510-435-8234
 skype: kcoylenet/+1-510-984-3600
 ___
 Ol-discuss mailing list - Ol-discuss@archive.org
 http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
 Archives: http://www.mail-archive.com/ol-discuss@archive.org/
 To unsubscribe from this mailing list, send email to
 ol-discuss-unsubscr...@archive.org



-- 
Tod Robbins
Digital Asset Manager, MLIS
todrobbins.com | @todrobbins http://www.twitter.com/#!/todrobbins
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-06-06 Thread smbreau
 I'm wondering if there are any plans to open up adminship/moderatorship 

 to some more people so volunteers can tidy up the mess rather than 

 having to report it. Zapping spam/vandalism/obvious crap as it happens 

 is important so as to ensure that OpenLibrary does not end with broken 

 windows symptoms. 






What is the policy on admin/moderators? I have stopped edition in Open Office 
because I can't make records right, and it's frustrating to only partway fix 
them. Every few months I check back in to see if I can merge works, but no. 
Other sites I edit (Discogs, GoodReads, ISFDb, etc) allow some users editing 
privileges. OL is the only one I have used that doesn't. Or maybe I haven't 
figured out how to ask for it?


Sarah___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org

Re: [ol-discuss] Ol-discuss Digest, Vol 88, Issue 1

2015-06-06 Thread jessamyn c. west
I'm the one paid staff member that I know of who is Open Library only.
I've asked before about trying to get some granular level of privs
(merges and spam would be the two important ones) for power users.
It's a thing that isn't built into the back end so they've been
reluctant to do it' but it's never a bad idea to ask again.


Jessamyn

librarian.net ::: jessamyn.com ::: jessamyn.info ::: box 345, randolph vt 05060


On Sat, Jun 6, 2015 at 10:25 AM,  smbr...@hotmail.com wrote:
 I'm wondering if there are any plans to open up adminship/moderatorship
 to some more people so volunteers can tidy up the mess rather than
 having to report it. Zapping spam/vandalism/obvious crap as it happens
 is important so as to ensure that OpenLibrary does not end with broken
 windows symptoms.

 What is the policy on admin/moderators? I have stopped edition in Open
 Office because I can't make records right, and it's frustrating to only
 partway fix them. Every few months I check back in to see if I can merge
 works, but no. Other sites I edit (Discogs, GoodReads, ISFDb, etc) allow
 some users editing privileges. OL is the only one I have used that doesn't.
 Or maybe I haven't figured out how to ask for it?

 Sarah


 ___
 Ol-discuss mailing list - Ol-discuss@archive.org
 http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
 Archives: http://www.mail-archive.com/ol-discuss@archive.org/
 To unsubscribe from this mailing list, send email to
 ol-discuss-unsubscr...@archive.org
___
Ol-discuss mailing list - Ol-discuss@archive.org
http://mail.archive.org/cgi-bin/mailman/listinfo/ol-discuss
Archives: http://www.mail-archive.com/ol-discuss@archive.org/
To unsubscribe from this mailing list, send email to 
ol-discuss-unsubscr...@archive.org