Re: [Call-for-​Review] one fix for odt saving performance improvement

[li zhang]

hi Pitonyak

Thank you for your attention to this topic. I will test the sample file
mentioned in your mail and update the result.
On Fri, Jun 22, 2012 at 2:45 PM, Andrew Douglas Pitonyak <
and...@pitonyak.org> wrote:

>  On 06/21/2012 01:00 AM, li zhang wrote:
>
>> hi, all
>> I'm zhang li from China. My main focus is performance(loading, saving,
>> asynchronous loading, etc).
>>
>> I have one fix need for review. It is about odt saving. Please check the
>> below for details, thanks!
>>
>> https://issues.apache.org/ooo/**show_bug.cgi?id=120030
>>
>> root cause:
>> Do profiling on a sample file, SfxObjectShell::**GenerateAndStoreThumbnail
>> is
>> to be found occypy too much time, and it will call SwFlyFrm::Paint several
>> times, but it's unnecessary to paint thumbnail so many times when saving.
>>
>> solution:
>> When thumbnail is generated and stored, in SwFlyFrm::Paint, current
>> visible
>> rectangle will be compared with fly frame rectangle, if the two rectangles
>> don't intersect, SwFlyFrm::Paint will return, need no repaint.
>>
>> Excellent I hope this speeds up the save time on
>
> http://www.pitonyak.org/OOME_**3_0.odt
>
> Document loads pretty fast, but saving is horrid!
>
> Do you have a link for more information related to "how to profile OOo"?
>
> --
> Andrew Pitonyak
> My Macro Document: 
> http://www.pitonyak.org/**AndrewMacro.odt
> Info:  http://www.pitonyak.org/oo.php
>
>
>
>

Re: [Call-for-​Review] one fix for odt saving performance improvement

[li zhang]

hi, Juergen

thanks you for your interest in this topic and really appreciate your help.
On Fri, Jun 22, 2012 at 3:29 PM, Jürgen Schmidt
wrote:

>  On 6/21/12 10:20 AM, Jürgen Schmidt wrote:
> > On 6/21/12 7:06 AM, li zhang wrote:
> >> for more information, you can refer to the below link:
> >>
> >>
> http://wiki.services.openoffice.org/wiki/ODT_saving_performance_improvement
> >>
> >> On Thu, Jun 21, 2012 at 1:00 PM, li zhang  wrote:
> >>
> >>> hi, all
> >>> I'm zhang li from China. My main focus is performance(loading, saving,
> >>> asynchronous loading, etc).
> >>>
> >>> I have one fix need for review. It is about odt saving. Please check
> the
> >>> below for details, thanks!
> >>>
> >>> https://issues.apache.org/ooo/show_bug.cgi?id=120030
> >>>
> >>> root cause:
> >>> Do profiling on a sample file,
> SfxObjectShell::GenerateAndStoreThumbnail
> >>> is to be found occypy too much time, and it will call SwFlyFrm::Paint
> >>> several times, but it's unnecessary to paint thumbnail so many times
> when
> >>> saving.
> >>>
> >>> solution:
> >>> When thumbnail is generated and stored, in SwFlyFrm::Paint, current
> >>> visible rectangle will be compared with fly frame rectangle, if the two
> >>> rectangles don't intersect, SwFlyFrm::Paint will return, need no
> repaint.
> >>>
> >>
> >
> > I will take care of this
>
> I had some problems with building on trunk in general. Nothing that
> depends on your patch but it takes more time to built and test the patch.
>
> Juergen
>
>
>

Re: [Call-for-​Review] one fix for odt saving performance improvement

[Jürgen Schmidt]

On 6/21/12 10:20 AM, Jürgen Schmidt wrote:
> On 6/21/12 7:06 AM, li zhang wrote:
>> for more information, you can refer to the below link:
>>
>> http://wiki.services.openoffice.org/wiki/ODT_saving_performance_improvement
>>
>> On Thu, Jun 21, 2012 at 1:00 PM, li zhang  wrote:
>>
>>> hi, all
>>> I'm zhang li from China. My main focus is performance(loading, saving,
>>> asynchronous loading, etc).
>>>
>>> I have one fix need for review. It is about odt saving. Please check the
>>> below for details, thanks!
>>>
>>> https://issues.apache.org/ooo/show_bug.cgi?id=120030
>>>
>>> root cause:
>>> Do profiling on a sample file, SfxObjectShell::GenerateAndStoreThumbnail
>>> is to be found occypy too much time, and it will call SwFlyFrm::Paint
>>> several times, but it's unnecessary to paint thumbnail so many times when
>>> saving.
>>>
>>> solution:
>>> When thumbnail is generated and stored, in SwFlyFrm::Paint, current
>>> visible rectangle will be compared with fly frame rectangle, if the two
>>> rectangles don't intersect, SwFlyFrm::Paint will return, need no repaint.
>>>
>>
> 
> I will take care of this

I had some problems with building on trunk in general. Nothing that
depends on your patch but it takes more time to built and test the patch.

Juergen

Re: [Call-for-​Review] one fix for odt saving performance improvement

[Chao Huang]

hi, Pitonyak

Thanks for your interest in this topic. This fixed only improves the saving
for odt file, which contains a lot of pictures. I will try to test with
your sample file and update the result for you.

Excellent I hope this speeds up the save time on
>
> http://www.pitonyak.org/OOME_3_0.odt
>
> Document loads pretty fast, but saving is horrid!
>
> Do you have a link for more information related to "how to profile OOo"?
>
> --
> Andrew Pitonyak
> My Macro Document: http://www.pitonyak.org/AndrewMacro.odt
> Info:  http://www.pitonyak.org/oo.php
>
>
>
>
>


-- 
Best regards,
Chao Huang

Re: [Call-for-​Review] one fix for odt saving performance improvement

[Andrew Douglas Pitonyak]

On 06/21/2012 01:00 AM, li zhang wrote:

hi, all
I'm zhang li from China. My main focus is performance(loading, saving,
asynchronous loading, etc).

I have one fix need for review. It is about odt saving. Please check the
below for details, thanks!

https://issues.apache.org/ooo/show_bug.cgi?id=120030

root cause:
Do profiling on a sample file, SfxObjectShell::GenerateAndStoreThumbnail is
to be found occypy too much time, and it will call SwFlyFrm::Paint several
times, but it's unnecessary to paint thumbnail so many times when saving.

solution:
When thumbnail is generated and stored, in SwFlyFrm::Paint, current visible
rectangle will be compared with fly frame rectangle, if the two rectangles
don't intersect, SwFlyFrm::Paint will return, need no repaint.


Excellent I hope this speeds up the save time on

http://www.pitonyak.org/OOME_3_0.odt

Document loads pretty fast, but saving is horrid!

Do you have a link for more information related to "how to profile OOo"?

--
Andrew Pitonyak
My Macro Document: http://www.pitonyak.org/AndrewMacro.odt
Info:  http://www.pitonyak.org/oo.php

Re: [Call-for-​Review] one fix for odt saving performance improvement

[Jürgen Schmidt]

On 6/21/12 7:06 AM, li zhang wrote:
> for more information, you can refer to the below link:
> 
> http://wiki.services.openoffice.org/wiki/ODT_saving_performance_improvement
> 
> On Thu, Jun 21, 2012 at 1:00 PM, li zhang  wrote:
> 
>> hi, all
>> I'm zhang li from China. My main focus is performance(loading, saving,
>> asynchronous loading, etc).
>>
>> I have one fix need for review. It is about odt saving. Please check the
>> below for details, thanks!
>>
>> https://issues.apache.org/ooo/show_bug.cgi?id=120030
>>
>> root cause:
>> Do profiling on a sample file, SfxObjectShell::GenerateAndStoreThumbnail
>> is to be found occypy too much time, and it will call SwFlyFrm::Paint
>> several times, but it's unnecessary to paint thumbnail so many times when
>> saving.
>>
>> solution:
>> When thumbnail is generated and stored, in SwFlyFrm::Paint, current
>> visible rectangle will be compared with fly frame rectangle, if the two
>> rectangles don't intersect, SwFlyFrm::Paint will return, need no repaint.
>>
> 

I will take care of this

Juergen

Re: [Call-for-​Review] one fix for odt saving performance improvement

[li zhang]

for more information, you can refer to the below link:

http://wiki.services.openoffice.org/wiki/ODT_saving_performance_improvement

On Thu, Jun 21, 2012 at 1:00 PM, li zhang  wrote:

> hi, all
> I'm zhang li from China. My main focus is performance(loading, saving,
> asynchronous loading, etc).
>
> I have one fix need for review. It is about odt saving. Please check the
> below for details, thanks!
>
> https://issues.apache.org/ooo/show_bug.cgi?id=120030
>
> root cause:
> Do profiling on a sample file, SfxObjectShell::GenerateAndStoreThumbnail
> is to be found occypy too much time, and it will call SwFlyFrm::Paint
> several times, but it's unnecessary to paint thumbnail so many times when
> saving.
>
> solution:
> When thumbnail is generated and stored, in SwFlyFrm::Paint, current
> visible rectangle will be compared with fly frame rectangle, if the two
> rectangles don't intersect, SwFlyFrm::Paint will return, need no repaint.
>

[Call-for-​Review] one fix for odt saving performance improvement

[li zhang]

hi, all
I'm zhang li from China. My main focus is performance(loading, saving,
asynchronous loading, etc).

I have one fix need for review. It is about odt saving. Please check the
below for details, thanks!

https://issues.apache.org/ooo/show_bug.cgi?id=120030

root cause:
Do profiling on a sample file, SfxObjectShell::GenerateAndStoreThumbnail is
to be found occypy too much time, and it will call SwFlyFrm::Paint several
times, but it's unnecessary to paint thumbnail so many times when saving.

solution:
When thumbnail is generated and stored, in SwFlyFrm::Paint, current visible
rectangle will be compared with fly frame rectangle, if the two rectangles
don't intersect, SwFlyFrm::Paint will return, need no repaint.