Re: [Oorexx-devel] RexxUtil test coverage
Greetings Rick, Rick McGuire wrote: On Fri, Feb 8, 2019 at 6:23 AM Michael Lueck mailto:mlu...@lueckdatasystems.com>> wrote: I added some of the RexxUtil functions. So please let me know how I may assist in contributing test cases for those functions. Take a look at what functions we are missing test cases for, or even don't have many cases for in the test suite and pick one. You might want to post a notice here when you start work on tests for a functions to avoid someone else duplicating your work. Sure. I will look over what exists and consider what gaps I am able to fill. Perhaps if I were to mount the share to our file server to several mount points I could get back up to the number of objects that used to cause the crash. /mnt/ldslnx01/data, /mnt/ldslnx01/data2, etc... Thoughts, or do you think what Mark resolved back then resolved a crash trying to build a file tree of too many objects? I don't really know if Mark resolved this crash or not, but the SysFileTree code has been completely rewritten with my version. One of the goals of the rewrite was to avoid those sorts of crashes, so hopefully this problem is dead-and-buried. Then it sounds like I should do my /mnt/ldslnx01/data, /mnt/ldslnx01/data2, etc... idea and really stress test the new code. I will do that as well on my own / not by creating a test case. At least the Linux version will be stress tested this way. I am thankful, -- Michael Lueck Lueck Data Systems http://www.lueckdatasystems.com/ ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
Re: [Oorexx-devel] RexxUtil test coverage
On Fri, Feb 8, 2019 at 6:23 AM Michael Lueck wrote: > Greeting Rick, > > Rick McGuire wrote: > > If anybody would like to help out with this effort, contributing tests > for rexxutil functions would be an excellent way to chip in. > > I added some of the RexxUtil functions. So please let me know how I may > assist in contributing test cases for those functions. > > Take a look at what functions we are missing test cases for, or even don't have many cases for in the test suite and pick one. You might want to post a notice here when you start work on tests for a functions to avoid someone else duplicating your work. > Also, on SysFileTree... you seem to have done much work on that function > which is one of my personal favorites. A long long time ago now... prior to > me doing major cleanup on our file server, doing a > SysFileTree call against the entire collection of files would crash the > function. > > "#973 SysFileTree causes Segmentation fault" > https://sourceforge.net/p/oorexx/bugs/973/ > > Seems now that I have looked it back up, Mark did find something wrong... > not that it was closed as un-reproducible. Unfortunately I had already done > the major cleanup on our file server, so at that > time I could not say if what Mark did resolved the problem. > > Perhaps if I were to mount the share to our file server to several mount > points I could get back up to the number of objects that used to cause the > crash. /mnt/ldslnx01/data, /mnt/ldslnx01/data2, etc... > > Thoughts, or do you think what Mark resolved back then resolved a crash > trying to build a file tree of too many objects? > > I don't really know if Mark resolved this crash or not, but the SysFileTree code has been completely rewritten with my version. One of the goals of the rewrite was to avoid those sorts of crashes, so hopefully this problem is dead-and-buried. Rick > I am thankful, > > -- > Michael Lueck > Lueck Data Systems > http://www.lueckdatasystems.com/ > > > ___ > Oorexx-devel mailing list > Oorexx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/oorexx-devel > ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
Re: [Oorexx-devel] RexxUtil test coverage
Ahso :-)) Might be worth contacting the Boeb folk .. could well be a hoarder there who kept testcases ... :-) _ From: Rick McGuire [mailto:object.r...@gmail.com] Sent: 04 February 2019 13:11 To: Open Object Rexx Developer Mailing List Subject: Re: [Oorexx-devel] RexxUtil test coverage On Mon, Feb 4, 2019 at 8:07 AM Mike Cowlishaw wrote: I 'delegated' REX functions to Steve Davies very early on, so don't have any testcases. But now I think about it, I forget where the 'Sys' functions came from. Maybe the original author has testcases... ? For many of them, *I* was the original author :-) Most of the rest were written by the folks in Boeblingen and we didn't receive any testcases when Object Rexx was open sourced, so the cases we have were created since then. We have been steadily improving them, but there are some gaping holes, as I just discovered. This is a good opportunity to fix some of those holes. Rick Mike I'm trying to work my way through regression testing all of the RexxUtil functions and I'm not finding any tests for a lot of these functions. For example, there don't seem to be any tests at all for the SysStem* functions. Are we really missing tests for large chunks of these functions? Since a lot of these functions have been reworked, they should get a thorough retesting. If anybody would like to help out with this effort, contributing tests for rexxutil functions would be an excellent way to chip in. Rick ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
Re: [Oorexx-devel] RexxUtil test coverage
On Mon, Feb 4, 2019 at 8:07 AM Mike Cowlishaw wrote: > I 'delegated' REX functions to Steve Davies very early on, so don't have > any testcases. But now I think about it, I forget where the 'Sys' > functions came from. Maybe the original author has testcases... ? > For many of them, *I* was the original author :-) Most of the rest were written by the folks in Boeblingen and we didn't receive any testcases when Object Rexx was open sourced, so the cases we have were created since then. We have been steadily improving them, but there are some gaping holes, as I just discovered. This is a good opportunity to fix some of those holes. Rick > > Mike > > I'm trying to work my way through regression testing all of the RexxUtil > functions and I'm not finding any tests for a lot of these functions. For > example, there don't seem to be any tests at all for the SysStem* > functions. Are we really missing tests for large chunks of these functions? > Since a lot of these functions have been reworked, they should get a > thorough retesting. > > If anybody would like to help out with this effort, contributing tests for > rexxutil functions would be an excellent way to chip in. > > Rick > > ___ > Oorexx-devel mailing list > Oorexx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/oorexx-devel > ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
Re: [Oorexx-devel] RexxUtil test coverage
I 'delegated' REX functions to Steve Davies very early on, so don't have any testcases. But now I think about it, I forget where the 'Sys' functions came from. Maybe the original author has testcases... ? Mike I'm trying to work my way through regression testing all of the RexxUtil functions and I'm not finding any tests for a lot of these functions. For example, there don't seem to be any tests at all for the SysStem* functions. Are we really missing tests for large chunks of these functions? Since a lot of these functions have been reworked, they should get a thorough retesting. If anybody would like to help out with this effort, contributing tests for rexxutil functions would be an excellent way to chip in. Rick ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
[Oorexx-devel] RexxUtil test coverage
I'm trying to work my way through regression testing all of the RexxUtil functions and I'm not finding any tests for a lot of these functions. For example, there don't seem to be any tests at all for the SysStem* functions. Are we really missing tests for large chunks of these functions? Since a lot of these functions have been reworked, they should get a thorough retesting. If anybody would like to help out with this effort, contributing tests for rexxutil functions would be an excellent way to chip in. Rick ___ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
