Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-23 Thread Christian Seiler
On 12/23/2016 09:17 PM, Andrew Patterson wrote:
> On 12/23/2016 11:18 AM, The Lee-Man wrote:
>> On Friday, December 23, 2016 at 7:32:27 AM UTC-8, Christian Seiler wrote:
>>
>> On 12/22/2016 07:07 PM, Andrew Patterson wrote:
>> > I found a bnx2x card with iscsi hardware offload support. Running
>> > iscsistart -f does bring the interace up and assign an IP to it as
>> > long as OFFLOAD_BOOT_SUPPORTED is defined. However, iscsistart -b
>> needs iscsiuio
>> > running to log into a LUN, which the current debian scripts do not
>> > start (or even add to the initramfs).
>>
>> So the reason why neither Ritesh nor I have added support for
>> iscsiuio in the initramfs to the Debian package is that we both
>> don't have any hardware with a corresponding network card, so
>> we are really unable to test it.
>>
>>  
>>
>> We'll gladly accept patches for the initramfs logic (or even
>> help writing them if you agree to test them) to get this working,
>> so please feel free to contact me, either privately or via the
>> Debian bugtracker, in this regard.
>>
> 
> I can start on this after the end of the year, testing or providing a
> patch or both. I will file a debian bug.

Many thanks!

Note that if you want to see this in Stretch because of the
looming freeze deadline, this has to be done until Jan 25th.
(I could live with this going into either Stretch or the
Debian release following that, so no pressure if you don't
get to it until then, just wanted to make you aware of the
deadline.)

Regards,
Christian

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-23 Thread Andrew Patterson
On 12/23/2016 11:18 AM, The Lee-Man wrote:
> On Friday, December 23, 2016 at 7:32:27 AM UTC-8, Christian Seiler wrote:
> 
> On 12/22/2016 07:07 PM, Andrew Patterson wrote:
> > I found a bnx2x card with iscsi hardware offload support. Running
> > iscsistart -f does bring the interace up and assign an IP to it as
> > long as OFFLOAD_BOOT_SUPPORTED is defined. However, iscsistart -b
> needs iscsiuio
> > running to log into a LUN, which the current debian scripts do not
> > start (or even add to the initramfs).
> 
> So the reason why neither Ritesh nor I have added support for
> iscsiuio in the initramfs to the Debian package is that we both
> don't have any hardware with a corresponding network card, so
> we are really unable to test it.
> 
>  
> 
> We'll gladly accept patches for the initramfs logic (or even
> help writing them if you agree to test them) to get this working,
> so please feel free to contact me, either privately or via the
> Debian bugtracker, in this regard.
> 

I can start on this after the end of the year, testing or providing a
patch or both. I will file a debian bug.

> Regards,
> Christian
> 
> 
> I have a similar issue for SUSE. I have one BNX card, but it is
> an engineering prototype that actually does not work correctly.
> 
> It seems like it would behoove the card manufacturers to have
> a loaner program for OS enablement.
> 

They all have loaner programs I believe (Emulex in particular is very
good at this). The issue is almost always who to contact.

Andrew


-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-23 Thread The Lee-Man
On Friday, December 23, 2016 at 7:32:27 AM UTC-8, Christian Seiler wrote:
>
> On 12/22/2016 07:07 PM, Andrew Patterson wrote: 
> > I found a bnx2x card with iscsi hardware offload support. Running 
> > iscsistart -f does bring the interace up and assign an IP to it as 
> > long as OFFLOAD_BOOT_SUPPORTED is defined. However, iscsistart -b needs 
> iscsiuio 
> > running to log into a LUN, which the current debian scripts do not 
> > start (or even add to the initramfs). 
>
> So the reason why neither Ritesh nor I have added support for 
> iscsiuio in the initramfs to the Debian package is that we both 
> don't have any hardware with a corresponding network card, so 
> we are really unable to test it. 
>
 

> We'll gladly accept patches for the initramfs logic (or even 
> help writing them if you agree to test them) to get this working, 
> so please feel free to contact me, either privately or via the 
> Debian bugtracker, in this regard. 
>
> Regards, 
> Christian 
>

I have a similar issue for SUSE. I have one BNX card, but it is
an engineering prototype that actually does not work correctly.

It seems like it would behoove the card manufacturers to have
a loaner program for OS enablement. 

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-23 Thread Christian Seiler
On 12/22/2016 07:07 PM, Andrew Patterson wrote:
> I found a bnx2x card with iscsi hardware offload support. Running
> iscsistart -f does bring the interace up and assign an IP to it as
> long as OFFLOAD_BOOT_SUPPORTED is defined. However, iscsistart -b needs 
> iscsiuio
> running to log into a LUN, which the current debian scripts do not
> start (or even add to the initramfs).

So the reason why neither Ritesh nor I have added support for
iscsiuio in the initramfs to the Debian package is that we both
don't have any hardware with a corresponding network card, so
we are really unable to test it.

We'll gladly accept patches for the initramfs logic (or even
help writing them if you agree to test them) to get this working,
so please feel free to contact me, either privately or via the
Debian bugtracker, in this regard.

Regards,
Christian

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-22 Thread Andrew Patterson
On 12/20/2016 12:28 PM, Andrew Patterson wrote:
> On 12/20/2016 12:13 PM, Mike Christie wrote:
>> On 12/20/2016 12:15 PM, Andrew Patterson wrote:
>>> On 12/12/2016 02:38 PM, Andrew Patterson wrote:


 On Friday, December 9, 2016 at 3:33:57 PM UTC-7, Mike Christie wrote:

 On 12/08/2016 10:55 AM, andrew.p...@hpe.com  wrote:
 > I am trying to get iSCSI boot working on a debian-based system
 > using built-in uEFI iSCSI initiator firmware and broadcom
 > NICs (bnx2x).
 >
 > The debian initramfs uses the ibft support in iscsistart to log
 > into the root volume. The initramfs script uses iscsistart -N to
 > bring up the NICs before logging in with iscsstart -b. This
 > process works fine when using non-offload NICs, but fails when
 > using NICs using the bnx2, bnx2x, cxgb3, and cxgb4 drivers due to
 > the following code in
 > utils/fwparam_ibft/fw_entry.c:fw_setup_nics():
 >
 > list_for_each_entry(context, , list) {  
 > /* if it is a offload nic ignore it */
 > if (!net_get_transport_name_from_netdev(context->iface,
 > transport))
 > continue
 >
 >
 > Which does a lookup in the table in usr/iscsi_net_util.c
 >
 > static struct iscsi_net_driver net_drivers[] = {
 > {"cxgb3", "cxgb3i" },
 > {"cxgb4", "cxgb4i" },
 > {"bnx2", "bnx2i" },
 > {"bnx2x", "bnx2i"},
 > {NULL, NULL}
 > };
 >
 >
 > to see if -N should skip this NIC.  I cannot determine the reason
 > for this check. Do iscsi offload NICs not need to be configured
 > for boot? The current code causes iscsi boots to fail. I removed the
 > check and booting works fine.
 >

 If you use the ibft net info for the nic, what do you use for the iscsi
 offload engine? 


 I am not configuring it at boot (at least not yet). I haven't tried
 using the boot support in the NIC firmware yet, just the uEFI iSCSI 
 firmware
 which will work with any NIC.


  

 Do they both have the same IP, and are you creating boot
 iscsi sessions through the offload engine?


 I am not using offload yet. But I will probably need to get this working 
 next.



 cxgb*i is able to share the net info. The normal old nic engine and
 iscsi engine are able to use the same IP. That originally was not
 supposed to be allowed upstream, but it got in.

 bnx2* is (or at least was when we wrote that code) not able to share 
 the
 net info. The nic and iscsi engines need different IPs.


 That makes some sense. The firmware has two different MAC addresses,
 one for the NIC and one for iSCSI.


  


 So to cover both types we just use the ibft net info for the iscsi
 offload engines.

 In the version of the code you are using is OFFLOAD_BOOT_SUPPORTED
 defined in open-iscsi/usr/iface.c or not?


 Version 2.0.874. OFFLOAD_BOOT_SUPPORTED is in the code but not defined.



 If it's not defined and you modified the code like you described, then 
 I
 think you would use the ibft info to setup the normal old nic, and then
 you would end up creating a boot session using software iscsi. 


 Yes, I believe that is the result I am getting.


  

 I am not
 100% sure about this last statement. I cannot remember and just looked
 at the code for a couple minutes.


 I will try defining OFFLOAD_BOOT_SUPPORTED to see if that brings up the 
 NIC.

  

>>>
>>> I tried defining OFFLOAD_BOOT_SUPPORTED. The NIC is brought up but no
>>> IP is assigned. Is that expected? I have been using the uEFI iSCSI
>>
>> It is expected for what you are doing. I misunderstood what you were
>> trying to do.
>>
>>> driver which does not support hardware offload. I also have at least
>>> one bnx2x NIC that does not support iSCSI hardware offload:
>>>
>>> 02:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5719
>>> Gigabit Ethernet PCIe (rev 01)
>>> 02:00.0 0200: 14e4:1657 (rev 01)
>>>
>>> Do we need some sort of whitelist or a command-line flag to support these 
>>> sort
>>> of configurations?
>>>
>>
>> I thought you wanted to use a iscsi offload engine in the broadcom card.
>> If you wanted to use a card that is in those offload lists for normal
>> old networking, have iscsistart bring it up and do iscsi root using
>> software iscsi, then yeah, I think we need some sort of flag.
>>
> 
> I want to do both. I 

Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-20 Thread Andrew Patterson
On 12/20/2016 12:13 PM, Mike Christie wrote:
> On 12/20/2016 12:15 PM, Andrew Patterson wrote:
>> On 12/12/2016 02:38 PM, Andrew Patterson wrote:
>>>
>>>
>>> On Friday, December 9, 2016 at 3:33:57 PM UTC-7, Mike Christie wrote:
>>>
>>> On 12/08/2016 10:55 AM, andrew.p...@hpe.com  wrote:
>>> > I am trying to get iSCSI boot working on a debian-based system
>>> > using built-in uEFI iSCSI initiator firmware and broadcom
>>> > NICs (bnx2x).
>>> >
>>> > The debian initramfs uses the ibft support in iscsistart to log
>>> > into the root volume. The initramfs script uses iscsistart -N to
>>> > bring up the NICs before logging in with iscsstart -b. This
>>> > process works fine when using non-offload NICs, but fails when
>>> > using NICs using the bnx2, bnx2x, cxgb3, and cxgb4 drivers due to
>>> > the following code in
>>> > utils/fwparam_ibft/fw_entry.c:fw_setup_nics():
>>> >
>>> > list_for_each_entry(context, , list) {  
>>> > /* if it is a offload nic ignore it */
>>> > if (!net_get_transport_name_from_netdev(context->iface,
>>> > transport))
>>> > continue
>>> >
>>> >
>>> > Which does a lookup in the table in usr/iscsi_net_util.c
>>> >
>>> > static struct iscsi_net_driver net_drivers[] = {
>>> > {"cxgb3", "cxgb3i" },
>>> > {"cxgb4", "cxgb4i" },
>>> > {"bnx2", "bnx2i" },
>>> > {"bnx2x", "bnx2i"},
>>> > {NULL, NULL}
>>> > };
>>> >
>>> >
>>> > to see if -N should skip this NIC.  I cannot determine the reason
>>> > for this check. Do iscsi offload NICs not need to be configured
>>> > for boot? The current code causes iscsi boots to fail. I removed the
>>> > check and booting works fine.
>>> >
>>>
>>> If you use the ibft net info for the nic, what do you use for the iscsi
>>> offload engine? 
>>>
>>>
>>> I am not configuring it at boot (at least not yet). I haven't tried
>>> using the boot support in the NIC firmware yet, just the uEFI iSCSI firmware
>>> which will work with any NIC.
>>>
>>>
>>>  
>>>
>>> Do they both have the same IP, and are you creating boot
>>> iscsi sessions through the offload engine?
>>>
>>>
>>> I am not using offload yet. But I will probably need to get this working 
>>> next.
>>>
>>>
>>>
>>> cxgb*i is able to share the net info. The normal old nic engine and
>>> iscsi engine are able to use the same IP. That originally was not
>>> supposed to be allowed upstream, but it got in.
>>>
>>> bnx2* is (or at least was when we wrote that code) not able to share the
>>> net info. The nic and iscsi engines need different IPs.
>>>
>>>
>>> That makes some sense. The firmware has two different MAC addresses,
>>> one for the NIC and one for iSCSI.
>>>
>>>
>>>  
>>>
>>>
>>> So to cover both types we just use the ibft net info for the iscsi
>>> offload engines.
>>>
>>> In the version of the code you are using is OFFLOAD_BOOT_SUPPORTED
>>> defined in open-iscsi/usr/iface.c or not?
>>>
>>>
>>> Version 2.0.874. OFFLOAD_BOOT_SUPPORTED is in the code but not defined.
>>>
>>>
>>>
>>> If it's not defined and you modified the code like you described, then I
>>> think you would use the ibft info to setup the normal old nic, and then
>>> you would end up creating a boot session using software iscsi. 
>>>
>>>
>>> Yes, I believe that is the result I am getting.
>>>
>>>
>>>  
>>>
>>> I am not
>>> 100% sure about this last statement. I cannot remember and just looked
>>> at the code for a couple minutes.
>>>
>>>
>>> I will try defining OFFLOAD_BOOT_SUPPORTED to see if that brings up the NIC.
>>>
>>>  
>>>
>>
>> I tried defining OFFLOAD_BOOT_SUPPORTED. The NIC is brought up but no
>> IP is assigned. Is that expected? I have been using the uEFI iSCSI
> 
> It is expected for what you are doing. I misunderstood what you were
> trying to do.
> 
>> driver which does not support hardware offload. I also have at least
>> one bnx2x NIC that does not support iSCSI hardware offload:
>>
>> 02:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5719
>> Gigabit Ethernet PCIe (rev 01)
>> 02:00.0 0200: 14e4:1657 (rev 01)
>>
>> Do we need some sort of whitelist or a command-line flag to support these 
>> sort
>> of configurations?
>>
> 
> I thought you wanted to use a iscsi offload engine in the broadcom card.
> If you wanted to use a card that is in those offload lists for normal
> old networking, have iscsistart bring it up and do iscsi root using
> software iscsi, then yeah, I think we need some sort of flag.
> 

I want to do both. I haven't been able to get software iSCSI working
because the cards/configurations I have been using are effectively
blacklisted (unless I use some sort of hack). I am still working on
finding a card/server 

Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-20 Thread Mike Christie
On 12/20/2016 12:15 PM, Andrew Patterson wrote:
> On 12/12/2016 02:38 PM, Andrew Patterson wrote:
>>
>>
>> On Friday, December 9, 2016 at 3:33:57 PM UTC-7, Mike Christie wrote:
>>
>> On 12/08/2016 10:55 AM, andrew.p...@hpe.com  wrote:
>> > I am trying to get iSCSI boot working on a debian-based system
>> > using built-in uEFI iSCSI initiator firmware and broadcom
>> > NICs (bnx2x).
>> >
>> > The debian initramfs uses the ibft support in iscsistart to log
>> > into the root volume. The initramfs script uses iscsistart -N to
>> > bring up the NICs before logging in with iscsstart -b. This
>> > process works fine when using non-offload NICs, but fails when
>> > using NICs using the bnx2, bnx2x, cxgb3, and cxgb4 drivers due to
>> > the following code in
>> > utils/fwparam_ibft/fw_entry.c:fw_setup_nics():
>> >
>> > list_for_each_entry(context, , list) {  
>> > /* if it is a offload nic ignore it */
>> > if (!net_get_transport_name_from_netdev(context->iface,
>> > transport))
>> > continue
>> >
>> >
>> > Which does a lookup in the table in usr/iscsi_net_util.c
>> >
>> > static struct iscsi_net_driver net_drivers[] = {
>> > {"cxgb3", "cxgb3i" },
>> > {"cxgb4", "cxgb4i" },
>> > {"bnx2", "bnx2i" },
>> > {"bnx2x", "bnx2i"},
>> > {NULL, NULL}
>> > };
>> >
>> >
>> > to see if -N should skip this NIC.  I cannot determine the reason
>> > for this check. Do iscsi offload NICs not need to be configured
>> > for boot? The current code causes iscsi boots to fail. I removed the
>> > check and booting works fine.
>> >
>>
>> If you use the ibft net info for the nic, what do you use for the iscsi
>> offload engine? 
>>
>>
>> I am not configuring it at boot (at least not yet). I haven't tried
>> using the boot support in the NIC firmware yet, just the uEFI iSCSI firmware
>> which will work with any NIC.
>>
>>
>>  
>>
>> Do they both have the same IP, and are you creating boot
>> iscsi sessions through the offload engine?
>>
>>
>> I am not using offload yet. But I will probably need to get this working 
>> next.
>>
>>
>>
>> cxgb*i is able to share the net info. The normal old nic engine and
>> iscsi engine are able to use the same IP. That originally was not
>> supposed to be allowed upstream, but it got in.
>>
>> bnx2* is (or at least was when we wrote that code) not able to share the
>> net info. The nic and iscsi engines need different IPs.
>>
>>
>> That makes some sense. The firmware has two different MAC addresses,
>> one for the NIC and one for iSCSI.
>>
>>
>>  
>>
>>
>> So to cover both types we just use the ibft net info for the iscsi
>> offload engines.
>>
>> In the version of the code you are using is OFFLOAD_BOOT_SUPPORTED
>> defined in open-iscsi/usr/iface.c or not?
>>
>>
>> Version 2.0.874. OFFLOAD_BOOT_SUPPORTED is in the code but not defined.
>>
>>
>>
>> If it's not defined and you modified the code like you described, then I
>> think you would use the ibft info to setup the normal old nic, and then
>> you would end up creating a boot session using software iscsi. 
>>
>>
>> Yes, I believe that is the result I am getting.
>>
>>
>>  
>>
>> I am not
>> 100% sure about this last statement. I cannot remember and just looked
>> at the code for a couple minutes.
>>
>>
>> I will try defining OFFLOAD_BOOT_SUPPORTED to see if that brings up the NIC.
>>
>>  
>>
> 
> I tried defining OFFLOAD_BOOT_SUPPORTED. The NIC is brought up but no
> IP is assigned. Is that expected? I have been using the uEFI iSCSI

It is expected for what you are doing. I misunderstood what you were
trying to do.

> driver which does not support hardware offload. I also have at least
> one bnx2x NIC that does not support iSCSI hardware offload:
> 
> 02:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5719
> Gigabit Ethernet PCIe (rev 01)
> 02:00.0 0200: 14e4:1657 (rev 01)
> 
> Do we need some sort of whitelist or a command-line flag to support these sort
> of configurations?
> 

I thought you wanted to use a iscsi offload engine in the broadcom card.
If you wanted to use a card that is in those offload lists for normal
old networking, have iscsistart bring it up and do iscsi root using
software iscsi, then yeah, I think we need some sort of flag.

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-20 Thread Andrew Patterson
On 12/12/2016 02:38 PM, Andrew Patterson wrote:
> 
> 
> On Friday, December 9, 2016 at 3:33:57 PM UTC-7, Mike Christie wrote:
> 
> On 12/08/2016 10:55 AM, andrew.p...@hpe.com  wrote:
> > I am trying to get iSCSI boot working on a debian-based system
> > using built-in uEFI iSCSI initiator firmware and broadcom
> > NICs (bnx2x).
> >
> > The debian initramfs uses the ibft support in iscsistart to log
> > into the root volume. The initramfs script uses iscsistart -N to
> > bring up the NICs before logging in with iscsstart -b. This
> > process works fine when using non-offload NICs, but fails when
> > using NICs using the bnx2, bnx2x, cxgb3, and cxgb4 drivers due to
> > the following code in
> > utils/fwparam_ibft/fw_entry.c:fw_setup_nics():
> >
> > list_for_each_entry(context, , list) {  
> > /* if it is a offload nic ignore it */
> > if (!net_get_transport_name_from_netdev(context->iface,
> > transport))
> > continue
> >
> >
> > Which does a lookup in the table in usr/iscsi_net_util.c
> >
> > static struct iscsi_net_driver net_drivers[] = {
> > {"cxgb3", "cxgb3i" },
> > {"cxgb4", "cxgb4i" },
> > {"bnx2", "bnx2i" },
> > {"bnx2x", "bnx2i"},
> > {NULL, NULL}
> > };
> >
> >
> > to see if -N should skip this NIC.  I cannot determine the reason
> > for this check. Do iscsi offload NICs not need to be configured
> > for boot? The current code causes iscsi boots to fail. I removed the
> > check and booting works fine.
> >
> 
> If you use the ibft net info for the nic, what do you use for the iscsi
> offload engine? 
> 
> 
> I am not configuring it at boot (at least not yet). I haven't tried
> using the boot support in the NIC firmware yet, just the uEFI iSCSI firmware
> which will work with any NIC.
> 
> 
>  
> 
> Do they both have the same IP, and are you creating boot
> iscsi sessions through the offload engine?
> 
> 
> I am not using offload yet. But I will probably need to get this working next.
> 
> 
> 
> cxgb*i is able to share the net info. The normal old nic engine and
> iscsi engine are able to use the same IP. That originally was not
> supposed to be allowed upstream, but it got in.
> 
> bnx2* is (or at least was when we wrote that code) not able to share the
> net info. The nic and iscsi engines need different IPs.
> 
> 
> That makes some sense. The firmware has two different MAC addresses,
> one for the NIC and one for iSCSI.
> 
> 
>  
> 
> 
> So to cover both types we just use the ibft net info for the iscsi
> offload engines.
> 
> In the version of the code you are using is OFFLOAD_BOOT_SUPPORTED
> defined in open-iscsi/usr/iface.c or not?
> 
> 
> Version 2.0.874. OFFLOAD_BOOT_SUPPORTED is in the code but not defined.
> 
> 
> 
> If it's not defined and you modified the code like you described, then I
> think you would use the ibft info to setup the normal old nic, and then
> you would end up creating a boot session using software iscsi. 
> 
> 
> Yes, I believe that is the result I am getting.
> 
> 
>  
> 
> I am not
> 100% sure about this last statement. I cannot remember and just looked
> at the code for a couple minutes.
> 
> 
> I will try defining OFFLOAD_BOOT_SUPPORTED to see if that brings up the NIC.
> 
>  
> 

I tried defining OFFLOAD_BOOT_SUPPORTED. The NIC is brought up but no
IP is assigned. Is that expected? I have been using the uEFI iSCSI
driver which does not support hardware offload. I also have at least
one bnx2x NIC that does not support iSCSI hardware offload:

02:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5719
Gigabit Ethernet PCIe (rev 01)
02:00.0 0200: 14e4:1657 (rev 01)

Do we need some sort of whitelist or a command-line flag to support these sort
of configurations?

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-14 Thread Andrew Patterson
On 12/09/2016 03:33 PM, Mike Christie wrote:
> On 12/08/2016 10:55 AM, andrew.patter...@hpe.com wrote:
>> I am trying to get iSCSI boot working on a debian-based system
>> using built-in uEFI iSCSI initiator firmware and broadcom
>> NICs (bnx2x).
>>
>> The debian initramfs uses the ibft support in iscsistart to log
>> into the root volume. The initramfs script uses iscsistart -N to
>> bring up the NICs before logging in with iscsstart -b. This
>> process works fine when using non-offload NICs, but fails when
>> using NICs using the bnx2, bnx2x, cxgb3, and cxgb4 drivers due to
>> the following code in
>> utils/fwparam_ibft/fw_entry.c:fw_setup_nics():
>>
>> list_for_each_entry(context, , list) {   
>> /* if it is a offload nic ignore it */
>> if (!net_get_transport_name_from_netdev(context->iface,
>> transport))
>> continue
>>
>>
>> Which does a lookup in the table in usr/iscsi_net_util.c
>>
>> static struct iscsi_net_driver net_drivers[] = {
>> {"cxgb3", "cxgb3i" },
>> {"cxgb4", "cxgb4i" },
>> {"bnx2", "bnx2i" },
>> {"bnx2x", "bnx2i"},
>> {NULL, NULL}
>> };
>>
>>
>> to see if -N should skip this NIC.  I cannot determine the reason
>> for this check. Do iscsi offload NICs not need to be configured
>> for boot? The current code causes iscsi boots to fail. I removed the
>> check and booting works fine.
>>
> 
> If you use the ibft net info for the nic, what do you use for the iscsi
> offload engine?

I am not configuring it at boot (at least not yet). I haven't tried
using the boot support in the NIC firmware yet, just the uEFI iSCSI firmware
which will work with any NIC.

Do they both have the same IP, and are you creating boot
> iscsi sessions through the offload engine?

I am not using offload yet. But I will probably need to get this working next.


> 
> cxgb*i is able to share the net info. The normal old nic engine and
> iscsi engine are able to use the same IP. That originally was not
> supposed to be allowed upstream, but it got in.
> 
> bnx2* is (or at least was when we wrote that code) not able to share the
> net info. The nic and iscsi engines need different IPs.

That makes some sense. The firmware has two different MAC addresses,
one for the NIC and one for iSCSI.

> 
> So to cover both types we just use the ibft net info for the iscsi
> offload engines.
> 
> In the version of the code you are using is OFFLOAD_BOOT_SUPPORTED
> defined in open-iscsi/usr/iface.c or not?

Version 2.0.874. OFFLOAD_BOOT_SUPPORTED is in the code but not defined.

> 
> If it's not defined and you modified the code like you described, then I
> think you would use the ibft info to setup the normal old nic, and then
> you would end up creating a boot session using software iscsi.

Yes, I believe that is the result I am getting.

I am not
> 100% sure about this last statement. I cannot remember and just looked
> at the code for a couple minutes.
>

I will try defining OFFLOAD_BOOT_SUPPORTED to see if that brings up the NIC.

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-14 Thread andrewdanpatterson
I am trying to get iSCSI boot working on a debian-based system
using built-in uEFI iSCSI initiator firmware and broadcom
NICs (bnx2x).

The debian initramfs uses the ibft support in iscsistart to log
into the root volume. The initramfs script uses iscsistart -N to
bring up the NICs before logging in with iscsstart -b. This
process works fine when using non-offload NICs, but fails when
using NICs using the bnx2, bnx2x, cxgb3, and cxgb4 drivers due to
the following code in
utils/fwparam_ibft/fw_entry.c:fw_setup_nics():

list_for_each_entry(context, , list) {
> /* if it is a offload nic ignore it */
> if (!net_get_transport_name_from_netdev(context->iface,
> transport))
> continue
>

Which does a lookup in the table in usr/iscsi_net_util.c

static struct iscsi_net_driver net_drivers[] = {
> {"cxgb3", "cxgb3i" },
> {"cxgb4", "cxgb4i" },
> {"bnx2", "bnx2i" },
> {"bnx2x", "bnx2i"},
> {NULL, NULL}
> };
>

to see if -N should skip this NIC.  I cannot determine the reason
for this check. Do iscsi offload NICs not need to be configured
for boot? The current code causes iscsi boots to fail. I removed the
check and booting works fine.

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-12 Thread Andrew Patterson


On Friday, December 9, 2016 at 3:33:57 PM UTC-7, Mike Christie wrote:
>
> On 12/08/2016 10:55 AM, andrew.p...@hpe.com  wrote: 
> > I am trying to get iSCSI boot working on a debian-based system 
> > using built-in uEFI iSCSI initiator firmware and broadcom 
> > NICs (bnx2x). 
> > 
> > The debian initramfs uses the ibft support in iscsistart to log 
> > into the root volume. The initramfs script uses iscsistart -N to 
> > bring up the NICs before logging in with iscsstart -b. This 
> > process works fine when using non-offload NICs, but fails when 
> > using NICs using the bnx2, bnx2x, cxgb3, and cxgb4 drivers due to 
> > the following code in 
> > utils/fwparam_ibft/fw_entry.c:fw_setup_nics(): 
> > 
> > list_for_each_entry(context, , list) {   
> > /* if it is a offload nic ignore it */ 
> > if (!net_get_transport_name_from_netdev(context->iface, 
> > transport)) 
> > continue 
> > 
> > 
> > Which does a lookup in the table in usr/iscsi_net_util.c 
> > 
> > static struct iscsi_net_driver net_drivers[] = { 
> > {"cxgb3", "cxgb3i" }, 
> > {"cxgb4", "cxgb4i" }, 
> > {"bnx2", "bnx2i" }, 
> > {"bnx2x", "bnx2i"}, 
> > {NULL, NULL} 
> > }; 
> > 
> > 
> > to see if -N should skip this NIC.  I cannot determine the reason 
> > for this check. Do iscsi offload NICs not need to be configured 
> > for boot? The current code causes iscsi boots to fail. I removed the 
> > check and booting works fine. 
> > 
>
> If you use the ibft net info for the nic, what do you use for the iscsi 
> offload engine? 


I am not configuring it at boot (at least not yet). I haven't tried
using the boot support in the NIC firmware yet, just the uEFI iSCSI firmware
which will work with any NIC.


 

> Do they both have the same IP, and are you creating boot 
> iscsi sessions through the offload engine? 
>

I am not using offload yet. But I will probably need to get this working next.



> cxgb*i is able to share the net info. The normal old nic engine and 
> iscsi engine are able to use the same IP. That originally was not 
> supposed to be allowed upstream, but it got in. 
>
> bnx2* is (or at least was when we wrote that code) not able to share the 
> net info. The nic and iscsi engines need different IPs. 
>

That makes some sense. The firmware has two different MAC addresses,
one for the NIC and one for iSCSI.


 

>
> So to cover both types we just use the ibft net info for the iscsi 
> offload engines. 
>
> In the version of the code you are using is OFFLOAD_BOOT_SUPPORTED 
> defined in open-iscsi/usr/iface.c or not? 
>

Version 2.0.874. OFFLOAD_BOOT_SUPPORTED is in the code but not defined.



> If it's not defined and you modified the code like you described, then I 
> think you would use the ibft info to setup the normal old nic, and then 
> you would end up creating a boot session using software iscsi. 


Yes, I believe that is the result I am getting.


 

> I am not 
> 100% sure about this last statement. I cannot remember and just looked 
> at the code for a couple minutes. 
>

I will try defining OFFLOAD_BOOT_SUPPORTED to see if that brings up the NIC.

 

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Re: iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-09 Thread Mike Christie
On 12/08/2016 10:55 AM, andrew.patter...@hpe.com wrote:
> I am trying to get iSCSI boot working on a debian-based system
> using built-in uEFI iSCSI initiator firmware and broadcom
> NICs (bnx2x).
> 
> The debian initramfs uses the ibft support in iscsistart to log
> into the root volume. The initramfs script uses iscsistart -N to
> bring up the NICs before logging in with iscsstart -b. This
> process works fine when using non-offload NICs, but fails when
> using NICs using the bnx2, bnx2x, cxgb3, and cxgb4 drivers due to
> the following code in
> utils/fwparam_ibft/fw_entry.c:fw_setup_nics():
> 
> list_for_each_entry(context, , list) {   
> /* if it is a offload nic ignore it */
> if (!net_get_transport_name_from_netdev(context->iface,
> transport))
> continue
> 
> 
> Which does a lookup in the table in usr/iscsi_net_util.c
> 
> static struct iscsi_net_driver net_drivers[] = {
> {"cxgb3", "cxgb3i" },
> {"cxgb4", "cxgb4i" },
> {"bnx2", "bnx2i" },
> {"bnx2x", "bnx2i"},
> {NULL, NULL}
> };
> 
> 
> to see if -N should skip this NIC.  I cannot determine the reason
> for this check. Do iscsi offload NICs not need to be configured
> for boot? The current code causes iscsi boots to fail. I removed the
> check and booting works fine.
> 

If you use the ibft net info for the nic, what do you use for the iscsi
offload engine? Do they both have the same IP, and are you creating boot
iscsi sessions through the offload engine?

cxgb*i is able to share the net info. The normal old nic engine and
iscsi engine are able to use the same IP. That originally was not
supposed to be allowed upstream, but it got in.

bnx2* is (or at least was when we wrote that code) not able to share the
net info. The nic and iscsi engines need different IPs.

So to cover both types we just use the ibft net info for the iscsi
offload engines.

In the version of the code you are using is OFFLOAD_BOOT_SUPPORTED
defined in open-iscsi/usr/iface.c or not?

If it's not defined and you modified the code like you described, then I
think you would use the ibft info to setup the normal old nic, and then
you would end up creating a boot session using software iscsi. I am not
100% sure about this last statement. I cannot remember and just looked
at the code for a couple minutes.

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


iscsistart -N skips offload NICs causing boot to fail on debian

2016-12-08 Thread andrew . patterson
I am trying to get iSCSI boot working on a debian-based system
using built-in uEFI iSCSI initiator firmware and broadcom
NICs (bnx2x).

The debian initramfs uses the ibft support in iscsistart to log
into the root volume. The initramfs script uses iscsistart -N to
bring up the NICs before logging in with iscsstart -b. This
process works fine when using non-offload NICs, but fails when
using NICs using the bnx2, bnx2x, cxgb3, and cxgb4 drivers due to
the following code in
utils/fwparam_ibft/fw_entry.c:fw_setup_nics():

list_for_each_entry(context, , list) {
> /* if it is a offload nic ignore it */
> if (!net_get_transport_name_from_netdev(context->iface,
> transport))
> continue
>

Which does a lookup in the table in usr/iscsi_net_util.c

static struct iscsi_net_driver net_drivers[] = {
> {"cxgb3", "cxgb3i" },
> {"cxgb4", "cxgb4i" },
> {"bnx2", "bnx2i" },
> {"bnx2x", "bnx2i"},
> {NULL, NULL}
> };
>

to see if -N should skip this NIC.  I cannot determine the reason
for this check. Do iscsi offload NICs not need to be configured
for boot? The current code causes iscsi boots to fail. I removed the
check and booting works fine.

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.