[OpenbravoERP-commits] devel/pi: Related with issue 33799: The preferenceValue variable...
details: https://code.openbravo.com/erp/devel/pi/rev/9bc7137ec26a
changeset: 30069:9bc7137ec26a
user: Naroa Iriarte openbravo.com>
date: Wed Sep 14 17:03:14 2016 +0200
summary: Related with issue 33799: The preferenceValue variable set correctly
The preferenceValue variable was being set outside the for loop and this had no
sense. Now it is correctly placed.
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
| 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diffs (13 lines):
diff -r 11ee89985b04 -r 9bc7137ec26a
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Wed Sep 14 16:23:43 2016 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Wed Sep 14 17:03:14 2016 +0200
@@ -230,8 +230,8 @@
// to the form, so they will be retrieved when getContextInfo() is called
for the form
if (this.sessionAttributesNames) {
this.preferenceValues = {};
- preferenceValue = OB.PropertyStore.get(this.sessionAttributesNames[i],
this.standardWindow.windowId);
for (i = 0; i < this.sessionAttributesNames.length; i++) {
+preferenceValue = OB.PropertyStore.get(this.sessionAttributesNames[i],
this.standardWindow.windowId);
if (preferenceValue !== null) {
this.preferenceValues[this.sessionAttributesNames[i]] =
preferenceValue;
}
--
___
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
[OpenbravoERP-commits] devel/pi: Related with issue 33799: The OB.PropertyStore.get met...
details: https://code.openbravo.com/erp/devel/pi/rev/11ee89985b04
changeset: 30068:11ee89985b04
user: Naroa Iriarte openbravo.com>
date: Wed Sep 14 16:23:43 2016 +0200
summary: Related with issue 33799: The OB.PropertyStore.get method is now
invoked once
Before, there were two invocations to the OB.PropertyStore.get method, now, a
new variable has been created which contains the value obtained from the
OB.PropertyStore.get method and now that variable is used instead of invoking
twice the method.
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
| 7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diffs (25 lines):
diff -r 2baddd2da048 -r 11ee89985b04
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Wed Sep 14 12:39:16 2016 +
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Wed Sep 14 16:23:43 2016 +0200
@@ -197,7 +197,7 @@
initWidget: function (properties) {
var length, rightMemberButtons = [],
leftMemberButtons = [],
-i, actionButton;
+i, actionButton, preferenceValue;
if (this.isRootView) {
this.buildStructure();
@@ -230,9 +230,10 @@
// to the form, so they will be retrieved when getContextInfo() is called
for the form
if (this.sessionAttributesNames) {
this.preferenceValues = {};
+ preferenceValue = OB.PropertyStore.get(this.sessionAttributesNames[i],
this.standardWindow.windowId);
for (i = 0; i < this.sessionAttributesNames.length; i++) {
-if (OB.PropertyStore.get(this.sessionAttributesNames[i],
this.standardWindow.windowId) !== null) {
- this.preferenceValues[this.sessionAttributesNames[i]] =
OB.PropertyStore.get(this.sessionAttributesNames[i],
this.standardWindow.windowId);
+if (preferenceValue !== null) {
+ this.preferenceValues[this.sessionAttributesNames[i]] =
preferenceValue;
}
}
}
--
___
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
[OpenbravoERP-commits] devel/pi: 2 new changesets
details: https://code.openbravo.com/erp/devel/pi/rev/4bab0d04f3bd changeset: 30066:4bab0d04f3bd user: RM packaging bot openbravo.com> date: Wed Sep 14 12:25:34 2016 + summary: CI: update AD_MODULE to version 30065 details: https://code.openbravo.com/erp/devel/pi/rev/2baddd2da048 changeset: 30067:2baddd2da048 user: RM packaging bot openbravo.com> date: Wed Sep 14 12:39:16 2016 + summary: CI: merge back from main diffstat: modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 4 +- modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 8 +- modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 6 +- modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 4 +- modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 10 ++-- modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 4 +- modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 12 ++-- modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 6 +- modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.v3.datasets/src-db/database/
[OpenbravoERP-commits] devel/main: 3 new changesets
details: https://code.openbravo.com/erp/devel/main/rev/f4782910908c changeset: 30064:f4782910908c user: RM packaging bot openbravo.com> date: Tue Sep 13 21:47:09 2016 + summary: CI: merge back from main details: https://code.openbravo.com/erp/devel/main/rev/6413719aeee5 changeset: 30065:6413719aeee5 user: Naroa Iriarte openbravo.com> date: Mon Sep 12 12:15:22 2016 +0200 summary: Fixed issue 33799: AD_ROLE_ID was not working fine in the tabs display logic The display logics using the AD_ROLE_ID session variable were not working fine. The problem was in the ob-standard-view.js class. The session attributes were overwritten with the values saved in the OB.Properties. And in this case it was null. To fix this, a condition has been added, now if the OB.Properties(propertyName) is null, the value of the session attribute is not overwritten. details: https://code.openbravo.com/erp/devel/main/rev/4bab0d04f3bd changeset: 30066:4bab0d04f3bd user: RM packaging bot openbravo.com> date: Wed Sep 14 12:25:34 2016 + summary: CI: update AD_MODULE to version 30065 diffstat: modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 4 +- modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 8 +- modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js | 4 +- modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 6 +- modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 4 +- modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 10 ++-- modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 4 +- modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml | 2 +- modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml | 2 +- modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDE
[OpenbravoERP-commits] devel/pi: Fixed issue 33799: AD_ROLE_ID was not working fine in ...
details: https://code.openbravo.com/erp/devel/pi/rev/6413719aeee5
changeset: 30065:6413719aeee5
user: Naroa Iriarte openbravo.com>
date: Mon Sep 12 12:15:22 2016 +0200
summary: Fixed issue 33799: AD_ROLE_ID was not working fine in the tabs
display logic
The display logics using the AD_ROLE_ID session variable were not working fine.
The problem was in the ob-standard-view.js class. The session attributes were
overwritten with the values saved in the OB.Properties. And in this case it was
null.
To fix this, a condition has been added, now if the OB.Properties(propertyName)
is null, the value of the session attribute is not overwritten.
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
| 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diffs (14 lines):
diff -r f4782910908c -r 6413719aeee5
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Tue Sep 13 21:47:09 2016 +
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Mon Sep 12 12:15:22 2016 +0200
@@ -231,7 +231,9 @@
if (this.sessionAttributesNames) {
this.preferenceValues = {};
for (i = 0; i < this.sessionAttributesNames.length; i++) {
-this.preferenceValues[this.sessionAttributesNames[i]] =
OB.PropertyStore.get(this.sessionAttributesNames[i],
this.standardWindow.windowId);
+if (OB.PropertyStore.get(this.sessionAttributesNames[i],
this.standardWindow.windowId) !== null) {
+ this.preferenceValues[this.sessionAttributesNames[i]] =
OB.PropertyStore.get(this.sessionAttributesNames[i],
this.standardWindow.windowId);
+}
}
}
--
___
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
