Re: [OE-core] [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug
Op 28 mei 2011, om 00:13 heeft Elizabeth Flanagan het volgende geschreven: Using python abstract syntax trees as a parser and an ast visitor class, I've begun the first steps to being able to put some sanity to license selection. One note. License modifiers have traditionally been limited to the or greater modifier +. I've added another modifier with exceptions for licenses that have no generic ie common-licenses/GPL-2,0-with-GCC-exception I get this now: WARNING: /OE/tentacle/sources/openembedded-core/meta/files/common-licenses WARNING: We need to use a SPDXLICENSEMAP for GPLv2 Is that really a warning, should that be a note or even complete hidden from the console? regards, Koen ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with 1 or 0
Op 28 mei 2011, om 04:44 heeft Khem Raj het volgende geschreven: Value of USE_PR_SERV is either 1 or 0 looking at settings in bitbake.conf USE_PR_SERV = ${@[1,0][(bb.data.getVar('PRSERV_HOST',d,1) is None) or (bb.data.getVar('PRSERV_PORT',d,1) is None)]} So we compare the strings Signed-off-by: Khem Raj raj.k...@gmail.com Fixes the problem for me: Tested-by: Koen Kooi k...@dominion.thruhere.net --- meta/classes/package.bbclass |2 +- meta/classes/prserv.bbclass |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index a1b9482..1e6a872 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -330,7 +330,7 @@ def runtime_mapping_rename (varname, d): # python package_get_auto_pr() { - if d.getVar('USE_PR_SERV', True): + if d.getVar('USE_PR_SERV', True) != 0: auto_pr=prserv_get_pr_auto(d) if auto_pr is None: bb.fatal(Can NOT get auto PR revision from remote PR service) diff --git a/meta/classes/prserv.bbclass b/meta/classes/prserv.bbclass index de46ff6..18b8589 100644 --- a/meta/classes/prserv.bbclass +++ b/meta/classes/prserv.bbclass @@ -12,7 +12,7 @@ def prserv_make_conn(d): return conn def prserv_get_pr_auto(d): -if not d.getVar('USE_PR_SERV', True): +if d.getVar('USE_PR_SERV', True) != 0: bb.warn(Not using network based PR service) return None -- 1.7.4.1 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with 1 or 0
On Sat, May 28, 2011 at 09:50:09AM +0200, Koen Kooi wrote: Op 28 mei 2011, om 04:44 heeft Khem Raj het volgende geschreven: Value of USE_PR_SERV is either 1 or 0 looking at settings in bitbake.conf USE_PR_SERV = ${@[1,0][(bb.data.getVar('PRSERV_HOST',d,1) is None) or (bb.data.getVar('PRSERV_PORT',d,1) is None)]} So we compare the strings Signed-off-by: Khem Raj raj.k...@gmail.com Fixes the problem for me: Tested-by: Koen Kooi k...@dominion.thruhere.net For me too: Tested-by: Martin Jansa martin.ja...@gmail.com --- meta/classes/package.bbclass |2 +- meta/classes/prserv.bbclass |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index a1b9482..1e6a872 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -330,7 +330,7 @@ def runtime_mapping_rename (varname, d): # python package_get_auto_pr() { - if d.getVar('USE_PR_SERV', True): + if d.getVar('USE_PR_SERV', True) != 0: auto_pr=prserv_get_pr_auto(d) if auto_pr is None: bb.fatal(Can NOT get auto PR revision from remote PR service) diff --git a/meta/classes/prserv.bbclass b/meta/classes/prserv.bbclass index de46ff6..18b8589 100644 --- a/meta/classes/prserv.bbclass +++ b/meta/classes/prserv.bbclass @@ -12,7 +12,7 @@ def prserv_make_conn(d): return conn def prserv_get_pr_auto(d): -if not d.getVar('USE_PR_SERV', True): +if d.getVar('USE_PR_SERV', True) != 0: bb.warn(Not using network based PR service) return None -- 1.7.4.1 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug
Op 28 mei 2011, om 00:13 heeft Elizabeth Flanagan het volgende geschreven: Using python abstract syntax trees as a parser and an ast visitor class, I've begun the first steps to being able to put some sanity to license selection. One note. License modifiers have traditionally been limited to the or greater modifier +. I've added another modifier with exceptions for licenses that have no generic ie common-licenses/GPL-2,0-with-GCC-exception When building shadow I get: | WARNING: /home/koen/angstrom-core/sources/openembedded-core/meta/files/common-licenses | ERROR: Error executing a python function in /home/koen/angstrom-core/sources/openembedded-core/meta/recipes-extended/shadow/shadow_4.1.4.3.bb: | RuntimeError: maximum recursion depth exceeded while calling a Python object | | ERROR: The stack trace of python calls that resulted in this exception/failure was: | ERROR: File do_populate_lic, line 121, in module | ERROR: | ERROR: File do_populate_lic, line 118, in do_populate_lic | ERROR: | ERROR: File /usr/lib64/python2.7/ast.py, line 243, in visit | ERROR: return visitor(node) | ERROR: | ERROR: File do_populate_lic, line 13, in generic_visit and a few hundred more lines, I had to change the scrollback buffer from 512 lines to unlimited to catch this :) I can send the full log on request. ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [RFC][PATCH] sysvinit: make pidof usuable in a standalone setting
Currently it's a symlink to killall5: $ dpkg-deb -c sysvinit-pidof_2.88dsf-r1_armv7a.ipk | grep pidof lrwxrwxrwx root/root 0 2011-05-27 11:05 ./bin/pidof.sysvinit - /sbin/killall5 The point of the pidof subpackage was to have a pidof without needing sysvinit, this restores that behaviour. The trade-off is a 14KiB (armv7a, uncompressed) increase in size. Signed-off-by: Koen Kooi k...@dominion.thruhere.net --- The alternative is to just move 'killall5' into the pidof subpackage and to RDPEPENDS_${PN} += ${PN}-pidof The change in this patch was the least amounts of edits to the recipe, let me know which way you prefer. meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb b/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb index 7d5e936..f0e73bb 100644 --- a/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb +++ b/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb @@ -5,7 +5,7 @@ SECTION = base LICENSE = GPLv2+ LIC_FILES_CHKSUM = file://COPYING;md5=751419260aa954499f7abaabaa882bbe \ file://COPYRIGHT;endline=15;md5=349c872e0066155e1818b786938876a4 -PR = r1 +PR = r2 # USE_VT and SERIAL_CONSOLE are generally defined by the MACHINE .conf. # Set PACKAGE_ARCH appropriately. @@ -100,7 +100,7 @@ EOF ln -s ../init.d/stop-bootlogd ${D}${sysconfdir}/rc$level.d/S99stop-bootlogd done mv ${D}${base_sbindir}/init ${D}${base_sbindir}/init.${PN} - mv ${D}${base_bindir}/pidof ${D}${base_bindir}/pidof.${PN} + cp ${D}${base_sbindir}/killall5 ${D}${base_bindir}/pidof.${PN} mv ${D}${base_sbindir}/halt ${D}${base_sbindir}/halt.${PN} mv ${D}${base_sbindir}/reboot ${D}${base_sbindir}/reboot.${PN} mv ${D}${base_sbindir}/shutdown ${D}${base_sbindir}/shutdown.${PN} -- 1.6.6.1 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug
Here you go :) Op 28 mei 2011, om 15:21 heeft Elizabeth Flanagan het volgende geschreven: Could you send me the log. That's odd and shouldn't have happened (the license is only two licenses...) -b On 05/28/2011 02:16 AM, Koen Kooi wrote: Op 28 mei 2011, om 00:13 heeft Elizabeth Flanagan het volgende geschreven: Using python abstract syntax trees as a parser and an ast visitor class, I've begun the first steps to being able to put some sanity to license selection. One note. License modifiers have traditionally been limited to the or greater modifier +. I've added another modifier with exceptions for licenses that have no generic ie common-licenses/GPL-2,0-with-GCC-exception When building shadow I get: | WARNING: /home/koen/angstrom-core/sources/openembedded-core/meta/files/common-licenses | ERROR: Error executing a python function in /home/koen/angstrom-core/sources/openembedded-core/meta/recipes-extended/shadow/shadow_4.1.4.3.bb: | RuntimeError: maximum recursion depth exceeded while calling a Python object | | ERROR: The stack trace of python calls that resulted in this exception/failure was: | ERROR: File do_populate_lic, line 121, inmodule | ERROR: | ERROR: File do_populate_lic, line 118, in do_populate_lic | ERROR: | ERROR: File /usr/lib64/python2.7/ast.py, line 243, in visit | ERROR: return visitor(node) | ERROR: | ERROR: File do_populate_lic, line 13, in generic_visit and a few hundred more lines, I had to change the scrollback buffer from 512 lines to unlimited to catch this :) I can send the full log on request. ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- --- Elizabeth Flanagan Yocto Project Release Engineer ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/1][v3] license.bbclass: Sane Parsing of licenses
On 5/27/2011 3:13 PM, Elizabeth Flanagan wrote: This is a first pass at sane license parsing, using python abstract syntax trees. A few notes on this since ast is not generally used. I massage the LICENSE field to be more pythonesque and then create an ast. I then dump the ast and using a LicenseVisitor class, recurse through the tree, looking for licenses. I then copy and link. It's cleaner, allows for easier addition of logic and while it takes slightly more CPU, it's also slightly faster in initial small scale tests. It doesn't recognize the '+' or '*' modifiers to the licenses yet nor does it know what to do with bitors (|), since I'm not even sure what to do with them. Signed-off-by: Beth Flanagan elizabeth.flana...@intel.com elfutils uses () around license which is not parsable now after this commit. --- meta/classes/license.bbclass | 152 +++--- 1 files changed, 114 insertions(+), 38 deletions(-) diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass index 4fd1f85..a4d34e7 100644 --- a/meta/classes/license.bbclass +++ b/meta/classes/license.bbclass @@ -14,6 +14,42 @@ LICSSTATEDIR = ${WORKDIR}/license-destdir/ addtask populate_lic after do_patch before do_package do_populate_lic[dirs] = ${LICSSTATEDIR}/${PN} do_populate_lic[cleandirs] = ${LICSSTATEDIR} + +# Standards are great! Everyone has their own. In an effort to standardize licensing +# names, common-licenses will use the SPDX standard license names. In order to not +# break the non-standardized license names that we find in LICENSE, we'll set +# up a bunch of VarFlags to accomodate non-SPDX license names. +# +# We should really discuss standardizing this field, but that's a longer term goal. +# For now, we can do this and it should grab the most common LICENSE naming variations. +# +#GPL variations +SPDXLICENSEMAP[GPL] = GPL-1 +SPDXLICENSEMAP[GPLv2] = GPL-2 +SPDXLICENSEMAP[GPLv3] = GPL-3 + +#LGPL variations +SPDXLICENSEMAP[LGPL] = LGPL-2 +SPDXLICENSEMAP[LGPLv2] = LGPL-2 +SPDXLICENSEMAP[LGPL2.1] = LGPL-2.1 +SPDXLICENSEMAP[LGPLv2.1] = LGPL-2.1 +SPDXLICENSEMAP[LGPLv3] = LGPL-3 + +#MPL variations +SPDXLICENSEMAP[MPL] = MPL-1 +SPDXLICENSEMAP[MPLv1] = MPL-1 +SPDXLICENSEMAP[MPLv1.1] = MPL-1 + +#MIT variations +SPDXLICENSEMAP[MIT-X] = MIT + +#Openssl variations +SPDXLICENSEMAP[openssl] = Openssl + +#Other variations +SPDXLICENSEMAP[AFL2.1] = AFL-2 +SPDXLICENSEMAP[EPLv1.0] = EPL-1 + python do_populate_lic() { Populate LICENSE_DIRECTORY with licenses. @@ -21,6 +57,68 @@ python do_populate_lic() { import os import bb import shutil + import ast + + class LicenseVisitor(ast.NodeVisitor): + def generic_visit(self, node): + ast.NodeVisitor.generic_visit(self, node) + + def visit_Str(self, node): + # + # Until I figure out what to do with + # the two modifiers I support (or greater = + + # and with exceptions being * + # we'll just strip out the modifier and put + # the base license. + find_license(node.s.replace(+, ).replace(*, )) + ast.NodeVisitor.generic_visit(self, node) + + def visit_BinOp(self, node): + op = node.op + if isinstance(op, ast.BitOr): + x = LicenseVisitor() + x.visit(node) + else: + ast.NodeVisitor.generic_visit(self, node) + + def copy_license(source, destination, file_name): + try: + bb.copyfile(os.path.join(source, file_name), os.path.join(destination, file_name)) + except: + bb.warn(%s: No generic license file exists for: %s at %s % (pn, file_name, source)) + pass + + def link_license(source, destination, file_name): + try: + os.symlink(os.path.join(source, file_name), os.path.join(destination, generic_ + file_name)) + except: + bb.warn(%s: Could not symlink: %s at %s to %s at %s % (pn, file_name, source, file_name, destination)) + pass + + def find_license(license_type): + + try: + bb.mkdirhier(gen_lic_dest) + except: + pass + + # If the generic does not exist we need to check to see if there is an SPDX mapping to it + if not os.path.isfile(os.path.join(generic_directory, license_type)): + if bb.data.getVarFlag('SPDXLICENSEMAP', license_type, d) != None: + # Great, there is an SPDXLICENSEMAP. We can copy! + bb.warn(We need to use a SPDXLICENSEMAP for %s % (license_type)) + spdx_generic = bb.data.getVarFlag('SPDXLICENSEMAP', license_type, d) + copy_license(generic_directory, gen_lic_dest, spdx_generic) + link_license(gen_lic_dest, destdir, spdx_generic) + else: + # And here is where we warn people that their licenses are lousy + bb.warn(%s: No generic license file exists for: %s at %s % (pn, license_type, generic_directory)) + bb.warn(%s: There is also no SPDXLICENSEMAP for this license type: %s at %s % (pn, license_type, generic_directory)) + pass + elif os.path.isfile(os.path.join(generic_directory, license_type)): + copy_license(generic_directory, gen_lic_dest, license_type) + link_license(gen_lic_dest, destdir, license_type) + # All the license types for the package license_types = bb.data.getVar('LICENSE', d, True) @@ -33,6 +131,12 @@ python do_populate_lic() {
Re: [OE-core] [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug
On 5/28/2011 2:16 AM, Koen Kooi wrote: Op 28 mei 2011, om 00:13 heeft Elizabeth Flanagan het volgende geschreven: Using python abstract syntax trees as a parser and an ast visitor class, I've begun the first steps to being able to put some sanity to license selection. One note. License modifiers have traditionally been limited to the or greater modifier +. I've added another modifier with exceptions for licenses that have no generic ie common-licenses/GPL-2,0-with-GCC-exception When building shadow I get: and when building elfutils I get ERROR: (file: 'do_populate_lic', lineno: 116, function: do_populate_lic) ERROR: Function 'do_populate_lic' failed ERROR: Logfile of failure stored in: /home/kraj/work/slugos/build/tmp-slugos-eglibc/work/armv5te-oe-linux-gnueabi/elfutils-0.148-r2/temp/log.do_populate_lic.31784 Log data follows: | WARNING: /home/kraj/work/slugos/openembedded-core/meta/files/common-licenses | ERROR: Error executing a python function in /home/kraj/work/slugos/openembedded-core/meta/recipes-devtools/elfutils/elfutils_0.148.bb: | File unknown, line 1 | ( 'GPLv2' 'Exception' ) |^ | IndentationError: unexpected indent | | ERROR: The stack trace of python calls that resulted in this exception/failure was: | ERROR: File do_populate_lic, line 121, in module | ERROR: | ERROR: File do_populate_lic, line 116, in do_populate_lic | ERROR: | ERROR: File /usr/lib/python2.7/ast.py, line 37, in parse | ERROR: return compile(source, filename, mode, PyCF_ONLY_AST) | ERROR: | ERROR: The code that was being executed was: | ERROR: 0117:v = LicenseVisitor() | ERROR: 0118:v.visit(node) | ERROR: 0119: | ERROR: 0120: | ERROR: *** 0121:do_populate_lic(d) | ERROR: 0122: | ERROR: (file: 'do_populate_lic', lineno: 121, function: module) | ERROR: 0112:clean_licenses += ' + x + ' | ERROR: 0113:else: | ERROR: 0114:clean_licenses += + x + | ERROR: 0115: | ERROR: *** 0116:node = ast.parse(clean_licenses) | ERROR: 0117:v = LicenseVisitor() | ERROR: 0118:v.visit(node) | ERROR: 0119: | ERROR: 0120: | ERROR: (file: 'do_populate_lic', lineno: 116, function: do_populate_lic) | ERROR: Function 'do_populate_lic' failed NOTE: package elfutils-0.148-r2: task do_populate_lic: Failed | WARNING: /home/koen/angstrom-core/sources/openembedded-core/meta/files/common-licenses | ERROR: Error executing a python function in /home/koen/angstrom-core/sources/openembedded-core/meta/recipes-extended/shadow/shadow_4.1.4.3.bb: | RuntimeError: maximum recursion depth exceeded while calling a Python object | | ERROR: The stack trace of python calls that resulted in this exception/failure was: | ERROR: File do_populate_lic, line 121, inmodule | ERROR: | ERROR: File do_populate_lic, line 118, in do_populate_lic | ERROR: | ERROR: File /usr/lib64/python2.7/ast.py, line 243, in visit | ERROR: return visitor(node) | ERROR: | ERROR: File do_populate_lic, line 13, in generic_visit and a few hundred more lines, I had to change the scrollback buffer from 512 lines to unlimited to catch this :) I can send the full log on request. ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [bugfix 1/2] gcc-4.6.0: fix ICE with armv7 target
On 5/27/2011 12:41 PM, Mark Hatle wrote: On 5/27/11 2:36 PM, Khem Raj wrote: On Fri, May 27, 2011 at 12:15 PM, Mark Hatlemark.ha...@windriver.com wrote: On 5/27/11 1:25 PM, Khem Raj wrote: On Fri, May 27, 2011 at 11:15 AM,nitin.a.kam...@intel.com wrote: From: Nitin A Kamblenitin.a.kam...@intel.com This fixes an internal compiler error for gcc 4.6.0 for armv7 Patch came from: Phil Blundellp...@pbcl.net Validated by Nitin Signed-off-by: Nitin A Kamblenitin.a.kam...@intel.com Signed-Off-by: Phil Blundellp...@pbcl.net --- meta/recipes-devtools/gcc/gcc-4.6.0.inc|3 +- .../gcc/gcc-4.6.0/ICE_fix_for_arm.patch| 44 2 files changed, 46 insertions(+), 1 deletions(-) create mode 100644 meta/recipes-devtools/gcc/gcc-4.6.0/ICE_fix_for_arm.patch diff --git a/meta/recipes-devtools/gcc/gcc-4.6.0.inc b/meta/recipes-devtools/gcc/gcc-4.6.0.inc index fb5c70d..4407eca 100644 --- a/meta/recipes-devtools/gcc/gcc-4.6.0.inc +++ b/meta/recipes-devtools/gcc/gcc-4.6.0.inc @@ -7,7 +7,7 @@ require gcc-common.inc require gcc-4_6-branch-backports.inc -PR = r2 +PR = r3 DEPENDS =+ mpfr gmp libmpc NATIVEDEPS = mpfr-native gmp-native gettext-native libmpc-native @@ -53,6 +53,7 @@ SRC_URI = ${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \ file://gcc-poison-parameters.patch \ file://GPLUSPLUS_INCLUDE_DIR_with_sysroot.patch \ file://COLLECT_GCC_OPTIONS.patch \ + file://ICE_fix_for_arm.patch \ SRC_URI_append_sh3 = file://sh3-installfix-fixheaders.patch;patch=1 diff --git a/meta/recipes-devtools/gcc/gcc-4.6.0/ICE_fix_for_arm.patch b/meta/recipes-devtools/gcc/gcc-4.6.0/ICE_fix_for_arm.patch new file mode 100644 index 000..037a180 --- /dev/null +++ b/meta/recipes-devtools/gcc/gcc-4.6.0/ICE_fix_for_arm.patch @@ -0,0 +1,44 @@ +Upstream-Status: Pending + +Patch came from: Phil Blundellp...@pbcl.net +Validated by Nitin +This fixes the following internal compiler error of gcc 4.6.0 on for armv7-a +related gcc bugzilla: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47719 + + +| arm-poky-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon +-mfloat-abi=softfp -fno-tree-vectorize +--sysroot=/srv/home/pokybuild/poky-slave/nightly-external/build/build/tmp/sysroots/beagleboard +-c -I. -I../../../../src/gallium/include -I../../../../src/gallium/auxiliary +-I../../../../src/gallium/drivers +-I../../../../src/gallium/drivers/svga/include -O2 -pipe -g +-feliminate-unused-debug-types -Wall -Wmissing-prototypes -std=c99 -ffast-math +-fvisibility=hidden -fno-strict-aliasing -fPIC -D_GNU_SOURCE -DPTHREADS +-DHAVE_POSIX_MEMALIGN -DUSE_XSHM -std=gnu99 -fvisibility=hidden -DHAVE_STDINT_H +-DHAVE_SYS_TYPES_H svga_resource_buffer_upload.c -o +svga_resource_buffer_upload.o +| svga_tgsi_insn.c: In function 'svga_shader_emit_instructions': +| svga_tgsi_insn.c:2969:1: internal compiler error: in push_minipool_fix, at +config/arm/arm.c:12084 +| Please submit a full bug report, +| with preprocessed source if appropriate. +| Seehttp://gcc.gnu.org/bugs.html for instructions. +| make[4]: *** [svga_tgsi_insn.o] Error 1 + +Nitin A Kamblenitin.a.kam...@intel.com 2011/05/27 + +Index: gcc-4.6.0/gcc/config/arm/arm.md +=== +--- gcc-4.6.0.orig/gcc/config/arm/arm.md gcc-4.6.0/gcc/config/arm/arm.md +@@ -4213,7 +4213,9 @@ +uxth%?\\t%0, %1 +ldr%(h%)\\t%0, %1 + [(set_attr type alu_shift,load_byte) +- (set_attr predicable yes)] ++ (set_attr predicable yes) ++ (set_attr pool_range *,256) ++ (set_attr neg_pool_range *,244)] + ) + FWIW a patch which is similar to this was rejected here. http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01731.html based on that link, I'd say there are two cases that are needed for a proper workaround. Then likely we wait until upstream has a fix working around package is better than working around gcc IMHO Problem is the ICE will still be there. If we put the workaround in gcc, then the package will work with different versions of gcc (without modification), and other packages will not experience this ICE. (This of course is assuming the gcc workaround is reasonable and not introducing other faults.) we should qualify and run regression tests IMO to validate it if we intend patch gcc. I think fixing the given recipe is path of least impact ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug
In this case, elfutils should probably be changes as well as license.bbclass. As do_populate_lic is looking for valid python to make a syntax tree from, this will fail. Solution: 1. Fix license.bbclass to check LICENSE and massage it a bit more. 2. Fix elfutils to be GPLv2* (unless it's the GCC exception. I haven't read the license yet). I'll poke around this today. -b On 05/28/2011 09:55 AM, Khem Raj wrote: On 5/28/2011 2:16 AM, Koen Kooi wrote: Op 28 mei 2011, om 00:13 heeft Elizabeth Flanagan het volgende geschreven: Using python abstract syntax trees as a parser and an ast visitor class, I've begun the first steps to being able to put some sanity to license selection. One note. License modifiers have traditionally been limited to the or greater modifier +. I've added another modifier with exceptions for licenses that have no generic ie common-licenses/GPL-2,0-with-GCC-exception When building shadow I get: and when building elfutils I get ERROR: (file: 'do_populate_lic', lineno: 116, function: do_populate_lic) ERROR: Function 'do_populate_lic' failed ERROR: Logfile of failure stored in: /home/kraj/work/slugos/build/tmp-slugos-eglibc/work/armv5te-oe-linux-gnueabi/elfutils-0.148-r2/temp/log.do_populate_lic.31784 Log data follows: | WARNING: /home/kraj/work/slugos/openembedded-core/meta/files/common-licenses | ERROR: Error executing a python function in /home/kraj/work/slugos/openembedded-core/meta/recipes-devtools/elfutils/elfutils_0.148.bb: | File unknown, line 1 | ( 'GPLv2' 'Exception' ) |^ | IndentationError: unexpected indent | | ERROR: The stack trace of python calls that resulted in this exception/failure was: | ERROR: File do_populate_lic, line 121, inmodule | ERROR: | ERROR: File do_populate_lic, line 116, in do_populate_lic | ERROR: | ERROR: File /usr/lib/python2.7/ast.py, line 37, in parse | ERROR: return compile(source, filename, mode, PyCF_ONLY_AST) | ERROR: | ERROR: The code that was being executed was: | ERROR: 0117:v = LicenseVisitor() | ERROR: 0118:v.visit(node) | ERROR: 0119: | ERROR: 0120: | ERROR: *** 0121:do_populate_lic(d) | ERROR: 0122: | ERROR: (file: 'do_populate_lic', lineno: 121, function:module) | ERROR: 0112:clean_licenses += ' + x + ' | ERROR: 0113:else: | ERROR: 0114:clean_licenses += + x + | ERROR: 0115: | ERROR: *** 0116:node = ast.parse(clean_licenses) | ERROR: 0117:v = LicenseVisitor() | ERROR: 0118:v.visit(node) | ERROR: 0119: | ERROR: 0120: | ERROR: (file: 'do_populate_lic', lineno: 116, function: do_populate_lic) | ERROR: Function 'do_populate_lic' failed NOTE: package elfutils-0.148-r2: task do_populate_lic: Failed | WARNING: /home/koen/angstrom-core/sources/openembedded-core/meta/files/common-licenses | ERROR: Error executing a python function in /home/koen/angstrom-core/sources/openembedded-core/meta/recipes-extended/shadow/shadow_4.1.4.3.bb: | RuntimeError: maximum recursion depth exceeded while calling a Python object | | ERROR: The stack trace of python calls that resulted in this exception/failure was: | ERROR: File do_populate_lic, line 121, inmodule | ERROR: | ERROR: File do_populate_lic, line 118, in do_populate_lic | ERROR: | ERROR: File /usr/lib64/python2.7/ast.py, line 243, in visit | ERROR: return visitor(node) | ERROR: | ERROR: File do_populate_lic, line 13, in generic_visit and a few hundred more lines, I had to change the scrollback buffer from 512 lines to unlimited to catch this :) I can send the full log on request. ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- --- Elizabeth Flanagan Yocto Project Release Engineer ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug
On Fri, May 27, 2011 at 22:13, Elizabeth Flanagan elizabeth.flana...@intel.com wrote: ... Beth Flanagan (1): license.bbclass: Sane Parsing of licenses ... The change itself was OK and really an improvement but please pay some attention to whitespaces. It is nice to avoid useless whitespaces into new code. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug
On 5/28/2011 10:54 AM, Elizabeth Flanagan wrote: In this case, elfutils should probably be changes as well as license.bbclass. As do_populate_lic is looking for valid python to make a syntax tree from, this will fail. Solution: 1. Fix license.bbclass to check LICENSE and massage it a bit more. 2. Fix elfutils to be GPLv2* (unless it's the GCC exception. I haven't read the license yet). It does not like () around license values so simple solution is to replace -LICENSE = (GPLv2 Exception) +LICENSE = GPLv2 Exception Generally its preferable to fix eflutils first before license class in this case to keep the tree bisect'able. I'll poke around this today. -b On 05/28/2011 09:55 AM, Khem Raj wrote: On 5/28/2011 2:16 AM, Koen Kooi wrote: Op 28 mei 2011, om 00:13 heeft Elizabeth Flanagan het volgende geschreven: Using python abstract syntax trees as a parser and an ast visitor class, I've begun the first steps to being able to put some sanity to license selection. One note. License modifiers have traditionally been limited to the or greater modifier +. I've added another modifier with exceptions for licenses that have no generic ie common-licenses/GPL-2,0-with-GCC-exception When building shadow I get: and when building elfutils I get ERROR: (file: 'do_populate_lic', lineno: 116, function: do_populate_lic) ERROR: Function 'do_populate_lic' failed ERROR: Logfile of failure stored in: /home/kraj/work/slugos/build/tmp-slugos-eglibc/work/armv5te-oe-linux-gnueabi/elfutils-0.148-r2/temp/log.do_populate_lic.31784 Log data follows: | WARNING: /home/kraj/work/slugos/openembedded-core/meta/files/common-licenses | ERROR: Error executing a python function in /home/kraj/work/slugos/openembedded-core/meta/recipes-devtools/elfutils/elfutils_0.148.bb: | File unknown, line 1 | ( 'GPLv2' 'Exception' ) | ^ | IndentationError: unexpected indent | | ERROR: The stack trace of python calls that resulted in this exception/failure was: | ERROR: File do_populate_lic, line 121, inmodule | ERROR: | ERROR: File do_populate_lic, line 116, in do_populate_lic | ERROR: | ERROR: File /usr/lib/python2.7/ast.py, line 37, in parse | ERROR: return compile(source, filename, mode, PyCF_ONLY_AST) | ERROR: | ERROR: The code that was being executed was: | ERROR: 0117: v = LicenseVisitor() | ERROR: 0118: v.visit(node) | ERROR: 0119: | ERROR: 0120: | ERROR: *** 0121:do_populate_lic(d) | ERROR: 0122: | ERROR: (file: 'do_populate_lic', lineno: 121, function:module) | ERROR: 0112: clean_licenses += ' + x + ' | ERROR: 0113: else: | ERROR: 0114: clean_licenses += + x + | ERROR: 0115: | ERROR: *** 0116: node = ast.parse(clean_licenses) | ERROR: 0117: v = LicenseVisitor() | ERROR: 0118: v.visit(node) | ERROR: 0119: | ERROR: 0120: | ERROR: (file: 'do_populate_lic', lineno: 116, function: do_populate_lic) | ERROR: Function 'do_populate_lic' failed NOTE: package elfutils-0.148-r2: task do_populate_lic: Failed | WARNING: /home/koen/angstrom-core/sources/openembedded-core/meta/files/common-licenses | ERROR: Error executing a python function in /home/koen/angstrom-core/sources/openembedded-core/meta/recipes-extended/shadow/shadow_4.1.4.3.bb: | RuntimeError: maximum recursion depth exceeded while calling a Python object | | ERROR: The stack trace of python calls that resulted in this exception/failure was: | ERROR: File do_populate_lic, line 121, inmodule | ERROR: | ERROR: File do_populate_lic, line 118, in do_populate_lic | ERROR: | ERROR: File /usr/lib64/python2.7/ast.py, line 243, in visit | ERROR: return visitor(node) | ERROR: | ERROR: File do_populate_lic, line 13, in generic_visit and a few hundred more lines, I had to change the scrollback buffer from 512 lines to unlimited to catch this :) I can send the full log on request. ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH 0/1] license.bbclass: Fix for infinite recursion and bad license_type
- Fixing LicenseVisitor so it forks at a BitOr instead of infinitely checking the node. - Fixing the bad license_type syntax by lstriping it so it's valid python. - Moved the bb.warn that we're using a SPDXLICENSEMAP to a note. The following changes since commit 1169f1b066d0028bd2ef7915440450bd42ef165e: license.bbclass: Sane Parsing of licenses (2011-05-27 23:36:24 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib eflanagan/common-licenses http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=eflanagan/common-licenses Beth Flanagan (1): license.bbclass: Infinite recursion of or nodes meta/classes/license.bbclass | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [upgrades 2/4] autoconf: upgrade from 2.65 to 2.68
From: Nitin A Kamble nitin.a.kam...@intel.com And rebase the patches to the newer code. Signed-off-by: Nitin A Kamble nitin.a.kam...@intel.com --- .../{autoconf-2.65 = autoconf}/autoconf-x.patch |0 .../autoheader-nonfatal-warnings.patch |0 .../autoreconf-exclude.patch |0 .../autoreconf-foreign.patch |0 .../autoreconf-gnuconfigize.patch |0 .../autoreconf-include.patch |0 .../{autoconf-2.65 = autoconf}/config_site.patch | 19 ++- .../fix_path_xtra.patch| 14 +++--- .../path_prog_fixes.patch |0 .../program_prefix.patch |0 .../{autoconf_2.65.bb = autoconf_2.68.bb} |6 +++--- 11 files changed, 24 insertions(+), 15 deletions(-) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoconf-x.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoheader-nonfatal-warnings.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoreconf-exclude.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoreconf-foreign.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoreconf-gnuconfigize.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoreconf-include.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/config_site.patch (60%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/fix_path_xtra.patch (90%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/path_prog_fixes.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/program_prefix.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf_2.65.bb = autoconf_2.68.bb} (85%) diff --git a/meta/recipes-devtools/autoconf/autoconf-2.65/autoconf-x.patch b/meta/recipes-devtools/autoconf/autoconf/autoconf-x.patch similarity index 100% rename from meta/recipes-devtools/autoconf/autoconf-2.65/autoconf-x.patch rename to meta/recipes-devtools/autoconf/autoconf/autoconf-x.patch diff --git a/meta/recipes-devtools/autoconf/autoconf-2.65/autoheader-nonfatal-warnings.patch b/meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch similarity index 100% rename from meta/recipes-devtools/autoconf/autoconf-2.65/autoheader-nonfatal-warnings.patch rename to meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch diff --git a/meta/recipes-devtools/autoconf/autoconf-2.65/autoreconf-exclude.patch b/meta/recipes-devtools/autoconf/autoconf/autoreconf-exclude.patch similarity index 100% rename from meta/recipes-devtools/autoconf/autoconf-2.65/autoreconf-exclude.patch rename to meta/recipes-devtools/autoconf/autoconf/autoreconf-exclude.patch diff --git a/meta/recipes-devtools/autoconf/autoconf-2.65/autoreconf-foreign.patch b/meta/recipes-devtools/autoconf/autoconf/autoreconf-foreign.patch similarity index 100% rename from meta/recipes-devtools/autoconf/autoconf-2.65/autoreconf-foreign.patch rename to meta/recipes-devtools/autoconf/autoconf/autoreconf-foreign.patch diff --git a/meta/recipes-devtools/autoconf/autoconf-2.65/autoreconf-gnuconfigize.patch b/meta/recipes-devtools/autoconf/autoconf/autoreconf-gnuconfigize.patch similarity index 100% rename from meta/recipes-devtools/autoconf/autoconf-2.65/autoreconf-gnuconfigize.patch rename to meta/recipes-devtools/autoconf/autoconf/autoreconf-gnuconfigize.patch diff --git a/meta/recipes-devtools/autoconf/autoconf-2.65/autoreconf-include.patch b/meta/recipes-devtools/autoconf/autoconf/autoreconf-include.patch similarity index 100% rename from meta/recipes-devtools/autoconf/autoconf-2.65/autoreconf-include.patch rename to meta/recipes-devtools/autoconf/autoconf/autoreconf-include.patch diff --git a/meta/recipes-devtools/autoconf/autoconf-2.65/config_site.patch b/meta/recipes-devtools/autoconf/autoconf/config_site.patch similarity index 60% rename from meta/recipes-devtools/autoconf/autoconf-2.65/config_site.patch rename to meta/recipes-devtools/autoconf/autoconf/config_site.patch index e3ff318..9f04440 100644 --- a/meta/recipes-devtools/autoconf/autoconf-2.65/config_site.patch +++ b/meta/recipes-devtools/autoconf/autoconf/config_site.patch @@ -6,17 +6,26 @@ them. RP 1/2/10 -Index: autoconf-2.65/lib/autoconf/general.m4 +Updated for 2.68 version: the CONFIG_SITE var was not getting used at all +fixed the 2.68 code +Nitin A Kamble nitin.a.kam...@intel.com 2011/05/27 + +Index: autoconf-2.68/lib/autoconf/general.m4 === autoconf-2.65.orig/lib/autoconf/general.m4 2010-02-01 12:41:32.329073138 + -+++ autoconf-2.65/lib/autoconf/general.m4 2010-02-01 12:41:56.769040799 + -@@ -1863,17 +1863,10 @@ +---
[OE-core] [upgrades 0/4] devel/toolchain recipe upgrades
From: Nitin A Kamble nitin.a.kam...@intel.com I could build meta-toolchain sato-sdk image for qemuppc with these commits. I had to fix the autoconf's config-site patch to avoid lots of errors as site files were not getting parsed earlier. The following changes since commit 1169f1b066d0028bd2ef7915440450bd42ef165e: license.bbclass: Sane Parsing of licenses (2011-05-27 23:36:24 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib nitin/upgrades http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/upgrades Nitin A Kamble (4): m4: upgrade from 1.4.15 to 1.4.16 autoconf: upgrade from 2.65 to 2.68 bison: upgrade from 2.4.3 to 2.5 genttext-0.16.1: mark upstream status for gplv2 recipe's patches .../gettext/gettext-0.16.1/disable_java.patch |2 + .../gettext-0.16.1/fix_aclocal_version.patch |2 + .../gettext-0.16.1/fix_gnu_source_circular.patch |2 + .../gettext/gettext-0.16.1/fixchicken.patch|2 + .../gettext/gettext-0.16.1/getline.m4.patch|2 + .../gettext-autoconf-lib-link-no-L.patch |2 + .../gettext-error_print_progname.patch |2 + .../gettext/gettext-0.16.1/gettext-vpath.patch |2 + .../gettext-0.16.1/hardcode_macro_version.patch|2 + .../gettext/gettext-0.16.1/linklib_from_0.17.patch |2 + .../{autoconf-2.65 = autoconf}/autoconf-x.patch |0 .../autoheader-nonfatal-warnings.patch |0 .../autoreconf-exclude.patch |0 .../autoreconf-foreign.patch |0 .../autoreconf-gnuconfigize.patch |0 .../autoreconf-include.patch |0 .../{autoconf-2.65 = autoconf}/config_site.patch | 19 ++- .../fix_path_xtra.patch| 14 +- .../path_prog_fixes.patch |0 .../program_prefix.patch |0 .../{autoconf_2.65.bb = autoconf_2.68.bb} |6 +- meta/recipes-devtools/bison/bison/m4.patch | 131 .../bison/bison/uclibc-sched_param-def.patch | 21 --- .../bison/{bison_2.4.3.bb = bison_2.5.bb} |7 +- .../{m4-native_1.4.15.bb = m4-native_1.4.16.bb} |0 .../m4/{m4_1.4.15.bb = m4_1.4.16.bb} |6 +- 26 files changed, 50 insertions(+), 174 deletions(-) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoconf-x.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoheader-nonfatal-warnings.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoreconf-exclude.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoreconf-foreign.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoreconf-gnuconfigize.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/autoreconf-include.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/config_site.patch (60%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/fix_path_xtra.patch (90%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/path_prog_fixes.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf-2.65 = autoconf}/program_prefix.patch (100%) rename meta/recipes-devtools/autoconf/{autoconf_2.65.bb = autoconf_2.68.bb} (85%) delete mode 100644 meta/recipes-devtools/bison/bison/uclibc-sched_param-def.patch rename meta/recipes-devtools/bison/{bison_2.4.3.bb = bison_2.5.bb} (85%) rename meta/recipes-devtools/m4/{m4-native_1.4.15.bb = m4-native_1.4.16.bb} (100%) rename meta/recipes-devtools/m4/{m4_1.4.15.bb = m4_1.4.16.bb} (75%) -- 1.7.2.2 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core