[OE-core] [PATCH] elfutils: Fix build with gcc trunk

2024-01-25 Thread Khem Raj
Fixes a build issue seen with latest gcc trunk.

Fixes
| ../../elfutils-0.189/tests/elfstrmerge.c: In function 'main':
| ../../elfutils-0.189/tests/elfstrmerge.c:450:32: error: 'calloc' sizes 
specified with 'sizeof' in the earlier argument and not in the later argument 
[-Werror=calloc-transposed-args]
|   450 |   newscnbufs = calloc (sizeof (void *), newshnums);
|   |^~~~
| ../../elfutils-0.189/tests/elfstrmerge.c:450:32: note: earlier argument 
should specify number of elements, later size of each element
| cc1: all warnings being treated as errors

Signed-off-by: Khem Raj 
---
 .../elfutils/elfutils_0.189.bb|  1 +
 ...against-upcoming-gcc-14-Werror-callo.patch | 39 +++
 2 files changed, 40 insertions(+)
 create mode 100644 
meta/recipes-devtools/elfutils/files/0001-tests-fix-build-against-upcoming-gcc-14-Werror-callo.patch

diff --git a/meta/recipes-devtools/elfutils/elfutils_0.189.bb 
b/meta/recipes-devtools/elfutils/elfutils_0.189.bb
index e9b432e4e99..076ba473580 100644
--- a/meta/recipes-devtools/elfutils/elfutils_0.189.bb
+++ b/meta/recipes-devtools/elfutils/elfutils_0.189.bb
@@ -22,6 +22,7 @@ SRC_URI = 
"https://sourceware.org/elfutils/ftp/${PV}/${BP}.tar.bz2 \
file://ptest.patch \

file://0001-tests-Makefile.am-compile-test_nlist-with-standard-C.patch \
file://0001-Add-helper-function-for-basename.patch \
+   
file://0001-tests-fix-build-against-upcoming-gcc-14-Werror-callo.patch \
"
 SRC_URI:append:libc-musl = " \
file://0003-musl-utils.patch \
diff --git 
a/meta/recipes-devtools/elfutils/files/0001-tests-fix-build-against-upcoming-gcc-14-Werror-callo.patch
 
b/meta/recipes-devtools/elfutils/files/0001-tests-fix-build-against-upcoming-gcc-14-Werror-callo.patch
new file mode 100644
index 000..5e0c7e97664
--- /dev/null
+++ 
b/meta/recipes-devtools/elfutils/files/0001-tests-fix-build-against-upcoming-gcc-14-Werror-callo.patch
@@ -0,0 +1,39 @@
+From 901c6a8c78c3c4eee244b9d5298cbd7b9aa713d1 Mon Sep 17 00:00:00 2001
+From: Sergei Trofimovich 
+Date: Thu, 21 Dec 2023 09:23:30 +
+Subject: [PATCH] tests: fix build against upcoming `gcc-14`
+ (`-Werror=calloc-transposed-args`)
+
+`gcc-14` added a new `-Wcalloc-transposed-args` warning recently. It
+detected minor infelicity in `calloc()` API usage in `elfutils`:
+
+elfstrmerge.c: In function 'main':
+elfstrmerge.c:450:32: error:
+  'calloc' sizes specified with 'sizeof' in the earlier argument and not 
in the later argument [-Werror=calloc-transposed-args]
+  450 |   newscnbufs = calloc (sizeof (void *), newshnums);
+  |^~~~
+elfstrmerge.c:450:32: note: earlier argument should specify number of 
elements, later size of each element
+
+Upstream-Status: Backport 
[https://sourceware.org/git/?p=elfutils.git;a=commit;h=ae580d48278b9924da7503886b37be34378e1b04]
+Signed-off-by: Sergei Trofimovich 
+Signed-off-by: Khem Raj 
+---
+ tests/elfstrmerge.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tests/elfstrmerge.c b/tests/elfstrmerge.c
+index 56350bb..4eb58bb 100644
+--- a/tests/elfstrmerge.c
 b/tests/elfstrmerge.c
+@@ -447,7 +447,7 @@ main (int argc, char **argv)
+ }
+ 
+   newshnums = shdrnum - 1;
+-  newscnbufs = calloc (sizeof (void *), newshnums);
++  newscnbufs = calloc (newshnums, sizeof (void *));
+   if (newscnbufs == NULL)
+ fail_errno ("Couldn't allocate memory for new section buffers", NULL);
+ 
+-- 
+2.43.0
+
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194346): 
https://lists.openembedded.org/g/openembedded-core/message/194346
Mute This Topic: https://lists.openembedded.org/mt/103972028/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v3] xz: Add ptest support

2024-01-25 Thread Chi Xu
There are two types of cases: executables and POSIX shell scripts.
All test cases PASS.
Add xz-ptest to PTESTS_FAST because test duration less than 30s
on qemux86-64.

root@qemux86-64:~# ptest-runner xz
START: ptest-runner
2024-01-26T03:32
BEGIN: /usr/lib/xz/ptest
=== test_bcj_exact_size.c ===
PASS: test_exact_size
PASS: test_empty_block
---
=== END ===
...
=== test_vli.c ===
PASS: test_lzma_vli_size
PASS: test_lzma_vli_encode
PASS: test_lzma_vli_decode
---
=== END ===
PASS: test_files.sh
PASS: test_scripts.sh
PASS: test_compress.sh
DURATION: 18
END: /usr/lib/xz/ptest
2024-01-26T03:33
STOP: ptest-runner
TOTAL: 1 FAIL: 0

Signed-off-by: Xu, Chi 
---
 .../distro/include/ptest-packagelists.inc |  1 +
 meta/recipes-extended/xz/xz/run-ptest | 26 +
 meta/recipes-extended/xz/xz_5.4.5.bb  | 28 +--
 3 files changed, 53 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-extended/xz/xz/run-ptest

diff --git a/meta/conf/distro/include/ptest-packagelists.inc 
b/meta/conf/distro/include/ptest-packagelists.inc
index a1643c5548..68a3f63a6a 100644
--- a/meta/conf/distro/include/ptest-packagelists.inc
+++ b/meta/conf/distro/include/ptest-packagelists.inc
@@ -77,6 +77,7 @@ PTESTS_FAST = "\
 sed \
 slang \
 wayland \
+xz \
 zlib \
 libexif \
 "
diff --git a/meta/recipes-extended/xz/xz/run-ptest 
b/meta/recipes-extended/xz/xz/run-ptest
new file mode 100644
index 00..cc8ba92016
--- /dev/null
+++ b/meta/recipes-extended/xz/xz/run-ptest
@@ -0,0 +1,26 @@
+#!/bin/bash
+
+ptestdir=$(dirname "$(readlink -f "$0")")
+cd "$ptestdir"/tests || exit
+
+# executables test cases
+tests_exec=$(file $(ls test_*) | grep "ELF" | awk -F: '{print $1}')
+for i in ${tests_exec}; do
+./$i
+done
+
+# POSIX shell script test cases
+export srcdir=${ptestdir}/tests
+test_shell="test_files.sh test_scripts.sh test_compress.sh"
+for j in ${test_shell}; do
+if [ $j == "test_compress.sh" ]; then
+./$j create_compress_files
+else
+./$j
+fi
+if [ $? -eq 0 ]; then
+echo "PASS: $j"
+else
+echo "FAIL: $j"
+fi
+done
diff --git a/meta/recipes-extended/xz/xz_5.4.5.bb 
b/meta/recipes-extended/xz/xz_5.4.5.bb
index 09eade8be0..0f0849c3e5 100644
--- a/meta/recipes-extended/xz/xz_5.4.5.bb
+++ b/meta/recipes-extended/xz/xz_5.4.5.bb
@@ -24,13 +24,15 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=c8ea84ebe7b93cce676b54355dc6b2c0 \
 
file://lib/getopt.c;endline=23;md5=2069b0ee710572c03bb3114e4532cd84 \
 "
 
-SRC_URI = "https://tukaani.org/xz/xz-${PV}.tar.gz";
+SRC_URI = "https://tukaani.org/xz/xz-${PV}.tar.gz \
+   ${@bb.utils.contains('PTEST_ENABLED', '1', 'file://run-ptest', '', 
d)} \
+  "
 SRC_URI[sha256sum] = 
"135c90b934aee8fbc0d467de87a05cb70d627da36abe518c357a873709e5b7d6"
 UPSTREAM_CHECK_REGEX = "xz-(?P\d+(\.\d+)+)\.tar"
 
 CACHED_CONFIGUREVARS += "gl_cv_posix_shell=/bin/sh"
 
-inherit autotools gettext
+inherit autotools gettext ptest
 
 PACKAGES =+ "liblzma"
 
@@ -42,3 +44,25 @@ ALTERNATIVE:${PN} = "xz xzcat unxz \
  lzma lzcat unlzma"
 
 BBCLASSEXTEND = "native nativesdk"
+
+RDEPENDS:${PN}-ptest += "bash file"
+
+do_compile_ptest() {
+oe_runmake check TESTS=
+}
+
+do_install_ptest () {
+install -d ${D}${PTEST_PATH}/tests
+find ${B}/tests/.libs -type f -executable -exec cp {} 
${D}${PTEST_PATH}/tests \;
+cp ${B}/config.h ${D}${PTEST_PATH}
+for i in files xzgrep_expected_output test_files.sh test_scripts.sh 
test_compress.sh; do
+cp -r ${S}/tests/$i ${D}${PTEST_PATH}/tests
+done
+mkdir -p ${D}${PTEST_PATH}/src/xz
+ln -s ${bindir}/xz ${D}${PTEST_PATH}/src/xz/xz
+mkdir -p ${D}${PTEST_PATH}/src/xzdec
+ln -s ${bindir}/xzdec ${D}${PTEST_PATH}/src/xzdec/xzdec
+mkdir -p ${D}${PTEST_PATH}/src/scripts
+ln -s ${bindir}/xzdiff ${D}${PTEST_PATH}/src/scripts/xzdiff
+ln -s ${bindir}/xzgrep ${D}${PTEST_PATH}/src/scripts/xzgrep
+}
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194345): 
https://lists.openembedded.org/g/openembedded-core/message/194345
Mute This Topic: https://lists.openembedded.org/mt/103971280/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] lttng-modules: upgrade 2.13.10 -> 2.13.11

2024-01-25 Thread Denys Dmytriyenko
Changelog:
https://lwn.net/Articles/957396/

Drop 2 backported patches and 1 implemented differently upstream.

Signed-off-by: Denys Dmytriyenko 
---
 ...-and-cpu_core_id-moved-in-linux-6.7..patch | 79 ---
 ...per-fdtable-adjust-fd-lookup-to-v6.7.patch | 35 
 ...ignatures-changed-in-linux-6.7.0-rc1.patch | 71 -
 ...es_2.13.10.bb => lttng-modules_2.13.11.bb} |  5 +-
 4 files changed, 1 insertion(+), 189 deletions(-)
 delete mode 100644 
meta/recipes-kernel/lttng/lttng-modules/0001-fix-phys_proc_id-and-cpu_core_id-moved-in-linux-6.7..patch
 delete mode 100644 
meta/recipes-kernel/lttng/lttng-modules/0001-wrapper-fdtable-adjust-fd-lookup-to-v6.7.patch
 delete mode 100644 
meta/recipes-kernel/lttng/lttng-modules/0002-fix-mm-vmscan-signatures-changed-in-linux-6.7.0-rc1.patch
 rename meta/recipes-kernel/lttng/{lttng-modules_2.13.10.bb => 
lttng-modules_2.13.11.bb} (81%)

diff --git 
a/meta/recipes-kernel/lttng/lttng-modules/0001-fix-phys_proc_id-and-cpu_core_id-moved-in-linux-6.7..patch
 
b/meta/recipes-kernel/lttng/lttng-modules/0001-fix-phys_proc_id-and-cpu_core_id-moved-in-linux-6.7..patch
deleted file mode 100644
index 598f5a7efa..00
--- 
a/meta/recipes-kernel/lttng/lttng-modules/0001-fix-phys_proc_id-and-cpu_core_id-moved-in-linux-6.7..patch
+++ /dev/null
@@ -1,79 +0,0 @@
-From 4f32efe70b618c4721bf197692fc9d709d352528 Mon Sep 17 00:00:00 2001
-From: Kienan Stewart 
-Date: Mon, 20 Nov 2023 11:27:12 -0500
-Subject: [PATCH 1/2] fix: phys_proc_id and cpu_core_id moved in linux
- 6.7.0-rc1
-
-See upstream commit:
-
-commit 02fb601d27a7abf60d52b21bdf5b100a8d63da3f
-Author: Thomas Gleixner 
-Date:   Mon Aug 14 10:18:30 2023 +0200
-
-x86/cpu: Move phys_proc_id into topology info
-
-Rename it to pkg_id which is the terminology used in the kernel.
-
-No functional change.
-
-See upstream commit:
-
-commit e95256335d45cc965cd12c423535002974313340
-Author: Thomas Gleixner 
-Date:   Mon Aug 14 10:18:34 2023 +0200
-
-x86/cpu: Move cpu_core_id into topology info
-
-Rename it to core_id and stick it to the other ID fields.
-
-No functional change.
-
-Upstream-Status: Backport [commit 4f32efe7]
-
-Signed-off-by: Kienan Stewart 
-Signed-off-by: Mathieu Desnoyers 
-Change-Id: I574b02430210d5bb72c4b9db901d0e3a6dc7bea0

- .../instrumentation/events/lttng-statedump.h  | 19 +++
- 1 file changed, 19 insertions(+)
-
-diff --git a/include/instrumentation/events/lttng-statedump.h 
b/include/instrumentation/events/lttng-statedump.h
-index 642aa356..4831a941 100644
 a/include/instrumentation/events/lttng-statedump.h
-+++ b/include/instrumentation/events/lttng-statedump.h
-@@ -253,6 +253,23 @@ LTTNG_TRACEPOINT_EVENT(lttng_statedump_interrupt,
- 
- #define LTTNG_HAVE_STATEDUMP_CPU_TOPOLOGY
- 
-+#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0))
-+LTTNG_TRACEPOINT_EVENT(lttng_statedump_cpu_topology,
-+  TP_PROTO(struct lttng_kernel_session *session, struct cpuinfo_x86 *c),
-+  TP_ARGS(session, c),
-+  TP_FIELDS(
-+  ctf_string(architecture, "x86")
-+  ctf_integer(uint16_t, cpu_id, c->cpu_index)
-+  ctf_string(vendor, c->x86_vendor_id[0] ? c->x86_vendor_id : 
"unknown")
-+  ctf_integer(uint8_t, family, c->x86)
-+  ctf_integer(uint8_t, model, c->x86_model)
-+  ctf_string(model_name, c->x86_model_id[0] ? c->x86_model_id : 
"unknown")
-+  ctf_integer(uint16_t, physical_id, c->topo.pkg_id)
-+  ctf_integer(uint16_t, core_id, c->topo.core_id)
-+  ctf_integer(uint16_t, cores, c->booted_cores)
-+  )
-+)
-+#else
- LTTNG_TRACEPOINT_EVENT(lttng_statedump_cpu_topology,
-   TP_PROTO(struct lttng_kernel_session *session, struct cpuinfo_x86 *c),
-   TP_ARGS(session, c),
-@@ -268,6 +285,8 @@ LTTNG_TRACEPOINT_EVENT(lttng_statedump_cpu_topology,
-   ctf_integer(uint16_t, cores, c->booted_cores)
-   )
- )
-+#endif /* LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0) */
-+
- #endif /* CONFIG_X86_32 || CONFIG_X86_64 */
- 
- #endif /*  LTTNG_TRACE_LTTNG_STATEDUMP_H */
--- 
-2.34.1
-
diff --git 
a/meta/recipes-kernel/lttng/lttng-modules/0001-wrapper-fdtable-adjust-fd-lookup-to-v6.7.patch
 
b/meta/recipes-kernel/lttng/lttng-modules/0001-wrapper-fdtable-adjust-fd-lookup-to-v6.7.patch
deleted file mode 100644
index b374483517..00
--- 
a/meta/recipes-kernel/lttng/lttng-modules/0001-wrapper-fdtable-adjust-fd-lookup-to-v6.7.patch
+++ /dev/null
@@ -1,35 +0,0 @@
-From 76e4ea0c33a8c7726c0df28083d5c8bc1c1335e8 Mon Sep 17 00:00:00 2001
-From: Bruce Ashfield 
-Date: Thu, 23 Nov 2023 13:49:51 -0500
-Subject: [PATCH] wrapper/fdtable: adjust fd lookup to v6.7+
-
-commit 0ede61d8589cc2d93 [file: convert to SLAB_TYPESAFE_BY_RCU]
-renames lookup_fd_rcu to lookup_fdget_rcu, so we need to
-version adjust the fdtable wrapper accordingly.
-
-Upstream-Status: Submitted 
[ht

[OE-core] [kirkstone][patch 3/3] xwayland: Fix CVE-2023-6377 CVE-2023-6478

2024-01-25 Thread Lee Chee Yang
From: Lee Chee Yang 

Signed-off-by: Lee Chee Yang 
---
 .../xwayland/xwayland/CVE-2023-6377.patch | 82 +++
 .../xwayland/xwayland/CVE-2023-6478.patch | 66 +++
 .../xwayland/xwayland_22.1.8.bb   |  2 +
 3 files changed, 150 insertions(+)
 create mode 100644 meta/recipes-graphics/xwayland/xwayland/CVE-2023-6377.patch
 create mode 100644 meta/recipes-graphics/xwayland/xwayland/CVE-2023-6478.patch

diff --git a/meta/recipes-graphics/xwayland/xwayland/CVE-2023-6377.patch 
b/meta/recipes-graphics/xwayland/xwayland/CVE-2023-6377.patch
new file mode 100644
index 00..f650f495a3
--- /dev/null
+++ b/meta/recipes-graphics/xwayland/xwayland/CVE-2023-6377.patch
@@ -0,0 +1,82 @@
+CVE: CVE-2023-6377
+Upstream-Status: Backport [ 
https://gitlab.freedesktop.org/xorg/xserver/-/commit/19e9f199950aaa4b9b7696936d1b067475da999c
 ]
+Signed-off-by: Lee Chee Yang 
+
+
+From 19e9f199950aaa4b9b7696936d1b067475da999c Mon Sep 17 00:00:00 2001
+From: Peter Hutterer 
+Date: Tue, 28 Nov 2023 15:19:04 +1000
+Subject: [PATCH] Xi: allocate enough XkbActions for our buttons
+
+button->xkb_acts is supposed to be an array sufficiently large for all
+our buttons, not just a single XkbActions struct. Allocating
+insufficient memory here means when we memcpy() later in
+XkbSetDeviceInfo we write into memory that wasn't ours to begin with,
+leading to the usual security ooopsiedaisies.
+
+CVE-2023-6377, ZDI-CAN-22412, ZDI-CAN-22413
+
+This vulnerability was discovered by:
+Jan-Niklas Sohn working with Trend Micro Zero Day Initiative
+
+(cherry picked from commit 0c1a93d319558fe3ab2d94f51d174b4f93810afd)
+---
+ Xi/exevents.c | 12 ++--
+ dix/devices.c | 10 ++
+ 2 files changed, 16 insertions(+), 6 deletions(-)
+
+diff --git a/Xi/exevents.c b/Xi/exevents.c
+index dcd4efb3bc..54ea11a938 100644
+--- a/Xi/exevents.c
 b/Xi/exevents.c
+@@ -611,13 +611,13 @@ DeepCopyPointerClasses(DeviceIntPtr from, DeviceIntPtr 
to)
+ }
+ 
+ if (from->button->xkb_acts) {
+-if (!to->button->xkb_acts) {
+-to->button->xkb_acts = calloc(1, sizeof(XkbAction));
+-if (!to->button->xkb_acts)
+-FatalError("[Xi] not enough memory for xkb_acts.\n");
+-}
++size_t maxbuttons = max(to->button->numButtons, 
from->button->numButtons);
++to->button->xkb_acts = xnfreallocarray(to->button->xkb_acts,
++   maxbuttons,
++   sizeof(XkbAction));
++memset(to->button->xkb_acts, 0, maxbuttons * sizeof(XkbAction));
+ memcpy(to->button->xkb_acts, from->button->xkb_acts,
+-   sizeof(XkbAction));
++   from->button->numButtons * sizeof(XkbAction));
+ }
+ else {
+ free(to->button->xkb_acts);
+diff --git a/dix/devices.c b/dix/devices.c
+index 7150734a58..20fef16923 100644
+--- a/dix/devices.c
 b/dix/devices.c
+@@ -2530,6 +2530,8 @@ RecalculateMasterButtons(DeviceIntPtr slave)
+ 
+ if (master->button && master->button->numButtons != maxbuttons) {
+ int i;
++int last_num_buttons = master->button->numButtons;
++
+ DeviceChangedEvent event = {
+ .header = ET_Internal,
+ .type = ET_DeviceChanged,
+@@ -2540,6 +2542,14 @@ RecalculateMasterButtons(DeviceIntPtr slave)
+ };
+ 
+ master->button->numButtons = maxbuttons;
++if (last_num_buttons < maxbuttons) {
++master->button->xkb_acts = 
xnfreallocarray(master->button->xkb_acts,
++   maxbuttons,
++   sizeof(XkbAction));
++memset(&master->button->xkb_acts[last_num_buttons],
++   0,
++   (maxbuttons - last_num_buttons) * sizeof(XkbAction));
++}
+ 
+ memcpy(&event.buttons.names, master->button->labels, maxbuttons *
+sizeof(Atom));
+-- 
+GitLab
+
diff --git a/meta/recipes-graphics/xwayland/xwayland/CVE-2023-6478.patch 
b/meta/recipes-graphics/xwayland/xwayland/CVE-2023-6478.patch
new file mode 100644
index 00..23fbc0e9e2
--- /dev/null
+++ b/meta/recipes-graphics/xwayland/xwayland/CVE-2023-6478.patch
@@ -0,0 +1,66 @@
+CVE: CVE-2023-6478
+Upstream-Status: Backport [ 
https://gitlab.freedesktop.org/xorg/xserver/-/commit/aaf854fb25541380cc38a221c15f0e8372f48872
 ]
+Signed-off-by: Lee Chee Yang 
+
+
+From aaf854fb25541380cc38a221c15f0e8372f48872 Mon Sep 17 00:00:00 2001
+From: Peter Hutterer 
+Date: Mon, 27 Nov 2023 16:27:49 +1000
+Subject: [PATCH] randr: avoid integer truncation in length check of
+ ProcRRChange*Property
+
+Affected are ProcRRChangeProviderProperty and ProcRRChangeOutputProperty.
+See also xserver@8f454b79 where this same bug was fixed for the core
+protocol and XI.
+
+This fixes an OOB read and the resulting informat

[OE-core] [kirkstone][patch 2/3] python3-jinja2: upgrade 3.1.2 -> 3.1.3

2024-01-25 Thread Lee Chee Yang
From: Wang Mingyu 

Changelog:
==
-Fix compiler error when checking if required blocks in parent templates are 
empty.
-xmlattr filter does not allow keys with spaces.
-Make error messages stemming from invalid nesting of {% trans %} blocks more 
helpful

(cherry picked from OE-Core rev: 8a0524464583d69df7746253f5020c2c125a8e1f)

Signed-off-by: Wang Mingyu 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Richard Purdie 
Signed-off-by: Lee Chee Yang 
---
 .../python/{python3-jinja2_3.1.2.bb => python3-jinja2_3.1.3.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-devtools/python/{python3-jinja2_3.1.2.bb => 
python3-jinja2_3.1.3.bb} (92%)

diff --git a/meta/recipes-devtools/python/python3-jinja2_3.1.2.bb 
b/meta/recipes-devtools/python/python3-jinja2_3.1.3.bb
similarity index 92%
rename from meta/recipes-devtools/python/python3-jinja2_3.1.2.bb
rename to meta/recipes-devtools/python/python3-jinja2_3.1.3.bb
index 80e0b85670..068e21bf5f 100644
--- a/meta/recipes-devtools/python/python3-jinja2_3.1.2.bb
+++ b/meta/recipes-devtools/python/python3-jinja2_3.1.3.bb
@@ -4,7 +4,7 @@ HOMEPAGE = "https://pypi.org/project/Jinja2/";
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE.rst;md5=5dc88300786f1c214c1e9827a5229462"
 
-SRC_URI[sha256sum] = 
"31351a702a408a9e7595a8fc6150fc3f43bb6bf7e319770cbc0db9df9437e852"
+SRC_URI[sha256sum] = 
"ac8bd6544d4bb2c9792bf3a159e80bba8fda7f07e81bc3aed565432d5925ba90"
 
 PYPI_PACKAGE = "Jinja2"
 
-- 
2.37.3


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194342): 
https://lists.openembedded.org/g/openembedded-core/message/194342
Mute This Topic: https://lists.openembedded.org/mt/103969589/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [kirkstone][patch 1/3] python3-jinja2: upgrade 3.1.1 -> 3.1.2

2024-01-25 Thread Lee Chee Yang
From: Alexander Kanavin 

(cherry picked from OE-Core rev: 1e58fa1fff649a4ab07290d2b0e5a8d69d51ef16)

Signed-off-by: Alexander Kanavin 
Signed-off-by: Luca Ceresoli 
Signed-off-by: Richard Purdie 
Signed-off-by: Lee Chee Yang 
---
 .../python/{python3-jinja2_3.1.1.bb => python3-jinja2_3.1.2.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-devtools/python/{python3-jinja2_3.1.1.bb => 
python3-jinja2_3.1.2.bb} (92%)

diff --git a/meta/recipes-devtools/python/python3-jinja2_3.1.1.bb 
b/meta/recipes-devtools/python/python3-jinja2_3.1.2.bb
similarity index 92%
rename from meta/recipes-devtools/python/python3-jinja2_3.1.1.bb
rename to meta/recipes-devtools/python/python3-jinja2_3.1.2.bb
index c38686a5c2..80e0b85670 100644
--- a/meta/recipes-devtools/python/python3-jinja2_3.1.1.bb
+++ b/meta/recipes-devtools/python/python3-jinja2_3.1.2.bb
@@ -4,7 +4,7 @@ HOMEPAGE = "https://pypi.org/project/Jinja2/";
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE.rst;md5=5dc88300786f1c214c1e9827a5229462"
 
-SRC_URI[sha256sum] = 
"640bed4bb501cbd17194b3cace1dc2126f5b619cf068a726b98192a0fde74ae9"
+SRC_URI[sha256sum] = 
"31351a702a408a9e7595a8fc6150fc3f43bb6bf7e319770cbc0db9df9437e852"
 
 PYPI_PACKAGE = "Jinja2"
 
-- 
2.37.3


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194341): 
https://lists.openembedded.org/g/openembedded-core/message/194341
Mute This Topic: https://lists.openembedded.org/mt/103969588/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] Patchtest results for [RFC PATCH][RESEND] cve-update-nvd2-native: make an error if the DB file is not present at the end of do_fetch

2024-01-25 Thread Patchtest
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/RFC-RESEND-cve-update-nvd2-native-make-an-error-if-the-DB-file-is-not-present-at-the-end-of-do_fetch.patch

FAIL: test shortlog length: Edit shortlog so that it is 90 characters or less 
(currently 99 characters) (test_mbox.TestMbox.test_shortlog_length)

PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence 
(test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)

SKIP: pretest pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: No modified recipes, skipping pretest 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes, skipping test 
(test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced 
(test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced 
(test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced 
(test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, 
skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing 
lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194340): 
https://lists.openembedded.org/g/openembedded-core/message/194340
Mute This Topic: https://lists.openembedded.org/mt/103968770/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC PATCH][RESEND] cve-update-nvd2-native: make an error if the DB file is not present at the end of do_fetch

2024-01-25 Thread Yuta Hayama
From: Yuta Hayama 

Signed-off-by: Yuta Hayama 
---
Please do not apply this. For now, this is just my question.


I think the issue of [YOCTO #14929] is partially still there.
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14929

Certainly, now that 8efe99214d has been applied, do_cve_check no longer runs on
broken DB file. However, if the first cve-update-nvd2-native:do_fetch run after
creating the build environment fails to save CVE_CHECK_DB_FILE, do_fetch will
have succeeded even though the DB file does not exist.

This may be confusing.

* do_cve_check seems to exit without doing anything if CVE_CHECK_DB_FILE is not
  existing. At this time, do_cve_check only logs in bb.note() and nothing seems
  to appear in the console. This may make it difficult for the user to
  understand what happened.

* Similar to cve-update-nvd2-native:do_fetch, do_cve_check is also successful
  even though it does not actually do anything. Yes, a check like this patch
  may be needed for cve-check.bbclass...

  I have written a task in our own recipe (sorry, we can't publish it) that
  depends on do_cve_check and expects ${WORKDIR}/temp/cve.log to be present,
  but I have found that the task may not work because of this. I don't know
  if I didn't understand do_cve_check well or if the current behavior is
  not good...

First, I would like to ask why cve-update-nvd2-native:do_fetch and do_cve_check
are completing successfully even when the DB file does not exist. Well, NVD API
frequently fails with errors, so I don't think it is necessary to fail the
do_fetch task if it "just failed to update". But other than that, I feel it's
better to make an error...

Thanks,


 meta/recipes-core/meta/cve-update-nvd2-native.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-core/meta/cve-update-nvd2-native.bb 
b/meta/recipes-core/meta/cve-update-nvd2-native.bb
index bfe48b27e7..42e50d9cd1 100644
--- a/meta/recipes-core/meta/cve-update-nvd2-native.bb
+++ b/meta/recipes-core/meta/cve-update-nvd2-native.bb
@@ -83,6 +83,9 @@ python do_fetch() {
 # Update failed, do not modify the database
 bb.warn("CVE database update failed")
 os.remove(db_tmp_file)
+
+if not os.path.isfile(db_file):
+bb.error("Failed to fetch the CVE DB. do_cve_check run after this will 
not work.")
 }
 
 do_fetch[lockfiles] += "${CVE_CHECK_DB_FILE_LOCK}"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194339): 
https://lists.openembedded.org/g/openembedded-core/message/194339
Mute This Topic: https://lists.openembedded.org/mt/103968560/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe-core][PATCH] gtk4: update 4.12.4 -> 4.12.5

2024-01-25 Thread Markus Volk
Overview of Changes in 4.12.5, 17-01-2024
=

* GtkColumnView:
 - Fix a crash on dispose

* GtkEmojiChooser:
 - Update to CLDR v44
 - Add more translations

* GtkFileDialog:
 - Return an error if no file is selected
 - Make closing the portal file chooser work

* GtkDropDown:
 - Fix display of the initial checkmark

* GtkShortcutsWindow:
 - Reduce the minimum width

* GDK:
 - Make the png loader safer against overflow

* Windows:
 - Use new clipboard api

* Wayland:
 - Fix cursor handling with graphics tablets

* macOS:
 - Silence secure-restore message
 - Fix build on macOS < 10.13

* Translation updates
 Basque
 British English
 Catalan
 Chinese (China)
 Czech
 Georgian
 German
 Hebrew
 Indonesian
 Lithuanian
 Persian
 Polish
 Romanian
 Russian
 Slovenian
 Swedish
 Turkish
 Ukrainian
 Vietnamese

Signed-off-by: Markus Volk 
---
 meta/recipes-gnome/gtk+/{gtk4_4.12.4.bb => gtk4_4.12.5.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-gnome/gtk+/{gtk4_4.12.4.bb => gtk4_4.12.5.bb} (98%)

diff --git a/meta/recipes-gnome/gtk+/gtk4_4.12.4.bb 
b/meta/recipes-gnome/gtk+/gtk4_4.12.5.bb
similarity index 98%
rename from meta/recipes-gnome/gtk+/gtk4_4.12.4.bb
rename to meta/recipes-gnome/gtk+/gtk4_4.12.5.bb
index 1b2b5c0db8..65ac1071f8 100644
--- a/meta/recipes-gnome/gtk+/gtk4_4.12.4.bb
+++ b/meta/recipes-gnome/gtk+/gtk4_4.12.5.bb
@@ -37,7 +37,7 @@ MAJ_VER = "${@oe.utils.trim_version("${PV}", 2)}"
 UPSTREAM_CHECK_REGEX = "gtk-(?P\d+\.(\d*[02468])+(\.\d+)+)\.tar.xz"
 
 SRC_URI = 
"http://ftp.gnome.org/pub/gnome/sources/gtk/${MAJ_VER}/gtk-${PV}.tar.xz";
-SRC_URI[sha256sum] = 
"ba67c6498e5599f928edafb9e08a320adfaa50ab2f0da6fc6ab2252fc2d57520"
+SRC_URI[sha256sum] = 
"28b356d590ee68ef626e2ef9820b2dd21441484a9a042a5a3f0c40e9dfc4f4f8"
 
 S = "${WORKDIR}/gtk-${PV}"
 
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194338): 
https://lists.openembedded.org/g/openembedded-core/message/194338
Mute This Topic: https://lists.openembedded.org/mt/103967045/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/1] qemu: Allow native and nativesdk versions on Linux older then 4.17

2024-01-25 Thread Richard Purdie
On Thu, 2024-01-25 at 22:41 +0100, Alexander Kanavin wrote:
> Initial release of Ubuntu 18.04 had 4.15 alright. Later point releases 
> offered much newer kernels. It’s also altogether EOL since end of may 2023.
> 
> Why should oe-core carry these? It’s RP’s call as qemu maintainer but my vote 
> is a firm no, unless additional arguments are put forward.

I had talked a bit with Mark about this issue and in the end I did
suggest sending the patch as the issue is a tricky one and it is
something we should really think about. At the very least it is worth
documenting and understanding the implications as it isn't easy to see
all the implications straight away.

The challenge is that the generated SDKs may end up running on
older/interesting systems and it is mostly pure luck we haven't hit
this. We do still have one 18.04 autobuilder system, albeit with a
slightly newer kernel version without this issue. Our "normal" sanity
checks don't cover it either.

I'm still unsure if we plan to merge the patch or not.

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194337): 
https://lists.openembedded.org/g/openembedded-core/message/194337
Mute This Topic: https://lists.openembedded.org/mt/103962276/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/1] qemu: Allow native and nativesdk versions on Linux older then 4.17

2024-01-25 Thread Mark Hatle

QEMU is a symptom of the real problem.

SDK_OLDEST_KERNEL is set to 3.2.0.  If that is what we keep it as, then we need 
to make sure that the nativesdk tooling works on a pre 4.17 kernel.


If that value moves to 4.17 then we can't use the same uninative / 
buildtools-tarball with older (LTS) releases.  So there is no "good" solution here.


As you said, it's RPs decision, I see three courses here:

1) Accept qemu mmap calls could break silently on pre-4.17 kernels
2) Apply this patch, allowing SDK_OLDEST_KERNEL to remain at 3.2.0
3) Bump SDK_OLDEST_KERNEL to at least 4.17

or ?

I'm not really partial to one solution or another in this case, but we do have 
an underlying issue that needs to be resolved or we're going to be chasing bug 
reports that we have no way to resolve.


--Mark

On 1/25/24 3:41 PM, Alexander Kanavin wrote:
Initial release of Ubuntu 18.04 had 4.15 alright. Later point releases offered 
much newer kernels. It’s also altogether EOL since end of may 2023.


Why should oe-core carry these? It’s RP’s call as qemu maintainer but my vote is 
a firm no, unless additional arguments are put forward.


Alex

On Thu 25. Jan 2024 at 22.04, Mark Hatle > wrote:


From: Mark Hatle mailto:mark.ha...@amd.com>>

Linux kernel 4.17 introduced two new mmap flags, MAP_FIXED_NOREPLACE and
MAP_SHARED_VALIDATE.  Starting with QEMU 8.1, these flags are now used
and required for proper system operation.  In order to build and run on a
system older then 4.17, we need to emulate this new behavior.

Not having a newer kernel could result in the mmap memory being allocated
in a way that will cause failures without QEMU checking for these
conditions.  Note, memory allocation issues are rare in my experience so
this is more of a 'just-in-case' behavior.

SDK_OLDEST_KERNEL is currently set to 3.2.0, the only way this can claim
that qemu works in an SDK is by checking the return values to emulate
the expected behavior.

Signed-off-by: Mark Hatle mailto:mark.ha...@amd.com>>
Signed-off-by: Mark Hatle mailto:mark.ha...@kernel.crashing.org>>
---
  meta/recipes-devtools/qemu/qemu.inc           |  12 +
  ...round-for-missing-MAP_FIXED_NOREPLAC.patch | 286 ++
  ...round-for-missing-MAP_SHARED_VALIDAT.patch |  51 
  3 files changed, 349 insertions(+)
  create mode 100644

meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
  create mode 100644

meta/recipes-devtools/qemu/qemu/0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch

diff --git a/meta/recipes-devtools/qemu/qemu.inc
b/meta/recipes-devtools/qemu/qemu.inc
index ccb2880402..7c31a5aa83 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -39,6 +39,18 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz
 \
             "
  UPSTREAM_CHECK_REGEX = "qemu-(?P\d+(\.\d+)+)\.tar"

+# SDK_OLDEST_KERNEL is set below 4.17, which is the minimum version
required by QEMU >= 8.1
+# This is due to two MMAP flags being used at certain points
+SRC_URI:append:class-nativesdk = " \
+       
file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
+       
file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
+        "
+
+# Support building and using native version on pre 4.17 kernels
+SRC_URI:append:class-native = " \
+       
file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
+       
file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
+        "

  SRC_URI[sha256sum] =
"bf00d2fa12010df8b0ade93371def58e632cb32a6bfdc5f5a0ff8e6a1fb1bf32"

diff --git

a/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
 
b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
new file mode 100644
index 00..8941911fb3
--- /dev/null
+++

b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
@@ -0,0 +1,286 @@
+From fa9bcabe2387bb230ef82d62827ad6f93b8a1e61 Mon Sep 17 00:00:00 2001
+From: Frederic Konrad mailto:fkon...@amd.com>>
+Date: Wed, 17 Jan 2024 18:15:06 +
+Subject: [PATCH 1/2] linux-user/*: workaround for missing 
MAP_FIXED_NOREPLACE
+
+QEMU v8.1.0 recently requires MAP_FIXED_NOREPLACE flags implementation for
mmap.
+
+This is missing from ubuntu 18.04, thus this patch catches the mmap calls 
which
+could use that new flag and forwards them to mmap when MAP_FIXED_NOREPLACE
+flag isn't set or emulates them by checking the returned address w.r.t the
+requested address.
+
+Signed-off-by: Frederic Kon

Re: [OE-core] [PATCH 1/1] qemu: Allow native and nativesdk versions on Linux older then 4.17

2024-01-25 Thread Mark Hatle



On 1/25/24 3:42 PM, Martin Jansa wrote:
I did something similar for LGE when we were using 18.04 ubuntu, but IIRC it's 
not about the kernel version, but glibc being older than 2.27.


18.04 is already unsupported for a while, I don't think oe-core should support 
unsupported host OS versions (that's why I've never send my version).


To make this change smaller you can just 
revert c42e77a90d9244c8caf76fe0e54f84200430a4e1 from qemu.


If oe-core really needs to support this I can share my version as in:
https://github.com/shr-project/meta-webosose/commit/7528c20bf3ba7576d4611f71f987a408ac8845c2
 



This version includes an actual check that the mmap returned a proper value. 
The version here just sets the flags to avoid the compilation issue.


Using the buildtools-tarball in your build will accomplish the same end result, 
hides the problem but doesn't verify the mmap will actually work (or error) as 
needed.


--Mark


Regards,

On Thu, Jan 25, 2024 at 10:04 PM Mark Hatle > wrote:


From: Mark Hatle mailto:mark.ha...@amd.com>>

Linux kernel 4.17 introduced two new mmap flags, MAP_FIXED_NOREPLACE and
MAP_SHARED_VALIDATE.  Starting with QEMU 8.1, these flags are now used
and required for proper system operation.  In order to build and run on a
system older then 4.17, we need to emulate this new behavior.

Not having a newer kernel could result in the mmap memory being allocated
in a way that will cause failures without QEMU checking for these
conditions.  Note, memory allocation issues are rare in my experience so
this is more of a 'just-in-case' behavior.

SDK_OLDEST_KERNEL is currently set to 3.2.0, the only way this can claim
that qemu works in an SDK is by checking the return values to emulate
the expected behavior.

Signed-off-by: Mark Hatle mailto:mark.ha...@amd.com>>
Signed-off-by: Mark Hatle mailto:mark.ha...@kernel.crashing.org>>
---
  meta/recipes-devtools/qemu/qemu.inc           |  12 +
  ...round-for-missing-MAP_FIXED_NOREPLAC.patch | 286 ++
  ...round-for-missing-MAP_SHARED_VALIDAT.patch |  51 
  3 files changed, 349 insertions(+)
  create mode 100644

meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
  create mode 100644

meta/recipes-devtools/qemu/qemu/0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch

diff --git a/meta/recipes-devtools/qemu/qemu.inc
b/meta/recipes-devtools/qemu/qemu.inc
index ccb2880402..7c31a5aa83 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -39,6 +39,18 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz
 \
             "
  UPSTREAM_CHECK_REGEX = "qemu-(?P\d+(\.\d+)+)\.tar"

+# SDK_OLDEST_KERNEL is set below 4.17, which is the minimum version
required by QEMU >= 8.1
+# This is due to two MMAP flags being used at certain points
+SRC_URI:append:class-nativesdk = " \
+       
file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
+       
file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
+        "
+
+# Support building and using native version on pre 4.17 kernels
+SRC_URI:append:class-native = " \
+       
file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
+       
file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
+        "

  SRC_URI[sha256sum] =
"bf00d2fa12010df8b0ade93371def58e632cb32a6bfdc5f5a0ff8e6a1fb1bf32"

diff --git

a/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
 
b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
new file mode 100644
index 00..8941911fb3
--- /dev/null
+++

b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
@@ -0,0 +1,286 @@
+From fa9bcabe2387bb230ef82d62827ad6f93b8a1e61 Mon Sep 17 00:00:00 2001
+From: Frederic Konrad mailto:fkon...@amd.com>>
+Date: Wed, 17 Jan 2024 18:15:06 +
+Subject: [PATCH 1/2] linux-user/*: workaround for missing 
MAP_FIXED_NOREPLACE
+
+QEMU v8.1.0 recently requires MAP_FIXED_NOREPLACE flags implementation for
mmap.
+
+This is missing from ubuntu 18.04, thus this patch catches the mmap calls 
which
+could use that new flag and forwards them to mmap when MAP_FIXED_NOREPLACE
+flag isn't set or emulates them by checking the returned address w.r.t the
+requested address.
+
+Signed-off-by: Frederic Konrad mailto:fkon...@amd.com>>
+Signed-off-by: Francisco Iglesias mailto:francisco.igles...@amd

Re: [OE-core] [PATCH 1/1] qemu: Allow native and nativesdk versions on Linux older then 4.17

2024-01-25 Thread Martin Jansa
I did something similar for LGE when we were using 18.04 ubuntu, but IIRC
it's not about the kernel version, but glibc being older than 2.27.

18.04 is already unsupported for a while, I don't think oe-core should
support unsupported host OS versions (that's why I've never send my
version).

To make this change smaller you can just
revert c42e77a90d9244c8caf76fe0e54f84200430a4e1 from qemu.

If oe-core really needs to support this I can share my version as in:
https://github.com/shr-project/meta-webosose/commit/7528c20bf3ba7576d4611f71f987a408ac8845c2

Regards,

On Thu, Jan 25, 2024 at 10:04 PM Mark Hatle 
wrote:

> From: Mark Hatle 
>
> Linux kernel 4.17 introduced two new mmap flags, MAP_FIXED_NOREPLACE and
> MAP_SHARED_VALIDATE.  Starting with QEMU 8.1, these flags are now used
> and required for proper system operation.  In order to build and run on a
> system older then 4.17, we need to emulate this new behavior.
>
> Not having a newer kernel could result in the mmap memory being allocated
> in a way that will cause failures without QEMU checking for these
> conditions.  Note, memory allocation issues are rare in my experience so
> this is more of a 'just-in-case' behavior.
>
> SDK_OLDEST_KERNEL is currently set to 3.2.0, the only way this can claim
> that qemu works in an SDK is by checking the return values to emulate
> the expected behavior.
>
> Signed-off-by: Mark Hatle 
> Signed-off-by: Mark Hatle 
> ---
>  meta/recipes-devtools/qemu/qemu.inc   |  12 +
>  ...round-for-missing-MAP_FIXED_NOREPLAC.patch | 286 ++
>  ...round-for-missing-MAP_SHARED_VALIDAT.patch |  51 
>  3 files changed, 349 insertions(+)
>  create mode 100644
> meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
>  create mode 100644
> meta/recipes-devtools/qemu/qemu/0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch
>
> diff --git a/meta/recipes-devtools/qemu/qemu.inc
> b/meta/recipes-devtools/qemu/qemu.inc
> index ccb2880402..7c31a5aa83 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -39,6 +39,18 @@ SRC_URI = "
> https://download.qemu.org/${BPN}-${PV}.tar.xz \
> "
>  UPSTREAM_CHECK_REGEX = "qemu-(?P\d+(\.\d+)+)\.tar"
>
> +# SDK_OLDEST_KERNEL is set below 4.17, which is the minimum version
> required by QEMU >= 8.1
> +# This is due to two MMAP flags being used at certain points
> +SRC_URI:append:class-nativesdk = " \
> +
>  file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
> +
>  file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
> +"
> +
> +# Support building and using native version on pre 4.17 kernels
> +SRC_URI:append:class-native = " \
> +
>  file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
> +
>  file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
> +"
>
>  SRC_URI[sha256sum] =
> "bf00d2fa12010df8b0ade93371def58e632cb32a6bfdc5f5a0ff8e6a1fb1bf32"
>
> diff --git
> a/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
> b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
> new file mode 100644
> index 00..8941911fb3
> --- /dev/null
> +++
> b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
> @@ -0,0 +1,286 @@
> +From fa9bcabe2387bb230ef82d62827ad6f93b8a1e61 Mon Sep 17 00:00:00 2001
> +From: Frederic Konrad 
> +Date: Wed, 17 Jan 2024 18:15:06 +
> +Subject: [PATCH 1/2] linux-user/*: workaround for missing
> MAP_FIXED_NOREPLACE
> +
> +QEMU v8.1.0 recently requires MAP_FIXED_NOREPLACE flags implementation
> for mmap.
> +
> +This is missing from ubuntu 18.04, thus this patch catches the mmap calls
> which
> +could use that new flag and forwards them to mmap when MAP_FIXED_NOREPLACE
> +flag isn't set or emulates them by checking the returned address w.r.t the
> +requested address.
> +
> +Signed-off-by: Frederic Konrad 
> +Signed-off-by: Francisco Iglesias 
> +
> +Upstream-Status: Inappropriate [OE specific]
> +
> +The upstream only supports the last two major releases of an OS.  The ones
> +they have declared all have kernel 4.17 or newer.
> +
> +See:
> +https://xilinx.slack.com/archives/D04G2647CTV/p1705074697942019
> +
> +https://www.qemu.org/docs/master/about/build-platforms.html
> +
> + The project aims to support the most recent major version at all times
> for up
> + to five years after its initial release. Support for the previous major
> + version will be dropped 2 years after the new major version is released
> or
> + when the vendor itself drops support, whichever comes first.
> +
> +Signed-off-by: Mark Hatle 
> +---
> + linux-user/elfload.c|  7 +++--
> + linux-user/meson.build  |  1 +
> + linux-user/mmap-fixed.c | 63 +
> + linux-user/mmap-fixed.h | 39 +
> + linu

Re: [OE-core] [PATCH 1/1] qemu: Allow native and nativesdk versions on Linux older then 4.17

2024-01-25 Thread Alexander Kanavin
Initial release of Ubuntu 18.04 had 4.15 alright. Later point releases
offered much newer kernels. It’s also altogether EOL since end of may 2023.

Why should oe-core carry these? It’s RP’s call as qemu maintainer but my
vote is a firm no, unless additional arguments are put forward.

Alex

On Thu 25. Jan 2024 at 22.04, Mark Hatle 
wrote:

> From: Mark Hatle 
>
> Linux kernel 4.17 introduced two new mmap flags, MAP_FIXED_NOREPLACE and
> MAP_SHARED_VALIDATE.  Starting with QEMU 8.1, these flags are now used
> and required for proper system operation.  In order to build and run on a
> system older then 4.17, we need to emulate this new behavior.
>
> Not having a newer kernel could result in the mmap memory being allocated
> in a way that will cause failures without QEMU checking for these
> conditions.  Note, memory allocation issues are rare in my experience so
> this is more of a 'just-in-case' behavior.
>
> SDK_OLDEST_KERNEL is currently set to 3.2.0, the only way this can claim
> that qemu works in an SDK is by checking the return values to emulate
> the expected behavior.
>
> Signed-off-by: Mark Hatle 
> Signed-off-by: Mark Hatle 
> ---
>  meta/recipes-devtools/qemu/qemu.inc   |  12 +
>  ...round-for-missing-MAP_FIXED_NOREPLAC.patch | 286 ++
>  ...round-for-missing-MAP_SHARED_VALIDAT.patch |  51 
>  3 files changed, 349 insertions(+)
>  create mode 100644
> meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
>  create mode 100644
> meta/recipes-devtools/qemu/qemu/0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch
>
> diff --git a/meta/recipes-devtools/qemu/qemu.inc
> b/meta/recipes-devtools/qemu/qemu.inc
> index ccb2880402..7c31a5aa83 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -39,6 +39,18 @@ SRC_URI = "
> https://download.qemu.org/${BPN}-${PV}.tar.xz \
> "
>  UPSTREAM_CHECK_REGEX = "qemu-(?P\d+(\.\d+)+)\.tar"
>
> +# SDK_OLDEST_KERNEL is set below 4.17, which is the minimum version
> required by QEMU >= 8.1
> +# This is due to two MMAP flags being used at certain points
> +SRC_URI:append:class-nativesdk = " \
> +
>  file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
> +
>  file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
> +"
> +
> +# Support building and using native version on pre 4.17 kernels
> +SRC_URI:append:class-native = " \
> +
>  file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
> +
>  file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
> +"
>
>  SRC_URI[sha256sum] =
> "bf00d2fa12010df8b0ade93371def58e632cb32a6bfdc5f5a0ff8e6a1fb1bf32"
>
> diff --git
> a/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
> b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
> new file mode 100644
> index 00..8941911fb3
> --- /dev/null
> +++
> b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
> @@ -0,0 +1,286 @@
> +From fa9bcabe2387bb230ef82d62827ad6f93b8a1e61 Mon Sep 17 00:00:00 2001
> +From: Frederic Konrad 
> +Date: Wed, 17 Jan 2024 18:15:06 +
> +Subject: [PATCH 1/2] linux-user/*: workaround for missing
> MAP_FIXED_NOREPLACE
> +
> +QEMU v8.1.0 recently requires MAP_FIXED_NOREPLACE flags implementation
> for mmap.
> +
> +This is missing from ubuntu 18.04, thus this patch catches the mmap calls
> which
> +could use that new flag and forwards them to mmap when MAP_FIXED_NOREPLACE
> +flag isn't set or emulates them by checking the returned address w.r.t the
> +requested address.
> +
> +Signed-off-by: Frederic Konrad 
> +Signed-off-by: Francisco Iglesias 
> +
> +Upstream-Status: Inappropriate [OE specific]
> +
> +The upstream only supports the last two major releases of an OS.  The ones
> +they have declared all have kernel 4.17 or newer.
> +
> +See:
> +https://xilinx.slack.com/archives/D04G2647CTV/p1705074697942019
> +
> +https://www.qemu.org/docs/master/about/build-platforms.html
> +
> + The project aims to support the most recent major version at all times
> for up
> + to five years after its initial release. Support for the previous major
> + version will be dropped 2 years after the new major version is released
> or
> + when the vendor itself drops support, whichever comes first.
> +
> +Signed-off-by: Mark Hatle 
> +---
> + linux-user/elfload.c|  7 +++--
> + linux-user/meson.build  |  1 +
> + linux-user/mmap-fixed.c | 63 +
> + linux-user/mmap-fixed.h | 39 +
> + linux-user/mmap.c   | 31 +++-
> + linux-user/syscall.c|  1 +
> + 6 files changed, 125 insertions(+), 17 deletions(-)
> + create mode 100644 linux-user/mmap-fixed.c
> + create mode 100644 linux-user/mmap-fixed.h
> +
> +Index: qemu-8.2.0/linux-user/elfload.c
> 

[OE-core] [PATCH 0/1] Support running qemu on kernel older then 4.17

2024-01-25 Thread Mark Hatle
We were attempting to build qemu on an Ubuntu 18.04 system and ran into
an issue where certain (newer) MMAP flags were not defined.  After further
tracking it was determined that QEMU 8.1 moved forward and only supports
usage on kernel 4.17 or newer.

Using the patch included with this, you can build for an older host, but
more importantly you can build an SDK that includes QEMU that will execute
on the 'SDK_OLDEST_KERNEL'.  While I've not gone back and verified things
work on 3.2.0 system, I have verified that Ubuntu 18.04 is working for me.

(Ubuntu 18.04 is kernel 4.15)

Mark Hatle (1):
  qemu: Allow native and nativesdk versions on Linux older then 4.17

 meta/recipes-devtools/qemu/qemu.inc   |  12 +
 ...round-for-missing-MAP_FIXED_NOREPLAC.patch | 286 ++
 ...round-for-missing-MAP_SHARED_VALIDAT.patch |  51 
 3 files changed, 349 insertions(+)
 create mode 100644 
meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
 create mode 100644 
meta/recipes-devtools/qemu/qemu/0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch

-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194332): 
https://lists.openembedded.org/g/openembedded-core/message/194332
Mute This Topic: https://lists.openembedded.org/mt/103962277/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/1] qemu: Allow native and nativesdk versions on Linux older then 4.17

2024-01-25 Thread Mark Hatle
From: Mark Hatle 

Linux kernel 4.17 introduced two new mmap flags, MAP_FIXED_NOREPLACE and
MAP_SHARED_VALIDATE.  Starting with QEMU 8.1, these flags are now used
and required for proper system operation.  In order to build and run on a
system older then 4.17, we need to emulate this new behavior.

Not having a newer kernel could result in the mmap memory being allocated
in a way that will cause failures without QEMU checking for these
conditions.  Note, memory allocation issues are rare in my experience so
this is more of a 'just-in-case' behavior.

SDK_OLDEST_KERNEL is currently set to 3.2.0, the only way this can claim
that qemu works in an SDK is by checking the return values to emulate
the expected behavior.

Signed-off-by: Mark Hatle 
Signed-off-by: Mark Hatle 
---
 meta/recipes-devtools/qemu/qemu.inc   |  12 +
 ...round-for-missing-MAP_FIXED_NOREPLAC.patch | 286 ++
 ...round-for-missing-MAP_SHARED_VALIDAT.patch |  51 
 3 files changed, 349 insertions(+)
 create mode 100644 
meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
 create mode 100644 
meta/recipes-devtools/qemu/qemu/0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch

diff --git a/meta/recipes-devtools/qemu/qemu.inc 
b/meta/recipes-devtools/qemu/qemu.inc
index ccb2880402..7c31a5aa83 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -39,6 +39,18 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz \
"
 UPSTREAM_CHECK_REGEX = "qemu-(?P\d+(\.\d+)+)\.tar"
 
+# SDK_OLDEST_KERNEL is set below 4.17, which is the minimum version required 
by QEMU >= 8.1
+# This is due to two MMAP flags being used at certain points
+SRC_URI:append:class-nativesdk = " \
+   file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
+   file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
+"
+
+# Support building and using native version on pre 4.17 kernels
+SRC_URI:append:class-native = " \
+   file://0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch \
+   file://0012-linux-user-workaround-for-missing-MAP_SHARED_VALIDAT.patch \
+"
 
 SRC_URI[sha256sum] = 
"bf00d2fa12010df8b0ade93371def58e632cb32a6bfdc5f5a0ff8e6a1fb1bf32"
 
diff --git 
a/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
 
b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
new file mode 100644
index 00..8941911fb3
--- /dev/null
+++ 
b/meta/recipes-devtools/qemu/qemu/0011-linux-user-workaround-for-missing-MAP_FIXED_NOREPLAC.patch
@@ -0,0 +1,286 @@
+From fa9bcabe2387bb230ef82d62827ad6f93b8a1e61 Mon Sep 17 00:00:00 2001
+From: Frederic Konrad 
+Date: Wed, 17 Jan 2024 18:15:06 +
+Subject: [PATCH 1/2] linux-user/*: workaround for missing MAP_FIXED_NOREPLACE
+
+QEMU v8.1.0 recently requires MAP_FIXED_NOREPLACE flags implementation for 
mmap.
+
+This is missing from ubuntu 18.04, thus this patch catches the mmap calls which
+could use that new flag and forwards them to mmap when MAP_FIXED_NOREPLACE
+flag isn't set or emulates them by checking the returned address w.r.t the
+requested address.
+
+Signed-off-by: Frederic Konrad 
+Signed-off-by: Francisco Iglesias 
+
+Upstream-Status: Inappropriate [OE specific]
+
+The upstream only supports the last two major releases of an OS.  The ones
+they have declared all have kernel 4.17 or newer.
+
+See:
+https://xilinx.slack.com/archives/D04G2647CTV/p1705074697942019
+
+https://www.qemu.org/docs/master/about/build-platforms.html
+
+ The project aims to support the most recent major version at all times for up
+ to five years after its initial release. Support for the previous major
+ version will be dropped 2 years after the new major version is released or
+ when the vendor itself drops support, whichever comes first.
+
+Signed-off-by: Mark Hatle 
+---
+ linux-user/elfload.c|  7 +++--
+ linux-user/meson.build  |  1 +
+ linux-user/mmap-fixed.c | 63 +
+ linux-user/mmap-fixed.h | 39 +
+ linux-user/mmap.c   | 31 +++-
+ linux-user/syscall.c|  1 +
+ 6 files changed, 125 insertions(+), 17 deletions(-)
+ create mode 100644 linux-user/mmap-fixed.c
+ create mode 100644 linux-user/mmap-fixed.h
+
+Index: qemu-8.2.0/linux-user/elfload.c
+===
+--- qemu-8.2.0.orig/linux-user/elfload.c
 qemu-8.2.0/linux-user/elfload.c
+@@ -22,6 +22,7 @@
+ #include "qemu/error-report.h"
+ #include "target_signal.h"
+ #include "accel/tcg/debuginfo.h"
++#include "mmap-fixed.h"
+ 
+ #ifdef TARGET_ARM
+ #include "target/arm/cpu-features.h"
+@@ -2765,9 +2766,9 @@ static abi_ulong create_elf_tables(abi_u
+ static int pgb_try_mmap(uintptr_t addr, uintptr_t addr_last, bool keep)
+ {
+ size_t size = addr_last - addr + 1;

[OE-core] [kirkstone][PATCH] image-live.bbclass: LIVE_ROOTFS_TYPE support compression

2024-01-25 Thread Ludovic Jozeau
The task for fstypes with compression is the same as the task for the
uncompressed fstypes, e.g. when adding tar.xz to `IMAGE_FSTYPES`, it will
be included into the do_image_tar task and not creating a separate
do_image_tar.xz task.

This commit fixes `LIVE_ROOTFS_TYPE` with compressed fstypes by
depending on the actual task instead of the non-existent
do_image_. task.

Fixes [YOCTO #15331]

Signed-off-by: Ludovic Jozeau 
Reviewed-by: Yoann Congal 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Richard Purdie 
(cherry picked from commit 67c507e3d42e52a6d452c4a453eeaf7f2e2d68d6)
---
 meta/classes/image-live.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/image-live.bbclass b/meta/classes/image-live.bbclass
index 2c948190cf..c0c1fb31ac 100644
--- a/meta/classes/image-live.bbclass
+++ b/meta/classes/image-live.bbclass
@@ -30,7 +30,7 @@ do_bootimg[depends] += "dosfstools-native:do_populate_sysroot 
\
 virtual/kernel:do_deploy \
 ${MLPREFIX}syslinux:do_populate_sysroot \
 syslinux-native:do_populate_sysroot \
-${@'%s:do_image_%s' % (d.getVar('PN'), 
d.getVar('LIVE_ROOTFS_TYPE').replace('-', '_')) if d.getVar('ROOTFS') else ''} \
+${@'%s:do_image_%s' % (d.getVar('PN'), 
d.getVar('LIVE_ROOTFS_TYPE').replace('-', '_').split('.')[0]) if 
d.getVar('ROOTFS') else ''} \
 "
 
 
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194330): 
https://lists.openembedded.org/g/openembedded-core/message/194330
Mute This Topic: https://lists.openembedded.org/mt/103955899/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] piglit: Update to latest revision

2024-01-25 Thread Fabio Estevam
From: Fabio Estevam 

Update to the latest piglit revision.

Signed-off-by: Fabio Estevam 
---
 meta/recipes-graphics/piglit/piglit_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/piglit/piglit_git.bb 
b/meta/recipes-graphics/piglit/piglit_git.bb
index 69294c6c9468..1bc3b784c77e 100644
--- a/meta/recipes-graphics/piglit/piglit_git.bb
+++ b/meta/recipes-graphics/piglit/piglit_git.bb
@@ -13,7 +13,7 @@ SRC_URI = 
"git://gitlab.freedesktop.org/mesa/piglit.git;protocol=https;branch=ma
"
 UPSTREAM_CHECK_COMMITS = "1"
 
-SRCREV = "71c21b1157c4f9a96453bdfcb9f4dda091360afd"
+SRCREV = "f3f1b3f960611a88cb1a037114ba4724f1bf330e"
 # (when PV goes above 1.0 remove the trailing r)
 PV = "1.0+gitr"
 
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194329): 
https://lists.openembedded.org/g/openembedded-core/message/194329
Mute This Topic: https://lists.openembedded.org/mt/103955076/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] Patchtest results for [PATCH] python3-numpy: Use Large File Support version of fallocate

2024-01-25 Thread Patchtest
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/python3-numpy-Use-Large-File-Support-version-of-fallocate.patch

FAIL: test Signed-off-by presence: A patch file has been added without a 
Signed-off-by tag: 
'0001-BUG-Use-large-file-fallocate-on-32-bit-linux-platfor.patch' 
(test_patch.TestPatch.test_signed_off_by_presence)

PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Upstream-Status presence 
(test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence 
(test_mbox.TestMbox.test_commit_message_presence)
PASS: test lic files chksum modified not mentioned 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194328): 
https://lists.openembedded.org/g/openembedded-core/message/194328
Mute This Topic: https://lists.openembedded.org/mt/103954938/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] python3-numpy: Use Large File Support version of fallocate

2024-01-25 Thread Ola x Nilsson
This was supposed to always be the case from upstream but was exposed
by the 64-bit-time QA checker when file function scanning was enabled.

Signed-off-by: Ola x Nilsson 
---
 ...le-fallocate-on-32-bit-linux-platfor.patch | 49 +++
 .../python/python3-numpy_1.26.2.bb|  1 +
 2 files changed, 50 insertions(+)
 create mode 100644 
meta/recipes-devtools/python/python3-numpy/0001-BUG-Use-large-file-fallocate-on-32-bit-linux-platfor.patch

diff --git 
a/meta/recipes-devtools/python/python3-numpy/0001-BUG-Use-large-file-fallocate-on-32-bit-linux-platfor.patch
 
b/meta/recipes-devtools/python/python3-numpy/0001-BUG-Use-large-file-fallocate-on-32-bit-linux-platfor.patch
new file mode 100644
index 00..6972431192
--- /dev/null
+++ 
b/meta/recipes-devtools/python/python3-numpy/0001-BUG-Use-large-file-fallocate-on-32-bit-linux-platfor.patch
@@ -0,0 +1,49 @@
+From a67561c3c015589e26d156f82de8624533e3e6d7 Mon Sep 17 00:00:00 2001
+From: Ola x Nilsson 
+Date: Fri, 19 Jan 2024 10:26:41 +0100
+Subject: [PATCH] BUG: Use large file fallocate on 32 bit linux platforms
+
+Using a local prototype for fallocate instead of the fcntl.h header
+meant that the redirect triggered by -D_FILE_OFFSET_BITS=64 was not
+triggered.
+
+The prototypes in feature_detection_stdio.h should only be used by
+functions in setup_common.py. If they are used by the feature
+discovery code they might trigger false positives.
+
+Upstream-Status: Backport 
[https://github.com/numpy/numpy/commit/f49c6f9ea735cd7f718e74f8d637ffbbd3a7a03b]
+---
+ numpy/core/feature_detection_stdio.h | 3 +++
+ numpy/core/src/multiarray/convert.c  | 5 +++--
+ 2 files changed, 6 insertions(+), 2 deletions(-)
+
+diff --git a/numpy/core/feature_detection_stdio.h 
b/numpy/core/feature_detection_stdio.h
+index bc14d16..d8bbfbd 100644
+--- a/numpy/core/feature_detection_stdio.h
 b/numpy/core/feature_detection_stdio.h
+@@ -1,6 +1,9 @@
++#define _GNU_SOURCE
+ #include 
+ #include 
+ 
++#if 0 /* Only for setup_common.py, not the C compiler */
+ off_t ftello(FILE *stream);
+ int fseeko(FILE *stream, off_t offset, int whence);
+ int fallocate(int, int, off_t, off_t);
++#endif
+diff --git a/numpy/core/src/multiarray/convert.c 
b/numpy/core/src/multiarray/convert.c
+index 60c1a1b..8ec0aee 100644
+--- a/numpy/core/src/multiarray/convert.c
 b/numpy/core/src/multiarray/convert.c
+@@ -23,8 +23,9 @@
+ #include "array_coercion.h"
+ #include "refcount.h"
+ 
+-int
+-fallocate(int fd, int mode, off_t offset, off_t len);
++#if defined(HAVE_FALLOCATE) && defined(__linux__)
++#include 
++#endif
+ 
+ /*
+  * allocate nbytes of diskspace for file fp
diff --git a/meta/recipes-devtools/python/python3-numpy_1.26.2.bb 
b/meta/recipes-devtools/python/python3-numpy_1.26.2.bb
index 253b334367..b28a6c0305 100644
--- a/meta/recipes-devtools/python/python3-numpy_1.26.2.bb
+++ b/meta/recipes-devtools/python/python3-numpy_1.26.2.bb
@@ -12,6 +12,7 @@ SRC_URI = 
"${GITHUB_BASE_URI}/download/v${PV}/${SRCNAME}-${PV}.tar.gz \
file://0001-numpy-core-Define-RISCV-32-support.patch \
file://fix_reproducibility.patch \
file://run-ptest \
+   
file://0001-BUG-Use-large-file-fallocate-on-32-bit-linux-platfor.patch \
"
 SRC_URI[sha256sum] = 
"f65738447676ab5777f11e6bbbdb8ce11b785e105f690bc45966574816b6d3ea"
 
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194327): 
https://lists.openembedded.org/g/openembedded-core/message/194327
Mute This Topic: https://lists.openembedded.org/mt/103954747/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v4 7/7] rust: Enable rust oe-selftest.

2024-01-25 Thread Shinde, Yash via lists.openembedded.org
From: Yash Shinde 

* Enable rust oe-selftest.

* Include the dependent patches for rust oe-selftest in
  meta/recipes-devtools/rust/rust-source.inc

* Disable rust oe-selftest for mips32 target (Rust upstream has classified it 
into tier 3 target,
  for which the Rust project does not build or test automatically) as it is 
unstable with rust tests.
  https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-3

* The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets on 
Ubuntu 22.04.

Signed-off-by: Yash Shinde 
---
 meta/lib/oeqa/selftest/cases/rust.py   | 7 ++-
 meta/recipes-devtools/rust/rust-source.inc | 4 
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 0d7d524471..164ad11ecd 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -40,7 +40,12 @@ def parse_results(filename):
 class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
 def test_rust(self, *args, **kwargs):
 # Disable Rust Oe-selftest
-self.skipTest("The Rust Oe-selftest is disabled.")
+#self.skipTest("The Rust Oe-selftest is disabled.")
+
+# Skip mips32 target since it is unstable with rust tests
+machine = get_bb_var('MACHINE')
+if machine == "qemumips":
+self.skipTest("The mips32 target is skipped for Rust Oe-selftest.")
 
 # build remote-test-server before image build
 recipe = "rust"
diff --git a/meta/recipes-devtools/rust/rust-source.inc 
b/meta/recipes-devtools/rust/rust-source.inc
index 83a0dbc15f..e02829e6b3 100644
--- a/meta/recipes-devtools/rust/rust-source.inc
+++ b/meta/recipes-devtools/rust/rust-source.inc
@@ -10,6 +10,10 @@ SRC_URI += 
"https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n
 
file://0004-musl-Define-O_LARGEFILE-for-riscv32.patch;patchdir=${RUSTSRC} \
 
file://0005-musl-Define-SOCK_SEQPACKET-in-common-place.patch;patchdir=${RUSTSRC}
 \
 
file://0001-Revert-Map-source-absolute-paths-to-OUT_DIR-as-relat.patch;patchdir=${RUSTSRC}
 \
+file://cargo-path.patch;patchdir=${RUSTSRC} \
+file://custom-target-cfg.patch;patchdir=${RUSTSRC} \
+file://rustc-bootstrap.patch;patchdir=${RUSTSRC} \
+file://target-build-value.patch;patchdir=${RUSTSRC} \
 "
 SRC_URI[rust.sha256sum] = 
"b98c09d968529212fb29eec7d6d3e9bdaa869810679b7fb86a1ca69469d75f5e"
 
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194326): 
https://lists.openembedded.org/g/openembedded-core/message/194326
Mute This Topic: https://lists.openembedded.org/mt/103953377/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v4 4/7] rust: Fix assertion failure error on oe-selftest

2024-01-25 Thread Shinde, Yash via lists.openembedded.org
From: Yash Shinde 

Fixes: thread 'main' panicked at 'assertion failed: `(left == right)`
   left: `x86_64-unknown-linux-gnu`,
   right: `x86_64-poky-linux-gnu`: Cannot obtain compiler for non-native 
build triple at stage 0', compile.rs:1474:13

Add correct target value for cross-compiled targets on stage1 during rust 
oe-selfest.

Signed-off-by: Yash Shinde 
---
 .../rust/files/target-build-value.patch   | 26 +++
 1 file changed, 26 insertions(+)
 create mode 100644 meta/recipes-devtools/rust/files/target-build-value.patch

diff --git a/meta/recipes-devtools/rust/files/target-build-value.patch 
b/meta/recipes-devtools/rust/files/target-build-value.patch
new file mode 100644
index 00..23e8c76801
--- /dev/null
+++ b/meta/recipes-devtools/rust/files/target-build-value.patch
@@ -0,0 +1,26 @@
+Add correct build value for cross-compiled targets on stage1 when
+bootstapping rustc.
+
+Upstream-Status: Backport 
[https://github.com/rust-lang/rust/pull/119619/commits/b888e2f82b9dbe81875f50d13adbc0271a9401ff]
+
+Signed-off-by: onur-ozkan 
+Signed-off-by: Yash Shinde 
+---
+diff --git a/src/bootstrap/test.rs b/src/bootstrap/test.rs
+--- a/src/bootstrap/test.rs
 b/src/bootstrap/test.rs
+@@ -1489,8 +1489,12 @@
+ // NOTE: Only stage 1 is special cased because we need the 
rustc_private artifacts to match the
+ // running compiler in stage 2 when plugins run.
+ let stage_id = if suite == "ui-fulldeps" && compiler.stage == 1 {
+-compiler = builder.compiler(compiler.stage - 1, target);
+-format!("stage{}-{}", compiler.stage + 1, target)
++// At stage 0 (stage - 1) we are using the beta compiler. Using 
`self.target` can lead finding
++// an incorrect compiler path on cross-targets, as the stage 0 
beta compiler is always equal
++// to `build.build` in the configuration.
++let build = builder.build.build;
++compiler = builder.compiler(compiler.stage - 1, build);
++format!("stage{}-{}", compiler.stage + 1, build)
+ } else {
+ format!("stage{}-{}", compiler.stage, target)
+ };
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194323): 
https://lists.openembedded.org/g/openembedded-core/message/194323
Mute This Topic: https://lists.openembedded.org/mt/103953374/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v4 5/7] rust: Add new tests in the exclude list for rust oe-selftest

2024-01-25 Thread Shinde, Yash via lists.openembedded.org
From: Yash Shinde 

Add newly failing tests cases in the exclude list for
rust oe-selftest.

Signed-off-by: Yash Shinde 
---
 meta/lib/oeqa/selftest/cases/rust.py | 38 +++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 6dbc517006..5f0cc73596 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -262,7 +262,43 @@ class RustSelfTestSystemEmulated(OESelftestTestCase, 
OEPTestResultTestCase):
 'tests/ui/process/process-panic-after-fork.rs',
 'tests/ui/process/process-sigpipe.rs',
 'tests/ui/simd/target-feature-mixup.rs',
-'tests/ui/structs-enums/multiple-reprs.rs'
+'tests/ui/structs-enums/multiple-reprs.rs',
+'src/tools/jsondoclint',
+'src/tools/replace-version-placeholder',
+'tests/codegen/abi-efiapi.rs',
+'tests/codegen/abi-sysv64.rs',
+'tests/codegen/align-byval.rs',
+'tests/codegen/align-fn.rs',
+'tests/codegen/asm-powerpc-clobbers.rs',
+'tests/codegen/async-fn-debug-awaitee-field.rs',
+
'tests/codegen/binary-search-index-no-bound-check.rs',
+'tests/codegen/call-metadata.rs',
+'tests/codegen/debug-column.rs',
+'tests/codegen/debug-limited.rs',
+
'tests/codegen/debuginfo-generic-closure-env-names.rs',
+'tests/codegen/drop.rs',
+'tests/codegen/dst-vtable-align-nonzero.rs',
+'tests/codegen/enable-lto-unit-splitting.rs',
+'tests/codegen/enum/enum-u128.rs',
+'tests/codegen/fn-impl-trait-self.rs',
+'tests/codegen/inherit_overflow.rs',
+'tests/codegen/inline-function-args-debug-info.rs',
+'tests/codegen/intrinsics/mask.rs',
+'tests/codegen/intrinsics/transmute-niched.rs',
+'tests/codegen/issues/issue-73258.rs',
+'tests/codegen/issues/issue-75546.rs',
+'tests/codegen/issues/issue-77812.rs',
+
'tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs',
+'tests/codegen/llvm-ident.rs',
+'tests/codegen/mainsubprogram.rs',
+'tests/codegen/move-operands.rs',
+'tests/codegen/repr/transparent-mips64.rs',
+'tests/mir-opt/',
+'tests/rustdoc-json',
+'tests/rustdoc-ui/doc-test-rustdoc-feature.rs',
+'tests/rustdoc-ui/no-run-flag.rs',
+'tests/ui-fulldeps/',
+'tests/ui/numbers-arithmetic/u128.rs'
 ]
 
 exclude_fail_tests = " ".join([" --exclude " + item for item in 
exclude_list])
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194324): 
https://lists.openembedded.org/g/openembedded-core/message/194324
Mute This Topic: https://lists.openembedded.org/mt/103953375/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v4 6/7] rust: Remove the test cases whose parent dir is also present in the exclude list

2024-01-25 Thread Shinde, Yash via lists.openembedded.org
From: Yash Shinde 

To avoid overlap and redundancy of rust tests, remove the test cases whose
parent dir is already excluded.

Tests which are failing from below dirs are removed as these dirs are
already present in exclude list
tests/run-make
tests/rustdoc
tests/mir-opt
tests/ui-fulldeps

Signed-off-by: Yash Shinde 
---
 meta/lib/oeqa/selftest/cases/rust.py | 120 ---
 1 file changed, 120 deletions(-)

diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 5f0cc73596..0d7d524471 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -102,108 +102,10 @@ class RustSelfTestSystemEmulated(OESelftestTestCase, 
OEPTestResultTestCase):
 'tests/codegen/uninit-consts.rs',
 'tests/pretty/raw-str-nonexpr.rs',
 'tests/run-make',
-'tests/run-make/cdylib-fewer-symbols/foo.rs',
-'tests/run-make/doctests-keep-binaries/t.rs',
 'tests/run-make-fulldeps',
-'tests/run-make/issue-22131/foo.rs',
-'tests/run-make/issue-36710/Makefile',
-'tests/run-make/issue-47551',
-'tests/run-make/pgo-branch-weights',
-'tests/run-make/pgo-gen',
-'tests/run-make/pgo-gen-lto',
-'tests/run-make/pgo-indirect-call-promotion',
-'tests/run-make/pgo-use',
-'tests/run-make/pointer-auth-link-with-c/Makefile',
-'tests/run-make/profile',
-'tests/run-make/static-pie',
-'tests/run-make/sysroot-crates-are-unstable',
-'tests/run-make/target-specs',
 'tests/rustdoc',
-'tests/rustdoc/async-move-doctest.rs',
-'tests/rustdoc/async-trait.rs',
-'tests/rustdoc/auto-traits.rs',
-'tests/rustdoc/check-source-code-urls-to-def.rs',
-'tests/rustdoc/comment-in-doctest.rs',
-
'tests/rustdoc/const-generics/const-generics-docs.rs',
-
'tests/rustdoc/cross-crate-hidden-assoc-trait-items.rs',
-
'tests/rustdoc/cross-crate-hidden-impl-parameter.rs',
-'tests/rustdoc/cross-crate-links.rs',
-'tests/rustdoc/cross-crate-primitive-doc.rs',
-'tests/rustdoc/doctest-manual-crate-name.rs',
-'tests/rustdoc/edition-doctest.rs',
-'tests/rustdoc/edition-flag.rs',
-'tests/rustdoc/elided-lifetime.rs',
-'tests/rustdoc/external-macro-src.rs',
-'tests/rustdoc/extern-html-root-url.rs',
-'tests/rustdoc/extern-impl-trait.rs',
-'tests/rustdoc/hide-unstable-trait.rs',
-'tests/rustdoc/inline_cross/add-docs.rs',
-
'tests/rustdoc/inline_cross/default-trait-method.rs',
-'tests/rustdoc/inline_cross/dyn_trait.rs',
-'tests/rustdoc/inline_cross/impl_trait.rs',
-'tests/rustdoc/inline_cross/issue-24183.rs',
-'tests/rustdoc/inline_cross/macros.rs',
-'tests/rustdoc/inline_cross/trait-vis.rs',
-'tests/rustdoc/inline_cross/use_crate.rs',
-'tests/rustdoc/intra-doc-crate/self.rs',
-
'tests/rustdoc/intra-doc/cross-crate/additional_doc.rs',
-'tests/rustdoc/intra-doc/cross-crate/basic.rs',
-'tests/rustdoc/intra-doc/cross-crate/crate.rs',
-'tests/rustdoc/intra-doc/cross-crate/hidden.rs',
-'tests/rustdoc/intra-doc/cross-crate/macro.rs',
-'tests/rustdoc/intra-doc/cross-crate/module.rs',
-
'tests/rustdoc/intra-doc/cross-crate/submodule-inner.rs',
-
'tests/rustdoc/intra-doc/cross-crate/submodule-outer.rs',
-'tests/rustdoc/intra-doc/cross-crate/traits.rs',
-
'tests/rustdoc/intra-doc/extern-builtin-type-impl.rs',
-
'tests/rustdoc/intra-doc/extern-crate-only-used-in-link.rs',
-'tests/rustdoc/intra-doc/extern-crate.rs',
-'tests/rust

[OE-core] [PATCH v4 3/7] rust: Enable RUSTC_BOOTSTRAP to use nightly features during rust oe-selftest.

2024-01-25 Thread Shinde, Yash via lists.openembedded.org
From: Yash Shinde 

Fixes: error: the option `Z` is only accepted on the nightly compiler

When rust.channel is set to either beta or stable, we can't use
nightly features on bootstrap without RUSTC_BOOTSTRAP.
Set RUSTC_BOOTSTRAP=1 to use nightly features on stable or beta.

Signed-off-by: Yash Shinde 
---
 .../rust/files/rustc-bootstrap.patch  | 21 +++
 1 file changed, 21 insertions(+)
 create mode 100644 meta/recipes-devtools/rust/files/rustc-bootstrap.patch

diff --git a/meta/recipes-devtools/rust/files/rustc-bootstrap.patch 
b/meta/recipes-devtools/rust/files/rustc-bootstrap.patch
new file mode 100644
index 00..406fc610bb
--- /dev/null
+++ b/meta/recipes-devtools/rust/files/rustc-bootstrap.patch
@@ -0,0 +1,21 @@
+When rust.channel is set to either beta or stable, we can't use
+nightly features on bootstrap without RUSTC_BOOTSTRAP. Set RUSTC_BOOTSTRAP=1
+to use nightly features on stable or beta.
+
+Upstream-Status: Backport 
[https://github.com/rust-lang/rust/pull/119619/commits/8aa7dd06f6e50621dc10f9f9490681be8a45876f]
+
+Signed-off-by: onur-ozkan 
+Signed-off-by: Yash Shinde 
+---
+diff --git a/src/bootstrap/synthetic_targets.rs b/ 
src/bootstrap/synthetic_targets.rs
+index d2c65b740da..45baf56f46b 100644
+--- a/src/bootstrap/synthetic_targets.rs
 b/src/bootstrap/synthetic_targets.rs
+@@ -59,6 +59,7 @@ fn create_synthetic_target(
+ let mut cmd = Command::new(builder.rustc(compiler));
+ cmd.arg("--target").arg(base.rustc_target_arg());
+ cmd.args(["-Zunstable-options", "--print", "target-spec-json"]);
++cmd.env("RUSTC_BOOTSTRAP", "1");
+ cmd.stdout(Stdio::piped());
+
+ let output = cmd.spawn().unwrap().wait_with_output().unwrap();
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194322): 
https://lists.openembedded.org/g/openembedded-core/message/194322
Mute This Topic: https://lists.openembedded.org/mt/103953373/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v4 2/7] rust: detect user-specified custom targets in compiletest

2024-01-25 Thread Shinde, Yash via lists.openembedded.org
From: Yash Shinde 

Fixes: thread 'main' panicked at 'failed to gather the target spec
   for '-unknown-linux-gnu', synthetic_targets.rs:66:9

Detect and fetch custom target configurations when rustc is
bootstrapped in rust oe-selftest.

Signed-off-by: Yash Shinde 
---
 .../rust/files/custom-target-cfg.patch| 90 +++
 1 file changed, 90 insertions(+)
 create mode 100644 meta/recipes-devtools/rust/files/custom-target-cfg.patch

diff --git a/meta/recipes-devtools/rust/files/custom-target-cfg.patch 
b/meta/recipes-devtools/rust/files/custom-target-cfg.patch
new file mode 100644
index 00..15a7f252cc
--- /dev/null
+++ b/meta/recipes-devtools/rust/files/custom-target-cfg.patch
@@ -0,0 +1,90 @@
+Detect and fetch custom target configurations when rustc is
+bootstrapped in rust oe-selftest.
+
+Upstream-Status: Backport 
[https://github.com/rust-lang/rust/pull/119619/commits/26c71cbcf1a9bce6ceb962d753c467d098f63cf6]
+
+Signed-off-by: onur-ozkan 
+Signed-off-by: Yash Shinde 
+---
+diff --git a/src/tools/compiletest/src/common.rs 
b/src/tools/compiletest/src/common.rs
+index e85f6319936..c45c0b3c652 100644
+--- a/src/tools/compiletest/src/common.rs
 b/src/tools/compiletest/src/common.rs
+@@ -479,6 +479,7 @@ fn new(config: &Config) -> TargetCfgs {
+ let mut targets: HashMap = 
serde_json::from_str(&rustc_output(
+ config,
+ &["--print=all-target-specs-json", "-Zunstable-options"],
++Default::default(),
+ ))
+ .unwrap();
+
+@@ -491,16 +492,33 @@ fn new(config: &Config) -> TargetCfgs {
+ let mut all_families = HashSet::new();
+ let mut all_pointer_widths = HashSet::new();
+
+-// Handle custom target specs, which are not included in 
`--print=all-target-specs-json`.
+-if config.target.ends_with(".json") {
+-targets.insert(
+-config.target.clone(),
+-serde_json::from_str(&rustc_output(
+-config,
+-&["--print=target-spec-json", "-Zunstable-options", 
"--target", &config.target],
+-))
+-.unwrap(),
+-);
++// If current target is not included in the 
`--print=all-target-specs-json` output,
++// we check whether it is a custom target from the user or a 
synthetic target from bootstrap.
++if !targets.contains_key(&config.target) {
++let mut envs: HashMap = HashMap::new();
++
++if let Ok(t) = std::env::var("RUST_TARGET_PATH") {
++envs.insert("RUST_TARGET_PATH".into(), t);
++}
++
++// This returns false only when the target is neither a synthetic 
target
++// nor a custom target from the user, indicating it is most 
likely invalid.
++if config.target.ends_with(".json") || !envs.is_empty() {
++targets.insert(
++config.target.clone(),
++serde_json::from_str(&rustc_output(
++config,
++&[
++"--print=target-spec-json",
++"-Zunstable-options",
++"--target",
++&config.target,
++],
++envs,
++))
++.unwrap(),
++);
++}
+ }
+
+ for (target, cfg) in targets.iter() {
+@@ -545,7 +563,9 @@ fn get_current_target_config(
+ // code below extracts them from `--print=cfg`: make sure to only 
override fields that can
+ // actually be changed with `-C` flags.
+ for config in
+-rustc_output(config, &["--print=cfg", "--target", 
&config.target]).trim().lines()
++rustc_output(config, &["--print=cfg", "--target", 
&config.target], Default::default())
++.trim()
++.lines()
+ {
+ let (name, value) = config
+ .split_once("=\"")
+@@ -624,11 +644,12 @@ pub enum Endian {
+ Big,
+ }
+
+-fn rustc_output(config: &Config, args: &[&str]) -> String {
++fn rustc_output(config: &Config, args: &[&str], envs: HashMap) -> String {
+ let mut command = Command::new(&config.rustc_path);
+ add_dylib_path(&mut command, iter::once(&config.compile_lib_path));
+ command.args(&config.target_rustcflags).args(args);
+ command.env("RUSTC_BOOTSTRAP", "1");
++command.envs(envs);
+
+ let output = match command.output() {
+ Ok(output) => output,
+
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194321): 
https://lists.openembedded.org/g/openembedded-core/message/194321
Mute This Topic: https://lists.openembedded.org/mt/103953372/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail

[OE-core] [PATCH v4 1/7] rust: Fetch cargo from rust-snapshot dir.

2024-01-25 Thread Shinde, Yash via lists.openembedded.org
From: Yash Shinde 

Fixes: Exception: no cargo executable found at
   `${B}/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`

Fix the cargo binary path error on oe-selftest and path set to rust-snapshot 
dir.

Patch sent to upstream- https://github.com/rust-lang/rust/pull/120125

Signed-off-by: Yash Shinde 
---
 .../rust/files/cargo-path.patch   | 37 +++
 1 file changed, 37 insertions(+)
 create mode 100644 meta/recipes-devtools/rust/files/cargo-path.patch

diff --git a/meta/recipes-devtools/rust/files/cargo-path.patch 
b/meta/recipes-devtools/rust/files/cargo-path.patch
new file mode 100644
index 00..84bd580aa7
--- /dev/null
+++ b/meta/recipes-devtools/rust/files/cargo-path.patch
@@ -0,0 +1,37 @@
+Fix the cargo binary path error and ensure that it is fetched
+during rustc bootstrap in rust oe-selftest.
+
+==
+ERROR: test_cargoflags (bootstrap_test.BuildBootstrap)
+--
+Traceback (most recent call last):
+  File 
"/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py",
 line 157, in test_cargoflags
+args, _ = self.build_args(env={"CARGOFLAGS": "--timings"})
+  File 
"/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py",
 line 154, in build_args
+return build.build_bootstrap_cmd(env), env
+  File 
"/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap.py",
 line 960, in build_bootstrap_cmd
+raise Exception("no cargo executable found at `{}`".format(
+Exception: no cargo executable found at 
`/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
+
+Upstream-Status: Submitted [https://github.com/rust-lang/rust/pull/120125]
+
+Signed-off-by: Yash Shinde 
+---
+diff --git a/src/bootstrap/bootstrap.py b/src/bootstrap/bootstrap.py
+--- a/src/bootstrap/bootstrap.py
 b/src/bootstrap/bootstrap.py
+@@ -954,9 +954,11 @@
+ if deny_warnings:
+ env["RUSTFLAGS"] += " -Dwarnings"
+
+-env["PATH"] = os.path.join(self.bin_root(), "bin") + \
+-os.pathsep + env["PATH"]
+-if not os.path.isfile(self.cargo()):
++cargo_bin_path = os.path.join(self.bin_root(), "bin", "cargo")
++if not os.path.isfile(cargo_bin_path):
++cargo_bin_path = os.getenv("RUST_TARGET_PATH") + 
"rust-snapshot/bin/cargo"
++env["PATH"] = os.path.dirname(cargo_bin_path) + os.pathsep + 
env["PATH"]
++else:
+ raise Exception("no cargo executable found at `{}`".format(
+ self.cargo()))
+ args = [self.cargo(), "build", "--manifest-path",
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194320): 
https://lists.openembedded.org/g/openembedded-core/message/194320
Mute This Topic: https://lists.openembedded.org/mt/103953371/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] tutorial-level questions to clean up recipes for demo purposes

2024-01-25 Thread Etienne Cordonnier via lists.openembedded.org
In this particular case the line should be removed IMO.

On Thu, Jan 25, 2024 at 2:04 PM Etienne Cordonnier via
lists.openembedded.org  wrote:

> Hi Robert,
> for this kind of things I usually run bitbake -e dropbear >
> out-before.txt, remove the line, then run bitbake -e dropbear >
> out-after.txt, and finally vimdiff out-before.txt out-after.txt
>
> Etienne
>
> On Thu, Jan 25, 2024 at 12:22 PM Robert P. J. Day 
> wrote:
>
>>
>>   (NOTE: i'm currently tutoring some colleagues in the basics of OE
>> and using standard OE recipes as examples of good programming
>> practice, so occasionally i run across something that looks strange
>> and i just want to clarify so i don't have to say, "i don't know, i
>> guess there's a reason for that, i just don't know what it is." so,
>> first question that has arisen ...)
>>
>>   in current dropbear recipe, very last line:
>>
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__git.openembedded.org_openembedded-2Dcore_tree_meta_recipes-2Dcore_dropbear_dropbear-5F2022.83.bb-23n134&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=W9n61A0zDvN6Tj5VtV34qyc-BOCTDVwKaiOFK5rQRDBz5hCnNdgxjqE-W6fBEXyw&s=WplZmxLv9Ks1Z_nFQ7ut5gDiJmOB4sSHSneLPg015Z0&e=
>>
>> the line:
>>
>>   FILES:${PN} += "${bindir}"
>>
>> but as i read bitbake.conf, ${bindir} is *already* part of FILES:${PN}
>> and i see nothing in the rest of the dropbear recipe that redefines
>> the PACKAGES or reorders them. is there some point to that last line
>> that i am simply missing? it seems unnecessary.
>>
>> rday
>>
>>
>>
>>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194319): 
https://lists.openembedded.org/g/openembedded-core/message/194319
Mute This Topic: https://lists.openembedded.org/mt/103951915/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] tutorial-level questions to clean up recipes for demo purposes

2024-01-25 Thread Etienne Cordonnier via lists.openembedded.org
Hi Robert,
for this kind of things I usually run bitbake -e dropbear > out-before.txt,
remove the line, then run bitbake -e dropbear > out-after.txt, and finally
vimdiff out-before.txt out-after.txt

Etienne

On Thu, Jan 25, 2024 at 12:22 PM Robert P. J. Day 
wrote:

>
>   (NOTE: i'm currently tutoring some colleagues in the basics of OE
> and using standard OE recipes as examples of good programming
> practice, so occasionally i run across something that looks strange
> and i just want to clarify so i don't have to say, "i don't know, i
> guess there's a reason for that, i just don't know what it is." so,
> first question that has arisen ...)
>
>   in current dropbear recipe, very last line:
>
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__git.openembedded.org_openembedded-2Dcore_tree_meta_recipes-2Dcore_dropbear_dropbear-5F2022.83.bb-23n134&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=W9n61A0zDvN6Tj5VtV34qyc-BOCTDVwKaiOFK5rQRDBz5hCnNdgxjqE-W6fBEXyw&s=WplZmxLv9Ks1Z_nFQ7ut5gDiJmOB4sSHSneLPg015Z0&e=
>
> the line:
>
>   FILES:${PN} += "${bindir}"
>
> but as i read bitbake.conf, ${bindir} is *already* part of FILES:${PN}
> and i see nothing in the rest of the dropbear recipe that redefines
> the PACKAGES or reorders them. is there some point to that last line
> that i am simply missing? it seems unnecessary.
>
> rday
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194318): 
https://lists.openembedded.org/g/openembedded-core/message/194318
Mute This Topic: https://lists.openembedded.org/mt/103951915/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] Patchtest results for [PATCH v2 8/9] oeqa/selftest/recipetool: Move helper function to the class scope

2024-01-25 Thread Vyacheslav Yurkov

I don't think so.

git pw series list --submitter "Vyacheslav Yurkov"

Shows the latest series 21353 from me.

Regards,
Slava

On 22.01.2024 16:35, Lukas Funke wrote:
Is this the reason why I cannot find the series on patchwork? This 
makes it kinda tricky to review/test IMHO.


Please provide a commit message, so patchtest is happy.

On 16.01.2024 09:45, Patchtest via lists.openembedded.org wrote:

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/v2-8-9-oeqa-selftest-recipetool-Move-helper-function-to-the-class-scope.patch


FAIL: test commit message presence: Please include a commit message 
on your patch explaining the change 
(test_mbox.TestMbox.test_commit_message_presence)


PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)

PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test max line length 
(test_metadata.TestMetadata.test_max_line_length)

PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list 
(test_mbox.TestMbox.test_target_mailing_list)


SKIP: pretest src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes, skipping test 
(test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced 
(test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced 
(test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced 
(test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified 
recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)


---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194317): 
https://lists.openembedded.org/g/openembedded-core/message/194317
Mute This Topic: https://lists.openembedded.org/mt/103758513/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] tutorial-level questions to clean up recipes for demo purposes

2024-01-25 Thread Robert P. J. Day

  (NOTE: i'm currently tutoring some colleagues in the basics of OE
and using standard OE recipes as examples of good programming
practice, so occasionally i run across something that looks strange
and i just want to clarify so i don't have to say, "i don't know, i
guess there's a reason for that, i just don't know what it is." so,
first question that has arisen ...)

  in current dropbear recipe, very last line:

https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/dropbear/dropbear_2022.83.bb#n134

the line:

  FILES:${PN} += "${bindir}"

but as i read bitbake.conf, ${bindir} is *already* part of FILES:${PN}
and i see nothing in the rest of the dropbear recipe that redefines
the PACKAGES or reorders them. is there some point to that last line
that i am simply missing? it seems unnecessary.

rday

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194316): 
https://lists.openembedded.org/g/openembedded-core/message/194316
Mute This Topic: https://lists.openembedded.org/mt/103951915/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 3/3] blktool: Make the version consistent

2024-01-25 Thread Alexander Kanavin
Doesn't this also break PV monotonically increasing?

Alex

On Thu, 25 Jan 2024 at 10:26, Yu, Mingli  wrote:
>
> From: Mingli Yu 
>
> Update the version to make package version consistent and there is
> indeed the source as blktool_4.orig.tar.gz [1].
> Before the patch:
>   # rpm -qa | grep blktool
>   blktool-4+7.1-r0.core2_64
>   # blktool
>   blktool version 4
>   usage: blktool [options] DEVICE COMMAND [args...]
>   command list:
>   ATA defect-mgmt { off | on }
>   ATA dev-keep-settings { off | on }
>   any dev-read-ahead { off | on }
>   [snip]
> After the patch:
>   # rpm -qa | grep blktool
>   blktool-4-r0.core2_64
>   # blktool
>   blktool version 4
>   usage: blktool [options] DEVICE COMMAND [args...]
>   command list:
>   ATA defect-mgmt { off | on }
>   ATA dev-keep-settings { off | on }
>   any dev-read-ahead { off | on }
>   [snip]
>
> [1] 
> http://snapshot.debian.org/archive/debian/20160728T043443Z/pool/main/b/blktool/
>
> Signed-off-by: Mingli Yu 
> ---
>  meta/recipes-extended/blktool/{blktool_4-7.1.bb => blktool_4.bb} | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename meta/recipes-extended/blktool/{blktool_4-7.1.bb => blktool_4.bb} 
> (100%)
>
> diff --git a/meta/recipes-extended/blktool/blktool_4-7.1.bb 
> b/meta/recipes-extended/blktool/blktool_4.bb
> similarity index 100%
> rename from meta/recipes-extended/blktool/blktool_4-7.1.bb
> rename to meta/recipes-extended/blktool/blktool_4.bb
> --
> 2.25.1
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194315): 
https://lists.openembedded.org/g/openembedded-core/message/194315
Mute This Topic: https://lists.openembedded.org/mt/103950929/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 2/3] icu: Make the version consistent

2024-01-25 Thread Alexander Kanavin
This breaks upstream version check and automated updates, I can't accept that:

$ devtool latest-version icu
INFO: Current version: 74.1
INFO: Latest version: 74-2

It also breaks PV monotonically increasing.

Alex

On Thu, 25 Jan 2024 at 10:26, Yu, Mingli  wrote:
>
> From: Mingli Yu 
>
> Update the version in the bb name to make the version consistent.
> Before the patch:
>  # rpm -qa | grep icu
>  icu-74+1-r0.core2_64
>  # rpm -ql icu
>  /usr
>  /usr/bin
>  /usr/bin/derb
>  [snip]
>  # derb --version
>  derb version 1.1 (ICU version 74.1).
>   Copyright (C) 2016 and later: Unicode, Inc. and others. License & terms of 
> use: http://www.unicode.org/copyright.html
>
> After the patch:
>  # rpm -qa | grep icu
>  icu-74.1-r0.core2_64
>  # rpm -ql icu
>  /usr
>  /usr/bin
>  /usr/bin/derb
>  [snip]
>  # derb --version
>  derb version 1.1 (ICU version 74.1).
>   Copyright (C) 2016 and later: Unicode, Inc. and others. License & terms of 
> use: http://www.unicode.org/copyright.html
>
> Signed-off-by: Mingli Yu 
> ---
>  meta/recipes-support/icu/{icu_74-1.bb => icu_74.1.bb} | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>  rename meta/recipes-support/icu/{icu_74-1.bb => icu_74.1.bb} (96%)
>
> diff --git a/meta/recipes-support/icu/icu_74-1.bb 
> b/meta/recipes-support/icu/icu_74.1.bb
> similarity index 96%
> rename from meta/recipes-support/icu/icu_74-1.bb
> rename to meta/recipes-support/icu/icu_74.1.bb
> index 88ded166b5..196b3dc579 100644
> --- a/meta/recipes-support/icu/icu_74-1.bb
> +++ b/meta/recipes-support/icu/icu_74.1.bb
> @@ -14,7 +14,7 @@ S = "${WORKDIR}/icu/source"
>  SPDX_S = "${WORKDIR}/icu"
>  STAGING_ICU_DIR_NATIVE = "${STAGING_DATADIR_NATIVE}/${BPN}/${PV}"
>
> -ICU_MAJOR_VER = "${@d.getVar('PV').split('-')[0]}"
> +ICU_MAJOR_VER = "${@d.getVar('PV').split('.')[0]}"
>
>  inherit autotools pkgconfig github-releases
>
> @@ -81,15 +81,15 @@ BBCLASSEXTEND = "native nativesdk"
>  LIC_FILES_CHKSUM = "file://../LICENSE;md5=08dc3852df8fffa807301902ad899ff8"
>
>  def icu_download_version(d):
> -pvsplit = d.getVar('PV').split('-')
> +pvsplit = d.getVar('PV').split('.')
>  return pvsplit[0] + "_" + pvsplit[1]
>
>  def icu_download_folder(d):
> -pvsplit = d.getVar('PV').split('-')
> +pvsplit = d.getVar('PV').split('.')
>  return pvsplit[0] + "-" + pvsplit[1]
>
>  def icu_install_folder(d):
> -pvsplit = d.getVar('PV').split('-')
> +pvsplit = d.getVar('PV').split('.')
>  return pvsplit[0] + "." + pvsplit[1]
>
>  ICU_PV = "${@icu_download_version(d)}"
> --
> 2.25.1
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194314): 
https://lists.openembedded.org/g/openembedded-core/message/194314
Mute This Topic: https://lists.openembedded.org/mt/103950928/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/3] pkgconfig: Correct the PV

2024-01-25 Thread Alexander Kanavin
On Thu, 25 Jan 2024 at 10:25, Yu, Mingli  wrote:
>
> From: Mingli Yu 
>
> Correct the PV to make the version consistent.
>  SRCREV = "d97db4fae4c1cd099b506970b285dc2afd818ea2"
> -PV = "0.29.2+git"
> +PV = "0.29.2"

0.29.2 release tag maps to a different commit, so we cannot drop +git:
https://gitlab.freedesktop.org/pkg-config/pkg-config/-/tags/pkg-config-0.29.2

It helps if you explain the broader goal. Why does version as reported
by rpm need to match version as reported by component exactly? Can't
you strip all the suffixes from what rpm says?

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194313): 
https://lists.openembedded.org/g/openembedded-core/message/194313
Mute This Topic: https://lists.openembedded.org/mt/103950927/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 3/3] blktool: Make the version consistent

2024-01-25 Thread Yu, Mingli
From: Mingli Yu 

Update the version to make package version consistent and there is
indeed the source as blktool_4.orig.tar.gz [1].
Before the patch:
  # rpm -qa | grep blktool
  blktool-4+7.1-r0.core2_64
  # blktool
  blktool version 4
  usage: blktool [options] DEVICE COMMAND [args...]
  command list:
  ATA defect-mgmt { off | on }
  ATA dev-keep-settings { off | on }
  any dev-read-ahead { off | on }
  [snip]
After the patch:
  # rpm -qa | grep blktool
  blktool-4-r0.core2_64
  # blktool
  blktool version 4
  usage: blktool [options] DEVICE COMMAND [args...]
  command list:
  ATA defect-mgmt { off | on }
  ATA dev-keep-settings { off | on }
  any dev-read-ahead { off | on }
  [snip]

[1] 
http://snapshot.debian.org/archive/debian/20160728T043443Z/pool/main/b/blktool/

Signed-off-by: Mingli Yu 
---
 meta/recipes-extended/blktool/{blktool_4-7.1.bb => blktool_4.bb} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename meta/recipes-extended/blktool/{blktool_4-7.1.bb => blktool_4.bb} (100%)

diff --git a/meta/recipes-extended/blktool/blktool_4-7.1.bb 
b/meta/recipes-extended/blktool/blktool_4.bb
similarity index 100%
rename from meta/recipes-extended/blktool/blktool_4-7.1.bb
rename to meta/recipes-extended/blktool/blktool_4.bb
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194312): 
https://lists.openembedded.org/g/openembedded-core/message/194312
Mute This Topic: https://lists.openembedded.org/mt/103950929/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/3] pkgconfig: Correct the PV

2024-01-25 Thread Yu, Mingli
From: Mingli Yu 

Correct the PV to make the version consistent.

Before the patch:
 # rpm -qa | grep pkgconfig
 pkgconfig-0.29.2+git0+d97db4fae4-r0.core2_64
 # rpm -ql pkgconfig
 /usr
 /usr/bin
 /usr/bin/pkg-config
 /usr/bin/x86_64-wrs-linux-gnu-pkg-config
 /usr/share
 /usr/share/aclocal
 /usr/share/aclocal/pkg.m4
 # pkg-config --version
 0.29.2

After the patch:
 # rpm -qa | grep pkgconfig
 pkgconfig-0.29.2-r0.core2_64
 # rpm -ql pkgconfig
 /usr
 /usr/bin
 /usr/bin/pkg-config
 /usr/bin/x86_64-wrs-linux-gnu-pkg-config
 /usr/share
 /usr/share/aclocal
 /usr/share/aclocal/pkg.m4
 # pkg-config --version
 0.29.2

Signed-off-by: Mingli Yu 
---
 meta/recipes-devtools/pkgconfig/pkgconfig_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb 
b/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb
index 16e6c5b609..53d2335317 100644
--- a/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb
+++ b/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb
@@ -9,7 +9,7 @@ LICENSE = "GPL-2.0-or-later"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SRCREV = "d97db4fae4c1cd099b506970b285dc2afd818ea2"
-PV = "0.29.2+git"
+PV = "0.29.2"
 
 SRC_URI = 
"git://gitlab.freedesktop.org/pkg-config/pkg-config.git;branch=master;protocol=https
 \
file://pkg-config-esdk.in \
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194310): 
https://lists.openembedded.org/g/openembedded-core/message/194310
Mute This Topic: https://lists.openembedded.org/mt/103950927/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 2/3] icu: Make the version consistent

2024-01-25 Thread Yu, Mingli
From: Mingli Yu 

Update the version in the bb name to make the version consistent.
Before the patch:
 # rpm -qa | grep icu
 icu-74+1-r0.core2_64
 # rpm -ql icu
 /usr
 /usr/bin
 /usr/bin/derb
 [snip]
 # derb --version
 derb version 1.1 (ICU version 74.1).
  Copyright (C) 2016 and later: Unicode, Inc. and others. License & terms of 
use: http://www.unicode.org/copyright.html

After the patch:
 # rpm -qa | grep icu
 icu-74.1-r0.core2_64
 # rpm -ql icu
 /usr
 /usr/bin
 /usr/bin/derb
 [snip]
 # derb --version
 derb version 1.1 (ICU version 74.1).
  Copyright (C) 2016 and later: Unicode, Inc. and others. License & terms of 
use: http://www.unicode.org/copyright.html

Signed-off-by: Mingli Yu 
---
 meta/recipes-support/icu/{icu_74-1.bb => icu_74.1.bb} | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
 rename meta/recipes-support/icu/{icu_74-1.bb => icu_74.1.bb} (96%)

diff --git a/meta/recipes-support/icu/icu_74-1.bb 
b/meta/recipes-support/icu/icu_74.1.bb
similarity index 96%
rename from meta/recipes-support/icu/icu_74-1.bb
rename to meta/recipes-support/icu/icu_74.1.bb
index 88ded166b5..196b3dc579 100644
--- a/meta/recipes-support/icu/icu_74-1.bb
+++ b/meta/recipes-support/icu/icu_74.1.bb
@@ -14,7 +14,7 @@ S = "${WORKDIR}/icu/source"
 SPDX_S = "${WORKDIR}/icu"
 STAGING_ICU_DIR_NATIVE = "${STAGING_DATADIR_NATIVE}/${BPN}/${PV}"
 
-ICU_MAJOR_VER = "${@d.getVar('PV').split('-')[0]}"
+ICU_MAJOR_VER = "${@d.getVar('PV').split('.')[0]}"
 
 inherit autotools pkgconfig github-releases
 
@@ -81,15 +81,15 @@ BBCLASSEXTEND = "native nativesdk"
 LIC_FILES_CHKSUM = "file://../LICENSE;md5=08dc3852df8fffa807301902ad899ff8"
 
 def icu_download_version(d):
-pvsplit = d.getVar('PV').split('-')
+pvsplit = d.getVar('PV').split('.')
 return pvsplit[0] + "_" + pvsplit[1]
 
 def icu_download_folder(d):
-pvsplit = d.getVar('PV').split('-')
+pvsplit = d.getVar('PV').split('.')
 return pvsplit[0] + "-" + pvsplit[1]
 
 def icu_install_folder(d):
-pvsplit = d.getVar('PV').split('-')
+pvsplit = d.getVar('PV').split('.')
 return pvsplit[0] + "." + pvsplit[1]
 
 ICU_PV = "${@icu_download_version(d)}"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194311): 
https://lists.openembedded.org/g/openembedded-core/message/194311
Mute This Topic: https://lists.openembedded.org/mt/103950928/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] xz: Add ptest support

2024-01-25 Thread Alexander Kanavin
On Thu, 25 Jan 2024 at 03:55, Xu, Chi  wrote:
> > I still don't understand this part. If these scripts are executed as a part 
> > of
> > standard in-tree unit testing, what prints PASS/FAIL in that context? 
> > Shouldn't
> > we reuse that, to replicate the in-tree testing sequence as much as 
> > possible?
> >
>
> According to the description on section 4.2 in 'INSTALL' file of xz,
> "The shell script tests can be copied from the source directory to the target 
> machine to execute."
> So I copy them to target and execute them in ptest.
> They don't have out put like "PASS/FAIL", just return zero or non-zero, so in 
> run-ptest, I print
> "PASS" or "FAIL" according to the return value.

Thanks, I confirmed from the source code that binaries print PASS/FAIL
directly. Shell scripts only indicate the test outcome with a return
code. Then Makefile (produced with autotools macros) prints PASS/FAIL
for all of them.

So run-ptest is fine, nothing needs to be changed.

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194309): 
https://lists.openembedded.org/g/openembedded-core/message/194309
Mute This Topic: https://lists.openembedded.org/mt/103905858/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-