[OE-core] [PATCH] maintainers.inc: update self e-mail address
From: Michael Opdenacker Signed-off-by: Michael Opdenacker --- meta/conf/distro/include/maintainers.inc | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc index 5028a507eb..89a02dd8bd 100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -31,13 +31,13 @@ RECIPE_MAINTAINER:pn-acl = "Chen Qi " RECIPE_MAINTAINER:pn-acpica = "Ross Burton " RECIPE_MAINTAINER:pn-acpid = "Ross Burton " RECIPE_MAINTAINER:pn-adwaita-icon-theme = "Ross Burton " -RECIPE_MAINTAINER:pn-alsa-lib = "Michael Opdenacker " -RECIPE_MAINTAINER:pn-alsa-plugins = "Michael Opdenacker " -RECIPE_MAINTAINER:pn-alsa-state = "Michael Opdenacker " -RECIPE_MAINTAINER:pn-alsa-tools = "Michael Opdenacker " -RECIPE_MAINTAINER:pn-alsa-topology-conf = "Michael Opdenacker " -RECIPE_MAINTAINER:pn-alsa-ucm-conf = "Michael Opdenacker " -RECIPE_MAINTAINER:pn-alsa-utils = "Michael Opdenacker " +RECIPE_MAINTAINER:pn-alsa-lib = "Michael Opdenacker " +RECIPE_MAINTAINER:pn-alsa-plugins = "Michael Opdenacker " +RECIPE_MAINTAINER:pn-alsa-state = "Michael Opdenacker " +RECIPE_MAINTAINER:pn-alsa-tools = "Michael Opdenacker " +RECIPE_MAINTAINER:pn-alsa-topology-conf = "Michael Opdenacker " +RECIPE_MAINTAINER:pn-alsa-ucm-conf = "Michael Opdenacker " +RECIPE_MAINTAINER:pn-alsa-utils = "Michael Opdenacker " RECIPE_MAINTAINER:pn-appstream = "Markus Volk " RECIPE_MAINTAINER:pn-apr = "Hongxu Jia " RECIPE_MAINTAINER:pn-apr-util = "Hongxu Jia " @@ -174,7 +174,7 @@ RECIPE_MAINTAINER:pn-expect = "Alexander Kanavin " RECIPE_MAINTAINER:pn-ffmpeg = "Alexander Kanavin " RECIPE_MAINTAINER:pn-file = "Yi Zhao " RECIPE_MAINTAINER:pn-findutils = "Chen Qi " -RECIPE_MAINTAINER:pn-flac = "Michael Opdenacker " +RECIPE_MAINTAINER:pn-flac = "Michael Opdenacker " RECIPE_MAINTAINER:pn-flex = "Chen Qi " RECIPE_MAINTAINER:pn-font-alias = "Unassigned " RECIPE_MAINTAINER:pn-font-util = "Unassigned " @@ -302,7 +302,7 @@ RECIPE_MAINTAINER:pn-keymaps = "Alexander Kanavin " RECIPE_MAINTAINER:pn-kmod = "Chen Qi " RECIPE_MAINTAINER:pn-kmscube = "Carlos Rafael Giani " RECIPE_MAINTAINER:pn-l3afpad = "Anuj Mittal " -RECIPE_MAINTAINER:pn-lame = "Michael Opdenacker " +RECIPE_MAINTAINER:pn-lame = "Michael Opdenacker " RECIPE_MAINTAINER:pn-ldconfig-native = "Khem Raj " RECIPE_MAINTAINER:pn-less = "Yi Zhao " RECIPE_MAINTAINER:pn-libacpi = "Anuj Mittal " @@ -774,8 +774,8 @@ RECIPE_MAINTAINER:pn-shutdown-desktop = "Alexander Kanavin -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#200405): https://lists.openembedded.org/g/openembedded-core/message/200405 Mute This Topic: https://lists.openembedded.org/mt/106523907/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH RESEND] oeqa/selftest/prservice: support non integer PR values
From: Michael Opdenacker Support non integer x.y.z PR values, for when the PR server supports upstream PR servers. Signed-off-by: Michael Opdenacker --- Note that regular integer PR values are still supported. This code has also been tested on master (as of Apr. 29, 2024), without the proposed PR server changes. --- meta/classes/primport.bbclass | 2 +- meta/lib/oe/prservice.py | 17 - meta/lib/oeqa/selftest/cases/prservice.py | 9 +++-- 3 files changed, 20 insertions(+), 8 deletions(-) diff --git a/meta/classes/primport.bbclass b/meta/classes/primport.bbclass index 00924174c1..1ff09c8785 100644 --- a/meta/classes/primport.bbclass +++ b/meta/classes/primport.bbclass @@ -17,7 +17,7 @@ python primport_handler () { bb.fatal("import failed!") for (version, pkgarch, checksum, value) in imported: -bb.note("imported (%s,%s,%s,%d)" % (version, pkgarch, checksum, value)) +bb.note("imported (%s,%s,%s,%s)" % (version, pkgarch, checksum, value)) elif isinstance(e, bb.event.ParseStarted): import oe.prservice oe.prservice.prserv_check_avail(e.data) diff --git a/meta/lib/oe/prservice.py b/meta/lib/oe/prservice.py index c41242c878..d7920fc511 100644 --- a/meta/lib/oe/prservice.py +++ b/meta/lib/oe/prservice.py @@ -4,6 +4,12 @@ # SPDX-License-Identifier: GPL-2.0-only # +import re + +def is_legal_prvalue(str): +pattern = r'^[0-9]+([.][0-9]+)*$' +return bool(re.match(pattern, str)) + def prserv_make_conn(d, check = False): import prserv.serv host_params = list([_f for _f in (d.getVar("PRSERV_HOST") or '').split(':') if _f]) @@ -59,14 +65,15 @@ def prserv_import_db(d, filter_version=None, filter_pkgarch=None, filter_checksu (filter_pkgarch and filter_pkgarch != pkgarch) or \ (filter_checksum and filter_checksum != checksum): continue -try: -value = int(d.getVar(remain + '$' + version + '$' + pkgarch + '$' + checksum)) -except BaseException as exc: + +value = d.getVar(remain + '$' + version + '$' + pkgarch + '$' + checksum) +if not is_legal_prvalue(value): bb.debug("Not valid value of %s:%s" % (v,str(exc))) continue -ret = conn.importone(version,pkgarch,checksum,value) + +ret = str(conn.importone(version, pkgarch, checksum, value)) if ret != value: -bb.error("importing(%s,%s,%s,%d) failed. DB may have larger value %d" % (version,pkgarch,checksum,value,ret)) +bb.error("importing(%s,%s,%s,%s) failed. DB may have larger value %s" % (version,pkgarch,checksum,value,ret)) else: imported.append((version,pkgarch,checksum,value)) conn.close() diff --git a/meta/lib/oeqa/selftest/cases/prservice.py b/meta/lib/oeqa/selftest/cases/prservice.py index 8da3739c57..0e2ca0c5ab 100644 --- a/meta/lib/oeqa/selftest/cases/prservice.py +++ b/meta/lib/oeqa/selftest/cases/prservice.py @@ -16,6 +16,11 @@ from oeqa.utils.network import get_free_port import bb.utils +def rev_minor(rev): +"""Returns the last number of an x.y.z revision number""" +fields=str(rev).split('.') +return int(fields[-1]) + class BitbakePrTests(OESelftestTestCase): @classmethod @@ -78,7 +83,7 @@ class BitbakePrTests(OESelftestTestCase): pr_2 = self.get_pr_version(package_name) stamp_2 = self.get_task_stamp(package_name, track_task) -self.assertTrue(pr_2 - pr_1 == 1, "New PR %s did not increment as expected (from %s), difference should be 1" % (pr_2, pr_1)) +self.assertTrue(rev_minor(pr_2) - rev_minor(pr_1) == 1, "New PR %s did not increment as expected (from %s), difference should be 1" % (pr_2, pr_1)) self.assertTrue(stamp_1 != stamp_2, "Different pkg rev. but same stamp: %s" % stamp_1) self.cleanup() @@ -104,7 +109,7 @@ class BitbakePrTests(OESelftestTestCase): self.increment_package_pr(package_name) pr_2 = self.get_pr_version(package_name) -self.assertTrue(pr_2 - pr_1 == 1, "New PR %s did not increment as expected (from %s), difference should be 1" % (pr_2, pr_1)) +self.assertTrue(rev_minor(pr_2) - rev_minor(pr_1) == 1, "New PR %s did not increment as expected (from %s), difference should be 1" % (pr_2, pr_1)) self.cleanup() -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#198752): https://lists.openembedded.org/g/openembedded-core/message/198752 Mute This Topic: https://lists.openembedded.org/mt/105808223/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH v2] oeqa/runtime/cases: new image_upgrade test
From: Michael Opdenacker New oe-selftest and associated "testimage" test to check that generated package feeds can be used to update the latest image built by the Yocto Project autobuilder. Currently, only the "core-image-full-cmdline" image with IPK packages and the "poky-altcfg" distro is tested. Test it by running: oe-selftest -r image_upgrade Signed-off-by: Michael Opdenacker Suggested-by: Richard Purdie CC: Thomas Petazzoni CC: Bruce Ashfield CC: Alexander Kanavin --- Changes in V2: - Move meta/lib/oeqa/runtime/cases/opkg_sysupgrade.py to meta-selftest/lib/oeqa/runtime/cases/ipk_sysupgrade.py (notice that "ipk" is a new prefix, to match PACKAGE_CLASSES values) as it needs special setup via selftest, and not useful in standalone '-c testimage' runs. Suggested by Alexander Kanavin. - Implement a more generic run_image_upgrade_test() which can be given any image type, image file path, image download URL, any PACKAGE_CLASSES value, and specific features. This way, the function running the tests is not supposed to be Yocto and Poky specific. - Tested on the latest master against yocto-5.0_M3 Interested in further (specific) guidelines for making this test more generic, depending on the environments calling it and their configurations. --- .../lib/oeqa/runtime/cases/ipk_sysupgrade.py | 68 + meta/lib/oeqa/selftest/cases/image_upgrade.py | 134 ++ 2 files changed, 202 insertions(+) create mode 100644 meta-selftest/lib/oeqa/runtime/cases/ipk_sysupgrade.py create mode 100755 meta/lib/oeqa/selftest/cases/image_upgrade.py diff --git a/meta-selftest/lib/oeqa/runtime/cases/ipk_sysupgrade.py b/meta-selftest/lib/oeqa/runtime/cases/ipk_sysupgrade.py new file mode 100644 index 00..05b5847b4a --- /dev/null +++ b/meta-selftest/lib/oeqa/runtime/cases/ipk_sysupgrade.py @@ -0,0 +1,68 @@ +# +# Copyright OpenEmbedded Contributors +# +# Test that generated ipk packages can be used to upgrade +# an older image version. +# +# This is done by the meta/lib/oeqa/selftest/cases/image_upgrade.py oe-selftest +# replacing the newly generated image by an older image +# generated by the Yocto Project autobuilder. +# +# Here, we replace the package feeds in our image by our own +# +# This test is not meant to be used as a regular "testimage" test +# run on the fresh image. +# +# SPDX-License-Identifier: MIT +# + +import os +from oeqa.utils.httpserver import HTTPService +from oeqa.runtime.case import OERuntimeTestCase +from oeqa.core.decorator.data import skipIfNotDataVar, skipIfNotFeature, skipIfFeature +from oeqa.runtime.decorator.package import OEHasPackage + +class OpkgSysUpgradeTest(OERuntimeTestCase): + +def pkg(self, command, expected = 0): +command = 'opkg %s' % command +status, output = self.target.run(command, 1500) +message = os.linesep.join([command, output]) +self.assertEqual(status, expected, message) +return output + +class OpkgRepoTest(OpkgSysUpgradeTest): + +@classmethod +def setUp(cls): +service_repo = os.path.join(cls.tc.td['DEPLOY_DIR_IPK']) +cls.repo_server = HTTPService(service_repo, + '0.0.0.0', port=cls.tc.target.server_port, + logger=cls.tc.logger) +cls.repo_server.start() + +@classmethod +def tearDown(cls): +cls.repo_server.stop() + +def setup_source_config_for_package_install(self): +source_server = 'http://%s:%s' % (self.tc.target.server_ip, self.repo_server.port) +sourceslist_dir = '/etc/opkg' +pkgarch = self.tc.td["TUNE_PKGARCH"] +machinedir = self.tc.td["MACHINE"].replace("-", "_") +self.target.run('cd %s; echo src/gz all %s/all > base-feeds.conf' % (sourceslist_dir, source_server)) +self.target.run('cd %s; echo src/gz %s %s/%s >> base-feeds.conf' % (sourceslist_dir, pkgarch, source_server, pkgarch)) +self.target.run('cd %s; echo src/gz %s %s/%s >> base-feeds.conf' % (sourceslist_dir, machinedir, source_server, machinedir)) + +@skipIfNotFeature('package-management', + 'Test requires package-management to be in IMAGE_FEATURES') +@skipIfNotDataVar('IMAGE_PKGTYPE', 'ipk', + 'IPK is not the primary package manager') +@skipIfFeature('read-only-rootfs', + 'Test does not work with read-only-rootfs in IMAGE_FEATURES') +@OEHasPackage(['opkg']) +def test_opkg_system_upgrade_from_repo(self): +self.setup_source_config_for_package_install() +self.pkg('update') +self.pkg('upgrade') + diff --git a/meta/lib/oeqa/selftest/cases/image_upgrade.py b/meta/lib/oeqa/selftest/cases/image_upgrade.py new file mode 100755 index 00..aed526483b --- /dev/null +++ b/meta/lib/oeqa/selftest/cases/image_upgrade.py @@ -0
Re: [OE-core] [RFC][PATCH] oeqa/runtime/cases: new image_upgrade test
Hi Richard, Many thanks for your feedback. I started by implementing Alex Kanavin's suggestions, which are a little more specific to get started ;-) On 4/25/24 at 22:40, Richard Purdie wrote: Hi Michael, At least at a first read and without running it, this does look like a reasonable direction. I suspect that anyone else looking at this would have a lot of questions about why we'd do it this way but given the various constraints, it does make sense to me. What we do need to think about is how someone else would reuse this as currently it is very poky specific. Our aim is to make it easy for others to use too. With that in mind: * We probably want to "tag" this test with something so we can exclude it from the normal oe-selftest runs on the autobuilder and allow it to run on a per machine basis. There are other oe-selftests we already do this with (like toolchain testing or machine specific environment file tests). * The configuration about what to test probably needs to come from the distro (i.e. which DISTRO/MACHINE/image combinations). * We probably need to parameterise it so that a list of images can be tested rather than just a single one. I did wonder if we could have it dynamically add tests for each image configured. * We don't want to test on all MACHINE (e.g. qemumips and qemuppc are not going to be included). * We need to find a better way to share the code with autobuilder- helper, I don't like duplicating code. Is there example code somewhere doing something similar, i.e. importing code from an external repository? * The image url code is also highly poky specific. That probably needs to come from the poky repository alongside the configuration. I'm going to submit a new version that doesn't assume any specific URL scheme. More soon. Thanks, Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#198745): https://lists.openembedded.org/g/openembedded-core/message/198745 Mute This Topic: https://lists.openembedded.org/mt/105732738/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [RFC][PATCH] oeqa/runtime/cases: new image_upgrade test
From: Michael Opdenacker New oe-selftest and associated "testimage" test to check that generated package feeds can be used to update the latest image built by the Yocto Project autobuilder. Currently, only the "core-image-full-cmdline" image with IPK packages and the "poky-altcfg" distro is supported. Test it by running: oe-selftest -r image_upgrade Signed-off-by: Michael Opdenacker Suggested-by: Richard Purdie CC: Thomas Petazzoni CC: Bruce Ashfield --- Tested on the latest master against yocto-5.0_M3 Interested in your feedback about which settings (such as IMAGE) can be hardcoded in the scripts or provided by the calling environment. --- .../lib/oeqa/runtime/cases/opkg_sysupgrade.py | 68 ++ meta/lib/oeqa/selftest/cases/image_upgrade.py | 124 ++ 2 files changed, 192 insertions(+) create mode 100644 meta/lib/oeqa/runtime/cases/opkg_sysupgrade.py create mode 100755 meta/lib/oeqa/selftest/cases/image_upgrade.py diff --git a/meta/lib/oeqa/runtime/cases/opkg_sysupgrade.py b/meta/lib/oeqa/runtime/cases/opkg_sysupgrade.py new file mode 100644 index 00..05b5847b4a --- /dev/null +++ b/meta/lib/oeqa/runtime/cases/opkg_sysupgrade.py @@ -0,0 +1,68 @@ +# +# Copyright OpenEmbedded Contributors +# +# Test that generated ipk packages can be used to upgrade +# an older image version. +# +# This is done by the meta/lib/oeqa/selftest/cases/image_upgrade.py oe-selftest +# replacing the newly generated image by an older image +# generated by the Yocto Project autobuilder. +# +# Here, we replace the package feeds in our image by our own +# +# This test is not meant to be used as a regular "testimage" test +# run on the fresh image. +# +# SPDX-License-Identifier: MIT +# + +import os +from oeqa.utils.httpserver import HTTPService +from oeqa.runtime.case import OERuntimeTestCase +from oeqa.core.decorator.data import skipIfNotDataVar, skipIfNotFeature, skipIfFeature +from oeqa.runtime.decorator.package import OEHasPackage + +class OpkgSysUpgradeTest(OERuntimeTestCase): + +def pkg(self, command, expected = 0): +command = 'opkg %s' % command +status, output = self.target.run(command, 1500) +message = os.linesep.join([command, output]) +self.assertEqual(status, expected, message) +return output + +class OpkgRepoTest(OpkgSysUpgradeTest): + +@classmethod +def setUp(cls): +service_repo = os.path.join(cls.tc.td['DEPLOY_DIR_IPK']) +cls.repo_server = HTTPService(service_repo, + '0.0.0.0', port=cls.tc.target.server_port, + logger=cls.tc.logger) +cls.repo_server.start() + +@classmethod +def tearDown(cls): +cls.repo_server.stop() + +def setup_source_config_for_package_install(self): +source_server = 'http://%s:%s' % (self.tc.target.server_ip, self.repo_server.port) +sourceslist_dir = '/etc/opkg' +pkgarch = self.tc.td["TUNE_PKGARCH"] +machinedir = self.tc.td["MACHINE"].replace("-", "_") +self.target.run('cd %s; echo src/gz all %s/all > base-feeds.conf' % (sourceslist_dir, source_server)) +self.target.run('cd %s; echo src/gz %s %s/%s >> base-feeds.conf' % (sourceslist_dir, pkgarch, source_server, pkgarch)) +self.target.run('cd %s; echo src/gz %s %s/%s >> base-feeds.conf' % (sourceslist_dir, machinedir, source_server, machinedir)) + +@skipIfNotFeature('package-management', + 'Test requires package-management to be in IMAGE_FEATURES') +@skipIfNotDataVar('IMAGE_PKGTYPE', 'ipk', + 'IPK is not the primary package manager') +@skipIfFeature('read-only-rootfs', + 'Test does not work with read-only-rootfs in IMAGE_FEATURES') +@OEHasPackage(['opkg']) +def test_opkg_system_upgrade_from_repo(self): +self.setup_source_config_for_package_install() +self.pkg('update') +self.pkg('upgrade') + diff --git a/meta/lib/oeqa/selftest/cases/image_upgrade.py b/meta/lib/oeqa/selftest/cases/image_upgrade.py new file mode 100755 index 00..3e26c7eed0 --- /dev/null +++ b/meta/lib/oeqa/selftest/cases/image_upgrade.py @@ -0,0 +1,124 @@ +# +# Copyright OpenEmbedded Contributors +# +# SPDX-License-Identifier: MIT +# + +import os +import subprocess +from oeqa.selftest.case import OESelftestTestCase +from oeqa.utils.commands import bitbake, runCmd, get_bb_var +from oeqa.core.decorator.data import skipIfNotQemu + +basepath = os.path.abspath(os.path.dirname(__file__) + '/../../../../../') + +# Version string utilities copied from yocto-autobuilder-helper/scripts/utils.py + +def get_string_from_version(version, milestone=None, rc=None): +""" Point releases finishing by 0 (e.g 4.0.0, 4.1.0) do no exists, +those are major releases +""" +
[OE-core] [RFC PATCH] scripts: new oe-test-system-upgrade test
From: Michael Opdenacker Proof of concept "testimage" test to check whether the generated package feeds can be used to update an older image provided by the Yocto Project autobuilder. Signed-off-by: Michael Opdenacker Suggested-by: Richard Purdie CC: Thomas Petazzoni CC: Bruce Ashfield --- Tested on the latest master against yocto-5.0_M3 A bit surprised that only one package got upgraded: DEBUG: Command: opkg upgrade Status: 0 Output: Upgrading libexpat1 (2.6.1-r0) to libexpat1 (2.6.2) on root Downloading http://192.168.7.1:44893/core2-64/libexpat1_2.6.2-r0_core2-64.ipk. Removing obsolete file /usr/lib/libexpat.so.1.9.1. Configuring libexpat1. Test with a more complete image than core-image-full-cmdline? --- .../lib/oeqa/runtime/cases/opkg_sysupgrade.py | 71 +++ scripts/oe-test-system-upgrade| 34 + 2 files changed, 105 insertions(+) create mode 100644 meta/lib/oeqa/runtime/cases/opkg_sysupgrade.py create mode 100755 scripts/oe-test-system-upgrade diff --git a/meta/lib/oeqa/runtime/cases/opkg_sysupgrade.py b/meta/lib/oeqa/runtime/cases/opkg_sysupgrade.py new file mode 100644 index 00..7431db9198 --- /dev/null +++ b/meta/lib/oeqa/runtime/cases/opkg_sysupgrade.py @@ -0,0 +1,71 @@ +# +# Copyright OpenEmbedded Contributors +# +# Test that generated ipk packages can be used to upgrade +# an older image version. +# +# This is done by the scripts/oe-test-system-upgrade script +# replacing the fresh generated image by the older image +# generated by the Yocto Project autobuilder. +# +# Here, we then replace the original package feeds by our own. +# This test is not meant to be used as a regular "testimage" test +# run on the fresh image. +# +# SPDX-License-Identifier: MIT +# + +import os +from oeqa.utils.httpserver import HTTPService +from oeqa.runtime.case import OERuntimeTestCase +from oeqa.core.decorator.data import skipIfNotDataVar, skipIfNotFeature, skipIfFeature +from oeqa.runtime.decorator.package import OEHasPackage + +class OpkgSysUpgradeTest(OERuntimeTestCase): + +def pkg(self, command, expected = 0): +command = 'opkg %s' % command +status, output = self.target.run(command, 1500) +message = os.linesep.join([command, output]) +self.assertEqual(status, expected, message) +return output + +class OpkgRepoTest(OpkgSysUpgradeTest): + +@classmethod +def setUp(cls): +service_repo = os.path.join(cls.tc.td['DEPLOY_DIR_IPK']) +cls.repo_server = HTTPService(service_repo, + '0.0.0.0', port=cls.tc.target.server_port, + logger=cls.tc.logger) +cls.repo_server.start() + +@classmethod +def tearDown(cls): +cls.repo_server.stop() + +def setup_source_config_for_package_install(self): +source_server = 'http://%s:%s' % (self.tc.target.server_ip, self.repo_server.port) +sourceslist_dir = '/etc/opkg' +pkgarch = self.tc.td["TUNE_PKGARCH"] +machinedir = self.tc.td["MACHINE"].replace("-", "_") +self.target.run('cd %s; echo src/gz all %s/all > base-feeds.conf' % (sourceslist_dir, source_server)) +self.target.run('cd %s; echo src/gz %s %s/%s >> base-feeds.conf' % (sourceslist_dir, pkgarch, source_server, pkgarch)) +self.target.run('cd %s; echo src/gz %s %s/%s >> base-feeds.conf' % (sourceslist_dir, machinedir, source_server, machinedir)) + +def cleanup_source_config_for_package_install(self): +sourceslist_dir = '/etc/opkg' +self.target.run('rm -rf %s; mv %s.orig %s' % (sourceslist_dir, sourceslist_dir, sourceslist_dir)) + +@skipIfNotFeature('package-management', + 'Test requires package-management to be in IMAGE_FEATURES') +@skipIfNotDataVar('IMAGE_PKGTYPE', 'ipk', + 'IPK is not the primary package manager') +@skipIfFeature('read-only-rootfs', + 'Test does not work with read-only-rootfs in IMAGE_FEATURES') +@OEHasPackage(['opkg']) +def test_opkg_system_upgrade_from_repo(self): +self.setup_source_config_for_package_install() +self.pkg('update') +self.pkg('upgrade') + diff --git a/scripts/oe-test-system-upgrade b/scripts/oe-test-system-upgrade new file mode 100755 index 00..0d36a70a8a --- /dev/null +++ b/scripts/oe-test-system-upgrade @@ -0,0 +1,34 @@ +#!/bin/sh +# Proof of concept script to test that generated ipk packages can +# be used to upgrade an older image version. +# +# This is done by generating an image but then replacing it +# by an older image shared by the Yocto Project autobuilder. +# We then run QEMU on the old image and replace the original +# original package feeds by our own. + +IMAGE=core-image-full-cmdline +MILESTONE=yocto-5.0_M3 +MACHINE=qemux86-64 +MACHINE_VARIANT=-alt +IMAGE_FILE=$IMAGE-$MACHINE.rootfs.ext4 +IM
[OE-core] Review of 5.0 release notes
Greetings For your information, here are the release and migration notes that we have gathered for 5.0 so far: https://docs.yoctoproject.org/next/migration-guides/release-5.0.html Your reviews are welcome, in particular if you contributed a change or new feature during the last development cycle. Note that the detailed recipe version updates will be added when the release is actually finalized. Patches against yocto-docs "master-next" are most welcome, but I can also take text descriptions of the changes you'd like to see. https://git.yoctoproject.org/yocto-docs/log/?h=master-next Thanks in advance :) Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#198122): https://lists.openembedded.org/g/openembedded-core/message/198122 Mute This Topic: https://lists.openembedded.org/mt/105459019/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] oeqa/selftest/prservice: support non integer PR values
From: Michael Opdenacker Support non integer x.y.z PR values, for when the PR server supports upstream PR servers. Signed-off-by: Michael Opdenacker --- Note that regular integer PR values are still supported. This code has also been tested on master, without the proposed PR server changes. --- meta/classes/primport.bbclass | 2 +- meta/lib/oe/prservice.py | 17 - meta/lib/oeqa/selftest/cases/prservice.py | 9 +++-- 3 files changed, 20 insertions(+), 8 deletions(-) diff --git a/meta/classes/primport.bbclass b/meta/classes/primport.bbclass index 00924174c1..1ff09c8785 100644 --- a/meta/classes/primport.bbclass +++ b/meta/classes/primport.bbclass @@ -17,7 +17,7 @@ python primport_handler () { bb.fatal("import failed!") for (version, pkgarch, checksum, value) in imported: -bb.note("imported (%s,%s,%s,%d)" % (version, pkgarch, checksum, value)) +bb.note("imported (%s,%s,%s,%s)" % (version, pkgarch, checksum, value)) elif isinstance(e, bb.event.ParseStarted): import oe.prservice oe.prservice.prserv_check_avail(e.data) diff --git a/meta/lib/oe/prservice.py b/meta/lib/oe/prservice.py index c41242c878..d7920fc511 100644 --- a/meta/lib/oe/prservice.py +++ b/meta/lib/oe/prservice.py @@ -4,6 +4,12 @@ # SPDX-License-Identifier: GPL-2.0-only # +import re + +def is_legal_prvalue(str): +pattern = r'^[0-9]+([.][0-9]+)*$' +return bool(re.match(pattern, str)) + def prserv_make_conn(d, check = False): import prserv.serv host_params = list([_f for _f in (d.getVar("PRSERV_HOST") or '').split(':') if _f]) @@ -59,14 +65,15 @@ def prserv_import_db(d, filter_version=None, filter_pkgarch=None, filter_checksu (filter_pkgarch and filter_pkgarch != pkgarch) or \ (filter_checksum and filter_checksum != checksum): continue -try: -value = int(d.getVar(remain + '$' + version + '$' + pkgarch + '$' + checksum)) -except BaseException as exc: + +value = d.getVar(remain + '$' + version + '$' + pkgarch + '$' + checksum) +if not is_legal_prvalue(value): bb.debug("Not valid value of %s:%s" % (v,str(exc))) continue -ret = conn.importone(version,pkgarch,checksum,value) + +ret = str(conn.importone(version, pkgarch, checksum, value)) if ret != value: -bb.error("importing(%s,%s,%s,%d) failed. DB may have larger value %d" % (version,pkgarch,checksum,value,ret)) +bb.error("importing(%s,%s,%s,%s) failed. DB may have larger value %s" % (version,pkgarch,checksum,value,ret)) else: imported.append((version,pkgarch,checksum,value)) conn.close() diff --git a/meta/lib/oeqa/selftest/cases/prservice.py b/meta/lib/oeqa/selftest/cases/prservice.py index 8da3739c57..0e2ca0c5ab 100644 --- a/meta/lib/oeqa/selftest/cases/prservice.py +++ b/meta/lib/oeqa/selftest/cases/prservice.py @@ -16,6 +16,11 @@ from oeqa.utils.network import get_free_port import bb.utils +def rev_minor(rev): +"""Returns the last number of an x.y.z revision number""" +fields=str(rev).split('.') +return int(fields[-1]) + class BitbakePrTests(OESelftestTestCase): @classmethod @@ -78,7 +83,7 @@ class BitbakePrTests(OESelftestTestCase): pr_2 = self.get_pr_version(package_name) stamp_2 = self.get_task_stamp(package_name, track_task) -self.assertTrue(pr_2 - pr_1 == 1, "New PR %s did not increment as expected (from %s), difference should be 1" % (pr_2, pr_1)) +self.assertTrue(rev_minor(pr_2) - rev_minor(pr_1) == 1, "New PR %s did not increment as expected (from %s), difference should be 1" % (pr_2, pr_1)) self.assertTrue(stamp_1 != stamp_2, "Different pkg rev. but same stamp: %s" % stamp_1) self.cleanup() @@ -104,7 +109,7 @@ class BitbakePrTests(OESelftestTestCase): self.increment_package_pr(package_name) pr_2 = self.get_pr_version(package_name) -self.assertTrue(pr_2 - pr_1 == 1, "New PR %s did not increment as expected (from %s), difference should be 1" % (pr_2, pr_1)) +self.assertTrue(rev_minor(pr_2) - rev_minor(pr_1) == 1, "New PR %s did not increment as expected (from %s), difference should be 1" % (pr_2, pr_1)) self.cleanup() -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#198065): https://lists.openembedded.org/g/openembedded-core/message/198065 Mute This Topic: https://lists.openembedded.org/mt/105421276/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [yocto] [Openembedded-architecture] New mailing list for layer patches
Hi Paul, On 4/2/24 at 10:38, Paul Barker wrote: On 28/03/2024 14:36, Ross Burton wrote: Hi, At the moment if a layer doesn’t have enough volume to justify a dedicated mailing list for patches (see, for example, meta-...@lists.yoctoproject.org <mailto:meta-...@lists.yoctoproject.org>) then the convention is that the patches can be sent to yo...@lists.yoctoproject.org <mailto:yo...@lists.yoctoproject.org>. However, that’s also the list that we encourage users of Yocto to use for help, so the list has a mix of patches for various layers and people asking for help, which isn’t ideal: users who want help don’t want to be flooded with patches for layers they’re not using, layer maintainers may not want to see the requests for help, and people who want the status reports have to receive patches and support. The Yocto TSC has been discussing this, and as a solution to this we’ve just created a new mailing list: yocto-patc...@lists.yoctoproject.org <mailto:yocto-patc...@lists.yoctoproject.org>. This list is specifically for Yocto-related projects which don’t have their own mailing list or other patch submission process. We ask that all layers currently using yocto@ for patches move to yocto-patches@, so that yocto@ can be used purely for discussion and other non-patch related subjects. I think this is a great change, along with the new yocto-status@ list it will make things easier to follow :) Do you know if yocto-patches@ will be available via lore.kernel.org? I've just asked them to index the new lists as well as these important ones which are missing too: https://lists.yoctoproject.org/g/yocto-announce http://lists.openembedded.org/mailman/listinfo/openembedded-architecture https://lists.yoctoproject.org/g/automated-testing https://lists.yoctoproject.org/g/yocto-security Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#197921): https://lists.openembedded.org/g/openembedded-core/message/197921 Mute This Topic: https://lists.openembedded.org/mt/105310355/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] package: fix issue converting PR to string
From: Michael Opdenacker The upcoming introduction of "passthrough" PR servers will add non integer PR values, such as '0.3'. With such a value, the current conversion of this value to a string, to define the package file name, can result in incorrect strings such as "0.30004"! Introduce a safe_str() function which, when given a float value, rounds it up to the 6th decimal first, before the conversion to string. Signed-off-by: Michael Opdenacker CC: thomas.petazz...@bootlin.com --- Notes: this has been tested successfully on the "master" branch. No obvious regression was found and the package file names look normal. --- meta/classes-global/package.bbclass | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/meta/classes-global/package.bbclass b/meta/classes-global/package.bbclass index aa1eb5e901..82747d5467 100644 --- a/meta/classes-global/package.bbclass +++ b/meta/classes-global/package.bbclass @@ -250,6 +250,13 @@ package_get_auto_pr[vardeps] += "PRSERV_ACTIVE" python package_get_auto_pr() { import oe.prservice +def safe_str(pr): +# Avoids turning 0.3 to 0.30004 (for example) +# during the conversion of a float to a string +if type(pr) == float: +pr = round(pr, 6) +return str(pr) + def get_do_package_hash(pn): if d.getVar("BB_RUNTASK") != "do_package": taskdepdata = d.getVar("BB_TASKDEPDATA", False) @@ -289,7 +296,7 @@ python package_get_auto_pr() { auto_pr = d.getVar('PRAUTO_' + version + '_' + pkgarch) or d.getVar('PRAUTO_' + version) or None if auto_pr is None: bb.fatal("Can NOT get PRAUTO from lockdown exported file") -d.setVar('PRAUTO',str(auto_pr)) +d.setVar('PRAUTO', safe_str(auto_pr)) return try: @@ -299,7 +306,7 @@ python package_get_auto_pr() { srcpv = bb.fetch2.get_srcrev(d) base_ver = "AUTOINC-%s" % version[:version.find(srcpv)] value = conn.getPR(base_ver, pkgarch, srcpv) -d.setVar("PRSERV_PV_AUTOINC", str(value)) +d.setVar("PRSERV_PV_AUTOINC", safe_str(value)) auto_pr = conn.getPR(version, pkgarch, checksum) conn.close() @@ -307,7 +314,7 @@ python package_get_auto_pr() { bb.fatal("Can NOT get PRAUTO, exception %s" % str(e)) if auto_pr is None: bb.fatal("Can NOT get PRAUTO from remote PR service") -d.setVar('PRAUTO',str(auto_pr)) +d.setVar('PRAUTO', safe_str(auto_pr)) } # -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#197920): https://lists.openembedded.org/g/openembedded-core/message/197920 Mute This Topic: https://lists.openembedded.org/mt/105308894/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Call for contributions to the 5.0 release notes
Hi Ross On 3/15/24 at 21:58, Ross Burton wrote: On 15 Mar 2024, at 08:12, Michael Opdenacker via lists.openembedded.org wrote: Greetings, If you contributed new features to the upcoming release, or if you are interested in figuring out what's new in 5.0, that would be great if you could help us by submitting bits of release notes about them too. I’ve been making notes of every commit that I’ve seen go into master that looks like it should be in the release notes. I didn’t include upgrades unless they were incredibly notable because that can be generated by a script. I know this isn’t very useful as it is, and I do hope to start writing some entries where I was responsible for the changes, but here’s the raw list: b49d42ce: oeqa/runtime/login: Proof of concept for screenshot testcases e9870028: image_types.bbclass: fix vfat image names 22d6c096: rxvt: add rxvt to desktop entry name 2f4f72ff: Add genericarm64 MACHINE f1567659: bmaptool: now part of Yocto Project fd2e5e0b: goarch: disable dynamic linking globally 2387bd63: core-image-full-cmdline: add package-management 694b85a2: rust: Revert PGO to it's default 90893b5e: python3: dont disable readline module for editline ee014ca5: wic: allow imager-specific filename extensions 08aa69a1: bitbake: runqueue: Add support for BB_LOADFACTOR_MAX a226865c: base-files: add usage warning to motd 9f7475b4: recipetool; add support for python_mesonpy class a7484a66: python_mesonpy.bbclass: move from meta-python c0a2e3a9: python3-meson-python: move from meta-python 03f3aa64: python3-pyproject-metadata: move from meta-python 4cfd0f7e: lib/oe/patch: Use git notes to store the filenames for the patches 6f32769a: overlayfs-etc: add option to skip creation of mount dirs 1effd101: bitbake: hashserv: Add Unihash Garbage Collection fd600728: meta-poky/conf/templates/default/conf-summary.txt: add a template summary c390b2e6: oe-setup-build: add a tool for discovering config templates and setting up builds dfe98713: oe-init-build-env: generate .vscode from template f62e4d81: bitbake: taskexp_ncurses: ncurses version of taskexp.py 3ccb4d8a: devtool: new ide-sdk plugin 8da6bd69: cups: use LOCALE_PATHS to split localized HTML templates c2a7c008: lib/oe/package: add LOCALE_PATHS to add define all locations for locales a7bbb105: bitbake: runqueue: Improve performance for executing tasks 80396cc7: sanity.bbclass: raise_sanity_error if /tmp is noexec 07006c48: Revert "lzop: remove recipe from oe-core" 92d790f5: conf/machine: Add Power8 tune to PowerPC architecture 81d90fc8: package_rpm: add RPMBUILD_EXTRA_PARAMS variable 77f5f99f: package_manager: ipk: add OPKG_MAKE_INDEX_EXTRA_PARAMS variable e6857735: wic: implement reproducible Disk GUID cc740bf6: arm/armv*: add all the Arm tunes in GCC 13.2.0 e71f54c6: tunes/sve: Add support for sve2 instructions 6d503a7f: glibc: Upgrade to 2.39 b0e5542e: binutils: Upgrade to binutils 2.42 78c99af2: eudev: allow for predictable network interface names 6540f65a: linux-yocto-dev: update to v6.8 ed081806: sysroot user management postinsts: run with /bin/sh -e to report errors when they happen bb630c3e: rust: Enable rust oe-selftest. 999bcf99: linux-yocto/6.1: drop recipes 603669d3: xserver-xorg: disable xvfb by default 97fd704a: tune-core2: Update qemu cpu to supported model 09b69a69: rng-tools: Revert "rng-tools: move to meta-oe" 3e579c30: classes: go-vendor: Handle modules from the same repo 0161d08a: recipetool: Don't fail on local go modules 6e00774a: classes-global/insane: Add check for "virtual/" in RPROVIDES and RDEPENDS c917323a: classes/recipes: Switch to use inherit_defer c56fce9e: bitbake: ast/BBHandler: Add inherit_defer support 5031cf42: package.py: fix Darwin support d2b44538: rng-tools: move to meta-oe 61182659: bitbake: runqueue: Fix runall all bug 3dc89580: autotools: don't exclude gtkdocize 67e3f243: bitbake: bitbake/runqueue: rework 'bitbake -S printdiff' logic c665a2c9: bitbake: ast: Fix EXPORT_FUNCTIONS bug 3f415929: bitbake: bitbake: event: Inject empty lines to make code match lineno in filename 8c732425: openssh: Add PACKAGECONFIG option to customize sshd mode 10075b25: linux-yocto/6.1: update to v6.1.70 486588e2: linux-yocto/6.6: update to v6.6.9 df9eb69f: linux-yocto: introduce 6.6 reference kernel 4f2c4993: systemd-boot: Add recipe to compile native b40a8e02: zvariant: Drop recipe fdef56a5: archiver.bbclass: Drop tarfile module to improve performance 3000abe2: conf/machine-sdk: declare qemu-usermode SDK_MACHINE_FEATURE 64162b18: nativesdk: don't unset MACHINE_FEATURES, let machine-sdk/ set it 60ce6818: nativesdk: ensure features don't get backfilled df548e98: ipk: Switch to using zstd compression bc8ca0ba: wic: use E2FSPROGS_FAKE_TIME and hash_seed to generate reproducible ext4 images 143686fe: gpgme: disable python support (until upstream fixes 3.12 compatibility) e73b3744: python3: re-enable profile guided optimisation 2f56aec0: machine/arch-armv9: remove crc and sve tune
[OE-core] Call for contributions to the 5.0 release notes
Greetings, If you contributed new features to the upcoming release, or if you are interested in figuring out what's new in 5.0, that would be great if you could help us by submitting bits of release notes about them too. If you are familiar with the Sphinx / ReStructured Text format, you can directly send patches against the yocto-docs "master-next" branch (https://git.yoctoproject.org/yocto-docs/log/?h=master-next). However, I'm also happy to accept raw text as well and format it or even elaborate on it by myself. We may also need proper documentation for the new features, not only release notes. I am thinking about documenting the new variables in ref-manual/variables.rst, for example. Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#197128): https://lists.openembedded.org/g/openembedded-core/message/197128 Mute This Topic: https://lists.openembedded.org/mt/104943580/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v2] dev-manual: Convert to 'bmaptool-native'
Hi Fabio On 3/5/24 at 20:52, Fabio Estevam wrote: Since commit 7a036b1a1ec7 ("bmaptool: now part of Yocto Project") 'bmap-tools-native' has been renamed as 'bmaptool-native'. Adjust the references in the documentation accordingly. Suggested-by: Khem Raj Signed-off-by: Fabio Estevam Many thanks for the patch! However, I eventually took Trevor's version, which was more exhaustive than yours... Funny to have two competing patches :-) Thanks anyway Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#196683): https://lists.openembedded.org/g/openembedded-core/message/196683 Mute This Topic: https://lists.openembedded.org/mt/104752483/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] Easy way to talk to hashserv or prserv?
Hi Joshua and all, I'm going to test changes to the prserv server, to implement "passthrough" to another server. I can make tests by checking the impact of my changes on the build results, like checking the revision of generated packages. However, would there be an easy way to make a test connection to a server based on the bb.asyncrpc.AsyncServer class, such as hashserv or prserv? Feeling lucky, I tried with a plain "telnet": telnet 0.0.0.0 8585 Trying 0.0.0.0... Connected to 0.0.0.0. Escape character is '^]'. get-pr ethtool-6.7-r0 Connection closed by foreign host. The request doesn't look that bad, as the server doesn't complain (in the logs) but I don't get the return value. So, any tip for talking to a server from a terminal, or do I need a proper client written in Python? Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#196464): https://lists.openembedded.org/g/openembedded-core/message/196464 Mute This Topic: https://lists.openembedded.org/mt/104671208/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] core-image-full-cmdline: add package-management
From: Michael Opdenacker Add "package-management" image feature to the core-image-full-cmdline image, to support package upgrade testing. Signed-off-by: Michael Opdenacker Suggested-by: Richard Purdie --- meta/recipes-extended/images/core-image-full-cmdline.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-extended/images/core-image-full-cmdline.bb b/meta/recipes-extended/images/core-image-full-cmdline.bb index 4e1cf58d55..b034cd0aeb 100644 --- a/meta/recipes-extended/images/core-image-full-cmdline.bb +++ b/meta/recipes-extended/images/core-image-full-cmdline.bb @@ -1,7 +1,7 @@ SUMMARY = "A console-only image with more full-featured Linux system \ functionality installed." -IMAGE_FEATURES += "splash ssh-server-openssh" +IMAGE_FEATURES += "splash ssh-server-openssh package-management" IMAGE_INSTALL = "\ packagegroup-core-boot \ -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#196436): https://lists.openembedded.org/g/openembedded-core/message/196436 Mute This Topic: https://lists.openembedded.org/mt/104644618/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: Patchtest results for [OE-core][PATCH 1/2] patchtest: Fix grammar in log output
On 2/15/24 at 22:05, Patchtest wrote: Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/1-2-patchtest-Fix-grammar-in-log-output.patch FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence) Brilliant! Patchtest is now reaching self-awareness :) Cheers Michael -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#195739): https://lists.openembedded.org/g/openembedded-core/message/195739 Mute This Topic: https://lists.openembedded.org/mt/104381528/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] Issue with relative DEPLOY_DIR in meta/lib/oeqa/runtime/cases/rpm.py
Greetings, Using the latest poky master branch, I'm running: bitbake -c testimage core-image-full-cmdline I'm getting errors in the RPM tests: AttributeError: 'RpmInstallRemoveTest' object has no attribute 'test_file' Tracing the code, this happens because the code in rpm.py is trying to access DEPLOY_DIR/rpm, which is a relative path (tmp/deploy/rpm), and this path doesn't exist because I'm not running BitBake from TOPDIR. Of course, if I'm running BitBake from TOPDIR, the test works. Why doesn't this module see an absolute path for DEPLOY_DIR, like the value I get from "bitbake-getvar"? This would make the test modules more robust. Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#192283): https://lists.openembedded.org/g/openembedded-core/message/192283 Mute This Topic: https://lists.openembedded.org/mt/103147277/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] systemd-compat-units.bb: fix postinstall script
From: Michael Opdenacker This fixes an issue running "opkg upgrade" on a system with systemd (and when there is an update to "systemd-compat-units", for example between yocto 4.2.2 and 4.2.3): //var/lib/opkg/info/systemd-compat-units.postinst: cd: line 3: can't cd to /etc/init.d: No such file or directory The existence of /etc/init.d is now tested without causing an error if doesn't exist. Fixes [YOCTO #15292] Signed-off-by: Michael Opdenacker --- meta/recipes-core/systemd/systemd-compat-units.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb index 253bc9fcf1..c03d97f9c9 100644 --- a/meta/recipes-core/systemd/systemd-compat-units.bb +++ b/meta/recipes-core/systemd/systemd-compat-units.bb @@ -27,7 +27,8 @@ SYSTEMD_DISABLED_SYSV_SERVICES = " \ pkg_postinst:${PN} () { - cd $D${sysconfdir}/init.d || exit 0 + test -d $D${sysconfdir}/init.d || exit 0 + cd $D${sysconfdir}/init.d echo "Disabling the following sysv scripts: " -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#191055): https://lists.openembedded.org/g/openembedded-core/message/191055 Mute This Topic: https://lists.openembedded.org/mt/102746398/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Meaning of the name of the "cml1" class?
On 03.11.23 at 10:52, Martin Jansa wrote: The answer from 2022-07-18 on #yocto channel: 20:20 < hushmoney> what does clm1 stand for as in clm1.bbclass? 20:20 < hushmoney> s/clm1/cml1/g 20:31 < JaMa> hushmoney: interesting question, the bbclass was introduced very long time ago (already included in 2004 https://git.openembedded.org/openembedded/commit/?h=master=a780643c4b6aa11e1a36965a69df7116477c7b4c <https://git.openembedded.org/openembedded/commit/?h=master=a780643c4b6aa11e1a36965a69df7116477c7b4c>) and it was very small until https://git.openembedded.org/openembedded/commit/?h=master=f6433e75a047a2d38ab60efea8a7ab7cc3dcd822 <https://git.openembedded.org/openembedded/commit/?h=master=f6433e75a047a2d38ab60efea8a7ab7cc3dcd822> Don't know what it really stands for 20:35 < hushmoney> yes that's what i saw too 20:37 < hushmoney> i grepped the linux source for cml1 and only found references to some clock in modules and device trees, don't think that's related 20:45 < JaMa> http://www.catb.org/~esr/cml2/ANNOUNCEMENT 20:48 < hushmoney> wow, good find! still doesn't answer what cml stands for, but at least i know now to what it refers and that more answers lie outside of yocto history 20:50 < hushmoney> here it is. cml = Configuration Menu Language 20:50 < hushmoney> JaMa: thanks! 20:51 < hushmoney> sort of an odd choice for that bbclass name, but at least now i know where it came from 20:56 < kergoth> hushmoney: it's named based on the ocnifguration language it interacts with, as it's common to more than just kernels, it's used by busybox, buildroot, and other projects as well Great, many thanks. Better than the "Configure My Linux" hypothesis! Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#190152): https://lists.openembedded.org/g/openembedded-core/message/190152 Mute This Topic: https://lists.openembedded.org/mt/102360721/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] Meaning of the name of the "cml1" class?
Greetings I'd like to explain the meaning of the name of the "cml1" class in the documentation. This would help to remember this name. From what I've seen, it has this name since the beginning of the git history. Do those of you who are veterans remember what the name originally meant? Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#190145): https://lists.openembedded.org/g/openembedded-core/message/190145 Mute This Topic: https://lists.openembedded.org/mt/102360721/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] documentation.conf: drop SERIAL_CONSOLES_CHECK
On 03.11.23 at 07:25, Lee Chee Yang wrote: From: Lee Chee Yang remove obsolete SERIAL_CONSOLES_CHECK. Signed-off-by: Lee Chee Yang --- meta/conf/documentation.conf | 1 - 1 file changed, 1 deletion(-) diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf index 23a9c0fe7b..d03c497c0e 100644 --- a/meta/conf/documentation.conf +++ b/meta/conf/documentation.conf @@ -379,7 +379,6 @@ SDKMACHINE[doc] = "Specifies the architecture (i.e. i686 or x86_64) for which to SECTION[doc] = "The section in which packages should be categorized. Package management utilities can make use of this variable." SELECTED_OPTIMIZATION[doc] = "The variable takes the value of FULL_OPTIMIZATION unless DEBUG_BUILD = '1'. In this case, the value of DEBUG_OPTIMIZATION is used." SERIAL_CONSOLES[doc] = "Defines the serial consoles (TTYs) to enable using getty." -SERIAL_CONSOLES_CHECK[doc] = "Similar to SERIAL_CONSOLES except the device is checked for existence before attempting to enable it. Supported only by SysVinit." SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS[doc] = "A list of recipe dependencies that should not be used to determine signatures of tasks from one recipe when they depend on tasks from another recipe." SIGGEN_EXCLUDERECIPES_ABISAFE[doc] = "A list of recipes that are completely stable and will never change." SITEINFO_BITS[doc] = "Specifies the number of bits for the target system CPU." Reviewed-by: Michael Opdenacker Once this is merged, I'll be able to remove the variable from the docs. Thanks! Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#190144): https://lists.openembedded.org/g/openembedded-core/message/190144 Mute This Topic: https://lists.openembedded.org/mt/102359058/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs
Hi Trevor, On 31.10.23 at 15:20, Trevor Gamblin wrote: Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-result-outputs.patch Thanks for this very useful service! However, could the replies have an "In-Reply-To" header so that e-mail clients can put the reply in the same thread as the patch? Happy to create an entry in Bugzilla if this helps. Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189847): https://lists.openembedded.org/g/openembedded-core/message/189847 Mute This Topic: https://lists.openembedded.org/mt/102275009/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [yocto] Yocto Project Status 31 October 2023 (WW44)
Greetings, On 31.10.23 at 13:29, Neal Caidin wrote: Current Dev Position: YP 4.3 M4 (Feature Freeze) Next Deadline: 2nd October 2023 YP 4.3 M4 build date Next Team Meetings: * Bug Triage meeting Thursday November 2, 7:30 am PDT (https://zoom.us/j/454367603?pwd=ZGxoa2ZXL3FkM3Y0bFd5aVpHVVZ6dz09 <https://zoom.us/j/454367603?pwd=ZGxoa2ZXL3FkM3Y0bFd5aVpHVVZ6dz09>) * Weekly Project Engineering Sync Tuesday October 31st at 8 am PDT (https://zoom.us/j/990892712?pwd=cHU1MjhoM2x6ck81bkcrYjRrcmJsUT09 <https://zoom.us/j/990892712?pwd=cHU1MjhoM2x6ck81bkcrYjRrcmJsUT09>) <https://zoom.us/j/990892712> Reminder: this week 8:00 PDT translates to 16:00 CET if I understood correctly. That's one hour earlier because daylight saving time changes happen in Europe 1 week earlier than in the USA. Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189841): https://lists.openembedded.org/g/openembedded-core/message/189841 Mute This Topic: https://lists.openembedded.org/mt/102296935/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v7 8/8] docs: cover devtool ide
loaded into VSCode the cross-toolchain s/cmake-kit/CMake kit/ + can be selected for compiling. The following example shows how the cross-toolchain can be + selected in VSCode. + + + .. code-block:: + + mkdir kit-test + echo "project(foo VERSION 0.1)" > kit-test/CMakeLists.txt + code kit-test + + Ctrl + Shift + P --> CMake: Scan for Kits + Ctrl + Shift + P --> CMake: Select a Kit + Use ``devtool upgrade`` to Create a Version of the Recipe that Supports a Newer Version of the Software --- Good luck for the edits! Could you let me know when the code changes made it to the master branch? This way I know I can merge the documentation too. Thanks again for your work. Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189836): https://lists.openembedded.org/g/openembedded-core/message/189836 Mute This Topic: https://lists.openembedded.org/mt/102285623/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] All new features advertised in the Nanbield release notes?
Dear OE-core contributors, I've reviewed all the commits specific to the Nanbield branch and came up with this draft or the release and migration notes for this upcoming release: * https://docs.yoctoproject.org/next/migration-guides/migration-4.3.html * https://docs.yoctoproject.org/next/migration-guides/release-notes-4.3.html If you made a contribution that is featured in the new release, it would be great if you could check whether it's advertised in the release notes with sufficient detail. I'm pretty sure some noteworthy changes didn't catch my attention. In particular, I'm pretty sure that the runqemu changes should be properly summarized, as well at the CVE management ones. This way, new users will be aware of your new feature(s)! Of course, I'm also interested in reviews of the text. Some sections are still empty, but some of them will be filled by our usual scripts when the release is ready. Some of them are also empty because I haven't found any noteworthy changes yet. The latter will be removed if they should indeed be empty. And don't hesitate to send patches against the yocto-docs "master-next" branch! Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189811): https://lists.openembedded.org/g/openembedded-core/message/189811 Mute This Topic: https://lists.openembedded.org/mt/102284588/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 3/5] meta-yocto-bsp/conf/machine: remove SERIAL_CONSOLES_CHECK
Greetings, On 10.10.23 at 14:36, Ross Burton wrote: From: Ross Burton There's no need for this variable anymore, as all consoles listed in SERIAL_CONSOLES are checked for their existence before a getty is started. --- meta-yocto-bsp/conf/machine/beaglebone-yocto.conf | 1 - meta-yocto-bsp/conf/machine/genericx86-64.conf| 1 - 2 files changed, 2 deletions(-) diff --git a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf index 8b67cefef70..9f389711b3b 100644 --- a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf +++ b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf @@ -18,7 +18,6 @@ MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-image kernel-devicetree" do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot virtual/bootloader:do_deploy" SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyO0 115200;ttyAMA0" -SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}" PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto" PREFERRED_VERSION_linux-yocto ?= "6.1%" diff --git a/meta-yocto-bsp/conf/machine/genericx86-64.conf b/meta-yocto-bsp/conf/machine/genericx86-64.conf index 14913ea1f15..f19a1c1527c 100644 --- a/meta-yocto-bsp/conf/machine/genericx86-64.conf +++ b/meta-yocto-bsp/conf/machine/genericx86-64.conf @@ -6,6 +6,5 @@ DEFAULTTUNE ?= "core2-64" require conf/machine/include/x86/tune-core2.inc require conf/machine/include/genericx86-common.inc -SERIAL_CONSOLES_CHECK = "ttyS0" #For runqemu QB_SYSTEM_NAME = "qemu-system-x86_64" Oops, this patch hasn't been taken yet in poky-contrib. Any reason why? Getting rid of SERIAL_CONSOLES_CHECK for good would allow me to remove it from the documentation. Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189801): https://lists.openembedded.org/g/openembedded-core/message/189801 Mute This Topic: https://lists.openembedded.org/mt/101873854/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] oeqa/runtime/cases/parselogs: remove "edgerouter" case
From: Michael Opdenacker The "edgerouter" machine has been removed since https://git.yoctoproject.org/poky/commit/?id=0c64d0e4317e3749f7f7ed9ecd5d08bbb0cedc9e Signed-off-by: Michael Opdenacker --- meta/lib/oeqa/runtime/cases/parselogs.py | 6 -- 1 file changed, 6 deletions(-) diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py b/meta/lib/oeqa/runtime/cases/parselogs.py index a805edd79d..cddb846bdf 100644 --- a/meta/lib/oeqa/runtime/cases/parselogs.py +++ b/meta/lib/oeqa/runtime/cases/parselogs.py @@ -180,12 +180,6 @@ ignore_errors = { 'Failed to load DMC firmware', 'The driver is built-in, so to load the firmware you need to', ] + x86_common, -'edgerouter' : [ -'not creating \'/sys/firmware/fdt\'', -'Failed to find cpu0 device node', -'Fatal server error:', -'Server terminated with error', -] + common_errors, 'beaglebone-yocto' : [ 'Direct firmware load for regulatory.db', 'failed to load regulatory.db', -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189732): https://lists.openembedded.org/g/openembedded-core/message/189732 Mute This Topic: https://lists.openembedded.org/mt/102201826/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] convert-overrides.py: remove "edgerouter" string
From: Michael Opdenacker The "edgerouter" machine has been removed since https://git.yoctoproject.org/poky/commit/?id=0c64d0e4317e3749f7f7ed9ecd5d08bbb0cedc9e Signed-off-by: Michael Opdenacker --- scripts/contrib/convert-overrides.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/contrib/convert-overrides.py b/scripts/contrib/convert-overrides.py index 1939757f1b..14839d9269 100755 --- a/scripts/contrib/convert-overrides.py +++ b/scripts/contrib/convert-overrides.py @@ -39,7 +39,7 @@ args = parser.parse_args() vars = args.override vars += ["append", "prepend", "remove"] vars += ["qemuarm", "qemux86", "qemumips", "qemuppc", "qemuriscv", "qemuall"] -vars += ["genericx86", "edgerouter", "beaglebone-yocto"] +vars += ["genericx86", "beaglebone-yocto"] vars += ["armeb", "arm", "armv5", "armv6", "armv4", "powerpc64", "aarch64", "riscv32", "riscv64", "x86", "mips64", "powerpc"] vars += ["mipsarch", "x86-x32", "mips16e", "microblaze", "e5500-64b", "mipsisa32", "mipsisa64"] vars += ["class-native", "class-target", "class-cross-canadian", "class-cross", "class-devupstream"] -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189731): https://lists.openembedded.org/g/openembedded-core/message/189731 Mute This Topic: https://lists.openembedded.org/mt/102201522/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] CVE work synchronization proposal
Hi Marta On 20.10.23 at 10:36, Marta Rybczynska wrote: Hello everyone, We have a constant flow of work on pending CVEs. During my discussion with multiple people, there is a common need for synchronization of this work to avoid duplication or forgotten fixes. We have a decision on the tooling to make: do we want to create a Bugzilla entry for each new open CVE? An alternative is to use a wiki page (this has been prototyped by Ross) with heavy scripting to automate the tedious part. Today I propose you to use a special wiki page and the following procedure: On the wiki page, always add all additional information after a ; sign to allow scripting. The first part of each line (until ";" ) will be auto-generated. The second part contains information about the issue, like who is investigating or what the situation is. There is a separate list for each branch, as we realize that people concentrate on various branches. Workflow: * Mark name of a person preparing a patch for each branch * If you have additional information (like a link to a patch), add it to the record * If a patch is posted to the mailing list, post a link to it (this will be automated) * When a patch reaches the "next" branch, mark it too (this will be automated too) * When the patch reaches the final branch, the line of the CVE is automatically removed (this is already automated) * The list is (re)generated every day Please have a look at the procedure proposal and how the tracking might look like: https://wiki.yoctoproject.org/wiki/Synchronization_CVEs This looks very useful. Thanks! If I understand correctly, the fact that the beginning of each line is generated automatically is a way to make sure nobody with Wiki write rights can hide a vulnerability by removing it from the list, right? Thanks again Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189538): https://lists.openembedded.org/g/openembedded-core/message/189538 Mute This Topic: https://lists.openembedded.org/mt/102077364/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Detecting unimplemented ptests with heuristics
Hi Yoann On 19.10.23 at 10:00, Yoann Congal wrote: Hi everyone, We recently implemented a way to detect recipes for upstream code that contain unit tests but does not implement ptests. Those recipes make good candidates for increasing the ptests coverage. This is implemented as a QA check. The check is disabled by default since it generates a lot of warning at build. In order to activate it (in local.conf for exemple) : WARN_QA += "unimplemented-ptest" The warnings looks like: WARNING: time-1.9-r0 do_patch: QA Issue: time: autotools-based tests detected [unimplemented-ptest] I've generated the list for the unimplemented ptests for oe-core and for meta-openembedded: 329 unimplemented-ptests_oe-core.log: https://gist.github.com/ycongal-smile/dd51b0e450a8f0083e9d5cc10eeeb060#file-unimplemented-ptests_oe-core-log 1080 unimplemented-ptests_meta-openembedded.log: https://gist.github.com/ycongal-smile/dd51b0e450a8f0083e9d5cc10eeeb060#file-unimplemented-ptests_meta-openembedded-log Thanks, indeed, I "own" recipes that were flagged :) Maybe, you could find a way to notify the maintainers of such recipes, as in the AUH upgrade status reports (https://lists.openembedded.org/g/openembedded-core/message/188589 for example). Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189469): https://lists.openembedded.org/g/openembedded-core/message/189469 Mute This Topic: https://lists.openembedded.org/mt/102056219/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH 0/4] patchtest: add to oe-core
Hi Trevor On 16.10.23 at 21:44, Trevor Gamblin wrote: Add the patchtest core tools and supporting scripts to openembedded-core. This will enable users to validate their changes locally against the repository before submission to the mailing list, reducing maintainer overhead and encouraging more consistent use of important patch tags and information. Note that there are a few elements of the tooling that are still under development, namely the patchtest-send-results script, which is currently hard-coded to mail test results to test-l...@lists.yoctoproject.org (and only that list), while in the future it may be adjusted to directly reply to user submissions. A scripts/patchtest.README file is included for basic instructions on how to use patchtest, as well as for submitting fixes should any bugs be identified. The Yocto Project Contributor Guide will receive a single, corresponding patch to provide similar details on why and how to use patchtest. Finally, the patchtest layer itself will be reduced to only those pieces that are required for building the core-image-patchtest image, which makes special adjustments to kernel configurations and initscripts that are only suitable for automation, and therefore outside the scope of most contributors' usage. Trevor Gamblin (4): patchtest/requirements.txt: update patchtest: add supporting modules patchtest: add scripts to oe-core patchtest: set default repo and testdir targets meta/lib/patchtest/data.py | 100 meta/lib/patchtest/patch.py | 73 + meta/lib/patchtest/repo.py | 185 ++ meta/lib/patchtest/requirements.txt | 2 + meta/lib/patchtest/utils.py | 179 + scripts/patchtest | 233 scripts/patchtest-get-branch| 92 +++ scripts/patchtest-get-series| 125 +++ scripts/patchtest-send-results | 93 +++ scripts/patchtest-setup-sharedir| 95 scripts/patchtest.README| 156 +++ 11 files changed, 1333 insertions(+) create mode 100644 meta/lib/patchtest/data.py create mode 100644 meta/lib/patchtest/patch.py create mode 100644 meta/lib/patchtest/repo.py create mode 100644 meta/lib/patchtest/utils.py create mode 100755 scripts/patchtest create mode 100755 scripts/patchtest-get-branch create mode 100755 scripts/patchtest-get-series create mode 100755 scripts/patchtest-send-results create mode 100755 scripts/patchtest-setup-sharedir create mode 100644 scripts/patchtest.README Thanks for this! I tried "patchtest --patch" with the attached patch, which had its "Signed-off-by" line intentionally removed. However, it didn't find the issue (see the attached log). Did I miss anything in the way I use it? Thanks again Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From 2e1d43af896722a8788be102df1b975819ecf678 Mon Sep 17 00:00:00 2001 From: Michael Opdenacker Date: Tue, 17 Oct 2023 15:07:09 +0200 Subject: [PATCH] brief-yoctoprojectqs: use new CDN mirror for sstate Recommended instead of the Yocto Project mirror, because expected to be faster. Make sure you only set one such mirror. CC: richard.pur...@linuxfoundation.org --- documentation/brief-yoctoprojectqs/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/documentation/brief-yoctoprojectqs/index.rst b/documentation/brief-yoctoprojectqs/index.rst index 0ccffccc60..df8d75edc2 100644 --- a/documentation/brief-yoctoprojectqs/index.rst +++ b/documentation/brief-yoctoprojectqs/index.rst @@ -254,7 +254,7 @@ an entire Linux distribution, including the toolchain, from source. BB_SIGNATURE_HANDLER = "OEEquivHash" BB_HASHSERVE = "auto" BB_HASHSERVE_UPSTREAM = "hashserv.yocto.io:8687" - SSTATE_MIRRORS ?= "file://.* https://sstate.yoctoproject.org/all/PATH;downloadfilename=PATH; + SSTATE_MIRRORS ?= "file://.* http://cdn.jsdelivr.net/yocto/sstate/all/PATH;downloadfilename=PATH; #. **Start the Build:** Continue with the following command to build an OS image for the target, which is ``core-image-sato`` in this example: -- 2.34.1 Testing patch /home/mike/work/git/git.yoctoproject.org/yocto-docs/documentation/0001-brief-yoctoprojectqs-use-new-CDN-mirror-for-sstate.patch NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None NoneType: None None -- Ran 18 tests in 0.403s OK NoneType: None None NoneType: None None
[OE-core] [dunfell][PATCH v2] flac: fix CVE-2020-22219
From: Michael Opdenacker Buffer Overflow vulnerability in function bitwriter_grow_ in flac before 1.4.0 allows remote attackers to run arbitrary code via crafted input to the encoder. Signed-off-by: Meenali Gupta Signed-off-by: Michael Opdenacker Tested-by: Michael Opdenacker --- Changes in V2: - include the patch this time! --- .../flac/files/CVE-2020-22219.patch | 197 ++ meta/recipes-multimedia/flac/flac_1.3.3.bb| 1 + 2 files changed, 198 insertions(+) create mode 100644 meta/recipes-multimedia/flac/files/CVE-2020-22219.patch diff --git a/meta/recipes-multimedia/flac/files/CVE-2020-22219.patch b/meta/recipes-multimedia/flac/files/CVE-2020-22219.patch new file mode 100644 index 00..e042872dc0 --- /dev/null +++ b/meta/recipes-multimedia/flac/files/CVE-2020-22219.patch @@ -0,0 +1,197 @@ +From 579ff6922089cbbbd179619e40e622e279bd719f Mon Sep 17 00:00:00 2001 +From: Martijn van Beurden +Date: Wed, 3 Aug 2022 13:52:19 +0200 +Subject: [PATCH] flac: Add and use _nofree variants of safe_realloc functions + +Parts of the code use realloc like + +x = safe_realloc(x, somesize); + +when this is the case, the safe_realloc variant used must free the +old memory block in case it fails, otherwise it will leak. However, +there are also instances in the code where handling is different: + +if (0 == (x = safe_realloc(y, somesize))) +return false + +in this case, y should not be freed, as y is not set to NULL we +could encounter double frees. Here the safe_realloc_nofree +functions are used. + +Upstream-Status: Backport [https://github.com/xiph/flac/commit/21fe95ee828b0b9b944f6aa0bb02d24fbb981815] +CVE: CVE-2020-22219 + +Signed-off-by: Meenali Gupta +--- + include/share/alloc.h | 41 +++ + src/flac/encode.c | 4 ++-- + src/flac/foreign_metadata.c | 2 +- + src/libFLAC/bitwriter.c | 2 +- + src/libFLAC/metadata_object.c | 2 +- + src/plugin_common/tags.c | 2 +- + src/share/utf8/iconvert.c | 2 +- + 7 files changed, 44 insertions(+), 11 deletions(-) + +diff --git a/include/share/alloc.h b/include/share/alloc.h +index 914de9b..55bdd1d 100644 +--- a/include/share/alloc.h b/include/share/alloc.h +@@ -161,17 +161,30 @@ static inline void *safe_realloc_(void *ptr, size_t size) + free(oldptr); + return newptr; + } +-static inline void *safe_realloc_add_2op_(void *ptr, size_t size1, size_t size2) ++static inline void *safe_realloc_nofree_add_2op_(void *ptr, size_t size1, size_t size2) ++{ ++ size2 += size1; ++ if(size2 < size1) ++ return 0; ++ return realloc(ptr, size2); ++} ++ ++static inline void *safe_realloc_add_3op_(void *ptr, size_t size1, size_t size2, size_t size3) + { + size2 += size1; + if(size2 < size1) { + free(ptr); + return 0; + } +- return realloc(ptr, size2); ++ size3 += size2; ++ if(size3 < size2) { ++ free(ptr); ++ return 0; ++ } ++ return safe_realloc_(ptr, size3); + } + +-static inline void *safe_realloc_add_3op_(void *ptr, size_t size1, size_t size2, size_t size3) ++static inline void *safe_realloc_nofree_add_3op_(void *ptr, size_t size1, size_t size2, size_t size3) + { + size2 += size1; + if(size2 < size1) +@@ -182,7 +195,7 @@ static inline void *safe_realloc_add_3op_(void *ptr, size_t size1, size_t size2, + return realloc(ptr, size3); + } + +-static inline void *safe_realloc_add_4op_(void *ptr, size_t size1, size_t size2, size_t size3, size_t size4) ++static inline void *safe_realloc_nofree_add_4op_(void *ptr, size_t size1, size_t size2, size_t size3, size_t size4) + { + size2 += size1; + if(size2 < size1) +@@ -205,6 +218,15 @@ static inline void *safe_realloc_mul_2op_(void *ptr, size_t size1, size_t size2) + return safe_realloc_(ptr, size1*size2); + } + ++static inline void *safe_realloc_nofree_mul_2op_(void *ptr, size_t size1, size_t size2) ++{ ++ if(!size1 || !size2) ++ return realloc(ptr, 0); /* preserve POSIX realloc(ptr, 0) semantics */ ++ if(size1 > SIZE_MAX / size2) ++ return 0; ++ return realloc(ptr, size1*size2); ++} ++ + /* size1 * (size2 + size3) */ + static inline void *safe_realloc_muladd2_(void *ptr, size_t size1, size_t size2, size_t size3) + { +@@ -216,4 +238,15 @@ static inline void *safe_realloc_muladd2_(void *ptr, size_t size1, size_t size2, + return safe_realloc_mul_2op_(ptr, size1, size2); + } + ++/* size1 * (size2 + size3) */ ++static inline void *safe_realloc_nofree_muladd2_(void *ptr, size_t size1, size_t size2, size_t size3) ++{ ++ if(!size1 || (!size2 && !size3)) ++ return realloc(ptr, 0); /* preserve POSIX realloc(ptr, 0) semantics */ ++ size2 += size3; ++ if(size2 < size3) ++ return 0; ++ return safe_realloc_nofree_mul_2op_(ptr, size1,
[OE-core] [PATCH] maintainers.inc: add self for flac recipe
From: Michael Opdenacker Signed-off-by: Michael Opdenacker --- meta/conf/distro/include/maintainers.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc index e977c84fc8..7697324335 100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -173,7 +173,7 @@ RECIPE_MAINTAINER:pn-expect = "Alexander Kanavin " RECIPE_MAINTAINER:pn-ffmpeg = "Alexander Kanavin " RECIPE_MAINTAINER:pn-file = "Yi Zhao " RECIPE_MAINTAINER:pn-findutils = "Chen Qi " -RECIPE_MAINTAINER:pn-flac = "Unassigned " +RECIPE_MAINTAINER:pn-flac = "Michael Opdenacker " RECIPE_MAINTAINER:pn-flex = "Chen Qi " RECIPE_MAINTAINER:pn-font-alias = "Unassigned " RECIPE_MAINTAINER:pn-font-util = "Unassigned " -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#188094): https://lists.openembedded.org/g/openembedded-core/message/188094 Mute This Topic: https://lists.openembedded.org/mt/101518473/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [dunfell][PATCH] flac: fix CVE-2020-22219
From: Michael Opdenacker Buffer Overflow vulnerability in function bitwriter_grow_ in flac before 1.4.0 allows remote attackers to run arbitrary code via crafted input to the encoder. Signed-off-by: Meenali Gupta Signed-off-by: Michael Opdenacker Tested-by: Michael Opdenacker --- meta/recipes-multimedia/flac/flac_1.3.3.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-multimedia/flac/flac_1.3.3.bb b/meta/recipes-multimedia/flac/flac_1.3.3.bb index cb6692aedf..ca04f36d1a 100644 --- a/meta/recipes-multimedia/flac/flac_1.3.3.bb +++ b/meta/recipes-multimedia/flac/flac_1.3.3.bb @@ -15,6 +15,7 @@ LIC_FILES_CHKSUM = "file://COPYING.FDL;md5=ad1419ecc56e060eccf8184a87c4285f \ DEPENDS = "libogg" SRC_URI = "http://downloads.xiph.org/releases/flac/${BP}.tar.xz \ + file://CVE-2020-22219.patch \ " SRC_URI[md5sum] = "26703ed2858c1fc9ffc05136d13daa69" -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#188093): https://lists.openembedded.org/g/openembedded-core/message/188093 Mute This Topic: https://lists.openembedded.org/mt/101518444/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH 2/2] lib/oe/qa: update guidelines link for Upstream-Status
From: Michael Opdenacker Signed-off-by: Michael Opdenacker --- meta/lib/oe/qa.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/lib/oe/qa.py b/meta/lib/oe/qa.py index 94955f78ba..f8ae3c743f 100644 --- a/meta/lib/oe/qa.py +++ b/meta/lib/oe/qa.py @@ -217,7 +217,7 @@ def check_upstream_status(fullpath): import re kinda_status_re = re.compile(r"^.*upstream.*status.*$", re.IGNORECASE | re.MULTILINE) strict_status_re = re.compile(r"^Upstream-Status: (Pending|Submitted|Denied|Inappropriate|Backport|Inactive-Upstream)( .+)?$", re.MULTILINE) -guidelines = "https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status; +guidelines = "https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status; with open(fullpath, encoding='utf-8', errors='ignore') as f: file_content = f.read() -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187992): https://lists.openembedded.org/g/openembedded-core/message/187992 Mute This Topic: https://lists.openembedded.org/mt/101498746/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH 1/2] lib/oe/qa: remove obsolete "Accepted" string for Upstream-Status
From: Michael Opdenacker Replaced by "Backport" since release 3.2 https://docs.yoctoproject.org/migration-guides/migration-3.2.html#miscellaneous-changes Signed-off-by: Michael Opdenacker --- meta/lib/oe/qa.py | 2 +- meta/lib/patchtest/tests/pyparsing/parse_upstream_status.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/lib/oe/qa.py b/meta/lib/oe/qa.py index de980638c4..94955f78ba 100644 --- a/meta/lib/oe/qa.py +++ b/meta/lib/oe/qa.py @@ -216,7 +216,7 @@ def exit_if_errors(d): def check_upstream_status(fullpath): import re kinda_status_re = re.compile(r"^.*upstream.*status.*$", re.IGNORECASE | re.MULTILINE) -strict_status_re = re.compile(r"^Upstream-Status: (Pending|Submitted|Denied|Accepted|Inappropriate|Backport|Inactive-Upstream)( .+)?$", re.MULTILINE) +strict_status_re = re.compile(r"^Upstream-Status: (Pending|Submitted|Denied|Inappropriate|Backport|Inactive-Upstream)( .+)?$", re.MULTILINE) guidelines = "https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status; with open(fullpath, encoding='utf-8', errors='ignore') as f: diff --git a/meta/lib/patchtest/tests/pyparsing/parse_upstream_status.py b/meta/lib/patchtest/tests/pyparsing/parse_upstream_status.py index 511b36d033..d63567efbe 100644 --- a/meta/lib/patchtest/tests/pyparsing/parse_upstream_status.py +++ b/meta/lib/patchtest/tests/pyparsing/parse_upstream_status.py @@ -8,8 +8,8 @@ import common import pyparsing -upstream_status_literal_valid_status = ["Pending", "Accepted", "Backport", "Denied", "Inappropriate", "Submitted"] -upstream_status_nonliteral_valid_status = ["Pending", "Accepted", "Backport", "Denied", "Inappropriate [reason]", "Submitted [where]"] +upstream_status_literal_valid_status = ["Pending", "Backport", "Denied", "Inappropriate", "Submitted"] +upstream_status_nonliteral_valid_status = ["Pending", "Backport", "Denied", "Inappropriate [reason]", "Submitted [where]"] upstream_status_valid_status = pyparsing.Or( [pyparsing.Literal(status) for status in upstream_status_literal_valid_status] -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187991): https://lists.openembedded.org/g/openembedded-core/message/187991 Mute This Topic: https://lists.openembedded.org/mt/101498745/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH 2/2] libevent: fix patch Upstream-Status
From: Michael Opdenacker Signed-off-by: Michael Opdenacker --- ...test-retriable-tests-are-marked-failed-only-when-all-a.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-support/libevent/libevent/0004-test-retriable-tests-are-marked-failed-only-when-all-a.patch b/meta/recipes-support/libevent/libevent/0004-test-retriable-tests-are-marked-failed-only-when-all-a.patch index ea17e876ea..26b707ad31 100644 --- a/meta/recipes-support/libevent/libevent/0004-test-retriable-tests-are-marked-failed-only-when-all-a.patch +++ b/meta/recipes-support/libevent/libevent/0004-test-retriable-tests-are-marked-failed-only-when-all-a.patch @@ -6,7 +6,7 @@ Subject: [PATCH] test: retriable tests are marked failed only when all Fixes: #1193 -Upstream-Status: Accepted +Upstream-Status: Backport [https://github.com/libevent/libevent/commit/3daebf308a01b4b2d3fb867be3d6631f7b5a2dbb] Signed-off-by: Thomas Perrot --- -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187911): https://lists.openembedded.org/g/openembedded-core/message/187911 Mute This Topic: https://lists.openembedded.org/mt/101474975/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH 1/2] shadow: fix patch Upstream-Status
From: Michael Opdenacker Replace "Accepted" by "Backport" as specified on https://docs.yoctoproject.org/migration-guides/migration-3.2.html#miscellaneous-changes Signed-off-by: Michael Opdenacker --- .../shadow/files/0001-Fix-can-not-print-full-login.patch| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-extended/shadow/files/0001-Fix-can-not-print-full-login.patch b/meta/recipes-extended/shadow/files/0001-Fix-can-not-print-full-login.patch index 37ba5f3dc2..89f9c05c8d 100644 --- a/meta/recipes-extended/shadow/files/0001-Fix-can-not-print-full-login.patch +++ b/meta/recipes-extended/shadow/files/0001-Fix-can-not-print-full-login.patch @@ -7,7 +7,7 @@ Date: Tue Dec 27 17:40:17 2022 +0530 Login timed out message prints only first few bytes when write is immediately followed by exit. Calling exit from new handler provides enough time to display full message. -Upstream-Status: Accepted [https://github.com/shadow-maint/shadow/commit/670cae834827a8f794e6f7464fa57790d911b63c] +Upstream-Status: Backport [https://github.com/shadow-maint/shadow/commit/670cae834827a8f794e6f7464fa57790d911b63c] diff --git a/src/login.c b/src/login.c index 116e2cb3..c55f4de0 100644 -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187910): https://lists.openembedded.org/g/openembedded-core/message/187910 Mute This Topic: https://lists.openembedded.org/mt/101474974/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH 2/2] alsa-utils: update patch Upstream-Status
From: Michael Opdenacker Signed-off-by: Michael Opdenacker --- .../0001-nhlt-nhlt-dmic-info.c-include-sys-types.h.patch| 2 +- .../alsa/alsa-utils/0001-topology.c-include-locale.h.patch | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-multimedia/alsa/alsa-utils/0001-nhlt-nhlt-dmic-info.c-include-sys-types.h.patch b/meta/recipes-multimedia/alsa/alsa-utils/0001-nhlt-nhlt-dmic-info.c-include-sys-types.h.patch index 43497e3d76..0ebf98b41e 100644 --- a/meta/recipes-multimedia/alsa/alsa-utils/0001-nhlt-nhlt-dmic-info.c-include-sys-types.h.patch +++ b/meta/recipes-multimedia/alsa/alsa-utils/0001-nhlt-nhlt-dmic-info.c-include-sys-types.h.patch @@ -8,7 +8,7 @@ nhlt-dmic-info.c: error: unknown type name 'u_int8_t' https://github.com/alsa-project/alsa-utils/issues/238 -Upstream-Status: Submitted [alsa-de...@alsa-project.org] +Upstream-Status: Backport [https://github.com/alsa-project/alsa-utils/commit/0925ad7f09b2dc77015784f9ac2f5e34dd0dd5c3] Signed-off-by: Michael Opdenacker --- nhlt/nhlt-dmic-info.c | 1 + diff --git a/meta/recipes-multimedia/alsa/alsa-utils/0001-topology.c-include-locale.h.patch b/meta/recipes-multimedia/alsa/alsa-utils/0001-topology.c-include-locale.h.patch index a4b1decceb..e1c7470356 100644 --- a/meta/recipes-multimedia/alsa/alsa-utils/0001-topology.c-include-locale.h.patch +++ b/meta/recipes-multimedia/alsa/alsa-utils/0001-topology.c-include-locale.h.patch @@ -8,7 +8,7 @@ topology.c: error: 'LC_ALL' undeclared https://github.com/alsa-project/alsa-utils/issues/239 -Upstream-Status: Submitted [alsa-de...@alsa-project.org] +Upstream-Status: Backport [https://github.com/alsa-project/alsa-utils/commit/8c229270f6bae83b705a03714c46067a7aa57b02] Signed-off-by: Michael Opdenacker --- topology/topology.c | 1 + -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187907): https://lists.openembedded.org/g/openembedded-core/message/187907 Mute This Topic: https://lists.openembedded.org/mt/101474805/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH 1/2] alsa-lib: fix patch Upstream-Status
From: Michael Opdenacker Using "Backport" instead of "Accepted", as instructed on https://docs.yoctoproject.org/migration-guides/migration-3.2.html#miscellaneous-changes Signed-off-by: Michael Opdenacker --- ...1-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch b/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch index a75300f51f..9a7ba0d847 100644 --- a/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch +++ b/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch @@ -13,7 +13,7 @@ control.c: In function 'snd_ctl_open_conf': |^~~~ Fixes: https://github.com/alsa-project/alsa-lib/issues/350 -Upstream-Status: Accepted +Upstream-Status: Backport [https://github.com/alsa-project/alsa-lib/commit/10bd599970acc71c92f85eb08943eb8d3d702a9c] Signed-off-by: Jaroslav Kysela --- include/global.h | 10 +- -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187906): https://lists.openembedded.org/g/openembedded-core/message/187906 Mute This Topic: https://lists.openembedded.org/mt/101474804/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH v2 2/2] alsa-utils: upgrade 1.2.9 -> 1.2.10
From: Michael Opdenacker Changelog: - po: add Korean translations - alsactl: fix compilation when building in a subdir - reshuffle included files to include config.h as first - github: update build.yml - aseqdump: fix MIDI 2.0 code - it compiles now - gitcompile: set more verbose compilation warnings - nhlt-dmic-info: fix the verbose compilation warnings for latest gcc - alsaucm: fix the verbose compilation warnings for latest gcc - aplaymidi: fix the verbose compilation warnings for latest gcc - aseqnet: fix the verbose compilation warnings for latest gcc - aseqdump: fix the verbose compilation warnings for latest gcc - aconnect: fix the verbose compilation warnings for latest gcc - speaker-test: fix the verbose compilation warnings for latest gcc - amidi: fix the verbose compilation warnings for latest gcc - bat: fix the verbose compilation warnings for latest gcc - iecset: fix the verbose compilation warnings for latest gcc - alsamixer: fix the verbose compilation warnings for latest gcc - alsaloop: fix the verbose compilation warnings for latest gcc - axfer: fix the verbose compilation warnings for latest gcc - alsactl: fix the verbose compilation warnings for latest gcc - amixer: fix the verbose compilation warnings for latest gcc - aplay: fix the verbose compilation warnings for latest gcc - topology: fix the verbose compilation warnings for latest gcc - alsactl: fix the copy-n-paste typo (SND_RAWMIDI_STREAM_*) - aseqdump: Add options to switch view mode - aseqdump: Correct wrong channel number - aseqdump: Align outputs of UMP MIDI 1.0 with legacy MIDI 1.0 - speaker-test: allow large buffer and period time setup - up to 100 seconds - topology: plugins: nhlt: remove dmic error print - Topology: NHLT: Intel: Update DMIC FIR coefficients - topology: nhlt: intel: support more device types and directions - topology: pre-processor: Add support for CombineArrays - alsactl: add define to compile with glibc 2.38 - topology: plugins: nhlt: set dmic stereo mode only in hw version 1 - aplaymidi: Add UMP support - aconnect: Add UMP support - aseqdump: Add UMP support - nhlt: add nhlt-dmic-info utility Signed-off-by: Michael Opdenacker --- Changes in V2: - 0001-nhlt-nhlt-dmic-info.c-include-sys-types.h.patch, 0001-topology.c-include-locale.h.patch: Upstream-Status: replace "Submitted" by "Backport", as the patches were quickly accepted by the maintainer. 0001-nhlt-nhlt-dmic-info.c-include-sys-types.h.patch# --- ...dd-define-to-compile-with-glibc-2.38.patch | 39 --- ...ompilation-when-building-in-a-subdir.patch | 35 - ...nhlt-dmic-info.c-include-sys-types.h.patch | 31 +++ .../0001-topology.c-include-locale.h.patch| 31 +++ ...sa-utils_1.2.9.bb => alsa-utils_1.2.10.bb} | 11 -- 5 files changed, 69 insertions(+), 78 deletions(-) delete mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-add-define-to-compile-with-glibc-2.38.patch delete mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch create mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-nhlt-nhlt-dmic-info.c-include-sys-types.h.patch create mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-topology.c-include-locale.h.patch rename meta/recipes-multimedia/alsa/{alsa-utils_1.2.9.bb => alsa-utils_1.2.10.bb} (93%) diff --git a/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-add-define-to-compile-with-glibc-2.38.patch b/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-add-define-to-compile-with-glibc-2.38.patch deleted file mode 100644 index 8c23fb2cec..00 --- a/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-add-define-to-compile-with-glibc-2.38.patch +++ /dev/null @@ -1,39 +0,0 @@ -From a610f4c21b083c0f9cf62ad2251dfadc98abb50e Mon Sep 17 00:00:00 2001 -From: Rudi Heitbaum -Date: Sat, 22 Jul 2023 15:36:09 + -Subject: [PATCH] alsactl: add define to compile with glibc 2.38 - -strlcat and strlcpy have been added to glibc 2.38. -update the defines to use the glibc versions, and not conflict with -string.h. - -ref: -- https://sourceware.org/git/?p=glibc.git;a=commit;h=454a20c8756c9c1d55419153255fc7692b3d2199 - -Fixes: https://github.com/alsa-project/alsa-utils/pull/225 -Signed-off-by: Jaroslav Kysela -Signed-off-by: Martin Jansa - -Upstream-Status: Backport [https://github.com/alsa-project/alsa-utils/commit/d6a71bfbde9e1710743d3a446c6ea3b41c45234e] - alsactl/init_sysdeps.c | 2 ++ - 1 file changed, 2 insertions(+) - -diff --git a/alsactl/init_sysdeps.c b/alsactl/init_sysdeps.c -index 3aca1b4..f09b1ae 100644 a/alsactl/init_sysdeps.c -+++ b/alsactl/init_sysdeps.c -@@ -18,6 +18,7 @@ - */ - - #if defined(__GLIBC__) && !(defined(__UCLIBC__) && defined(__USE_BSD)) -+#if !(__GLIBC_PREREQ(2, 38)) - static size_t strlcpy(char *dst, const char *src, size_t size) - { - size_t bytes = 0; -@@ -60,4 +61,5 @@ s
[OE-core] [PATCH v2 1/2] alsa-lib: upgrade 1.2.9 -> 1.2.10
From: Michael Opdenacker Changelog: - Fix symver build error on non-ELF platforms - ucm: main - remove cast to pointer from integer of different size warning - ucm: mark internal functions static - topology: fix src/mixer/mixer.c return value warning - dogyxen: fix topology.h warnings - doxygen: fix broken examples links - doxygen: include docs for shmarea functions - doxygen: conf: do not hide PCM specific function - doxygen: silence warning from asoundlib.h - doxygen: ucm: silence warnings - doxygen: topology: silence 'not documented' warnings - doxygen: global: silence 'not documented' warnings - doxygen: namehint: silence 'not documented' warnings - doxygen: seq: silence 'not documented' warnings - doxygen: conf: silence 'not documented' warnings - doxygen: rawmidi: silence 'not documented' warnings - doxygen: control: silence 'not documented' item warnings - doxygen: pcm: silence 'not documented' warnings - doxygen: include external control docs - doxygen: fix inadvertent link requests - doxygen: fix list indentation errors - doxygen: escape xml tags - doxygen: fix image path - doxygen: fix broken parameter name tags - doxygen: Fix missing group end markers - reshuffle included files to include config.h as first - configure: add AC_SYS_LARGEFILE - seq: Fix wrong seq version update at snd_seq_hw_get_client_info() - seq: Add overflow check in snd_seq_ev_set_ump_data() - test: oldapi - fix the clang-16 compilation error - rawmidi: Suppress error messages for non-fatal errors - seq: ump: Fix typo in function name containing "group" - pcm: hw: fix minor bug in sw_params ioctl - seq: Add UMP 1.1 features - ump: Add UMP 1.1 features - uapi: Update rawmidi API to 2.0.4 - seq: Add UMP support - uapi: Update asequencer.h definitions for 1.0.3 - ump: Add helpers for handling SysEx data - ump: Add helpers to parse / set UMP packet data - control: Add UMP Endpoint and Block info query support - control: Add UMP device query support -- ump: Add initial support - rawmidi: Add UMP ioctl support - uapi: Update control API to 2.0.9 - uapi: Update rawmidi API to 2.0.3 - remove extra trailing new line in SNDMSG and SNDERR calls - usecase: add CaptureMicInfoFile field to documentation - include: fix SND_DLSYM_BUILD_VERSION() for static build - pcm: hw - prevent divide by zero for broken apps Signed-off-by: Michael Opdenacker --- Changes in V2: - 0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch Upstream-Status: replace "Accepted" (obsolete) by "Backport" --- ...STRING-macro-outside-PIC-ifdef-block.patch | 52 +++ .../{alsa-lib_1.2.9.bb => alsa-lib_1.2.10.bb} | 6 ++- 2 files changed, 56 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch rename meta/recipes-multimedia/alsa/{alsa-lib_1.2.9.bb => alsa-lib_1.2.10.bb} (88%) diff --git a/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch b/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch new file mode 100644 index 00..9a7ba0d847 --- /dev/null +++ b/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch @@ -0,0 +1,52 @@ +From 10bd599970acc71c92f85eb08943eb8d3d702a9c Mon Sep 17 00:00:00 2001 +From: Michael Opdenacker +Date: Wed, 6 Sep 2023 15:16:44 +0200 +Subject: [PATCH] global.h: move __STRING() macro outside !PIC ifdef block + +From: Jaroslav Kysela + +It solves the musl libc compilation issue. + +control.c: In function 'snd_ctl_open_conf': +../../include/global.h:98:36: warning: implicit declaration of function '__STRING' [-Wimplicit-function-declaratio] + 98 | #define SND_DLSYM_VERSION(version) __STRING(version) + |^~~~ + +Fixes: https://github.com/alsa-project/alsa-lib/issues/350 +Upstream-Status: Backport [https://github.com/alsa-project/alsa-lib/commit/10bd599970acc71c92f85eb08943eb8d3d702a9c] +Signed-off-by: Jaroslav Kysela +--- + include/global.h | 10 +- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/include/global.h b/include/global.h +index dfe9bc2b..3ecaeee8 100644 +--- a/include/global.h b/include/global.h +@@ -51,6 +51,11 @@ const char *snd_asoundlib_version(void); + #define ATTRIBUTE_UNUSED __attribute__ ((__unused__)) + #endif + ++#ifndef __STRING ++/** \brief Return 'x' argument as string */ ++#define __STRING(x) #x ++#endif ++ + #ifdef PIC /* dynamic build */ + + /** \hideinitializer \brief Helper macro for #SND_DLSYM_BUILD_VERSION. */ +@@ -71,11 +76,6 @@ struct snd_dlsym_link { + + extern struct snd_dlsym_link *snd_dlsym_start; + +-#ifndef __STRING +-/** \brief Return 'x' argument as string */ +-#define __STRING(x) #x +-#endif +- + /** \hideinitializer \brief Helper macro for #SND_DLSYM_BUILD_VERSION. */ + #define __SND
[OE-core] [PATCH 2/2] alsa-utils: upgrade 1.2.9 -> 1.2.10
From: Michael Opdenacker Changelog: - po: add Korean translations - alsactl: fix compilation when building in a subdir - reshuffle included files to include config.h as first - github: update build.yml - aseqdump: fix MIDI 2.0 code - it compiles now - gitcompile: set more verbose compilation warnings - nhlt-dmic-info: fix the verbose compilation warnings for latest gcc - alsaucm: fix the verbose compilation warnings for latest gcc - aplaymidi: fix the verbose compilation warnings for latest gcc - aseqnet: fix the verbose compilation warnings for latest gcc - aseqdump: fix the verbose compilation warnings for latest gcc - aconnect: fix the verbose compilation warnings for latest gcc - speaker-test: fix the verbose compilation warnings for latest gcc - amidi: fix the verbose compilation warnings for latest gcc - bat: fix the verbose compilation warnings for latest gcc - iecset: fix the verbose compilation warnings for latest gcc - alsamixer: fix the verbose compilation warnings for latest gcc - alsaloop: fix the verbose compilation warnings for latest gcc - axfer: fix the verbose compilation warnings for latest gcc - alsactl: fix the verbose compilation warnings for latest gcc - amixer: fix the verbose compilation warnings for latest gcc - aplay: fix the verbose compilation warnings for latest gcc - topology: fix the verbose compilation warnings for latest gcc - alsactl: fix the copy-n-paste typo (SND_RAWMIDI_STREAM_*) - aseqdump: Add options to switch view mode - aseqdump: Correct wrong channel number - aseqdump: Align outputs of UMP MIDI 1.0 with legacy MIDI 1.0 - speaker-test: allow large buffer and period time setup - up to 100 seconds - topology: plugins: nhlt: remove dmic error print - Topology: NHLT: Intel: Update DMIC FIR coefficients - topology: nhlt: intel: support more device types and directions - topology: pre-processor: Add support for CombineArrays - alsactl: add define to compile with glibc 2.38 - topology: plugins: nhlt: set dmic stereo mode only in hw version 1 - aplaymidi: Add UMP support - aconnect: Add UMP support - aseqdump: Add UMP support - nhlt: add nhlt-dmic-info utility Signed-off-by: Michael Opdenacker --- ...dd-define-to-compile-with-glibc-2.38.patch | 39 --- ...ompilation-when-building-in-a-subdir.patch | 35 - ...nhlt-dmic-info.c-include-sys-types.h.patch | 31 +++ .../0001-topology.c-include-locale.h.patch| 31 +++ ...sa-utils_1.2.9.bb => alsa-utils_1.2.10.bb} | 11 -- 5 files changed, 69 insertions(+), 78 deletions(-) delete mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-add-define-to-compile-with-glibc-2.38.patch delete mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch create mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-nhlt-nhlt-dmic-info.c-include-sys-types.h.patch create mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-topology.c-include-locale.h.patch rename meta/recipes-multimedia/alsa/{alsa-utils_1.2.9.bb => alsa-utils_1.2.10.bb} (93%) diff --git a/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-add-define-to-compile-with-glibc-2.38.patch b/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-add-define-to-compile-with-glibc-2.38.patch deleted file mode 100644 index 8c23fb2cec..00 --- a/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-add-define-to-compile-with-glibc-2.38.patch +++ /dev/null @@ -1,39 +0,0 @@ -From a610f4c21b083c0f9cf62ad2251dfadc98abb50e Mon Sep 17 00:00:00 2001 -From: Rudi Heitbaum -Date: Sat, 22 Jul 2023 15:36:09 + -Subject: [PATCH] alsactl: add define to compile with glibc 2.38 - -strlcat and strlcpy have been added to glibc 2.38. -update the defines to use the glibc versions, and not conflict with -string.h. - -ref: -- https://sourceware.org/git/?p=glibc.git;a=commit;h=454a20c8756c9c1d55419153255fc7692b3d2199 - -Fixes: https://github.com/alsa-project/alsa-utils/pull/225 -Signed-off-by: Jaroslav Kysela -Signed-off-by: Martin Jansa - -Upstream-Status: Backport [https://github.com/alsa-project/alsa-utils/commit/d6a71bfbde9e1710743d3a446c6ea3b41c45234e] - alsactl/init_sysdeps.c | 2 ++ - 1 file changed, 2 insertions(+) - -diff --git a/alsactl/init_sysdeps.c b/alsactl/init_sysdeps.c -index 3aca1b4..f09b1ae 100644 a/alsactl/init_sysdeps.c -+++ b/alsactl/init_sysdeps.c -@@ -18,6 +18,7 @@ - */ - - #if defined(__GLIBC__) && !(defined(__UCLIBC__) && defined(__USE_BSD)) -+#if !(__GLIBC_PREREQ(2, 38)) - static size_t strlcpy(char *dst, const char *src, size_t size) - { - size_t bytes = 0; -@@ -60,4 +61,5 @@ static size_t strlcat(char *dst, const char *src, size_t size) - *q = '\0'; - return bytes; - } -+#endif /* !(__GLIBC_PREREQ(2, 38)) */ - #endif /* __GLIBC__ */ diff --git a/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch b/meta/recipes-mult
[OE-core] [PATCH 1/2] alsa-lib: upgrade 1.2.9 -> 1.2.10
From: Michael Opdenacker Changelog: - Fix symver build error on non-ELF platforms - ucm: main - remove cast to pointer from integer of different size warning - ucm: mark internal functions static - topology: fix src/mixer/mixer.c return value warning - dogyxen: fix topology.h warnings - doxygen: fix broken examples links - doxygen: include docs for shmarea functions - doxygen: conf: do not hide PCM specific function - doxygen: silence warning from asoundlib.h - doxygen: ucm: silence warnings - doxygen: topology: silence 'not documented' warnings - doxygen: global: silence 'not documented' warnings - doxygen: namehint: silence 'not documented' warnings - doxygen: seq: silence 'not documented' warnings - doxygen: conf: silence 'not documented' warnings - doxygen: rawmidi: silence 'not documented' warnings - doxygen: control: silence 'not documented' item warnings - doxygen: pcm: silence 'not documented' warnings - doxygen: include external control docs - doxygen: fix inadvertent link requests - doxygen: fix list indentation errors - doxygen: escape xml tags - doxygen: fix image path - doxygen: fix broken parameter name tags - doxygen: Fix missing group end markers - reshuffle included files to include config.h as first - configure: add AC_SYS_LARGEFILE - seq: Fix wrong seq version update at snd_seq_hw_get_client_info() - seq: Add overflow check in snd_seq_ev_set_ump_data() - test: oldapi - fix the clang-16 compilation error - rawmidi: Suppress error messages for non-fatal errors - seq: ump: Fix typo in function name containing "group" - pcm: hw: fix minor bug in sw_params ioctl - seq: Add UMP 1.1 features - ump: Add UMP 1.1 features - uapi: Update rawmidi API to 2.0.4 - seq: Add UMP support - uapi: Update asequencer.h definitions for 1.0.3 - ump: Add helpers for handling SysEx data - ump: Add helpers to parse / set UMP packet data - control: Add UMP Endpoint and Block info query support - control: Add UMP device query support -- ump: Add initial support - rawmidi: Add UMP ioctl support - uapi: Update control API to 2.0.9 - uapi: Update rawmidi API to 2.0.3 - remove extra trailing new line in SNDMSG and SNDERR calls - usecase: add CaptureMicInfoFile field to documentation - include: fix SND_DLSYM_BUILD_VERSION() for static build - pcm: hw - prevent divide by zero for broken apps Signed-off-by: Michael Opdenacker --- ...STRING-macro-outside-PIC-ifdef-block.patch | 52 +++ .../{alsa-lib_1.2.9.bb => alsa-lib_1.2.10.bb} | 6 ++- 2 files changed, 56 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch rename meta/recipes-multimedia/alsa/{alsa-lib_1.2.9.bb => alsa-lib_1.2.10.bb} (88%) diff --git a/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch b/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch new file mode 100644 index 00..a75300f51f --- /dev/null +++ b/meta/recipes-multimedia/alsa/alsa-lib/0001-global.h-move-__STRING-macro-outside-PIC-ifdef-block.patch @@ -0,0 +1,52 @@ +From 10bd599970acc71c92f85eb08943eb8d3d702a9c Mon Sep 17 00:00:00 2001 +From: Michael Opdenacker +Date: Wed, 6 Sep 2023 15:16:44 +0200 +Subject: [PATCH] global.h: move __STRING() macro outside !PIC ifdef block + +From: Jaroslav Kysela + +It solves the musl libc compilation issue. + +control.c: In function 'snd_ctl_open_conf': +../../include/global.h:98:36: warning: implicit declaration of function '__STRING' [-Wimplicit-function-declaratio] + 98 | #define SND_DLSYM_VERSION(version) __STRING(version) + |^~~~ + +Fixes: https://github.com/alsa-project/alsa-lib/issues/350 +Upstream-Status: Accepted +Signed-off-by: Jaroslav Kysela +--- + include/global.h | 10 +- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/include/global.h b/include/global.h +index dfe9bc2b..3ecaeee8 100644 +--- a/include/global.h b/include/global.h +@@ -51,6 +51,11 @@ const char *snd_asoundlib_version(void); + #define ATTRIBUTE_UNUSED __attribute__ ((__unused__)) + #endif + ++#ifndef __STRING ++/** \brief Return 'x' argument as string */ ++#define __STRING(x) #x ++#endif ++ + #ifdef PIC /* dynamic build */ + + /** \hideinitializer \brief Helper macro for #SND_DLSYM_BUILD_VERSION. */ +@@ -71,11 +76,6 @@ struct snd_dlsym_link { + + extern struct snd_dlsym_link *snd_dlsym_start; + +-#ifndef __STRING +-/** \brief Return 'x' argument as string */ +-#define __STRING(x) #x +-#endif +- + /** \hideinitializer \brief Helper macro for #SND_DLSYM_BUILD_VERSION. */ + #define __SND_DLSYM_VERSION(prefix, name, version) _ ## prefix ## name ## version + /** +-- +2.34.1 + diff --git a/meta/recipes-multimedia/alsa/alsa-lib_1.2.9.bb b/meta/recipes-multimedia/alsa/alsa-lib_1.2.10.bb similarity index 88% rename from meta/recipes-multimedia/alsa/a
Re: [OE-core] [AUH] alsa-lib: upgrading to 1.2.10 FAILED
Hi Alex On 18.09.23 at 21:13, Alexander Kanavin wrote: On Mon, 18 Sept 2023 at 20:46, Michael Opdenacker wrote: Ah, right, I should have paid attention to the file name. I could reproduce it too. Thanks a lot Alex :) Michael. I think this backport should help: https://github.com/alsa-project/alsa-lib/commit/10bd599970acc71c92f85eb08943eb8d3d702a9c Good catch. Indeed this fixes the issue. I'll send a patch shortly. Many thanks! Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187850): https://lists.openembedded.org/g/openembedded-core/message/187850 Mute This Topic: https://lists.openembedded.org/mt/101386188/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [AUH] alsa-lib: upgrading to 1.2.10 FAILED
On 18.09.23 at 19:16, Alexander Kanavin wrote: On Mon, 18 Sept 2023 at 18:28, Michael Opdenacker via lists.openembedded.org wrote: this email is a notification from the Auto Upgrade Helper that the automatic attempt to upgrade the recipe *alsa-lib* to *1.2.10* has Failed(do_compile). Detailed error information: do_compile failed Ouch, as far as I am concerned, the AUH patch didn't cause any failure on Poky "master". After applying a fix to the alsa-utils 2.10 recipe, I could also build this recipe depending on alsa-lib 1.2.10 and check that "speaker-test" starts. Any advice for cases when you can't reproduce the AUH failures? The failure is with musl, and I easily reproduced it there. The main report itself isn't saying it, but attached log file name should indicate the failing configuration. Ah, right, I should have paid attention to the file name. I could reproduce it too. Thanks a lot Alex :) Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187843): https://lists.openembedded.org/g/openembedded-core/message/187843 Mute This Topic: https://lists.openembedded.org/mt/101386188/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [AUH] alsa-lib: upgrading to 1.2.10 FAILED
Greetings, On 15.09.23 at 20:59, Auto Upgrade Helper wrote: Hello, this email is a notification from the Auto Upgrade Helper that the automatic attempt to upgrade the recipe *alsa-lib* to *1.2.10* has Failed(do_compile). Detailed error information: do_compile failed Ouch, as far as I am concerned, the AUH patch didn't cause any failure on Poky "master". After applying a fix to the alsa-utils 2.10 recipe, I could also build this recipe depending on alsa-lib 1.2.10 and check that "speaker-test" starts. Any advice for cases when you can't reproduce the AUH failures? Thanks in advance Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187836): https://lists.openembedded.org/g/openembedded-core/message/187836 Mute This Topic: https://lists.openembedded.org/mt/101386188/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH v6 12/12] docs: cover devtool ide
ur help with the documentation! Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187489): https://lists.openembedded.org/g/openembedded-core/message/187489 Mute This Topic: https://lists.openembedded.org/mt/101275541/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] base: improve LICENSE_FLAGS_DETAILS output
On 08.09.23 at 13:11, Ross Burton wrote: On 8 Sep 2023, at 12:00, Michael Opdenacker wrote: Hi Ross, I'm currently writing the doc patch for LICENSE_FLAGS_DETAILS. However, I don't find the current behavior optimal... On 21.06.23 at 16:22, ross.bur...@arm.com wrote: From: Ross Burton Don't prefix the output of LICENSE_FLAGS_DETAILS with "For further details, see" so that recipes can put arbitrary text in their license details instead of being limited to a specific sentence structure. Signed-off-by: Ross Burton --- meta/classes-global/base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes-global/base.bbclass b/meta/classes-global/base.bbclass index 976a2ddee4b..cbda8d12f09 100644 --- a/meta/classes-global/base.bbclass +++ b/meta/classes-global/base.bbclass @@ -520,7 +520,7 @@ python () { message = "Has a restricted license '%s' which is not listed in your LICENSE_FLAGS_ACCEPTED." % unmatched details = d.getVarFlag("LICENSE_FLAGS_DETAILS", unmatched) if details: -message += " For further details, see %s." % details +message += details What about message += ' ' + details instead? Otherwise, you have to add a leading space to LICENSE_FLAGS_DETAILS. What do you think? Throwing in a newline or a space seems sensible, yes. Want to send a patch? FWIW the recipes in meta-arm put a newline at the beginning, so adding a blank line if details is set seems fairly sensible. Thanks Ross, good idea! I sent a patch, but been in a rush, forgot to add you to a "Reported-by" line. Thanks again Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187415): https://lists.openembedded.org/g/openembedded-core/message/187415 Mute This Topic: https://lists.openembedded.org/mt/99677069/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] base: add newline before LICENSE_FLAGS_DETAILS
From: Michael Opdenacker To improve readability and avoid putting one inside LICENSE_FLAGS_DETAILS. Signed-off-by: Michael Opdenacker --- Suggested by Ross here: https://lists.openembedded.org/g/openembedded-core/message/187412 --- meta/classes-global/base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes-global/base.bbclass b/meta/classes-global/base.bbclass index 7c774d250f..f57f9cf827 100644 --- a/meta/classes-global/base.bbclass +++ b/meta/classes-global/base.bbclass @@ -527,7 +527,7 @@ python () { message = "Has a restricted license '%s' which is not listed in your LICENSE_FLAGS_ACCEPTED." % unmatched details = d.getVarFlag("LICENSE_FLAGS_DETAILS", unmatched) if details: -message += details +message += "\n" + details bb.debug(1, "Skipping %s: %s" % (pn, message)) raise bb.parse.SkipRecipe(message) -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187414): https://lists.openembedded.org/g/openembedded-core/message/187414 Mute This Topic: https://lists.openembedded.org/mt/101234733/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] base: improve LICENSE_FLAGS_DETAILS output
Hi Ross, I'm currently writing the doc patch for LICENSE_FLAGS_DETAILS. However, I don't find the current behavior optimal... On 21.06.23 at 16:22, ross.bur...@arm.com wrote: From: Ross Burton Don't prefix the output of LICENSE_FLAGS_DETAILS with "For further details, see" so that recipes can put arbitrary text in their license details instead of being limited to a specific sentence structure. Signed-off-by: Ross Burton --- meta/classes-global/base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes-global/base.bbclass b/meta/classes-global/base.bbclass index 976a2ddee4b..cbda8d12f09 100644 --- a/meta/classes-global/base.bbclass +++ b/meta/classes-global/base.bbclass @@ -520,7 +520,7 @@ python () { message = "Has a restricted license '%s' which is not listed in your LICENSE_FLAGS_ACCEPTED." % unmatched details = d.getVarFlag("LICENSE_FLAGS_DETAILS", unmatched) if details: -message += " For further details, see %s." % details +message += details What about message += ' ' + details instead? Otherwise, you have to add a leading space to LICENSE_FLAGS_DETAILS. What do you think? Happy to send a patch if that helps... Cheers Michael. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187411): https://lists.openembedded.org/g/openembedded-core/message/187411 Mute This Topic: https://lists.openembedded.org/mt/99677069/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Status of patchtest tool
Hi Frederic, On 11.08.23 at 07:28, Frederic Martinsons wrote: Hello list Michael recently made a change on contirubing guide talking about patchtest as a tool (quoting him) "to test user contributions before they hit the mailing lists; and looking in my older emails, Alexander also mentioned this tool as a (quoting him) "special bot called patchtest that used to check mailing list submissions for common problems". Can you tell me more about it ? Are we talking about the script patchtest.sh in scripts/contrib of oe-core ? Can you please describe the expectations of this tool . I'm willing to improve it and am ready to work on it if you give me some directions. Actually, Richard wrote the initial text, and I actually wondered... Is the intent to have a tool that contributors can run before sending their patches, and that a bot can run on mailing list submissions too? Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#185827): https://lists.openembedded.org/g/openembedded-core/message/185827 Mute This Topic: https://lists.openembedded.org/mt/100678742/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Keep scripts/create-pull-request and send-pull-request ?
Hello, On 10.08.23 at 16:18, Cliff Brake wrote: On 8/10/23 10:04, Michael Opdenacker via lists.openembedded.org wrote: I'm wondering whether it's better to document how to create and send pull requests from standard git tools. +1 Cliff All things considered, since scripts/create-pull-request is still in use, in particular by Steve and Bruce, I'm leaning towards documenting both variants: * Creating a simple pull request using the standard git tools, as several of us are doing. Richard doesn't seem to mind. At least in my case, this applies to changes I previously submitted through the lists. * Creating a more elaborate pull request from a branch containing commits that haven't been shared yet, typically like what Steve does. This way, people can review each patch individually by e-mail. Unless we want to standardize our pull requests, and make sure each commit is submitted (sometimes once again) as a separate patch. In that case, we'd only document the use of scripts/create-pull-request. Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#185814): https://lists.openembedded.org/g/openembedded-core/message/185814 Mute This Topic: https://lists.openembedded.org/mt/100663724/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][mickledore 00/37] Patch review
On 10.08.23 at 18:26, Steve Sakoman wrote: On Thu, Aug 10, 2023 at 6:18 AM Michael Opdenacker wrote: Hi Steve, On 10.08.23 at 18:03, Steve Sakoman wrote: Please review this set of changes and have comments back by end of day Monday, August 14. Passed a-full on autobuilder: https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5711 The following changes since commit dc4099307100de817110958c9426ced4189fd0ac: util-linux: add alternative links for ipcs,ipcrm (2023-07-27 04:32:06 -1000) are available in the Git repository at: https://git.openembedded.org/openembedded-core-contrib stable/mickledore-nut http://cgit.openembedded.org/openembedded-core-contrib/log/?h=stable/mickledore-nut To update supported distributions in the Mickledore documentation, I'd also need to have this patch merged in the "mickledore" branch of "meta-yocto": - [poky] [PATCH] [mickledore] poky.conf: update SANITY_TESTED_DISTROS to match autobuilder https://lists.yoctoproject.org/g/poky/message/13118 Could you take care of it too? Yes. This particular review request is for oe-core. I'll take your meta-yocto patches for all of the stable branches later today if there are no objections on the list. Great, thanks! BTW, ideally the tag should be [meta-yocto], not [poky], since my searches are typically for meta-yocto and the branch name. Actually, [poky] was the mailing list prefix which I copied, but is not present in the commit title. Thanks again Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#185812): https://lists.openembedded.org/g/openembedded-core/message/185812 Mute This Topic: https://lists.openembedded.org/mt/100666325/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][mickledore 00/37] Patch review
Hi Steve, On 10.08.23 at 18:03, Steve Sakoman wrote: Please review this set of changes and have comments back by end of day Monday, August 14. Passed a-full on autobuilder: https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5711 The following changes since commit dc4099307100de817110958c9426ced4189fd0ac: util-linux: add alternative links for ipcs,ipcrm (2023-07-27 04:32:06 -1000) are available in the Git repository at: https://git.openembedded.org/openembedded-core-contrib stable/mickledore-nut http://cgit.openembedded.org/openembedded-core-contrib/log/?h=stable/mickledore-nut To update supported distributions in the Mickledore documentation, I'd also need to have this patch merged in the "mickledore" branch of "meta-yocto": - [poky] [PATCH] [mickledore] poky.conf: update SANITY_TESTED_DISTROS to match autobuilder https://lists.yoctoproject.org/g/poky/message/13118 Could you take care of it too? FYI information I also have the same changes for Kirkstone and Dunfell: - [poky] [PATCH] [kirkstone] poky.conf: update SANITY_TESTED_DISTROS to match autobuilder https://lists.yoctoproject.org/g/poky/message/13119 - [poky] [PATCH] [dunfell] poky.conf: update SANITY_TESTED_DISTROS to match autobuilder https://lists.yoctoproject.org/g/poky/message/13120 Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#185800): https://lists.openembedded.org/g/openembedded-core/message/185800 Mute This Topic: https://lists.openembedded.org/mt/100666325/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] scripts/create-pull-request: update URLs to git repositories
From: Michael Opdenacker Also remove the git.pokylinux.org URL, no longer used. Signed-off-by: Michael Opdenacker --- scripts/create-pull-request | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/scripts/create-pull-request b/scripts/create-pull-request index 2f91a355b0..885105fab3 100755 --- a/scripts/create-pull-request +++ b/scripts/create-pull-request @@ -149,13 +149,10 @@ fi WEB_URL="" case "$REMOTE_URL" in *git.yoctoproject.org*) - WEB_URL="http://git.yoctoproject.org/cgit.cgi/$REMOTE_REPO/log/?h=$BRANCH; - ;; - *git.pokylinux.org*) - WEB_URL="http://git.pokylinux.org/cgit.cgi/$REMOTE_REPO/log/?h=$BRANCH; + WEB_URL="https://git.yoctoproject.org/$REMOTE_REPO/log/?h=$BRANCH; ;; *git.openembedded.org*) - WEB_URL="http://cgit.openembedded.org/$REMOTE_REPO/log/?h=$BRANCH; + WEB_URL="https://git.openembedded.org/$REMOTE_REPO/log/?h=$BRANCH; ;; *github.com*) WEB_URL="https://github.com/$REMOTE_REPO/tree/$BRANCH; -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#185754): https://lists.openembedded.org/g/openembedded-core/message/185754 Mute This Topic: https://lists.openembedded.org/mt/100664161/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [docs] Keep scripts/create-pull-request and send-pull-request ?
Hi Bruce On 10.08.23 at 16:09, Bruce Ashfield wrote: On Thu, Aug 10, 2023 at 10:04 AM Michael Opdenacker via lists.yoctoproject.org wrote: Greetings, I'm reviewing https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull and trying to simplify it. Do people still use scripts/create-pull-request and send-pull-request? I see some obsolete URLs in the first script, and mostly old commits to their code. I use create-pull-request for all my series, so the scripts still do work and are in at least in use here. But I send with git send-email directly. Good to know, thanks! So, we need to keep at least the first one. I'll send a patch to it then. I'm not saying we should keep documenting them though ;-) Thanks Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#185751): https://lists.openembedded.org/g/openembedded-core/message/185751 Mute This Topic: https://lists.openembedded.org/mt/100663811/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] Keep scripts/create-pull-request and send-pull-request ?
Greetings, I'm reviewing https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull and trying to simplify it. Do people still use scripts/create-pull-request and send-pull-request? I see some obsolete URLs in the first script, and mostly old commits to their code. I'm also asking because I'm wondering whether it's better to document how to create and send pull requests from standard git tools. This way, people also learn how to submit pull requests to other upstreams. What do you think? Thanks in advance Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#185748): https://lists.openembedded.org/g/openembedded-core/message/185748 Mute This Topic: https://lists.openembedded.org/mt/100663724/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] recipes: remove unused AUTHOR variable
From: Michael Opdenacker No longer used in generating packages Also creates a possible confusion with the recipe maintainer name. Signed-off-by: Michael Opdenacker --- meta/lib/oe/recipeutils.py | 2 +- meta/recipes-bsp/setserial/setserial_2.17.bb| 1 - meta/recipes-connectivity/avahi/avahi_0.8.bb| 1 - meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb | 1 - meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb | 1 - meta/recipes-devtools/python/python3-ruamel-yaml_0.17.32.bb | 1 - meta/recipes-kernel/kexec/kexec-tools_2.0.26.bb | 1 - meta/recipes-multimedia/libsndfile/libsndfile1_1.2.0.bb | 1 - meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 1 - meta/recipes-support/libdaemon/libdaemon_0.14.bb| 1 - meta/recipes-support/re2c/re2c_3.0.bb | 1 - meta/recipes-support/rng-tools/rng-tools_6.16.bb| 2 -- 12 files changed, 1 insertion(+), 13 deletions(-) diff --git a/meta/lib/oe/recipeutils.py b/meta/lib/oe/recipeutils.py index b04992c66d..5a902c23f6 100644 --- a/meta/lib/oe/recipeutils.py +++ b/meta/lib/oe/recipeutils.py @@ -24,7 +24,7 @@ from collections import OrderedDict, defaultdict from bb.utils import vercmp_string # Help us to find places to insert values -recipe_progression = ['SUMMARY', 'DESCRIPTION', 'AUTHOR', 'HOMEPAGE', 'BUGTRACKER', 'SECTION', 'LICENSE', 'LICENSE_FLAGS', 'LIC_FILES_CHKSUM', 'PROVIDES', 'DEPENDS', 'PR', 'PV', 'SRCREV', 'SRCPV', 'SRC_URI', 'S', 'do_fetch()', 'do_unpack()', 'do_patch()', 'EXTRA_OECONF', 'EXTRA_OECMAKE', 'EXTRA_OESCONS', 'do_configure()', 'EXTRA_OEMAKE', 'do_compile()', 'do_install()', 'do_populate_sysroot()', 'INITSCRIPT', 'USERADD', 'GROUPADD', 'PACKAGES', 'FILES', 'RDEPENDS', 'RRECOMMENDS', 'RSUGGESTS', 'RPROVIDES', 'RREPLACES', 'RCONFLICTS', 'ALLOW_EMPTY', 'populate_packages()', 'do_package()', 'do_deploy()', 'BBCLASSEXTEND'] +recipe_progression = ['SUMMARY', 'DESCRIPTION', 'HOMEPAGE', 'BUGTRACKER', 'SECTION', 'LICENSE', 'LICENSE_FLAGS', 'LIC_FILES_CHKSUM', 'PROVIDES', 'DEPENDS', 'PR', 'PV', 'SRCREV', 'SRCPV', 'SRC_URI', 'S', 'do_fetch()', 'do_unpack()', 'do_patch()', 'EXTRA_OECONF', 'EXTRA_OECMAKE', 'EXTRA_OESCONS', 'do_configure()', 'EXTRA_OEMAKE', 'do_compile()', 'do_install()', 'do_populate_sysroot()', 'INITSCRIPT', 'USERADD', 'GROUPADD', 'PACKAGES', 'FILES', 'RDEPENDS', 'RRECOMMENDS', 'RSUGGESTS', 'RPROVIDES', 'RREPLACES', 'RCONFLICTS', 'ALLOW_EMPTY', 'populate_packages()', 'do_package()', 'do_deploy()', 'BBCLASSEXTEND'] # Variables that sometimes are a bit long but shouldn't be wrapped nowrap_vars = ['SUMMARY', 'HOMEPAGE', 'BUGTRACKER', r'SRC_URI\[(.+\.)?md5sum\]', r'SRC_URI\[(.+\.)?sha256sum\]'] list_vars = ['SRC_URI', 'LIC_FILES_CHKSUM'] diff --git a/meta/recipes-bsp/setserial/setserial_2.17.bb b/meta/recipes-bsp/setserial/setserial_2.17.bb index e46aeb90cb..8e4bb62b9f 100644 --- a/meta/recipes-bsp/setserial/setserial_2.17.bb +++ b/meta/recipes-bsp/setserial/setserial_2.17.bb @@ -1,7 +1,6 @@ SUMMARY = "Controls the configuration of serial ports" DESCRIPTION = "setserial is a program designed to set and/or report the configuration information associated with a serial port" HOMEPAGE = "http://setserial.sourceforge.net; -AUTHOR = "Theodore Ts'o " SECTION = "console/utils" LICENSE = "GPL-2.0-only" diff --git a/meta/recipes-connectivity/avahi/avahi_0.8.bb b/meta/recipes-connectivity/avahi/avahi_0.8.bb index d1c6f7f54a..7b0f490768 100644 --- a/meta/recipes-connectivity/avahi/avahi_0.8.bb +++ b/meta/recipes-connectivity/avahi/avahi_0.8.bb @@ -5,7 +5,6 @@ with no specific configuration. This tool implements IPv4LL, "Dynamic Configurat IPv4 Link-Local Addresses" (IETF RFC3927), a protocol for automatic IP address \ configuration from the link-local 169.254.0.0/16 range without the need for a central \ server.' -AUTHOR = "Lennart Poettering " HOMEPAGE = "http://avahi.org; BUGTRACKER = "https://github.com/lathiat/avahi/issues; SECTION = "network" diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb b/meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb index 3f1b75d07d..09a0ab7d27 100644 --- a/meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb +++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb @@ -7,7 +7,6 @@ information." SECTION = "console/network" LICENSE = "GPL-2.0-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" -AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf; RDEPENDS:${PN} = "bash sed util-linux-flock" diff --git a/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb index d93152cedd..cce2f57363 100644 --- a/meta/recipes-devtools/bootchart2/
Re: [OE-core] [PATCH] kernel.bbclass: introduce KERNEL_LOCALVERSION
On 21.06.23 at 18:52, Bruce Ashfield wrote: It really isn't a variable that most people will use. Most kernel recipes that have needed to set a local version have already been doing it a different way. So, we wouldn't document this new variable? Would you have details about this different way? It seems that the manual doesn't explain how... (see https://docs.yoctoproject.org/kernel-dev/index.html) Thanks Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#183192): https://lists.openembedded.org/g/openembedded-core/message/183192 Mute This Topic: https://lists.openembedded.org/mt/99224358/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] kernel.bbclass: introduce KERNEL_LOCALVERSION
Hi Bruce, Thanks for your help. On 21.06.23 at 18:17, Bruce Ashfield wrote: linux-yocto uses a different mechanism for setting this (and will continue to use that existing mechanism). So this would work in absence of a kernel recipe using CONFIG_LOCALVERSION. That's good to know from a documentation perspective :) I'm using "core-image-minimal". Is there another standard image I can build that wouldn't use linux-yocto then (if I understood correctly)? I want to make sure people know how to use this variable, because without further information, I expected that information to be used by linux-yocto. Thanks Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#183188): https://lists.openembedded.org/g/openembedded-core/message/183188 Mute This Topic: https://lists.openembedded.org/mt/99224358/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] kernel.bbclass: introduce KERNEL_LOCALVERSION
Greetings, On 30.05.23 at 19:09, Ming Liu wrote: From: Ming Liu Just like UBOOT_LOCALVERSION, an end user can set KERNEL_LOCALVERSION to append a string to the name of the local version of the kernel image. How is this supposed to be used? I added the following to my conf/local.conf file: KERNEL_LOCALVERSION = "no-networking" But when I run "uname -a" on the qemux86-64 target, I get: Linux qemux86-64 6.1.33-yocto-standard #1 SMP PREEMPT_DYNAMIC Thu Jun 15 03:08:03 UTC 2023 x86_64 GNU/Linux So, my string is not there! I'm using the latest Poky master branch for testing. Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#183186): https://lists.openembedded.org/g/openembedded-core/message/183186 Mute This Topic: https://lists.openembedded.org/mt/99224358/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] psplash: replace Yocto .h by .png splashscreen
From: Michael Opdenacker This makes the image easier to modify. People may not realize they can pass a .png image to SPLASH_IMAGES, and producing a .h file is more complicated. Also provide the source SVG file (though the recipe doesn´t use it, for easier modification) and support for higher resolutions than the initial 640x480 image. This SVG file was reconstituted manually to reproduce what was shown on the qemu86-64 image. Signed-off-by: Michael Opdenacker --- .../psplash/files/psplash-poky-img.h | 1259 - .../psplash/files/psplash-poky-img.png| Bin 0 -> 13103 bytes .../psplash/files/psplash-poky-img.svg| 116 ++ meta/recipes-core/psplash/psplash_git.bb |2 +- 4 files changed, 117 insertions(+), 1260 deletions(-) delete mode 100644 meta/recipes-core/psplash/files/psplash-poky-img.h create mode 100644 meta/recipes-core/psplash/files/psplash-poky-img.png create mode 100644 meta/recipes-core/psplash/files/psplash-poky-img.svg diff --git a/meta/recipes-core/psplash/files/psplash-poky-img.h b/meta/recipes-core/psplash/files/psplash-poky-img.h deleted file mode 100644 index 8d56aa0201..00 --- a/meta/recipes-core/psplash/files/psplash-poky-img.h +++ /dev/null @@ -1,1259 +0,0 @@ -/* GdkPixbuf RGB C-Source image dump 1-byte-run-length-encoded */ - -#define POKY_IMG_ROWSTRIDE (1920) -#define POKY_IMG_WIDTH (640) -#define POKY_IMG_HEIGHT (480) -#define POKY_IMG_BYTES_PER_PIXEL (3) /* 3:RGB, 4:RGBA */ -#define POKY_IMG_RLE_PIXEL_DATA ((uint8*) \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" \ - "\377\377
Re: [OE-core] [AUH] alsa-utils: upgrading to 1.2.9 FAILED
On 02.06.23 at 10:10, Auto Upgrade Helper wrote: Hello, this email is a notification from the Auto Upgrade Helper that the automatic attempt to upgrade the recipe *alsa-utils* to *1.2.9* has Failed(do_compile). This has already been addressed by a patch that hasn't been merged yet. See https://lists.openembedded.org/g/openembedded-core/message/182092 Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#182295): https://lists.openembedded.org/g/openembedded-core/message/182295 Mute This Topic: https://lists.openembedded.org/mt/99282239/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH RESEND] alsa-utils: upgrade 1.2.8 -> 1.2.9
From: Michael Opdenacker Signed-off-by: Michael Opdenacker --- ...ompilation-when-building-in-a-subdir.patch | 35 +++ ...lay-axfer-Replace-off64_t-with-off_t.patch | 272 -- ...lsa-utils_1.2.8.bb => alsa-utils_1.2.9.bb} | 6 +- 3 files changed, 38 insertions(+), 275 deletions(-) create mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch delete mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-aplay-axfer-Replace-off64_t-with-off_t.patch rename meta/recipes-multimedia/alsa/{alsa-utils_1.2.8.bb => alsa-utils_1.2.9.bb} (96%) diff --git a/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch b/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch new file mode 100644 index 00..3b3fe5345a --- /dev/null +++ b/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch @@ -0,0 +1,35 @@ +From 44636a7c5862538def0d2fac074772cc39a22a15 Mon Sep 17 00:00:00 2001 +From: Rudi Heitbaum +Date: Tue, 16 May 2023 02:27:59 +1000 +Subject: [PATCH] alsactl: fix compilation when building in a subdir + +Fixes: 613372d +Fixes: cff2d1c + +Compile errors when building in a subdir: +alsactl/alsactl.c:33:10: fatal error: os_compat.h: No such file or directory + 33 | #include "os_compat.h" + | ^ +alsactl/lock.c:34:10: fatal error: os_compat.h: No such file or directory + 34 | #include "os_compat.h" + | ^ + +Signed-off-by: Rudi Heitbaum +Upstream-Status: Submitted [https://github.com/alsa-project/alsa-utils/pull/213] +--- + alsactl/Makefile.am | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/alsactl/Makefile.am b/alsactl/Makefile.am +index 80dba69d..fb32c4f3 100644 +--- a/alsactl/Makefile.am b/alsactl/Makefile.am +@@ -9,6 +9,8 @@ EXTRA_DIST=alsactl.1 alsactl_init.xml + + AM_CFLAGS = -D_GNU_SOURCE + ++AM_CPPFLAGS = -I$(top_srcdir)/include ++ + alsactl_SOURCES=alsactl.c state.c lock.c utils.c init_parse.c init_ucm.c \ + daemon.c monitor.c clean.c info.c + diff --git a/meta/recipes-multimedia/alsa/alsa-utils/0001-aplay-axfer-Replace-off64_t-with-off_t.patch b/meta/recipes-multimedia/alsa/alsa-utils/0001-aplay-axfer-Replace-off64_t-with-off_t.patch deleted file mode 100644 index 356c5964ae..00 --- a/meta/recipes-multimedia/alsa/alsa-utils/0001-aplay-axfer-Replace-off64_t-with-off_t.patch +++ /dev/null @@ -1,272 +0,0 @@ -From 03553ccc6284a437576349b5a3c2ed0d7d4265e1 Mon Sep 17 00:00:00 2001 -From: Khem Raj -Date: Thu, 15 Dec 2022 14:04:10 -0800 -Subject: [PATCH] aplay,axfer: Replace off64_t with off_t - -Also replace lseek64 with lseek. - -_FILE_OFFSET_BITS=64 is passed to needed platforms since configure uses -AC_SYS_LARGEFILE macro. Therefore off_t is already 64-bit and lseek is -same as lseek64. - -Additionally this fixes buils with latest musl where these lfs64 -functions are moved out from _GNU_SOURCE and under _LARGEFILE64_SOURCE -macro alone. This makes the builds fail on 32-bit platforms even though -default off_t on musl is 64-bit always. - -Upstream-Status: Submitted [https://github.com/alsa-project/alsa-utils/pull/183] -Signed-off-by: Khem Raj - aplay/aplay.c | 44 ++--- - axfer/container-voc.c | 2 +- - axfer/container.c | 6 ++--- - axfer/container.h | 2 +- - axfer/test/container-test.c | 4 ++-- - axfer/test/mapper-test.c| 2 +- - 6 files changed, 30 insertions(+), 30 deletions(-) - -diff --git a/aplay/aplay.c b/aplay/aplay.c -index 6ce7191..bd93be3 100644 a/aplay/aplay.c -+++ b/aplay/aplay.c -@@ -141,7 +141,7 @@ static long term_c_lflag = -1; - static int dump_hw_params = 0; - - static int fd = -1; --static off64_t pbrec_count = LLONG_MAX, fdcount; -+static off_t pbrec_count = LLONG_MAX, fdcount; - static int vocmajor, vocminor; - - static char *pidfile_name = NULL; -@@ -2356,7 +2356,7 @@ static void voc_play(int fd, int ofs, char *name) - u_char *data, *buf; - char was_extended = 0, output = 0; - u_short *sp, repeat = 0; -- off64_t filepos = 0; -+ off_t filepos = 0; - - #define COUNT(x) nextblock -= x; in_buffer -= x; data += x - #define COUNT1(x) in_buffer -= x; data += x -@@ -2490,7 +2490,7 @@ static void voc_play(int fd, int ofs, char *name) - d_printf("Repeat loop %d times\n", repeat); - #endif - if (filepos >= 0) { /* if < 0, one seek fails, why test another */ -- if ((filepos = lseek64(fd, 0, 1)) < 0) { -+ if ((filepos = lseek(fd, 0, 1)) < 0) { - error(_("can't play loops; %s isn't seekable\n"), name);
Re: [OE-core] [PATCH v4] Fixes pseudo build in loongarch64
Hi JiaLing On 30.05.23 at 13:33, zhangjial...@loongson.cn wrote: From: JiaLing Zhang Fixes [YOCTO #15110] Some functions used in the project have been removed from glibc. After the removal of these functions, the architecture in glibc will not include the removed functions. This patch resolves the usage and compilation issues on the loongarch64 architecture Signed-off-by: JiaLing Zhang The patch looks perfect, thanks! I trust you on the contents ;-) Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181917): https://lists.openembedded.org/g/openembedded-core/message/181917 Mute This Topic: https://lists.openembedded.org/mt/99217464/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v3] Fixes pseudo build in loongarch64
Hi JiaLing On 30.05.23 at 11:00, zhangjial...@loongson.cn wrote: From: zhangjialing Fixes [YOCTO #15110] Some functions used in the project have been removed from glibc. After the removal of these functions, the architecture in glibc will not include the removed functions. This patch resolves the usage and compilation issues on the loongarch64 architecture Signed-off-by: JiaLing Zhang Many thanks for your update. Indeed, the "Signed-off-by" information is now correct, but the "From:" filed at the beginning of your e-mail is not updated yet, and that's what "git am" used for defining the commit author. Could you try with: git config --global sendemail.from "zhangjial...@loongson.cn" This should help. See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity By the way, I cannot apply your patch. Did you apply it against OE-core's latest master branch? Thanks again Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181908): https://lists.openembedded.org/g/openembedded-core/message/181908 Mute This Topic: https://lists.openembedded.org/mt/99216091/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v2] Fixes pseudo build in loongarch64
On 30.05.23 at 10:13, Michael Opdenacker via lists.openembedded.org wrote: |git config --global user.name "Guy Fawkes" ||| Sorry about the extra "|" characters. Of course, you should read... git config --global user.name "Guy Fawkes" Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181906): https://lists.openembedded.org/g/openembedded-core/message/181906 Mute This Topic: https://lists.openembedded.org/mt/99215084/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v2] Fixes pseudo build in loongarch64
Hello, On 30.05.23 at 08:47, zhangjial...@loongson.cn wrote: From: zhangjialing Fixes [YOCTO #15110] Some functions used in the project have been removed from glibc. After the removal of these functions, the architecture in glibc will not include the removed functions. This patch resolves the usage and compilation issues on the loongarch64 architecture Signed-off-by: zhangjialing Many thanks for your patches! However, would you mind modifying your git configuration, so that your first and last names are separated, please? Something like... |git config --global user.name "Guy Fawkes" ||| Otherwise, your name won't be correctly added to the release notes. Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181905): https://lists.openembedded.org/g/openembedded-core/message/181905 Mute This Topic: https://lists.openembedded.org/mt/99215084/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/1] rpm2cpio.sh: update to the last 4.x version
Hi Alberto, On 26.05.23 at 14:39, Alberto Planas via lists.openembedded.org wrote: openSUSE RPMs are compressing the RPM payload using zstd, that correspond to the magic ID 0x28, 0xb5, 0x2f. This patch update the script to the last version from the rpm project, and add support to this compression format, and extract the cpio payload using the "unzstd" binary. Signed-off-by: Alberto Planas --- scripts/rpm2cpio.sh | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) mode change 100755 => 100644 scripts/rpm2cpio.sh Many thanks for your contributions to the project! However, since your patches are received through "Your Name via lists.openembedded.org" or "Your Name via lists.yoctoproject.org", we'd need you to do add one thing to your git configuration, so that your patches are given an "Author" field which matches your "Signed-off-by" information. See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity for details. Don't hesitate to send a patch test directly to me, if you wish. Thanks in advance Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181771): https://lists.openembedded.org/g/openembedded-core/message/181771 Mute This Topic: https://lists.openembedded.org/mt/99149298/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] psplash: enable fullscreen and disable startup-msg
From: Michael Opdenacker by setting PACKAGECONFIG entries - fullscreen wasn't set by default but caused issues displaying the image (image translated upwards, white stripe at the bottom) - startup-msg was set by default but didn't seem to work, showing a white stripe in the lower half of the display. - progress-bar was already enabled, but it can now be disabled through PACKAGECONFIG. Signed-off-by: Michael Opdenacker Suggested-by: Alexander Kanavin CC: Tim Orling CC: Khem Raj --- meta/recipes-core/psplash/psplash_git.bb | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb index aecbd2ce46..e590eb978f 100644 --- a/meta/recipes-core/psplash/psplash_git.bb +++ b/meta/recipes-core/psplash/psplash_git.bb @@ -65,9 +65,12 @@ S = "${WORKDIR}/git" inherit autotools pkgconfig update-rc.d update-alternatives systemd -PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}" +PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} progress-bar fullscreen" PACKAGECONFIG[systemd] = "--with-systemd,--without-systemd,systemd" +PACKAGECONFIG[fullscreen] = "--enable-img-fullscreen" +PACKAGECONFIG[startup-msg] = ",--disable-startup-msg" +PACKAGECONFIG[progress-bar] = ",--disable-progress-bar" ALTERNATIVE_PRIORITY = "100" ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash" -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181714): https://lists.openembedded.org/g/openembedded-core/message/181714 Mute This Topic: https://lists.openembedded.org/mt/99131878/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH v4 1/3] cve-check: add option to add additional patched CVEs
Hi Andrej, On 19.05.23 at 10:18, Andrej Valek via lists.openembedded.org wrote: - Replace CVE_CHECK_IGNORE with CVE_STATUS + [CVE_STATUS_REASONING] to be more flexible. CVE_STATUS should contain flag for each CVE with accepted values "Ignored", "Not applicable" or "Patched". It allows to add a status for each CVEs. - Optional CVE_STATUS_REASONING flag variable may contain a reason why the CVE status was used. It will be added in csv/json report like a new "reason" entry. I'm not a native English speaker, but what about just "CVE_STATUS_REASON" instead of "CVE_STATUS_REASONING"? "Reasoning" is a mental process if I understand correctly. See https://www.englishforums.com/English/ReasonVsReasoning/zdgdw/post.htm. It seems to me that the term "reason" should be sufficient, as the "reason" flag that you're using. I'd be interested in what others think about this... Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181549): https://lists.openembedded.org/g/openembedded-core/message/181549 Mute This Topic: https://lists.openembedded.org/mt/99008417/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH v3 1/3] cve-check: add option to add additional patched CVEs
Hi Andrej On 19.05.23 at 08:24, Andrej Valek via lists.openembedded.org wrote: - Replace CVE_CHECK_IGNORE with CVE_STATUS + [CVE_STATUS_REASONING] to be more flexible. CVE_STATUS should contain flag for each CVE with accepted values "Ignored", "Not applicable" or "Patched". It allows to add a status for each CVEs. - Optional CVE_STATUS_REASONING flag variable may contain a reason why the CVE status was used. It will be added in csv/json report like a new "reason" entry. - Settings the same status and reason for multiple CVEs is possible via CVE_STATUS_GROUPS variable. - All listed CVEs in CVE_CHECK_IGNORE are copied to CVE_STATUS with value "Ignored" like a fallback. Examples of usage: CVE_STATUS[CVE-1234-0001] = "Ignored" # or "Not applicable" or "Patched" CVE_STATUS[CVE-1234-0002] = "Not applicable" CVE_STATUS_REASONING[CVE-1234-0002] = "Issue only applies on Windows" CVE_STATUS_GROUPS = "CVE_STATUS_WIN CVE_STATUS_PATCHED" CVE_STATUS_WIN = "CVE-1234-0001 CVE-1234-0002" CVE_STATUS_WIN[status] = "Not applicable" CVE_STATUS_WIN[reason] = "Issue only applies on Windows" CVE_STATUS_PATCHED = "CVE-1234-0003 CVE-1234-0004" CVE_STATUS_PATCHED[status] = "Patched" CVE_STATUS_PATCHED[reason] = "Fixed externally" Signed-off-by: Andrej Valek Signed-off-by: Peter Marko --- documentation/dev-manual/new-recipe.rst | 4 +- documentation/dev-manual/vulnerabilities.rst | 11 ++--- documentation/ref-manual/classes.rst | 9 ++-- documentation/ref-manual/variables.rst | 33 --- meta/classes/cve-check.bbclass | 44 +--- meta/lib/oe/cve_check.py | 6 +++ 6 files changed, 87 insertions(+), 20 deletions(-) Many thanks for the patch and for the documentation changes too ! However, could you send the documentation changes separately, using the yocto-docs repository as a reference, and sending them to the d...@lists.yoctoproject.org mailing list? You seem to have produced your patches against "poky", but that's a repository aggregating stuff from other repositories. Your code changes should be for the "openembedded-core" repository. Another advantage is that we can merge the documentation changes only when the code changes are accepted. Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181536): https://lists.openembedded.org/g/openembedded-core/message/181536 Mute This Topic: https://lists.openembedded.org/mt/99007092/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH 3/3] alsa-utils: upgrade 1.2.8 -> 1.2.9
From: Michael Opdenacker Signed-off-by: Michael Opdenacker --- ...ompilation-when-building-in-a-subdir.patch | 35 +++ ...lay-axfer-Replace-off64_t-with-off_t.patch | 272 -- ...lsa-utils_1.2.8.bb => alsa-utils_1.2.9.bb} | 6 +- 3 files changed, 38 insertions(+), 275 deletions(-) create mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch delete mode 100644 meta/recipes-multimedia/alsa/alsa-utils/0001-aplay-axfer-Replace-off64_t-with-off_t.patch rename meta/recipes-multimedia/alsa/{alsa-utils_1.2.8.bb => alsa-utils_1.2.9.bb} (96%) diff --git a/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch b/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch new file mode 100644 index 00..3b3fe5345a --- /dev/null +++ b/meta/recipes-multimedia/alsa/alsa-utils/0001-alsactl-fix-compilation-when-building-in-a-subdir.patch @@ -0,0 +1,35 @@ +From 44636a7c5862538def0d2fac074772cc39a22a15 Mon Sep 17 00:00:00 2001 +From: Rudi Heitbaum +Date: Tue, 16 May 2023 02:27:59 +1000 +Subject: [PATCH] alsactl: fix compilation when building in a subdir + +Fixes: 613372d +Fixes: cff2d1c + +Compile errors when building in a subdir: +alsactl/alsactl.c:33:10: fatal error: os_compat.h: No such file or directory + 33 | #include "os_compat.h" + | ^ +alsactl/lock.c:34:10: fatal error: os_compat.h: No such file or directory + 34 | #include "os_compat.h" + | ^ + +Signed-off-by: Rudi Heitbaum +Upstream-Status: Submitted [https://github.com/alsa-project/alsa-utils/pull/213] +--- + alsactl/Makefile.am | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/alsactl/Makefile.am b/alsactl/Makefile.am +index 80dba69d..fb32c4f3 100644 +--- a/alsactl/Makefile.am b/alsactl/Makefile.am +@@ -9,6 +9,8 @@ EXTRA_DIST=alsactl.1 alsactl_init.xml + + AM_CFLAGS = -D_GNU_SOURCE + ++AM_CPPFLAGS = -I$(top_srcdir)/include ++ + alsactl_SOURCES=alsactl.c state.c lock.c utils.c init_parse.c init_ucm.c \ + daemon.c monitor.c clean.c info.c + diff --git a/meta/recipes-multimedia/alsa/alsa-utils/0001-aplay-axfer-Replace-off64_t-with-off_t.patch b/meta/recipes-multimedia/alsa/alsa-utils/0001-aplay-axfer-Replace-off64_t-with-off_t.patch deleted file mode 100644 index 356c5964ae..00 --- a/meta/recipes-multimedia/alsa/alsa-utils/0001-aplay-axfer-Replace-off64_t-with-off_t.patch +++ /dev/null @@ -1,272 +0,0 @@ -From 03553ccc6284a437576349b5a3c2ed0d7d4265e1 Mon Sep 17 00:00:00 2001 -From: Khem Raj -Date: Thu, 15 Dec 2022 14:04:10 -0800 -Subject: [PATCH] aplay,axfer: Replace off64_t with off_t - -Also replace lseek64 with lseek. - -_FILE_OFFSET_BITS=64 is passed to needed platforms since configure uses -AC_SYS_LARGEFILE macro. Therefore off_t is already 64-bit and lseek is -same as lseek64. - -Additionally this fixes buils with latest musl where these lfs64 -functions are moved out from _GNU_SOURCE and under _LARGEFILE64_SOURCE -macro alone. This makes the builds fail on 32-bit platforms even though -default off_t on musl is 64-bit always. - -Upstream-Status: Submitted [https://github.com/alsa-project/alsa-utils/pull/183] -Signed-off-by: Khem Raj - aplay/aplay.c | 44 ++--- - axfer/container-voc.c | 2 +- - axfer/container.c | 6 ++--- - axfer/container.h | 2 +- - axfer/test/container-test.c | 4 ++-- - axfer/test/mapper-test.c| 2 +- - 6 files changed, 30 insertions(+), 30 deletions(-) - -diff --git a/aplay/aplay.c b/aplay/aplay.c -index 6ce7191..bd93be3 100644 a/aplay/aplay.c -+++ b/aplay/aplay.c -@@ -141,7 +141,7 @@ static long term_c_lflag = -1; - static int dump_hw_params = 0; - - static int fd = -1; --static off64_t pbrec_count = LLONG_MAX, fdcount; -+static off_t pbrec_count = LLONG_MAX, fdcount; - static int vocmajor, vocminor; - - static char *pidfile_name = NULL; -@@ -2356,7 +2356,7 @@ static void voc_play(int fd, int ofs, char *name) - u_char *data, *buf; - char was_extended = 0, output = 0; - u_short *sp, repeat = 0; -- off64_t filepos = 0; -+ off_t filepos = 0; - - #define COUNT(x) nextblock -= x; in_buffer -= x; data += x - #define COUNT1(x) in_buffer -= x; data += x -@@ -2490,7 +2490,7 @@ static void voc_play(int fd, int ofs, char *name) - d_printf("Repeat loop %d times\n", repeat); - #endif - if (filepos >= 0) { /* if < 0, one seek fails, why test another */ -- if ((filepos = lseek64(fd, 0, 1)) < 0) { -+ if ((filepos = lseek(fd, 0, 1)) < 0) { - error(_("can't play loops; %s isn't seekable\n"), name);
Re: [OE-core] [PATCH] bitbake.conf: add "xz" to HOSTTOOLS
On 16.05.23 at 20:30, Michael Opdenacker via lists.openembedded.org wrote: From: Michael Opdenacker xz is necessary to extract the uninative binary shims Signed-off-by: Michael Opdenacker Oops, forget about this patch. It's an old one, and it has already been applied. Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181411): https://lists.openembedded.org/g/openembedded-core/message/181411 Mute This Topic: https://lists.openembedded.org/mt/98932860/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH 2/3] alsa-ucm-conf: upgrade 1.2.8 -> 1.2.9
From: Michael Opdenacker Signed-off-by: Michael Opdenacker --- .../alsa/{alsa-ucm-conf_1.2.8.bb => alsa-ucm-conf_1.2.9.bb} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename meta/recipes-multimedia/alsa/{alsa-ucm-conf_1.2.8.bb => alsa-ucm-conf_1.2.9.bb} (89%) diff --git a/meta/recipes-multimedia/alsa/alsa-ucm-conf_1.2.8.bb b/meta/recipes-multimedia/alsa/alsa-ucm-conf_1.2.9.bb similarity index 89% rename from meta/recipes-multimedia/alsa/alsa-ucm-conf_1.2.8.bb rename to meta/recipes-multimedia/alsa/alsa-ucm-conf_1.2.9.bb index d30b323a04..073e3b0900 100644 --- a/meta/recipes-multimedia/alsa/alsa-ucm-conf_1.2.8.bb +++ b/meta/recipes-multimedia/alsa/alsa-ucm-conf_1.2.9.bb @@ -8,7 +8,7 @@ LICENSE = "BSD-3-Clause" LIC_FILES_CHKSUM = "file://LICENSE;md5=20d74d74db9741697903372ad001d3b4" SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2; -SRC_URI[sha256sum] = "fee4a737830fd25f969d83da46a2b231beb086efd966fcc07d225e7823260ae8" +SRC_URI[sha256sum] = "374f6833bfd77d0a4675e4aa2bfb79defe850e5a46a5d4542a45962f4b9e272a" # Something went wrong at upstream tarballing inherit allarch -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181410): https://lists.openembedded.org/g/openembedded-core/message/181410 Mute This Topic: https://lists.openembedded.org/mt/98932756/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] bitbake.conf: add "xz" to HOSTTOOLS
From: Michael Opdenacker xz is necessary to extract the uninative binary shims Signed-off-by: Michael Opdenacker --- meta/conf/bitbake.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index afd9e2f552..2a6aefc01a 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -529,7 +529,7 @@ HOSTTOOLS += " \ python3 pzstd ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh \ sha1sum sha224sum sha256sum sha384sum sha512sum \ sleep sort split stat strings strip tail tar tee test touch tr true uname \ -uniq wc wget which xargs zstd \ +uniq wc wget which xargs xz zstd \ " # Tools needed to run testimage runtime image testing -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181409): https://lists.openembedded.org/g/openembedded-core/message/181409 Mute This Topic: https://lists.openembedded.org/mt/98932754/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH 1/3] alsa-lib: upgrade 1.2.8 -> 1.2.9
From: Michael Opdenacker Signed-off-by: Michael Opdenacker --- .../alsa/{alsa-lib_1.2.8.bb => alsa-lib_1.2.9.bb} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename meta/recipes-multimedia/alsa/{alsa-lib_1.2.8.bb => alsa-lib_1.2.9.bb} (94%) diff --git a/meta/recipes-multimedia/alsa/alsa-lib_1.2.8.bb b/meta/recipes-multimedia/alsa/alsa-lib_1.2.9.bb similarity index 94% rename from meta/recipes-multimedia/alsa/alsa-lib_1.2.8.bb rename to meta/recipes-multimedia/alsa/alsa-lib_1.2.9.bb index bf968c920b..a8bf09904d 100644 --- a/meta/recipes-multimedia/alsa/alsa-lib_1.2.8.bb +++ b/meta/recipes-multimedia/alsa/alsa-lib_1.2.9.bb @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a916467b91076e631dd8edb7424769c7 \ " SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2; -SRC_URI[sha256sum] = "1ab01b74e33425ca99c2e36c0844fd6888273193bd898240fe8f93accbcbf347" +SRC_URI[sha256sum] = "dc9c643fdc4ccfd0572cc685858dd41e08afb583f30460b317e4188275f615b2" inherit autotools pkgconfig -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181408): https://lists.openembedded.org/g/openembedded-core/message/181408 Mute This Topic: https://lists.openembedded.org/mt/98932744/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] OE-core CVE metrics for master on Sun 14 May 2023 01:00:01 AM HST
On 14.05.23 at 13:29, Steve Sakoman wrote: Branch: master New this week: 3 CVEs CVE-2022-21227 (CVSS3: 7.5 HIGH): sqlite3:sqlite3-native https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2022-21227 * CVE-2023-2426 (CVSS3: 5.5 MEDIUM): vim https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-2426 * CVE-2023-2610 (CVSS3: 7.8 HIGH): vim https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-2610 * The number of vulnerabilities coming from vim week after week, year after year, is always striking to me. Could it be because of lower code quality compared to other projects of similar complexity? Could the situation be better if we supported neovim instead? Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181232): https://lists.openembedded.org/g/openembedded-core/message/181232 Mute This Topic: https://lists.openembedded.org/mt/98882755/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH v4] devicetree.bbclass: Allow selection of dts files to build
On 05.05.23 at 13:10, Richard Purdie wrote: On Fri, 2023-05-05 at 10:59 +, Petr Kubizňák - 2N wrote: Thanks for accepting the patch. I can for sure send a doc patch, just want to make sure it is desired since the glossary does not list any DT_* variable at the moment, and the devicetree class section in this respect only refers to the class sources. So I think both DT_FILES and DT_FILES_PATH variables should be documented at least, right? Ideally all the variables in use would be documented in the manual. We're trying to fix and improve the docs so yes, adding docs for the ones you added would be great, bonus marks if there are others you can add at the same time! I have the same challenge with https://git.yoctoproject.org/poky/tree/meta/classes-recipe/uboot-sign.bbclass The number of variables which can be modified is overwhelming! I guess what matters in the documentation is to refer to the variables for which there is a legitimate reason for changing the default value, right? Like UBOOT_FIT_ADDRESS_CELLS, which was introduced recently. Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181042): https://lists.openembedded.org/g/openembedded-core/message/181042 Mute This Topic: https://lists.openembedded.org/mt/98510103/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH] cve-check: add option to add additional patched CVEs
Hi Andrej, On 05.05.23 at 13:18, Andrej Valek via lists.openembedded.org wrote: CVE_CHECK_PATCHED - should contains an additional CVEs which have been fixed and shouldn't be mark as vulnerable nor ignored. Signed-off-by: Andrej Valek --- meta/classes/cve-check.bbclass | 8 1 file changed, 8 insertions(+) diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass index bd9e7e7445c..957ea0130dc 100644 --- a/meta/classes/cve-check.bbclass +++ b/meta/classes/cve-check.bbclass @@ -78,6 +78,11 @@ CVE_CHECK_SKIP_RECIPE ?= "" # CVE_CHECK_IGNORE ?= "" +# Usually a CVE gets treated as patched when a patch with the name of the CVE +# gets applied. Basically this variable should not be used. But if there are +# other reasons to mark a CVE as patched it can be added to this list. +CVE_CHECK_PATCHED ?= "" + # Layers to be excluded CVE_CHECK_LAYER_EXCLUDELIST ??= "" @@ -284,6 +289,9 @@ def check_cves(d, patched_cves): cve_ignore = d.getVar("CVE_CHECK_IGNORE").split() +# add additional patched CVEs into existing patched list +patched_cves.update(d.getVar("CVE_CHECK_PATCHED").split()) + import sqlite3 db_file = d.expand("file:${CVE_CHECK_DB_FILE}?mode=ro") conn = sqlite3.connect(db_file, uri=True) Thanks for the patch! However, we'd need you to add one thing to your git configuration, so that your patches are given an "Author" field which matches your "Signed-off-by" information. See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity for details. Don't hesitate to send a patch test directly to me, if you wish. Thanks again, Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181035): https://lists.openembedded.org/g/openembedded-core/message/181035 Mute This Topic: https://lists.openembedded.org/mt/98703185/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Contributing, how it works?
Hi Frederic On 05.05.23 at 19:17, Frederic Martinsons wrote: Hello list I'm wondering if there are documentations on how contribution are managed for the project. I try to find some but didn't manage to. There are easily reachable doc about how to contribute of course (how to make patches, fixe your identity, send mail via git... etc) but I didn't find what I usually find on other open source project (CONTRIBUTING.md file most of the time) like - what are the tests do should I run before submitting (I learnt by practice about test image or bitbake selftest for example) ? - is there a specific configuration that I should test before submitting (poky is ok, or should I also test another distro)? - does some commit writing rules exist ? (some projects want commits to begin with a prefix, usually the software component that is modified by the patch for example) - what are the coding rules you should follow, if any? (having common coding rules helps greatly the review of patches, pylint for python code for example, and I saw there are some bitbake recipes linter from meta-sca layer) Long story short, I really would like to know what are the different steps a patch should go through before being merged into master (and as a side question, what are the steps for a patch to be backported into one of the LTS branch). I'm deeply sorry if all these questions are obvious to you and have been already answered somewhere, in that case, please just give me the link. I recently started to contribute to yocto / oe and I think it will help me to make better contributions if I know more of how it works "under the hood". Thanks for starting this thread! We precisely have plans to consolidate docs on how to contribute. See https://www.openembedded.org/wiki/Document_Consolidation and https://wiki.yoctoproject.org/wiki/Maintainers_Manual for a list of documents we want to consolidate. Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#180974): https://lists.openembedded.org/g/openembedded-core/message/180974 Mute This Topic: https://lists.openembedded.org/mt/98710419/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [Yocto-Advocacy] Yocto Project Community Manager updates
Dear Nico, On 04.05.23 at 16:40, Nicolas Dechesne wrote: Dear all, After five years, I have decided to resign from my position as the Yocto Project Community Manager. I joined the OpenEmbedded community around 2008. I have fond memories of my early days, and still remember some of my first interactions on IRC and mailing lists! This is a very welcoming community, always helping new people with patience and kindness. Serving the project during the last five years is something I am very proud of, and I will be forever grateful to all of you for accepting me! During these years, we have gone through a lot together, the pandemic gave us an opportunity to rethink how our community should come together. Setting up our Virtual Summits has been a lot of work (and stress!) for a group of few people, but the never ending success of these events has been very rewarding! Our online presence in social media has dramatically improved, and allows us to reach out to and interact with our community faster than ever before! On the side of all the technical changes, and releases, we have also established the Yocto LTS process which was a recurring request from the community and has become a strength of the project! We also revamped the project documentation to make it easier to maintain and contribute. The Yocto Project documentation is such a great resource for our community! I have spent so many hours on these PDFs in my early days! Anyway, let’s not focus on the past! The future looks bright and I am really excited to announce that Josef Holzmayr has accepted to take over the Community Manager role. Josef needs no introduction, he has been a key member of this community for so many years. Thanks to Josef's relentless efforts, we have grown our social media presence on Youtube, Twitter, LinkedIn and Mastodon! His energy will be a great source of inspiration for this community! I wish Josef and Yocto the best for the years to come, and I am convinced this community is in good hands and that Josef will be a great community leader! Many thanks for everything you did for the project, and are still doing for the wider embedded Linux community. You will be missed here but I hope you will still be around. Now the bar is high and Josef is expected to stay as an official Community Manager for at least 5 years ;-) Thanks again to you Nico and thanks to Josef for taking over! Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#180878): https://lists.openembedded.org/g/openembedded-core/message/180878 Mute This Topic: https://lists.openembedded.org/mt/98685425/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] bitbake.conf: add "xz" to HOSTTOOLS
On 03.05.23 at 12:47, Richard Purdie wrote: On Wed, 2023-05-03 at 11:52 +0200, Michael Opdenacker via lists.openembedded.org wrote: From: Michael Opdenacker xz is necessary to extract the uninative binary shims Signed-off-by: Michael Opdenacker --- meta/conf/bitbake.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index afd9e2f552..2a6aefc01a 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -529,7 +529,7 @@ HOSTTOOLS += " \ python3 pzstd ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh \ sha1sum sha224sum sha256sum sha384sum sha512sum \ sleep sort split stat strings strip tail tar tee test touch tr true uname \ -uniq wc wget which xargs zstd \ +uniq wc wget which xargs xz zstd \ " # Tools needed to run testimage runtime image testing I don't quite understand, how is this working today without this? At least on Ubuntu, the "xz-utils" package is pulled by "build-essential", so everyone on Ubuntu always has "xz". Then, we I ran my tests on a fresh Fedora container, bitbake didn't warn me but "xz" was missing, but this prevented the uninative shim from being installed. It seems that at least on Fedora, "xz" isn't pulled by the other host tools we install. I guess most people has "xz" anyway, which could explain why this wasn't reported before. By the way, just wondering... What do we need "perl" for ? Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#180816): https://lists.openembedded.org/g/openembedded-core/message/180816 Mute This Topic: https://lists.openembedded.org/mt/98658155/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] bitbake.conf: add "xz" to HOSTTOOLS
From: Michael Opdenacker xz is necessary to extract the uninative binary shims Signed-off-by: Michael Opdenacker --- meta/conf/bitbake.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index afd9e2f552..2a6aefc01a 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -529,7 +529,7 @@ HOSTTOOLS += " \ python3 pzstd ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh \ sha1sum sha224sum sha256sum sha384sum sha512sum \ sleep sort split stat strings strip tail tar tee test touch tr true uname \ -uniq wc wget which xargs zstd \ +uniq wc wget which xargs xz zstd \ " # Tools needed to run testimage runtime image testing -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#180803): https://lists.openembedded.org/g/openembedded-core/message/180803 Mute This Topic: https://lists.openembedded.org/mt/98658155/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] init-manager-none.inc: have no init manager
Hi Alex, On 02.05.23 at 16:14, Alexandre Belloni wrote: Hello, This causes the following error: https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/7035/steps/12/logs/stdio This is the expected behaviour of the patch but doesn't fit with what this particular build (qemuarm-oecore) is testing as we can't run testimage without an init. I'm wondering what should be the proper course of action here. Thanks for the report! Maybe another option is to remove the "none" option, as someone also suggested, as it is currently identical to the "sysvinit" option. Any further thoughts? Thanks again Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#180732): https://lists.openembedded.org/g/openembedded-core/message/180732 Mute This Topic: https://lists.openembedded.org/mt/98554799/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] init-manager-none.inc: have no init manager
From: Michael Opdenacker This fixes the issue that setting INIT_MANAGER to "none" produces a system with sysvinit. As the name suggests, this produces a system without an init manager (no systemd, no sysvinit, no BusyBox init, no /etc/inittab). There isn't any login manager either. The kernel just starts /bin/sh in the console. Signed-off-by: Michael Opdenacker --- meta/conf/distro/include/init-manager-none.inc | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/meta/conf/distro/include/init-manager-none.inc b/meta/conf/distro/include/init-manager-none.inc index bbedf898f7..56d2b0f406 100644 --- a/meta/conf/distro/include/init-manager-none.inc +++ b/meta/conf/distro/include/init-manager-none.inc @@ -1,3 +1,4 @@ -VIRTUAL-RUNTIME_init_manager ??= "sysvinit" -VIRTUAL-RUNTIME_initscripts ??= "initscripts" -VIRTUAL-RUNTIME_login_manager ??= "busybox" +DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd sysvinit" +VIRTUAL-RUNTIME_init_manager ??= "" +VIRTUAL-RUNTIME_initscripts ??= "" +VIRTUAL-RUNTIME_login_manager ??= "" -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#180524): https://lists.openembedded.org/g/openembedded-core/message/180524 Mute This Topic: https://lists.openembedded.org/mt/98554799/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [docs] [OE-core] Difference between INIT_MANAGER="none" and INIT_MANAGER="sysvinit"?
Hi Alex, Getting back to this old thread about setting INIT_MANAGER to "none", which currently produces a system based on sysvinit and udev. On 23.02.23 at 19:22, Alexander Kanavin wrote: none is a confusing name though. Should it be dropped and nodistro tweaked to use sysvinit? Indeed, that's confusing. Even Paul Eggleton got it wrong when he documented INIT_MANAGER. I'll send a patch that fixes this on master Poky, but indeed removing "none" is another option. Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#180523): https://lists.openembedded.org/g/openembedded-core/message/180523 Mute This Topic: https://lists.openembedded.org/mt/97189211/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH v5] migration-guides: update 4.2 migration and release notes
From: Michael Opdenacker Signed-off-by: Michael Opdenacker CC: Frederic Martinsons CC: Marta Rybczynska CC: Paul Eggleton CC: Alex Kiernan CC: Alexis Lothoré ` +for example. + +The ``cargo-update-recipe-crates`` utility +:yocto_git:`has been extended ` +to include such checksums. So, in case you need to add the list of checksums +to a recipe just inheriting the :ref:`ref-classes-cargo` class so far, you can +follow these steps: + +#. Make the recipe inherit :ref:`ref-classes-cargo-update-recipe-crates` +#. Remove all ``crate://`` lines from the recipe +#. Create an empty ``${BPN}-crates.inc`` file and make your recipe require it +#. Execute ``bitbake -c update_crates your_recipe`` +#. Copy and paste the output of BitBake about the missing checksums into the +``${BPN}-crates.inc`` file. + +.. _migration-4.2-supported-distributions: + +Supported distributions +~~~ + +This release supports running BitBake on new GNU/Linux distributions: + +- Fedora 36 and 37 +- AlmaLinux 8.7 and 9.1 +- OpenSuse 15.4 + +On the other hand, some earlier distributions are no longer supported: + +- Debian 10.x +- Fedora 34 and 35 +- AlmaLinux 8.5 + +See :ref:`all supported distributions `. .. _migration-4.2-misc-changes: @@ -30,6 +92,7 @@ Miscellaneous changes - The ``OEBasic`` signature handler (see :term:`BB_SIGNATURE_HANDLER`) has been removed. + .. _migration-4.2-removed-variables: @@ -38,7 +101,7 @@ Removed variables The following variables have been removed: -- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:``SERIAL_CONSOLES``. +- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:`SERIAL_CONSOLES`. .. _migration-4.2-removed-recipes: @@ -47,3 +110,17 @@ Removed recipes The following recipes have been removed in this release: +- ``python3-picobuild``: after switching to ``python3-build`` +- ``python3-strict-rfc3339``: unmaintained and not needed by anything in + :oe_git:`openembedded-core ` + or :oe_git:`meta-openembedded `. + +.. _migration-4.2-removed-classes: + +Removed classes +~~~ + +The following classes have been removed in this release: + +- ``rust-bin``: no longer used in Poky + diff --git a/documentation/migration-guides/release-notes-4.2.rst b/documentation/migration-guides/release-notes-4.2.rst index edafe378b0..b6e278ee5d 100644 --- a/documentation/migration-guides/release-notes-4.2.rst +++ b/documentation/migration-guides/release-notes-4.2.rst @@ -6,23 +6,90 @@ Release notes for 4.2 (mickledore) New Features / Enhancements in 4.2 ~~ -- Python 3.8 is the minimum Python version required on the build host. - For host distributions that do not provide it, this is included as part of the - :term:`buildtools` tarball. +- Python 3.8 is the minimum Python version required on the build host. + For host distributions that do not provide it, this is included as part of the + :term:`buildtools` tarball. -- This release now supports a new ``addpylib`` directive to enable - Python libraries within layers. +- BitBake in this release now supports a new ``addpylib`` directive to enable + Python libraries within layers. - This directive should be added to your layer configuration, - as in the below example from ``meta/conf/layer.conf``:: + This directive should be added to your layer configuration + as in the below example from ``meta/conf/layer.conf``:: - addpylib ${LAYERDIR}/lib oe + addpylib ${LAYERDIR}/lib oe + +- BitBake has seen multiple internal changes that may impact + memory and disk usage as well as parsing time, in particular: + + - BitBake's Cooker server is now multithreaded. + + - BitBake's cache has been extended to include more hash + debugging data, but has also been optimized to :yocto_git:`compress + cache data <https://git.yoctoproject.org/poky/commit/?h=mickledore=7d010055e2af3294e17db862f42664ca689a9356>`. + + - BitBake's Cooker server :yocto_git:`can now be pinged + https://git.yoctoproject.org/poky/commit/?h=mickledore=26f255da09>` + from the UI. - Architecture-specific enhancements: + - This release adds initial support for the + :wikipedia:`LoongArch ` + (``loongarch64``) architecture, though there is no testing for it yet. + - Kernel-related enhancements: - QEMU/runqemu enhancements: - Image-related enhancements: +- New variables: + + - :term:`VOLATILE_TMP_DIR` allows to specify + whether ``/tmp`` should be on persistent storage + or in RAM. + +- Rust improvements: + + - This release adds Cargo support on the target, and includes + automated QA tests for this functionality. + + - It also supports checksums for Rust crates and makes + them mandatory for each crate in a recipe. + +- Testing: + + - The ptest images have changed structure in this release. The + underlying ``core-image-ptest
[OE-core] [PATCH v4] migration-guides: update 4.2 migration and release notes
From: Michael Opdenacker Signed-off-by: Michael Opdenacker CC: Frederic Martinsons CC: Marta Rybczynska CC: Paul Eggleton CC: Alex Kiernan CC: Alexis Lothoré ` +for example. + +The ``cargo-update-recipe-crates`` utility +:yocto_git:`has been extended ` +to include such checksums. So, in case you need to add the list of checksums +to a recipe just inheriting the :ref:`ref-classes-cargo` class so far, you can +follow these steps: + +#. Make the recipe inherit :ref:`ref-classes-cargo-update-recipe-crates` +#. Remove all ``crate://`` lines from the recipe +#. Create an empty ``${BPN}-crates.inc`` file and make your recipe require it +#. Execute ``bitbake -c update_crates your_recipe`` +#. Copy and paste the output of BitBake about the missing checksums into the +``${BPN}-crates.inc`` file. + .. _migration-4.2-qa-checks: QA check changes +.. _migration-4.2-supported-distributions: + +Supported distributions +~~~ + +This release supports running BitBake on new GNU/Linux distributions: + +- Fedora 36 and 37 +- AlmaLinux 8.7 and 9.1 +- OpenSuse 15.4 + +On the other hand, some earlier distributions are no longer supported: + +- Debian 10.x +- Fedora 34 and 35 +- AlmaLinux 8.5 + +See :ref:`all supported distributions `. + .. _migration-4.2-misc-changes: Miscellaneous changes @@ -30,6 +97,7 @@ Miscellaneous changes - The ``OEBasic`` signature handler (see :term:`BB_SIGNATURE_HANDLER`) has been removed. + .. _migration-4.2-removed-variables: @@ -38,7 +106,7 @@ Removed variables The following variables have been removed: -- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:``SERIAL_CONSOLES``. +- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:`SERIAL_CONSOLES`. .. _migration-4.2-removed-recipes: @@ -47,3 +115,17 @@ Removed recipes The following recipes have been removed in this release: +- ``python3-picobuild``: after switching to ``python3-build`` +- ``python3-strict-rfc3339``: unmaintained and not needed by anything in + :oe_git:`openembedded-core ` + or :oe_git:`meta-openembedded `. + +.. _migration-4.2-removed-classes: + +Removed classes +~~~ + +The following classes have been removed in this release: + +- ``rust-bin``: no longer used in Poky + diff --git a/documentation/migration-guides/release-notes-4.2.rst b/documentation/migration-guides/release-notes-4.2.rst index edafe378b0..b6e278ee5d 100644 --- a/documentation/migration-guides/release-notes-4.2.rst +++ b/documentation/migration-guides/release-notes-4.2.rst @@ -6,23 +6,90 @@ Release notes for 4.2 (mickledore) New Features / Enhancements in 4.2 ~~ -- Python 3.8 is the minimum Python version required on the build host. - For host distributions that do not provide it, this is included as part of the - :term:`buildtools` tarball. +- Python 3.8 is the minimum Python version required on the build host. + For host distributions that do not provide it, this is included as part of the + :term:`buildtools` tarball. -- This release now supports a new ``addpylib`` directive to enable - Python libraries within layers. +- BitBake in this release now supports a new ``addpylib`` directive to enable + Python libraries within layers. - This directive should be added to your layer configuration, - as in the below example from ``meta/conf/layer.conf``:: + This directive should be added to your layer configuration + as in the below example from ``meta/conf/layer.conf``:: - addpylib ${LAYERDIR}/lib oe + addpylib ${LAYERDIR}/lib oe + +- BitBake has seen multiple internal changes that may impact + memory and disk usage as well as parsing time, in particular: + + - BitBake's Cooker server is now multithreaded. + + - BitBake's cache has been extended to include more hash + debugging data, but has also been optimized to :yocto_git:`compress + cache data <https://git.yoctoproject.org/poky/commit/?h=mickledore=7d010055e2af3294e17db862f42664ca689a9356>`. + + - BitBake's Cooker server :yocto_git:`can now be pinged + https://git.yoctoproject.org/poky/commit/?h=mickledore=26f255da09>` + from the UI. - Architecture-specific enhancements: + - This release adds initial support for the + :wikipedia:`LoongArch ` + (``loongarch64``) architecture, though there is no testing for it yet. + - Kernel-related enhancements: - QEMU/runqemu enhancements: - Image-related enhancements: +- New variables: + + - :term:`VOLATILE_TMP_DIR` allows to specify + whether ``/tmp`` should be on persistent storage + or in RAM. + +- Rust improvements: + + - This release adds Cargo support on the target, and includes + automated QA tests for this functionality. + + - It also supports checksums for Rust crates and makes + them mandatory for each crate in a recipe. + +- Testing: + + -
[OE-core] [PATCH v3] migration-guides: update 4.2 migration and release notes
From: Michael Opdenacker Signed-off-by: Michael Opdenacker CC: Frederic Martinsons CC: Marta Rybczynska CC: Paul Eggleton CC: Alex Kiernan CC: Alexis Lothoré ` +for example. + +The ``cargo-update-recipe-crates`` utility +:yocto_git:`has been extended ` +to include such checksums. So, in case you need to add the list of checksums +to a recipe just inheriting the :ref:`ref-classes-cargo` class so far, you can +follow these steps: + +#. Make the recipe inherit :ref:`ref-classes-cargo-update-recipe-crates` +#. Remove all ``crate://`` lines from the recipe +#. Create an empty ``${BPN}-crates.inc`` file and make your recipe require it +#. Execute ``bitbake -c update_crates your_recipe`` +#. Copy and paste the output of BitBake about the missing checksums into the +``${BPN}-crates.inc`` file. + .. _migration-4.2-qa-checks: QA check changes +.. _migration-4.2-supported-distributions: + +Supported distributions +~~~ + +This release supports running BitBake on new GNU/Linux distributions: + +- Fedora 36 and 37 +- AlmaLinux 8.7 and 9.1 +- OpenSuse 15.4 + +On the other hand, some earlier distributions are no longer supported: + +- Debian 10.x +- Fedora 34 and 35 +- AlmaLinux 8.5 + +See :ref:`all supported distributions `. + .. _migration-4.2-misc-changes: Miscellaneous changes @@ -30,6 +97,7 @@ Miscellaneous changes - The ``OEBasic`` signature handler (see :term:`BB_SIGNATURE_HANDLER`) has been removed. + .. _migration-4.2-removed-variables: @@ -38,7 +106,7 @@ Removed variables The following variables have been removed: -- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:``SERIAL_CONSOLES``. +- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:`SERIAL_CONSOLES`. .. _migration-4.2-removed-recipes: @@ -47,3 +115,17 @@ Removed recipes The following recipes have been removed in this release: +- ``python3-picobuild``: after switching to ``python3-build`` +- ``python3-strict-rfc3339``: unmaintained and not needed by anything in + :oe_git:`openembedded-core ` + or :oe_git:`meta-openembedded `. + +.. _migration-4.2-removed-classes: + +Removed classes +~~~ + +The following classes have been removed in this release: + +- ``rust-bin``: no longer used in Poky + diff --git a/documentation/migration-guides/release-notes-4.2.rst b/documentation/migration-guides/release-notes-4.2.rst index edafe378b0..6fa41ce33b 100644 --- a/documentation/migration-guides/release-notes-4.2.rst +++ b/documentation/migration-guides/release-notes-4.2.rst @@ -6,23 +6,93 @@ Release notes for 4.2 (mickledore) New Features / Enhancements in 4.2 ~~ -- Python 3.8 is the minimum Python version required on the build host. - For host distributions that do not provide it, this is included as part of the - :term:`buildtools` tarball. +- Python 3.8 is the minimum Python version required on the build host. + For host distributions that do not provide it, this is included as part of the + :term:`buildtools` tarball. -- This release now supports a new ``addpylib`` directive to enable - Python libraries within layers. +- BitBake in this release now supports a new ``addpylib`` directive to enable + Python libraries within layers. - This directive should be added to your layer configuration, - as in the below example from ``meta/conf/layer.conf``:: + This directive should be added to your layer configuration + as in the below example from ``meta/conf/layer.conf``:: - addpylib ${LAYERDIR}/lib oe + addpylib ${LAYERDIR}/lib oe + +- BitBake has seen multiple internal changes that may impact + memory and disk usage as well as parsing time, in particular: + + - BitBake's Cooker server is now multithreaded. + + - BitBake's cache has been extended to include more hash + debugging data, but has also been optimized to :yocto_git:`compress + cache data <https://git.yoctoproject.org/poky/commit/?h=mickledore=7d010055e2af3294e17db862f42664ca689a9356>`. + + - BitBake's Cooker server :yocto_git:`can now be pinged + https://git.yoctoproject.org/poky/commit/?h=mickledore=26f255da09>` + from the UI. - Architecture-specific enhancements: + - This release adds initial support for the + :wikipedia:`LoongArch ` + (``loongarch64``) architecture, though there is no testing for it yet. + - Kernel-related enhancements: - QEMU/runqemu enhancements: - Image-related enhancements: +- New variables: + + - :term:`VOLATILE_TMP_DIR` allows to specify + whether ``/tmp`` should be on persistent storage + or in RAM. + +- Rust improvements: + + - This release adds Cargo support on the target, and includes + automated QA tests for this functionality. + + - It also supports checksums for Rust crates and makes + them mandatory for each crate in a recipe. + +- Testing: + + -
Re: [OE-core] [PATCH v2] migration-guides: update 4.2 migration and release notes
On 06.04.23 at 12:12, Richard Purdie wrote: The ptest images have changed structure in this release. The underlying core-image-ptest recipe now uses BBCLASSEXTEND to create a variant for each ptest enabled recipe in OE-Core. For example, this means that "core-image-ptest-bzip2", "core-image- ptest-lttng-tools" and many more image targets now exist and can be built/tested individually. The core-image-ptest-all and core-image-ptest-fast targets are now wrappers that target groups of individual images and means that the tests can be executed in parallel during our automated testing. This also means the dependencies are more accurately tested. Thanks Richard. This will be included in the next update I send. Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#179806): https://lists.openembedded.org/g/openembedded-core/message/179806 Mute This Topic: https://lists.openembedded.org/mt/98101357/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH v2] migration-guides: update 4.2 migration and release notes
From: Michael Opdenacker Signed-off-by: Michael Opdenacker CC: Frederic Martinsons CC: Marta Rybczynska CC: Paul Eggleton CC: Alex Kiernan --- Changes in V2: - Add details about filling checksums using the 'cargo-update-recipe-crates' class, as suggested by Frederic Martinsons. --- .../migration-guides/migration-4.2.rst| 84 ++- .../migration-guides/release-notes-4.2.rst| 68 +-- 2 files changed, 143 insertions(+), 9 deletions(-) diff --git a/documentation/migration-guides/migration-4.2.rst b/documentation/migration-guides/migration-4.2.rst index 1339411b3e..3b60b9a807 100644 --- a/documentation/migration-guides/migration-4.2.rst +++ b/documentation/migration-guides/migration-4.2.rst @@ -18,11 +18,78 @@ BitBake and OpenEmbedded-Core are now relying on Python 3.8, making it a requirement to use a distribution providing at least this version, or to use :term:`buildtools`. +.. _migration-4.2-gcc-8.0: + +gcc 8.0 is now the minumum required GNU C compiler version +~~ + +This version, released in 2018, is a minimum requirement +to build the ``mesa-native`` recipe. + +.. _migration-4.2-new-nvd-api: + +Fetching the NVD vulnerability database through the 2.0 API +~~~ + +This new version adds a new fetcher for the NVD database using the 2.0 API, +as the 1.0 API will be retired in 2023. + +The implementation changes as little as possible, keeping the current +database format (but using a different database file for the transition +period), with a notable exception of not using the META table. + +Here are minor changes that you may notice: + +- The database starts in 1999 instead of 2002 +- The complete fetch is longer (30 minutes typically) + +.. _migration-4.2-rust-crate-checksums: + +Rust: mandatory checksums for crates + + +This release now supports checksums for Rust crates and make +them mandatory for each crate in a recipe. See :yocto_git:`python3_bcrypt recipe changes +` +for example. + +The ``cargo-update-recipe-crates`` utility +:yocto_git:`has been extended ` +to include such checksums. So, in case you need to add the list of checksums +to a recipe just inheriting the :ref:`ref-classes-cargo` class so far, you can +follow these steps: + +#. Make the recipe inherit :ref:`ref-classes-cargo-update-recipe-crates` +#. Remove all ``crate://`` lines from the recipe +#. Create an empty ``${BPN}-crates.inc`` file and make your recipe require it +#. Execute ``bitbake -c update_crates your_recipe`` +#. Copy and paste the output of BitBake about the missing checksums into the +``${BPN}-crates.inc`` file. + .. _migration-4.2-qa-checks: QA check changes +.. _migration-4.2-supported-distributions: + +Supported distributions +~~~ + +This release supports running BitBake on new GNU/Linux distributions: + +- Fedora 36 and 37 +- AlmaLinux 8.7 and 9.1 +- OpenSuse 15.4 + +On the other hand, some earlier distributions are no longer supported: + +- Debian 10.x +- Fedora 34 and 35 +- AlmaLinux 8.5 + +See :ref:`all supported distributions `. + .. _migration-4.2-misc-changes: Miscellaneous changes @@ -30,6 +97,7 @@ Miscellaneous changes - The ``OEBasic`` signature handler (see :term:`BB_SIGNATURE_HANDLER`) has been removed. + .. _migration-4.2-removed-variables: @@ -38,7 +106,7 @@ Removed variables The following variables have been removed: -- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:``SERIAL_CONSOLES``. +- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:`SERIAL_CONSOLES`. .. _migration-4.2-removed-recipes: @@ -47,3 +115,17 @@ Removed recipes The following recipes have been removed in this release: +- ``python3-picobuild``: after switching to ``python3-build`` +- ``python3-strict-rfc3339``: unmaintained and not needed by anything in + :oe_git:`openembedded-core ` + or :oe_git:`meta-openembedded `. + +.. _migration-4.2-removed-classes: + +Removed classes +~~~ + +The following classes have been removed in this release: + +- ``rust-bin``: no longer used in Poky + diff --git a/documentation/migration-guides/release-notes-4.2.rst b/documentation/migration-guides/release-notes-4.2.rst index edafe378b0..1a60fe5490 100644 --- a/documentation/migration-guides/release-notes-4.2.rst +++ b/documentation/migration-guides/release-notes-4.2.rst @@ -6,23 +6,75 @@ Release notes for 4.2 (mickledore) New Features / Enhancements in 4.2 ~~ -- Python 3.8 is the minimum Python version required on the build host. - For host distributions that do not provide it, this is included as part of the - :term:`buildtools` tarball. +- Python 3.8 is the minimum Python version required on the build host. + For host distributions that do not provide
Re: [docs] [OE-core] [PATCH] migration-guides: update 4.2 migration and release notes
Hi Frederic On 05.04.23 at 21:04, Frederic Martinsons wrote: Any more Rust changes we should mention in the migration notes? Maybe mention a specific procedure to update a cargo based recipe from scratch (i.e. a recipe that didn't use the cargo-update-recipe-crates inheritance): To bootstrap a cargo base recipe which have not the checksum list, below are the steps to make: - make the recipe inherit cargo-update-recipe-crates - remove all crate:// from the recipe - create an empty ${BPN}-crates.inc file and make your recipe requires it - execute "bitbake -c update_crates your_recipe" - copy paste the output of bitbake about the missing checksums in your ${BPN}-crates.inc The last step requires a bitbake patch to show all the missing checksum which I don't know if it will be in 4.2. Do you mean this one? https://git.openembedded.org/bitbake/commit/?h=2.4=dafa07c080e05975b6319b5adf78a9691c6b6643 It just got merged. Thanks for the tip. Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#179757): https://lists.openembedded.org/g/openembedded-core/message/179757 Mute This Topic: https://lists.openembedded.org/mt/98100806/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] migration-guides: update 4.2 migration and release notes
Greetings, I copied the OE-core mailing list to get the attention of contributors. If you want your new features to be featured in the release and migration notes for 4.2, it's time to speak! What I wrote so far is a very early draft meant to help you detect what's missing and correct what I've written so far. See my questions and comments below... On 05.04.23 at 19:46, Michael Opdenacker via lists.openembedded.org wrote: diff --git a/documentation/migration-guides/migration-4.2.rst b/documentation/migration-guides/migration-4.2.rst index 1339411b3e..3b04e072cb 100644 ... +Rust: mandatory checksums for crates + + +This release now supports checksums for Rust crates and make +them mandatory for each crate in a recipe. See :yocto_git:`python3_bcrypt recipe changes +` +for example. + +The ``cargo-update-recipe-crates`` utility +:yocto_git:`has been extended ` +to include such checksums. Any more Rust changes we should mention in the migration notes? diff --git a/documentation/migration-guides/release-notes-4.2.rst b/documentation/migration-guides/release-notes-4.2.rst index edafe378b0..1a60fe5490 100644 --- a/documentation/migration-guides/release-notes-4.2.rst +++ b/documentation/migration-guides/release-notes-4.2.rst Here in the release notes, I didn't work on the detailed changes, such as version changes for the kernel and many recipes. I'm trying to help with the first part showing the big picture. - addpylib ${LAYERDIR}/lib oe + addpylib ${LAYERDIR}/lib oe + +- BitBake has seen multiple internal changes that may impact + memory and disk usage as well as parsing time, in particular: + + - BitBake's Cooker server is now multithreaded. + + - BitBake's cache has been extended to include more hash + debugging data, but has also been optimized to :yocto_git:`compress + cache data <https://git.yoctoproject.org/poky/commit/?h=mickledore=7d010055e2af3294e17db862f42664ca689a9356>`. + + - BitBake's Cooker server :yocto_git:`can now be pinged + https://git.yoctoproject.org/poky/commit/?h=mickledore=26f255da09>` + from the UI. More BitBake changes we should mention? + +- Rust improvements: + + - This release adds Cargo support on the target, and includes + automated QA tests for this functionality. + + - It also supports checksums for Rust crates and makes + them mandatory for each crate in a recipe. More Rust changes we should highlight? +- Miscellaneous changes: + + - Supporting 64 bit dates on 32 bit platforms: several packages have been + updated to pass Y2038 tests. By the way, what's the status of Y2038 support in Mickledore? Are all tests passing now? To make the drafts easier to review, they have been compiled in the master-next branch: https://docs.yoctoproject.org/next/migration-guides/release-4.2.html Thanks in advance Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#179745): https://lists.openembedded.org/g/openembedded-core/message/179745 Mute This Topic: https://lists.openembedded.org/mt/98088099/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] migration-guides: update 4.2 migration and release notes
From: Michael Opdenacker Signed-off-by: Michael Opdenacker CC: Frederic Martinsons CC: Marta Rybczynska CC: Paul Eggleton CC: Alex Kiernan --- .../migration-guides/migration-4.2.rst| 75 ++- .../migration-guides/release-notes-4.2.rst| 68 +++-- 2 files changed, 134 insertions(+), 9 deletions(-) diff --git a/documentation/migration-guides/migration-4.2.rst b/documentation/migration-guides/migration-4.2.rst index 1339411b3e..3b04e072cb 100644 --- a/documentation/migration-guides/migration-4.2.rst +++ b/documentation/migration-guides/migration-4.2.rst @@ -18,11 +18,69 @@ BitBake and OpenEmbedded-Core are now relying on Python 3.8, making it a requirement to use a distribution providing at least this version, or to use :term:`buildtools`. +.. _migration-4.2-gcc-8.0: + +gcc 8.0 is now the minumum required GNU C compiler version +~~ + +This version, released in 2018, is a minimum requirement +to build the ``mesa-native`` recipe. + +.. _migration-4.2-new-nvd-api: + +Fetching the NVD vulnerability database through the 2.0 API +~~~ + +This new version adds a new fetcher for the NVD database using the 2.0 API, +as the 1.0 API will be retired in 2023. + +The implementation changes as little as possible, keeping the current +database format (but using a different database file for the transition +period), with a notable exception of not using the META table. + +Here are minor changes that you may notice: + +- The database starts in 1999 instead of 2002 +- The complete fetch is longer (30 minutes typically) + +.. _migration-4.2-rust-crate-checksums: + +Rust: mandatory checksums for crates + + +This release now supports checksums for Rust crates and make +them mandatory for each crate in a recipe. See :yocto_git:`python3_bcrypt recipe changes +` +for example. + +The ``cargo-update-recipe-crates`` utility +:yocto_git:`has been extended ` +to include such checksums. + .. _migration-4.2-qa-checks: QA check changes +.. _migration-4.2-supported-distributions: + +Supported distributions +~~~ + +This release supports running BitBake on new GNU/Linux distributions: + +- Fedora 36 and 37 +- AlmaLinux 8.7 and 9.1 +- OpenSuse 15.4 + +On the other hand, some earlier distributions are no longer supported: + +- Debian 10.x +- Fedora 34 and 35 +- AlmaLinux 8.5 + +See :ref:`all supported distributions `. + .. _migration-4.2-misc-changes: Miscellaneous changes @@ -30,6 +88,7 @@ Miscellaneous changes - The ``OEBasic`` signature handler (see :term:`BB_SIGNATURE_HANDLER`) has been removed. + .. _migration-4.2-removed-variables: @@ -38,7 +97,7 @@ Removed variables The following variables have been removed: -- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:``SERIAL_CONSOLES``. +- ``SERIAL_CONSOLE``, deprecated since version 2.6, replaced by :term:`SERIAL_CONSOLES`. .. _migration-4.2-removed-recipes: @@ -47,3 +106,17 @@ Removed recipes The following recipes have been removed in this release: +- ``python3-picobuild``: after switching to ``python3-build`` +- ``python3-strict-rfc3339``: unmaintained and not needed by anything in + :oe_git:`openembedded-core ` + or :oe_git:`meta-openembedded `. + +.. _migration-4.2-removed-classes: + +Removed classes +~~~ + +The following classes have been removed in this release: + +- ``rust-bin``: no longer used in Poky + diff --git a/documentation/migration-guides/release-notes-4.2.rst b/documentation/migration-guides/release-notes-4.2.rst index edafe378b0..1a60fe5490 100644 --- a/documentation/migration-guides/release-notes-4.2.rst +++ b/documentation/migration-guides/release-notes-4.2.rst @@ -6,23 +6,75 @@ Release notes for 4.2 (mickledore) New Features / Enhancements in 4.2 ~~ -- Python 3.8 is the minimum Python version required on the build host. - For host distributions that do not provide it, this is included as part of the - :term:`buildtools` tarball. +- Python 3.8 is the minimum Python version required on the build host. + For host distributions that do not provide it, this is included as part of the + :term:`buildtools` tarball. -- This release now supports a new ``addpylib`` directive to enable - Python libraries within layers. +- BitBake in this release now supports a new ``addpylib`` directive to enable + Python libraries within layers. - This directive should be added to your layer configuration, - as in the below example from ``meta/conf/layer.conf``:: + This directive should be added to your layer configuration + as in the below example from ``meta/conf/layer.conf``:: - addpylib ${LAYERDIR}/lib oe + addpylib ${LAYERDIR}/lib oe + +- BitBake has seen multiple internal changes that may impact
Re: [OE-core] [meta][dunfell][PATCH] busybox: Make high ASCII chars printable
Hi Nikhil, On 29.03.23 at 08:47, nikhil wrote: Currently busybox utilty "ls" fails to display filenames contains UTF-8 characters and replaces with "?". Steps to reproduce: bin/busybox touch utf_test-Ü bin/busybox ls utf_test-* > sample.log bin/busybox cat sample.log utf_test-?? bin/busybox hexdump -C sample.log | grep "c3 9c" Therefore, above hexdump command is unable to find matching hex value for the umlaute character. Hence, change the libbb's printable_string() function to allow high ASCII characters so that unicode filenames are displayed correctly. This issue is not observed in upstream busybox. Signed-off-by: Sana Kazi Signed-off-by: Sana Kazi Signed-off-by: Nikhil R --- .../270-libbb_make_unicode_printable.patch| 39 +++ meta/recipes-core/busybox/busybox_1.31.1.bb | 1 + 2 files changed, 40 insertions(+) create mode 100644 meta/recipes-core/busybox/busybox/270-libbb_make_unicode_printable.patch Thanks for the patch! There's an issue with your e-mail identity. You should add one thing to your git configuration, so that your patches are given an "Author" field which matches your "Signed-off-by" information. See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity for details. Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#179306): https://lists.openembedded.org/g/openembedded-core/message/179306 Mute This Topic: https://lists.openembedded.org/mt/97923178/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] maintainers.inc: Modify email address
Hi Zang Thanks for the patch! On 20.03.23 at 09:11, zrc_work via lists.openembedded.org wrote: From: zangruochen zangrc.f...@fujitsu.com -> zangruoc...@loongson.cn Signed-off-by: zangruochen However... * Your Signed-off-by information doesn't carry your full name. You should be able to fix it by running: git config --global user.name "Zang Ruochen" * Your "From:" identity is incomplete too. You may need to follow instructions on https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity, but this may be fixed by just running the first step. Don't hesitate to send me an update through a private message first. I'll be happy to help with testing. Thanks in advance Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#178804): https://lists.openembedded.org/g/openembedded-core/message/178804 Mute This Topic: https://lists.openembedded.org/mt/97726736/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v2] libpng: Enable NEON for aarch64 to enensure consistency with arm32.
Hi Lei, On 10.01.23 at 04:31, leimaohui wrote: NEON is enabled for aarch64 by default, so, to ensure consistency with arm32, reference to libpng-1.6.38/configure, added enable_hardware_optimizations option for aarch64. Signed-off-by: Lei Maohui Many thanks for your contributions to the project! However, for future commits, we'd need you to do add one thing to your git configuration, so that your patches are given an "Author" field which matches your "Signed-off-by" information. See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity for details. Don't hesitate to send a patch test directly to me, if you wish. Thanks in advance Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#178648): https://lists.openembedded.org/g/openembedded-core/message/178648 Mute This Topic: https://lists.openembedded.org/mt/96170221/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [DISTRO|MACHINE]_FEATURES_BACKFILL_CONSIDERED: confusing variable names?
Greetings, Thank you all for your replies and comments! On 24.02.23 at 00:24, Tom Hochstein wrote: I agree. The problem I have with these variable names is that it's ambiguous whether the features will be included or excluded from the backfill. All you can tell from the names is that the values were 'considered'. What does that mean? You have to go to the manual to find the full meaning. What's important about the variables is that they will be 'excluded' from the backfill, so this does look much clearer to me: DISTRO_FEATURES_BACKFILL_EXCLUDED += "some-feature" Richard, would you accept it if I sent a patch replacing "BACKFILL_CONSIDERED" by "BACKFILL_EXCLUDED" in the two variables? Of course, I can understand if that's too late for the next release, and instead document this oddity, at least before we can make a change again. Is there a good reason why we have this separate variable and can't just do this? DISTRO_FEATURES_BACKFILL:remove = "some-feature" Good question. Maybe because ":remove" is final, and cannot be overridden, if I understood correctly? Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#177831): https://lists.openembedded.org/g/openembedded-core/message/177831 Mute This Topic: https://lists.openembedded.org/mt/97187180/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-