Re: [OE-Core][PATCH v2 1/4] classes: go-vendor: Add go-vendor class

[Ulrich Ölmann]

# only take the version which is explicitly listed
> +# as a dependency in the go.mod
> +module = modules[module_key]
> +src = module['src']
> +
> +# If the module is released at major version 2 or higher, the module
> +# path must end with a major version suffix like /v2.
> +# This may or may not be part of the subdirectory name
> +#
> +# https://go.dev/ref/mod#modules-overview
> +srcMajorVersion = os.path.join(src, module['pathMajor'].strip('/'))
> +if os.path.exists(srcMajorVersion):
> +src = srcMajorVersion
> +dst = os.path.join(vendor_dir, module_key)
> +if os.path.exists(dst):
> +shutil.rmtree(dst)
> +
> +bb.debug(1, "cp %s --> %s" % (src, dst))
> +shutil.copytree(src, dst, symlinks=True, \
> +ignore=shutil.ignore_patterns(".git", \
> +"vendor", \
> +"*.md", \
> +"*._test.go"))
> +# Copy vendor manifest
> +bb.debug(1, "cp %s --> %s" % (os.path.join(d.getVar('WORKDIR'), 
> "modules.txt"), vendor_dir))
> +shutil.copy2(os.path.join(d.getVar('WORKDIR'), "modules.txt"), 
> vendor_dir)
> +}
> +
> +addtask go_vendor before do_populate_lic after do_unpack
-- 
Pengutronix e.K.   | Ulrich Ölmann   |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189369): 
https://lists.openembedded.org/g/openembedded-core/message/189369
Mute This Topic: https://lists.openembedded.org/mt/102017390/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] packagegroup-base: clean up setting packagegroup-machine-base's SUMMARY

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/recipes-core/packagegroups/packagegroup-base.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb 
b/meta/recipes-core/packagegroups/packagegroup-base.bb
index 83907ca20663..70a10350031d 100644
--- a/meta/recipes-core/packagegroups/packagegroup-base.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
@@ -129,7 +129,6 @@ RRECOMMENDS:packagegroup-distro-base = 
"${DISTRO_EXTRA_RRECOMMENDS}"
 #
 # packages added by machine config
 #
-SUMMARY:packagegroup-machine-base = "${MACHINE} extras"
 SUMMARY:packagegroup-machine-base = "Extra packages required to fully support 
${MACHINE} hardware"
 RDEPENDS:packagegroup-machine-base = "${MACHINE_EXTRA_RDEPENDS}"
 RRECOMMENDS:packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}"
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188391): 
https://lists.openembedded.org/g/openembedded-core/message/188391
Mute This Topic: https://lists.openembedded.org/mt/101653428/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] weston: fix comment

[Ulrich Ölmann]

Fixes: be7da75827b4 ("weston: update 11.0.1 -> 12.0.1")
Signed-off-by: Ulrich Ölmann 
---
 meta/recipes-graphics/wayland/weston_12.0.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/wayland/weston_12.0.1.bb 
b/meta/recipes-graphics/wayland/weston_12.0.1.bb
index d9eae1ff62f3..8c2438cdaa5b 100644
--- a/meta/recipes-graphics/wayland/weston_12.0.1.bb
+++ b/meta/recipes-graphics/wayland/weston_12.0.1.bb
@@ -70,7 +70,7 @@ PACKAGECONFIG[egl] = 
"-Drenderer-gl=true,-Drenderer-gl=false,virtual/egl"
 PACKAGECONFIG[lcms] = 
"-Dcolor-management-lcms=true,-Dcolor-management-lcms=false,lcms"
 # Weston with webp support
 PACKAGECONFIG[webp] = "-Dimage-webp=true,-Dimage-webp=false,libwebp"
-# Weston with systemd-login support
+# Weston with systemd support
 PACKAGECONFIG[systemd] = "-Dsystemd=true,-Dsystemd=false,systemd dbus"
 # Weston with Xwayland support (requires X11 and Wayland)
 PACKAGECONFIG[xwayland] = "-Dxwayland=true,-Dxwayland=false,libxcb libxcursor 
xcb-util-cursor xwayland"
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#187010): 
https://lists.openembedded.org/g/openembedded-core/message/187010
Mute This Topic: https://lists.openembedded.org/mt/101097295/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] base: fix typos

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/classes-global/base.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes-global/base.bbclass b/meta/classes-global/base.bbclass
index 64e805c9476c..b6e339ed9c53 100644
--- a/meta/classes-global/base.bbclass
+++ b/meta/classes-global/base.bbclass
@@ -288,7 +288,7 @@ python base_eventhandler() {
 bb.plain('\n%s\n%s\n' % (statusheader, '\n'.join(statuslines)))
 
 # This code is to silence warnings where the SDK variables overwrite the 
-# target ones and we'd see dulpicate key names overwriting each other
+# target ones and we'd see duplicate key names overwriting each other
 # for various PREFERRED_PROVIDERS
 if isinstance(e, bb.event.RecipePreFinalise):
 if d.getVar("TARGET_PREFIX") == d.getVar("SDK_PREFIX"):
@@ -351,7 +351,7 @@ base_do_compile() {
 
 addtask install after do_compile
 do_install[dirs] = "${B}"
-# Remove and re-create ${D} so that is it guaranteed to be empty
+# Remove and re-create ${D} so that it is guaranteed to be empty
 do_install[cleandirs] = "${D}"
 
 base_do_install() {
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#178104): 
https://lists.openembedded.org/g/openembedded-core/message/178104
Mute This Topic: https://lists.openembedded.org/mt/97447453/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] kernel-yocto: fix kernel-meta data detection

[Ulrich Ölmann]

Fixes: 7ef7af5c03ba ("kernel-yocto: restore kernel-meta data detection for 
SRC_URI elements")
Signed-off-by: Ulrich Ölmann 
---
 meta/classes-recipe/kernel-yocto.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/kernel-yocto.bbclass 
b/meta/classes-recipe/kernel-yocto.bbclass
index 1a6695ba7e35..7de99cff5642 100644
--- a/meta/classes-recipe/kernel-yocto.bbclass
+++ b/meta/classes-recipe/kernel-yocto.bbclass
@@ -212,7 +212,7 @@ do_kernel_metadata() {
# SRC_URI. If they were supplied, we convert them into include 
directives
# for the update part of the process
for f in ${feat_dirs}; do
-   if [ -d "${WORKDIR}/$f/meta" ]; then
+   if [ -d "${WORKDIR}/$f/kernel-meta" ]; then
includes="$includes -I${WORKDIR}/$f/kernel-meta"
elif [ -d "${WORKDIR}/../oe-local-files/$f" ]; then
includes="$includes -I${WORKDIR}/../oe-local-files/$f"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177137): 
https://lists.openembedded.org/g/openembedded-core/message/177137
Mute This Topic: https://lists.openembedded.org/mt/96956989/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] update-alternatives: fix typos

[Ulrich Ölmann]

---
 meta/classes-recipe/update-alternatives.bbclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/classes-recipe/update-alternatives.bbclass 
b/meta/classes-recipe/update-alternatives.bbclass
index 55e0b954d62e..36a7497fec8b 100644
--- a/meta/classes-recipe/update-alternatives.bbclass
+++ b/meta/classes-recipe/update-alternatives.bbclass
@@ -5,7 +5,7 @@
 #
 
 # This class is used to help the alternatives system which is useful when
-# multiple sources provide same command. You can use update-alternatives
+# multiple sources provide the same command. You can use update-alternatives
 # command directly in your recipe, but in most cases this class simplifies
 # that job.
 #
@@ -35,7 +35,7 @@
 # A non-default link to create for a target
 # ALTERNATIVE_TARGET[name] = "target"
 #
-#   This is the name of the binary as it's been install by do_install
+#   This is the name of the binary as it's been installed by do_install
 #   i.e. ALTERNATIVE_TARGET[sh] = "/bin/bash"
 #
 # A package specific link for a target
@@ -68,7 +68,7 @@ ALTERNATIVE_PRIORITY = "10"
 
 # We need special processing for vardeps because it can not work on
 # modified flag values.  So we aggregate the flags into a new variable
-# and include that vairable in the set.
+# and include that variable in the set.
 UPDALTVARS  = "ALTERNATIVE ALTERNATIVE_LINK_NAME ALTERNATIVE_TARGET 
ALTERNATIVE_PRIORITY"
 
 PACKAGE_WRITE_DEPS += "virtual/update-alternatives-native"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176835): 
https://lists.openembedded.org/g/openembedded-core/message/176835
Mute This Topic: https://lists.openembedded.org/mt/96820130/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH 2/2] lsof: fix old override syntax

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/recipes-extended/lsof/lsof_4.96.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/lsof/lsof_4.96.5.bb 
b/meta/recipes-extended/lsof/lsof_4.96.5.bb
index 9f80176ee13b..a1f2c45c69bb 100644
--- a/meta/recipes-extended/lsof/lsof_4.96.5.bb
+++ b/meta/recipes-extended/lsof/lsof_4.96.5.bb
@@ -15,7 +15,7 @@ S = "${WORKDIR}/git"
 
 inherit update-alternatives
 
-ALTERNATIVE_${PN} = "lsof"
+ALTERNATIVE:${PN} = "lsof"
 ALTERNATIVE_LINK_NAME[lsof] = "${sbindir}/lsof"
 # Make our priority higher than busybox
 ALTERNATIVE_PRIORITY = "100"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176817): 
https://lists.openembedded.org/g/openembedded-core/message/176817
Mute This Topic: https://lists.openembedded.org/mt/96808032/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH 1/2] recipe_sanity: fix old override syntax

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/classes/recipe_sanity.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/recipe_sanity.bbclass 
b/meta/classes/recipe_sanity.bbclass
index 1c2e24c6a176..a5cc4315fb86 100644
--- a/meta/classes/recipe_sanity.bbclass
+++ b/meta/classes/recipe_sanity.bbclass
@@ -16,7 +16,7 @@ def bad_runtime_vars(cfgdata, d):
 for var in d.getVar("__recipe_sanity_badruntimevars").split():
 val = d.getVar(var, False)
 if val and val != cfgdata.get(var):
-__note("%s should be %s_${PN}" % (var, var), d)
+__note("%s should be %s:${PN}" % (var, var), d)
 
 __recipe_sanity_reqvars = "DESCRIPTION"
 __recipe_sanity_reqdiffvars = ""
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176816): 
https://lists.openembedded.org/g/openembedded-core/message/176816
Mute This Topic: https://lists.openembedded.org/mt/96808031/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-Core][PATCH v2 1/3] kernel: classes: Extract savedefconfig to a class

[Ulrich Ölmann]

On Wed, Oct 12 2022 at 20:43 +0100, "Alex Kiernan"  
wrote:
> On Wed, Oct 12, 2022 at 5:36 PM Ross Burton  wrote:
>>
>> On 12 Oct 2022, at 08:18, Alex Kiernan via lists.openembedded.org 
>>  wrote:
>> >
>> > Move savedefconfig task to a class so we can reuse it in other recipes
>> > which support it.
>>
>> There are three users of cml1 in oe-core: kernel, uboot, and busybox.  Does 
>> busybox support savedefconfig?
>>
>
> It doesn't and fairly obviously goes boom...
>
> ERROR: busybox-1.35.0-r0 do_savedefconfig: oe_runmake failed
> ERROR: busybox-1.35.0-r0 do_savedefconfig:
> ExecutionError('/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/temp/run.do_savedefconfig.12421',
> 1, None, None)
> ERROR: Logfile of failure stored in:
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/temp/log.do_savedefconfig.12421
> Log data follows:
> | DEBUG: Executing shell function do_savedefconfig
> | Saving defconfig to:
> | 
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0/defconfig
> | NOTE: make CC=x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2
> -msse3 -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> --sysroot=/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/recipe-sysroot
> LD=x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> --sysroot=/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/recipe-sysroot
> V=1 ARCH=x86_64 CROSS_COMPILE=x86_64-poky-linux- SKIP_STRIP=y
> HOSTCC=gcc  HOSTCPP=gcc  -E -C
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0
> savedefconfig
> | make: Entering directory
> '/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0'
> | make -f scripts/Makefile.build obj=scripts/basic
> | 
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0/scripts/gen_build_files.sh
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0
> /home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0
> | mkdir -p include
> | make -f scripts/Makefile.build obj=scripts/kconfig savedefconfig
> | make[1]: *** No rule to make target 'savedefconfig'.  Stop.
> | make: *** [Makefile:444: savedefconfig] Error 2
> | make: Leaving directory
> '/home/alexk/poky/build/tmp/work/core2-64-poky-linux/busybox/1.35.0-r0/busybox-1.35.0'
> | ERROR: oe_runmake failed
>
>> I’m thinking to avoid tiny classes we can just add this to
>> cml1.bbclass and make it print a decent error message if it doesn’t
>> work.
>>
>
> So where I started, was adding it to u-boot.inc (which isn't a class,
> I guess an artefact of history), because tiny classes felt like a poor
> choice. I can add it to cml1 instead, at which point I've tried all
> three options, maybe that's the best option and if you have a consumer
> that doesn't do it, you just get a fail as above.
>
> Are there are other users of cml1 other than these three? My suspicion
> is there isn't (though I've only looked at layers I've got checked
> out).

There is the barebox bootloader which supports 'savedefconfig', whose
recipe in meta-ptx uses cml1 via [2] and which would benefit from this
change.

Best regards
Ulrich


[1] https://barebox.org/
[2] 
https://github.com/pengutronix/meta-ptx/blob/master/recipes-bsp/barebox/barebox.inc#L12
-- 
Pengutronix e.K.   | Ulrich Ölmann   |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171680): 
https://lists.openembedded.org/g/openembedded-core/message/171680
Mute This Topic: https://lists.openembedded.org/mt/94276340/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] icecc.bbclass: fix filename of recipe in comment

[Ulrich Ölmann]

The character '%' is not a valid part of a recipe filename and has been used
here only to suggest a wildcard regarding the recipe's version, see reply [1] in
a companioned thread. Correct that by using the current recipe version instead.

[1] https://lists.yoctoproject.org/g/docs/message/3165

Signed-off-by: Ulrich Ölmann 
---
 meta/classes/icecc.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index e478ba488ce0..312e0f17b554 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -22,7 +22,7 @@
 # but nothing is sure. ;)
 #
 # If ICECC_ENV_EXEC is set in local.conf, then it should point to the 
icecc-create-env script provided by the user
-# or the default one provided by icecc-create-env_%.bb will be used.
+# or the default one provided by icecc-create-env_0.1.bb will be used.
 # (NOTE that this is a modified version of the needed script and *not the one 
that comes with icecream*).
 #
 # User can specify if specific recipes or recipes inheriting specific classes 
should not use icecc to distribute
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#170654): 
https://lists.openembedded.org/g/openembedded-core/message/170654
Mute This Topic: https://lists.openembedded.org/mt/93675187/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH 1/2] icecc.bbclass: fix typos

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/classes/icecc.bbclass | 46 +++---
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index a11e781f00f7..8f06e9dd7082 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -4,35 +4,35 @@
 # SPDX-License-Identifier: MIT
 #
 
-# IceCream distributed compiling support
+# Icecream distributed compiling support
 #
 # Stages directories with symlinks from gcc/g++ to icecc, for both
 # native and cross compilers. Depending on each configure or compile,
 # the directories are added at the head of the PATH list and ICECC_CXX
-# and ICEC_CC are set.
+# and ICECC_CC are set.
 #
 # For the cross compiler, creates a tar.gz of our toolchain and sets
 # ICECC_VERSION accordingly.
 #
 # The class now handles all 3 different compile 'stages' (i.e native 
,cross-kernel and target) creating the
 # necessary environment tar.gz file to be used by the remote machines.
-# It also supports meta-toolchain generation
+# It also supports meta-toolchain generation.
 #
 # If ICECC_PATH is not set in local.conf then the class will try to locate it 
using 'bb.utils.which'
-# but nothing is sure ;)
+# but nothing is sure. ;)
 #
 # If ICECC_ENV_EXEC is set in local.conf, then it should point to the 
icecc-create-env script provided by the user
-# or the default one provided by icecc-create-env.bb will be used
-# (NOTE that this is a modified version of the script need it and *not the one 
that comes with icecc*
+# or the default one provided by icecc-create-env_%.bb will be used.
+# (NOTE that this is a modified version of the needed script and *not the one 
that comes with icecream*).
 #
-# User can specify if specific recipes or recipes belonging to class should 
not use icecc to distribute
-# compile jobs to remote machines, but handled locally, by defining 
ICECC_CLASS_DISABLE and ICECC_RECIPE_DISABLE
+# User can specify if specific recipes or recipes inheriting specific classes 
should not use icecc to distribute
+# compile jobs to remote machines, but handle them locally by defining 
ICECC_CLASS_DISABLE and ICECC_RECIPE_DISABLE
 # with the appropriate values in local.conf. In addition the user can force to 
enable icecc for recipes
 # which set an empty PARALLEL_MAKE variable by defining ICECC_RECIPE_ENABLE.
 #
 
#
-#Error checking is kept to minimum so double check any parameters you pass to 
the class
-###
+# Error checking is kept to minimum so double check any parameters you pass to 
the class
+#
 
 BB_BASEHASH_IGNORE_VARS += "ICECC_PARALLEL_MAKE ICECC_DISABLED 
ICECC_RECIPE_DISABLE \
 ICECC_CLASS_DISABLE ICECC_RECIPE_ENABLE ICECC_PATH ICECC_ENV_EXEC \
@@ -50,7 +50,7 @@ HOSTTOOLS_NONFATAL += "icecc patchelf"
 # invalidate the version on the compile nodes. Changing it will cause a new
 # environment to be created.
 #
-# A useful thing to do for testing Icecream changes locally is to add a
+# A useful thing to do for testing icecream changes locally is to add a
 # subversion in local.conf:
 #  ICECC_ENV_VERSION:append = "-my-ver-1"
 ICECC_ENV_VERSION = "2"
@@ -72,16 +72,16 @@ CXXFLAGS += "${ICECC_CFLAGS}"
 ICECC_ENV_DEBUG ??= ""
 
 # Disable recipe list contains a list of recipes that can not distribute
-# compile tasks for one reason or the other. When adding new entry, please
+# compile tasks for one reason or the other. When adding a new entry, please
 # document why (how it failed) so that we can re-evaluate it later e.g. when
-# there is new version
+# there is a new version.
 #
 # libgcc-initial - fails with CPP sanity check error if host sysroot contains
-#  cross gcc built for another target tune/variant
+#  cross gcc built for another target tune/variant.
 # pixman - prng_state: TLS reference mismatches non-TLS reference, possibly 
due to
-#  pragma omp threadprivate(prng_state)
+#  pragma omp threadprivate(prng_state).
 # systemtap - _HelperSDT.c undefs macros and uses the identifiers in macros 
emitting
-# inline assembly
+# inline assembly.
 # target-sdk-provides-dummy - ${HOST_PREFIX} is empty which triggers the "NULL
 # prefix" error.
 ICECC_RECIPE_DISABLE += "\
@@ -91,10 +91,10 @@ ICECC_RECIPE_DISABLE += "\
 target-sdk-provides-dummy \
 "
 
-# Classes that should not use icecc. When adding new entry, please
-# document why (how it failed) so that we can re-evaluate it later
+# Classes that should not use icecc. When adding a new entry, please
+# document why (how it failed) so that we can re-evaluate it l

[OE-core] [PATCH 2/2] icecc.bbclass: delete 'rm' command

[Ulrich Ölmann]

The removed command was explicitly marked as transitional in commit [1] roughly
three years ago, so finally clean up.

[1] 40d74cb1d0dd ("icecc: Export ICECC_CC and friends via wrapper-script")

Signed-off-by: Ulrich Ölmann 
---
 meta/classes/icecc.bbclass | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index 8f06e9dd7082..e478ba488ce0 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -380,7 +380,6 @@ set_icecc_env() {
 fi
 for compiler in $compilers; do
 ln -sf $ICECC_BIN $ICE_PATH/symlinks/$compiler
-rm -f $ICE_PATH/$compiler
 cat <<-__EOF__ > $ICE_PATH/$compiler
#!/bin/sh -e
export ICECC_VERSION=$ICECC_VERSION
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#170384): 
https://lists.openembedded.org/g/openembedded-core/message/170384
Mute This Topic: https://lists.openembedded.org/mt/93522114/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] scripts/runqemu.README: fix typos and trailing whitespaces

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 scripts/runqemu.README | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/scripts/runqemu.README b/scripts/runqemu.README
index da9abd7dfbfc..e5f4b4634cba 100644
--- a/scripts/runqemu.README
+++ b/scripts/runqemu.README
@@ -1,12 +1,12 @@
 Using OE images with QEMU
 =
 
-OE-Core can generate qemu bootable kernels and images with can be used 
+OE-Core can generate qemu bootable kernels and images which can be used
 on a desktop system. The scripts currently support booting ARM, MIPS, PowerPC
-and x86 (32 and 64 bit) images. The scripts can be used within the OE build 
-system or externaly.
+and x86 (32 and 64 bit) images. The scripts can be used within the OE build
+system or externally.
 
-The runqemu script is run as: 
+The runqemu script is run as:
 
runqemu   
 
@@ -15,13 +15,13 @@ where:
 is the machine/architecture to use 
(qemuarm/qemumips/qemuppc/qemux86/qemux86-64)
 is the path to a kernel (e.g. zimage-qemuarm.bin)
 is the path to an ext2 image (e.g. filesystem-qemuarm.ext2) or 
an nfs directory
-   
-If  isn't specified, the script will try to detect the machine name 
+
+If  isn't specified, the script will try to detect the machine name
 from the name of the  file.
 
 If  isn't specified, nfs booting will be assumed.
 
-When used within the build system, it will default to qemuarm, ext2 and the 
last kernel and 
+When used within the build system, it will default to qemuarm, ext2 and the 
last kernel and
 core-image-sato-sdk image built by the build system. If an sdk image isn't 
present it will look
 for sato and minimal images.
 
@@ -31,7 +31,7 @@ Full usage instructions can be seen by running the command 
with no options speci
 Notes
 =
 
- - The scripts run qemu using sudo. Change perms on /dev/net/tun to 
+ - The scripts run qemu using sudo. Change perms on /dev/net/tun to
run as non root. The runqemu-gen-tapdevs script can also be used by
root to prepopulate the appropriate network devices.
  - You can access the host computer at 192.168.7.1 within the image.
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#170109): 
https://lists.openembedded.org/g/openembedded-core/message/170109
Mute This Topic: https://lists.openembedded.org/mt/93368588/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH 2/4] wic: rawcopy: Add support for packed images

[Ulrich Ölmann]

Hi Stefan,

On Fri, Feb 11 2022 at 17:35 +0100, "Stefan Herbrechtsmeier" 
 wrote:
> Am 11.02.2022 um 17:17 schrieb Ulrich Ölmann:
>> On Thu, Feb 10 2022 at 17:17 +0100, "Stefan Herbrechtsmeier" 
>>  wrote:
>>> From: Stefan Herbrechtsmeier 
>>>
>>> Add support for packed images to wic rawcopy handler do minimize disk
>>> usage in deploy directory and reuse of packed images between wic and
>>> swupdate. Add `unpack` to sourceparams to unpack an bz2, gz and xz
>>> archives.
>>>
>>> Example:
>>> part / --source rawcopy 
>>> --sourceparams="file=core-image-minimal-qemu.ext4.gz,unpack"
>>>
>>> Signed-off-by: Stefan Herbrechtsmeier 
>>> 
>>>
>>> ---
>>>
>>>   scripts/lib/wic/plugins/source/rawcopy.py | 28 ++-
>>>   1 file changed, 27 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/lib/wic/plugins/source/rawcopy.py 
>>> b/scripts/lib/wic/plugins/source/rawcopy.py
>>> index fa7b1eb8ac..7816e00e49 100644
>>> --- a/scripts/lib/wic/plugins/source/rawcopy.py
>>> +++ b/scripts/lib/wic/plugins/source/rawcopy.py
>>> @@ -4,6 +4,8 @@
>>> import logging
>>>   import os
>>> +import signal
>>> +import subprocess
>>> from wic import WicError
>>>   from wic.pluginbase import SourcePlugin
>>> @@ -38,6 +40,24 @@ class RawCopyPlugin(SourcePlugin):
>>> exec_cmd(cmd)
>>>   +@staticmethod
>>> +def do_image_uncompression(src, dst, workdir):
>>> +def subprocess_setup():
>>> +# Python installs a SIGPIPE handler by default. This is 
>>> usually not what
>>> +# non-Python subprocesses expect.
>>> +# SIGPIPE errors are known issues with gzip/bash
>>> +signal.signal(signal.SIGPIPE, signal.SIG_DFL)
>>> +
>>> +decompressor = {
>>> +".bz2": "bzip2",
>>> +".gz": "gzip",
>>> +".xz": "xz"
>>> +}.get(os.path.splitext(src)[1])
>>> +if not decompressor:
>>> +raise WicError("Compression not support")
>> Here is a small typo: s/support/supported/ .
>> And what about substituting "Compression" by "Compressor" to express
>> that not compression in general but only this individual compressor is
>> currently unsupported? (Or even better: in addition explicitely name the
>> currently unsupported compressor in the error message?)
>
> What about the following:
>
> Not supported compressor extension: %s

of course, that also sounds like a good alternative.

Have a nice weekend!
Ulrich


> Best regards
>   Stefan
-- 
Pengutronix e.K.   | Ulrich Ölmann   |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161659): 
https://lists.openembedded.org/g/openembedded-core/message/161659
Mute This Topic: https://lists.openembedded.org/mt/89049086/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH 2/4] wic: rawcopy: Add support for packed images

[Ulrich Ölmann]

Hi Stefan!

On Thu, Feb 10 2022 at 17:17 +0100, "Stefan Herbrechtsmeier" 
 wrote:
> From: Stefan Herbrechtsmeier 
>
> Add support for packed images to wic rawcopy handler do minimize disk
> usage in deploy directory and reuse of packed images between wic and
> swupdate. Add `unpack` to sourceparams to unpack an bz2, gz and xz
> archives.
>
> Example:
> part / --source rawcopy 
> --sourceparams="file=core-image-minimal-qemu.ext4.gz,unpack"
>
> Signed-off-by: Stefan Herbrechtsmeier 
>
> ---
>
>  scripts/lib/wic/plugins/source/rawcopy.py | 28 ++-
>  1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/plugins/source/rawcopy.py 
> b/scripts/lib/wic/plugins/source/rawcopy.py
> index fa7b1eb8ac..7816e00e49 100644
> --- a/scripts/lib/wic/plugins/source/rawcopy.py
> +++ b/scripts/lib/wic/plugins/source/rawcopy.py
> @@ -4,6 +4,8 @@
>  
>  import logging
>  import os
> +import signal
> +import subprocess
>  
>  from wic import WicError
>  from wic.pluginbase import SourcePlugin
> @@ -38,6 +40,24 @@ class RawCopyPlugin(SourcePlugin):
>  
>  exec_cmd(cmd)
>  
> +@staticmethod
> +def do_image_uncompression(src, dst, workdir):
> +def subprocess_setup():
> +# Python installs a SIGPIPE handler by default. This is usually 
> not what
> +# non-Python subprocesses expect.
> +# SIGPIPE errors are known issues with gzip/bash
> +signal.signal(signal.SIGPIPE, signal.SIG_DFL)
> +
> +decompressor = {
> +".bz2": "bzip2",
> +".gz": "gzip",
> +".xz": "xz"
> +}.get(os.path.splitext(src)[1])
> +if not decompressor:
> +raise WicError("Compression not support")

Here is a small typo: s/support/supported/ .

And what about substituting "Compression" by "Compressor" to express
that not compression in general but only this individual compressor is
currently unsupported? (Or even better: in addition explicitely name the
currently unsupported compressor in the error message?)

Best regards
Ulrich


> +cmd = "%s -dc %s > %s" % (decompressor, src, dst)
> +subprocess.call(cmd, preexec_fn=subprocess_setup, shell=True, 
> cwd=workdir)
> +
>  @classmethod
>  def do_prepare_partition(cls, part, source_params, cr, cr_workdir,
>   oe_builddir, bootimg_dir, kernel_dir,
> @@ -56,7 +76,13 @@ class RawCopyPlugin(SourcePlugin):
>  if 'file' not in source_params:
>  raise WicError("No file specified")
>  
> -src = os.path.join(kernel_dir, source_params['file'])
> +if 'unpack' in source_params:
> +img = os.path.join(kernel_dir, source_params['file'])
> +src = os.path.join(cr_workdir, 
> os.path.splitext(source_params['file'])[0])
> +RawCopyPlugin.do_image_uncompression(img, src, cr_workdir)
> +else:
> +src = os.path.join(kernel_dir, source_params['file'])
> +
>  dst = os.path.join(cr_workdir, "%s.%s" % 
> (os.path.basename(source_params['file']), part.lineno))
>  
>  if not os.path.exists(os.path.dirname(dst)):
-- 
Pengutronix e.K.   | Ulrich Ölmann   |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161657): 
https://lists.openembedded.org/g/openembedded-core/message/161657
Mute This Topic: https://lists.openembedded.org/mt/89049086/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] gstreamer1.0-plugins-base: add support for graphene

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 .../gstreamer/gstreamer1.0-plugins-base_1.18.5.bb   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.5.bb 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.5.bb
index 5e2cca3864e7..180241828fe4 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.5.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.5.bb
@@ -43,6 +43,7 @@ X11DISABLEOPTS = "-Dx11=disabled -Dxvideo=disabled 
-Dxshm=disabled"
 
 PACKAGECONFIG[alsa] = "-Dalsa=enabled,-Dalsa=disabled,alsa-lib"
 PACKAGECONFIG[cdparanoia]   = 
"-Dcdparanoia=enabled,-Dcdparanoia=disabled,cdparanoia"
+PACKAGECONFIG[graphene] = 
"-Dgl-graphene=enabled,-Dgl-graphene=disabled,graphene"
 PACKAGECONFIG[jpeg] = "-Dgl-jpeg=enabled,-Dgl-jpeg=disabled,jpeg"
 PACKAGECONFIG[ogg]  = "-Dogg=enabled,-Dogg=disabled,libogg"
 PACKAGECONFIG[opus] = "-Dopus=enabled,-Dopus=disabled,libopus"
@@ -71,7 +72,6 @@ OPENGL_WINSYS = "${@bb.utils.filter('PACKAGECONFIG', 'x11 gbm 
wayland dispmanx e
 
 EXTRA_OEMESON += " \
 -Ddoc=disabled \
--Dgl-graphene=disabled \
 ${@get_opengl_cmdline_list('gl_api', d.getVar('OPENGL_APIS'), d)} \
 ${@get_opengl_cmdline_list('gl_platform', d.getVar('OPENGL_PLATFORMS'), 
d)} \
 ${@get_opengl_cmdline_list('gl_winsys', d.getVar('OPENGL_WINSYS'), d)} \
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#158480): 
https://lists.openembedded.org/g/openembedded-core/message/158480
Mute This Topic: https://lists.openembedded.org/mt/87154156/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] initramfs-framework/setup-live: fix shebang

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/recipes-core/initrdscripts/initramfs-framework/setup-live | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/initrdscripts/initramfs-framework/setup-live 
b/meta/recipes-core/initrdscripts/initramfs-framework/setup-live
index 4c79f412857c..7e92f93322b2 100644
--- a/meta/recipes-core/initrdscripts/initramfs-framework/setup-live
+++ b/meta/recipes-core/initrdscripts/initramfs-framework/setup-live
@@ -1,4 +1,4 @@
-#/bin/sh
+#!/bin/sh
 # Copyright (C) 2011 O.S. Systems Software LTDA.
 # Licensed on MIT
 
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154039): 
https://lists.openembedded.org/g/openembedded-core/message/154039
Mute This Topic: https://lists.openembedded.org/mt/84365214/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] initramfs-framework: fix whitespace issue

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb 
b/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
index c53a0c03ae6c..fe24215b465d 100644
--- a/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
+++ b/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
@@ -31,7 +31,7 @@ do_install() {
 install -m 0755 ${WORKDIR}/rootfs ${D}/init.d/90-rootfs
 install -m 0755 ${WORKDIR}/finish ${D}/init.d/99-finish
 
-   # exec
+# exec
 install -m 0755 ${WORKDIR}/exec ${D}/init.d/89-exec
 
 # mdev
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154037): 
https://lists.openembedded.org/g/openembedded-core/message/154037
Mute This Topic: https://lists.openembedded.org/mt/84364193/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] local.conf.sample: fix typo

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/conf/local.conf.sample | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
index 870509cf1ff8..652bd477339e 100644
--- a/meta/conf/local.conf.sample
+++ b/meta/conf/local.conf.sample
@@ -167,7 +167,7 @@ PATCHRESOLVE = "noop"
 #
 # Monitor the disk space during the build. If there is less that 1GB of space 
or less
 # than 100K inodes in any key build location (TMPDIR, DL_DIR, SSTATE_DIR), 
gracefully
-# shutdown the build. If there is less that 100MB or 1K inodes, perform a hard 
abort
+# shutdown the build. If there is less than 100MB or 1K inodes, perform a hard 
abort
 # of the build. The reason for this is that running completely out of space 
can corrupt
 # files and damages the build in ways which may not be easily recoverable.
 # It's necessary to monitor /tmp, if there is no space left the build will fail
-- 
2.29.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151637): 
https://lists.openembedded.org/g/openembedded-core/message/151637
Mute This Topic: https://lists.openembedded.org/mt/82773665/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] arch-armv6m.inc: fix access rights

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/conf/machine/include/arm/arch-armv6m.inc | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 meta/conf/machine/include/arm/arch-armv6m.inc

diff --git a/meta/conf/machine/include/arm/arch-armv6m.inc 
b/meta/conf/machine/include/arm/arch-armv6m.inc
old mode 100755
new mode 100644
-- 
2.29.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#150271): 
https://lists.openembedded.org/g/openembedded-core/message/150271
Mute This Topic: https://lists.openembedded.org/mt/81920996/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] local.conf.sample: fix typo

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann 
---
 meta/conf/local.conf.sample | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
index 3318e983a78f..870509cf1ff8 100644
--- a/meta/conf/local.conf.sample
+++ b/meta/conf/local.conf.sample
@@ -185,7 +185,7 @@ BB_DISKMON_DIRS ??= "\
 #
 # Shared-state files from other locations
 #
-# As mentioned above, shared state files are prebuilt cache data objects which 
can
+# As mentioned above, shared state files are prebuilt cache data objects which 
can be
 # used to accelerate build time. This variable can be used to configure the 
system
 # to search other mirror locations for these objects before it builds the data 
itself.
 #
-- 
2.29.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149062): 
https://lists.openembedded.org/g/openembedded-core/message/149062
Mute This Topic: https://lists.openembedded.org/mt/81110865/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH v2] squashfs-tools: upgrade to commit f95864afe883

[Ulrich Ölmann]

The master branch's current tip commit as of this writing is [1], see the
squashfs-tool's repo at [0].

Because of commits [2]-[4] which are included in the master branch three
corresponding patches are dropped as they are not needed anymore. The single
remaining patch was rebased on top of [1] to apply cleanly.

Commits [5] & [6] introduced interesting features, namely zstd support and
reproducibility of created SquashFS images. They are reflected in two new
PACKAGECONFIG options now, but only the latter ("reproducible") is appended to
the default options as OE-core does not contain a recipe to build zstd at the
moment (a working zstd recipe can be found e.g. in meta-rauc, see [7]).

[0] https://github.com/plougher/squashfs-tools.git
[1] f95864afe883 ("unsquashfs-4: Add more sanity checks + fix CVE-2015-4645/6")
[2] 46bdc1726e5a ("mksquashfs: Make a load of functions static")
[3] b0ca8a5c98ff ("pseudo.c: add explicit  include")
[4] f95864afe883 ("unsquashfs-4: Add more sanity checks + fix CVE-2015-4645/6")
[5] 6113361316d5 ("squashfs-tools: Add zstd support")
[6] e0d74d07bb35 ("Add configuration and Mksquashfs build options for
   reproducible builds")
[7] https://layers.openembedded.org/layerindex/recipe/79049/

Signed-off-by: Ulrich Ölmann 
---

Changes since (implicit) v1:

  * dropped "zstd" from default options
  * refer to meta-rauc's zstd recipe in the commit message

 ...c-get-inline-functions-work-with-C99.patch | 154 --
 ...shfs-tools-patch-for-CVE-2015-4645-6.patch |  47 --
 .../squashfs-tools/fix-compat.patch   |  17 --
 .../squashfs-tools-4.3-sysmacros.patch|   2 +-
 .../squashfs-tools/squashfs-tools_git.bb  |   9 +-
 5 files changed, 5 insertions(+), 224 deletions(-)
 delete mode 100644 
meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-mksquashfs.c-get-inline-functions-work-with-C99.patch
 delete mode 100644 
meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-squashfs-tools-patch-for-CVE-2015-4645-6.patch
 delete mode 100644 
meta/recipes-devtools/squashfs-tools/squashfs-tools/fix-compat.patch

diff --git 
a/meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-mksquashfs.c-get-inline-functions-work-with-C99.patch
 
b/meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-mksquashfs.c-get-inline-functions-work-with-C99.patch
deleted file mode 100644
index a5bab054486a..
--- 
a/meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-mksquashfs.c-get-inline-functions-work-with-C99.patch
+++ /dev/null
@@ -1,154 +0,0 @@
-From ac6268e843c43286eebff2a1052182c2393cdb2e Mon Sep 17 00:00:00 2001
-From: Roy Li 
-Date: Mon, 14 Sep 2015 12:31:42 +0800
-Subject: [PATCH] mksquashfs.c:  get inline functions work with both gnu11 and 
gnu89
-
-Upstream-Status: Pending
-
-After gcc upgraded to gcc5, and if the codes is compiled without 
optimization(-O0),
-and the below error will happen:
-
-| mksquashfs.o: In function `create_inode':
-| git/squashfs-tools/mksquashfs.c:897: undefined reference to `get_inode_no'
-| git/squashfs-tools/mksquashfs.c:960: undefined reference to `get_parent_no'
-| git/squashfs-tools/mksquashfs.c:983: undefined reference to `get_parent_no'
-| mksquashfs.o: In function `reader_read_process':
-| git/squashfs-tools/mksquashfs.c:2132: undefined reference to `is_fragment'
-| mksquashfs.o: In function `reader_read_file':
-| git/squashfs-tools/mksquashfs.c:2228: undefined reference to `is_fragment'
-| mksquashfs.o: In function `dir_scan':
-| git/squashfs-tools/mksquashfs.c:3101: undefined reference to 
`create_dir_entry'
-
-gcc5 defaults to -std=gnu11 instead of -std=gnu89, and it requires that 
exactly one C
-source file has the callable copy of the inline function. Consider the 
following
-program:
-
-  inline int
-  foo (void)
-  {
-return 42;
-  }
-
-  int
-  main (void)
-  {
-return foo ();
-  }
-
-The program above will not link with the C99 inline semantics, because no 
out-of-line
-function foo is generated. To fix this, either mark the function foo as 
static, or
-add the following declaration:
-  static inline int foo (void);
-
-more information refer to: https://gcc.gnu.org/gcc-5/porting_to.html;
-
-but the use of "extern inline" will lead to the compilation issue if gcc is not
-gcc5, as the commit in oe-core d0af30c92fde [alsa-lib: Change function type to
-"static __inline__"]
-"extern __inline__ function()" is the inlined version that
-can be used in this compilation unit, but there will be another
-definition of this function somewhere, so compiler will not emit
-any code for the function body. This causes problem in -O0,
-where functions are never inlined, the function call is preserved,
-but linker can't find the symbol, thus the error happens.
-
-so replace "inline" with "static inline" to make it work with both gnu11 an

Re: [OE-core] [PATCH] squashfs-tools: upgrade to commit f95864afe883

[Ulrich Ölmann]

On Thu, Jul 18 2019 at 08:19 +0200, Adrian Bunk  wrote:
> On Wed, Jul 17, 2019 at 11:57:42AM +0100, richard.pur...@linuxfoundation.org 
> wrote:
>> On Wed, 2019-07-17 at 12:51 +0200, Ulrich Ölmann wrote:
>> > Hi Richard,
>> > 
>> > On Wed, Jul 17 2019 at 11:19 +0200, Richard Purdie <
>> > richard.pur...@linuxfoundation.org> wrote:
>> > > On Tue, 2019-07-16 at 15:54 +0200, Ulrich Ölmann wrote:  
>> > > > [...] 
>> > > > -PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr"
>> > > > +PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr zstd reproducible"
>> > > > [...] 
>> > > > +PACKAGECONFIG[zstd] = "ZSTD_SUPPORT=1,ZSTD_SUPPORT=0,zstd"
>> > > > +PACKAGECONFIG[reproducible] =
>> > > > "REPRODUCIBLE_DEFAULT=1,REPRODUCIBLE_DEFAULT=0,"
>> > > 
>> > > This fails in OE-Core since zstd isn't present and you've enabled
>> > > that
>> > > by default:
>> > > 
>> > > e.g.:
>> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/827
>> > > 
>> > > (but many other similar failures).
>> > > 
>> > > Adding the PACKAGECONFIG[zstd] is good, we just can't enable it by
>> > > default.
>> > 
>> > see my reply to Adrian: what do you think of transplanting the zstd
>> > recipe from meta-rauc to OE-core?
>> 
>> I think right now that zstd is not common enough to be something for
>> oe-core. If multiple people reply and disagree I'm willing to reasses
>> that but that's my feeling right now...
>
> zstd not even being in meta-oe is a surprise that should be corrected.
>
> btrfs-tools would be the only user that comes immediately into my mind,
> but zstd support in the kernel btrfs driver is relatively new and not
> yet widely used.
>
> zstd has already gotten a lot of traction in the Open Source world,
> but regarding adding it to oe-core right now one could argue either way.

Nobody stood up and objected in the last 24h, so I will send a v2 that
simply drops "zstd" from the set of default options and refers to
meta-rauc's recipe.

>> Cheers,
>> 
>> Richard
>
> cu
> Adrian

Best regards
Ulrich
-- 
Pengutronix e.K.   | Ulrich Ölmann   |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] squashfs-tools: upgrade to commit f95864afe883

[Ulrich Ölmann]

Hi Richard,

On Wed, Jul 17 2019 at 11:19 +0200, Richard Purdie 
 wrote:
> On Tue, 2019-07-16 at 15:54 +0200, Ulrich Ölmann wrote:  
>> [...] 
>> -PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr"
>> +PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr zstd reproducible"
>> [...] 
>> +PACKAGECONFIG[zstd] = "ZSTD_SUPPORT=1,ZSTD_SUPPORT=0,zstd"
>> +PACKAGECONFIG[reproducible] = 
>> "REPRODUCIBLE_DEFAULT=1,REPRODUCIBLE_DEFAULT=0,"
>
> This fails in OE-Core since zstd isn't present and you've enabled that
> by default:
>
> e.g.:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/827
>
> (but many other similar failures).
>
> Adding the PACKAGECONFIG[zstd] is good, we just can't enable it by
> default.

see my reply to Adrian: what do you think of transplanting the zstd
recipe from meta-rauc to OE-core?

Best regards
Ulrich
-- 
Pengutronix e.K.   | Ulrich Ölmann   |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] squashfs-tools: upgrade to commit f95864afe883

[Ulrich Ölmann]

Hi Adrian,

On Wed, Jul 17 2019 at 11:08 +0200, Adrian Bunk  wrote:
> On Tue, Jul 16, 2019 at 03:54:44PM +0200, Ulrich Ölmann wrote:
>>...
>> Commits [5] & [6] introduced interesting features, namely zstd support and
>> reproducibility of created SquashFS images. They are reflected in two new
>> PACKAGECONFIG options now.
>>...
>> -PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr"
>> +PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr zstd reproducible"
>>...
>
> zstd is not in OE-core, so this cannot be enabled by default.

of course... although I should have known better I missed that as in the
BSP I used to develop this patch I include meta-rauc which offers zstd
(see [1]).

I could send a v2 that does not enable zstd by default, but still offers
the PACKAGECONFIG[zstd]. Otherwise if you like zstd to become a member
of OE-core (as the other supported compressors already are) I could
prepare a patch series with meta-rauc's zstd-recipe as a base for the
update of the squashfs-tools. In the latter case meta-rauc could drop
that recipe in the future and that's what we would prefer. What do you
think?

Best regards
Ulrich


[1] https://layers.openembedded.org/layerindex/recipe/79049/
-- 
Pengutronix e.K.   | Ulrich Ölmann   |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] squashfs-tools: upgrade to commit f95864afe883

[Ulrich Ölmann]

The master branch's current tip commit as of this writing is [1], see the
squashfs-tool's repo at [0].

Because of commits [2]-[4] which are included in the master branch three
corresponding patches are dropped as they are not needed anymore. The single
remaining patch was rebased on top of [1] to apply cleanly.

Commits [5] & [6] introduced interesting features, namely zstd support and
reproducibility of created SquashFS images. They are reflected in two new
PACKAGECONFIG options now.

[0] https://github.com/plougher/squashfs-tools.git
[1] f95864afe883 ("unsquashfs-4: Add more sanity checks + fix CVE-2015-4645/6")
[2] 46bdc1726e5a ("mksquashfs: Make a load of functions static")
[3] b0ca8a5c98ff ("pseudo.c: add explicit  include")
[4] f95864afe883 ("unsquashfs-4: Add more sanity checks + fix CVE-2015-4645/6")
[5] 6113361316d5 ("squashfs-tools: Add zstd support")
[6] e0d74d07bb35 ("Add configuration and Mksquashfs build options for
   reproducible builds")

Signed-off-by: Ulrich Ölmann 
---
 ...c-get-inline-functions-work-with-C99.patch | 154 --
 ...shfs-tools-patch-for-CVE-2015-4645-6.patch |  47 --
 .../squashfs-tools/fix-compat.patch   |  17 --
 .../squashfs-tools-4.3-sysmacros.patch|   2 +-
 .../squashfs-tools/squashfs-tools_git.bb  |   9 +-
 5 files changed, 5 insertions(+), 224 deletions(-)
 delete mode 100644 
meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-mksquashfs.c-get-inline-functions-work-with-C99.patch
 delete mode 100644 
meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-squashfs-tools-patch-for-CVE-2015-4645-6.patch
 delete mode 100644 
meta/recipes-devtools/squashfs-tools/squashfs-tools/fix-compat.patch

diff --git 
a/meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-mksquashfs.c-get-inline-functions-work-with-C99.patch
 
b/meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-mksquashfs.c-get-inline-functions-work-with-C99.patch
deleted file mode 100644
index a5bab054486a..
--- 
a/meta/recipes-devtools/squashfs-tools/squashfs-tools/0001-mksquashfs.c-get-inline-functions-work-with-C99.patch
+++ /dev/null
@@ -1,154 +0,0 @@
-From ac6268e843c43286eebff2a1052182c2393cdb2e Mon Sep 17 00:00:00 2001
-From: Roy Li 
-Date: Mon, 14 Sep 2015 12:31:42 +0800
-Subject: [PATCH] mksquashfs.c:  get inline functions work with both gnu11 and 
gnu89
-
-Upstream-Status: Pending
-
-After gcc upgraded to gcc5, and if the codes is compiled without 
optimization(-O0),
-and the below error will happen:
-
-| mksquashfs.o: In function `create_inode':
-| git/squashfs-tools/mksquashfs.c:897: undefined reference to `get_inode_no'
-| git/squashfs-tools/mksquashfs.c:960: undefined reference to `get_parent_no'
-| git/squashfs-tools/mksquashfs.c:983: undefined reference to `get_parent_no'
-| mksquashfs.o: In function `reader_read_process':
-| git/squashfs-tools/mksquashfs.c:2132: undefined reference to `is_fragment'
-| mksquashfs.o: In function `reader_read_file':
-| git/squashfs-tools/mksquashfs.c:2228: undefined reference to `is_fragment'
-| mksquashfs.o: In function `dir_scan':
-| git/squashfs-tools/mksquashfs.c:3101: undefined reference to 
`create_dir_entry'
-
-gcc5 defaults to -std=gnu11 instead of -std=gnu89, and it requires that 
exactly one C
-source file has the callable copy of the inline function. Consider the 
following
-program:
-
-  inline int
-  foo (void)
-  {
-return 42;
-  }
-
-  int
-  main (void)
-  {
-return foo ();
-  }
-
-The program above will not link with the C99 inline semantics, because no 
out-of-line
-function foo is generated. To fix this, either mark the function foo as 
static, or
-add the following declaration:
-  static inline int foo (void);
-
-more information refer to: https://gcc.gnu.org/gcc-5/porting_to.html;
-
-but the use of "extern inline" will lead to the compilation issue if gcc is not
-gcc5, as the commit in oe-core d0af30c92fde [alsa-lib: Change function type to
-"static __inline__"]
-"extern __inline__ function()" is the inlined version that
-can be used in this compilation unit, but there will be another
-definition of this function somewhere, so compiler will not emit
-any code for the function body. This causes problem in -O0,
-where functions are never inlined, the function call is preserved,
-but linker can't find the symbol, thus the error happens.
-
-so replace "inline" with "static inline" to make it work with both gnu11 and 
gnu89
-
-Signed-off-by: Roy Li 

- squashfs-tools/mksquashfs.c | 20 ++--
- 1 file changed, 10 insertions(+), 10 deletions(-)
-
-diff --git a/squashfs-tools/mksquashfs.c b/squashfs-tools/mksquashfs.c
-index d221c35..6bba1d2 100644
 a/squashfs-tools/mksquashfs.c
-+++ b/squashfs-tools/mksquashfs.c
-@@ -828,13 +828,13 @@ char *subpathname(struct dir_ent *dir_ent)
- }
- 
- 
--inline unsi

Re: [OE-core] [PATCH v2 3/4] mesa: make gallium swrast target optional

[Ulrich Ölmann]

Hi there,

On Thu, May 02 2019 at 20:09 +0200, Marco Felsch  
wrote:
> Most the time we are compiling for embedded targets which have dedicated
> hardware combinations. Setting swrast default on isn't a good solution
> for such devices because if the hardware render node have an issue or
> don't support a special format/request mesa will fallback to the
> software renderer. This will make it harder to debug performace issues.
>
> A better way is to let the user deciced if a software renderer is
> needed e.g. if the system has no hardware renderer or to have such a
> fallback device. This way the user knows that the software renderer is
> enabled.
>
> Upstream-Status: Submitted [openembedded-core@lists.openembedded.org]
>
> Signed-off-by: Marco Felsch 
> ---
> Changelog:
>
> v2:
> - added Upstream-Status line
> - fix leading comma
>
>  meta/recipes-graphics/mesa/mesa.inc | 21 -
>  1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-graphics/mesa/mesa.inc 
> b/meta/recipes-graphics/mesa/mesa.inc
> index 7516a06639..b41d3054c3 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -86,24 +86,27 @@ PACKAGECONFIG[egl] = "-Degl=true, -Degl=false"
>
>  PACKAGECONFIG[etnaviv] = ""
>  PACKAGECONFIG[kmsro] = ""
> +PACKAGECONFIG[swrast] = ""
>
> -GALLIUMDRIVERS = "swrast"
> -GALLIUMDRIVERS_append ="${@bb.utils.contains('PACKAGECONFIG', 'etnaviv', 
> ',etnaviv', '', d)}"
> -GALLIUMDRIVERS_append ="${@bb.utils.contains('PACKAGECONFIG', 'kmsro', 
> ',kmsro', '', d)}"
> +GALLIUMDRIVERS = ""
> +GALLIUMDRIVERS +="${@bb.utils.contains('PACKAGECONFIG', 'swrast', 'swrast', 
> '', d)}"
> +GALLIUMDRIVERS +="${@bb.utils.contains('PACKAGECONFIG', 'etnaviv', 
> 'etnaviv', '', d)}"
> +GALLIUMDRIVERS +="${@bb.utils.contains('PACKAGECONFIG', 'kmsro', 'kmsro', 
> '', d)}"
>
>  # radeonsi requires LLVM
> -GALLIUMDRIVERS_LLVM33 = "${@bb.utils.contains('PACKAGECONFIG', 'r600', 
> ',radeonsi', '', d)}"
> +GALLIUMDRIVERS_LLVM33 = "${@bb.utils.contains('PACKAGECONFIG', 'r600', 
> 'radeonsi', '', d)}"
>  GALLIUMDRIVERS_LLVM33_ENABLED = 
> "${@oe.utils.version_less_or_equal('MESA_LLVM_RELEASE', '3.2', False, 
> len('${GALLIUMDRIVERS_LLVM33}') > 0, d)}"
> -GALLIUMDRIVERS_LLVM = "r300,svga,nouveau${@',${GALLIUMDRIVERS_LLVM33}' if 
> ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}"
> +GALLIUMDRIVERS_LLVM = "r300 svga nouveau ${@'${GALLIUMDRIVERS_LLVM33}' if 
> ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}"
>
>  PACKAGECONFIG[r600] = ""
>
> -GALLIUMDRIVERS_append = "${@bb.utils.contains('PACKAGECONFIG', 
> 'gallium-llvm', ',${GALLIUMDRIVERS_LLVM}', '', d)}"
> -GALLIUMDRIVERS_append = "${@bb.utils.contains('PACKAGECONFIG', 'r600', 
> ',r600', '', d)}"
> -GALLIUMDRIVERS_append = ",virgl"
> +GALLIUMDRIVERS += "${@bb.utils.contains('PACKAGECONFIG', 'gallium-llvm', 
> '${GALLIUMDRIVERS_LLVM}', '', d)}"
> +GALLIUMDRIVERS += "${@bb.utils.contains('PACKAGECONFIG', 'r600', 'r600', '', 
> d)}"
> +GALLIUMDRIVERS += "virgl"
> +GALLIUMDRIVERS_MESON = "${@",".join("${GALLIUMDRIVERS}".split())}"

how does it have to look like if I want to go without this auxiliary
variable GALLIUMDRIVERS_MESON and instead insert the Python expression
that generates its content directly into ...

>  # keep --with-gallium-drivers separate, because when only one of gallium 
> versions is enabled, other 2 were adding --without-gallium-drivers
> -PACKAGECONFIG[gallium] = "-Dgallium-drivers=${GALLIUMDRIVERS}, 
> -Dgallium-drivers=''"
> +PACKAGECONFIG[gallium] = "-Dgallium-drivers=${GALLIUMDRIVERS_MESON}, 
> -Dgallium-drivers=''"

... the above assignment of PACKAGECONFIG[gallium]?
I can't get it to work - perhaps it is a problem with escaping things?

Best regards
Ulrich


>  MESA_LLVM_RELEASE ?= "8.0.0"
>  PACKAGECONFIG[gallium-llvm] = "-Dllvm=true -Dshared-llvm=true, -Dllvm=false, 
> llvm${MESA_LLVM_RELEASE} llvm-native \
> ${@'elfutils' if 
> ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}"
-- 
Pengutronix e.K.   | Ulrich Ölmann   |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] openssh: Atomically generate host keys

[Ulrich Ölmann]

On Tue, May 23, 2017 at 03:37:16PM +0100, Burton, Ross wrote:
> On 7 May 2017 at 02:33, Joshua Watt  wrote:
> > diff --git a/meta/recipes-connectivity/openssh/openssh/sshdgenkeys.service
> > b/meta/recipes-connectivity/openssh/openssh/sshdgenkeys.service
> > index 148e6ad..af56404 100644
> > --- a/meta/recipes-connectivity/openssh/openssh/sshdgenkeys.service
> > +++ b/meta/recipes-connectivity/openssh/openssh/sshdgenkeys.service
> > @@ -1,22 +1,14 @@
> >  [Unit]
> >  Description=OpenSSH Key Generation
> >  RequiresMountsFor=/var /run
> > -ConditionPathExists=!/var/run/ssh/ssh_host_rsa_key
> > -ConditionPathExists=!/var/run/ssh/ssh_host_dsa_key
> > -ConditionPathExists=!/var/run/ssh/ssh_host_ecdsa_key
> > -ConditionPathExists=!/var/run/ssh/ssh_host_ed25519_key
> > -ConditionPathExists=!/etc/ssh/ssh_host_rsa_key
> > -ConditionPathExists=!/etc/ssh/ssh_host_dsa_key
> > -ConditionPathExists=!/etc/ssh/ssh_host_ecdsa_key
> > -ConditionPathExists=!/etc/ssh/ssh_host_ed25519_key
> >
> 
> Can you not continue to use ConditionPathExists to only run this unit if it
> needs to run?  You can prepend the argument with | to make them logical OR
> instead of logical AND, if I'm reading this documentation correctly.

Am I right that if we have a read-write mounted root-FS with already existing
keys in /etc/ssh the service unit will nevertheless be started on _every_ boot
now as the files which are checked for existance in /var/run/ssh are missing?

Best regards
Ulrich
-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] busybox: move default config fragments to defconfig

[Ulrich Ölmann]

On Wed, Mar 29, 2017 at 08:23:00AM -0700, Andre McCurdy wrote:
> On Wed, Mar 29, 2017 at 3:24 AM, Richard Purdie
>  wrote:
> >
> > Also, in case its not apparent, you can work around this today by
> > providing empty fragment files in your own layer. These would override
> > the default ones in the main recipe if you set it up right.
> 
> Or use SRC_URI_remove = "file://login-utilities.cfg" etc.

But for both suggested approaches you need to know the existance and name of the
config fragment file(s), don't you?

Regards
Ulrich
-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] Contents of non-rootfs partitions

[Ulrich Ölmann]

Hi,

On Wed, Nov 23, 2016 at 04:56:56PM +0100, Patrick Ohly wrote:
> On Wed, 2016-11-23 at 15:22 +0200, Ed Bartosh wrote:
> > On Wed, Nov 23, 2016 at 02:08:28PM +0100, Kristian Amlie wrote:
> > > On 23/11/16 13:08, Ed Bartosh wrote:
> > > > On Tue, Nov 22, 2016 at 12:54:52PM +0100, Kristian Amlie wrote:
> > > > [...]
> > > > This can be done by extending existing rootfs plugin. It should be able
> > > > to do 2 things:
> > > > 
> > > > - populate content of one rootfs directory to the partition. We can
> > > >   extend syntax of --rootfs-dir parameter to specify optional directory 
> > > > path to use
> > > > 
> > > > - exclude rootfs directories when populating partitions. I'd propose to
> > > >   introduce --exclude-dirs wks parser option to handle this.
> > > > 
> > > > Example of wks file with proposed new options:
> > > > part / --source rootfs --rootfs-dir=core-image-minimal   
> > > > --ondisk sda --fstype=ext4 --label root --align 1024 --exclude-dirs 
> > > > data --exclude-dirs home
> > > > part /data --source rootfs --rootfs-dir=core-image-minimal:/home 
> > > > --ondisk sda --fstype=ext4 --label data --align 1024
> > > > part /home --source rootfs --rootfs-dir=core-image-minimal:/data 
> > > > --ondisk sda --fstype=ext4 --label data --align 1024
> > > > 
> > > > Does this make sense?
> > > 
> > > Looks good. The only thing I would question is that, in the interest of
> > > reducing redundancy, maybe we should omit --exclude-dirs and have wic
> > > figure this out by combining all the entries, since "--exclude-dirs
> > > " and the corresponding "part " will almost always come in
> > > pairs. Possibly we could mark the "/" partition with one single
> > > --no-overlapping-dirs to force wic to make this consideration. Or do you
> > > think that's too magical?
> > >
> > Tt's quite implicit from my point of view. However, if people like it we
> > can implement it this way.
> 
> I prefer the explicit --exclude-dirs. It's less surprising and perhaps
> there are usages for having the same content in different partitions
> (redundancy, factory reset, etc.).
> 
> Excluding only the directory content but not the actual directory is
> indeed a good point. I'm a bit undecided. When excluding only the
> directory content, there's no way of building a rootfs without that
> mount point, if that's desired. OTOH, when excluding also the directory,
> the data would have to be staged under a different path in the rootfs
> and the mount point would have to be a separate, empty directory.
> 
> I'm leaning towards excluding the directory content and keeping the
> directory.

what about having both possibilities by leaning against the syntax that rsync
uses to specify if a whole source directory or only it's contents shall be
synced to some destination site (see [1])?

In analogy to this to exclude only the contents of the directory named 'data'
you would use

  --exclude-dirs data/

but to additionally exclude the dir itself as well it would read

  --exclude-dirs data

Best regards
Ulrich

[1] http://man.cx/rsync(1)#heading6
-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] nfs-utils: bugfix: adjust name of statd service unit

[Ulrich Ölmann]

On Wed, Mar 23, 2016 at 07:18:38AM -0600, Dan McGregor wrote:
> Oh, I did backport it locally, I was just hoping to get it into the
> upstream jethro branch.

Let's see what upstream decides.

> Cherry picking your commit was pretty straightforward.

:)

Regards
Ulrich

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] nfs-utils: bugfix: adjust name of statd service unit

[Ulrich Ölmann]

Hi Dan,

On Tue, Mar 22, 2016 at 06:34:08PM -0600, Dan McGregor wrote:
> On 17 Feb 2016 3:48 a.m., "Ulrich Ölmann" <u.oelm...@pengutronix.de> wrote:
> >
> > Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
> > 'nfs-statd.service' instead but forgot to update the mount.nfs helper
> > 'start-statd' accordingly.
> >
> > Signed-off-by: Ulrich Ölmann <u.oelm...@pengutronix.de>
> > ---
> >  .../files/bugfix-adjust-statd-service-name.patch   | 34
> ++
> >  .../nfs-utils/nfs-utils_1.3.3.bb   |  1 +
> >  2 files changed, 35 insertions(+)
> >  create mode 100644
> meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch

[...]

> I just got bit by this in jethro. Can it be backported?

Backporting should be fairly simple, I assume you didn't give it a go.
Try the patch that comes in my reply to this mail. It is untested as I don't
have the time at the moment, hence please report back if it works.

Regards
Ulrich
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [jethro][PATCH] nfs-utils: bugfix: adjust name of statd service unit

[Ulrich Ölmann]

Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
'nfs-statd.service' instead but forgot to update the mount.nfs helper
'start-statd' accordingly.

Signed-off-by: Ulrich Ölmann <u.oelm...@pengutronix.de>
---
 .../files/bugfix-adjust-statd-service-name.patch   | 34 ++
 .../nfs-utils/nfs-utils_1.3.1.bb   |  1 +
 2 files changed, 35 insertions(+)
 create mode 100644 
meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch

diff --git 
a/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
 
b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
new file mode 100644
index 000..14bd403
--- /dev/null
+++ 
b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
@@ -0,0 +1,34 @@
+From 398fed3bb0350cb1229e54e7020ae0e044c206d1 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Ulrich=20=C3=96lmann?= <u.oelm...@pengutronix.de>
+Date: Wed, 17 Feb 2016 08:33:45 +0100
+Subject: bugfix: adjust statd service name
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Upstream uses 'rpc-statd.service' and Yocto introduced 'nfs-statd.service'
+instead but forgot to update the mount.nfs helper 'start-statd' accordingly.
+
+Upstream-Status: Inappropriate [other]
+
+Signed-off-by: Ulrich Ölmann <u.oelm...@pengutronix.de>
+---
+ utils/statd/start-statd | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/utils/statd/start-statd b/utils/statd/start-statd
+index 8211a90..3c2aa6f 100755
+--- a/utils/statd/start-statd
 b/utils/statd/start-statd
+@@ -16,7 +16,7 @@ fi
+ # First try systemd if it's installed.
+ if [ -d /run/systemd/system ]; then
+ # Quit only if the call worked.
+-systemctl start rpc-statd.service && exit
++systemctl start nfs-statd.service && exit
+ fi
+ 
+ # Fall back to launching it ourselves.
+-- 
+2.1.4
+
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.1.bb 
b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.1.bb
index 42101de..f346fdc 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.1.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.1.bb
@@ -31,6 +31,7 @@ SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x
file://proc-fs-nfsd.mount \
file://nfs-utils-Do-not-pass-CFLAGS-to-gcc-while-building.patch \
file://nfs-utils-debianize-start-statd.patch \
+   file://bugfix-adjust-statd-service-name.patch \
 "
 
 SRC_URI[md5sum] = "8de676b9ff34b8f9addc1d0800fabdf8"
-- 
2.7.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] nfs-utils: bugfix: adjust name of statd service unit

[Ulrich Ölmann]

Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
'nfs-statd.service' instead but forgot to update the mount.nfs helper
'start-statd' accordingly.

Signed-off-by: Ulrich Ölmann <u.oelm...@pengutronix.de>
---
 .../files/bugfix-adjust-statd-service-name.patch   | 34 ++
 .../nfs-utils/nfs-utils_1.3.3.bb   |  1 +
 2 files changed, 35 insertions(+)
 create mode 100644 
meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch

diff --git 
a/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
 
b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
new file mode 100644
index 000..14bd403
--- /dev/null
+++ 
b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
@@ -0,0 +1,34 @@
+From 398fed3bb0350cb1229e54e7020ae0e044c206d1 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Ulrich=20=C3=96lmann?= <u.oelm...@pengutronix.de>
+Date: Wed, 17 Feb 2016 08:33:45 +0100
+Subject: bugfix: adjust statd service name
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Upstream uses 'rpc-statd.service' and Yocto introduced 'nfs-statd.service'
+instead but forgot to update the mount.nfs helper 'start-statd' accordingly.
+
+Upstream-Status: Inappropriate [other]
+
+Signed-off-by: Ulrich Ölmann <u.oelm...@pengutronix.de>
+---
+ utils/statd/start-statd | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/utils/statd/start-statd b/utils/statd/start-statd
+index 8211a90..3c2aa6f 100755
+--- a/utils/statd/start-statd
 b/utils/statd/start-statd
+@@ -16,7 +16,7 @@ fi
+ # First try systemd if it's installed.
+ if [ -d /run/systemd/system ]; then
+ # Quit only if the call worked.
+-systemctl start rpc-statd.service && exit
++systemctl start nfs-statd.service && exit
+ fi
+ 
+ # Fall back to launching it ourselves.
+-- 
+2.1.4
+
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb 
b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
index ea00656..a6268f3 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
@@ -32,6 +32,7 @@ SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x
file://nfs-utils-Do-not-pass-CFLAGS-to-gcc-while-building.patch \
file://nfs-utils-debianize-start-statd.patch \

file://0001-nfs-utils-statd-fix-a-segfault-caused-by-improper-us.patch \
+   file://bugfix-adjust-statd-service-name.patch \
 "
 
 SRC_URI[md5sum] = "cd6b568c2e9301cc3bfac09d87fbbc0b"
-- 
2.7.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core