Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-22 Thread Khem Raj 
On Thu, Mar 22, 2018 at 9:14 AM, Burton, Ross  wrote:
> On 22 March 2018 at 16:12, Randy MacLeod  wrote:
>> Best if we could pitch this to the meson devs on their list:
>>
>> The Meson Build System 
>>
>> The earlier that we describe the problem and our proposed solution with them
>> the better.
>
> There's already a bug filed against Meson for installable test cases,
> but nobody is working on it right now.

while that gets worked, we can create a general template in meson.bbclass may be
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-22 Thread Burton, Ross 
On 22 March 2018 at 16:12, Randy MacLeod  wrote:
> Best if we could pitch this to the meson devs on their list:
>
> The Meson Build System 
>
> The earlier that we describe the problem and our proposed solution with them
> the better.

There's already a bug filed against Meson for installable test cases,
but nobody is working on it right now.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-22 Thread Randy MacLeod 

On 2018-03-22 07:14 AM, Alexander Kanavin wrote:

On 03/22/2018 08:06 AM, ChenQi wrote:

The test framework meson uses is like:

|e = executable('prog', 'testprog.c') test('name of test', e)|


http://mesonbuild.com/Unit-tests.html

So they could be defined in any valid meson.build file. In systemd's 
case, most of them are in top-level meson.build.


I agree with you that it's possible to extract all these test cases 
and hold them in a custom script we write. I think this could serve 
as a fall-back approach to adding ptest support for systemd.
But I'd like to spend some time to try to find a more general 
approach, avoiding headaches when upgrading.


That's right. We probably need to put some kind of 'hook' inside 
meson's test() that would copy the test case to a ptest directory, 
instead of running it.


Alex



Best if we could pitch this to the meson devs on their list:

    The Meson Build System 

The earlier that we describe the problem and our proposed solution with 
them the better.


../Randy

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-22 Thread Alexander Kanavin 

On 03/22/2018 08:06 AM, ChenQi wrote:

The test framework meson uses is like:

|e = executable('prog', 'testprog.c') test('name of test', e)|


http://mesonbuild.com/Unit-tests.html

So they could be defined in any valid meson.build file. In systemd's 
case, most of them are in top-level meson.build.


I agree with you that it's possible to extract all these test cases and 
hold them in a custom script we write. I think this could serve as a 
fall-back approach to adding ptest support for systemd.
But I'd like to spend some time to try to find a more general approach, 
avoiding headaches when upgrading.


That's right. We probably need to put some kind of 'hook' inside meson's 
test() that would copy the test case to a ptest directory, instead of 
running it.


Alex
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-22 Thread ChenQi 

On 03/21/2018 02:00 AM, Burton, Ross wrote:
On 20 March 2018 at 17:36, Khem Raj > wrote:


>> @@ -80,7 +78,7 @@ PACKAGECONFIG ??= " \
>>  polkit \
>>  quotacheck \
>>  randomseed \
>> -resolved \
>> +resolve \
>
> I guess this was deliberate, but does it need picking up in release
> notes? Tripped up my builds off of master - clearly a trivial fix
> though.

hmm good catch but why change ?


Bah, didn't notice this.

Chen, can you submit a patch to change this back?

Ross



Hi All,

I've sent out a patch to change 'resolve' back to 'resolved'.

Sorry for causing troubles for you.
I used 'resolve' because meson_options.txt uses the word 'resolve' 
instead of 'resolved'.

But I now know that backward compatibility is more important.

Best Regards,
Chen Qi
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-22 Thread ChenQi 

On 03/19/2018 05:04 PM, Alexander Kanavin wrote:

On 03/19/2018 06:53 AM, ChenQi wrote:


For autotools,
1) if the test framework of some package is a standalone set of 
scripts or it could be easily decoupled from Makefile, adding ptest 
support for such package is easy.
2) if the test framework of some package is coupled with Makefile, we 
need to adjust or replace vars in Makefile, install make on target 
and rely on the Makefile to run tests. In such case, adding ptest is 
not easy.


For meson, the test framework is coupled with meson/ninja. We need to 
at least install ninja and meson on target as a first step. Maybe we 
need to adjust other things in do_install_ptest. That's why I said 
"there's no easy way to add ptest support."


Why didn't I look further into this problem? Because I view ptest 
support as optional, not necessary.
What I thought was: "let's upgrade the package first. If ptest 
support is required from community, deal with that in a separate patch."


Now that I've got feedback from you, I think I'll look further into 
this issue and try to add ptest support via a separate patch.


But is it tightly coupled with meson/ninja? From what I see here:

https://github.com/systemd/systemd/blob/master/test/meson.build

there is no testing logic as such in the meson.build file, it simply 
runs a few test scripts, and checks the outcome. Which we can easily 
replicate in a script.


Alex



Hi Alex,

The test framework meson uses is like:

|e = executable('prog', 'testprog.c') test('name of test', e)|


http://mesonbuild.com/Unit-tests.html

So they could be defined in any valid meson.build file. In systemd's 
case, most of them are in top-level meson.build.


I agree with you that it's possible to extract all these test cases and 
hold them in a custom script we write. I think this could serve as a 
fall-back approach to adding ptest support for systemd.
But I'd like to spend some time to try to find a more general approach, 
avoiding headaches when upgrading.


Best Regards,
Chen Qi

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-20 Thread Burton, Ross 
On 20 March 2018 at 17:36, Khem Raj  wrote:

> >> @@ -80,7 +78,7 @@ PACKAGECONFIG ??= " \
> >>  polkit \
> >>  quotacheck \
> >>  randomseed \
> >> -resolved \
> >> +resolve \
> >
> > I guess this was deliberate, but does it need picking up in release
> > notes? Tripped up my builds off of master - clearly a trivial fix
> > though.
>
> hmm good catch but why change ?


Bah, didn't notice this.

Chen, can you submit a patch to change this back?

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-20 Thread Khem Raj 
On Tue, Mar 20, 2018 at 10:19 AM, Alex Kiernan  wrote:
> On Mon, Mar 12, 2018 at 8:38 AM, Chen Qi  wrote:
>> Upgrade systemd to 237.
>>
>
> ...
>
>> @@ -80,7 +78,7 @@ PACKAGECONFIG ??= " \
>>  polkit \
>>  quotacheck \
>>  randomseed \
>> -resolved \
>> +resolve \
>
> I guess this was deliberate, but does it need picking up in release
> notes? Tripped up my builds off of master - clearly a trivial fix
> though.

hmm good catch but why change ?

>
> --
> Alex Kiernan
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-20 Thread Alex Kiernan 
On Mon, Mar 12, 2018 at 8:38 AM, Chen Qi  wrote:
> Upgrade systemd to 237.
>

...

> @@ -80,7 +78,7 @@ PACKAGECONFIG ??= " \
>  polkit \
>  quotacheck \
>  randomseed \
> -resolved \
> +resolve \

I guess this was deliberate, but does it need picking up in release
notes? Tripped up my builds off of master - clearly a trivial fix
though.

-- 
Alex Kiernan
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-19 Thread Alexander Kanavin 

On 03/19/2018 06:53 AM, ChenQi wrote:


For autotools,
1) if the test framework of some package is a standalone set of scripts 
or it could be easily decoupled from Makefile, adding ptest support for 
such package is easy.
2) if the test framework of some package is coupled with Makefile, we 
need to adjust or replace vars in Makefile, install make on target and 
rely on the Makefile to run tests. In such case, adding ptest is not easy.


For meson, the test framework is coupled with meson/ninja. We need to at 
least install ninja and meson on target as a first step. Maybe we need 
to adjust other things in do_install_ptest. That's why I said "there's 
no easy way to add ptest support."


Why didn't I look further into this problem? Because I view ptest 
support as optional, not necessary.
What I thought was: "let's upgrade the package first. If ptest support 
is required from community, deal with that in a separate patch."


Now that I've got feedback from you, I think I'll look further into this 
issue and try to add ptest support via a separate patch.


But is it tightly coupled with meson/ninja? From what I see here:

https://github.com/systemd/systemd/blob/master/test/meson.build

there is no testing logic as such in the meson.build file, it simply 
runs a few test scripts, and checks the outcome. Which we can easily 
replicate in a script.


Alex
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-18 Thread Khem Raj 



On 3/18/18 9:53 PM, ChenQi wrote:

On 03/17/2018 03:27 AM, Alexander Kanavin wrote:

On 03/16/2018 09:30 PM, Randy MacLeod wrote:

This new version has dropped ptest support, as there's no easy
way to do this in the framework of meson.


Are you talking to the meson developers to see if we/they can
come up with a way to do that? Is there an issue opened:
    https://github.com/mesonbuild/meson/issues
I didn't find one.


Yes - please be more specific. What are the difficulties in building 
and packaging tests when meson is used, as compared to autotools? If 
you need to patch meson build files in systemd source tree, it's 
totally fine to do that.


Alex



Hi Randy & Alex,

For autotools,
1) if the test framework of some package is a standalone set of scripts 
or it could be easily decoupled from Makefile, adding ptest support for 
such package is easy.
2) if the test framework of some package is coupled with Makefile, we 
need to adjust or replace vars in Makefile, install make on target and 
rely on the Makefile to run tests. In such case, adding ptest is not easy.


For meson, the test framework is coupled with meson/ninja. We need to at 
least install ninja and meson on target as a first step. Maybe we need 
to adjust other things in do_install_ptest. That's why I said "there's 
no easy way to add ptest support."


Why didn't I look further into this problem? Because I view ptest 
support as optional, not necessary.
What I thought was: "let's upgrade the package first. If ptest support 
is required from community, deal with that in a separate patch."


ptest is quite important as we move into future. Although here in this 
particular case, where systemd has changed the build system and we are 
doing upgrade at same time, we might consider it, however, it should be 
an important thing to fix before release.




Now that I've got feedback from you, I think I'll look further into this 
issue and try to add ptest support via a separate patch.






Best Regards,
Chen Qi

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-18 Thread ChenQi 

On 03/17/2018 03:27 AM, Alexander Kanavin wrote:

On 03/16/2018 09:30 PM, Randy MacLeod wrote:

This new version has dropped ptest support, as there's no easy
way to do this in the framework of meson.


Are you talking to the meson developers to see if we/they can
come up with a way to do that? Is there an issue opened:
https://github.com/mesonbuild/meson/issues
I didn't find one.


Yes - please be more specific. What are the difficulties in building 
and packaging tests when meson is used, as compared to autotools? If 
you need to patch meson build files in systemd source tree, it's 
totally fine to do that.


Alex



Hi Randy & Alex,

For autotools,
1) if the test framework of some package is a standalone set of scripts 
or it could be easily decoupled from Makefile, adding ptest support for 
such package is easy.
2) if the test framework of some package is coupled with Makefile, we 
need to adjust or replace vars in Makefile, install make on target and 
rely on the Makefile to run tests. In such case, adding ptest is not easy.


For meson, the test framework is coupled with meson/ninja. We need to at 
least install ninja and meson on target as a first step. Maybe we need 
to adjust other things in do_install_ptest. That's why I said "there's 
no easy way to add ptest support."


Why didn't I look further into this problem? Because I view ptest 
support as optional, not necessary.
What I thought was: "let's upgrade the package first. If ptest support 
is required from community, deal with that in a separate patch."


Now that I've got feedback from you, I think I'll look further into this 
issue and try to add ptest support via a separate patch.


Best Regards,
Chen Qi
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-16 Thread Alexander Kanavin 

On 03/16/2018 09:30 PM, Randy MacLeod wrote:

This new version has dropped ptest support, as there's no easy
way to do this in the framework of meson.


Are you talking to the meson developers to see if we/they can
come up with a way to do that? Is there an issue opened:
    https://github.com/mesonbuild/meson/issues
I didn't find one.


Yes - please be more specific. What are the difficulties in building and 
packaging tests when meson is used, as compared to autotools? If you 
need to patch meson build files in systemd source tree, it's totally 
fine to do that.


Alex
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-16 Thread Randy MacLeod 

On 2018-03-12 04:38 AM, Chen Qi wrote:

This new version has dropped ptest support, as there's no easy
way to do this in the framework of meson.


Are you talking to the meson developers to see if we/they can
come up with a way to do that? Is there an issue opened:
   https://github.com/mesonbuild/meson/issues
I didn't find one.

--
# Randy MacLeod.  WR Linux
# Wind River an Intel Company
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-12 Thread ChenQi 

On 03/12/2018 04:52 PM, Maxin B. John wrote:

Hi,

On Mon, Mar 12, 2018 at 04:38:51PM +0800, Chen Qi wrote:

Upgrade systemd to 237.

Note that this version has dropped autotools support.

Very minor nit-picking :

Even with this patch, "systemd_237.bb" and "systemd.inc" contains duplicated

SRC_URI = "git://github.com/systemd/systemd.git;protocol=git"

Probably a good idea to keep it only in "systemd.inc" file.



Hi Maxin,

Thanks for pointing it out.
I've fixed this problem and updated the remote branch.

Best Regards,
Chen Qi


The following patches are rebased:
0004-Use-getenv-when-secure-versions-are-not-available.patch
0005-binfmt-Don-t-install-dependency-links-at-install-tim.patch
0007-use-lnr-wrapper-instead-of-looking-for-relative-opti.patch
0015-Revert-udev-remove-userspace-firmware-loading-suppor.patch
0018-check-for-uchar.h-in-configure.patch
0019-socket-util-don-t-fail-if-libc-doesn-t-support-IDN.patch
0001-add-fallback-parse_printf_format-implementation.patch
0002-src-basic-missing.h-check-for-missing-strndupa.patch
0007-check-for-missing-canonicalize_file_name.patch
0008-Do-not-enable-nss-tests.patch
0010-test-sizeof.c-Disable-tests-for-missing-typedefs-in-.patch
0011-nss-mymachines-Build-conditionally-when-HAVE_MYHOSTN.patch

The following backported patches are dropped:
0001-core-evaluate-presets-after-generators-have-run-6526.patch
0001-main-skip-many-initialization-steps-when-running-in-.patch
0001-meson-update-header-file-to-detect-memfd_create.patch
0003-fileio-include-sys-mman.h.patch

The following patch is dropped as autotools support is dropped:
0002-configure.ac-Check-if-memfd_create-is-already-define.patch

The following patches are newly added to fix problems:
0027-remove-nobody-user-group-checking.patch
0028-add-missing-FTW_-macros-for-musl.patch
0030-fix-missing-of-__register_atfork-for-non-glibc-build.patch
0031-fix-missing-ULONG_LONG_MAX-definition-in-case-of-mus.patch

Best Regards,
Maxin



--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] systemd: upgrade to 237

2018-03-12 Thread Maxin B. John 
Hi,

On Mon, Mar 12, 2018 at 04:38:51PM +0800, Chen Qi wrote:
> Upgrade systemd to 237.
> 
> Note that this version has dropped autotools support.

Very minor nit-picking : 

Even with this patch, "systemd_237.bb" and "systemd.inc" contains duplicated

SRC_URI = "git://github.com/systemd/systemd.git;protocol=git"

Probably a good idea to keep it only in "systemd.inc" file.

> 
> The following patches are rebased:
> 0004-Use-getenv-when-secure-versions-are-not-available.patch
> 0005-binfmt-Don-t-install-dependency-links-at-install-tim.patch
> 0007-use-lnr-wrapper-instead-of-looking-for-relative-opti.patch
> 0015-Revert-udev-remove-userspace-firmware-loading-suppor.patch
> 0018-check-for-uchar.h-in-configure.patch
> 0019-socket-util-don-t-fail-if-libc-doesn-t-support-IDN.patch
> 0001-add-fallback-parse_printf_format-implementation.patch
> 0002-src-basic-missing.h-check-for-missing-strndupa.patch
> 0007-check-for-missing-canonicalize_file_name.patch
> 0008-Do-not-enable-nss-tests.patch
> 0010-test-sizeof.c-Disable-tests-for-missing-typedefs-in-.patch
> 0011-nss-mymachines-Build-conditionally-when-HAVE_MYHOSTN.patch
> 
> The following backported patches are dropped:
> 0001-core-evaluate-presets-after-generators-have-run-6526.patch
> 0001-main-skip-many-initialization-steps-when-running-in-.patch
> 0001-meson-update-header-file-to-detect-memfd_create.patch
> 0003-fileio-include-sys-mman.h.patch
> 
> The following patch is dropped as autotools support is dropped:
> 0002-configure.ac-Check-if-memfd_create-is-already-define.patch
> 
> The following patches are newly added to fix problems:
> 0027-remove-nobody-user-group-checking.patch
> 0028-add-missing-FTW_-macros-for-musl.patch
> 0030-fix-missing-of-__register_atfork-for-non-glibc-build.patch
> 0031-fix-missing-ULONG_LONG_MAX-definition-in-case-of-mus.patch

Best Regards,
Maxin
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core